Re: MLX5 PMD access ring library private data

2023-08-20 Thread Jack Min
On 2023/8/21 14:06, Honnappa Nagarahalli wrote: It would be good if you could fix the email on your side to text format. Comments inline. Seems a wrong setting on my email client. Sorry. *From:* Jack Min *Sent:* Friday, August 18, 2023 8:35 PM *To:* Honnappa Nagarahalli ; Stephen Hemming

RE: MLX5 PMD access ring library private data

2023-08-20 Thread Honnappa Nagarahalli
It would be good if you could fix the email on your side to text format. Comments inline. From: Jack Min Sent: Friday, August 18, 2023 8:35 PM To: Honnappa Nagarahalli ; Stephen Hemminger Cc: dev@dpdk.org; Matan Azrad ; viachesl...@nvidia.com; Tyler Retzlaff ; Wathsala Wathawana Vithanage ;

[RFC] lib/st_ring: add single thread ring

2023-08-20 Thread Honnappa Nagarahalli
Add a single thread safe and multi-thread unsafe ring data structure. This library provides an simple and efficient alternative to multi-thread safe ring when multi-thread safety is not required. Signed-off-by: Honnappa Nagarahalli --- v1: 1) The code is very prelimnary and is not even compiled 2

[PATCH] doc: update 23.07 Intel NICs matching list

2023-08-20 Thread Qiming Yang
Updated i40e and ice match list table. Signed-off-by: Qiming Yang --- doc/guides/nics/i40e.rst | 4 doc/guides/nics/ice.rst | 3 ++- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/doc/guides/nics/i40e.rst b/doc/guides/nics/i40e.rst index 1f5ac25c27..791e9553bc 100644 --- a/d

RE: Ring library optimization idea

2023-08-20 Thread Honnappa Nagarahalli
> -Original Message- > From: Morten Brørup > Sent: Sunday, August 20, 2023 4:24 AM > To: dev@dpdk.org > Cc: Honnappa Nagarahalli ; > konstantin.v.anan...@yandex.ru > Subject: Ring library optimization idea > > Most of the fast path ring library functions access the two cache lines > c

Re: [PATCH v2] bus/pci: fix legacy device IO port map in secondary process

2023-08-20 Thread Stephen Hemminger
On Mon, 21 Aug 2023 09:27:07 +0800 Wenwu Ma wrote: > + struct vfio_device_info device_info = { .argsz = sizeof(device_info) }; > + char pci_addr[PATH_MAX] = {0} Not sure if some tools will complain about initializing chars as zero. Anyway, why bother since you are using it with snprintf.

[PATCH v2] bus/pci: fix legacy device IO port map in secondary process

2023-08-20 Thread Wenwu Ma
When doing IO port mapping for legacy device in secondary process, the region information is missing, so, we need to refill it. Fixes: 4b741542ecde ("bus/pci: avoid depending on private kernel value") Cc: sta...@dpdk.org Signed-off-by: Wenwu Ma --- v2: add release of device in pci_vfio_ioport_u

Re: [RFC PATCH 1/1] Add basic support for code coverage analysis

2023-08-20 Thread Stephen Hemminger
On Tue, 6 Sep 2022 18:43:09 +0200 Felix Moessbauer wrote: > This patch adds basic support to get meaningful > code coverage statistics for some central components. > To keep things simple, we only focus on the parts that are > tested as part of the "fast-tests" suite. > This includes the lib as

Re: [dpdk-dev] [PATCH] app/testpmd: support unequal number of RXQ and TXQ

2023-08-20 Thread Stephen Hemminger
On Wed, 11 Dec 2019 15:56:17 +0530 Jerin Jacob wrote: > > > > > -Original Message- > > > From: dev On Behalf Of Hemant Agrawal > > > Sent: Wednesday, December 11, 2019 5:30 AM > > > To: dev@dpdk.org > > > Cc: Jun Yang > > > Subject: [dpdk-dev] [PATCH] app/testpmd: support unequal numb

[Bug 996] DPDK:20.11.1: net/ena crash while fetching xstats

2023-08-20 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=996 shaib...@amazon.com changed: What|Removed |Added Resolution|--- |FIXED Status|UNCONFIRMED

[PATCH] net/ice: omit IP protocol id from IP/TCP/UDP RSS

2023-08-20 Thread Visa Hankala
Omit the IP protocol id from the IP/TCP/UDP RSS templates so that the hash computation uses only the source and destination addresses, and ports. Otherwise, the hash input set would contain an extra IP protocol id word at the start, giving RSS hashes that do not match the usual 2-tuple and 4-tuple

Ring library optimization idea

2023-08-20 Thread Morten Brørup
Most of the fast path ring library functions access the two cache lines containing respectively the r->prod and r->cons structures. Some of the fast path functions also have to fetch r->capacity and r->mask, which reside in another cache line. What do you think about adding shadow variables of

Bug in non-power-of-2 rings?

2023-08-20 Thread Morten Brørup
Bruce, Honnappa, Konstantin, Back in 2017, Bruce added support for non-power-of-2 rings with this patch [1]. [1]: https://git.dpdk.org/dpdk/commit/lib/librte_ring/rte_ring.h?id=b74461155543430f5253e96ad6d413ebcad36693 I think that the calculation of "entries" in __rte_ring_move_cons_head() [2][