[RFC] ethdev: introduce maximum Rx buffer size

2023-08-07 Thread Huisong Li
The Rx buffer size stands for the size hardware supported to receive packets in one mbuf. The "min_rx_bufsize" is the minimum buffer hardware supported in Rx. Actually, some engines also have the maximum buffer specification, like, hns3. For these engines, the available data size of one mbuf in Rx

Re: [PATCH] telemetry: avoid truncation of strlcpy return before check

2023-08-07 Thread lihuisong (C)
在 2023/8/3 5:21, Tyler Retzlaff 写道: strlcpy returns type size_t when directly assigning to struct rte_tel_data data_len field it may be truncated leading to compromised length check that follows Since the limit in the check is < UINT_MAX the value returned is safe to be cast to unsigned int (w

Re: [PATCH] ethdev: add new symmetric hash function

2023-08-07 Thread fengchengwen
On 2023/8/8 6:32, Ivan Malov wrote: > Hi, > > Please see my notes below. > > On Mon, 7 Aug 2023, Xueming Li wrote: > >> The new symmetric hash function swap src/dst L3 address and >> L4 ports automatically by sorting. >> >> Signed-off-by: Xueming Li >> --- >> lib/ethdev/rte_flow.h | 5 + >>

Re: [PATCH] app/proc-info: remove unnecessary rte_malloc

2023-08-07 Thread fengchengwen
Acked-by: Chengwen Feng On 2023/8/8 4:43, Stephen Hemminger wrote: > Better to use malloc() which is faster and has more error > checking, as is done already for statistics. > > Fixes: 077c546704da ("app/proc_info: add metrics displaying") > Signed-off-by: Stephen Hemminger > --- > app/proc-in

Re: [RFC] ethdev: add group set miss actions API

2023-08-07 Thread Ivan Malov
Hi Tomer, This is a good proposal overall, but it's a bit questionable with regard to the transfer domain and precisely group 0. Say, the user starts a DPDK application and plugs a PF to it, also plugs a representor for a VF. If I'm not mistaken, in this case, default behaviour is hardly "undefi

Re: [PATCH] ethdev: add new symmetric hash function

2023-08-07 Thread Ivan Malov
Hi, Please see my notes below. On Mon, 7 Aug 2023, Xueming Li wrote: The new symmetric hash function swap src/dst L3 address and L4 ports automatically by sorting. Signed-off-by: Xueming Li --- lib/ethdev/rte_flow.h | 5 + 1 file changed, 5 insertions(+) diff --git a/lib/ethdev/rte_flow.

[PATCH] app/proc-info: remove unnecessary rte_malloc

2023-08-07 Thread Stephen Hemminger
Better to use malloc() which is faster and has more error checking, as is done already for statistics. Fixes: 077c546704da ("app/proc_info: add metrics displaying") Signed-off-by: Stephen Hemminger --- app/proc-info/main.c | 20 +--- 1 file changed, 9 insertions(+), 11 deletions(

[RFC] ethdev: add group set miss actions API

2023-08-07 Thread Tomer Shmilovich
Introduce new group set miss actions API: rte_flow_group_set_miss_actions(). A group's miss actions are a set of actions to be performed in case of a miss on a group, i.e. when a packet didn't hit any flow rules in the group. Currently, the expected behavior in this case is undefined. In order to

[PATCH 2/2] app/dma-perf: add PCI device support

2023-08-07 Thread Amit Prakash Shukla
Add support to test performance for "device to memory" and "memory to device" data transfer. Signed-off-by: Amit Prakash Shukla --- app/test-dma-perf/benchmark.c | 67 +++ app/test-dma-perf/config.ini | 37 +++ app/test-dma-perf/main.c | 67 +

[PATCH 1/2] app/dma-perf: skip support in dma-perf application

2023-08-07 Thread Amit Prakash Shukla
Add support to skip running a dma-perf test-case. Signed-off-by: Amit Prakash Shukla --- app/test-dma-perf/config.ini | 2 ++ app/test-dma-perf/main.c | 23 +++ app/test-dma-perf/main.h | 1 + 3 files changed, 26 insertions(+) diff --git a/app/test-dma-perf/config.

RE: [PATCH] ethdev: add new symmetric hash function

2023-08-07 Thread Ori Kam
Hi Xueming, > -Original Message- > From: Xueming(Steven) Li > Sent: Monday, August 7, 2023 2:55 PM > > The new symmetric hash function swap src/dst L3 address and > L4 ports automatically by sorting. > > Signed-off-by: Xueming Li > --- Acked-by: Ori Kam Best, Ori

[PATCH] ethdev: add new symmetric hash function

2023-08-07 Thread Xueming Li
The new symmetric hash function swap src/dst L3 address and L4 ports automatically by sorting. Signed-off-by: Xueming Li --- lib/ethdev/rte_flow.h | 5 + 1 file changed, 5 insertions(+) diff --git a/lib/ethdev/rte_flow.h b/lib/ethdev/rte_flow.h index 86ed98c562..ec6dd170b5 100644 --- a/lib/

Re: [PATCH 4/5] net/hns3: fix TM thread safety risk

2023-08-07 Thread Dongdong Liu
Hi Stephen On 2023/8/5 23:58, Stephen Hemminger wrote: On Sat, 5 Aug 2023 16:36:26 +0800 Dongdong Liu wrote: From: Chengwen Feng The driver-related TM (traffic management) info is implemented through the linked list. The following threads are involved in the read and write of the TM info:

Re: 20.11.9 patches review and test

2023-08-07 Thread Luca Boccassi
On Mon, 7 Aug 2023 at 08:41, Xu, HailinX wrote: > > > -Original Message- > > From: luca.bocca...@gmail.com > > Sent: Saturday, July 29, 2023 7:08 AM > > To: sta...@dpdk.org > > Cc: dev@dpdk.org; Abhishek Marathe ; Ali > > Alnubani ; Walker, Benjamin > > ; David Christensen ; > > Hemant Ag

RE: [EXT] Re: [PATCH v11 0/4] add support for self monitoring

2023-08-07 Thread Tomasz Duszynski
>-Original Message- >From: Thomas Monjalon >Sent: Monday, July 31, 2023 2:33 PM >To: Tomasz Duszynski >Cc: dev@dpdk.org; roret...@linux.microsoft.com; ruifeng.w...@arm.com; >bruce.richard...@intel.com; >Jerin Jacob Kollanukkaran ; mattias.ronnb...@ericsson.com; >m...@smartsharesystems.

RE: [TEST] dpdk/app/test/test_mbuf.c test_refcnt_mbuf instability + fix proposal

2023-08-07 Thread Julien Hascoet
Here is a patch, I let you amend it if needed as I'm a beginner in the dpdk project Thanks De : David Marchand Envoyé : lundi 7 août 2023 09:26 À : Julien Hascoet ; Olivier Matz Cc : dev@dpdk.org Objet : Re: [TEST] dpdk/app/test/test_mbuf.c test_refcnt_mbuf in

RE: 20.11.9 patches review and test

2023-08-07 Thread Xu, HailinX
> -Original Message- > From: luca.bocca...@gmail.com > Sent: Saturday, July 29, 2023 7:08 AM > To: sta...@dpdk.org > Cc: dev@dpdk.org; Abhishek Marathe ; Ali > Alnubani ; Walker, Benjamin > ; David Christensen ; > Hemant Agrawal ; Stokes, Ian > ; Jerin Jacob ; Mcnamara, John > ; Ju-Hyoung

Re: [TEST] dpdk/app/test/test_mbuf.c test_refcnt_mbuf instability + fix proposal

2023-08-07 Thread David Marchand
Hello Julien, On Mon, Aug 7, 2023 at 8:19 AM Julien Hascoet wrote: > from my understanding after debugging, in test_refcnt_iter the return value > of rte_ring_enqueue is not checked; leading to lack of expected mbufs at the > end checks. > > Here is some fix proposal that seems to work after ru

Re: [PATCH v2 2/2] kni: remove deprecated kernel network interface

2023-08-07 Thread David Marchand
On Fri, Aug 4, 2023 at 3:26 PM Bruce Richardson wrote: > > With this removal, there is no remaining out of tree Linux kernel module > > to compile/test in DPDK sources. This means that jobs (like the one in > > UNH lab that was compile-testing KNI against the latest Linux kernel > > sources) can