[PATCH v2] app/test:subprocess synchronization of parameters

2023-07-13 Thread Kaisen You
In meson_test, because the child process does not synchronize the NIC startup parameters of the parent process at startup, it uses all NICs bound by vfio as startup parameters by default, and an exception occurs in the subsequent hugefile check, causing the test to fail. Synchronize the NIC startup

Re: [PATCH 1/1] net/sfc: drop redundant null check from IPv4 flow item parse

2023-07-13 Thread Andrew Rybchenko
On 7/14/23 01:40, Ivan Malov wrote: Such check is already done at an earlier point, in sfc_flow_parse_pattern(), so remove it from IPv4 item parser. Doing so should fix Coverity issue. Coverity issue: 395526 Fixes: f79ce621e963 ("net/sfc: support IPv4 fragment matching in transfer rules") Cc: s

RE: [PATCH v2 0/3] fix Rx and Tx queue status get

2023-07-13 Thread Zhang, Qi Z
> -Original Message- > From: Yang, Qiming > Sent: Wednesday, July 12, 2023 4:32 PM > To: dev@dpdk.org > Cc: Xing, Beilei ; Zhang, Qi Z ; > Yang, Qiming > Subject: [PATCH v2 0/3] fix Rx and Tx queue status get > > Some Intel drivers not support queue start/stop ops, it will caused > ap

Re: Fwd: |FAILURE| pw129411-129407 [PATCH] [v16,6/6] test/memarea: support du

2023-07-13 Thread fengchengwen
Hi Tyler, Thanks for your reply, I will try work it out on your tips. Thanks On 2023/7/14 0:23, Tyler Retzlaff wrote: > On Thu, Jul 13, 2023 at 08:08:27PM +0800, fengchengwen wrote: >> Hi Microsoft guys, >> >> The unit-testing [1] show memarea_autotest has following error: > > there isn't rea

[PATCH 1/1] net/sfc: drop redundant null check from IPv4 flow item parse

2023-07-13 Thread Ivan Malov
Such check is already done at an earlier point, in sfc_flow_parse_pattern(), so remove it from IPv4 item parser. Doing so should fix Coverity issue. Coverity issue: 395526 Fixes: f79ce621e963 ("net/sfc: support IPv4 fragment matching in transfer rules") Cc: sta...@dpdk.org Signed-off-by: Ivan Ma

Re: [PATCH] doc: update compatible firmware version for bnxt

2023-07-13 Thread Ajit Khaparde
On Thu, Jul 13, 2023 at 9:58 AM Ajit Khaparde wrote: > > Update earliest supported firmware version for 22.11 release. > > Signed-off-by: Ajit Khaparde Patch applied to dpdk-next-net-brcm. > --- > doc/guides/nics/bnxt.rst | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/doc/guides/nics/

[PATCH] doc: update compatible firmware version for bnxt

2023-07-13 Thread Ajit Khaparde
Update earliest supported firmware version for 22.11 release. Signed-off-by: Ajit Khaparde --- doc/guides/nics/bnxt.rst | 1 + 1 file changed, 1 insertion(+) diff --git a/doc/guides/nics/bnxt.rst b/doc/guides/nics/bnxt.rst index 0b09b0c50a..806288d495 100644 --- a/doc/guides/nics/bnxt.rst +++ b

[PATCH v7 0/1] Add DTS smoke tests

2023-07-13 Thread jspewock
From: Jeremy Spewock Removed the commit for adding paramiko as a dependency because it is now covered by installing Fabric. RFCs for this patch: * v3: https://mails.dpdk.org/archives/dev/2023-June/269859.html * v2: https://mails.dpdk.org/archives/dev/2023-May/267915.html * v1: https://mails.dpdk

[PATCH v7 1/1] dts: add smoke tests

2023-07-13 Thread jspewock
From: Jeremy Spewock Adds a new test suite for running smoke tests that verify general configuration aspects of the system under test. If any of these tests fail, the DTS execution terminates as part of a "fail-fast" model. Signed-off-by: Jeremy Spewock --- dts/conf.yaml

RE: [PATCH] doc: fix typos and wording in flow API guide

2023-07-13 Thread Mcnamara, John
> -Original Message- > From: Ali Alnubani > Sent: Monday, July 3, 2023 8:58 AM > To: dev@dpdk.org > Cc: Doherty, Declan ; sta...@dpdk.org > Subject: [PATCH] doc: fix typos and wording in flow API guide > > This fixes typos, punctuation and wording in the rte flow API guide. > > Fixes:

Re: Fwd: |FAILURE| pw129411-129407 [PATCH] [v16,6/6] test/memarea: support du

2023-07-13 Thread Tyler Retzlaff
On Thu, Jul 13, 2023 at 08:08:27PM +0800, fengchengwen wrote: > Hi Microsoft guys, > > The unit-testing [1] show memarea_autotest has following error: there isn't really anything here other than the test failed. i see this test intermittently fail on both ubuntu and windows in my lab. the times i

Re: [PATCH v6 2/2] dts: add paramiko to dependencies

2023-07-13 Thread Jeremy Spewock
On Thu, Jul 13, 2023 at 12:06 PM Juraj Linkeš wrote: > On Thu, Jul 13, 2023 at 5:23 PM wrote: > > > > From: Jeremy Spewock > > > > added paramiko to the dependency files > > > > Signed-off-by: Jeremy Spewock > > --- > > dts/poetry.lock| 137 +++-- >

Re: [PATCH v6 2/2] dts: add paramiko to dependencies

2023-07-13 Thread Juraj Linkeš
On Thu, Jul 13, 2023 at 5:23 PM wrote: > > From: Jeremy Spewock > > added paramiko to the dependency files > > Signed-off-by: Jeremy Spewock > --- > dts/poetry.lock| 137 +++-- > dts/pyproject.toml | 1 + > 2 files changed, 82 insertions(+), 56 dele

Re: [PATCH v3 0/2] vduse: TSO & vIOMMU fixes

2023-07-13 Thread Maxime Coquelin
On 7/13/23 15:52, Maxime Coquelin wrote: This series contains two patches to fix TSO support and enable vIOMMU by default as it is required by VDUSE. Changes in v3: == - Ensure async copy cannot be enabled with VDUSE (Kevin) Changes in v2: == - Fix typo in commit mess

[PATCH v6 2/2] dts: add paramiko to dependencies

2023-07-13 Thread jspewock
From: Jeremy Spewock added paramiko to the dependency files Signed-off-by: Jeremy Spewock --- dts/poetry.lock| 137 +++-- dts/pyproject.toml | 1 + 2 files changed, 82 insertions(+), 56 deletions(-) diff --git a/dts/poetry.lock b/dts/poetry.lock i

[PATCH v6 1/2] dts: add smoke tests

2023-07-13 Thread jspewock
From: Jeremy Spewock Adds a new test suite for running smoke tests that verify general configuration aspects of the system under test. If any of these tests fail, the DTS execution terminates as part of a "fail-fast" model. Signed-off-by: Jeremy Spewock --- dts/conf.yaml

[PATCH v6 0/2] Add DTS smoke tests

2023-07-13 Thread jspewock
From: Jeremy Spewock Updates previous patch so that it applies over the latest git tree. RFCs for this patch: * v3: https://mails.dpdk.org/archives/dev/2023-June/269859.html * v2: https://mails.dpdk.org/archives/dev/2023-May/267915.html * v1: https://mails.dpdk.org/archives/dev/2023-April/266580

Re: [PATCH v3 2/2] vhost: force vIOMMU enablement with VDUSE

2023-07-13 Thread Kevin Traynor
On 13/07/2023 14:52, Maxime Coquelin wrote: Unlike Vhost-user, VDUSE requires vIOMMU support. This patch ignores whether RTE_VHOST_USER_IOMMU_SUPPORT flag is passed at register time to avoid having application to pass it for having working VDUSE device creation. Fixes: 0adb8eccc6a6 ("vhost: add

Re: [PATCH v3 1/2] vhost: fix net offload compliance

2023-07-13 Thread Kevin Traynor
On 13/07/2023 14:52, Maxime Coquelin wrote: Initial VDUSE support assumed the application always used the net offload compliant mode, which is not the case for OVS. This patch propagates the value set by the application. Fixes: 0adb8eccc6a6 ("vhost: add VDUSE device creation and destruction")

[PATCH v3 2/2] vhost: force vIOMMU enablement with VDUSE

2023-07-13 Thread Maxime Coquelin
Unlike Vhost-user, VDUSE requires vIOMMU support. This patch ignores whether RTE_VHOST_USER_IOMMU_SUPPORT flag is passed at register time to avoid having application to pass it for having working VDUSE device creation. Fixes: 0adb8eccc6a6 ("vhost: add VDUSE device creation and destruction") Signe

[PATCH v3 1/2] vhost: fix net offload compliance

2023-07-13 Thread Maxime Coquelin
Initial VDUSE support assumed the application always used the net offload compliant mode, which is not the case for OVS. This patch propagates the value set by the application. Fixes: 0adb8eccc6a6 ("vhost: add VDUSE device creation and destruction") Signed-off-by: Maxime Coquelin --- lib/vhost

[PATCH v3 0/2] vduse: TSO & vIOMMU fixes

2023-07-13 Thread Maxime Coquelin
This series contains two patches to fix TSO support and enable vIOMMU by default as it is required by VDUSE. Changes in v3: == - Ensure async copy cannot be enabled with VDUSE (Kevin) Changes in v2: == - Fix typo in commit message - Fix build when VDUSE is not supported by

Re: [PATCH v2 2/2] vhost: force vIOMMU enablement with VDUSE

2023-07-13 Thread Maxime Coquelin
On 7/13/23 14:47, Kevin Traynor wrote: On 13/07/2023 12:29, Maxime Coquelin wrote: Unlike Vhost-user, VDUSE requires vIOMMU support. This patch ignores whether RTE_VHOST_USER_IOMMU_SUPPORT flag is passed at register time to avoid having application to pass it for having working VDUSE device c

RE: [PATCH] doc: announce ethdev operation struct changes

2023-07-13 Thread Morten Brørup
> From: Feifei Wang [mailto:feifei.wa...@arm.com] > Sent: Thursday, 13 July 2023 04.37 > > > From: Feifei Wang > > Sent: Tuesday, July 4, 2023 4:17 PM > > > > > From: Feifei Wang > > > Sent: Tuesday, July 4, 2023 4:10 PM > > > > > > To support mbufs recycle mode, announce the coming ABI changes f

Re: [PATCH v2 2/2] vhost: force vIOMMU enablement with VDUSE

2023-07-13 Thread Kevin Traynor
On 13/07/2023 12:29, Maxime Coquelin wrote: Unlike Vhost-user, VDUSE requires vIOMMU support. This patch ignores whether RTE_VHOST_USER_IOMMU_SUPPORT flag is passed at register time to avoid having application to pass it for having working VDUSE device creation. Fixes: 0adb8eccc6a6 ("vhost: add

Re: [PATCH v2] net/mlx5: fix lro update tcp header cksum error

2023-07-13 Thread Thomas Monjalon
Any comment on this patch? 13/04/2023 02:57, jiangheng (G): > The variable csum is the sum of three 16 bits integers, the max value > is 0x2FFFD. The corner case of sum of 3 is 0x1 gives the wrong > result: 0x1 + 0x = 0x1, the upper 16 bits are not 0. > It must be folded again to ensur

Fwd: |FAILURE| pw129411-129407 [PATCH] [v16,6/6] test/memarea: support du

2023-07-13 Thread fengchengwen
Hi Microsoft guys, The unit-testing [1] show memarea_autotest has following error: 43/93 DPDK:fast-tests / memarea_autotest FAIL 0.15s (exit status 3221226356 or signal 3221226228 SIGinvalid) >>> MALLOC_PERTURB_=139 DPDK_TEST=memarea_autotest >>> C:\Users\builder\jen

[PATCH v2 2/2] vhost: force vIOMMU enablement with VDUSE

2023-07-13 Thread Maxime Coquelin
Unlike Vhost-user, VDUSE requires vIOMMU support. This patch ignores whether RTE_VHOST_USER_IOMMU_SUPPORT flag is passed at register time to avoid having application to pass it for having working VDUSE device creation. Fixes: 0adb8eccc6a6 ("vhost: add VDUSE device creation and destruction") Signe

[PATCH v2 1/2] vhost: fix net offload compliance

2023-07-13 Thread Maxime Coquelin
Initial VDUSE support assumed the application always used the net offload compliant mode, which is not the case for OVS. This patch propagates the value set by the application. Fixes: 0adb8eccc6a6 ("vhost: add VDUSE device creation and destruction") Signed-off-by: Maxime Coquelin --- lib/vhost

[PATCH v2 0/2] vduse: TSO & vIOMMU fixes

2023-07-13 Thread Maxime Coquelin
This series contains two patches to fix TSO support and enable vIOMMU by default as it is required by VDUSE. Changes in v2: == - Fix typo in commit message - Fix build when VDUSE is not supported by the Kernel (0-day robot) Maxime Coquelin (2): vhost: fix net offload compliance vh

[PATCH v2] net/mlx5: fix the drop action memory leak

2023-07-13 Thread Bing Zhao
In DV mode, when quitting an application, the default drop action and its resources should be released. The Devx action for the TIR was not destroyed and it would cause 80B memory leak. With this commit, in DV mode, the action should be destroyed in the mlx5_devx_drop_action_destroy() explicitly.

[PATCH] net/mlx5: fix the drop action memory leak

2023-07-13 Thread Bing Zhao
In DV mode, when quitting an application, the default drop action and its resources should be released. The Devx action for the TIR was not destroyed and it would cause 80B memory leak. With this commit, in DV mode, the action should be destroyed in the mlx5_devx_drop_action_destroy() explicitly.

Re: [PATCH] doc: deprecation notice to add callback data to rte_event_fp_ops

2023-07-13 Thread Jerin Jacob
On Thu, Jul 13, 2023 at 4:08 PM Tummala, Sivaprasad wrote: > > [AMD Official Use Only - General] > > Hi Jerin, > > > -Original Message- > > From: Jerin Jacob > > Sent: Thursday, July 13, 2023 2:22 PM > > To: Tummala, Sivaprasad > > Cc: dev@dpdk.org; Yigit, Ferruh ; > > bruce.richard...@i

RE: [PATCH] doc: deprecation notice to add callback data to rte_event_fp_ops

2023-07-13 Thread Tummala, Sivaprasad
[AMD Official Use Only - General] Hi Jerin, > -Original Message- > From: Jerin Jacob > Sent: Thursday, July 13, 2023 2:22 PM > To: Tummala, Sivaprasad > Cc: dev@dpdk.org; Yigit, Ferruh ; > bruce.richard...@intel.com; david.march...@redhat.com; tho...@monjalon.net > Subject: Re: [PATCH]

[PATCH 1/2] vhost: fix net offload compliancy

2023-07-13 Thread Maxime Coquelin
Initial VDUSE support assumed the application always used the net offload compliant mode, which is not the case for OVS. This patch propagates the value set by the application. Fixes: 0adb8eccc6a6 ("vhost: add VDUSE device creation and destruction") Signed-off-by: Maxime Coquelin --- lib/vhost

[PATCH 0/2] vduse: TSO & vIOMMU fixes

2023-07-13 Thread Maxime Coquelin
This series contains two patches to fix TSO support and enable vIOMMU by default as it is required by VDUSE. Maxime Coquelin (2): vhost: fix net offload compliancy vhost: force vIOMMU enablement with VDUSE lib/vhost/socket.c | 9 ++--- lib/vhost/vduse.c | 4 ++-- lib/vhost/vduse.h | 2

[PATCH 2/2] vhost: force vIOMMU enablement with VDUSE

2023-07-13 Thread Maxime Coquelin
Unlike Vhost-user, VDUSE requires vIOMMU support. This patch ignores whether RTE_VHOST_USER_IOMMU_SUPPORT flag is passed at register time to avoid having application to pass it for having working VDUSE device creation. Fixes: 0adb8eccc6a6 ("vhost: add VDUSE device creation and destruction") Signe

RE: [PATCH v2] common/iavf: fix hw mac type for 710 NIC

2023-07-13 Thread Zhang, Qi Z
> -Original Message- > From: Wenjing Qiao > Sent: Wednesday, July 12, 2023 3:38 PM > To: Wu, Jingjing ; Xing, Beilei > Cc: dev@dpdk.org; Qiao, Wenjing ; > sta...@dpdk.org > Subject: [PATCH v2] common/iavf: fix hw mac type for 710 NIC > > Fix hw mac type according to PCI ID list. > >

RE: [PATCH] net/iavf: fix the order of closing Rx queue

2023-07-13 Thread Zhang, Qi Z
> -Original Message- > From: Zeng, ZhichaoX > Sent: Wednesday, July 12, 2023 1:36 PM > To: dev@dpdk.org > Cc: sta...@dpdk.org; Zhang, Qi Z ; Staszewski, BartoszX > ; Zeng, ZhichaoX ; > Wu, Jingjing ; Xing, Beilei ; > Ferruh Yigit ; Rong, Leyi > Subject: [PATCH] net/iavf: fix the order

RE: [PATCH] net/i40e: fix comments

2023-07-13 Thread Zhang, Qi Z
> -Original Message- > From: Jieqiang Wang > Sent: Wednesday, July 12, 2023 6:08 PM > To: Thomas Monjalon ; Zhang, Yuying > ; Xing, Beilei ; David > Christensen ; Ruifeng Wang > ; Richardson, Bruce ; > Konstantin Ananyev ; Jeff Guo > ; Morten Brørup ; Zhang, > Qi Z > Cc: dev@dpdk.org;

Re: [PATCH] doc: deprecation notice to add callback data to rte_event_fp_ops

2023-07-13 Thread Jerin Jacob
On Wed, Jul 12, 2023 at 11:01 PM Sivaprasad Tummala wrote: > > Deprecation notice to add "rte_eventdev_port_data" field to Could you share the rational for why rte_eventdev_port_data needs to be added? > ``rte_event_fp_ops`` for callback support. > > Signed-off-by: Sivaprasad Tummala > --- >

Re: [PATCH] net/nfp: fix invalid control message packets

2023-07-13 Thread Ferruh Yigit
On 7/13/2023 4:02 AM, Chaoyong He wrote: > From: Long Wu > > If we add two cards that uses flower firmware into one dpdk-testpmd, > NFP PMD will printf error log. The reason is that the second card > uses the control VNIC Rx queue of the first card. > > Because rte_eth_dma_zone_reserve() will re

Re: [PATCH] doc: announce inclusive naming macro name changes

2023-07-13 Thread Ferruh Yigit
On 6/7/2023 3:44 AM, Chaoyong He wrote: > From: Long Wu > > In order to support inclusive naming, some of the macro in DPDK will > need to be renamed. Do this through deprecation process now for 23.07. > > Signed-off-by: Long Wu > Reviewed-by: Chaoyong He > --- > Depends-on: patch-127084 ("doc

Re: [PATCH] doc: announce ethdev operation struct changes

2023-07-13 Thread Ferruh Yigit
On 7/5/2023 12:32 PM, Konstantin Ananyev wrote: > 04/07/2023 09:10, Feifei Wang пишет: >> To support mbufs recycle mode, announce the coming ABI changes >> from DPDK 23.11. >> >> Signed-off-by: Feifei Wang >> Reviewed-by: Ruifeng Wang >> --- >>   doc/guides/rel_notes/deprecation.rst | 4 >>