[PATCH v2] bus/cdx: provide driver flag for optional resource mapping

2023-07-04 Thread Abhijit Gangurde
Provide driver flag which gives an option to map the cdx device resource before probing the device driver. Also, make rte_cdx_map_device() API as public to map device resource separately. Signed-off-by: Abhijit Gangurde --- v2: - Corrected _RTE_BUS_CDX_H_ to RTE_BUS_CDX_H - Improved code comme

[PATCH] doc: update iavf feature list

2023-07-04 Thread Zhichao Zeng
The iavf supports timestamp offload on vector path. Signed-off-by: Zhichao Zeng --- doc/guides/nics/features/iavf.ini | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/guides/nics/features/iavf.ini b/doc/guides/nics/features/iavf.ini index 55a02165a0..b72cd98484 100644 ---

Re: [PATCH v2] app/testpmd: fix invalid queue ID when start port

2023-07-04 Thread lihuisong (C)
在 2023/7/4 18:59, Ferruh Yigit 写道: On 7/4/2023 9:45 AM, Jie Hai wrote: Function update_queue_state updates queue state of all queues of all ports, using the queue num nb_rxq|nb_txq stored locally by testpmd. An error on the invalid queue ID occurs if we run testpmd with two ports and detach-at

RE: [PATCH] doc: fix missing release note for GVE PMD DQO

2023-07-04 Thread Guo, Junfeng
> -Original Message- > From: Ferruh Yigit > Sent: Tuesday, July 4, 2023 19:33 > To: Rushil Gupta ; Guo, Junfeng > > Cc: Zhang, Qi Z ; dev@dpdk.org; > joshw...@google.com; jeroe...@google.com > Subject: Re: [PATCH] doc: fix missing release note for GVE PMD DQO > > On 7/3/2023 6:34 PM, R

[PATCH v3] graph: fix graph model check in core binding

2023-07-04 Thread Zhirun Yan
Fix graph model check in core binding with graph. And rte_graph_clone() need to use valid params rather than NULL pointer. Update release notes for new mcore dispatch model. Fixes: ecb22a294980 ("graph: introduce graph bind unbind API") Fixes: 67e2303cd823 ("test/graph: add functional tests for mc

[Bug 1235] [dpdk-23.07]basic_4k_pages_cbdma: start dpdk-testpmd with `--no-huge ` parameters failed and prompt 'No probed ethernet devices'

2023-07-04 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1235 lingwei (weix.l...@intel.com) changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|---

Re: [PATCH v3] eal: fix prompt info when remap_segment failed

2023-07-04 Thread fengchengwen
This is bugfix, suggest add Cc. With above add, Acked-by: Chengwen Feng On 2023/7/4 20:17, Fengnan Chang wrote: > When there is not enough space to memsegs, we should prompt > which configuration should be modified instead of printing > some numbers. > > Signed-off-by: Fengnan Chang > --- > l

RE: [PATCH v2] graph: fix graph model check in core binding

2023-07-04 Thread Yan, Zhirun
> -Original Message- > From: Jerin Jacob > Sent: Tuesday, July 4, 2023 5:10 PM > To: Yan, Zhirun > Cc: dev@dpdk.org; jer...@marvell.com; kirankum...@marvell.com; > ndabilpu...@marvell.com; Fu, Qi > Subject: Re: [PATCH v2] graph: fix graph model check in core binding > > On Mon, Jul 3,

Re: [PATCH] cryptodev: fix device socket ID type

2023-07-04 Thread Ji, Kai
Acked-by: Kai Ji mailto:kai...@intel.com>> From: Power, Ciara Sent: 29 June 2023 14:21 To: dev@dpdk.org Cc: Ji, Kai ; Power, Ciara ; Matz, Olivier ; Akhil Goyal ; Fan Zhang Subject: [PATCH] cryptodev: fix device socket ID type The socket ID field for a cryptod

Re: [PATCH] drivers/ipsec_mb: fix aesni_mb set session ID

2023-07-04 Thread Ji, Kai
Acked-by: Kai Ji mailto:kai...@intel.com>> From: Power, Ciara Sent: 30 June 2023 09:34 To: dev@dpdk.org Cc: Ji, Kai ; Power, Ciara ; De Lara Guarch, Pablo Subject: [PATCH] drivers/ipsec_mb: fix aesni_mb set session ID In the case of multiprocess, when the same

RE: [PATCH v2] eal: avoid issues in macro expansion of alignment

2023-07-04 Thread Morten Brørup
> From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Tuesday, 4 July 2023 18.01 > > On Tue, 4 Jul 2023 10:43:40 +0200 > Morten Brørup wrote: > > > > From: Stephen Hemminger [mailto:step...@networkplumber.org] > > > Sent: Tuesday, 4 July 2023 01.24 > > > > > > RTE_ALIGN_MUL_NEAR

[PATCH] service: avoid worker lcore exit deadlock

2023-07-04 Thread Mattias Rönnblom
Calling rte_exit() from a worker lcore thread causes a deadlock in rte_service_finalize(). This patch makes rte_service_finalize() deadlock-free by avoiding the need to synchronize with service lcore threads, which in turn is achieved by moving service and per-lcore state from the heap to being st

[PATCH v2] pcap: support MTU set

2023-07-04 Thread Stephen Hemminger
Support rte_eth_dev_set_mtu for pcap driver when the pcap device is convigured to point to a network interface. This is rebased an consolidated from earlier version. Added support for FreeBSD. Signed-off-by: Ido Goshen Signed-off-by: Stephen Hemminger --- v2 - fix FreeBSD part drivers/net/pca

[PATCH] doc: announce deprecation for security ops

2023-07-04 Thread Akhil Goyal
Structure rte_security_ops and rte_security_ctx are meant to be used by rte_security library and the PMDs associated. These will be moved to an internal header in DPDK 23.11 release. Signed-off-by: Akhil Goyal --- doc/guides/rel_notes/deprecation.rst | 3 +++ 1 file changed, 3 insertions(+) dif

Re: [PATCH] eal/interrupts: Allow UIO interrupts when using igb_uio

2023-07-04 Thread Vladimir Ratnikov
On systems with I225 interfaces it works in interrupt mode(rx), so not only LSE interrupts are supported. I could try add rte_intr_cap_single functionality and recheck it twice(if several interfaces works in rx_mode=interrupt) But actually it worked with changes above(CPU utilization close to the

[PATCH] pcap: support MTU set

2023-07-04 Thread Stephen Hemminger
Support rte_eth_dev_set_mtu for pcap driver when the pcap device is convigured to point to a network interface. This is rebased an consolidated from earlier version. Added support for FreeBSD. Signed-off-by: Ido Goshen Signed-off-by: Stephen Hemminger --- drivers/net/pcap/pcap_ethdev.c

[Bug 961] PCAP PMD receives packets larger then MTU

2023-07-04 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=961 Stephen Hemminger (step...@networkplumber.org) changed: What|Removed |Added CC||step...@networkplu

Re: [PATCH] vfio: do not coalesce DMA mappings

2023-07-04 Thread Gupta, Nipun
On 7/4/2023 8:41 PM, Ding, Xuan wrote: Hi Nipun, -Original Message- From: Gupta, Nipun Sent: Tuesday, July 4, 2023 5:23 PM To: Ding, Xuan ; dev@dpdk.org; tho...@monjalon.net; Burakov, Anatoly ; Yigit, Ferruh ; David Marchand Cc: Agarwal, Nikhil ; He, Xingguang ; Ling, WeiX Subject

Re: [PATCH] vfio: do not coalesce DMA mappings

2023-07-04 Thread Gupta, Nipun
On 7/4/2023 7:39 PM, Thomas Monjalon wrote: 04/07/2023 11:23, Gupta, Nipun: On 7/4/2023 1:36 PM, Ding, Xuan wrote: From: Gupta, Nipun From: Ding, Xuan From: Ding, Xuan From: Nipun Gupta Hi Xuan, Thanks for pointing out the issue and figuring out the patch which introduced this. If yo

[v3 5/5] net/mlx5/hws: support default miss action on FDB

2023-07-04 Thread Itamar Gozlan
From: Alex Vesker Add the support for default miss on HWS FDB, this implementation was missing until now. Default miss can be used for more efficient miss flow instead of going to an empty matcher or some defecated empty table. Signed-off-by: Alex Vesker Acked-by: Matan Azrad --- drivers/net/

[v3 4/5] net/mlx5/hws: renaming FT to TBL

2023-07-04 Thread Itamar Gozlan
An action naming change is made to describe the action better and avoid implicit meaning. Signed-off-by: Itamar Gozlan Acked-by: Matan Azrad --- drivers/net/mlx5/hws/mlx5dr.h| 2 +- drivers/net/mlx5/hws/mlx5dr_action.c | 16 drivers/net/mlx5/hws/mlx5dr_debug.c | 2 +-

[v3 3/5] net/mlx5/hws: remove duplicated reformat type

2023-07-04 Thread Itamar Gozlan
From: Shun Hao Currently there are two enum definitions for reformat type: mlx5dr_action_reformat_type and mlx5dr_action_type. They are actually the same. This patch remove the unnecessary mlx5dr_action_reformat_type so use only one definition for reformat type. Signed-off-by: Shun Hao Acked-by

[v3 2/5] net/mlx5/hws: allow destroying rule resources on error

2023-07-04 Thread Itamar Gozlan
From: Alex Vesker In case the send engine is in error state API should provide a way to free rule resources and provide a fake completion. Otherwise there is no way to release these resources. Signed-off-by: Alex Vesker Acked-by: Matan Azrad --- drivers/net/mlx5/hws/mlx5dr_rule.c | 10 +--

[v3 1/5] net/mlx5/hws: remove unneeded new line for DR_LOG

2023-07-04 Thread Itamar Gozlan
From: Alex Vesker In some places an extra new line was added, remove to have clean prints. Signed-off-by: Alex Vesker Acked-by: Matan Azrad --- v1 -> v3 (1) amending a wrong subject prefix send (v1 instead of v3). (2) typo fix (uneeded -> unneeded) v2->v3 1. Right patches instead of wrong patc

Re: [dpdk-dev] [PATCH v3 1/2] eal: fix side effects in align mul macros

2023-07-04 Thread Stephen Hemminger
On Tue, 11 May 2021 01:10:06 +0530 wrote: > Avoid expanding parameters inside the macro multiple times. > For example: > RTE_ALIGN_MUL_NEAR(rte_rdtsc() - start, CYC_PER_10MHZ); > Here rte_rdtsc() call is expanded multiple times in the macro > causing it to return different values that leads

Re: [PATCH v2] eal: avoid issues in macro expansion of alignment

2023-07-04 Thread Stephen Hemminger
On Tue, 4 Jul 2023 10:43:40 +0200 Morten Brørup wrote: > > From: Stephen Hemminger [mailto:step...@networkplumber.org] > > Sent: Tuesday, 4 July 2023 01.24 > > > > RTE_ALIGN_MUL_NEAR is a macro so the cycle argument could > > get evaluated twice causing some potential skew. Fix by > > computing

Re: [PATCH] eal/interrupts: Allow UIO interrupts when using igb_uio

2023-07-04 Thread Stephen Hemminger
On Tue, 4 Jul 2023 12:45:54 +0200 Vladimir Ratnikov wrote: > Sorry for a long reply, sure. > > Stephen, > am I right that the most concern is about a place where interrupt > capabilities check appears for non MSI-X support? > What if having dedicated rte_intr_cap_single analog when there's no su

RE: [PATCH] net/mlx5: forbid MPRQ restart

2023-07-04 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Alexander Kozyrev > Sent: Tuesday, July 4, 2023 12:22 AM > To: dev@dpdk.org > Cc: Matan Azrad ; Raslan Darawsheh > ; Slava Ovsiienko ; > sta...@dpdk.org > Subject: [PATCH] net/mlx5: forbid MPRQ restart > > The queue restart is only supported by the non-ve

RE: [PATCH] vfio: do not coalesce DMA mappings

2023-07-04 Thread Ding, Xuan
Hi Nipun, > -Original Message- > From: Gupta, Nipun > Sent: Tuesday, July 4, 2023 5:23 PM > To: Ding, Xuan ; dev@dpdk.org; tho...@monjalon.net; > Burakov, Anatoly ; Yigit, Ferruh > ; David Marchand > Cc: Agarwal, Nikhil ; He, Xingguang > ; Ling, WeiX > Subject: Re: [PATCH] vfio: do not

Re: [PATCH V2 2/2] app/testpmd: assign custom ID to flow rules

2023-07-04 Thread Ferruh Yigit
On 7/4/2023 9:25 AM, Ori Kam wrote: > > >> -Original Message- >> From: Gregory Etelson >> Subject: [PATCH V2 2/2] app/testpmd: assign custom ID to flow rules >> >> From: Eli Britstein >> >> Upon creation of a flow, testpmd assigns it a flow ID. Later, the >> flow ID is used for flow ope

Re: [PATCH v4 3/3] ring: add telemetry cmd for ring info

2023-07-04 Thread Thomas Monjalon
04/07/2023 10:04, Jie Hai: > On 2023/6/20 22:34, Thomas Monjalon wrote: > > 20/06/2023 10:14, Jie Hai: > >> On 2023/2/20 20:55, David Marchand wrote: > >>> On Fri, Feb 10, 2023 at 3:50 AM Jie Hai wrote: > > This patch supports dump of ring information by its name. > An example using

[Bug 1260] Querying timer adapter events through dpdk-telemetry crashes DPDK applications

2023-07-04 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1260 Bug ID: 1260 Summary: Querying timer adapter events through dpdk-telemetry crashes DPDK applications Product: DPDK Version: 22.11 Hardware: All OS: All

Re: [PATCH] vfio: do not coalesce DMA mappings

2023-07-04 Thread Thomas Monjalon
04/07/2023 11:23, Gupta, Nipun: > On 7/4/2023 1:36 PM, Ding, Xuan wrote: >> From: Gupta, Nipun >>> From: Ding, Xuan From: Ding, Xuan > From: Nipun Gupta > > Hi Xuan, > > > > Thanks for pointing out the issue and figuring out the patch which > > introduced this. If you ha

Re: [PATCH] doc: fix typos and wording in flow API guide

2023-07-04 Thread Ferruh Yigit
On 7/3/2023 8:58 AM, Ali Alnubani wrote: > This fixes typos, punctuation and wording in the rte flow API guide. > > Fixes: 2f82d143fb31 ("ethdev: add group jump action") > Cc: declan.dohe...@intel.com > Cc: sta...@dpdk.org > > Signed-off-by: Ali Alnubani > --- > doc/guides/prog_guide/rte_flow.r

Re: [dpdk-dev] [PATCH v2 1/1] vfio: add page-by-page mapping API

2023-07-04 Thread Burakov, Anatoly
On 7/4/2023 12:48 AM, Stephen Hemminger wrote: On Thu, 2 Jun 2022 10:23:07 +0200 David Marchand wrote: Hello Anatoly, On Tue, Nov 2, 2021 at 4:54 PM Burakov, Anatoly wrote: On 28-Oct-21 3:09 PM, Anatoly Burakov wrote: Currently, there is no way to map memory for DMA in a way that allows u

Re: [PATCH v3] eal: fix prompt info when remap_segment failed

2023-07-04 Thread Burakov, Anatoly
On 7/4/2023 1:17 PM, Fengnan Chang wrote: When there is not enough space to memsegs, we should prompt which configuration should be modified instead of printing some numbers. Signed-off-by: Fengnan Chang --- Acked-by: Anatoly Burakov -- Thanks, Anatoly

[PATCH v3] eal: fix prompt info when remap_segment failed

2023-07-04 Thread Fengnan Chang
When there is not enough space to memsegs, we should prompt which configuration should be modified instead of printing some numbers. Signed-off-by: Fengnan Chang --- lib/eal/common/eal_common_dynmem.c | 6 ++ lib/eal/freebsd/eal_memory.c | 8 +++- lib/eal/linux/eal_memory.c

Re: [PATCH v2] eal: add notes to SMP memory barrier APIs

2023-07-04 Thread Mattias Rönnblom
On 2023-07-03 09:02, Ruifeng Wang wrote: -Original Message- From: Mattias Rönnblom Sent: Friday, June 30, 2023 3:44 AM To: Ruifeng Wang ; tho...@monjalon.net; david.march...@redhat.com Cc: dev@dpdk.org; roret...@linux.microsoft.com; konstantin.v.anan...@yandex.ru; Honnappa Nagarahalli

Re: [RFC] eventdev: remove single-event enqueue operation

2023-07-04 Thread Mattias Rönnblom
On 2023-06-30 06:37, Jerin Jacob wrote: On Fri, Jun 9, 2023 at 11:18 PM Mattias Rönnblom wrote: Eliminate non-burst enqueue operation from Eventdev. The effect of this change is to reduce Eventdev code complexity somewhat and slightly improve performance. The single-event enqueue shortcut pr

[PATCH] eventdev: remove single-event enqueue operation

2023-07-04 Thread Mattias Rönnblom
Eliminate non-burst enqueue operation from Eventdev. The effect of this change is to reduce Eventdev code complexity somewhat and slightly improve performance. The single-event enqueue shortcut provided a very minor performance advantage in some situations (e.g., with a compile time-constant burs

Re: [PATCH] doc: fix missing release note for GVE PMD DQO

2023-07-04 Thread Ferruh Yigit
On 7/3/2023 6:34 PM, Rushil Gupta wrote: > On Sun, Jul 2, 2023 at 8:00 PM Junfeng Guo wrote: >> >> Add missing release note for GVE PMD enabling for DQO queue format. >> >> Fixes: a14d391c7d99 ("net/gve: add Tx queue setup for DQO") >> >> Signed-off-by: Junfeng Guo >> --- >> doc/guides/rel_notes

Re: [PATCH] bus/cdx: provide driver flag for optional resource mapping

2023-07-04 Thread Gupta, Nipun
On 6/26/2023 4:09 PM, Abhijit Gangurde wrote: Provide driver flag which gives an option to map the cdx device resource before probing the device driver. Also, make rte_cdx_map_device() API as public to map device resource separately. Signed-off-by: Abhijit Gangurde --- drivers/bus/cdx/bus_

Re: [PATCH v2] app/testpmd: fix invalid queue ID when start port

2023-07-04 Thread Ferruh Yigit
On 7/4/2023 9:45 AM, Jie Hai wrote: > Function update_queue_state updates queue state of all queues > of all ports, using the queue num nb_rxq|nb_txq stored locally > by testpmd. An error on the invalid queue ID occurs if we run > testpmd with two ports and detach-attach one of them and start > the

[PATCH v3 2/2] node: add UDP v4 support

2023-07-04 Thread Rakesh Kudurumalla
IPv4 UDP packets are given to application with specified UDP destination port given by user. Signed-off-by: Rakesh Kudurumalla --- doc/api/doxy-api-index.md | 3 +- doc/guides/prog_guide/graph_lib.rst | 25 ++ .../img/graph_inbuilt_node_flow.svg | 165 +

[PATCH v3 1/2] node: add IPv4 local node to handle local pkts

2023-07-04 Thread Rakesh Kudurumalla
Local or Host destined pkts can be redirected IPv4 local node using IP4 Lookup node entries with prefix of 32 and be redirected to this IP4 local node for further processing. Signed-off-by: Rakesh Kudurumalla --- Depends-on: series-28622 ("add inbuilt graph nodes data flow") v3 : - Resolve co

[v1 5/5] net/mlx5/hws: support default miss action on FDB

2023-07-04 Thread Itamar Gozlan
From: Alex Vesker Add the support for default miss on HWS FDB, this implementation was missing until now. Default miss can be used for more efficient miss flow instead of going to an empty matcher or some defecated empty table. Signed-off-by: Alex Vesker Acked-by: Matan Azrad --- drivers/net/

[v1 4/5] net/mlx5/hws: renaming FT to TBL

2023-07-04 Thread Itamar Gozlan
An action naming change is made to describe the action better and avoid implicit meaning. Signed-off-by: Itamar Gozlan Acked-by: Matan Azrad --- drivers/net/mlx5/hws/mlx5dr.h| 2 +- drivers/net/mlx5/hws/mlx5dr_action.c | 16 drivers/net/mlx5/hws/mlx5dr_debug.c | 2 +-

[v1 3/5] net/mlx5/hws: remove duplicated reformat type

2023-07-04 Thread Itamar Gozlan
From: Shun Hao Currently there are two enum definitions for reformat type: mlx5dr_action_reformat_type and mlx5dr_action_type. They are actually the same. This patch remove the unnecessary mlx5dr_action_reformat_type so use only one definition for reformat type. Signed-off-by: Shun Hao Acked-by

[v1 2/5] net/mlx5/hws: allow destroying rule resources on error

2023-07-04 Thread Itamar Gozlan
From: Alex Vesker In case the send engine is in error state API should provide a way to free rule resources and provide a fake completion. Otherwise there is no way to release these resources. Signed-off-by: Alex Vesker Acked-by: Matan Azrad --- drivers/net/mlx5/hws/mlx5dr_rule.c | 10 +--

[v1 1/5] net/mlx5/hws: remove uneeded new line for DR_LOG

2023-07-04 Thread Itamar Gozlan
From: Alex Vesker In some places an extra new line was added, remove to have clean prints. Signed-off-by: Alex Vesker Acked-by: Matan Azrad --- v2->v3 1. Right patches instead of wrong patches in the previous series v1->v2 1. Last patch in the series (net/mlx5/hws: support default miss action

Re: [PATCH] eal/interrupts: Allow UIO interrupts when using igb_uio

2023-07-04 Thread Vladimir Ratnikov
Sorry for a long reply, sure. Stephen, am I right that the most concern is about a place where interrupt capabilities check appears for non MSI-X support? What if having dedicated rte_intr_cap_single analog when there's no support for MSI-X and just do the same(check capability, allocate interrupt

Re: [PATCH v2] app/testpmd: fix invalid queue ID when start port

2023-07-04 Thread fengchengwen
Acked-by: Chengwen Feng On 2023/7/4 16:45, Jie Hai wrote: > Function update_queue_state updates queue state of all queues > of all ports, using the queue num nb_rxq|nb_txq stored locally > by testpmd. An error on the invalid queue ID occurs if we run > testpmd with two ports and detach-attach one

Re: [PATCH] vfio: do not coalesce DMA mappings

2023-07-04 Thread Gupta, Nipun
Hi Xuan, On 7/4/2023 1:36 PM, Ding, Xuan wrote: Hi Nipun, -Original Message- From: Gupta, Nipun Sent: Tuesday, July 4, 2023 2:54 PM To: Ding, Xuan ; dev@dpdk.org; tho...@monjalon.net; Burakov, Anatoly ; Yigit, Ferruh ; David Marchand Cc: Agarwal, Nikhil ; He, Xingguang ; Ling, WeiX

Re: [PATCH v2] set namespace prefix to threads

2023-07-04 Thread fengchengwen
+1 for same prefix. Acked-by: Chengwen Feng On 2023/7/3 20:14, Thomas Monjalon wrote: > When looking at threads in a system, it can be confusing > to find some unknown threads without a clue it is started by DPDK. > > Let's start all thread names with "dpdk-" > plus the driver name if it comes f

RE: [PATCH v2] app/testpmd: fix invalid queue ID when start port

2023-07-04 Thread Ali Alnubani
> -Original Message- > From: Jie Hai > Sent: Tuesday, July 4, 2023 11:45 AM > To: Aman Singh ; Yuying Zhang > ; Ferruh Yigit ; Shiyang He > > Cc: dev@dpdk.org; liudongdo...@huawei.com; Ali Alnubani > > Subject: [PATCH v2] app/testpmd: fix invalid queue ID when start port > > Function up

Re: [PATCH v2] graph: fix graph model check in core binding

2023-07-04 Thread Jerin Jacob
On Mon, Jul 3, 2023 at 3:35 PM Zhirun Yan wrote: > > Fix graph model check in core binding with graph. And rte_graph_clone() > need to use valid params rather than NULL pointer. > Update release notes for new mcore dispatch model. Please add Fixes: > Signed-off-by: Zhirun Yan > --- > app/test

[PATCH v7 3/3] ring: add telemetry cmd for ring info

2023-07-04 Thread Jie Hai
This patch supports dump of ring information by its name. An example using this command is shown below: --> /ring/info,MP_mb_pool_0 { "/ring/info": { "name": "MP_mb_pool_0", "socket": 0, "flags": "0x0", "producer_type": "MP", "consumer_type": "MC", "size": 262144, "ma

[PATCH v7 0/3] add telemetry cmds for ring

2023-07-04 Thread Jie Hai
This patch set supports telemetry cmd to list rings and dump information of a ring by its name. v1->v2: 1. Add space after "switch". 2. Fix wrong strlen parameter. v2->v3: 1. Remove prefix "rte_" for static function. 2. Add Acked-by Konstantin Ananyev for PATCH 1. 3. Introduce functions to return

[PATCH v7 2/3] ring: add telemetry cmd to list rings

2023-07-04 Thread Jie Hai
Add a telemetry command to list the rings used in the system. An example using this command is shown below: --> /ring/list { "/ring/list": [ "HT_:7d:00.2", "MP_mb_pool_0" ] } Signed-off-by: Jie Hai Acked-by: Konstantin Ananyev Reviewed-by: Honnappa Nagarahalli Acked-by: Huisong

[PATCH v7 1/3] ring: fix unmatched type definition and usage

2023-07-04 Thread Jie Hai
Field 'flags' of struct rte_ring is defined as int type. However, it is used as unsigned int. To ensure consistency, change the type of flags to unsigned int. Since these two types has the same byte size, this change is not an ABI change. Fixes: af75078fece3 ("first public release") Signed-off-by

[PATCH v2] app/testpmd: fix invalid queue ID when start port

2023-07-04 Thread Jie Hai
Function update_queue_state updates queue state of all queues of all ports, using the queue num nb_rxq|nb_txq stored locally by testpmd. An error on the invalid queue ID occurs if we run testpmd with two ports and detach-attach one of them and start the other port first. This is because the attache

RE: [PATCH v2] eal: avoid issues in macro expansion of alignment

2023-07-04 Thread Morten Brørup
> From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Tuesday, 4 July 2023 01.24 > > RTE_ALIGN_MUL_NEAR is a macro so the cycle argument could > get evaluated twice causing some potential skew. Fix by > computing value once. > > Suggested by patch to fix side effects. > > Fixes:

Re: [PATCH] eal: fix file descriptor leakage with unhandled messages

2023-07-04 Thread David Marchand
On Mon, Jul 3, 2023 at 12:31 PM Burakov, Anatoly wrote: > On 6/28/2023 1:19 PM, Viacheslav Ovsiienko wrote: > > The sendmsg()/recvmsg() API is used to establish communication between > > the DPDK processes. The API supposes inter-process file descriptors > > sending and conversion, the recipient s

RE: [PATCH v1] net/mlx5: support symmetric RSS hash function

2023-07-04 Thread Ori Kam
Hi Xueming, > -Original Message- > From: Xueming(Steven) Li > Sent: Friday, June 30, 2023 10:55 AM > To: Matan Azrad ; Slava Ovsiienko > ; Ori Kam ; Suanming Mou > > Cc: Xueming(Steven) Li ; dev@dpdk.org > Subject: [PATCH v1] net/mlx5: support symmetric RSS hash function > > This patch

RE: [PATCH V2 2/2] app/testpmd: assign custom ID to flow rules

2023-07-04 Thread Ori Kam
> -Original Message- > From: Gregory Etelson > Subject: [PATCH V2 2/2] app/testpmd: assign custom ID to flow rules > > From: Eli Britstein > > Upon creation of a flow, testpmd assigns it a flow ID. Later, the > flow ID is used for flow operations (query, destroy, dump). > > The testp

Re: [PATCH v2] doc: build manpages as well as html output

2023-07-04 Thread David Marchand
On Tue, Jun 6, 2023 at 3:13 PM Bruce Richardson wrote: > > Doxygen can produce manpage output as well as html output for the DPDK > APIs. However, we need to do this as a separate task as the manpage > output needs to be placed in a different location post-install to the > html output (/usr/local/

RE: [PATCH] doc: announce ethdev operation struct changes

2023-07-04 Thread Feifei Wang
> -Original Message- > From: Feifei Wang > Sent: Tuesday, July 4, 2023 4:10 PM > Cc: dev@dpdk.org; nd ; Honnappa Nagarahalli > ; Feifei Wang ; > Ruifeng Wang > Subject: [PATCH] doc: announce ethdev operation struct changes > > To support mbufs recycle mode, announce the coming ABI cha

[PATCH] doc: announce ethdev operation struct changes

2023-07-04 Thread Feifei Wang
To support mbufs recycle mode, announce the coming ABI changes from DPDK 23.11. Signed-off-by: Feifei Wang Reviewed-by: Ruifeng Wang --- doc/guides/rel_notes/deprecation.rst | 4 1 file changed, 4 insertions(+) diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/depr

RE: [PATCH] vfio: do not coalesce DMA mappings

2023-07-04 Thread Ding, Xuan
Hi Nipun, > -Original Message- > From: Gupta, Nipun > Sent: Tuesday, July 4, 2023 2:54 PM > To: Ding, Xuan ; dev@dpdk.org; tho...@monjalon.net; > Burakov, Anatoly ; Yigit, Ferruh > ; David Marchand > Cc: Agarwal, Nikhil ; He, Xingguang > ; Ling, WeiX > Subject: RE: [PATCH] vfio: do not

Re: [PATCH v4 3/3] ring: add telemetry cmd for ring info

2023-07-04 Thread Jie Hai
On 2023/6/20 22:34, Thomas Monjalon wrote: 20/06/2023 10:14, Jie Hai: On 2023/2/20 20:55, David Marchand wrote: On Fri, Feb 10, 2023 at 3:50 AM Jie Hai wrote: This patch supports dump of ring information by its name. An example using this command is shown below: --> /ring/info,MP_mb_pool_0

Re: [PATCH v2 2/2] doc/contributing: guidelines for logging, tracing and telemetry

2023-07-04 Thread David Marchand
On Tue, Jun 20, 2023 at 7:08 PM Bruce Richardson wrote: > > As discussed by DPDK technical board [1], our contributor guide should > include some details as to when to use logging vs tracing vs telemetry > to provide the end user with information about the running process and > the DPDK libraries

Re: [PATCH v2 1/2] doc/contributing: provide coding details for dynamic logging

2023-07-04 Thread David Marchand
On Tue, Jun 20, 2023 at 7:08 PM Bruce Richardson wrote: > > While the section on dynamic logging in the contributors guide covered > the details of the logging naming scheme, it failed to cover exactly how > the component developer, i.e. the contributor, could actually use > dynamic logging in the