Re: [PATCH] eal: add notes to SMP memory barrier APIs

2023-06-23 Thread Tyler Retzlaff
On Thu, Jun 22, 2023 at 08:19:30PM +0200, Mattias Rönnblom wrote: > On 2023-06-21 08:44, Ruifeng Wang wrote: > >The rte_smp_xx() APIs are deprecated. But it is not mentioned > >in the function header. > >Added notes in function header for clarification. > > > >Signed-off-by: Ruifeng Wang > >--- >

Re: [PATCH v5 0/6] replace rte atomics with GCC builtin atomics

2023-06-23 Thread Tyler Retzlaff
On Fri, Jun 23, 2023 at 10:53:22AM +0200, David Marchand wrote: > Hello Patrick, > > On Thu, Jun 22, 2023 at 10:00 PM Patrick Robb wrote: > > > > I want to report a possible regression from this patch series seen from CI > > testing on our Intel 82599ES 10G NIC, which we failed to report to > >

Re: [PATCH v5 0/6] replace rte atomics with GCC builtin atomics

2023-06-23 Thread Tyler Retzlaff
Hi Patrick, I will take a look at this as a priority asap. Thanks for bringing it to my attention. On Thu, Jun 22, 2023 at 03:59:42PM -0400, Patrick Robb wrote: > I want to report a possible regression from this patch series seen from CI > testing on our Intel 82599ES 10G NIC, which we failed to

[PATCH 2/2] net/sfc: support IPv4 fragment matching in transfer rules

2023-06-23 Thread Artemii Morozov
This patch adds the support for IPv4 fragmented packets, but with some limitations: for non-zero fragment offset an exact match is not allowed, but ranges are allowed. Signed-off-by: Artemii Morozov Reviewed-by: Viacheslav Galaktionov Reviewed-by: Andy Moreton --- drivers/net/sfc/sfc_mae.c | 1

[PATCH 0/2] support IPv4 fragment matching in transfer rules

2023-06-23 Thread Artemii Morozov
This patch seria adds support for matching fragment offsets for IPv4 packets, but with some limitations. Exact matching is supported only for zero offset, ranges are allowed for non-zero offsets. Artemii Morozov (2): common/sfc_efx/base: add MAE IP fragmentation match bits net/sfc: support IPv

[PATCH 1/2] common/sfc_efx/base: add MAE IP fragmentation match bits

2023-06-23 Thread Artemii Morozov
Introduce necessary infrastructure for these bits to be set and validated. Using a combination of these bits IP fragmentation can be configured. Signed-off-by: Artemii Morozov Reviewed-by: Ivan Malov Reviewed-by: Andy Moreton --- drivers/common/sfc_efx/base/efx.h | 4 drivers/common/s

[PATCH v4 9/9] build: make reorder library optional

2023-06-23 Thread Bruce Richardson
This library is not essential for most DPDK uses, so mark it as optional in the build config. Signed-off-by: Bruce Richardson Acked-by: Morten Brørup --- app/test/meson.build | 6 -- lib/meson.build | 1 + 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/app/test/meson.bu

[PATCH v4 7/9] build: make distributor library optional

2023-06-23 Thread Bruce Richardson
This library is not essential for most DPDK uses, so mark it as optional in the build config. Signed-off-by: Bruce Richardson Acked-by: Morten Brørup --- app/test/meson.build | 9 + lib/meson.build | 1 + 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/app/test/meson

[PATCH v4 8/9] build: make fragmentation library optional

2023-06-23 Thread Bruce Richardson
This library is not essential for most DPDK uses, so mark it as optional in the build config. Signed-off-by: Bruce Richardson Acked-by: Morten Brørup --- app/test/meson.build | 6 -- lib/meson.build | 1 + 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/app/test/meson.bu

[PATCH v4 6/9] build: make efd library optional

2023-06-23 Thread Bruce Richardson
This library is not essential for most DPDK uses, so mark it as optional in the build config. Signed-off-by: Bruce Richardson Acked-by: Morten Brørup --- app/test/meson.build | 8 lib/meson.build | 1 + 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/app/test/meson.

[PATCH v4 5/9] build: make bpf library optional

2023-06-23 Thread Bruce Richardson
This library is not essential for most DPDK uses, so mark it as optional in the build config. Signed-off-by: Bruce Richardson Acked-by: Morten Brørup --- app/test/meson.build | 10 +++--- lib/meson.build | 1 + 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/app/test/me

[PATCH v4 3/9] build: make most device classes optional

2023-06-23 Thread Bruce Richardson
Apart from ethdev and cryptodev, which have lots of components and tests which depend on them, we can make the device class libraries optional without too much work. This patch marks: * bbdev, * compressdev, * dmadev, * eventdev, * mldev, * rawdev, * regexdev optional, and ensures that DPDK - incl

[PATCH v4 2/9] event/dlb2: skip configuration if no eventdev lib

2023-06-23 Thread Bruce Richardson
While the build system will skip building most libs and drivers when a dependency is missing for a component, for DLB2 driver, the "static_rte_eventdev" object is referenced inside the meson.build file itself, which will cause crashes if it doesn't exist i.e. if eventdev is disabled. Prevent this i

[PATCH v4 4/9] build: make membership library optional

2023-06-23 Thread Bruce Richardson
This library is not essential for most DPDK uses, so mark it as optional in the build config. Signed-off-by: Bruce Richardson Acked-by: Morten Brørup --- app/test/meson.build | 9 + lib/meson.build | 1 + 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/app/test/meson

[PATCH v4 1/9] examples/l3fwd: make eventdev an optional dependency

2023-06-23 Thread Bruce Richardson
With l3fwd being a very commonly used example app, and built as part of our CI tests, we need to ensure it's buildable with just about all supported DPDK configurations. To enable l3fwd application to be built when the eventdev library is disabled, we need to compile in the eventdev support condit

[PATCH v4 0/9] expand list of optional libraries

2023-06-23 Thread Bruce Richardson
DPDK still has many libraries which cannot be disabled as part of a build. With the ongoing work to make it easier to only build a subset of the libraries in DPDK, we can also work to expand the list of libraries which can be enabled/disabled as desired. This patch addresses a number of the "low-h

[PATCH v2] common/qat: detach QAT crypto compress build

2023-06-23 Thread Vikash Poddar
qat_qp.c is a common file for QAT crypto and compress. Moved compress function from common file to compress QAT file qat_comp.c Fixes: 2ca75c65af4c ("common/qat: build drivers from common folder") Cc: bruce.richard...@intel.com Cc: sta...@dpdk.org Signed-off-by: Vikash Poddar --- v2: Fixed codin

Re: [PATCH v3 5/8] crypto/cnxk: add support for raw APIs

2023-06-23 Thread Thomas Monjalon
20/06/2023 12:21, Tejasree Kondoj: > From: Anoob Joseph > > Add crypto RAW API support in cnxk PMD > Enable the flag to allow execution of raw test suite. > > Signed-off-by: Vidya Sagar Velumuri > Signed-off-by: Anoob Joseph The compilation with a RISC-V compiler reveal an issue with iv_buf b

Re: [PATCH] drivers: remove compile-time option for IEEE 1588

2023-06-23 Thread Ferruh Yigit
On 2/3/2023 1:28 PM, Thomas Monjalon wrote: > The option RTE_LIBRTE_IEEE1588 has no effect on any library > unlike its name. > > Also we are suppose to enable/disable features dynamically, > not at compilation time. > > And the best is that this macro is neither documented, > nor in rte_config.h.

[PATCH v2] crypto/qat: fix NULL algorithm digest placement

2023-06-23 Thread Ciara Power
QAT HW generates bytes of 0x00 digest, even when a digest of len 0 is requested for NULL. This caused test failures when the test vector had digest len 0, as the buffer has unexpected changed bytes. By placing the digest into the cookie for NULL authentication, the buffer remains unchanged as expe

[PATCH v1] common/qat: detach QAT crypto compress build

2023-06-23 Thread Vikash Poddar
qat_qp.c is a common file for QAT crypto and compress. Moved compress function from common file to compress QAT file qat_comp.c Fixes: 2ca75c65af4c ("common/qat: build drivers from common folder") Cc: bruce.richard...@intel.com Cc: sta...@dpdk.org Signed-off-by: Vikash Poddar --- drivers/common

Re: [PATCH v3 0/2] enhance bonding PMD to support the LACP negotiation

2023-06-23 Thread Ferruh Yigit
On 6/7/2023 4:10 AM, Chaoyong He wrote: >> On 6/6/2023 2:23 AM, Chaoyong He wrote: >>> A gentle ping on this series. > ... > Long Wu (2): > net/bonding: add independent LACP sending function > app/testpmd: add support for bonding port's LACP negotiation > > app/test-pmd/con

Re: [PATCH v3 1/8] examples/l3fwd: make eventdev an optional dependency

2023-06-23 Thread Bruce Richardson
On Fri, Jun 23, 2023 at 12:15:01PM +0100, Bruce Richardson wrote: > With l3fwd being a very commonly used example app, and built as part of > our CI tests, we need to ensure it's buildable with just about all > supported DPDK configurations. To enable l3fwd application to be built > when the event

DPDK Release Status Meeting 2023-06-22

2023-06-23 Thread Mcnamara, John
Release status meeting minutes 2023-06-22 = Agenda: * Release Dates * Subtrees * Roadmaps * LTS * Defects * Opens Participants: * AMD * ARM [no] * Debian/Microsoft [no] * Intel * Marvell * Nvidia * Red Hat Release Dates - The following are th

Re: [PATCH] net/bonding: fix iavf bond device query stats

2023-06-23 Thread Ferruh Yigit
On 6/9/2023 2:38 AM, lihuisong (C) wrote: > > 在 2023/6/8 23:41, Stephen Hemminger 写道: >> On Thu,  8 Jun 2023 15:26:36 +0800 >> Kaiwen Deng wrote: >> >>> If the rte_eth_stats_get function does not work properly, >>> the update function of the slave device does not work >>> properly When device is

RE: [PATCH v3] bitmap: add scan from offset function

2023-06-23 Thread Dumitrescu, Cristian
> -Original Message- > From: Thomas Monjalon > Sent: Thursday, June 22, 2023 6:45 PM > To: Volodymyr Fialko > Cc: dev@dpdk.org; Dumitrescu, Cristian ; > jer...@marvell.com; ano...@marvell.com > Subject: Re: [PATCH v3] bitmap: add scan from offset function > > 21/06/2023 12:01, Volodym

Re: [PATCH v8 0/4] net/sfc: support VLAN stripping offload

2023-06-23 Thread Ferruh Yigit
On 6/23/2023 6:47 AM, Artemii Morozov wrote: > This patch series adds VLAN stripping offload. Note that this > offload are device level offload. > > v8: > * fix minor issues > * update the release notes > > v7: > * raise an error if there is no callback for efo_get_count > * fix alignment

Re: [PATCH v2 1/5] app/testpmd: add trace save command

2023-06-23 Thread Ferruh Yigit
On 6/23/2023 1:03 PM, Jerin Jacob wrote: > On Fri, Jun 23, 2023 at 5:23 PM Ferruh Yigit wrote: >> >> On 6/23/2023 9:00 AM, Slava Ovsiienko wrote: >>> Hi, Ferruh >>> -Original Message- From: Ferruh Yigit Sent: Wednesday, June 21, 2023 2:16 PM To: Slava Ovsiienko ; dev@d

RE: [PATCH v2 1/5] app/testpmd: add trace save command

2023-06-23 Thread Slava Ovsiienko
> -Original Message- > From: Jerin Jacob > Sent: Friday, June 23, 2023 3:04 PM > To: Ferruh Yigit > Cc: Slava Ovsiienko ; Aman Singh > ; Jerin Jacob Kollanukkaran > ; dev@dpdk.org > Subject: Re: [PATCH v2 1/5] app/testpmd: add trace save command > > On Fri, Jun 23, 2023 at 5:23 PM Ferruh

Re: [PATCH v2 1/5] app/testpmd: add trace save command

2023-06-23 Thread Jerin Jacob
On Fri, Jun 23, 2023 at 5:23 PM Ferruh Yigit wrote: > > On 6/23/2023 9:00 AM, Slava Ovsiienko wrote: > > Hi, Ferruh > > > >> -Original Message- > >> From: Ferruh Yigit > >> Sent: Wednesday, June 21, 2023 2:16 PM > >> To: Slava Ovsiienko ; dev@dpdk.org; Aman Singh > >> > >> Cc: Jerin Jaco

Re: [PATCH v2 1/5] app/testpmd: add trace save command

2023-06-23 Thread Ferruh Yigit
On 6/23/2023 9:00 AM, Slava Ovsiienko wrote: > Hi, Ferruh > >> -Original Message- >> From: Ferruh Yigit >> Sent: Wednesday, June 21, 2023 2:16 PM >> To: Slava Ovsiienko ; dev@dpdk.org; Aman Singh >> >> Cc: Jerin Jacob Kollanukkaran >> Subject: Re: [PATCH v2 1/5] app/testpmd: add trace s

[PATCH v4] doc: prefer installing using meson rather than ninja

2023-06-23 Thread Bruce Richardson
After doing a build, to install DPDK system-wide our documentation recommended using the "ninja install" command. However, for anyone building as a non-root user and only installing as root, the "meson install" command is a better alternative, as it provides for automatically dropping or elevating

RE: [PATCH v4 3/4] build: select deprecated libraries

2023-06-23 Thread Morten Brørup
> From: Bruce Richardson [mailto:bruce.richard...@intel.com] > Sent: Friday, 23 June 2023 13.19 > > On Fri, Jun 23, 2023 at 01:15:00PM +0200, Morten Brørup wrote: > > > From: Bruce Richardson [mailto:bruce.richard...@intel.com] > > > Sent: Friday, 23 June 2023 13.04 > > > > > > On Fri, Jun 23, 202

Re: [PATCH v4 3/4] build: select deprecated libraries

2023-06-23 Thread Bruce Richardson
On Fri, Jun 23, 2023 at 01:15:00PM +0200, Morten Brørup wrote: > > From: Bruce Richardson [mailto:bruce.richard...@intel.com] > > Sent: Friday, 23 June 2023 13.04 > > > > On Fri, Jun 23, 2023 at 11:35:29AM +0200, David Marchand wrote: > > > Hello Bruce, > > > > > > On Thu, Jun 22, 2023 at 10:43 AM

[PATCH v3 7/8] build: make fragmentation library optional

2023-06-23 Thread Bruce Richardson
This library is not essential for most DPDK uses, so mark it as optional in the build config. Signed-off-by: Bruce Richardson Acked-by: Morten Brørup --- app/test/meson.build | 6 -- lib/meson.build | 1 + 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/app/test/meson.bu

[PATCH v3 8/8] build: make reorder library optional

2023-06-23 Thread Bruce Richardson
This library is not essential for most DPDK uses, so mark it as optional in the build config. Signed-off-by: Bruce Richardson Acked-by: Morten Brørup --- app/test/meson.build | 6 -- lib/meson.build | 1 + 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/app/test/meson.bu

[PATCH v3 6/8] build: make distributor library optional

2023-06-23 Thread Bruce Richardson
This library is not essential for most DPDK uses, so mark it as optional in the build config. Signed-off-by: Bruce Richardson Acked-by: Morten Brørup --- app/test/meson.build | 9 + lib/meson.build | 1 + 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/app/test/meson

[PATCH v3 4/8] build: make bpf library optional

2023-06-23 Thread Bruce Richardson
This library is not essential for most DPDK uses, so mark it as optional in the build config. Signed-off-by: Bruce Richardson Acked-by: Morten Brørup --- app/test/meson.build | 10 +++--- lib/meson.build | 1 + 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/app/test/me

[PATCH v3 3/8] build: make membership library optional

2023-06-23 Thread Bruce Richardson
This library is not essential for most DPDK uses, so mark it as optional in the build config. Signed-off-by: Bruce Richardson Acked-by: Morten Brørup --- app/test/meson.build | 9 + lib/meson.build | 1 + 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/app/test/meson

[PATCH v3 5/8] build: make efd library optional

2023-06-23 Thread Bruce Richardson
This library is not essential for most DPDK uses, so mark it as optional in the build config. Signed-off-by: Bruce Richardson Acked-by: Morten Brørup --- app/test/meson.build | 8 lib/meson.build | 1 + 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/app/test/meson.

[PATCH v3 2/8] build: make most device classes optional

2023-06-23 Thread Bruce Richardson
Apart from ethdev and cryptodev, which have lots of components and tests which depend on them, we can make the device class libraries optional without too much work. This patch marks: * bbdev, * compressdev, * dmadev, * eventdev, * mldev, * rawdev, * regexdev optional, and ensures that DPDK - incl

[PATCH v3 1/8] examples/l3fwd: make eventdev an optional dependency

2023-06-23 Thread Bruce Richardson
With l3fwd being a very commonly used example app, and built as part of our CI tests, we need to ensure it's buildable with just about all supported DPDK configurations. To enable l3fwd application to be built when the eventdev library is disabled, we need to compile in the eventdev support condit

[PATCH v3 0/8] expand list of optional libraries

2023-06-23 Thread Bruce Richardson
DPDK still has many libraries which cannot be disabled as part of a build. With the ongoing work to make it easier to only build a subset of the libraries in DPDK, we can also work to expand the list of libraries which can be enabled/disabled as desired. This patch addresses a number of the "low-h

RE: [PATCH v4 3/4] build: select deprecated libraries

2023-06-23 Thread Morten Brørup
> From: Bruce Richardson [mailto:bruce.richard...@intel.com] > Sent: Friday, 23 June 2023 13.04 > > On Fri, Jun 23, 2023 at 11:35:29AM +0200, David Marchand wrote: > > Hello Bruce, > > > > On Thu, Jun 22, 2023 at 10:43 AM Bruce Richardson > > wrote: > > > > > > On Wed, Jun 21, 2023 at 07:00:57PM

Re: [PATCH v2 0/7] expand list of optional libraries

2023-06-23 Thread Bruce Richardson
On Fri, Jun 23, 2023 at 12:31:10PM +0200, David Marchand wrote: > On Fri, Jun 23, 2023 at 12:25 PM David Marchand > wrote: > > > > On Thu, Jun 22, 2023 at 5:13 PM Bruce Richardson > > wrote: > > > > > > DPDK still has many libraries which cannot be disabled as part of a > > > build. With the ongo

Re: [PATCH v4 3/4] build: select deprecated libraries

2023-06-23 Thread Bruce Richardson
On Fri, Jun 23, 2023 at 11:35:29AM +0200, David Marchand wrote: > Hello Bruce, > > On Thu, Jun 22, 2023 at 10:43 AM Bruce Richardson > wrote: > > > > On Wed, Jun 21, 2023 at 07:00:57PM +0200, David Marchand wrote: > > > Rework deprecated libraries selection by introducing a new configuration > >

Re: [PATCH v2 0/7] expand list of optional libraries

2023-06-23 Thread David Marchand
On Fri, Jun 23, 2023 at 12:25 PM David Marchand wrote: > > On Thu, Jun 22, 2023 at 5:13 PM Bruce Richardson > wrote: > > > > DPDK still has many libraries which cannot be disabled as part of a > > build. With the ongoing work to make it easier to only build a subset > > of the libraries in DPDK,

RE: [EXT] [dpdk-dev v2 1/3] app/test: add diffie-hellman test cases

2023-06-23 Thread Gowrishankar Muthukrishnan
> diff --git a/app/test/test_cryptodev_asym.c b/app/test/test_cryptodev_asym.c > index 5b16dcab56..b9034b637a 100644 > --- a/app/test/test_cryptodev_asym.c > +++ b/app/test/test_cryptodev_asym.c > @@ -64,6 +64,39 @@ static uint32_t test_index; > > static struct crypto_testsuite_params_asym testsu

Re: [PATCH v2 0/7] expand list of optional libraries

2023-06-23 Thread David Marchand
On Thu, Jun 22, 2023 at 5:13 PM Bruce Richardson wrote: > > DPDK still has many libraries which cannot be disabled as part of a > build. With the ongoing work to make it easier to only build a subset > of the libraries in DPDK, we can also work to expand the list of > libraries which can be enable

Re: [PATCH v4 3/4] build: select deprecated libraries

2023-06-23 Thread David Marchand
Hello Bruce, On Thu, Jun 22, 2023 at 10:43 AM Bruce Richardson wrote: > > On Wed, Jun 21, 2023 at 07:00:57PM +0200, David Marchand wrote: > > Rework deprecated libraries selection by introducing a new configuration > > option. > > > > This breaks existing configurations that were relying on disab

Re: [EXT] [PATCH v4 0/9] crypto/mlx5: support AES-GCM

2023-06-23 Thread Thomas Monjalon
20/06/2023 20:49, Akhil Goyal: > > AES-GCM provides both authenticated encryption and the ability to check > > the integrity and authentication of additional authenticated data (AAD) > > that is sent in the clear. [...] > Series applied to dpdk-next-crypto This has to be added to avoid a compilati

Re: [Bug 1255] [asan] net/mlx5: memory leak on port cleanup

2023-06-23 Thread David Marchand
On Wed, Jun 21, 2023 at 9:12 PM Asaf Penso wrote: > > Hello David, > What's the dpdk version used in that OS? > Have you tried manually installing latest dpdk and check? > We recently fixed some mem issue, raised by valgrind. I caught this on the main branch of DPDK, after v23.03-rc1. Please chec

Re: [PATCH v5 0/6] replace rte atomics with GCC builtin atomics

2023-06-23 Thread David Marchand
Hello Patrick, On Thu, Jun 22, 2023 at 10:00 PM Patrick Robb wrote: > > I want to report a possible regression from this patch series seen from CI > testing on our Intel 82599ES 10G NIC, which we failed to report to patchwork > when this initially went under CI due to a bug in our Jenkins repor

RE: [PATCH v2 1/5] app/testpmd: add trace save command

2023-06-23 Thread Slava Ovsiienko
Hi, Ferruh > -Original Message- > From: Ferruh Yigit > Sent: Wednesday, June 21, 2023 2:16 PM > To: Slava Ovsiienko ; dev@dpdk.org; Aman Singh > > Cc: Jerin Jacob Kollanukkaran > Subject: Re: [PATCH v2 1/5] app/testpmd: add trace save command > > On 6/13/2023 5:58 PM, Viacheslav Ovsiie

Re: KNI to Vhost changes

2023-06-23 Thread Prasad Kachawar
Hi team, am working on containerized environment where application hosted in container and i want to transfer pkt from nic to application using vhost is any thing can i get for reference Thanks , Prasad K On Mon, Jun 19, 2023 at 12:49 PM Xia, Chenbo wrote: > Hi, > > > > Check here: > https://d

Re: [PATCH v3] doc: prefer installing using meson rather than ninja

2023-06-23 Thread Bruce Richardson
On Thu, Jun 22, 2023 at 08:35:17PM +0200, Thomas Monjalon wrote: > 09/06/2023 16:51, Bruce Richardson: > > After doing a build, to install DPDK system-wide our documentation > > recommended using the "ninja install" command. However, for anyone > > building as a non-root user and only installing as

[dpdk-dev] [PATCH v1] doc: add inbuilt graph nodes data flow

2023-06-23 Thread jerinj
From: Jerin Jacob Added diagram to depict the data flow between inbuilt graph nodes. In order to avoid graphviz package dependency to DPDK documentation, manual step added to create a svg file from the dot file. The details for the same is documented in graph_inbuilt_node_flow.svg as a comment.

Re: [PATCH v8 2/4] common/sfc_efx/base: add API to get installed filters count

2023-06-23 Thread Ivan Malov
On Fri, 23 Jun 2023, Artemii Morozov wrote: This API allows to get number of installed filters. This will be used in the future patches. Signed-off-by: Artemii Morozov Acked-by: Andrew Rybchenko Acked-by: Ivan Malov Thank you. --- drivers/common/sfc_efx/base/ef10_filter.c | 20 +