Re: [PATCH] net/iavf: fix old GCC compilation warnings

2023-06-08 Thread David Marchand
On Fri, Jun 9, 2023 at 7:35 AM Zhichao Zeng wrote: > > The code uses the Wimplicit-fallthrough compile option to ignore > falls through warnings in switch case, but this option was introduced > by GCC 7 and old GCC do not recognize the option. > > Add judgment to avoid warnings about unrecognized

Re: [PATCH v2 resend] crypto/uadk: set queue pair in dev_configure

2023-06-08 Thread Zhangfei Gao
Hi, Akhil 在 2023/6/2 11:04, Zhangfei Gao 写道: By default, uadk only alloc two queues for each algorithm, which will impact performance. Set queue pair number as required in dev_configure. The default max queue pair number is 8, which can be modified via para: max_nb_queue_pairs Example: sudo dp

RE: [EXT] [PATCH v2] cryptodev: avoid algorithm strings null pointers

2023-06-08 Thread Akhil Goyal
> Subject: [EXT] [PATCH v2] cryptodev: avoid algorithm strings null pointers > > The crypto algorithm strings identifiers that are Continuous may be null, > so there is needed to add null judgment. > When testing with dpdk-test-crypto-perf and passing in the parameter > --auth-algo sm3-hmac, The p

[PATCH] net/nfp: fix incorrect link status after LSC event

2023-06-08 Thread Chaoyong He
From: James Hershaw Incorrect port speed shown after a link state and interrupt of type RTE_ETH_EVENT_INTR_LSC occurs. This is because the interrupt handler for this type of event in the nfp PMD does not reconfigure the netdev. Fixed by moving the call to the nfp_net_notify_port_speed() function

[PATCH] net/nfp: fix TP flow action for UDP

2023-06-08 Thread Chaoyong He
The former logic can't distinguish the TCP and UDP set action, and only send a TCP type ctrl message to firmware, which cause the set action of UDP can't offload. Fixes: fc185097bbe6 ("net/nfp: support TP source flow action") Fixes: 87986df09d75 ("net/nfp: support TP destination flow action") Cc:

[PATCH] net/nfp: fix set IPv6 flow action can't get right address

2023-06-08 Thread Chaoyong He
The former logic of set IPv6 source/destination address flow action can't get the right IPV6 address, a 32 bit big endian value is expected while a 8 bit value is provided. This caused the offloaded packets don't have the right IPv6 address as expected. Fixes: 596ae2217214 ("net/nfp: support IPv6

[PATCH 3/3] net/nfp: fix flow hash table creation failed

2023-06-08 Thread Chaoyong He
From: Long Wu The former logic does not consider the simultaneous initialization of several NICs using flower firmware. The reason the initialization failed was because several NICs use the same name parameter when we call rte_hash_create(). We use the PCI address to give each NIC a unique name

[PATCH 2/3] net/nfp: fix representor creation failed

2023-06-08 Thread Chaoyong He
From: Long Wu The former logic does not consider the simultaneous initialization of several NICs using flower firmware. The reason the initialization failed was because several NICs use the same name parameter when we call rte_eth_dev_create(). We use the PCI address to give each NIC a unique na

[PATCH 1/3] net/nfp: fix control mempool creation failed

2023-06-08 Thread Chaoyong He
From: Long Wu The former logic does not consider the simultaneous initialization of several NICs using flower firmware. The reason the initialization failed was because several NICs use the same name parameter when we call rte_pktmbuf_pool_create(). We use the PCI address to give each NIC a uniq

[PATCH 0/3] support using several cards in one host

2023-06-08 Thread Chaoyong He
The former logic does not consider using several cards with flower firmware in one host, this patch series add the support of this situation. Long Wu (3): net/nfp: fix control mempool creation failed net/nfp: fix representor creation failed net/nfp: fix flow hash table creation failed driv

[PATCH] net/iavf: fix old GCC compilation warnings

2023-06-08 Thread Zhichao Zeng
The code uses the Wimplicit-fallthrough compile option to ignore falls through warnings in switch case, but this option was introduced by GCC 7 and old GCC do not recognize the option. Add judgment to avoid warnings about unrecognized options in old GCC. Fixes: 95a1b0b23140 ("net/iavf: support Rx

RE: [PATCH v2] config/arm: fix Neoverse N2 march flag

2023-06-08 Thread Ruifeng Wang
> -Original Message- > From: pbhagavat...@marvell.com > Sent: Friday, June 9, 2023 3:35 AM > To: jer...@marvell.com; Ruifeng Wang ; Bruce Richardson > > Cc: dev@dpdk.org; Pavan Nikhilesh ; Srikanth > Yalavarthi > > Subject: [PATCH v2] config/arm: fix Neoverse N2 march flag > > From: Pa

RE: [PATCH] net/iavf: fix abnormal disable HW interrupt

2023-06-08 Thread Ye, MingjinX
> -Original Message- > From: Zhang, Qi Z > Sent: 2023年6月9日 9:48 > To: Ye, MingjinX ; dev@dpdk.org > Cc: Yang, Qiming ; Zhou, YidingX > ; Ye, MingjinX ; > sta...@dpdk.org; Wu, Jingjing ; Xing, Beilei > > Subject: RE: [PATCH] net/iavf: fix abnormal disable HW interrupt > > > > > -

RE: [PATCH] net/iavf: fix virtchnl cmd called in intr thread

2023-06-08 Thread Jiale, SongX
> -Original Message- > From: Kaiwen Deng > Sent: Thursday, June 8, 2023 3:28 PM > To: dev@dpdk.org > Cc: sta...@dpdk.org; Yang, Qiming ; Zhou, YidingX > ; Deng, KaiwenX ; Wu, > Jingjing ; Xing, Beilei > Subject: [PATCH] net/iavf: fix virtchnl cmd called in intr thread > > When iavf send

RE: [PATCH v2] net/ice: fix data length check

2023-06-08 Thread Zhang, Qi Z
> -Original Message- > From: Zhang, Qi Z > Sent: Tuesday, May 23, 2023 6:35 PM > To: Yang, Qiming > Cc: dev@dpdk.org; Zhang, Qi Z ; sta...@dpdk.org > Subject: [PATCH v2] net/ice: fix data length check > > In TSO, It is possible mbuf->data_len exceed mtu. > Fixed the incorrect data len

RE: [PATCH] net/iavf: fix abnormal disable HW interrupt

2023-06-08 Thread Zhang, Qi Z
> -Original Message- > From: Mingjin Ye > Sent: Thursday, June 8, 2023 2:23 PM > To: dev@dpdk.org > Cc: Yang, Qiming ; Zhou, YidingX > ; Ye, MingjinX ; > sta...@dpdk.org; Wu, Jingjing ; Xing, Beilei > > Subject: [PATCH] net/iavf: fix abnormal disable HW interrupt > > For command VIRTC

Re: [PATCH] net/bonding: fix iavf bond device query stats

2023-06-08 Thread lihuisong (C)
在 2023/6/8 23:41, Stephen Hemminger 写道: On Thu, 8 Jun 2023 15:26:36 +0800 Kaiwen Deng wrote: If the rte_eth_stats_get function does not work properly, the update function of the slave device does not work properly When device is bonded as BONDING_MODE_TLB mode. This commit adds handling fo

RE: [PATCH] net/iavf: fix virtchnl cmd called in intr thread

2023-06-08 Thread Zhang, Qi Z
> -Original Message- > From: Kaiwen Deng > Sent: Thursday, June 8, 2023 3:28 PM > To: dev@dpdk.org > Cc: sta...@dpdk.org; Yang, Qiming ; Zhou, YidingX > ; Deng, KaiwenX ; Wu, > Jingjing ; Xing, Beilei > Subject: [PATCH] net/iavf: fix virtchnl cmd called in intr thread > > When iavf se

RE: [PATCH v4] gro : ipv6 changes to support GRO for TCP/ipv6

2023-06-08 Thread Hu, Jiayu
Hi Kumara, In your replied mail, the line doesn’t preface with “>” and it’s hard to find your replies. So I reply here. In gro_tcp4_reassemble(), I mean there is no need to switch the sequences of tcp_hdr and sent_seq definition statements in the code, rather than not updating them. Thanks, Ji

Re: [PATCH] doc: document the new devargs syntax

2023-06-08 Thread Stephen Hemminger
This patch is still in patchwork and was never applied. Much has changed over the last 5 years, and the syntax of devargs and usage has changed. If nothing else the terminolgy needs to be fixed and resubmitted.

Re: [PATCH v2] ethdev: add Tx queue flow matching item

2023-06-08 Thread Thomas Monjalon
08/05/2023 15:49, kirankum...@marvell.com: > From: Kiran Kumar K > > Adding support for Tx queue flow matching item. > This item is valid only for egress rules. > An example use case would be that application can > set different vlan insert rules with different PCP values > based on Tx queue numb

[PATCH v2] config/arm: fix Neoverse N2 march flag

2023-06-08 Thread pbhagavatula
From: Pavan Nikhilesh The -march flag of Neoverse N2 should be removed with the introduction of -mcpu='neoverse-n2' as they are incompatible. Fixes: ea85ed1f6882 ("config/arm: increase nodes and cores for Neoverse N2") Signed-off-by: Pavan Nikhilesh Tested-by: Srikanth Yalavarthi --- v2 Chan

DPDK Release Status Meeting 2023-06-08

2023-06-08 Thread Mcnamara, John
Release status meeting minutes 2023-06-08 = Agenda: * Release Dates * Subtrees * Roadmaps * LTS * Defects * Opens Participants: * AMD * ARM * Intel * Marvell * Nvidia * Red Hat Release Dates - The following are the proposed current dates for

RE: [PATCH v17] app/procinfo: display eventdev xstats

2023-06-08 Thread Sevincer, Abdullah
>+Acked-by: Reshma Pattan >+Acked-by: Stephen Hemminger Reminder! What's the plan to merge this patch?

RE: [PATCH v3 00/13] Add MACsec unit test cases

2023-06-08 Thread Akhil Goyal
> Subject: [PATCH v3 00/13] Add MACsec unit test cases > > Inline MACsec offload was supported in DPDK 22.11 > using rte_security APIs. > This patchset adds few minor changes in the rte_security APIs > to specify the direction of SA/SC and update the SC configuration > to set packet number thresho

Re: [PATCH v4] gro : ipv6 changes to support GRO for TCP/ipv6

2023-06-08 Thread kumaraparameshwaran rathinavel
Hi Jiyau, Thanks for the quick review comments. Will address the review comments. Require clarification in one of the comments. Please find it inline. On Thu, Jun 8, 2023 at 9:35 AM Hu, Jiayu wrote: > Hi Kumara, > > Please see replies inline. > > In addition, you need to update the programmer g

Re: [PATCH v3] ether: use a default for max Rx frame size in configure()

2023-06-08 Thread Stephen Hemminger
Going through the patch archives and this patch might still be interesting, but the configuration of jumbo and receive packet length has changed over the last 5 years. If this is still an issue, please either file a bug in bugzilla and/or rebase the patch on the current release.

Re: [PATCH v2] SDK: Add scripts to initialize DPDK runtime

2023-06-08 Thread Stephen Hemminger
This patch is still interesting but has grown stale. - Patch pre-dates meson build system - Ubuntu and Debian have probably changed in 7 years If still interested in this, please modify and resubmit.

Re: [PATCH 0/4] net/sfc: support KEEP_CRC offload

2023-06-08 Thread Ferruh Yigit
On 6/1/2023 12:42 PM, Denis Pryazhennikov wrote: > This patch series adds support for RTE_ETH_RX_OFFLOAD_KEEP_CRC > offload in the SFC driver. > > Denis Pryazhennikov (3): > common/sfc_efx/base: detect and report FCS include support > common/sfc_efx/base: add support for configure MAC to keep

[PATCH v3] eal: choose IOVA mode according to compilation flags

2023-06-08 Thread Viacheslav Ovsiienko
The DPDK can be compiled to be run in IOVA VA mode with 'enable_iova_as_pa=false' meson option. If there is no explicit EAL --iova-mode parameter specified in the command line the rte_eal_init() tried to deduce VA or PA mode without taking into account the above mentioned compile time option, resul

Re: [PATCH 0/4] fix the data endian problem in IPv6 logic

2023-06-08 Thread Ferruh Yigit
On 6/8/2023 4:19 AM, Chaoyong He wrote: > This patch series fix the data endian problem in the logics related with > rte_flow of IPv6. > > Chaoyong He (4): > net/nfp: fix the IPv6 flow item > net/nfp: fix TOS of IPv6 VXLAN encap flow action > net/nfp: fix TOS of IPv6 GENEVE encap flow action

Re: [PATCH] net/bonding: fix iavf bond device query stats

2023-06-08 Thread Stephen Hemminger
On Thu, 8 Jun 2023 15:26:36 +0800 Kaiwen Deng wrote: > If the rte_eth_stats_get function does not work properly, > the update function of the slave device does not work > properly When device is bonded as BONDING_MODE_TLB mode. > > This commit adds handling for functions that do not get > stats

Re: [PATCH v11 00/16] graph enhancement for multi-core dispatch

2023-06-08 Thread Jerin Jacob
On Thu, Jun 8, 2023 at 8:55 PM Zhirun Yan wrote: > > V11: > Update comments and fix to add experimental flags for > rte_graph_model_is_valid() in patch 04. > Update added symbols in alphabetical order in version.map with patch > 04,05,06,08,10. > Update commit message in patch 16. + @Thomas Mon

[PATCH v11 16/16] examples/l3fwd-graph: introduce mcore dispatch worker model

2023-06-08 Thread Zhirun Yan
Add new parameter "model" to choose mcore dispatch or rtc model. And in dispatch model, the node will affinity to worker core successively. RTE_GRAPH_MODEL_SELECT is set to RTE_GRAPH_MODEL_RTC by default. Must set model the same as RTE_GRAPH_MODEL_SELECT if set it as rtc or mcore dispatch explicit

[PATCH v11 15/16] test/graph: add functional tests for mcore dispatch model

2023-06-08 Thread Zhirun Yan
Add functional test for mcore dispatch model including graph clone, graph model set/get, node worker affinity, graph worker binding/unbinding. Signed-off-by: Haiyue Wang Signed-off-by: Cunming Liang Signed-off-by: Zhirun Yan Acked-by: Pavan Nikhilesh --- app/test/test_graph.c | 130 ++

[PATCH v11 13/16] graph: enable graph multicore dispatch scheduler model

2023-06-08 Thread Zhirun Yan
This patch enables to chose new scheduler model. Must define RTE_GRAPH_MODEL_SELECT before including rte_graph_worker.h to enable specific model choosing. Signed-off-by: Haiyue Wang Signed-off-by: Cunming Liang Signed-off-by: Zhirun Yan Acked-by: Jerin Jacob Acked-by: Pavan Nikhilesh --- doc

[PATCH v11 14/16] graph: add stats for mcore dispatch model

2023-06-08 Thread Zhirun Yan
Add stats for mcore dispatch model if stats collection is enabled. Signed-off-by: Haiyue Wang Signed-off-by: Cunming Liang Signed-off-by: Zhirun Yan Acked-by: Jerin Jacob Acked-by: Pavan Nikhilesh --- lib/graph/graph_debug.c| 6 ++ lib/graph/graph_stats.c

[PATCH v11 12/16] graph: introduce graph walk by cross-core dispatch

2023-06-08 Thread Zhirun Yan
This patch introduces the task scheduler mechanism to enable dispatching tasks to another worker cores. Currently, there is only a local work queue for one graph to walk. We introduce a scheduler worker queue in each worker core for dispatching tasks. It will perform the walk on scheduler work queu

[PATCH v11 11/16] graph: enable create and destroy graph scheduling workqueue

2023-06-08 Thread Zhirun Yan
This patch enables to create and destroy scheduling workqueue into common graph operations. Signed-off-by: Haiyue Wang Signed-off-by: Cunming Liang Signed-off-by: Zhirun Yan Acked-by: Pavan Nikhilesh --- lib/graph/graph.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/lib/gra

[PATCH v11 10/16] graph: introduce stream moving cross cores

2023-06-08 Thread Zhirun Yan
This patch introduces key functions to allow a worker thread to enable enqueue and move streams of objects to the next nodes over different cores for mcore dispatch model. Signed-off-by: Haiyue Wang Signed-off-by: Cunming Liang Signed-off-by: Zhirun Yan Acked-by: Pavan Nikhilesh --- lib/graph

[PATCH v11 08/16] graph: introduce graph clone API for other worker core

2023-06-08 Thread Zhirun Yan
This patch adds graph API for supporting to clone the graph object for a specified worker core. The new graph will also clone all nodes. Signed-off-by: Haiyue Wang Signed-off-by: Cunming Liang Signed-off-by: Zhirun Yan Acked-by: Jerin Jacob --- lib/graph/graph.c | 89 +

[PATCH v11 09/16] graph: add structure for stream moving between cores

2023-06-08 Thread Zhirun Yan
Add graph_mcore_dispatch_wq_node to hold graph scheduling workqueue node. Signed-off-by: Haiyue Wang Signed-off-by: Cunming Liang Signed-off-by: Zhirun Yan --- lib/graph/graph.c | 2 ++ lib/graph/graph_populate.c | 1 + lib/graph/graph_private.h | 12

[PATCH v11 07/16] graph: move node clone name func into private as common

2023-06-08 Thread Zhirun Yan
Move clone_name() into graph_private.h as a common function for both node and graph to naming a new cloned object. Signed-off-by: Haiyue Wang Signed-off-by: Cunming Liang Signed-off-by: Zhirun Yan Acked-by: Jerin Jacob --- lib/graph/graph_private.h | 41 +++

[PATCH v11 06/16] graph: introduce graph bind unbind API

2023-06-08 Thread Zhirun Yan
Add lcore_id for graph to hold affinity core id where graph would run on. Add bind/unbind API to set/unset graph affinity attribute. lcore_id will be set as MAX by default, it means not enable this attribute. Signed-off-by: Haiyue Wang Signed-off-by: Cunming Liang Signed-off-by: Zhirun Yan Acke

[PATCH v11 05/16] graph: introduce graph node core affinity API

2023-06-08 Thread Zhirun Yan
Add lcore_id for node to hold affinity core id and impl rte_graph_model_mcore_dispatch_lcore_affinity_set to set node affinity with specific lcore. Signed-off-by: Haiyue Wang Signed-off-by: Cunming Liang Signed-off-by: Zhirun Yan Acked-by: Jerin Jacob --- lib/graph/graph_private.h

[PATCH v11 04/16] graph: add get/set graph worker model APIs

2023-06-08 Thread Zhirun Yan
Add new get/set APIs to configure graph worker model which is used to determine which model will be chosen. Signed-off-by: Haiyue Wang Signed-off-by: Cunming Liang Signed-off-by: Zhirun Yan Acked-by: Jerin Jacob --- lib/graph/meson.build | 1 + lib/graph/rte_graph_worker.c

[PATCH v11 03/16] graph: move node process into inline function

2023-06-08 Thread Zhirun Yan
Node process is a single and reusable block, move the code into an inline function. Signed-off-by: Haiyue Wang Signed-off-by: Cunming Liang Signed-off-by: Zhirun Yan Acked-by: Jerin Jacob --- lib/graph/rte_graph_model_rtc.h | 20 ++--- lib/graph/rte_graph_worker_common.h | 33

[PATCH v11 02/16] graph: split graph worker into common and default model

2023-06-08 Thread Zhirun Yan
To support multiple graph worker model, split graph into common and default. Naming the current walk function as rte_graph_model_rtc cause the default model is RTC(Run-to-completion). Signed-off-by: Haiyue Wang Signed-off-by: Cunming Liang Signed-off-by: Zhirun Yan Acked-by: Jerin Jacob --- l

[PATCH v11 01/16] graph: rename rte_graph_work as common

2023-06-08 Thread Zhirun Yan
Rename rte_graph_work.h to rte_graph_work_common.h for supporting multiple graph worker model. Signed-off-by: Haiyue Wang Signed-off-by: Cunming Liang Signed-off-by: Zhirun Yan Acked-by: Jerin Jacob --- MAINTAINERS | 3 ++- lib/graph/graph_pcap.

[PATCH v11 00/16] graph enhancement for multi-core dispatch

2023-06-08 Thread Zhirun Yan
V11: Update comments and fix to add experimental flags for rte_graph_model_is_valid() in patch 04. Update added symbols in alphabetical order in version.map with patch 04,05,06,08,10. Update commit message in patch 16. V10: Add rte_graph_worker_model_no_check_get() for fast path, extract rte_gr

Re: [PATCH] bitmap: add scan init at given position

2023-06-08 Thread Bruce Richardson
On Thu, Jun 08, 2023 at 02:20:13PM +, Dumitrescu, Cristian wrote: > Hi Volodymyr, > > Thanks for your patch, comments below under your code: > > > -Original Message- > > From: Thomas Monjalon > > Sent: Thursday, June 1, 2023 4:26 PM > > To: Dumitrescu, Cristian ; Volodymyr Fialko > >

Re: [PATCH] net/nfp: fix callback function pointer of disabling promisc

2023-06-08 Thread Ferruh Yigit
On 6/8/2023 4:07 AM, Chaoyong He wrote: > From: Qin Ke > > The callback function of promiscuous_disable in nfp_flower_pf_repr_dev_ops > and nfp_flower_repr_dev_ops should be nfp_net_promisc_disable, not > nfp_net_promisc_enable, fix it. > > Fixes: 39d82d2 ("net/nfp: fix promiscuous mode for repr

RE: [PATCH v1] event/dlb2: add support for disabling PASID

2023-06-08 Thread Chen, Mike Ximing
> From: Jerin Jacob > Sent: Thursday, June 8, 2023 7:32 AM > To: David Marchand > Cc: Sevincer, Abdullah ; Gaetan Rivet > ; Thomas Monjalon > ; dev@dpdk.org; jer...@marvell.com; Chen, Mike Ximing > > Subject: Re: [PATCH v1] event/dlb2: add support for disabling PASID > > On Thu, Jun 8, 2023 at

Re: [PATCH v7] app/testpmd: expand noisy neighbour forward mode support

2023-06-08 Thread Ferruh Yigit
On 6/8/2023 2:31 PM, Mike Pattrick wrote: > Previously the noisy neighbour vnf simulation would only operate in io > mode, forwarding packets as is. However, this limited the usefulness of > noisy neighbour simulation. > > This feature has now been expanded to supporting mac, macswap, and > 5tswap

Re: [PATCH v5 00/26] Add VDUSE support to Vhost library

2023-06-08 Thread Maxime Coquelin
On 6/6/23 10:18, Maxime Coquelin wrote: This series introduces a new type of backend, VDUSE, to the Vhost library. VDUSE stands for vDPA device in Userspace, it enables implementing a Virtio device in userspace and have it attached to the Kernel vDPA bus. Once attached to the vDPA bus, it ca

RE: [EXT] [PATCH v10 13/16] graph: enable graph multicore dispatch scheduler model

2023-06-08 Thread Pavan Nikhilesh Bhagavatula
> This patch enables to chose new scheduler model. Must define > RTE_GRAPH_MODEL_SELECT before including rte_graph_worker.h > to enable specific model choosing. > > Signed-off-by: Haiyue Wang > Signed-off-by: Cunming Liang > Signed-off-by: Zhirun Yan Acked-by: Pavan Nikhilesh > --- > doc/gui

RE: [PATCH] bitmap: add scan init at given position

2023-06-08 Thread Dumitrescu, Cristian
Hi Volodymyr, Thanks for your patch, comments below under your code: > -Original Message- > From: Thomas Monjalon > Sent: Thursday, June 1, 2023 4:26 PM > To: Dumitrescu, Cristian ; Volodymyr Fialko > > Cc: dev@dpdk.org; jer...@marvell.com; ano...@marvell.com > Subject: Re: [PATCH] bitm

RE: [PATCH] config/arm: fix Neoverse N2 march flag

2023-06-08 Thread Ruifeng Wang
> -Original Message- > From: Pavan Nikhilesh Bhagavatula > Sent: Thursday, June 8, 2023 8:59 PM > To: Ruifeng Wang ; jer...@marvell.com; Bruce Richardson > > Cc: dev@dpdk.org; Juraj Linkeš ; nd > Subject: RE: [PATCH] config/arm: fix Neoverse N2 march flag > > > > > -Original Messa

RE: [EXT] [PATCH v10 16/16] examples/l3fwd-graph: introduce mcore dispatch worker model

2023-06-08 Thread Yan, Zhirun
> -Original Message- > From: Pavan Nikhilesh Bhagavatula > Sent: Thursday, June 8, 2023 8:09 PM > To: Yan, Zhirun ; dev@dpdk.org; Jerin Jacob > Kollanukkaran ; Kiran Kumar Kokkilagadda > ; Nithin Kumar Dabilpuram > ; step...@networkplumber.org; > jerinjac...@gmail.com > Cc: Liang, Cunmi

RE: [PATCH v10 06/16] graph: introduce graph bind unbind API

2023-06-08 Thread Yan, Zhirun
> -Original Message- > From: Jerin Jacob > Sent: Thursday, June 8, 2023 6:41 PM > To: Yan, Zhirun > Cc: dev@dpdk.org; jer...@marvell.com; kirankum...@marvell.com; > ndabilpu...@marvell.com; step...@networkplumber.org; > pbhagavat...@marvell.com; Liang, Cunming ; Wang, > Haiyue ; mattias

RE: [PATCH] net/mlx5: fix actions template expansion

2023-06-08 Thread Raslan Darawsheh
Hello, > -Original Message- > From: Gregory Etelson > Sent: Thursday, June 8, 2023 3:16 PM > To: dev@dpdk.org > Cc: Gregory Etelson ; Raslan Darawsheh > > Subject: [PATCH] net/mlx5: fix actions template expansion > > Static actions definitions used in template expansion were defined in

RE: [EXT] [PATCH v10 12/16] graph: introduce graph walk by cross-core dispatch

2023-06-08 Thread Pavan Nikhilesh Bhagavatula
> This patch introduces the task scheduler mechanism to enable dispatching > tasks to another worker cores. Currently, there is only a local work > queue for one graph to walk. We introduce a scheduler worker queue in > each worker core for dispatching tasks. It will perform the walk on > scheduler

RE: [EXT] [PATCH v10 11/16] graph: enable create and destroy graph scheduling workqueue

2023-06-08 Thread Pavan Nikhilesh Bhagavatula
> This patch enables to create and destroy scheduling workqueue into > common graph operations. > > Signed-off-by: Haiyue Wang > Signed-off-by: Cunming Liang > Signed-off-by: Zhirun Yan Acked-by: Pavan Nikhilesh > --- > lib/graph/graph.c | 10 ++ > 1 file changed, 10 insertions(+) >

RE: [EXT] [PATCH v10 10/16] graph: introduce stream moving cross cores

2023-06-08 Thread Pavan Nikhilesh Bhagavatula
> This patch introduces key functions to allow a worker thread to > enable enqueue and move streams of objects to the next nodes over > different cores for mcore dispatch model. > > Signed-off-by: Haiyue Wang > Signed-off-by: Cunming Liang > Signed-off-by: Zhirun Yan Acked-by: Pavan Nikhilesh

[PATCH v7] app/testpmd: expand noisy neighbour forward mode support

2023-06-08 Thread Mike Pattrick
Previously the noisy neighbour vnf simulation would only operate in io mode, forwarding packets as is. However, this limited the usefulness of noisy neighbour simulation. This feature has now been expanded to supporting mac, macswap, and 5tswap modes. To facilitate adding this support, some new he

RE: [RFC] ring: improve ring performance with C11 atomics

2023-06-08 Thread Wathsala Wathawana Vithanage
The solution presented in this RFC is not C11 compliant. C11 __atomic_compare_exchange_n updates "expected" only when CAS instruction fails. Therefore, the assumption that there is an address dependency from CAS instructions in both producer/consumer head update to the ring element accesses fa

RE: [PATCH v6] crypto/qat: support to enable insecure algorithms

2023-06-08 Thread Power, Ciara
> -Original Message- > From: Vikash Poddar > Sent: Monday 29 May 2023 11:45 > To: Akhil Goyal ; Fan Zhang > ; Ji, Kai > Cc: dev@dpdk.org; Poddar, Vikash ChandraX > > Subject: [PATCH v6] crypto/qat: support to enable insecure algorithms > > All the insecure algorithms are default disa

RE: [EXT] [PATCH v10 14/16] graph: add stats for mcore dispatch model

2023-06-08 Thread Pavan Nikhilesh Bhagavatula
> Add stats for mcore dispatch model if stats collection is > enabled. > > Signed-off-by: Haiyue Wang > Signed-off-by: Cunming Liang > Signed-off-by: Zhirun Yan > Acked-by: Jerin Jacob Acked-by: Pavan Nikhilesh > --- > lib/graph/graph_debug.c| 6 ++ > lib/graph/graph_s

RE: [PATCH v1] common/qat: fix qat_dev_cmd_param corruption

2023-06-08 Thread Power, Ciara
> -Original Message- > From: Vikash Poddar > Sent: Tuesday 23 May 2023 10:07 > To: Ji, Kai > Cc: dev@dpdk.org; Poddar, Vikash ChandraX > ; Kusztal, ArkadiuszX > > Subject: [PATCH v1] common/qat: fix qat_dev_cmd_param corruption > > Adding fix to address the memory corruption issue fo

RE: [PATCH] config/arm: fix Neoverse N2 march flag

2023-06-08 Thread Pavan Nikhilesh Bhagavatula
> -Original Message- > From: Ruifeng Wang > Sent: Thursday, June 8, 2023 4:12 PM > To: Pavan Nikhilesh Bhagavatula ; Jerin Jacob > Kollanukkaran ; Bruce Richardson > > Cc: dev@dpdk.org; Juraj Linkeš ; nd > > Subject: [EXT] RE: [PATCH] config/arm: fix Neoverse N2 march flag > > Extern

Re: [PATCH v4 0/4] Support VFIO sparse mmap in PCI bus

2023-06-08 Thread Patrick Robb
On Thu, Jun 8, 2023 at 3:03 AM David Marchand wrote: > Hello Chenbo, Patrick, > > > On Thu, Jun 8, 2023 at 8:50 AM Xia, Chenbo wrote: > > > > This series introduces a VFIO standard capability, called sparse > > > > mmap to PCI bus. In linux kernel, it's defined as > > > > VFIO_REGION_INFO_CAP_SP

Re: [PATCH v5 00/26] Add VDUSE support to Vhost library

2023-06-08 Thread David Marchand
On Thu, Jun 8, 2023 at 11:17 AM Maxime Coquelin wrote: > On 6/7/23 10:05, David Marchand wrote: > > On Tue, Jun 6, 2023 at 10:19 AM Maxime Coquelin > > wrote: > >> > >> This series introduces a new type of backend, VDUSE, > >> to the Vhost library. > >> > >> VDUSE stands for vDPA device in Usersp

Re: [PATCH v4 2/3] common/sfc_efx/base: add support to enable VLAN stripping

2023-06-08 Thread Andrew Rybchenko
On 6/8/23 14:16, Artemii Morozov wrote: Hello, On 6/2/23 12:32, Andrew Rybchenko wrote: On 6/1/23 18:30, Artemii Morozov wrote: To enable VLAN stripping, two conditions must be met: the corresponding flag must be set and the appropriate RX prefix should be requested. RX -> Rx VLAN strippin

Re: [PATCH v4 00/34] net/sfc: support HW conntrack assistance

2023-06-08 Thread Andrew Rybchenko
On 6/7/23 16:02, Ivan Malov wrote: On EF100 hardware, match-action engine (MAE) can be equipped with an assistance table for connection tracking (CT). In it, an entry key is a set of exact match fields: an EtherType, a pair of IP addresses, a L4 protocol ID and a pair of L4 port numbers. An entry

RE: [EXT] [PATCH v10 15/16] test/graph: add functional tests for mcore dispatch model

2023-06-08 Thread Pavan Nikhilesh Bhagavatula
> Add functional test for mcore dispatch model including graph clone, > graph model set/get, node worker affinity, graph worker binding/unbinding. > > Signed-off-by: Haiyue Wang > Signed-off-by: Cunming Liang > Signed-off-by: Zhirun Yan Acked-by: Pavan Nikhilesh > --- > app/test/test_graph.c

RE: [PATCH v5] crypto/qat: default to IPsec MB for computations

2023-06-08 Thread Power, Ciara
> -Original Message- > From: Brian Dooley > Sent: Tuesday 6 June 2023 11:28 > To: Ji, Kai > Cc: dev@dpdk.org; gak...@marvell.com; De Lara Guarch, Pablo > ; Dooley, Brian > Subject: [PATCH v5] crypto/qat: default to IPsec MB for computations > > Pre and post computations currently use

[PATCH] net/mlx5: fix actions template expansion

2023-06-08 Thread Gregory Etelson
Static actions definitions used in template expansion were defined in conditional context. That context was destroyed by the time it's memory was accessed. Fixes: cf7f458b05f3 ("net/mlx5: add indirect QUOTA create/query/modify") Signed-off-by: Gregory Etelson --- drivers/net/mlx5/mlx5_flow_hw.c

RE: [EXT] [PATCH v10 16/16] examples/l3fwd-graph: introduce mcore dispatch worker model

2023-06-08 Thread Pavan Nikhilesh Bhagavatula
> Add new parameter "model" to choose mcore dispatch or rtc model. > And in dispatch model, the node will affinity to worker core successively. > > Note: > RTE_GRAPH_MODEL_SELECT is set to GRAPH_MODEL_RTC by default. Must Should be RTE_GRAPH_MODEL_RTC > set > model the same as RTE_GRAPH_MODEL_SE

Re: [PATCH v2 0/6] changes for 23.07

2023-06-08 Thread Maxime Coquelin
Hi Hernan, On 6/6/23 16:31, Vargas, Hernan wrote: Hi Maxime, Kind reminder to review this series when you have a chance: https://patchwork.dpdk.org/project/dpdk/list/?series=28189 As mentioned on V1, I plan to only pick the fixes I for which I gave my R-by in v23.07. The other patches will be

Re: [PATCH v6] app/testpmd: expand noisy neighbour forward mode support

2023-06-08 Thread Ferruh Yigit
On 6/8/2023 11:43 AM, Mike Pattrick wrote: > On Thu, Jun 8, 2023 at 6:25 AM Ferruh Yigit wrote: >> >> On 6/8/2023 10:59 AM, Mike Pattrick wrote: >>> Previously the noisy neighbour vnf simulation would only operate in io >>> mode, forwarding packets as is. However, this limited the usefulness of >>

Re: [PATCH v1] event/dlb2: add support for disabling PASID

2023-06-08 Thread Jerin Jacob
On Thu, Jun 8, 2023 at 12:59 PM David Marchand wrote: > > On Thu, Jun 8, 2023 at 7:38 AM Jerin Jacob wrote: > > > > On Thu, Jun 8, 2023 at 2:31 AM Abdullah Sevincer > > wrote: > > > > > > vfio-pci driver in Linux kernel 6.2 enables PASID by default. > > > In DLB hardware, enabling PASID puts DLB

Re: [PATCH v4 2/3] common/sfc_efx/base: add support to enable VLAN stripping

2023-06-08 Thread Artemii Morozov
Hello, On 6/2/23 12:32, Andrew Rybchenko wrote: On 6/1/23 18:30, Artemii Morozov wrote: To enable VLAN stripping, two conditions must be met: the corresponding flag must be set and the appropriate RX prefix should be requested. RX -> Rx VLAN stripping is supported for ef100 datapath only.

Re: [PATCH v10 16/16] examples/l3fwd-graph: introduce mcore dispatch worker model

2023-06-08 Thread Jerin Jacob
On Thu, Jun 8, 2023 at 3:36 PM Zhirun Yan wrote: > > Add new parameter "model" to choose mcore dispatch or rtc model. > And in dispatch model, the node will affinity to worker core successively. > > Note: Remove just the "Note" text. > RTE_GRAPH_MODEL_SELECT is set to GRAPH_MODEL_RTC by defaul

Re: [PATCH v6] app/testpmd: expand noisy neighbour forward mode support

2023-06-08 Thread Mike Pattrick
On Thu, Jun 8, 2023 at 6:25 AM Ferruh Yigit wrote: > > On 6/8/2023 10:59 AM, Mike Pattrick wrote: > > Previously the noisy neighbour vnf simulation would only operate in io > > mode, forwarding packets as is. However, this limited the usefulness of > > noisy neighbour simulation. > > > > This feat

Re: [PATCH v10 13/16] graph: enable graph multicore dispatch scheduler model

2023-06-08 Thread Jerin Jacob
On Thu, Jun 8, 2023 at 3:35 PM Zhirun Yan wrote: > > This patch enables to chose new scheduler model. Must define > RTE_GRAPH_MODEL_SELECT before including rte_graph_worker.h > to enable specific model choosing. > > Signed-off-by: Haiyue Wang > Signed-off-by: Cunming Liang > Signed-off-by: Zhiru

RE: [PATCH] config/arm: fix Neoverse N2 march flag

2023-06-08 Thread Ruifeng Wang
> -Original Message- > From: pbhagavat...@marvell.com > Sent: Thursday, June 8, 2023 3:28 PM > To: jer...@marvell.com; Ruifeng Wang ; Bruce Richardson > > Cc: dev@dpdk.org; Pavan Nikhilesh > Subject: [PATCH] config/arm: fix Neoverse N2 march flag > > From: Pavan Nikhilesh > > The -mar

Re: [PATCH v10 06/16] graph: introduce graph bind unbind API

2023-06-08 Thread Jerin Jacob
On Thu, Jun 8, 2023 at 3:35 PM Zhirun Yan wrote: > > Add lcore_id for graph to hold affinity core id where graph would run on. > Add bind/unbind API to set/unset graph affinity attribute. lcore_id will > be set as MAX by default, it means not enable this attribute. > > diff --git a/lib/graph/vers

Re: [PATCH v10 04/16] graph: add get/set graph worker model APIs

2023-06-08 Thread Jerin Jacob
On Thu, Jun 8, 2023 at 3:35 PM Zhirun Yan wrote: > > Add new get/set APIs to configure graph worker model which is used to > determine which model will be chosen. > > Signed-off-by: Haiyue Wang > Signed-off-by: Cunming Liang > Signed-off-by: Zhirun Yan > > +/** Graph worker models */ > +/* If a

Re: [PATCH v6] app/testpmd: expand noisy neighbour forward mode support

2023-06-08 Thread Ferruh Yigit
On 6/8/2023 10:59 AM, Mike Pattrick wrote: > Previously the noisy neighbour vnf simulation would only operate in io > mode, forwarding packets as is. However, this limited the usefulness of > noisy neighbour simulation. > > This feature has now been expanded to supporting mac, macswap, and > 5tswa

[PATCH v10 15/16] test/graph: add functional tests for mcore dispatch model

2023-06-08 Thread Zhirun Yan
Add functional test for mcore dispatch model including graph clone, graph model set/get, node worker affinity, graph worker binding/unbinding. Signed-off-by: Haiyue Wang Signed-off-by: Cunming Liang Signed-off-by: Zhirun Yan --- app/test/test_graph.c | 130 +

[PATCH v10 16/16] examples/l3fwd-graph: introduce mcore dispatch worker model

2023-06-08 Thread Zhirun Yan
Add new parameter "model" to choose mcore dispatch or rtc model. And in dispatch model, the node will affinity to worker core successively. Note: RTE_GRAPH_MODEL_SELECT is set to GRAPH_MODEL_RTC by default. Must set model the same as RTE_GRAPH_MODEL_SELECT If set it as rtc or mcore dispatch explic

[PATCH v10 14/16] graph: add stats for mcore dispatch model

2023-06-08 Thread Zhirun Yan
Add stats for mcore dispatch model if stats collection is enabled. Signed-off-by: Haiyue Wang Signed-off-by: Cunming Liang Signed-off-by: Zhirun Yan Acked-by: Jerin Jacob --- lib/graph/graph_debug.c| 6 ++ lib/graph/graph_stats.c| 76 ++

[PATCH v10 12/16] graph: introduce graph walk by cross-core dispatch

2023-06-08 Thread Zhirun Yan
This patch introduces the task scheduler mechanism to enable dispatching tasks to another worker cores. Currently, there is only a local work queue for one graph to walk. We introduce a scheduler worker queue in each worker core for dispatching tasks. It will perform the walk on scheduler work queu

[PATCH v10 13/16] graph: enable graph multicore dispatch scheduler model

2023-06-08 Thread Zhirun Yan
This patch enables to chose new scheduler model. Must define RTE_GRAPH_MODEL_SELECT before including rte_graph_worker.h to enable specific model choosing. Signed-off-by: Haiyue Wang Signed-off-by: Cunming Liang Signed-off-by: Zhirun Yan --- doc/guides/prog_guide/graph_lib.rst | 71

[PATCH v10 11/16] graph: enable create and destroy graph scheduling workqueue

2023-06-08 Thread Zhirun Yan
This patch enables to create and destroy scheduling workqueue into common graph operations. Signed-off-by: Haiyue Wang Signed-off-by: Cunming Liang Signed-off-by: Zhirun Yan --- lib/graph/graph.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/lib/graph/graph.c b/lib/graph/grap

[PATCH v10 10/16] graph: introduce stream moving cross cores

2023-06-08 Thread Zhirun Yan
This patch introduces key functions to allow a worker thread to enable enqueue and move streams of objects to the next nodes over different cores for mcore dispatch model. Signed-off-by: Haiyue Wang Signed-off-by: Cunming Liang Signed-off-by: Zhirun Yan --- lib/graph/graph.c

[PATCH v10 09/16] graph: add structure for stream moving between cores

2023-06-08 Thread Zhirun Yan
Add graph_mcore_dispatch_wq_node to hold graph scheduling workqueue node. Signed-off-by: Haiyue Wang Signed-off-by: Cunming Liang Signed-off-by: Zhirun Yan --- lib/graph/graph.c | 2 ++ lib/graph/graph_populate.c | 1 + lib/graph/graph_private.h | 12

[PATCH v10 08/16] graph: introduce graph clone API for other worker core

2023-06-08 Thread Zhirun Yan
This patch adds graph API for supporting to clone the graph object for a specified worker core. The new graph will also clone all nodes. Signed-off-by: Haiyue Wang Signed-off-by: Cunming Liang Signed-off-by: Zhirun Yan Acked-by: Jerin Jacob --- lib/graph/graph.c | 89 +

[PATCH v10 07/16] graph: move node clone name func into private as common

2023-06-08 Thread Zhirun Yan
Move clone_name() into graph_private.h as a common function for both node and graph to naming a new cloned object. Signed-off-by: Haiyue Wang Signed-off-by: Cunming Liang Signed-off-by: Zhirun Yan Acked-by: Jerin Jacob --- lib/graph/graph_private.h | 41 +++

[PATCH v10 06/16] graph: introduce graph bind unbind API

2023-06-08 Thread Zhirun Yan
Add lcore_id for graph to hold affinity core id where graph would run on. Add bind/unbind API to set/unset graph affinity attribute. lcore_id will be set as MAX by default, it means not enable this attribute. Signed-off-by: Haiyue Wang Signed-off-by: Cunming Liang Signed-off-by: Zhirun Yan Acke

  1   2   >