RE: [PATCH v5 00/26] Add VDUSE support to Vhost library

2023-06-06 Thread Xia, Chenbo
Hi Maxime, > -Original Message- > From: Maxime Coquelin > Sent: Tuesday, June 6, 2023 4:18 PM > To: dev@dpdk.org; Xia, Chenbo ; > david.march...@redhat.com; m...@redhat.com; f...@redhat.com; > jasow...@redhat.com; Liang, Cunming ; Xie, Yongji > ; echau...@redhat.com; epere...@redhat.com;

RE: [PATCH v1 2/2] net/mlx5/hws: add support for infiniband BTH match

2023-06-06 Thread Ori Kam
> -Original Message- > From: Bill Zhou > Sent: Tuesday, June 6, 2023 2:07 PM > To: Ori Kam ; Alex Vesker ; Slava > Ovsiienko ; NBU-Contact-Thomas Monjalon > (EXTERNAL) ; Matan Azrad ; > Suanming Mou > Cc: dev@dpdk.org; Raslan Darawsheh > Subject: [PATCH v1 2/2] net/mlx5/hws: add suppor

RE: [EXT] [PATCH v5 3/5] eal/interrupts: add IRQ count in interrupt handle

2023-06-06 Thread Harman Kalra
> -Original Message- > From: Nipun Gupta > Sent: Tuesday, June 6, 2023 12:57 PM > To: Harman Kalra ; dev@dpdk.org; > tho...@monjalon.net; david.march...@redhat.com; > anatoly.bura...@intel.com; step...@networkplumber.org > Cc: ferruh.yi...@amd.com; harpreet.an...@amd.com; > nikhil.agar..

[PATCH v8 4/4] bus/cdx: support plug unplug and dev iterator

2023-06-06 Thread Nipun Gupta
This change adds support for plugging and unplugging CDX devices on AMD CDX bus. Also, CDX dev iterator support has been added for the CDX bus. Signed-off-by: Nipun Gupta Acked-by: Ferruh Yigit --- drivers/bus/cdx/bus_cdx_driver.h | 1 + drivers/bus/cdx/cdx.c| 122

[PATCH v8 3/4] bus/cdx: add support for MSI

2023-06-06 Thread Nipun Gupta
MSI's are exposed to the devices using VFIO (vfio-cdx). This patch uses the same to add support for MSI for the devices on the cdx bus. Signed-off-by: Nipun Gupta Acked-by: Ferruh Yigit --- drivers/bus/cdx/bus_cdx_driver.h | 25 + drivers/bus/cdx/cdx.c| 11 ++ drivers/bus/cdx/

[PATCH v8 2/4] bus/cdx: add DMA map and unmap support

2023-06-06 Thread Nipun Gupta
AMD CDX bus can use VFIO interface for mapping and unmapping of DMA addresses in the IOMMU. This change adds the callback support for map and unmap APIs as well as fetching the IOMMU class. Signed-off-by: Nipun Gupta Acked-by: Ferruh Yigit --- drivers/bus/cdx/cdx.c | 30

[PATCH v8 1/4] bus/cdx: introduce AMD CDX bus

2023-06-06 Thread Nipun Gupta
AMD CDX bus supports multiple type of devices, which can be exposed to user-space via vfio-cdx. vfio-cdx provides the MMIO IO_MEMORY regions as well as the DMA interface for the device (IOMMU). This support aims to enable the DPDK to support the cdx devices in user-space using VFIO interface. Si

[PATCH v8 0/4] Support AMD CDX bus

2023-06-06 Thread Nipun Gupta
The CDX devices are memory mapped on system bus for embedded CPUs. It uses sysfs interface and the vfio-cdx driver to discover and initialize the CDX devices. The CDX bus and VFIO support is available at Xilinx/AMD open source tree: https://github.com/Xilinx/linux-xlnx (drivers/cdx/ and drivers/v

RE: [PATCH v4] net/iavf: fix iavf query stats in intr thread

2023-06-06 Thread Zhang, Qi Z
> -Original Message- > From: Deng, KaiwenX > Sent: Wednesday, June 7, 2023 10:04 AM > To: dev@dpdk.org > Cc: sta...@dpdk.org; Yang, Qiming ; Zhou, YidingX > ; Deng, KaiwenX ; Chas > Williams ; Min Hu (Connor) ; Wu, > Jingjing ; Xing, Beilei ; Zhang, > Qi Z ; Mike Pattrick ; Doherty, > D

[PATCH v9 17/17] doc: update multicore dispatch model in graph guides

2023-06-06 Thread Zhirun Yan
Update graph documentation to introduce new multicore dispatch model. Signed-off-by: Haiyue Wang Signed-off-by: Cunming Liang Signed-off-by: Zhirun Yan --- doc/guides/prog_guide/graph_lib.rst | 68 +++-- 1 file changed, 64 insertions(+), 4 deletions(-) diff --git a/doc

[PATCH v9 16/17] test/graph: add functional tests for mcore dispatch model

2023-06-06 Thread Zhirun Yan
Add functional test for mcore dispatch model including graph clone, graph model set/get, node worker affinity, graph worker binding/unbinding. Signed-off-by: Haiyue Wang Signed-off-by: Cunming Liang Signed-off-by: Zhirun Yan --- app/test/test_graph.c | 130 +

[PATCH v9 15/17] examples/l3fwd-graph: introduce multicore dispatch worker model

2023-06-06 Thread Zhirun Yan
Add new parameter "model" to choose mcore dispatch or rtc model. And in dispatch model, the node will affinity to worker core successively. Note: RTE_GRAPH_MODEL_SELECT is set to GRAPH_MODEL_RTC by default. Must set model the same as RTE_GRAPH_MODEL_SELECT If set it as rtc or mcore dispatch explic

[PATCH v9 14/17] graph: add stats for cross-core dispatching

2023-06-06 Thread Zhirun Yan
Add stats for cross-core dispatching scheduler if stats collection is enabled. Signed-off-by: Haiyue Wang Signed-off-by: Cunming Liang Signed-off-by: Zhirun Yan --- lib/graph/graph_debug.c| 6 ++ lib/graph/graph_stats.c| 76 +++--- lib/g

[PATCH v9 13/17] graph: enable graph multicore dispatch scheduler model

2023-06-06 Thread Zhirun Yan
This patch enables to chose new scheduler model. Must define RTE_GRAPH_MODEL_SELECT before including rte_graph_worker.h to enable specific model choosing. Signed-off-by: Haiyue Wang Signed-off-by: Cunming Liang Signed-off-by: Zhirun Yan --- lib/graph/rte_graph_worker.h | 12 1 fil

[PATCH v9 12/17] graph: introduce graph walk by cross-core dispatch

2023-06-06 Thread Zhirun Yan
This patch introduces the task scheduler mechanism to enable dispatching tasks to another worker cores. Currently, there is only a local work queue for one graph to walk. We introduce a scheduler worker queue in each worker core for dispatching tasks. It will perform the walk on scheduler work queu

[PATCH v9 11/17] graph: enable create and destroy graph scheduling workqueue

2023-06-06 Thread Zhirun Yan
This patch enables to create and destroy scheduling workqueue into common graph operations. Signed-off-by: Haiyue Wang Signed-off-by: Cunming Liang Signed-off-by: Zhirun Yan --- lib/graph/graph.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/lib/graph/graph.c b/lib/graph/grap

[PATCH v9 10/17] graph: introduce stream moving cross cores

2023-06-06 Thread Zhirun Yan
This patch introduces key functions to allow a worker thread to enable enqueue and move streams of objects to the next nodes over different cores for mcore dispatch model. Signed-off-by: Haiyue Wang Signed-off-by: Cunming Liang Signed-off-by: Zhirun Yan --- lib/graph/graph.c

[PATCH v9 09/17] graph: add structure for stream moving between cores

2023-06-06 Thread Zhirun Yan
Add graph_mcore_dispatch_wq_node to hold graph scheduling workqueue node. Signed-off-by: Haiyue Wang Signed-off-by: Cunming Liang Signed-off-by: Zhirun Yan --- lib/graph/graph.c | 2 ++ lib/graph/graph_populate.c | 1 + lib/graph/graph_private.h | 12

[PATCH v9 08/17] graph: introduce graph clone API for other worker core

2023-06-06 Thread Zhirun Yan
This patch adds graph API for supporting to clone the graph object for a specified worker core. The new graph will also clone all nodes. Signed-off-by: Haiyue Wang Signed-off-by: Cunming Liang Signed-off-by: Zhirun Yan --- lib/graph/graph.c | 89 +++

[PATCH v9 07/17] graph: move node clone name func into private as common

2023-06-06 Thread Zhirun Yan
Move clone_name() into graph_private.h as a common function for both node and graph to naming a new cloned object. Signed-off-by: Haiyue Wang Signed-off-by: Cunming Liang Signed-off-by: Zhirun Yan --- lib/graph/graph_private.h | 41 +++ lib/graph/node.c

[PATCH v9 06/17] graph: introduce graph bind unbind API

2023-06-06 Thread Zhirun Yan
Add lcore_id for graph to hold affinity core id where graph would run on. Add bind/unbind API to set/unset graph affinity attribute. lcore_id will be set as MAX by default, it means not enable this attribute. Signed-off-by: Haiyue Wang Signed-off-by: Cunming Liang Signed-off-by: Zhirun Yan ---

[PATCH v9 05/17] graph: introduce graph node core affinity API

2023-06-06 Thread Zhirun Yan
Add lcore_id for node to hold affinity core id and impl rte_graph_model_mcore_dispatch_lcore_affinity_set to set node affinity with specific lcore. Signed-off-by: Haiyue Wang Signed-off-by: Cunming Liang Signed-off-by: Zhirun Yan --- lib/graph/graph_private.h | 2 + lib/graph

[PATCH v9 03/17] graph: move node process into inline function

2023-06-06 Thread Zhirun Yan
Node process is a single and reusable block, move the code into an inline function. Signed-off-by: Haiyue Wang Signed-off-by: Cunming Liang Signed-off-by: Zhirun Yan --- lib/graph/rte_graph_model_rtc.h | 20 ++--- lib/graph/rte_graph_worker_common.h | 33 +++

[PATCH v9 04/17] graph: add get/set graph worker model APIs

2023-06-06 Thread Zhirun Yan
Add new get/set APIs to configure graph worker model which is used to determine which model will be chosen. Signed-off-by: Haiyue Wang Signed-off-by: Cunming Liang Signed-off-by: Zhirun Yan --- lib/graph/meson.build | 1 + lib/graph/rte_graph_worker.c| 21 ++ lib

[PATCH v9 02/17] graph: split graph worker into common and default model

2023-06-06 Thread Zhirun Yan
To support multiple graph worker model, split graph into common and default. Naming the current walk function as rte_graph_model_rtc cause the default model is RTC(Run-to-completion). Signed-off-by: Haiyue Wang Signed-off-by: Cunming Liang Signed-off-by: Zhirun Yan --- lib/graph/graph_pcap.c

[PATCH v9 01/17] graph: rename rte_graph_work as common

2023-06-06 Thread Zhirun Yan
Rename rte_graph_work.h to rte_graph_work_common.h for supporting multiple graph worker model. Signed-off-by: Haiyue Wang Signed-off-by: Cunming Liang Signed-off-by: Zhirun Yan --- MAINTAINERS | 3 ++- lib/graph/graph_pcap.c

[PATCH v9 00/17] graph enhancement for multi-core dispatch

2023-06-06 Thread Zhirun Yan
V9: Fix CI build issues for doc building(move TAILQ next pointer out of union) in patch 09,10. Fix graph model check in rte_graph_worker_model_set() in patch 04. Fix typo in doc. V8: No performance dorp for original l3fwd-graph and graph_perf_autotest. Update graph model set/get functions and ad

RE: [PATCH v3 1/3] cryptodev: add SM2 asymmetric crypto algorithm

2023-06-06 Thread Gowrishankar Muthukrishnan
> Acked-by: Arek Kusztal > > Some things will need to be changed before the next release (few of them I > described below), but I will ack it. Especially that other algorithms have > similar > issues. > Sure. I also thought any improvements can collectively addressed as it is another EC. > >

RE: [PATCH v3 0/2] enhance bonding PMD to support the LACP negotiation

2023-06-06 Thread Chaoyong He
> On 6/6/2023 2:23 AM, Chaoyong He wrote: > > A gentle ping on this series. ... > >>> Long Wu (2): > >>> net/bonding: add independent LACP sending function > >>> app/testpmd: add support for bonding port's LACP negotiation > >>> > >>> app/test-pmd/config.c | 19 > >

[PATCH v4] net/iavf: fix iavf query stats in intr thread

2023-06-06 Thread Kaiwen Deng
When iavf send query-stats command in eal-intr-thread through virtual channel, there will be no response received from iavf_dev_virtchnl_handler for this command during block and wait. Because iavf_dev_virtchnl_handler is also registered in eal-intr-thread. When vf device is bonded as BONDING_MODE

[PATCH] doc: announce inclusive naming macro name changes

2023-06-06 Thread Chaoyong He
From: Long Wu In order to support inclusive naming, some of the macro in DPDK will need to be renamed. Do this through deprecation process now for 23.07. Signed-off-by: Long Wu Reviewed-by: Chaoyong He --- Depends-on: patch-127084 ("doc: announce inclusive naming function name") --- doc/guide

[PATCH 10/10] net/nfp: merge the recv function

2023-06-06 Thread Chaoyong He
Refactor the logic of parse metadata to include all the supported metadata type in one function. If a packet received carried metadata type 'PORT_ID', then it should be dispatched to the corresponding ring of the representor port, else it should be put into the array of the caller function. This

[PATCH 09/10] net/nfp: add the xmit function of NFDk for PF representor

2023-06-06 Thread Chaoyong He
The only different logic between the NFDk xmit function of PF representor and PF is if the logic about metadata exists. Refactor the NFDk xmit function and use a parameter to distinguish them. Signed-off-by: Chaoyong He Reviewed-by: Niklas Söderlund --- drivers/net/nfp/flower/nfp_flower.c | 15

[PATCH 08/10] net/nfp: merge the xmit function of NFD3

2023-06-06 Thread Chaoyong He
The only different logic between the NFD3 xmit function of PF representor port and PF is if the logic about metadata exists. So squash the NFD3 xmit function and use a parameter to distinguish them. Signed-off-by: Chaoyong He Reviewed-by: Niklas Söderlund --- drivers/net/nfp/flower/nfp_flower.c

[PATCH 07/10] net/nfp: add a dispatch layer for Tx function of representor

2023-06-06 Thread Chaoyong He
The dispatch layer aims to choose the corresponding Tx function within NFD3 version and NFDk version for reprsentor port. Signed-off-by: Chaoyong He Reviewed-by: Niklas Söderlund --- drivers/net/nfp/flower/nfp_flower.c | 29 +++-- drivers/net/nfp/flower/nfp_flower.h | 3

[PATCH 06/10] net/nfp: add the xmit function of NFDk for ctrl VNIC

2023-06-06 Thread Chaoyong He
Add the xmit function of NFDk for ctrl VNIC. Signed-off-by: Chaoyong He Reviewed-by: Niklas Söderlund --- drivers/net/nfp/flower/nfp_flower_ctrl.c | 138 ++- drivers/net/nfp/nfdk/nfp_nfdk.h | 2 + drivers/net/nfp/nfdk/nfp_nfdk_dp.c | 2 +- 3 files changed,

[PATCH 05/10] net/nfp: add a dispatch layer for Tx function of ctrl VNIC

2023-06-06 Thread Chaoyong He
The dispatch layer aims to choose the corresponding Tx function within NFD3 version and NFDk version for ctrl VNIC. Signed-off-by: Chaoyong He Reviewed-by: Niklas Söderlund --- drivers/net/nfp/flower/nfp_flower.c | 1 + drivers/net/nfp/flower/nfp_flower.h | 3 +++ drivers/net/nfp/fl

[PATCH 04/10] net/nfp: add the insert metadata logic of NFDk

2023-06-06 Thread Chaoyong He
NFD3 and NFDk have the same format metadata for the RX direction, while they are different for the TX direction. Add the insert metadata logic of NFDk. Signed-off-by: Chaoyong He Reviewed-by: Niklas Söderlund --- drivers/net/nfp/flower/nfp_flower.c | 8 +++- drivers/net/nfp/nfdk/nfp_nfdk.

[PATCH 03/10] net/nfp: refactor the insert metadata logic of NFD3

2023-06-06 Thread Chaoyong He
Extract the insert metadata logic of NFD3 into a single function to simplify the logics. Add the data structure aims to hold all the different function pointers which related to different NFD version. Also add a register function to initialize the function pointers. Signed-off-by: Chaoyong He R

[PATCH 02/10] net/nfp: add a check function for the NFD version

2023-06-06 Thread Chaoyong He
Add a check function for the NFD version, this will make the logics which using this version free from validaty check, thus simplify the driver. Signed-off-by: Chaoyong He Reviewed-by: Niklas Söderlund --- drivers/net/nfp/flower/nfp_flower.c | 3 +++ drivers/net/nfp/nfp_common.c| 37 ++

[PATCH 01/10] net/nfp: fix the problem of rtsym

2023-06-06 Thread Chaoyong He
The symbol '_abi_flower_extra_features' is in IMEM for NFP4000, but in EMU_CACHE for NFP3800 because which does not have IMEM. The original logic can't read symbol from EMU_CACHE, so the probe process will fail when we try to offload flows use NFP3800. Modify the related data structure and logics

[PATCH 00/10] support rte_flow for flower firmware with NFDk

2023-06-06 Thread Chaoyong He
This patch series add the support of rte_flow for card which using flower firmware with NFDk: 1. Fix the underlying API logic to support this feature. 2. Import a unified check and dispatch layer for different versions of NFD. 3. Refactor the meta data logic to adapt this dispatch layer. 4. Refacto

RE: [PATCH 3/4] net/ice: enable UDP fragmentation offload

2023-06-06 Thread Zhang, Qi Z
> -Original Message- > From: Zeng, ZhichaoX > Sent: Thursday, April 13, 2023 1:35 PM > To: dev@dpdk.org > Cc: Zhang, Qi Z ; Xu, Ke1 ; Zeng, > ZhichaoX ; Yang, Qiming > Subject: [PATCH 3/4] net/ice: enable UDP fragmentation offload > > This commit enables transmit segmentation offload

RE: [PATCH 4/4] net/iavf: enable UDP fragmentation offload

2023-06-06 Thread Zhang, Qi Z
> -Original Message- > From: Xu, Ke1 > Sent: Wednesday, May 24, 2023 1:21 PM > To: Zeng, ZhichaoX ; dev@dpdk.org > Cc: Zhang, Qi Z ; Wu, Jingjing > ; Xing, Beilei ; Xu, Ke1 > > Subject: RE: [PATCH 4/4] net/iavf: enable UDP fragmentation offload > > > From: Zeng, ZhichaoX > > Sent: Th

RE: [PATCH] net/igc: support device I225-LMVP

2023-06-06 Thread Zhang, Qi Z
> -Original Message- > From: Qiming Yang > Sent: Friday, May 26, 2023 4:23 PM > To: dev@dpdk.org > Cc: Yang, Qiming > Subject: [PATCH] net/igc: support device I225-LMVP > > Add support for I225-LMVP device. > > Signed-off-by: Qiming Yang Acked-by: Qi Zhang Applied to dpdk-next-ne

RE: [PATCH] net/e1000: support device I219

2023-06-06 Thread Zhang, Qi Z
> -Original Message- > From: Qiming Yang > Sent: Tuesday, May 30, 2023 5:54 PM > To: dev@dpdk.org > Cc: Yang, Qiming > Subject: [PATCH] net/e1000: support device I219 > > support device I219 LM22, V22, LM23 and V23. > > Signed-off-by: Qiming Yang Acked-by: Qi Zhang Applied to dpd

Re: [PATCH v6 1/4] ethdev: add API for mbufs recycle mode

2023-06-06 Thread Ferruh Yigit
On 6/6/2023 9:34 AM, Konstantin Ananyev wrote: > > >> >> [...] Probably I am missing something, but why it is not possible to do something >>> like that: rte_eth_recycle_mbufs(rx_port_id=X, rx_queue_id=Y, tx_port_id=N, tx_queue_id=M, ...); rte_eth_recycle_mbufs(rx_po

Re: [PATCH v5] app/testpmd: expand noisy neighbour forward mode support

2023-06-06 Thread Ferruh Yigit
On 6/6/2023 10:12 PM, Mike Pattrick wrote: > Previously the noisy neighbour vnf simulation would only operate in io > mode, forwarding packets as is. However, this limited the usefulness of > noisy neighbour simulation. > > This feature has now been expanded to supporting mac, macswap, and > 5tswa

[PATCH v5 6/6] net/ring: replace rte atomics with GCC builtin atomics

2023-06-06 Thread Tyler Retzlaff
Replace the use of rte_atomic.h types and functions, instead use GCC supplied C++11 memory model builtins. Signed-off-by: Tyler Retzlaff Acked-by: Morten Brørup Acked-by: Bruce Richardson --- drivers/net/ring/rte_eth_ring.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deleti

[PATCH v5 5/6] net/null: replace rte atomics with GCC builtin atomics

2023-06-06 Thread Tyler Retzlaff
Replace the use of rte_atomic.h types and functions, instead use GCC supplied C++11 memory model builtins. Signed-off-by: Tyler Retzlaff Acked-by: Morten Brørup --- drivers/net/null/rte_eth_null.c | 28 ++-- 1 file changed, 18 insertions(+), 10 deletions(-) diff --git a

[PATCH v5 2/6] dma/idxd: replace rte atomics with GCC builtin atomics

2023-06-06 Thread Tyler Retzlaff
Replace the use of rte_atomic.h types and functions, instead use GCC supplied C++11 memory model builtins. Signed-off-by: Tyler Retzlaff Acked-by: Morten Brørup Acked-by: Bruce Richardson Acked-by: Kevin Laatz --- drivers/dma/idxd/idxd_internal.h | 3 +-- drivers/dma/idxd/idxd_pci.c | 1

[PATCH v5 4/6] net/ixgbe: replace rte atomics with GCC builtin atomics

2023-06-06 Thread Tyler Retzlaff
Replace the use of rte_atomic.h types and functions, instead use GCC supplied C++11 memory model builtins. Signed-off-by: Tyler Retzlaff Acked-by: Morten Brørup --- drivers/net/ixgbe/ixgbe_bypass.c | 1 - drivers/net/ixgbe/ixgbe_ethdev.c | 18 -- drivers/net/ixgbe/ixgbe_ethdev.

[PATCH v5 0/6] replace rte atomics with GCC builtin atomics

2023-06-06 Thread Tyler Retzlaff
Replace the use of rte_atomic.h types and functions, instead use GCC supplied C++11 memory model builtins. This series covers the libraries and drivers that are built on Windows. The code has be converted to use the __atomic builtins but there are additional during conversion I notice that there

[PATCH v5 1/6] stack: replace rte atomics with GCC builtin atomics

2023-06-06 Thread Tyler Retzlaff
Replace the use of rte_atomic.h types and functions, instead use GCC supplied C++11 memory model builtins. Signed-off-by: Tyler Retzlaff Acked-by: Morten Brørup --- lib/stack/rte_stack_lf_generic.h | 16 +--- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/lib/stack/rt

[PATCH v5 3/6] net/ice: replace rte atomics with GCC builtin atomics

2023-06-06 Thread Tyler Retzlaff
Replace the use of rte_atomic.h types and functions, instead use GCC supplied C++11 memory model builtins. Signed-off-by: Tyler Retzlaff Acked-by: Morten Brørup --- drivers/net/ice/ice_dcf.c| 1 - drivers/net/ice/ice_dcf_ethdev.c | 1 - drivers/net/ice/ice_ethdev.c | 12 --

Re: [PATCH v5] app/testpmd: expand noisy neighbour forward mode support

2023-06-06 Thread Ferruh Yigit
On 6/6/2023 10:37 PM, Ferruh Yigit wrote: > On 6/6/2023 10:12 PM, Mike Pattrick wrote: >> Previously the noisy neighbour vnf simulation would only operate in io >> mode, forwarding packets as is. However, this limited the usefulness of >> noisy neighbour simulation. >> >> This feature has now been

Re: [PATCH v5] app/testpmd: expand noisy neighbour forward mode support

2023-06-06 Thread Ferruh Yigit
On 6/6/2023 10:12 PM, Mike Pattrick wrote: > Previously the noisy neighbour vnf simulation would only operate in io > mode, forwarding packets as is. However, this limited the usefulness of > noisy neighbour simulation. > > This feature has now been expanded to supporting mac, macswap, and > 5tswa

[PATCH v5] app/testpmd: expand noisy neighbour forward mode support

2023-06-06 Thread Mike Pattrick
Previously the noisy neighbour vnf simulation would only operate in io mode, forwarding packets as is. However, this limited the usefulness of noisy neighbour simulation. This feature has now been expanded to supporting mac, macswap, and 5tswap modes. To facilitate adding this support, some new he

RE: [PATCH v1 1/1] doc: announce change in bbdev api related to operation extension

2023-06-06 Thread Chautru, Nicolas
Hi David, > -Original Message- > From: David Marchand > Sent: Tuesday, June 6, 2023 2:21 AM > To: Chautru, Nicolas > Cc: Maxime Coquelin ; Stephen Hemminger > ; dev@dpdk.org; Rix, Tom > ; hemant.agra...@nxp.com; Vargas, Hernan > > Subject: Re: [PATCH v1 1/1] doc: announce change in bbd

RE: [PATCH v3 1/3] cryptodev: add SM2 asymmetric crypto algorithm

2023-06-06 Thread Kusztal, ArkadiuszX
Acked-by: Arek Kusztal Some things will need to be changed before the next release (few of them I described below), but I will ack it. Especially that other algorithms have similar issues. > -Original Message- > From: Gowrishankar Muthukrishnan > Sent: Sunday, June 4, 2023 11:43 AM >

Re: [RFC] app/testpmd: use RSS conf from software when configuring DCB

2023-06-06 Thread Ferruh Yigit
On 5/8/2023 2:21 AM, zhoumin wrote: > Kindly ping. > Hi Min, Sorry for the delay. > Should we solve this problem by modifying PMDs? > > Is it suitable to maintain the RSS configurations for NIC by testpmd in > order to set DCB? > > > On Thur, Apr 27, 2023 at 4:33PM, zhoumin wrote: >> Kindly

Re: [PATCH 1/4] net: calculate correct UDP pseudo header for UFO

2023-06-06 Thread Ferruh Yigit
On 6/6/2023 4:19 PM, Olivier Matz wrote: > Hi Zeng, > > On Thu, Apr 13, 2023 at 01:34:00PM +0800, Zhichao Zeng wrote: >> This commit calculates the correct pseudo header for the >> UDP fragmentation offload by adding UDP_SEG flag. >> >> Signed-off-by: Zhichao Zeng > > Sorry for the late feedback

Re: [PATCH v3 0/2] enhance bonding PMD to support the LACP negotiation

2023-06-06 Thread Ferruh Yigit
On 6/6/2023 2:23 AM, Chaoyong He wrote: > A gentle ping on this series. > >> -Original Message- >> From: Chaoyong He >> Sent: Friday, May 12, 2023 9:51 AM >> To: dev@dpdk.org >> Cc: oss-drivers ; Niklas Soderlund >> >> Subject: RE: [PATCH v3 0/2] enhance bonding PMD to support the LACP >>

Re: [PATCH] doc: deprecation notice to add RSS hash algorithm field

2023-06-06 Thread Stephen Hemminger
On Tue, 6 Jun 2023 16:50:53 +0100 Ferruh Yigit wrote: > On 6/6/2023 4:39 PM, Stephen Hemminger wrote: > > On Tue, 6 Jun 2023 20:11:26 +0800 > > Dongdong Liu wrote: > > > >> Deprecation notice to add "func" field to ``rte_eth_rss_conf`` > >> structure for RSS hash algorithm. > >> > >> Signed-o

Re: [PATCH V6 0/5] app/testpmd: support multiple process attach and detach port

2023-06-06 Thread Ferruh Yigit
On 5/27/2023 3:11 AM, Huisong Li wrote: > This patchset fix some bugs and support attaching and detaching port > in primary and secondary. > Hi Huisong, As commented on v4, I have some concerns on this set. The set does multiple ethdev/testpmd change, but the main target of the patch is not des

Re: [PATCH V4 1/5] drivers/bus: restore driver assignment at front of probing

2023-06-06 Thread Ferruh Yigit
On 2/28/2023 2:21 AM, lihuisong (C) wrote: > > 在 2023/2/16 0:09, Ferruh Yigit 写道: >> On 1/12/2023 2:44 AM, lihuisong (C) wrote: >>> 在 2023/1/11 20:51, Ferruh Yigit 写道: On 12/6/2022 9:26 AM, Huisong Li wrote: > The driver assignment was moved back at the end of the device probing > bec

Re: [dpdk-dev] [PATCH v1] doc: process for new library approval in principle

2023-06-06 Thread Jerin Jacob
On Thu, May 18, 2023 at 6:52 PM wrote: > > From: Jerin Jacob > > Based on techboard meeting[1] action item, defining the process for a > new library approval in principle. > > [1] > https://mails.dpdk.org/archives/dev/2023-January/260035.html > > Signed-off-by: Jerin Jacob > --- > RFC..v1: > - F

Re: [PATCH] doc: deprecation notice to add RSS hash algorithm field

2023-06-06 Thread Ferruh Yigit
On 6/6/2023 4:39 PM, Stephen Hemminger wrote: > On Tue, 6 Jun 2023 20:11:26 +0800 > Dongdong Liu wrote: > >> Deprecation notice to add "func" field to ``rte_eth_rss_conf`` >> structure for RSS hash algorithm. >> >> Signed-off-by: Dongdong Liu >> --- > > New fields do not require deprecation not

[PATCH] eal: add warning for incompatibe requested IOVA mode

2023-06-06 Thread Viacheslav Ovsiienko
The DPDK can be compiled to be run in IOVA VA mode with 'enable_iova_as_pa=false' meson option. It disables support of the physical address field in the mbufs and application can not be run in 'IOVA as PA mode'. The patch adds warning if some bus requires the 'IOVA as PA' mode in runtime and the '

Re: [PATCH] ethdev: validate reserved fields

2023-06-06 Thread Ferruh Yigit
On 5/25/2023 9:39 PM, Stephen Hemminger wrote: > The various reserved fields added to ethdev could not be > safely used for future extensions because they were never > checked on input. Therefore ABI would be broken if these > fields were added in a future DPDK release. > > Fixes: 436b3a6b6e62 ("e

Re: [PATCH v2] eal: choose IOVA mode according to compilation flags

2023-06-06 Thread Bruce Richardson
On Tue, Jun 06, 2023 at 06:15:11PM +0300, Viacheslav Ovsiienko wrote: > The DPDK can be compiled to be run in IOVA VA mode with > 'enable_iova_as_pa=false' meson option. If there is no > explicit EAL --iova-mode parameter specified in the command > line the rte_eal_init() tried to deduce VA or PA m

Re: [PATCH 1/4] net: calculate correct UDP pseudo header for UFO

2023-06-06 Thread Olivier Matz
Hi Zeng, On Thu, Apr 13, 2023 at 01:34:00PM +0800, Zhichao Zeng wrote: > This commit calculates the correct pseudo header for the > UDP fragmentation offload by adding UDP_SEG flag. > > Signed-off-by: Zhichao Zeng Sorry for the late feedback. The patch looks good to me, thanks! I don't think w

[PATCH v2] eal: choose IOVA mode according to compilation flags

2023-06-06 Thread Viacheslav Ovsiienko
The DPDK can be compiled to be run in IOVA VA mode with 'enable_iova_as_pa=false' meson option. If there is no explicit EAL --iova-mode parameter specified in the command line the rte_eal_init() tried to deduce VA or PA mode without taking into account the above mentioned compile time option, resul

[PATCH v4] gro : ipv6 changes to support GRO for TCP/ipv6

2023-06-06 Thread Kumara Parameshwaran
The patch adds GRO support for TCP/ipv6 packets. This does not include the support for vxlan, udp ipv6 packets. Signed-off-by: Kumara Parameshwaran --- v1: * Changes to support GRO for TCP/ipv6 packets. This does not include vxlan changes. * The GRO is performed only fo

[PATCH v8 16/17] test/graph: add functional tests for mcore dispatch model

2023-06-06 Thread Zhirun Yan
Add functional test for mcore dispatch model including graph clone, graph model set/get, node worker affinity, graph worker binding/unbinding. Signed-off-by: Haiyue Wang Signed-off-by: Cunming Liang Signed-off-by: Zhirun Yan --- app/test/test_graph.c | 130 +

[PATCH v8 17/17] doc: update multicore dispatch model in graph guides

2023-06-06 Thread Zhirun Yan
Update graph documentation to introduce new multicore dispatch model. Signed-off-by: Haiyue Wang Signed-off-by: Cunming Liang Signed-off-by: Zhirun Yan --- doc/guides/prog_guide/graph_lib.rst | 68 +++-- 1 file changed, 64 insertions(+), 4 deletions(-) diff --git a/doc

[PATCH v8 15/17] examples/l3fwd-graph: introduce multicore dispatch worker model

2023-06-06 Thread Zhirun Yan
Add new parameter "model" to choose mcore dispatch or rtc model. And in dispatch model, the node will affinity to worker core successively. Note: RTE_GRAPH_MODEL_SELECT is set to GRAPH_MODEL_RTC by default. Must set model the same as RTE_GRAPH_MODEL_SELECT If set it as rtc or mcore dispatch explic

[PATCH v8 14/17] graph: add stats for cross-core dispatching

2023-06-06 Thread Zhirun Yan
Add stats for cross-core dispatching scheduler if stats collection is enabled. Signed-off-by: Haiyue Wang Signed-off-by: Cunming Liang Signed-off-by: Zhirun Yan --- lib/graph/graph_debug.c| 6 ++ lib/graph/graph_stats.c| 76 +++--- lib/g

[PATCH v8 12/17] graph: introduce graph walk by cross-core dispatch

2023-06-06 Thread Zhirun Yan
This patch introduces the task scheduler mechanism to enable dispatching tasks to another worker cores. Currently, there is only a local work queue for one graph to walk. We introduce a scheduler worker queue in each worker core for dispatching tasks. It will perform the walk on scheduler work queu

[PATCH v8 13/17] graph: enable graph multicore dispatch scheduler model

2023-06-06 Thread Zhirun Yan
This patch enables to chose new scheduler model. Must define RTE_GRAPH_MODEL_SELECT before including rte_graph_worker.h to enable specific model choosing. Signed-off-by: Haiyue Wang Signed-off-by: Cunming Liang Signed-off-by: Zhirun Yan --- lib/graph/rte_graph_worker.h | 12 1 fil

[PATCH v8 11/17] graph: enable create and destroy graph scheduling workqueue

2023-06-06 Thread Zhirun Yan
This patch enables to create and destroy scheduling workqueue into common graph operations. Signed-off-by: Haiyue Wang Signed-off-by: Cunming Liang Signed-off-by: Zhirun Yan --- lib/graph/graph.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/lib/graph/graph.c b/lib/graph/grap

[PATCH v8 10/17] graph: introduce stream moving cross cores

2023-06-06 Thread Zhirun Yan
This patch introduces key functions to allow a worker thread to enable enqueue and move streams of objects to the next nodes over different cores for mcore dispatch model. Signed-off-by: Haiyue Wang Signed-off-by: Cunming Liang Signed-off-by: Zhirun Yan --- lib/graph/graph.c

[PATCH v8 09/17] graph: add structure for stream moving between cores

2023-06-06 Thread Zhirun Yan
Add graph_mcore_dispatch_wq_node to hold graph scheduling workqueue node. Signed-off-by: Haiyue Wang Signed-off-by: Cunming Liang Signed-off-by: Zhirun Yan --- lib/graph/graph.c | 2 ++ lib/graph/graph_populate.c | 1 + lib/graph/graph_private.h | 12

[PATCH v8 08/17] graph: introduce graph clone API for other worker core

2023-06-06 Thread Zhirun Yan
This patch adds graph API for supporting to clone the graph object for a specified worker core. The new graph will also clone all nodes. Signed-off-by: Haiyue Wang Signed-off-by: Cunming Liang Signed-off-by: Zhirun Yan --- lib/graph/graph.c | 89 +++

[PATCH v8 07/17] graph: move node clone name func into private as common

2023-06-06 Thread Zhirun Yan
Move clone_name() into graph_private.h as a common function for both node and graph to naming a new cloned object. Signed-off-by: Haiyue Wang Signed-off-by: Cunming Liang Signed-off-by: Zhirun Yan --- lib/graph/graph_private.h | 41 +++ lib/graph/node.c

[PATCH v8 06/17] graph: introduce graph bind unbind API

2023-06-06 Thread Zhirun Yan
Add lcore_id for graph to hold affinity core id where graph would run on. Add bind/unbind API to set/unset graph affinity attribute. lcore_id will be set as MAX by default, it means not enable this attribute. Signed-off-by: Haiyue Wang Signed-off-by: Cunming Liang Signed-off-by: Zhirun Yan ---

[PATCH v8 05/17] graph: introduce graph node core affinity API

2023-06-06 Thread Zhirun Yan
Add lcore_id for node to hold affinity core id and impl rte_graph_model_mcore_dispatch_lcore_affinity_set to set node affinity with specific lcore. Signed-off-by: Haiyue Wang Signed-off-by: Cunming Liang Signed-off-by: Zhirun Yan --- lib/graph/graph_private.h | 2 + lib/graph

[PATCH v8 04/17] graph: add get/set graph worker model APIs

2023-06-06 Thread Zhirun Yan
Add new get/set APIs to configure graph worker model which is used to determine which model will be chosen. Signed-off-by: Haiyue Wang Signed-off-by: Cunming Liang Signed-off-by: Zhirun Yan --- lib/graph/meson.build | 1 + lib/graph/rte_graph_worker.c| 21 ++ lib

[PATCH v8 02/17] graph: split graph worker into common and default model

2023-06-06 Thread Zhirun Yan
To support multiple graph worker model, split graph into common and default. Naming the current walk function as rte_graph_model_rtc cause the default model is RTC(Run-to-completion). Signed-off-by: Haiyue Wang Signed-off-by: Cunming Liang Signed-off-by: Zhirun Yan --- lib/graph/graph_pcap.c

[PATCH v8 03/17] graph: move node process into inline function

2023-06-06 Thread Zhirun Yan
Node process is a single and reusable block, move the code into an inline function. Signed-off-by: Haiyue Wang Signed-off-by: Cunming Liang Signed-off-by: Zhirun Yan --- lib/graph/rte_graph_model_rtc.h | 20 ++--- lib/graph/rte_graph_worker_common.h | 33 +++

[PATCH v8 01/17] graph: rename rte_graph_work as common

2023-06-06 Thread Zhirun Yan
Rename rte_graph_work.h to rte_graph_work_common.h for supporting multiple graph worker model. Signed-off-by: Haiyue Wang Signed-off-by: Cunming Liang Signed-off-by: Zhirun Yan --- MAINTAINERS | 3 ++- lib/graph/graph_pcap.c

[PATCH v8 00/17] graph enhancement for multi-core dispatch

2023-06-06 Thread Zhirun Yan
V8: No performance dorp for original l3fwd-graph and graph_perf_autotest. Update graph model set/get functions and add graph_model_is_valid() in patch 04. Update doc for new scheme usage(choose model in runtime or compile time). Update dispatch schedule struct into union. Change enum rte_graph_wor

Re: [PATCH v3] app/test-pmd: fix not polling all queues without deferred starting

2023-06-06 Thread Ferruh Yigit
On 5/29/2023 3:26 AM, Jie Hai wrote: > > Each stream has a read-only "disabled" field that control if this > stream should be used to forward. This field depends on states > of Rx/Tx queues, please see > commit 3c4426db54fc ("app/testpmd: do not poll stopped queues"). > > Currently, the testpmd

Re: [PATCH] pci: fix comment referencing renamed function

2023-06-06 Thread Thomas Monjalon
31/05/2023 08:02, Xia, Chenbo: > > -Original Message- > > From: Thomas Monjalon > > Sent: Wednesday, May 31, 2023 12:02 AM > > To: dev@dpdk.org > > Cc: sta...@dpdk.org; Gaetan Rivet ; David Marchand > > > > Subject: [PATCH] pci: fix comment referencing renamed function > > > > When renam

Re: [PATCH v2] bus/auxiliary: support cleanup callback

2023-06-06 Thread Thomas Monjalon
17/03/2023 16:24, Xueming Li: > The bus cleanup callback is used to sunset all devices on bus > gracefully. This patch supports the callback by unplug all > devices on auxiliary bus. > > Signed-off-by: Xueming Li Applied, thanks.

RE: [PATCH v2 0/6] changes for 23.07

2023-06-06 Thread Vargas, Hernan
Hi Maxime, Kind reminder to review this series when you have a chance: https://patchwork.dpdk.org/project/dpdk/list/?series=28189 Thanks, Hernan > -Original Message- > From: Vargas, Hernan > Sent: Thursday, May 25, 2023 1:28 PM > To: dev@dpdk.org; maxime.coque...@redhat.com; gak...@marv

Re: [PATCH v4] app/testpmd: expand noisy neighbour forward mode support

2023-06-06 Thread Ferruh Yigit
On 6/2/2023 7:29 PM, Mike Pattrick wrote: > Previously the noisy neighbour vnf simulation would only operate in io > mode, forwarding packets as is. However, this limited the usefulness of > noisy neighbour simulation. > > This feature has now been expanded to supporting mac, macswap, and > 5tswap

Re: [PATCH] bus/vmbus: add cleanup support

2023-06-06 Thread Thomas Monjalon
21/03/2023 20:31, lon...@linuxonhyperv.com: > From: Long Li > > Implement VMBUS cleanup callback from eal_cleanup(). > > Signed-off-by: Long Li > --- > drivers/bus/vmbus/vmbus_common.c | 29 + > 1 file changed, 29 insertions(+) > > diff --git a/drivers/bus/vmbus/vm

Re: [PATCH v3] app/testpmd: expand noisy neighbour forward mode support

2023-06-06 Thread Ferruh Yigit
On 6/1/2023 5:23 PM, Kevin Traynor wrote: > On 26/05/2023 18:32, Mike Pattrick wrote: >> On Fri, May 26, 2023 at 11:34 AM Kevin Traynor >> wrote: >>> >>> On 17/04/2023 19:55, Mike Pattrick wrote: Previously the noisy neighbour vnf simulation would only operate in io mode, forwarding pack

Re: [PATCH v8] enhance NUMA affinity heuristic

2023-06-06 Thread Thomas Monjalon
01/06/2023 16:42, David Marchand: > On Fri, May 26, 2023 at 11:03 AM Kaisen You wrote: > > > > When a DPDK application is started on only one numa node, memory is > > allocated for only one socket. When interrupt threads use memory, > > memory may not be found on the socket where the interrupt thr

  1   2   >