[PATCH v7 2/4] eal: provide abstracted bit count functions

Provide abstracted bit counting functions for count, leading and trailing bits in v to hide compiler specific intrinsics and builtins. Include basic unit test of following functions added. rte_clz32 rte_clz64 rte_ctz32 rte_ctz64 rte_popcount32 rte_popcount64 Signed-off-by

[PATCH v7 1/4] eal: move bit count functions to bitops header

Move the following inline functions from rte_common.h to rte_bitops.h rte_combine32ms1b rte_combine64ms1b rte_bsf32 rte_bsf32_safe rte_bsf64 rte_bsf64_safe rte_fls_u32 rte_fls_u64 rte_is_power_of_2 rte_align32pow2 rte_align32prevpow2 rte_align64pow2 rte_align64prevpow2

[PATCH v7 4/4] maintainers: add bitcount test under EAL API and common code

List app/test/test_bitcount.c under EAL API and common code. Signed-off-by: Tyler Retzlaff --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 8df23e5..c2995bb 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -155,6 +155,7 @@ F: doc/guides/prog_guide/

[PATCH v7 0/4] eal: provide abstracted bit counting functions

As discussed technical board meeting 2023-02-22 http://mails.dpdk.org/archives/dev/2023-February/263516.html We will bring support in pieces for the MSVC compiler, there will be some abstractions and functions introduced before the compiler is capable of compiling DPDK in order to make parallel pr

[PATCH v7 3/4] pipeline: add include of bitops

Include rte_bitops.h with the inline functions moving this include is now needed. Signed-off-by: Tyler Retzlaff --- lib/pipeline/rte_swx_pipeline_internal.h | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/pipeline/rte_swx_pipeline_internal.h b/lib/pipeline/rte_swx_pipeline_internal.h in

[PATCH] devtools: add script to check for non inclusive naming

Shell script to find use of words that not be used. By default it prints matches. The -q (quiet) option is used to just count. There is also -l option which lists lines matching (like grep -l). Examples: $ ./devtools/check-naming.sh -q Total files: 37 errors, 90 warnings, 1 suggestions $ ./dev

[PATCH] doc: announce inclusive naming function name changes

In order to suppor inclusive naming, some of the functions in DPDK will need to be renamed. Do this through deprecation process now for 23.07. Signed-off-by: Stephen Hemminger --- doc/guides/rel_notes/deprecation.rst | 16 1 file changed, 16 insertions(+) diff --git a/doc/guide

20.11.8 patches review and test

Hi all, Here is a list of patches targeted for stable release 20.11.8. The planned date for the final release is April 17th. Please help with testing and validation of your use cases and report any issues/results with reply-all to this mail. For the final release the fixes and reported validatio

Re: release candidate 23.03-rc4

IBM - Power Systems DPDK 22.11.0-rc4 * Basic PF on Mellanox: No issue found * Performance: not tested. * OS: RHEL 8.5 kernel: 4.18.0-348.el8.ppc64le with gcc version 8.5.0 20210514 (Red Hat 8.5.0-10) RHEL 9.0 kernel: 5.14.0-70.13.1.el9_0.ppc64le with gcc version 11.2.1 2

RE: ARM power-saving measurements

Hi Feifei/Ruifeng, any advice on power saving measurements on ARM? Regards, Alex > -Original Message- > From: Alexander Kozyrev > Sent: March 13, 2023 18:08 > To: Feifei Wang ; ruifeng.w...@arm.com > Subject: ARM power-saving measurements > > Hi Feifei/ Ruifeng, I can see that power mana

DPDK bond4 can not rx lacp pkt

I have found a similar issue, and the patch he provided is valid for me, but the issue has not been processed. Is there any reason, or has it been fixed in another way?https://bugs.dpdk.org/show_bug.cgi?id=343 my dpdk is dpdk-19.11 compile_success 980965...@qq.com  

DPDK 23.03 released

A new major release is available: https://fast.dpdk.org/rel/dpdk-23.03.tar.xz Winter release numbers are quite small as usual: 1048 commits from 161 authors 1379 files changed, 85721 insertions(+), 25814 deletions(-) It is not planned to start a maintenance branch for 23.0

Re: [PATCH] test: replace use of wrd segregate

On Fri, Mar 31, 2023 at 08:47:25AM -0700, Stephen Hemminger wrote: > Change comment based on inclusive naming recommendations. > > https://inclusivenaming.org/word-lists/tier-3/ > > Signed-off-by: Stephen Hemminger > --- Acked-by: Tyler Retzlaff

[PATCH] test: replace use of wrd segregate

Change comment based on inclusive naming recommendations. https://inclusivenaming.org/word-lists/tier-3/ Signed-off-by: Stephen Hemminger --- app/test/test_hash_readwrite_lf_perf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/test/test_hash_readwrite_lf_perf.c b/app/

[RFC 27/27] vhost: add multiqueue support to VDUSE

This patch enables control queue support in order to support multiqueue. Signed-off-by: Maxime Coquelin --- lib/vhost/vduse.c | 69 ++- 1 file changed, 63 insertions(+), 6 deletions(-) diff --git a/lib/vhost/vduse.c b/lib/vhost/vduse.c index 1cd04b487

[RFC 26/27] vhost: add VDUSE device startup

This patch adds the device and its virtqueues initialization once the Virtio driver has set the DRIVER_OK in the Virtio status register. Signed-off-by: Maxime Coquelin --- lib/vhost/vduse.c | 118 ++ 1 file changed, 118 insertions(+) diff --git a/lib/

[RFC 25/27] vhost: add support for VDUSE IOTLB update event

This patch adds support for VDUSE_UPDATE_IOTLB event handling, which consists in invaliding IOTLB entries for the range specified in the request. Signed-off-by: Maxime Coquelin --- lib/vhost/vduse.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/lib/vhost/vduse.c b/lib/vhost/vduse.c i

[RFC 24/27] vhost: add support for VDUSE status set event

This patch adds support for VDUSE_SET_STATUS event handling, which consists in updating the Virtio device status set by the Virtio driver. Signed-off-by: Maxime Coquelin --- lib/vhost/vduse.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/lib/vhost/vduse.c b/lib/vhost/vduse.c index 36

[RFC 22/27] vhost: add VDUSE events handler

This patch makes use of Vhost lib's FD manager to install a handler for VDUSE events occurring on the VDUSE device FD. Signed-off-by: Maxime Coquelin --- lib/vhost/vduse.c | 102 ++ 1 file changed, 102 insertions(+) diff --git a/lib/vhost/vduse.c b/li

[RFC 23/27] vhost: add support for virtqueue state get event

This patch adds support for VDUSE_GET_VQ_STATE event handling, which consists in providing the backend last available index for the specified virtqueue. Signed-off-by: Maxime Coquelin --- lib/vhost/vduse.c | 8 1 file changed, 8 insertions(+) diff --git a/lib/vhost/vduse.c b/lib/vhost/

[RFC 20/27] vhost: add VDUSE callback for IOTLB entry removal

This patch implements the VDUSE callback for IOTLB misses, where it unmaps the pages from the invalidated IOTLB entry Signed-off-by: Maxime Coquelin --- lib/vhost/vduse.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/lib/vhost/vduse.c b/lib/vhost/vduse.c index f46823f589..ff4c9e72f1

[RFC 21/27] vhost: add VDUSE callback for IRQ injection

This patch implements the VDUSE callback for kicking virtqueues. Signed-off-by: Maxime Coquelin --- lib/vhost/vduse.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/lib/vhost/vduse.c b/lib/vhost/vduse.c index ff4c9e72f1..afa8a39498 100644 --- a/lib/vhost/vduse.c +++ b/lib/vhost/vduse

[RFC 19/27] vhost: add VDUSE callback for IOTLB miss

This patch implements the VDUSE callback for IOTLB misses, where it unmaps the pages from the invalidated IOTLB entry. Signed-off-by: Maxime Coquelin --- lib/vhost/vduse.c | 58 +++ 1 file changed, 58 insertions(+) diff --git a/lib/vhost/vduse.c b/lib

[RFC 18/27] vhost: add VDUSE device creation and destruction

This patch adds initial support for VDUSE, which includes the device creation and destruction. It does not include the virtqueues configuration, so this is not functionnal at this point. Signed-off-by: Maxime Coquelin --- lib/vhost/meson.build | 4 + lib/vhost/socket.c| 34 +--- lib/

[RFC 17/27] vhost: add control virtqueue support

In order to support multi-queue with VDUSE, having control queue support in required. This patch adds control queue implementation, it will be used later when adding VDUSE support. Only split ring layout is supported for now, packed ring support will be added later. Signed-off-by: Maxime Coquelin

[RFC 16/27] net/vhost: use API to set max queue pairs

In order to support multiqueue with VDUSE, we need to be able to limit the maximum number of queue pairs, to avoid unnecessary memory consumption since the maximum number of queue pairs need to be allocated at device creation time, as opposed to Vhost-user which allocate only when the frontend init

[RFC 15/27] vhost: add API to set max queue pairs

This patch introduces a new rte_vhost_driver_set_max_queues API as preliminary work for multiqueue support with VDUSE. Indeed, with VDUSE we need to pre-allocate the vrings at device creation time, so we need such API not to allocate the 128 queue pairs supported by the Vhost library. Calling the

[RFC 13/27] vhost: add helper for IOTLB misses

This patch adds a helper for sending IOTLB misses as VDUSE will use an ioctl while Vhost-user use a dedicated Vhost-user backend request. Signed-off-by: Maxime Coquelin --- lib/vhost/vhost.c | 13 - lib/vhost/vhost.h | 3 +++ lib/vhost/vhost_user.c | 6 -- lib/vhost/v

[RFC 14/27] vhost: add helper for interrupt injection

Vhost-user uses eventfd to inject IRQs, but VDUSE uses an ioctl. This patch prepares vhost_vring_call_split() and vhost_vring_call_packed() to support VDUSE by introducing a new helper. It also adds a new counter to for guest notification failures, which could happen in case of uninitialized call

[RFC 12/27] vhost: add IOTLB cache entry removal callback

VDUSE will need to munmap() the IOTLB entry on removal from the cache, as it performs mmap() before insertion. This patch introduces a callback that VDUSE layer will implement to achieve this. Signed-off-by: Maxime Coquelin --- lib/vhost/iotlb.c | 12 lib/vhost/vhost.h | 4 2

[RFC 11/27] vhost: introduce backend ops

This patch introduces backend ops struct, that will enable calling backend specifics callbacks (Vhost-user, VDUSE), in shared code. This is an empty shell for now, it will be filled in later patches. Signed-off-by: Maxime Coquelin --- lib/vhost/socket.c | 2 +- lib/vhost/vhost.c | 8

[RFC 10/27] vhost: retry translating IOVA after IOTLB miss

Vhost-user backend IOTLB misses and updates are asynchronous, so IOVA address translation function just fails after having sent an IOTLB miss update if needed entry was not in the IOTLB cache. This is not the case for VDUSE, for which the needed IOTLB update is returned directly when sending an IO

[RFC 09/27] vhost: add page size info to IOTLB entry

VDUSE will close the file descriptor after having mapped the shared memory, so it will not be possible to get the page size afterwards. This patch adds an new page_shift field to the IOTLB entry, so that the information will be passed at IOTLB cache insertion time. The information is stored as a b

[RFC 08/27] vhost: add offset field to IOTLB entries

This patch is a preliminary work to prepare for VDUSE support, for which we need to keep track of the mmaped base address and offset in order to be able to unmap it later when IOTLB entry is invalidated. Signed-off-by: Maxime Coquelin --- lib/vhost/iotlb.c | 30 ++---

[RFC 07/27] vhost: change to single IOTLB cache per device

This patch simplifies IOTLB implementation and improves IOTLB memory consumption by having a single IOTLB cache per device, instead of having one per queue. In order to not impact performance, it keeps an IOTLB lock per virtqueue, so that there is no contention between multiple queue trying to acq

[RFC 05/27] vhost: add helper for IOTLB entries shared page check

This patch introduces a helper to check whether two IOTLB entries share a page. Signed-off-by: Maxime Coquelin --- lib/vhost/iotlb.c | 25 - 1 file changed, 20 insertions(+), 5 deletions(-) diff --git a/lib/vhost/iotlb.c b/lib/vhost/iotlb.c index e8f1cb661e..d919f74704 1

[RFC 06/27] vhost: don't dump unneeded pages with IOTLB

On IOTLB entry removal, previous fixes took care of not marking pages shared with other IOTLB entries as DONTDUMP. However, if an IOTLB entry is spanned on multiple pages, the other pages were kept as DODUMP while they might not have been shared with other entries, increasing needlessly the coredu

[RFC 03/27] vhost: fix IOTLB entries overlap check with previous entry

Commit 22b6d0ac691a ("vhost: fix madvise IOTLB entries pages overlap check") fixed the check to ensure the entry to be removed does not overlap with the next one in the IOTLB cache before marking it as DONTDUMP with madvise(). This is not enough, because the same issue is present when comparing wit

[RFC 04/27] vhost: add helper of IOTLB entries coredump

This patch reworks IOTLB code to extract madvise-related bits into dedicated helper. This refactoring improves code sharing. Signed-off-by: Maxime Coquelin --- lib/vhost/iotlb.c | 77 +-- 1 file changed, 41 insertions(+), 36 deletions(-) diff --git a/

[RFC 02/27] vhost: fix invalid call FD handling

This patch fixes cases where IRQ injection is tried while the call FD is not valid, which should not happen. Fixes: b1cce26af1dc ("vhost: add notification for packed ring") Fixes: e37ff954405a ("vhost: support virtqueue interrupt/notification suppression") Cc: sta...@dpdk.org Signed-off-by: Maxi

[RFC 01/27] vhost: fix missing guest notif stat increment

Guest notification counter was only incremented for split ring, this patch adds it also for packed ring. Fixes: 1ea74efd7fa4 ("vhost: add statistics for guest notification") Cc: sta...@dpdk.org Signed-off-by: Maxime Coquelin --- lib/vhost/vhost.h | 2 ++ 1 file changed, 2 insertions(+) diff --

[RFC 00/27] Add VDUSE support to Vhost library

This series introduces a new type of backend, VDUSE, to the Vhost library. VDUSE stands for vDPA device in Userspace, it enables implementing a Virtio device in userspace and have it attached to the Kernel vDPA bus. Once attached to the vDPA bus, it can be used either by Kernel Virtio drivers, li

Re: DPDK Release Status Meeting 2023-03-23

23/03/2023 12:28, Mcnamara, John: > * 22.07 V1 deadline moved out 1 week to 15 April 15 April is the original date. Did we discuss moving to 22 April?

Re: [PATCH] doc: deprecation notice to remove net/bnx2x driver

> >> From: Jerin Jacob > >> > >> Starting from DPDK 23.07, the Marvell QLogic bnx2x driver > >> will be removed. This decision has been made to alleviate the burden of > >> maintaining a discontinued product. > >> > >> Signed-off-by: Jerin Jacob > > > > Acked-by: Alok Prasad > > Acked-by: Ferr

Re: [dpdk-dev] [PATCH] doc: deprecation notice to remove LiquidIO ethdev driver

09/03/2023 08:07, jer...@marvell.com: > From: Jerin Jacob > > The LiquidIO product line(drivers/net/liquidio) has been substituted with > CN9K/CN10K OCTEON product line smart NICs located in drivers/net/octeon_ep/. > DPDK v20.08 has categorized the LiquidIO driver as UNMAINTAINED > because of the

Re: [PATCH V3] doc: announce the pipeline legacy API deprecation

09/03/2023 21:09, Cristian Dumitrescu: > Announce the deprecation of the legacy pipeline, table and port > library API and gradual stabilization of the new API. > > Signed-off-by: Cristian Dumitrescu We'll discuss the timeline for promoting the new API, when reviewing the patches. As Bruce sugge

Re: [PATCH v1] doc: update release notes for 23.03

30/03/2023 21:19, Zhang, Fan: > On 3/30/2023 5:09 PM, John McNamara wrote: > > Fix grammar, spelling and formatting of DPDK 23.03 release notes. > > > > Signed-off-by: John McNamara > > --- > > > > * Minor fixes/changes only. > > > > > > doc/guides/rel_notes/release_23_03.rst | 16 ++

Re: [dpdk-dev] [PATCH] doc: deprecation notice to remove LiquidIO ethdev driver

On Thu, Mar 9, 2023 at 8:07 AM wrote: > > The LiquidIO product line(drivers/net/liquidio) has been substituted with > CN9K/CN10K OCTEON product line smart NICs located in drivers/net/octeon_ep/. > DPDK v20.08 has categorized the LiquidIO driver as UNMAINTAINED > because of the absence of updates i

Re: Regarding DPDK API's like rte_timer_subsystem_init/rte_hash_create etc. in VPP

On Fri, Mar 31, 2023 at 03:11:18PM +0530, Prashant Upadhyaya wrote: > On Thu, Mar 30, 2023 at 7:34 PM Bruce Richardson > wrote: > > > > On Thu, Mar 30, 2023 at 07:07:23PM +0530, Prashant Upadhyaya wrote: > > > On Thu, Mar 30, 2023 at 6:47 PM Bruce Richardson > > > wrote: > > > > > > > > On Thu, M

Re: [PATCH] doc: add tested platforms with NVIDIA NICs

29/03/2023 10:24, Raslan Darawsheh: > Add tested platforms with NVIDIA NICs to the 23.03 release notes. > > Signed-off-by: Raslan Darawsheh Applied, thanks.

Re: [dpdk-dev] [PATCH] doc: clarify disclosure time slot when no response

25/01/2021 02:57, Marvin Liu: > Sometimes security team won't send confirmation mail back to reporter > in three business days. This mean reported vulnerability is either low > severity or not a real vulnerability. Reporter should assume that the > issue need shortest embargo. After that reporter c

Re: [PATCH] doc: relax requirement on commit messages of security fixes

Indeed! On 3/31/23 12:34, Thomas Monjalon wrote: We missed this patch, there was no comment. Please review. 10/03/2022 18:59, luca.bocca...@gmail.com: From: Luca Boccassi Allow more flexibility with embargo lifting by not requiring mentions of CVEs in commit messages if the lift date allows

Re: [PATCH] doc: relax requirement on commit messages of security fixes

We missed this patch, there was no comment. Please review. 10/03/2022 18:59, luca.bocca...@gmail.com: > From: Luca Boccassi > > Allow more flexibility with embargo lifting by not requiring > mentions of CVEs in commit messages if the lift date allows > it. > > Signed-off-by: Luca Boccassi > --

Re: [PATCH] docs: change the doc to highlight the allowed multicast addresses

01/07/2022 12:37, huzaifa.rahman: > Bugzilla ID: 802 > > The ipv4_multicast example does not work with any multicast IPs. > Only a selected few IPs are allowed to send pakcets. These IPs > are listed in an mcast_group_table array along with their respective > port masks. A normal user would not kn

Re: [PATCH 1/1] doc: expand description of no-huge and PMD issue

15/11/2022 16:37, Thomas Monjalon: > Ping for review > > 11/07/2022 23:09, Thomas Monjalon: > > 13/06/2022 11:31, David Marchand: > > > On Thu, Jun 9, 2022 at 3:40 PM Stanislaw Kardach > > > wrote: > > > > > > > > Add more details to the description of a known issue of PMDs not being > > > > usa

Re: [PATCH] doc: fix dcf instructions

27/03/2023 21:44, Qi Zhang: > Replace the deprecated VF action with the represented_port action. > > Fixes: 776c119736e7 ("net/ice: remove deprecated VF flow action") > Cc: sta...@dpdk.org > > Signed-off-by: Qi Zhang Applied, thanks.

Re: Regarding DPDK API's like rte_timer_subsystem_init/rte_hash_create etc. in VPP

On Thu, Mar 30, 2023 at 7:34 PM Bruce Richardson wrote: > > On Thu, Mar 30, 2023 at 07:07:23PM +0530, Prashant Upadhyaya wrote: > > On Thu, Mar 30, 2023 at 6:47 PM Bruce Richardson > > wrote: > > > > > > On Thu, Mar 30, 2023 at 06:42:58PM +0530, Prashant Upadhyaya wrote: > > > > On Thu, Mar 30, 2

Re: [PATCH] maintainers: update for FIPS validation

30/03/2023 11:07, Dooley, Brian: > From: Gowrishankar Muthukrishnan > > > > Add co-maintainer for FIPS validation example. > > > > Signed-off-by: Gowrishankar Muthukrishnan > > --- > > FIPS validation example > > M: Brian Dooley > > +M: Gowrishankar Muthukrishnan > > F: examples/fips_valid

[PATCH v1] dts: update dependencies and mypy execution

Poetry changed the syntax of dev dependencies section in version 1.2.0. Remove the scripts section that did nothing. Update Pylama linters: * pep8 is the same as pycodestyle * pylint is missing dependencies and thus not executed. It reports a number of warnings and may be introduced in a future p

RE: release candidate 23.03-rc4

> -Original Message- > From: Xu, HailinX > Sent: Thursday, March 30, 2023 4:13 PM > To: Thomas Monjalon ; dev@dpdk.org > Cc: Kovacevic, Marko ; Mcnamara, John > ; Richardson, Bruce > ; Ferruh Yigit > Subject: RE: release candidate 23.03-rc4 > > > -Original Message- > > From: Thoma

Re: [Bug 1209] vmxnet3 interface not receiving any packets with dpdk-22.11.1

Hello Jochen, On Fri, Mar 31, 2023 at 9:07 AM wrote: > > Bug ID 1209 > Summary vmxnet3 interface not receiving any packets with dpdk-22.11.1 > Product DPDK > Version 22.11 > Hardware x86 > OS All > Status UNCONFIRMED > Severity critical > Priority Normal > Component ethdev > Assignee dev@dpdk.org

[Bug 1209] vmxnet3 interface not receiving any packets with dpdk-22.11.1

https://bugs.dpdk.org/show_bug.cgi?id=1209 Bug ID: 1209 Summary: vmxnet3 interface not receiving any packets with dpdk-22.11.1 Product: DPDK Version: 22.11 Hardware: x86 OS: All Status: UNCONFIRM