>-Original Message-
>From: Zhang, Yuying
>Sent: Wednesday, February 8, 2023 11:22 AM
>To: He, ShiyangX
>Cc: dev@dpdk.org; Zhou, YidingX ;
>sta...@dpdk.org; Singh, Aman Deep ; Burakov,
>Anatoly ; Li, Xiaoyun ;
>Alvin Zhang
>Subject: RE: [PATCH] app/testpmd: fix secondary process not fo
Add support for MPLS tunnel item in HWS.
Signed-off-by: Michael Baum
Acked-by: Ori Kam
---
doc/guides/nics/mlx5.rst | 4
doc/guides/rel_notes/release_23_03.rst | 4
drivers/net/mlx5/mlx5_flow_hw.c| 1 +
3 files changed, 9 insertions(+)
diff --git a/doc/guides/ni
From: Erez Shitrit
Add support for matching MPLS labels while it is under UDP protocol.
Matching up to 5 MPLS labels with or without the MPLS value.
Signed-off-by: Erez Shitrit
---
drivers/net/mlx5/hws/mlx5dr_definer.c | 183 +-
drivers/net/mlx5/hws/mlx5dr_definer.h |
Add support for matching/encap/decap MPLSoUDP including multiple MPLS
headers.
Erez Shitrit (1):
net/mlx5/hws: support matching on MPLSoUDP
Michael Baum (1):
net/mlx5: add MPLS tunnel support for HWS
doc/guides/nics/mlx5.rst | 4 +
doc/guides/rel_notes/release_23_03.rst |
There already is a logtype in this driver, use it!
Fixes: b35848bc01f6 ("crypto/ipsec_mb: add multi-process IPC request handler")
Cc: kai...@intel.com
Signed-off-by: Stephen Hemminger
---
drivers/crypto/ipsec_mb/ipsec_mb_ops.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a
Fix instances of USER1 logtype in fdset and crypto
sections.
Signed-off-by: Stephen Hemminger
---
lib/vhost/fd_man.c | 16 +---
lib/vhost/vhost_crypto.c | 24 ++--
2 files changed, 19 insertions(+), 21 deletions(-)
diff --git a/lib/vhost/fd_man.c b/lib/vhos
Libraries should not reuse RTE_LOGTYPE_USER1 for their
logging. Instead they should register their own type.
Fixes: 5cd3cac9ed22 ("latency: added new library for latency stats")
Cc: reshma.pat...@intel.com
Signed-off-by: Stephen Hemminger
---
lib/latencystats/rte_latencystats.c | 55
Libraries should not be reusing RTE_LOGTYPE_USER1 instead
of doing proper logtype registration.
Fixes: b70b56032bff ("reorder: new library")
Cc: sergio.gonzalez.mon...@intel.com
Signed-off-by: Stephen Hemminger
---
lib/reorder/rte_reorder.c | 35 +++
1 file change
DPDK libraries should not be reusing RTE_LOGTYPE_USER1 in
lieu of doing proper logtype registration.
Fixes: 416707812c03 ("ip_frag: refactor reassembly code into a proper library")
Signed-off-by: Stephen Hemminger
---
lib/ip_frag/ip_frag_common.h | 16 ++-
lib/ip_frag/ip_frag_internal.c
This is split out of other rte_log patchset.
The DPDK libraries and drivers should not be using the USER1 logtype.
Stephen Hemminger (5):
ip_frag: use a dynamic logtype
reorder: use a dynamic logtype
latencystats: use dynamic logtype
vhost: use logtype instead of RTE_LOGTYPE_USER1
ipsec:
> -Original Message-
> From: Wenzhuo Lu
> Sent: Wednesday, February 8, 2023 10:59 AM
> To: dev@dpdk.org
> Cc: Lu, Wenzhuo
> Subject: [PATCH v2] net/ice: remove avx512 specific Rx queue rearm code
>
> 'ice_rxq_rearm' in avx512 path is optimized to improve the performance.
> But after t
'ice_rxq_rearm' in avx512 path is optimized to improve the performance.
But after the commit a2833ecc5ea4 ("mempool: fix get objects from mempool
with cache"), this avx512 specific optimization is not necessary.
This patch remove the unnecessary PMD specific optimization to make the
code easier to
> -Original Message-
> From: Yang, Qiming
> Sent: Tuesday, February 7, 2023 2:41 PM
> To: Deng, KaiwenX ; dev@dpdk.org
> Cc: sta...@dpdk.org; Zhou, YidingX ; Wu,
> Wenjun1 ; Zhao1, Wei ;
> Xing, Beilei ; Lu, Wenzhuo ;
> Dai, Wei
> Subject: RE: [PATCH] net/ixgbe: enable IPv6 mask for ge
Hi Shiyang,
> -Original Message-
> From: He, ShiyangX
> Sent: 2023年1月13日 17:08
> To: He, ShiyangX ; Zhang, Yuying
>
> Cc: dev@dpdk.org; Zhou, YidingX ;
> sta...@dpdk.org; Singh, Aman Deep ;
> Burakov, Anatoly ; Li, Xiaoyun
> ; Alvin Zhang
> Subject: RE: [PATCH] app/testpmd: fix secondar
> -Original Message-
> From: Wenzhuo Lu
> Sent: Tuesday, February 7, 2023 2:39 PM
> To: dev@dpdk.org
> Cc: Lu, Wenzhuo
> Subject: [PATCH] net/iavf: remove avx512 specific Rx queue rearm code
>
> 'iavf_rxq_rearm' in avx512 path is optimized to improve the performance.
> But after the c
Add testpmd CLI interface for a template table hash function.
Available types are: default, linear, crc32 and crc16.
flow template_table 0 create table_id 0 hash_func linear ...
Signed-off-by: Alexander Kozyrev
---
app/test-pmd/cmdline_flow.c | 69 -
1 file ch
Allow user to specify hash calculation function used in template tables.
The hash calculation type is responsible for the calculation of the flow
rule index a packet would hit upon arrival at the table.
Control over this is useful for applications with custom RSS algorithms,
for example. An applic
Add testpmd CLI interface for specifying a template table insertion type.
Available types are: pattern and index.
flow template_table 0 create table_id 0 insertion_type index ...
Allow specifying the rule index instead of the pattern template index:
flow queue 0 create 0 template_table 0 rule_index
Allow user to specify insertion type used in template tables.
The insertion type is responsible for choosing the appropriate key
value used to map inserted flow rules into a template table.
Flow rules can be inserted by calculating the hash value for
the pattern or inserted by index via the new cr
Bring more flexibility and control over both flow rule insertion
and packet matching mechanisms. Introduce 2 new flow table types:
1. Allow a user to specify the insertion type used in template tables.
The insertion type is responsible for choosing the appropriate key
value used to map inserted fl
Good evening,
Tomorrow DPDK will hold its biweekly Tech Board Call. 7am PT/10am ET/1600h
CET.
Our agenda for the meeting will be posted here:
https://annuel.framapad.org/p/r.0c3cc4d1e011214183872a98f6b5c7db
Link to join the call:
https://meet.jit.si/dpdk
We look forward to seeing you there.
> -Original Message-
> From: Wenzhuo Lu
> Sent: Tuesday, February 7, 2023 2:39 PM
> To: dev@dpdk.org
> Cc: Lu, Wenzhuo
> Subject: [PATCH] net/i40e: remove avx512 specific Rx queue rearm code
>
> 'i40e_rxq_rearm' in avx512 path is optimized to improve the performance.
> But after the c
在 2023/2/8 3:37, Robin Jarry 写道:
The --record-core-cycles option already accounts for busy cycles. One
turn of packet_fwd_t is considered "busy" if there was at least one
received or transmitted packet.
Rename core_cycles to busy_cycles in struct fwd_stream to make it more
explicit. Add total_
Good evening,
Tomorrow, Wed. Feb. 8, 2023, @ 6am PT/9am ET/1500h CET, DPDK will hold its
DTS Working Group. Zoom information to follow. We look forward to seeing
you there.
Many thanks
Nathan
Nathan C. Southern, Project Coordinator
Data Plane Development Kit
The Linux Foundation
248.835.481
Add testpmd CLI interface for a template table hash function.
Available types are: default, linear, crc32 and crc16.
flow template_table 0 create table_id 0 hash_func linear ...
Signed-off-by: Alexander Kozyrev
---
app/test-pmd/cmdline_flow.c | 69 -
1 file ch
Bring more flexibility and control over both flow rule insertion
and packet matching mechanisms. Introduce 2 new flow table types:
1. Allow a user to specify the insertion type used in template tables.
The insertion type is responsible for choosing the appropriate key
value used to map inserted fl
Add testpmd CLI interface for specifying a template table insertion type.
Available types are: pattern and index.
flow template_table 0 create table_id 0 insertion_type index ...
Allow specifying the rule index instead of the pattern template index:
flow queue 0 create 0 template_table 0 rule_index
Allow user to specify insertion type used in template tables.
The insertion type is responsible for choosing the appropriate key
value used to map inserted flow rules into a template table.
Flow rules can be inserted by calculating the hash value for
the pattern or inserted by index via the new cr
Allow user to specify hash calculation function used in template tables.
The hash calculation type is responsible for the calculation of the flow
rule index a packet would hit upon arrival at the table.
Control over this is useful for applications with custom RSS algorithms,
for example. An applic
在 2023/2/8 3:37, Robin Jarry 写道:
Report the same information than rte_lcore_dump() in the telemetry
API into /eal/lcore/list and /eal/lcore/info,ID.
Example:
--> /eal/lcore/info,3
{
"/eal/lcore/info": {
"lcore_id": 3,
"socket": 0,
"role": "RTE",
"cpuset"
On 2/7/2023 10:10 AM, Singh, Aman Deep wrote:
>
> On 1/31/2023 5:26 PM, Ferruh Yigit wrote:
>> There is an inconsistency at displaying Tx dropped value for per port
>> forwarding stats and accumulated forwarding stats.
>>
>> While displaying per port TX-dropped value, it only takes
>> 'ports_stats
> -Original Message-
> From: Liu, Mingxia
> Sent: Tuesday, February 7, 2023 6:17 PM
> To: dev@dpdk.org; Zhang, Qi Z ; Wu, Jingjing
> ; Xing, Beilei
> Cc: Liu, Mingxia
> Subject: [PATCH v6 1/6] common/idpf: add hw statistics
Suggest to use ./devtools/check-git-log.sh to fix any title
Add optimization to return early if there are no available descriptors
in ring to dequeue.
Signed-off-by: Hernan Vargas
---
drivers/baseband/acc/rte_acc100_pmd.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/baseband/acc/rte_acc100_pmd.c
b/drivers/baseband/acc
Fix potential issue of dereferencing a pointer before null check.
Remove null check for value that could never be null.
Coverity issue: 381646, 381631
Fixes: 989dec301a9 ("baseband/acc100: add ring companion address")
Cc: sta...@dpdk.org
Signed-off-by: Hernan Vargas
---
drivers/baseband/acc/rte
v2: Split code unrelated to coverity fix in separate commit.
v1: Upstream fix to 23.03 for potential issue of dereferencing a pointer before
null check.
Hernan Vargas (2):
baseband/acc: fix check after deref and dead code
baseband/acc: add check for empty queue
drivers/baseband/acc/rte_acc1
On 2/7/2023 2:17 AM, Chaoyong He wrote:
>> On Mon, 6 Feb 2023 15:05:46 +0800
>> Chaoyong He wrote:
>>
>>> This patch series aims to better align the PMD with the preferred DPDK
>>> coding style.
>>> - Remove the usage of 'printf()'
>>> - Remove the unneeded header file includes
>>> - Explicitly c
On 2/6/2023 7:05 AM, Chaoyong He wrote:
> This patch series aims to better align the PMD with
> the preferred DPDK coding style.
> - Remove the usage of 'printf()'
> - Remove the unneeded header file includes
> - Explicitly compare pointer with NULL
> - Explicitly compare integer with 0
>
> James
> -Original Message-
> From: Wenjun Wu
> Sent: Tuesday, February 7, 2023 4:46 PM
> To: dev@dpdk.org; Wu, Jingjing ; Xing, Beilei
>
> Cc: Liu, Mingxia ; Lu, Wenzhuo
> ; Wu, Wenjun1
> Subject: [PATCH v11 0/1] Add support AVX512 split queue datapath
>
> This patchset enables AVX512 data
On 2/7/2023 6:32 AM, Ankur Dwivedi wrote:
> Subject:
> [PATCH v9 3/6] ethdev: add trace points for ethdev (part two)
> From:
> Ankur Dwivedi
> Date:
> 2/7/2023, 6:32 AM
>
> To:
>
> CC:
>
>
> Adds trace points for remaining ethdev functions.
>
> Signed-off-by: Ankur Dwivedi
> Acked-by: Sunil
On Tue, Feb 07, 2023 at 11:34:14PM +, Honnappa Nagarahalli wrote:
>
>
> > > >
> > > > Honnappa, please could you give your view on the future of atomics in
> > DPDK?
> > > Thanks Thomas, apologies it has taken me a while to get to this
> > > discussion.
> > >
> > > IMO, we do not need DPDK's
On 2/7/2023 6:32 AM, Ankur Dwivedi wrote:
> Adds a trace point emit function for capturing a blob. The blob
> captures the length passed by the application followed by the array.
>
> The maximum blob bytes which can be captured is bounded by
> RTE_TRACE_BLOB_LEN_MAX macro. The value for max blob l
On 2/7/2023 6:32 AM, Ankur Dwivedi wrote:
> Adds trace points for ethdev functions.
>
> The rte_ethdev_trace.h is removed. The file ethdev_trace.h is added as
> an internal header. ethdev_trace.h contains internal slow path and
> fast path tracepoints. The public fast path tracepoints are present
> -Original Message-
> From: Maxime Coquelin
> Sent: Tuesday, February 7, 2023 11:18 PM
> To: dev@dpdk.org; Xia, Chenbo ;
> david.march...@redhat.com; epere...@redhat.com; step...@networkplumber.org
> Cc: Maxime Coquelin
> Subject: [PATCH v2 10/21] net/virtio: alloc Rx SW ring only if vec
> -Original Message-
> From: Maxime Coquelin
> Sent: Tuesday, February 7, 2023 11:18 PM
> To: dev@dpdk.org; Xia, Chenbo ;
> david.march...@redhat.com; epere...@redhat.com; step...@networkplumber.org
> Cc: Maxime Coquelin
> Subject: [PATCH v2 21/21] net/virtio-user: remove max queues limit
> -Original Message-
> From: Maxime Coquelin
> Sent: Tuesday, February 7, 2023 11:18 PM
> To: dev@dpdk.org; Xia, Chenbo ;
> david.march...@redhat.com; epere...@redhat.com; step...@networkplumber.org
> Cc: Maxime Coquelin
> Subject: [PATCH v2 19/21] net/virtio-user: forward control message
> -Original Message-
> From: Liu, Mingxia
> Sent: Tuesday, February 7, 2023 6:17 PM
> To: dev@dpdk.org; Zhang, Qi Z ; Wu, Jingjing
> ; Xing, Beilei
> Cc: Liu, Mingxia
> Subject: [PATCH v6 0/6] add idpf pmd enhancement features
>
> This patchset add several enhancement features of idp
> > >
> > > Honnappa, please could you give your view on the future of atomics in
> DPDK?
> > Thanks Thomas, apologies it has taken me a while to get to this discussion.
> >
> > IMO, we do not need DPDK's own abstractions. APIs from stdatomic.h
> (stdatomics as is called here) already serve the p
Split up the single static RTE_LOGTYPE_PORT into seperate
sub types for each component: port.ethdev, port.evendev, ...
Signed-off-by: Stephen Hemminger
---
lib/eal/common/eal_common_log.c | 1 -
lib/eal/include/rte_log.h | 2 +-
lib/port/rte_port_ethdev.c | 23 +
lib/port/rt
Also can remove unused RTE_LOGTYPE_METER
Signed-off-by: Stephen Hemminger
---
lib/eal/common/eal_common_log.c | 2 -
lib/eal/include/rte_log.h | 4 +-
lib/sched/rte_pie.c | 16 +-
lib/sched/rte_sched.c | 297 +---
lib/sched/rte_sched_l
A little more complex here since the one hash library actually
has multiple routines in it. Split up the logtypes for
hash and toeplitz.
The hash crc file has another issue around logging.
It is calling RTE_LOG during a constructor which is maybe
problematic because this will all run before the D
Even though KNI will eventually disappear, fix the
logtype now.
Signed-off-by: Stephen Hemminger
---
lib/eal/common/eal_common_log.c | 1 -
lib/eal/include/rte_log.h | 2 +-
lib/kni/rte_kni.c | 63 ++---
3 files changed, 35 insertions(+), 31 dele
Split lpm and lpm6 into separate log types since they
are in different files and user may want to change log
levels for IPv4 vs IPv6.
For rib and fib libraries give them own types as well.
Signed-off-by: Stephen Hemminger
---
lib/eal/common/eal_common_log.c | 1 -
lib/eal/include/rte_log.h
Convert from RTE_LOGTYPE_MEMPOOL to logtype_mempool.
Signed-off-by: Stephen Hemminger
---
lib/eal/common/eal_common_log.c | 1 -
lib/eal/include/rte_log.h | 2 +-
lib/mempool/rte_mempool.c | 33 ++---
lib/mempool/rte_mempool_log.h | 10 ++
lib/
Use dynamic log type for power library.
Also replace use of RTE_LOGTYPE_USER1 with lib.power.guest.
Signed-off-by: Stephen Hemminger
---
lib/eal/common/eal_common_log.c| 1 -
lib/eal/include/rte_log.h | 2 +-
lib/power/guest_channel.c | 48 +
lib/power/power_ac
The logtype for ring only used in library.
Signed-off-by: Stephen Hemminger
---
lib/eal/common/eal_common_log.c | 1 -
lib/eal/include/rte_log.h | 2 +-
lib/ring/rte_ring.c | 31 +++
3 files changed, 20 insertions(+), 14 deletions(-)
diff --git a/
Get rid of RTE_LOGTYPE_ACL and RTE_LOGTYPE_MALLOC.
For ACL library use a dynamic type.
The one message using RTE_LOGTYPE_MALLOC should have been
under the ACL logtype anyway.
The test code should not have been using fixed log type
so just change that to stderr.
Signed-off-by: Stephen Hemminger
-
Introduce a new dynamic logtype for mbuf related messages.
Since this is used in multiple files put one macro in mbuf_log.h
Signed-off-by: Stephen Hemminger
---
lib/eal/common/eal_common_log.c | 1 -
lib/eal/include/rte_log.h | 2 +-
lib/mbuf/mbuf_log.h | 10 ++
lib/m
Replace all uses of global logtype with a local log type.
Do not break message formats across source lines.
Signed-off-by: Stephen Hemminger
---
lib/eal/common/eal_common_log.c | 1 -
lib/eal/include/rte_log.h | 2 +-
lib/efd/rte_efd.c | 106 +++---
The timer code does not use rte_log.
Signed-off-by: Stephen Hemminger
---
lib/eal/common/eal_common_log.c | 1 -
lib/eal/include/rte_log.h | 2 +-
2 files changed, 1 insertion(+), 2 deletions(-)
diff --git a/lib/eal/common/eal_common_log.c b/lib/eal/common/eal_common_log.c
index c369154cb
If a large packet is passed into GSO routines of unknown protocol
then library would log a message and pass it through. This is incorrect
behaviour on many levels:
- it allows oversize packet to get passed on to NIC driver
- no direct return is visible to applications
- if it happens once, ma
Libraries should not reuse RTE_LOGTYPE_USER1 for their
loggging. Instead they should register their own type.
Fixes: 5cd3cac9ed22 ("latency: added new library for latency stats")
Cc: reshma.pat...@intel.com
Signed-off-by: Stephen Hemminger
Signed-off-by: Stephen Hemminger
---
lib/latencystats/
Libraries should not be reusing RTE_LOGTYPE_USER1 instead
of doing proper logtype registration.
Fixes: b70b56032bff ("reorder: new library")
Cc: sergio.gonzalez.mon...@intel.com
Signed-off-by: Stephen Hemminger
---
lib/reorder/rte_reorder.c | 35 +++
1 file change
DPDK libraries should not be reusing RTE_LOGTYPE_USER1 in
lieu of doing proper logtype registration.
Fixes: 416707812c03 ("ip_frag: refactor reassembly code into a proper library")
Signed-off-by: Stephen Hemminger
---
lib/ip_frag/ip_frag_common.h | 16 ++-
lib/ip_frag/ip_frag_internal.c
These static log types should be deprecated in next stable
release.
Also, remove use of USER1 from example of doing mlockall.
Signed-off-by: Stephen Hemminger
---
doc/guides/prog_guide/writing_efficient_code.rst | 3 +--
doc/guides/rel_notes/deprecation.rst | 4
2 files changed
Second draft of removing static log types. This version also
fixes abuse of RTE_LOGTYPE_USER1 in some libraries.
May split the USER1 stuff out into seperate patch bundle
in later versions.
Still left is the big device driver usage.
Stephen Hemminger (17):
doc: document intention to deprecate
2023-02-06 16:19 (UTC-0800), Stephen Hemminger:
> While diagnosing some Windows cross build errors;
> noticed that lots of important DPDK libraries are not
> being built on Windows.
>
> Stephen Hemminger (8):
> net/null: build null PMD on Windows
> net/ring: build on Windows
> lpm: enable on
> -Original Message-
> From: Jerin Jacob
> Sent: Tuesday, February 7, 2023 12:01 AM
> To: Carrillo, Erik G ; Stephen Hemminger
>
> Cc: jer...@marvell.com; dev@dpdk.org; sta...@dpdk.org
> Subject: Re: [PATCH v2] eventdev/timer: fix overflow issue
>
> On Wed, Jan 25, 2023 at 2:16 AM Erik
On Tue, Feb 07, 2023 at 04:16:58PM +0100, Morten Brørup wrote:
> > From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com]
> > Sent: Friday, 3 February 2023 21.49
> >
> > On Fri, Feb 03, 2023 at 12:19:13PM +, Bruce Richardson wrote:
> > > On Thu, Feb 02, 2023 at 11:00:23AM -0800, Tyler Retz
On Tue, Feb 07, 2023 at 02:12:18PM +0100, David Marchand wrote:
> On Tue, Jan 31, 2023 at 9:30 PM Tyler Retzlaff
> wrote:
> >
> > Add rte_control_thread_create API as a replacement for
> > rte_ctrl_thread_create to allow deprecation of the use of platform
> > specific types in DPDK public API.
> >
On Tue, Feb 07, 2023 at 04:39:06PM +0100, David Marchand wrote:
> On Tue, Jan 31, 2023 at 9:30 PM Tyler Retzlaff
> wrote:
> >
> > Add missing thread index referencing rte_thread.h under the basic
> > topic.
> >
> > Signed-off-by: Tyler Retzlaff
> > ---
> > doc/api/doxy-api-index.md | 1 +
> > 1
Also can remove unused RTE_LOGTYPE_METER
Signed-off-by: Stephen Hemminger
---
lib/eal/common/eal_common_log.c | 2 -
lib/eal/include/rte_log.h | 4 +-
lib/sched/rte_pie.c | 16 +-
lib/sched/rte_sched.c | 297 +---
lib/sched/rte_sched_l
A little more complex here since the one hash library actually
has multiple routines in it. Split up the logtypes for
hash and toeplitz.
The hash crc file has another issue around logging.
It is calling RTE_LOG during a constructor which is maybe
problematic because this will all run before the D
Even though KNI will eventually disappear, fix the
logtype now.
Signed-off-by: Stephen Hemminger
---
lib/eal/common/eal_common_log.c | 1 -
lib/eal/include/rte_log.h | 2 +-
lib/kni/rte_kni.c | 63 ++---
3 files changed, 35 insertions(+), 31 dele
Split lpm and lpm6 into seperate log types since they
are in different files and user may want to change log
levels for IPv4 vs IPv6.
For rib and fib libraries give them own types as well.
Signed-off-by: Stephen Hemminger
---
lib/eal/common/eal_common_log.c | 1 -
lib/eal/include/rte_log.h
Convert from RTE_LOGTYPE_MEMPOOL to logtype_mempool.
Signed-off-by: Stephen Hemminger
---
lib/eal/common/eal_common_log.c | 1 -
lib/eal/include/rte_log.h | 2 +-
lib/mempool/rte_mempool.c | 33 ++---
lib/mempool/rte_mempool_log.h | 10 ++
lib/
Use dynamic log type for power library.
Also replace use of RTE_LOGTYPE_USER1 with lib.power.guest.
Signed-off-by: Stephen Hemminger
---
lib/eal/common/eal_common_log.c| 1 -
lib/eal/include/rte_log.h | 2 +-
lib/power/guest_channel.c | 48 +
lib/power/power_ac
The logtype for ring only used in library.
Signed-off-by: Stephen Hemminger
---
lib/eal/common/eal_common_log.c | 1 -
lib/eal/include/rte_log.h | 2 +-
lib/ring/rte_ring.c | 31 +++
3 files changed, 20 insertions(+), 14 deletions(-)
diff --git a/
Get rid of RTE_LOGTYPE_ACL and RTE_LOGTYPE_MALLOC.
For ACL library use a dynamic type.
The one message using RTE_LOGTYPE_MALLOC should have been
under the ACL logtype anyway.
The test code should not have been using fixed log type
so just change that to stderr.
Signed-off-by: Stephen Hemminger
-
Introduce a new dynamic logtype for mbuf related messages.
Since this is used in multiple files put one macro in mbuf_log.h
Signed-off-by: Stephen Hemminger
---
lib/eal/common/eal_common_log.c | 1 -
lib/eal/include/rte_log.h | 2 +-
lib/mbuf/mbuf_log.h | 10 ++
lib/m
Replace all uses of global logtype with a local log type.
Do not break message formats across source lines.
Signed-off-by: Stephen Hemminger
---
lib/eal/common/eal_common_log.c | 1 -
lib/eal/include/rte_log.h | 2 +-
lib/efd/rte_efd.c | 106 +++---
The timer code does not use rte_log
---
lib/eal/common/eal_common_log.c | 1 -
lib/eal/include/rte_log.h | 2 +-
2 files changed, 1 insertion(+), 2 deletions(-)
diff --git a/lib/eal/common/eal_common_log.c b/lib/eal/common/eal_common_log.c
index c369154cb1ea..e7ccde1c9ccd 100644
--- a/lib/e
If a large packet is passed into GSO routines of unknown protocol
then library would log a message and pass it through. This is incorrect
behaviour on many levels:
- it allows oversize packet to get passed on to NIC driver
- no direct return is visible to applications
- if it happens once, ma
These static log types should be deprecated in next stable
release.
Also, remove use of USER1 from example of doing mlockall.
Signed-off-by: Stephen Hemminger
---
doc/guides/prog_guide/writing_efficient_code.rst | 3 +--
doc/guides/rel_notes/deprecation.rst | 4
2 files changed
This is a first draft and tackling the removal of static logtypes.
It starts with the easy one and goes on to the more complex ones.
It does not address the biggest effort which is the eal,
eventdev, cryptodev, and pmd log types.
Mostly this is semi-automatic conversion but some places like
hash
From: Pavan Nikhilesh
Remove unnecessary locks as locking is now taken care by
mbox_get and mbox_put.
Signed-off-by: Pavan Nikhilesh
---
v2 Changes:
- Rebase on main
drivers/common/cnxk/roc_sso.c | 25 -
drivers/common/cnxk/roc_sso_priv.h | 1 -
2 files changed
The --record-core-cycles option already accounts for busy cycles. One
turn of packet_fwd_t is considered "busy" if there was at least one
received or transmitted packet.
Rename core_cycles to busy_cycles in struct fwd_stream to make it more
explicit. Add total_cycles to struct fwd_lcore. Add cycle
Allow fetching CPU cycles usage for all lcores with a single request.
This endpoint is intended for repeated and frequent invocations by
external monitoring systems and therefore returns condensed data.
It consists of a single dictionary with three keys: "lcore_ids",
"total_cycles" and "busy_cycle
Add a simple command that calls rte_lcore_dump().
Signed-off-by: Robin Jarry
Acked-by: Morten Brørup
Acked-by: Konstantin Ananyev
Reviewed-by: Kevin Laatz
---
Notes:
v8 -> v9: no change
app/test-pmd/cmdline.c | 3 +++
doc/guides/testpmd_app_ug/testpmd_funcs.rst | 7
Allow applications to register a callback that will be invoked in
rte_lcore_dump() and when requesting lcore info in the telemetry API.
The callback is expected to return the number of TSC cycles that have
passed since application start and the number of these cycles that were
spent doing busy wor
Report the same information than rte_lcore_dump() in the telemetry
API into /eal/lcore/list and /eal/lcore/info,ID.
Example:
--> /eal/lcore/info,3
{
"/eal/lcore/info": {
"lcore_id": 3,
"socket": 0,
"role": "RTE",
"cpuset": [
3
]
}
}
Signed-off-
This is a follow up on previous work by Kevin Laatz:
http://patches.dpdk.org/project/dpdk/list/?series=24658&state=*
This series is aimed at allowing DPDK applications to expose their CPU
usage stats in the DPDK telemetry under /eal/lcore/info. This is a much
more basic and naive approach which l
If a telemetry endpoint callback returns 0 without modifying the data
object, output_json() may be called with undefined contents in data.
This can cause crashes and/or worse (double free, etc.).
Reset data before passing it to the endpoint callbacks.
Fixes: 6dd571fd07c3 ("telemetry: introduce ne
On Tue, Feb 7, 2023 at 4:18 PM Maxime Coquelin
wrote:
>
> This patch implements control messages forwarding from the
> regular control queue to the shadow control queue.
>
> Signed-off-by: Maxime Coquelin
Acked-by: Eugenio Pérez
> ---
> .../net/virtio/virtio_user/virtio_user_dev.c | 35 +
On Tue, Feb 7, 2023 at 4:18 PM Maxime Coquelin
wrote:
>
> This patch advertizes control virtqueue support by the vDPA
> backend if it supports VIRTIO_NET_F_CTRL_VQ.
>
> Signed-off-by: Maxime Coquelin
> Reviewed-by: Chenbo Xia
Acked-by: Eugenio Pérez
> ---
> drivers/net/virtio/virtio_user/vho
In case of rte_ipsec_session_prepare() error, the crypto session was
not freed, leading to its leakage.
Fixes: 20777eb5f913 ("pipeline: add IPsec")
Coverity issue: 383139
Signed-off-by: Cristian Dumitrescu
---
lib/pipeline/rte_swx_ipsec.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(
On Tue, Feb 7, 2023 at 4:18 PM Maxime Coquelin
wrote:
>
> This patch introduces a new callback that is to be called
> when the backend supports control virtqueue.
>
> Implementation for Vhost-vDPA backend is added in this patch.
>
> Signed-off-by: Maxime Coquelin
> Reviewed-by: Chenbo Xia
Small
On Tue, Feb 7, 2023 at 4:18 PM Maxime Coquelin
wrote:
>
> This patch adds sending the shadow control queue info
> to the backend.
>
> Signed-off-by: Maxime Coquelin
> Reviewed-by: Chenbo Xia
Acked-by: Eugenio Pérez
> ---
> .../net/virtio/virtio_user/virtio_user_dev.c | 28 --
On Tue, Feb 7, 2023 at 4:18 PM Maxime Coquelin
wrote:
>
> If the backends supports control virtqueue, allocate a
> shadow control virtqueue, and implement the notify callback
> that writes into the kickfd.
>
> Signed-off-by: Maxime Coquelin
> Reviewed-by: Chenbo Xia
Even with the nitpick below,
On Tue, Feb 7, 2023 at 4:18 PM Maxime Coquelin
wrote:
>
> When supported by the backend (only vDPA for now), this
> patch gets the maximum number of queue pairs supported by
> the device by querying it in its config space.
>
> This is required for adding backend control queue support,
> as is inde
If eth_stats_get fails (for example with -ENOTSUPP) then
dumpcap would pass that to strerror which is incorrect.
Fixes: 8744f84bb255 ("app/dumpcap: add statistics mode")
Coverity issue: 383136
Signed-off-by: Stephen Hemminger
---
app/dumpcap/main.c | 2 +-
1 file changed, 1 insertion(+), 1 delet
1 - 100 of 310 matches
Mail list logo
