Re: [EXT] Re: [PATCH v3 0/4] implementation of ML common code

2023-01-26 Thread Jerin Jacob
On Thu, Jan 26, 2023 at 4:27 PM Thomas Monjalon wrote: > > 25/01/2023 15:59, Srikanth Yalavarthi: > > From: Thomas Monjalon > > > 25/01/2023 14:25, Srikanth Yalavarthi: > > > > From: Thomas Monjalon > > > > > 20/12/2022 18:52, Srikanth Yalavarthi: > > > > > > This patch series implements the com

Re: [PATCH 1/3] lib: dpdk spec to skip red for ingress policer

2023-01-26 Thread Jerin Jacob
On Thu, Jan 26, 2023 at 8:43 PM Ori Kam wrote: > > > > > -Original Message- > > From: Rakesh Kudurumalla > > Sent: Wednesday, 18 January 2023 10:10 > > > > > > > -Original Message- > > > From: Rakesh Kudurumalla > > > Sent: Tuesday, January 10, 2023 12:12 PM > > > To: Ori Kam ; Je

RE: [EXT] Re: [PATCH v5 2/2] app/testpmd: add command to process Rx metadata negotiation

2023-01-26 Thread Nithin Kumar Dabilpuram
Please see inline. > -Original Message- > From: Thomas Monjalon > Sent: Thursday, January 26, 2023 4:33 PM > To: Nithin Kumar Dabilpuram > Cc: Aman Singh ; Yuying Zhang > ; > Ivan Malov ; Andrew Rybchenko > ; dev@dpdk.org; Hanumanth Reddy Pothula > ; Ferruh Yigit ; > viachesl...@nvidia

Re: [EXT] Re: [dpdk-dev] [PATCH v1 00/12] mldev: introduce machine learning device library

2023-01-26 Thread Jerin Jacob
On Fri, Jan 27, 2023 at 8:04 AM Shivah Shankar Shankar Narayan Rao wrote: > > External Email > > -- > 25/01/2023 20:01, Jerin Jacob: > > On Wed, Jan 25, 2023 at 7:50 PM Thomas Monjalon wrote: > > > 14/11/2022 13:02, jer...@marvel

[PATCH] net/mlx5: check compressed CQE opcode for an error

2023-01-26 Thread Alexander Kozyrev
The CQE opcode is never checked for a compressed CQE in the vectorized Rx burst routines. It is assumed that compressed CQEs are always valid and skipped error checking. This is obviously not the case and error CQEs may be compressed together as well. Need to check for the MLX5_CQE_RESP_ERR opcode

[PATCH] net/mlx5: ignore non-critical syndromes for Rx queue

2023-01-26 Thread Alexander Kozyrev
For non-fatal syndromes like LOCAL_LENGTH_ERR, the Rx queue reset shouldn't be triggered. Rx queue could continue with the next packets without any recovery. Only three syndromes warrant Rx queue reset: LOCAL_QP_OP_ERR, LOCAL_PROT_ERR and WR_FLUSH_ERR. Do not initiate a Rx queue reset in any other

[PATCH] net/mlx5: fix error CQE dumping for vectorized Rx burst

2023-01-26 Thread Alexander Kozyrev
There is a dump file with debug information created for an error CQE to help with troubleshooting later. It starts with the last CQE, which, presumably is the error CQE. But this is only true for the scalar Rx burst routing since we handle CQEs there one by one and detect the error immediately. For

[PATCH 4/4] net/mlx5: define index register for linear tables

2023-01-26 Thread Alexander Kozyrev
Set MLX5_LINEAR_HASH_TAG_INDEX as a special id for the TAG item: it holds the index in a linear table for a packet to land to. This rule index in the table uses upper 16-bits of REG_C_3, handle this TAG item in the modify_field API for setting the index. Signed-off-by: Alexander Kozyrev --- driv

[PATCH 3/4] net/mlx5: add hash result metadata to modify field

2023-01-26 Thread Alexander Kozyrev
Allow copy of the hash result via modify_field Flow API. Setting this value is not allowed, it is read-only field. Signed-off-by: Alexander Kozyrev --- drivers/net/mlx5/mlx5_flow_dv.c | 12 drivers/net/mlx5/mlx5_flow_hw.c | 5 +++-- 2 files changed, 15 insertions(+), 2 deletions(-)

[PATCH 2/4] net/mlx5: add flow rule insertion by index

2023-01-26 Thread Alexander Kozyrev
New Flow API allows to insert flow rules into a specified index for tables with the index-based insertion type. Implement rte_flow_async_create_by_index API in mlx5 PMD. Signed-off-by: Alexander Kozyrev --- drivers/net/mlx5/mlx5_flow.c| 61 + drivers/net/mlx5/mlx5_flow.h

[PATCH 1/4] net/mlx5: add table insertion type and hash function

2023-01-26 Thread Alexander Kozyrev
Pass the insertion type and hash calculation function of a table to the mlx5 PMD driver. Create appropriate table as requested. Note that 16-bit checksum hash calculation is not supported yet. Signed-off-by: Alexander Kozyrev --- drivers/net/mlx5/mlx5_flow_hw.c | 26 +- 1

[PATCH 0/4] net/mlx5: add template table insertion and matching types

2023-01-26 Thread Alexander Kozyrev
Add the insertion type and hash calculation function of a template table. Support the new rte_flow_async_create_by_index() Flow API to allow flow rules insertion into a specified index of index-based template tables. Set MLX5_LINEAR_HASH_TAG_INDEX as a special id for specifiyng the index. Allow to

[PATCH v2 3/4] app/testpmd: add template table insertion type

2023-01-26 Thread Alexander Kozyrev
Add testpmd CLI interface for specifying a template table insertion type. Available types are: pattern and index. flow template_table 0 create table_id 0 insertion_type index ... Allow specifying the rule index instead of the pattern template index: flow queue 0 create 0 template_table 0 rule_index

[PATCH v2 4/4] app/testpmd: add template table hash calculation function

2023-01-26 Thread Alexander Kozyrev
Add testpmd CLI interface for a template table hash function. Available types are: default, linear, crc32 and crc16. flow template_table 0 create table_id 0 hash_func linear ... Signed-off-by: Alexander Kozyrev --- app/test-pmd/cmdline_flow.c | 69 - 1 file ch

[PATCH v2 2/4] ethdev: add template table hash calculation function

2023-01-26 Thread Alexander Kozyrev
Allow user to specify hash calculation function used in template tables. The hash calculation type is responsible for the calculation of the flow rule index a packet would hit upon arrival at the table. Control over this is useful for applications with custom RSS algorithms, for example. An applic

[PATCH v2 1/4] ethdev: add template table insertion type

2023-01-26 Thread Alexander Kozyrev
Allow user to specify insertion type used in template tables. The insertion type is responsible for choosing the appropriate key value used to map inserted flow rules into a template table. Flow rules can be inserted by calculating the hash value for the pattern or inserted by index via the new cr

[PATCH v2 0/4] ethdev: add template table insertion and matching types

2023-01-26 Thread Alexander Kozyrev
Bring more flexibility and control over both flow rule insertion and packet matching mechanisms. Introduce 2 new flow table types: 1. Allow a user to specify the insertion type used in template tables. The insertion type is responsible for choosing the appropriate key value used to map inserted fl

DPDK Release Status Meeting 2023-01-26

2023-01-26 Thread Mcnamara, John
Release status meeting minutes 2023-01-26 = Agenda: * Release Dates * Subtrees * Roadmaps * LTS * Defects * Opens Participants: * AMD * Intel * Nvidia * Red Hat Release Dates - The following are the proposed current dates for 23.03: * V1:

[PATCH 3/3] dumpcap: add support statistics mode

2023-01-26 Thread Stephen Hemminger
This add new -S option which does the same thing as wireshark's dumpcap -S option. It loops over all interfaces and prints the number of received and dropped packets. In this mode, actual packet capture is not done. Signed-off-by: Stephen Hemminger --- app/dumpcap/main.c | 55 ++

[PATCH 2/3] dumpcap: support temp-dir option

2023-01-26 Thread Stephen Hemminger
Option for putting output files in different directory. Same syntax as wireshark. Signed-off-by: Stephen Hemminger --- app/dumpcap/main.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/app/dumpcap/main.c b/app/dumpcap/main.c index 297b6378aaf2..02bb8b2b2b4f 100644 --

[PATCH 1/3] dumpcap: add --interface to help

2023-01-26 Thread Stephen Hemminger
Make the help more complete, add all supported options. Signed-off-by: Stephen Hemminger --- app/dumpcap/main.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/app/dumpcap/main.c b/app/dumpcap/main.c index 2eb8414efaa5..297b6378aaf2 100644 --- a/app/dumpcap/main.c +++ b/app

[PATCH 0/3] dumpcap: small enhancements

2023-01-26 Thread Stephen Hemminger
Cover a few more options and statistics mode to be add more compatiablity with wireshark dumpcap. Stephen Hemminger (3): dumpcap: add --interface to help dumpcap: support temp-dir option dumpcap: add support statistics mode app/dumpcap/main.c | 67 --

Re: [PATCH v2 3/3] build: limit what is built when using MSVC compiler

2023-01-26 Thread Bruce Richardson
On Thu, Jan 26, 2023 at 10:03:24AM -0800, Tyler Retzlaff wrote: > Build only kvargs and telemetry when is_ms_compiler. > > Signed-off-by: Tyler Retzlaff > --- Thanks for v2 Acked-by: Bruce Richardson

Re: [PATCH v2 0/3] unblock the use of the MSVC compiler

2023-01-26 Thread Tyler Retzlaff
On Thu, Jan 26, 2023 at 10:03:21AM -0800, Tyler Retzlaff wrote: > Introduce minimum changes to the build system to allow use of the MSVC > compiler. > > This change is intended to enable a phased approach to allowing DPDK to > built with MSVC. Building with MSVC removes barriers to enterprise > cu

[PATCH v2 1/3] build: unblock the use of the MSVC compiler

2023-01-26 Thread Tyler Retzlaff
Detect when MSVC toolset is available and tweak toolchain arguments where the meson build system offers no abstraction. Signed-off-by: Tyler Retzlaff Acked-by: Bruce Richardson --- buildtools/meson.build | 10 +++--- config/meson.build | 21 ++--- config/x86/meson.build

[PATCH v2 3/3] build: limit what is built when using MSVC compiler

2023-01-26 Thread Tyler Retzlaff
Build only kvargs and telemetry when is_ms_compiler. Signed-off-by: Tyler Retzlaff --- app/meson.build | 5 + drivers/meson.build | 4 lib/meson.build | 7 +++ usertools/meson.build | 4 4 files changed, 20 insertions(+) diff --git a/app/meson.build b/app/meson.b

[PATCH v2 2/3] build: determine execution environment at config time

2023-01-26 Thread Tyler Retzlaff
Move execution environment determination and definitions to config. The RTE_EXEC_ENV macros are actually used by libraries built before EAL. Currently it does not matter that this is determined in lib/eal since the definitions are consumed before anything is built including libs built before lib/e

[PATCH v2 0/3] unblock the use of the MSVC compiler

2023-01-26 Thread Tyler Retzlaff
Introduce minimum changes to the build system to allow use of the MSVC compiler. This change is intended to enable a phased approach to allowing DPDK to built with MSVC. Building with MSVC removes barriers to enterprise customers use of DPDK who have constraints around security policy, compliance

Re: [PATCH 3/3] build: limit what is built when using MSVC compiler

2023-01-26 Thread Tyler Retzlaff
On Thu, Jan 26, 2023 at 05:34:50PM +, Bruce Richardson wrote: > On Thu, Jan 26, 2023 at 09:28:58AM -0800, Tyler Retzlaff wrote: > > On Thu, Jan 26, 2023 at 11:10:26AM +, Bruce Richardson wrote: > > > On Wed, Jan 25, 2023 at 11:25:07AM -0800, Tyler Retzlaff wrote: > > > > Build only kvargs a

Re: [PATCH 3/3] build: limit what is built when using MSVC compiler

2023-01-26 Thread Bruce Richardson
On Thu, Jan 26, 2023 at 09:28:58AM -0800, Tyler Retzlaff wrote: > On Thu, Jan 26, 2023 at 11:10:26AM +, Bruce Richardson wrote: > > On Wed, Jan 25, 2023 at 11:25:07AM -0800, Tyler Retzlaff wrote: > > > Build only kvargs and telemetry when is_ms_compiler. > > > > > > Signed-off-by: Tyler Retzla

Re: [PATCH 3/3] build: limit what is built when using MSVC compiler

2023-01-26 Thread Tyler Retzlaff
On Thu, Jan 26, 2023 at 11:10:26AM +, Bruce Richardson wrote: > On Wed, Jan 25, 2023 at 11:25:07AM -0800, Tyler Retzlaff wrote: > > Build only kvargs and telemetry when is_ms_compiler. > > > > Signed-off-by: Tyler Retzlaff > > --- > > lib/meson.build | 7 +++ > > meson.build | 13 ++

Re: [EXT] Re: [PATCH 1/2] lib: add helper to read strings from sysfs files

2023-01-26 Thread Tyler Retzlaff
On Thu, Jan 26, 2023 at 08:30:01AM +, Tomasz Duszynski wrote: > > >-Original Message- > >From: Tyler Retzlaff > >Sent: Wednesday, January 25, 2023 5:16 PM > >To: Thomas Monjalon > >Cc: Tomasz Duszynski ; dev@dpdk.org; Jerin Jacob > >Kollanukkaran > >; step...@networkplumber.org; che

[PATCH v5 8/8] net: mark all big endian types

2023-01-26 Thread Ferruh Yigit
From: Thomas Monjalon Some protocols (ARP, MPLS and HIGIG2) were using uint16_t and uint32_t types for their 16 and 32-bit fields. It was correct but not conveying the big endian nature of these fields. As for other protocols defined in this directory, all types are explicitly marked as big endi

[PATCH v5 7/8] doc: fix description of L2TPV2 flow item

2023-01-26 Thread Ferruh Yigit
From: Thomas Monjalon The flow item structure includes the protocol definition from the directory lib/net/, so it is reflected in the guide. Section title underlining is also fixed around. Fixes: 3a929df1f286 ("ethdev: support L2TPv2 and PPP procotol") Cc: sta...@dpdk.org Signed-off-by: Thomas

[PATCH v5 6/8] ethdev: use ARP protocol struct for flow matching

2023-01-26 Thread Ferruh Yigit
From: Thomas Monjalon As announced in the deprecation notice, flow item structures should re-use the protocol header definitions from the directory lib/net/. The protocol struct is added in an unnamed union, keeping old field names. The ARP header struct members are used in testpmd instead of t

[PATCH v5 5/8] ethdev: use GTP protocol struct for flow matching

2023-01-26 Thread Ferruh Yigit
From: Thomas Monjalon As announced in the deprecation notice, flow item structures should re-use the protocol header definitions from the directory lib/net/. The protocol struct is added in an unnamed union, keeping old field names. The GTP header struct members are used in apps and drivers ins

[PATCH v5 4/8] ethdev: use GRE protocol struct for flow matching

2023-01-26 Thread Ferruh Yigit
From: Thomas Monjalon As announced in the deprecation notice, flow item structures should re-use the protocol header definitions from the directory lib/net/. The protocol struct is added in an unnamed union, keeping old field names. The GRE header struct members are used in apps and drivers ins

[PATCH v5 3/8] ethdev: use VXLAN protocol struct for flow matching

2023-01-26 Thread Ferruh Yigit
From: Thomas Monjalon As announced in the deprecation notice, flow item structures should re-use the protocol header definitions from the directory lib/net/. In the case of VXLAN-GPE, the protocol struct is added in an unnamed union, keeping old field names. The VXLAN headers (including VXLAN-G

[PATCH v5 1/8] ethdev: use Ethernet protocol struct for flow matching

2023-01-26 Thread Ferruh Yigit
From: Thomas Monjalon As announced in the deprecation notice, flow item structures should re-use the protocol header definitions from the directory lib/net/. The Ethernet headers (including VLAN) structures are used instead of the redundant fields in the flow items. The remaining protocols to cl

[PATCH v5 2/8] net: add smaller fields for VXLAN

2023-01-26 Thread Ferruh Yigit
From: Thomas Monjalon The VXLAN and VXLAN-GPE headers were including reserved fields with other fields in big uint32_t struct members. Some more precise definitions are added as union of the old ones. The new struct members are smaller in size and in names. Signed-off-by: Thomas Monjalon ---

[PATCH v5 0/8] start cleanup of rte_flow_item_*

2023-01-26 Thread Ferruh Yigit
There was a plan to have structures from lib/net/ at the beginning of corresponding flow item structures. Unfortunately this plan has not been followed up so far. This series is a step to make the most used items, compliant with the inheritance design explained above. The old API is kept in anonymo

[PATCH 4/5] net/mlx5/hws: support IP version matching for non relaxed

2023-01-26 Thread Hamdan Igbaria
Enable matching on IP version explicitly for non relaxed mode. This will add support for the user cases where he needs to match on ip version explicitly, for such case to have outer ipv6 and inner ipv4 packets, etc. Signed-off-by: Hamdan Igbaria --- drivers/net/mlx5/hws/mlx5dr_definer.c | 16 +++

[PATCH 5/5] net/mlx5: support HW steering debug dump

2023-01-26 Thread Hamdan Igbaria
Add the ability for the DPDK apps to call HW steering relevant debug data dump function. Signed-off-by: Hamdan Igbaria --- drivers/net/mlx5/mlx5_flow.c | 19 +-- 1 file changed, 13 insertions(+), 6 deletions(-) diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_fl

[PATCH 3/5] net/mlx5/hws: support STC info dump

2023-01-26 Thread Hamdan Igbaria
Dump the STC info in debug dump. Signed-off-by: Hamdan Igbaria --- drivers/net/mlx5/hws/mlx5dr_debug.c | 55 + drivers/net/mlx5/hws/mlx5dr_debug.h | 1 + 2 files changed, 56 insertions(+) diff --git a/drivers/net/mlx5/hws/mlx5dr_debug.c b/drivers/net/mlx5/hws/mlx5d

[PATCH 2/5] net/mlx5/hws: change STC array size to 32K

2023-01-26 Thread Hamdan Igbaria
Change STC array size from 16K to 32K. This change allows supporting more actions using HWS. Signed-off-by: Hamdan Igbaria --- drivers/net/mlx5/hws/mlx5dr_pool.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/mlx5/hws/mlx5dr_pool.h b/drivers/net/mlx5/hws/mlx5dr_

[PATCH 1/5] net/mlx5/hws: fix alias_rtc_0 print location in debug dump

2023-01-26 Thread Hamdan Igbaria
Fix alias_rtc_0 print location in debug dump, move it to the end of matcher dumped info instead of the middle, to keep the dump compatibility. Fixes: dd2845361a58 ("net/mlx5/hws: add debug details for cross gvmi") Signed-off-by: Hamdan Igbaria --- drivers/net/mlx5/hws/mlx5dr_debug.c | 12 ++-

Re: [PATCH 2/2] test/reorder: fix double free of drained buffers

2023-01-26 Thread David Marchand
On Sat, Jan 7, 2023 at 4:20 PM Volodymyr Fialko wrote: > > Set to zero array of drained buffers after free, to prevent freeing them > one more time. > Discovered with enabled `RTE_LIBRTE_MEMPOOL_DEBUG`. Good catch, having those debug options enabled in the CI could be interesting. Cc: CI people,

Re: [PATCH 0/3] reorder: introduce new APIs

2023-01-26 Thread David Marchand
On Fri, Jan 20, 2023 at 11:22 AM Volodymyr Fialko wrote: > > This patch series provides new APIs for reorder library and test cases for > them. > > Volodymyr Fialko (3): > reorder: add new drain up to seq number API > reorder: add ability to set min sequence number > test/reorder: add cases

Re: [PATCH 0/2] lib/reorder: fix drain/free issues

2023-01-26 Thread David Marchand
Hi Reshma, On Sat, Jan 7, 2023 at 4:20 PM Volodymyr Fialko wrote: > > This patch address issues with reorder drain/free, > discovered with enabled `RTE_LIBRTE_MEMPOOL_DEBUG`. > > Volodymyr Fialko (2): > reorder: invalidate buf from ready queue in drain > test/reorder: fix double free of drain

RE: [EXT] Re: [PATCH v6 1/4] lib: add generic support for reading PMU events

2023-01-26 Thread Tomasz Duszynski
>-Original Message- >From: Bruce Richardson >Sent: Thursday, January 26, 2023 1:59 PM >To: Morten Brørup >Cc: Tomasz Duszynski ; dev@dpdk.org; Thomas Monjalon >; >Jerin Jacob Kollanukkaran ; ruifeng.w...@arm.com; >mattias.ronnb...@ericsson.com; zhou...@loongson.cn; >roret...@linux.mi

[PATCH v7 4/5] app/testpmd: report lcore usage

2023-01-26 Thread Robin Jarry
Reuse the --record-core-cycles option to account for busy cycles. One turn of packet_fwd_t is considered "busy" if there was at least one received or transmitted packet. Add a new busy_cycles field in struct fwd_stream. Update get_end_cycles to accept an additional argument for the number of proce

[PATCH v7 5/5] eal: add lcore usage telemetry endpoint

2023-01-26 Thread Robin Jarry
Allow fetching CPU cycles usage for all lcores with a single request. This endpoint is intended for repeated and frequent invocations by external monitoring systems and therefore returns condensed data. It consists of a single dictionary with three keys: "lcore_ids", "total_cycles" and "busy_cycle

[PATCH v7 3/5] app/testpmd: add dump command for lcores

2023-01-26 Thread Robin Jarry
Add a simple command that calls rte_lcore_dump(). Signed-off-by: Robin Jarry Acked-by: Morten Brørup Acked-by: Konstantin Ananyev Reviewed-by: Kevin Laatz --- Notes: v6 -> v7: Added doc entry app/test-pmd/cmdline.c | 3 +++ doc/guides/testpmd_app_ug/testpmd_funcs.rs

[PATCH v7 1/5] eal: add lcore info in telemetry

2023-01-26 Thread Robin Jarry
Report the same information than rte_lcore_dump() in the telemetry API into /eal/lcore/list and /eal/lcore/info,ID. Example: --> /eal/lcore/info,3 { "/eal/lcore/info": { "lcore_id": 3, "socket": 0, "role": "RTE", "cpuset": [ 3 ] } } Signed-off-

[PATCH v7 0/5] lcore telemetry improvements

2023-01-26 Thread Robin Jarry
This is a follow up on previous work by Kevin Laatz: http://patches.dpdk.org/project/dpdk/list/?series=24658&state=* This series is aimed at allowing DPDK applications to expose their CPU usage stats in the DPDK telemetry under /eal/lcore/info. This is a much more basic and naive approach which l

[PATCH v7 2/5] eal: report applications lcore usage

2023-01-26 Thread Robin Jarry
Allow applications to register a callback that will be invoked in rte_lcore_dump() and when requesting lcore info in the telemetry API. The callback is expected to return the number of TSC cycles that have passed since application start and the number of these cycles that were spent doing busy wor

RE: [PATCH v6 1/4] lib: add generic support for reading PMU events

2023-01-26 Thread Tomasz Duszynski
>-Original Message- >From: Morten Brørup >Sent: Thursday, January 26, 2023 1:30 PM >To: Tomasz Duszynski ; dev@dpdk.org; Thomas Monjalon > >Cc: Jerin Jacob Kollanukkaran ; ruifeng.w...@arm.com; >mattias.ronnb...@ericsson.com; zhou...@loongson.cn; bruce.richard...@intel.com; >roret...@linu

RE: [RFC] ethdev: sharing indirect actions between ports

2023-01-26 Thread Ori Kam
> -Original Message- > From: Andrew Rybchenko > Sent: Friday, 20 January 2023 14:23 > > On 1/18/23 19:37, Slava Ovsiienko wrote: > > > > > >> -Original Message- > >> From: Thomas Monjalon > >> Sent: Wednesday, January 18, 2023 6:22 PM > >> To: Slava Ovsiienko ; Ori Kam > >> >

RE: [PATCH 1/3] lib: dpdk spec to skip red for ingress policer

2023-01-26 Thread Ori Kam
> -Original Message- > From: Rakesh Kudurumalla > Sent: Wednesday, 18 January 2023 10:10 > > > > -Original Message- > > From: Rakesh Kudurumalla > > Sent: Tuesday, January 10, 2023 12:12 PM > > To: Ori Kam ; Jerin Jacob ; > > Stephen Hemminger > > Cc: NBU-Contact-Thomas Monjal

[PATCH V6 10/11] examples/pipeline: add block enable/disable CLI commands

2023-01-26 Thread Cristian Dumitrescu
Add CLI commands to enable/disable block execution on data plane threads. Signed-off-by: Cristian Dumitrescu Signed-off-by: Kamalakannan R --- examples/pipeline/cli.c | 154 1 file changed, 154 insertions(+) diff --git a/examples/pipeline/cli.c b/exampl

[PATCH V6 11/11] examples/pipeline: add IPsec example

2023-01-26 Thread Cristian Dumitrescu
Add example files to illustrate the pipeline IPsec support. Signed-off-by: Cristian Dumitrescu Signed-off-by: Kamalakannan R --- examples/pipeline/examples/ipsec.cli| 57 +++ examples/pipeline/examples/ipsec.io | 23 +++ examples/pipeline/examples/ipsec.spec | 138 ++

[PATCH V6 09/11] examples/pipeline: support blocks other than pipelines

2023-01-26 Thread Cristian Dumitrescu
Previously, the data plane threads only supported the execution of pipelines assigned to them through configuration updates. Now, the data plane threads also support running blocks such as IPsec. Signed-off-by: Cristian Dumitrescu Signed-off-by: Kamalakannan R --- examples/pipeline/thread.c | 1

[PATCH V6 08/11] examples/pipeline: rework the thread configuration updates

2023-01-26 Thread Cristian Dumitrescu
Previously, the configuration updates for the data plane threads were performed through message queues. Now, this mechanism is replaced by the control thread updating the mirror copy of the data plane thread configuration followed by pointer swapping. Signed-off-by: Cristian Dumitrescu Signed-off

[PATCH V6 07/11] examples/pipeline: add IPsec CLI commands

2023-01-26 Thread Cristian Dumitrescu
Add CLI commands for IPsec block configuration. Signed-off-by: Cristian Dumitrescu Signed-off-by: Kamalakannan R --- examples/pipeline/cli.c | 298 1 file changed, 298 insertions(+) diff --git a/examples/pipeline/cli.c b/examples/pipeline/cli.c index db

[PATCH V6 06/11] examples/pipeline: add CLI command for crypto device

2023-01-26 Thread Cristian Dumitrescu
Add CLI command for the configuration of crypto devices. Signed-off-by: Cristian Dumitrescu Signed-off-by: Kamalakannan R --- examples/pipeline/cli.c | 63 + 1 file changed, 63 insertions(+) diff --git a/examples/pipeline/cli.c b/examples/pipeline/cli.c

[PATCH V6 05/11] examples/pipeline: support crypto devices

2023-01-26 Thread Cristian Dumitrescu
Add support for crypto devices in the application. Signed-off-by: Cristian Dumitrescu Signed-off-by: Kamalakannan R --- examples/pipeline/obj.c | 62 + examples/pipeline/obj.h | 11 2 files changed, 73 insertions(+) diff --git a/examples/pipelin

[PATCH V6 04/11] examples/pipeline: streamline the Ethernet device support

2023-01-26 Thread Cristian Dumitrescu
Streamline the Ethernet device support code and remove redundant code. Signed-off-by: Cristian Dumitrescu Signed-off-by: Kamalakannan R --- examples/pipeline/cli.c | 172 ++-- examples/pipeline/main.c | 12 +-- examples/pipeline/obj.c | 186 +--

[PATCH V6 03/11] examples/pipeline: streamline ring support

2023-01-26 Thread Cristian Dumitrescu
Remove redundant ring related code. Signed-off-by: Cristian Dumitrescu Signed-off-by: Kamalakannan R --- examples/pipeline/cli.c | 24 ++-- examples/pipeline/obj.c | 63 - examples/pipeline/obj.h | 21 -- 3 files changed, 15 insert

[PATCH V6 02/11] examples/pipeline: rework memory pool support

2023-01-26 Thread Cristian Dumitrescu
Rework the memory pool CLI command to accommodate the MBUF private meta-data area size parameter. Signed-off-by: Cristian Dumitrescu Signed-off-by: Kamalakannan R --- examples/pipeline/cli.c | 72 ++--- examples/pipeline/examples/fib.cli| 2 +- exa

[PATCH V6 01/11] pipeline: add IPsec support

2023-01-26 Thread Cristian Dumitrescu
This block is providing IPsec support to the SWX pipeline. The IPsec block is external to the pipeline, so it needs to be explicitly instantiated and connected to a pipeline through the I/O ports. Signed-off-by: Cristian Dumitrescu Signed-off-by: Kamalakannan R --- lib/pipeline/meson.build

[PATCH V6 00/11] pipeline: add IPsec support

2023-01-26 Thread Cristian Dumitrescu
This patch set introduces a companion block for the SWX pipeline for IPsec support. The IPsec block is external to the pipeline, hence it needs to be explicitly instantiated by the user and connected to a pipeline instance through the pipeline I/O ports. Main features: * IPsec inbound (encrypted

[PATCH V5 11/11] examples/pipeline: add IPsec example

2023-01-26 Thread Cristian Dumitrescu
Add example files to illustrate the pipeline IPsec support. Signed-off-by: Cristian Dumitrescu Signed-off-by: Kamalakannan R --- examples/pipeline/examples/ipsec.cli| 57 +++ examples/pipeline/examples/ipsec.io | 23 +++ examples/pipeline/examples/ipsec.spec | 138 ++

[PATCH V5 10/11] examples/pipeline: add block enable/disable CLI commands

2023-01-26 Thread Cristian Dumitrescu
Add CLI commands to enable/disable block execution on data plane threads. Signed-off-by: Cristian Dumitrescu Signed-off-by: Kamalakannan R --- examples/pipeline/cli.c | 154 1 file changed, 154 insertions(+) diff --git a/examples/pipeline/cli.c b/exampl

[PATCH V5 09/11] examples/pipeline: support blocks other than pipelines

2023-01-26 Thread Cristian Dumitrescu
Previously, the data plane threads only supported the execution of pipelines assigned to them through configuration updates. Now, the data plane threads also support running blocks such as IPsec. Signed-off-by: Cristian Dumitrescu Signed-off-by: Kamalakannan R --- examples/pipeline/thread.c | 1

[PATCH V5 08/11] examples/pipeline: rework the thread configuration updates

2023-01-26 Thread Cristian Dumitrescu
Previously, the configuration updates for the data plane threads were performed through message queues. Now, this mechanism is replaced by the control thread updating the mirror copy of the data plane thread configuration followed by pointer swapping. Signed-off-by: Cristian Dumitrescu Signed-off

[PATCH V5 07/11] examples/pipeline: add IPsec CLI commands

2023-01-26 Thread Cristian Dumitrescu
Add CLI commands for IPsec block configuration. Signed-off-by: Cristian Dumitrescu Signed-off-by: Kamalakannan R --- examples/pipeline/cli.c | 298 1 file changed, 298 insertions(+) diff --git a/examples/pipeline/cli.c b/examples/pipeline/cli.c index 6b

[PATCH V5 06/11] examples/pipeline: add CLI command for crypto device

2023-01-26 Thread Cristian Dumitrescu
Add CLI command for the configuration of crypto devices. Signed-off-by: Cristian Dumitrescu Signed-off-by: Kamalakannan R --- examples/pipeline/cli.c | 63 + 1 file changed, 63 insertions(+) diff --git a/examples/pipeline/cli.c b/examples/pipeline/cli.c

[PATCH V5 05/11] examples/pipeline: support crypto devices

2023-01-26 Thread Cristian Dumitrescu
Add support for crypto devices in the application. Signed-off-by: Cristian Dumitrescu Signed-off-by: Kamalakannan R --- examples/pipeline/obj.c | 62 + examples/pipeline/obj.h | 11 2 files changed, 73 insertions(+) diff --git a/examples/pipelin

[PATCH V5 04/11] examples/pipeline: streamline the Ethernet device support

2023-01-26 Thread Cristian Dumitrescu
Streamline the Ethernet device support code and remove redundant code. Signed-off-by: Cristian Dumitrescu Signed-off-by: Kamalakannan R --- examples/pipeline/cli.c | 175 ++-- examples/pipeline/main.c | 12 +-- examples/pipeline/obj.c | 186 +--

[PATCH V5 03/11] examples/pipeline: streamline ring support

2023-01-26 Thread Cristian Dumitrescu
Remove redundant ring related code. Signed-off-by: Cristian Dumitrescu Signed-off-by: Kamalakannan R --- examples/pipeline/cli.c | 24 ++-- examples/pipeline/obj.c | 63 - examples/pipeline/obj.h | 21 -- 3 files changed, 15 insert

[PATCH V5 01/11] pipeline: add IPsec support

2023-01-26 Thread Cristian Dumitrescu
This block is providing IPsec support to the SWX pipeline. The IPsec block is external to the pipeline, so it needs to be explicitly instantiated and connected to a pipeline through the I/O ports. Signed-off-by: Cristian Dumitrescu Signed-off-by: Kamalakannan R --- lib/pipeline/meson.build

[PATCH V5 02/11] examples/pipeline: rework memory pool support

2023-01-26 Thread Cristian Dumitrescu
Rework the memory pool CLI command to accommodate the MBUF private meta-data area size parameter. Signed-off-by: Cristian Dumitrescu Signed-off-by: Kamalakannan R --- examples/pipeline/cli.c | 72 ++--- examples/pipeline/examples/fib.cli| 2 +- exa

[PATCH V5 00/11] pipeline: add IPsec support

2023-01-26 Thread Cristian Dumitrescu
This patch set introduces a companion block for the SWX pipeline for IPsec support. The IPsec block is external to the pipeline, hence it needs to be explicitly instantiated by the user and connected to a pipeline instance through the pipeline I/O ports. Main features: * IPsec inbound (encrypted

[PATCH v4 8/8] net: mark all big endian types

2023-01-26 Thread Ferruh Yigit
From: Thomas Monjalon Some protocols (ARP, MPLS and HIGIG2) were using uint16_t and uint32_t types for their 16 and 32-bit fields. It was correct but not conveying the big endian nature of these fields. As for other protocols defined in this directory, all types are explicitly marked as big endi

[PATCH v4 7/8] doc: fix description of L2TPV2 flow item

2023-01-26 Thread Ferruh Yigit
From: Thomas Monjalon The flow item structure includes the protocol definition from the directory lib/net/, so it is reflected in the guide. Section title underlining is also fixed around. Fixes: 3a929df1f286 ("ethdev: support L2TPv2 and PPP procotol") Cc: sta...@dpdk.org Signed-off-by: Thomas

[PATCH v4 6/8] ethdev: use ARP protocol struct for flow matching

2023-01-26 Thread Ferruh Yigit
From: Thomas Monjalon As announced in the deprecation notice, flow item structures should re-use the protocol header definitions from the directory lib/net/. The protocol struct is added in an unnamed union, keeping old field names. The ARP header struct members are used in testpmd instead of t

[PATCH v4 5/8] ethdev: use GTP protocol struct for flow matching

2023-01-26 Thread Ferruh Yigit
From: Thomas Monjalon As announced in the deprecation notice, flow item structures should re-use the protocol header definitions from the directory lib/net/. The protocol struct is added in an unnamed union, keeping old field names. The GTP header struct members are used in apps and drivers ins

[PATCH v4 4/8] ethdev: use GRE protocol struct for flow matching

2023-01-26 Thread Ferruh Yigit
From: Thomas Monjalon As announced in the deprecation notice, flow item structures should re-use the protocol header definitions from the directory lib/net/. The protocol struct is added in an unnamed union, keeping old field names. The GRE header struct members are used in apps and drivers ins

[PATCH v4 2/8] net: add smaller fields for VXLAN

2023-01-26 Thread Ferruh Yigit
From: Thomas Monjalon The VXLAN and VXLAN-GPE headers were including reserved fields with other fields in big uint32_t struct members. Some more precise definitions are added as union of the old ones. The new struct members are smaller in size and in names. Signed-off-by: Thomas Monjalon ---

[PATCH v4 3/8] ethdev: use VXLAN protocol struct for flow matching

2023-01-26 Thread Ferruh Yigit
From: Thomas Monjalon As announced in the deprecation notice, flow item structures should re-use the protocol header definitions from the directory lib/net/. In the case of VXLAN-GPE, the protocol struct is added in an unnamed union, keeping old field names. The VXLAN headers (including VXLAN-G

[PATCH v4 1/8] ethdev: use Ethernet protocol struct for flow matching

2023-01-26 Thread Ferruh Yigit
From: Thomas Monjalon As announced in the deprecation notice, flow item structures should re-use the protocol header definitions from the directory lib/net/. The Ethernet headers (including VLAN) structures are used instead of the redundant fields in the flow items. The remaining protocols to cl

[PATCH v4 0/8] start cleanup of rte_flow_item_*

2023-01-26 Thread Ferruh Yigit
There was a plan to have structures from lib/net/ at the beginning of corresponding flow item structures. Unfortunately this plan has not been followed up so far. This series is a step to make the most used items, compliant with the inheritance design explained above. The old API is kept in anonymo

RE: [PATCH V4 00/11] pipeline: add IPsec support

2023-01-26 Thread Dumitrescu, Cristian
> -Original Message- > From: Thomas Monjalon > Sent: Thursday, January 26, 2023 9:17 AM > To: Dumitrescu, Cristian > Cc: dev@dpdk.org > Subject: Re: [PATCH V4 00/11] pipeline: add IPsec support > > 12/01/2023 19:53, Cristian Dumitrescu: > > This patch set introduces a companion block

Re: [PATCH v6 1/4] lib: add generic support for reading PMU events

2023-01-26 Thread Bruce Richardson
On Thu, Jan 26, 2023 at 01:29:36PM +0100, Morten Brørup wrote: > > From: Tomasz Duszynski [mailto:tduszyn...@marvell.com] > > Sent: Thursday, 26 January 2023 10.40 > > > > >From: Morten Brørup > > >Sent: Friday, January 20, 2023 10:47 AM > > > > > >> From: Tomasz Duszynski [mailto:tduszyn...@marv

RE: [PATCH] net/mlx5/hws: fix memory leak on general pool db init

2023-01-26 Thread Matan Azrad
From: Alex Vesker > On elemend db init we allocated the element_manager which was unused > and not freed. > > Fixes: b4dd7bcb0dcbe ("net/mlx5/hws: add pool and buddy") > Signed-off-by: Alex Vesker > Reviewed-by: Erez Shitrit Acked-by: Matan Azrad

RE: [PATCH v6 1/4] lib: add generic support for reading PMU events

2023-01-26 Thread Morten Brørup
> From: Tomasz Duszynski [mailto:tduszyn...@marvell.com] > Sent: Thursday, 26 January 2023 10.40 > > >From: Morten Brørup > >Sent: Friday, January 20, 2023 10:47 AM > > > >> From: Tomasz Duszynski [mailto:tduszyn...@marvell.com] > >> Sent: Friday, 20 January 2023 00.39 > >> > >> Add support for p

RE: [PATCH 2/2] app/testpmd: add disable-flow-flush parameter

2023-01-26 Thread Ori Kam
Hi, > -Original Message- > From: Ferruh Yigit > Sent: Wednesday, 25 January 2023 20:38 > > On 12/15/2022 1:41 AM, Chengwen Feng wrote: > > This patch adds "--disable-flow-flush" parameter, which could used to > > disable port flow flush when stop port. It allows testing keep flow > > rul

Re: [PATCH v4 1/9] eal: annotate spinlock, rwlock and seqlock

2023-01-26 Thread David Marchand
On Thu, Jan 19, 2023 at 10:50 PM Tyler Retzlaff wrote: > > > we briefly touched on abstracting annotations in another thread. it > > > would be favorable if annotations were stashed behind macros that could > > > be expanded for more than just clang/internal/under doxygen to make > > > available o

Re: [PATCH v6 3/5] testpmd: add dump_lcores command

2023-01-26 Thread David Marchand
On Thu, Jan 19, 2023 at 4:08 PM Robin Jarry wrote: > > Add a simple command that calls rte_lcore_dump(). > > Signed-off-by: Robin Jarry > Acked-by: Morten Brørup > Acked-by: Konstantin Ananyev We maintain consistent prefixes for commit titles in git. Historically, testpmd patches titles are pr

Re: [PATCH v6 2/5] eal: allow applications to report their cpu usage

2023-01-26 Thread David Marchand
On Thu, Jan 19, 2023 at 4:08 PM Robin Jarry wrote: > > Allow applications to register a callback that will be invoked in > rte_lcore_dump() and when requesting lcore info in the telemetry API. > > The callback is expected to return the number of TSC cycles that have > passed since application star

  1   2   >