RE: [PATCH v3] app/dma-perf: introduce dma-perf application

Hi Bruce, Replies are inline. Really appreciate your comments. I'll fix it in the next version. Thanks, Cheng > -Original Message- > From: Richardson, Bruce > Sent: Tuesday, January 17, 2023 11:44 PM > To: Jiang, Cheng1 > Cc: tho...@monjalon.net; m...@smartsharesystems.com; dev@dpdk.or

[PATCH v2] event/cnxk: wait for CPT flow control on WQE path

This is to avoid CPT queue overflow and thereby a CPT misc interrupt. Fixes: 1a7da795f64 ("net/cnxk: support Tx security offload on cn9k") Signed-off-by: Rahul Bhansali --- Changes in v2: Updated commit message. drivers/event/cnxk/cn9k_worker.h | 1 + drivers/net/cnxk/cn9k_tx.h | 10 +++

Re: [PATCH RESEND v2 01/11] ethdev: check return result of rte_eth_dev_info_get

On Wed, 2023-01-18 at 09:42 +0100, Thomas Monjalon wrote: > 22/11/2022 16:30, > ok...@kernel.org > : > > > rte_class_eth: eth_mac_cmp: The status of this call to > > rte_eth_dev_info_get > > is not checked, potentially leaving dev_info uninitialized. > > [...] > > >/* Return 0 if devarg

Re: [PATCH RESEND v2 02/11] net/tap: check if name is null

On Wed, 2023-01-18 at 10:57 +, Ferruh Yigit wrote: > I assume this is highlighted by a tool but in practice > > 'rte_vdev_device_name()' should not return NULL, and there are many > > other location this check is missing. That's correct. Warning was found by codeql static analysis tool. When

[PATCH v2 11/11] app/testpmd: adjust cleanup sequence when quitting

If flex item is referenced in async flow either by pattern template or action template, currently testpmd complains "flex item has flow references". Flex items should be flushed after async flow resources cleanup. Signed-off-by: Rongwei Liu Acked-by: Viacheslav Ovsiienko --- app/test-pmd/testpm

[PATCH v2 10/11] doc/mlx5: update mlx5 doc

Add flex item matching and modify field feature into mlx5 documents. Signed-off-by: Rongwei Liu Acked-by: Viacheslav Ovsiienko --- doc/guides/nics/mlx5.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/guides/nics/mlx5.rst b/doc/guides/nics/mlx5.rst index f137f156f9..5

[PATCH v2 09/11] app/testpmd: raw encap with flex item support

Application should retrieve raw_encap buffer from spec->pattern if it is flex item. Signed-off-by: Rongwei Liu Acked-by: Viacheslav Ovsiienko --- app/test-pmd/cmdline_flow.c | 26 +- 1 file changed, 17 insertions(+), 9 deletions(-) diff --git a/app/test-pmd/cmdline_flow

[PATCH v2 04/11] net/mlx5: add IPv6 protocol as flex item input

Support IPv6 protocol as new flex item input link. Signed-off-by: Rongwei Liu Acked-by: Viacheslav Ovsiienko --- drivers/net/mlx5/mlx5_flow_flex.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/drivers/net/mlx5/mlx5_flow_flex.c b/drivers/net/mlx5/mlx5_flow_flex.c inde

[PATCH v2 08/11] net/mlx5: return error for sws modify field

Return unsupported error message when application tries to modify flex item field. Validation of packet modifications actions for SW Steering checked if either source or destination field of MODIFY_FIELD action was a flex item. When DEC_TTL action is used, DEC_TTL action does not have any action c

[PATCH v2 07/11] net/mlx5: add flex item modify field implementation

Add flex item modify field HWS implementation. The minimum modify boundary is one byte. Signed-off-by: Rongwei Liu Acked-by: Viacheslav Ovsiienko --- drivers/common/mlx5/mlx5_prm.h | 1 + drivers/net/mlx5/mlx5_flow.h| 3 + drivers/net/mlx5/mlx5_flow_dv.c | 165 +

[PATCH v2 05/11] net/mlx5: adopt new flex item prm definition

Per newest PRM definition, sample_id stands for 3 parts of information instead of single uint32_t id: sample_id + modify_filed_id + format_select_dw. Also new FW capability bits have been introduces to identify the new capability. Signed-off-by: Rongwei Liu Acked-by: Viacheslav Ovsiienko --- d

[PATCH v2 06/11] net/mlx5/hws: add hws flex item matching support

Support flex item matching in hws and syntax follows sws exactly. Flex item should be created in advance and follow current json mapping logic. Signed-off-by: Rongwei Liu Reviewed-by: Alex Vesker Acked-by: Viacheslav Ovsiienko --- drivers/net/mlx5/hws/mlx5dr_definer.c | 83 ++

[PATCH v2 03/11] net/mlx5: enable hws flex item create

Enable flex item create and destroy with dv_flow_en=2 Signed-off-by: Rongwei Liu Acked-by: Viacheslav Ovsiienko --- drivers/net/mlx5/linux/mlx5_os.c | 27 +++ drivers/net/mlx5/mlx5_flow_hw.c | 2 ++ 2 files changed, 17 insertions(+), 12 deletions(-) diff --git a/drive

[PATCH v2 02/11] app/testpmd: pass flex handle into matching mask

In async flow create API, there is only mask information when creating flow table but flex item handle is required to parse the HW sample information. Pass the flex item handle instead of UINT64/32_MAX to mask. Signed-off-by: Rongwei Liu Acked-by: Ori Kam --- app/test-pmd/cmdline_flow.c | 8 ++

[PATCH v2 01/11] ethdev: add flex item modify field support

Add flex item as modify field destination. Add "struct rte_flow_item_flex_handle *flex_handle" into "struct rte_flow_action_modify_data" as union with existed "level" member. This new member is dedicated for modifying flex item. Add flex item modify field cmdline support. Now user can use testpmd

[PATCH v2 00/11] add flex item support

Support flex item matching and modify field in async flow. Syntax follows sync flow exactly. Rongwei Liu (11): ethdev: add flex item modify field support app/testpmd: pass flex handle into matching mask net/mlx5: enable hws flex item create net/mlx5: add IPv6 protocol as flex item input

[PATCH v2 8/8] doc/mlx5: add IPv6 routing extension matching docs

Update mlx5 related document on IPv6 routing extension header matching. Signed-off-by: Rongwei Liu Acked-by: Ori Kam --- doc/guides/nics/features/default.ini | 1 + doc/guides/nics/features/mlx5.ini| 1 + doc/guides/nics/mlx5.rst | 2 ++ 3 files changed, 4 insertions(+) diff --

[PATCH v2 5/8] app/testpmd: add IPv6 routing extension header in raw encap

Add IPv6 routing extension header support in raw_encap command. 1. No TLV support now. 2. Assume header length equals to the current segment_left. Signed-off-by: Rongwei Liu Acked-by: Ori Kam --- app/test-pmd/cmdline_flow.c | 23 +++ 1 file changed, 23 insertions(+) diff --

[PATCH v2 7/8] net/mlx5: add modify IPv6 protocol implementation

Add HWS modify IPv6 protocol implementation. Signed-off-by: Rongwei Liu Acked-by: Viacheslav Ovsiienko --- drivers/common/mlx5/mlx5_prm.h | 1 + drivers/net/mlx5/mlx5_flow_dv.c | 10 ++ 2 files changed, 11 insertions(+) diff --git a/drivers/common/mlx5/mlx5_prm.h b/drivers/common/mlx

[PATCH v2 6/8] ethdev: add modify IPv6 protocol field

Add IPv6 protocol modify field definition. Add new modify field destination type string: "ipv6_proto". Signed-off-by: Rongwei Liu Acked-by: Ori Kam --- app/test-pmd/cmdline_flow.c | 3 ++- lib/ethdev/rte_flow.h | 1 + 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/app/test

[PATCH v2 4/8] net/mlx5/hws: add IPv6 routing extension matching support

Add mlx5 HWS logic to match IPv6 routing extension header. Once detecting IPv6 matching extension items in pattern template create callback, PMD allocates a flex parser to sample the first dword of srv6 header. Only support next_hdr/segments_left/type for now. Signed-off-by: Rongwei Liu Reviewe

[PATCH v2 3/8] net/mlx5/hws: Definer, add mlx5dr context to definer_conv_data

From: Gregory Etelson New mlx5dr_context member replaces mlx5dr_cmd_query_caps. Capabilities structure is a member of mlx5dr_context. Signed-off-by: Gregory Etelson Signed-off-by: Rongwei Liu Reviewed-by: Alex Vesker Acked-by: Viacheslav Ovsiienko --- drivers/net/mlx5/hws/mlx5dr_definer.c |

[PATCH v2 2/8] net/mlx5: adopt IPv6 routing extension prm definition

Per newest PRM definition, sample_id stands for 3 parts of information instead of single uint32_t id: sample_id + modify_filed_id + format_select_dw. Also new FW capability bits have been introduces to identify the new capability. Signed-off-by: Rongwei Liu Acked-by: Viacheslav Ovsiienko --- d

[PATCH v2 1/8] ethdev: add IPv6 routing extension header definition

Add IPv6 routing extension header definition and no TLV support for now. At rte_flow layer, there are new items defined for matching type/nexthdr/segments_left field. Add command line support for IPv6 routing extension header matching: type/nexthdr/segment_list. Signed-off-by: Rongwei Liu Acked

[PATCH v2 0/8] add IPv6 routing extension support

Support IPv6 routing extension header matching with new rte_flow item. Add encapsulation support for IPv6 routing extension header. v2: remove redundant rte_flow items. include the commit from Gregory to pass the compilation. Gregory Etelson (1): net/mlx5/hws: Definer, add mlx5dr context to

[PATCH v2] net/axgbe: move offloads to Rx/Tx queue setup

For Multiprocess dpdk applications need to retrieve the offload parameter from the Device data directly that is shared between primary and secondary processes rather than accessing from Port private data (pdata) since this is not shared between primary and secondary process . Signed-off-by: Jesna

Re: [PATCH v6 1/5] eal: add thread set name API operating on rte thread

On Wed, Jan 18, 2023 at 03:13:12PM -0800, Stephen Hemminger wrote: > On Wed, 18 Jan 2023 11:54:02 -0800 > Tyler Retzlaff wrote: > > > + if (name != NULL) > > + rte_thread_set_name((rte_thread_t){(uintptr_t)*thread}, name) > > Do we really need so many casts here? Looks like the wrong

Re: [PATCH v6 1/5] eal: add thread set name API operating on rte thread

On Wed, 18 Jan 2023 11:54:02 -0800 Tyler Retzlaff wrote: > + if (name != NULL) > + rte_thread_set_name((rte_thread_t){(uintptr_t)*thread}, name) Do we really need so many casts here? Looks like the wrong type was passed in the first place?

[PATCH v6 5/5] eal: deprecation notice for rte thread setname API

Notify deprecation of rte_thread_setname API, it will be removed as it exposes platform-specific thread details. The functionality it provided is now available via the new rte_lcore_set_name API. Signed-off-by: Tyler Retzlaff Acked-by: David Marchand Series-acked-by: Morten Brørup --- doc/gu

[PATCH v6 2/5] eal: remove thread getname API

Remove the rte_thread_getname API. The API is __rte_experimental and requires no deprecation notice. Fold the platform specific variants into the one place it is used as a special case to retain the functionality for linux only. Adjust the function as follows. * reduce scope where thread_get_nam

[PATCH v6 1/5] eal: add thread set name API operating on rte thread

Add a rte_thread_set_name that sets the name of an rte_thread_t thread. This is a replacement for the rte_thread_setname(pthread_t, ...) which exposes platform-specific details. Signed-off-by: Tyler Retzlaff Series-acked-by: Morten Brørup --- lib/eal/common/eal_common_thread.c | 8 ++- l

[PATCH v6 4/5] drivers: mlx5 use rte thread set name

Use the new internal rte_thread_set_name API instead of the now deprecated rte_thread_setname API. Signed-off-by: Tyler Retzlaff --- drivers/net/mlx5/mlx5_hws_cnt.c | 3 ++- drivers/vdpa/mlx5/mlx5_vdpa_event.c | 3 +-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/ne

[PATCH v6 3/5] eal: set thread name on Windows worker threads

Bring Windows EAL worker thread initialization in line with linux & freebsd by setting the worker thread name using the new platform agnostic rte_thread_set_name API. Signed-off-by: Tyler Retzlaff --- lib/eal/windows/eal.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/lib/eal/window

[PATCH v6 0/5] add rte_thread_set_name API for rte_thread_t

Replace the rte_thread_setname API which operates on pthread_t with rte_thread_set_name that operates on rte_thread_t. We should try to align tracing output from the EAL for all platforms but in this case we are retaining an exception for linux as requested from the community. v6: * clean up co

Re: [PATCH] examples/cmdline: fix build error with gcc 12

On 1/18/2023 4:11 PM, Bruce Richardson wrote: > When building the example without libbsd and using the DPDK-provided > strlcpy function, a compiler warning is emitted by GCC 12 about the copy > of the parsed string into the resulting object. This is because the > source from cmdline library is 128

RE: [EXT] Re: [PATCH 1/5] net: add PDCP header

Hi Thomas, Please see inline. Thanks, Anoob > Subject: [EXT] Re: [PATCH 1/5] net: add PDCP header > > External Email > > -- > 22/12/2022 10:25, Anoob Joseph: > > --- /dev/null > > +++ b/lib/net/rte_pdcp_hdr.h > > @@ -0,0 +1,93

RE: [PATCH v4 1/2] ethdev: add query_update sync and async function calls

Hello Thomas, [] > > Current API allows either query or update indirect flow action. > > If port hardware allows both update and query in a single operation, > > application still has to issue 2 separate hardware requests. > > > > The patch adds `rte_flow_action_handle_query_update` function call

Re: [PATCH v7 4/4] eal: add nonnull and access function attributes

On Wed, 18 Jan 2023 09:31:42 +0100 Morten Brørup wrote: > > > So I decided for this order in the names (treating > > nonnull/access_mode as "country" and param/params as "city"), also > > somewhat looking at the __rte_deprecated and __rte_deprecated_msg(msg) > > macros. > > > > > > I have no

Re: [PATCH v5 2/4] eal: allow applications to report their cpu usage

Konstantin Ananyev, Jan 04, 2023 at 11:53: > Probably we can even print warning or so if some-one tries to overwrite > it once again. I'm not sure that is necessary. If an application wants to reset the callback to NULL at any point in time, I don't see why DPDK should tell them it is a bad thing.

Re: [PATCH 0/5] lib: add pdcp protocol

For such new library, I think we need to vote in techboard to accept it. That's a process we had in recent years to keep the project scope in control. 22/12/2022 10:25, Anoob Joseph: > Add Packet Data Convergence Protocol (PDCP) processing library. > > The library is similar to lib_ipsec which p

RE: [RFC] ethdev: sharing indirect actions between ports

> -Original Message- > From: Thomas Monjalon > Sent: Wednesday, January 18, 2023 6:22 PM > To: Slava Ovsiienko ; Ori Kam > > Cc: dev@dpdk.org; Matan Azrad ; Raslan Darawsheh > ; andrew.rybche...@oktetlabs.ru; > ivan.ma...@oktetlabs.ru; ferruh.yi...@amd.com > Subject: Re: [RFC] ethdev: s

Re: [PATCH 1/5] net: add PDCP header

22/12/2022 10:25, Anoob Joseph: > --- /dev/null > +++ b/lib/net/rte_pdcp_hdr.h > @@ -0,0 +1,93 @@ > +/* SPDX-License-Identifier: BSD-3-Clause > + * Copyright(C) 2022 Marvell. > + */ > + > +#ifndef _RTE_PDCP_HDR_H_ > +#define _RTE_PDCP_HDR_H_ No need of extra underscores before and after. Sorry I

Re: [RFC 2/5] ethdev: introduce the affinity field in Tx queue API

18/01/2023 15:44, Jiawei(Jonny) Wang: > > 21/12/2022 11:29, Jiawei Wang: > > > For the multiple hardware ports connect to a single DPDK port > > > (mhpsdp), the previous patch introduces the new rte flow item to match > > > the port affinity of the received packets. > > > > > > This patch adds the

Re: [RFC 1/5] ethdev: add port affinity match item

18/01/2023 15:41, Jiawei(Jonny) Wang: > Hi, > > > > > 21/12/2022 11:29, Jiawei Wang: > > > + /** > > > + * Matches on the physical port affinity of the received packet. > > > + * > > > + * See struct rte_flow_item_port_affinity. > > > + */ > > > + RTE_FLOW_ITEM_TYPE_PORT_AFFINITY, > > > }; >

RE: [PATCH 2/5] lib: add pdcp protocol

Hi Anoob, Please see inline comments. > Subject: [PATCH 2/5] lib: add pdcp protocol > > Add Packet Data Convergence Protocol (PDCP) processing library. > > The library is similar to lib_ipsec which provides IPsec processing > capabilities in DPDK. > > PDCP would involve roughly the following op

Re: [PATCH] net/gve: add support for basic stats

On 12/19/2022 7:38 PM, Joshua Washington wrote: > Hello, > > As it turns out, this error actually propagates to the "total" stats as > well, which I assume is just calculated by adding TX-packets and > TX-dropped. Here are the full stats from the example that Rushil mentioned: > >   -

Re: [RFC] ethdev: sharing indirect actions between ports

18/01/2023 16:17, Ori Kam: > From: Thomas Monjalon > > 28/12/2022 17:54, Viacheslav Ovsiienko: > > > The RTE Flow API implements the concept of shared objects, > > > known as indirect actions (RTE_FLOW_ACTION_TYPE_INDIRECT). > > > An application can create the indirect action of desired > > > type

Re: [PATCH v7] ethdev: add special flags when creating async transfer table

18/01/2023 08:28, Andrew Rybchenko: > On 11/14/22 14:59, Rongwei Liu wrote: > > In case flow rules match only one kind of traffic in a flow table, > > then optimization can be done via allocation of this table. > > Such optimization is possible only if the application gives a hint > > about its usa

Re: [PATCH v5 1/4] eal: add lcore info in telemetry

Kevin Laatz, Jan 18, 2023 at 17:01: > The additional endpoint(s) (I like Morten's idea of a single additional > endpoint where you can specify the metrics to include via parameters) > shouldn't affect the format of other parts of this patchset, but we > would gain the benefits of the additional

[PATCH] examples/cmdline: fix build error with gcc 12

When building the example without libbsd and using the DPDK-provided strlcpy function, a compiler warning is emitted by GCC 12 about the copy of the parsed string into the resulting object. This is because the source from cmdline library is 128 bytes and the destination buffer is 64-bytes. command

Re: [PATCH v5 1/4] eal: add lcore info in telemetry

On 18/01/2023 14:45, Robin Jarry wrote: Kevin Laatz, Jan 18, 2023 at 10:42: Hi Robin, Thanks for taking the time to work on this. It is a good implementation for debug use-cases. I have 2 suggestions which would improve the usability of the data: 1. Could we make the lcore_id paramater on /eal

[PATCH v4 3/3] ethdev: add standby flags for live migration

Some flags are added to the process state API for live migration in order to change the behavior of the flow rules in a standby process. Signed-off-by: Rongwei Liu --- lib/ethdev/rte_ethdev.h | 21 + 1 file changed, 21 insertions(+) diff --git a/lib/ethdev/rte_ethdev.h b/lib

[PATCH v4 2/3] ethdev: add standby state for live migration

When a DPDK application must be upgraded, the traffic downtime should be shortened as much as possible. During the migration time, the old application may stay alive while the new application is starting and being configured. In order to optimize the switch to the new application, the old applicat

[PATCH v4 0/3] add API for live migration

Introduce a new API to set eth_dev process to different roles: active or standby. This API should be used when switching DPDK application to a different version and it should be simple and easy to use. v4: add more descriptions and one user example. v3: add rollback and device capability. Rongwei

[PATCH v4 1/3] ethdev: add flow rule group description

Add more sentences to describe the group concepts and define group 0 as root group for traffic to search a hit rule. Signed-off-by: Rongwei Liu --- lib/ethdev/rte_flow.h | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/lib/ethdev/rte_flow.h b/lib/ethdev/rte_flow.

Re: [PATCH] net/nfp: add support reading linkspeed from port table

On 12/9/2022 2:43 AM, Chaoyong He wrote: > From: Long Wu > > The NFP PMD driver retrieves the linkspeed by reading the > NFP_NET_CFG_STS_LINK register. This register is not set by all versions > of the firmware. > > Add a second preferred method to read the linkspeed from the port table > instea

Re: Google Virtual NIC (GVE) PMD

On 1/18/2023 1:47 PM, Levend Sayar wrote: > Hi all. > > PMD for Google Virtual NIC says it is capable of IPV4 TX checksum > offloading. > > https://github.com/DPDK/dpdk/blob/main/drivers/net/gve/gve_ethdev.c#L285 > > > Bu

RE: [RFC] ethdev: sharing indirect actions between ports

Hi > -Original Message- > From: Thomas Monjalon > Sent: Wednesday, 18 January 2023 14:07 > > 28/12/2022 17:54, Viacheslav Ovsiienko: > > The RTE Flow API implements the concept of shared objects, > > known as indirect actions (RTE_FLOW_ACTION_TYPE_INDIRECT). > > An application can create

Re: [PATCH] event/cnxk: wait for CPT fc on wqe path

On Fri, Dec 9, 2022 at 7:11 PM Rahul Bhansali wrote: > > Wait for CPT flow control on WQE path. Please add Why? If it is bug add Fixes: Also change the subject as event/cnxk: wait for CPT flow control on WQE path > > Signed-off-by: Rahul Bhansali > --- > drivers/event/cnxk/cn9k_worker.h | 1

Re: [PATCH] eal: replace lcore direct use of pthread in the EAL

On Wed, Jan 18, 2023 at 12:25 PM David Marchand wrote: > > On Thu, Dec 8, 2022 at 10:48 PM Tyler Retzlaff > wrote: > > > > * Replace the use of pthread_t in struct lcore_config with the EAL > > rte_thread_t type. > > > > * Replace the direct use of pthread_create(), pthread_self() > > pthread

Re: [PATCH v5 2/4] eal: remove thread getname API

On Tue, Jan 17, 2023 at 7:22 PM Tyler Retzlaff wrote: > > Remove the rte_thread_getname API. The API is __rte_experimental and > requires no deprecation notice. > > Fold the platform specific variants into the one place it is used as a > special case to retain the functionality for linux only. >

Re: [PATCH v5 1/4] eal: add thread set name API operating on rte thread

On Tue, Jan 17, 2023 at 7:21 PM Tyler Retzlaff wrote: > > Add a rte_thread_set_name that sets the name of an rte_thread_t thread. > This is a replacement for the rte_thread_setname(pthread_t, ...) which > exposes platform-specific details. > > Signed-off-by: Tyler Retzlaff > --- > > Series-acked-

Re: [PATCH v5 1/4] eal: add lcore info in telemetry

Kevin Laatz, Jan 18, 2023 at 10:42: > Hi Robin, > > Thanks for taking the time to work on this. It is a good implementation > for debug use-cases. > > I have 2 suggestions which would improve the usability of the data: > 1. Could we make the lcore_id paramater on /eal/lcore/info optional? > This

RE: [RFC 2/5] ethdev: introduce the affinity field in Tx queue API

Hi, > > 21/12/2022 11:29, Jiawei Wang: > > For the multiple hardware ports connect to a single DPDK port > > (mhpsdp), the previous patch introduces the new rte flow item to match > > the port affinity of the received packets. > > > > This patch adds the tx_affinity setting in Tx queue API, the

RE: [RFC 1/5] ethdev: add port affinity match item

Hi, > > 21/12/2022 11:29, Jiawei Wang: > > + /** > > +* Matches on the physical port affinity of the received packet. > > +* > > +* See struct rte_flow_item_port_affinity. > > +*/ > > + RTE_FLOW_ITEM_TYPE_PORT_AFFINITY, > > }; > > I'm not sure about the word "affinity". > I

Re: [PATCH v4] devtools: parallelize ABI check

On Wed, Jan 11, 2023 at 8:53 PM Thomas Monjalon wrote: > > Generation and comparison of ABI dumps are done on multiple cores > thanks to xargs -P0. > It can accelerate this long step by 5 in my tests. > > xargs reports a global error if one of the process has an error. > > Running a shell function

RE: [PATCH v2] crypto/qat: fix build

Acked-by: Kai Ji > -Original Message- > From: De Lara Guarch, Pablo > Sent: Wednesday, January 18, 2023 11:06 AM > To: gak...@marvell.com > Cc: dev@dpdk.org; De Lara Guarch, Pablo ; > sta...@dpdk.org; Ji, Kai > Subject: [PATCH v2] crypto/qat: fix build > > When building QAT PMD, the fo

Re: [PATCH V4 0/5] app/testpmd: support mulitple process attach and detach port

11/01/2023 11:46, Ferruh Yigit: > On 1/11/2023 10:27 AM, Ferruh Yigit wrote: > > On 1/11/2023 12:53 AM, lihuisong (C) wrote: > >> 在 2023/1/11 0:51, Ferruh Yigit 写道: > >>> Hi Huisong, > >>> > >>> I haven't checked the patch in detail yet, but I can see it gives some > >>> ABI compatibility warnings,

Re: [PATCH v4 2/2] ethdev: add quota flow action and item

Is this patch related to query/update of indirect flow action? It looks like it should be in a separate series. 18/01/2023 11:31, Gregory Etelson: > Quota action limits traffic according to pre-defined configuration. > Quota reflects overall traffic usage regardless bandwidth. > Quota flow action

[PATCH 1/1] net/cpfl: add port to port feature.

- Implement hairpin queue setup/confige/enable/disable. - Cross-vport hairpin queue implemented via hairpin_bind/unbind API. Test step: 1. Make sure no bug on CP side. 2. Add rule on IMC. - devmem 0x202920C100 64 0x804 - opcode=0x1303 prof_id=0x34 sub_prof_id=0x0 cookie=0xa2b87 key=0x18,\

[PATCH 0/1] add port to port feature for CPFL PMD

This patch add the support of port to port feature. MEV can loopback packets from RX port to TX port (can be the same or different port). This feature is called "port to port". The main principal of operation is that port-to-port packets are looped back through the host/NIC memory, without softw

Re: [PATCH v4 1/2] ethdev: add query_update sync and async function calls

18/01/2023 11:31, Gregory Etelson: > Current API allows either query or update indirect flow action. > If port hardware allows both update and query in a single operation, > application still has to issue 2 separate hardware requests. > > The patch adds `rte_flow_action_handle_query_update` functi

Google Virtual NIC (GVE) PMD

Hi all. PMD for Google Virtual NIC says it is capable of IPV4 TX checksum offloading. https://github.com/DPDK/dpdk/blob/main/drivers/net/gve/gve_ethdev.c#L285 But according to my tests on Google Cloud, it is not doing that ipv4 checksum tx offload. I only managed to send a packet via DPDK if I c

[PATCH 5/5] mlx5dr: Definer, translate RTE quota item

MLX5 PMD implements QUOTA with Meter object. PMD Quota action translation implicitly increments Meter register value after HW assigns it. Meter register values are: HW QUOTA(HW+1) QUOTA state RED01 (01b) BLOCK YELLOW 12 (10b) PASS GREEN 2

[PATCH 4/5] net/mlx5: add indirect QUOTA create/query/modify

Implement HWS functions for indirect QUOTA creation, modification and query. Signed-off-by: Gregory Etelson --- drivers/net/mlx5/meson.build | 1 + drivers/net/mlx5/mlx5.h| 72 +++ drivers/net/mlx5/mlx5_flow.c | 62 +++ drivers/net/mlx5/mlx5_flow.h | 20 +- dri

[PATCH 3/5] common/mlx5: update MTR ASO definitions

Update MTR ASO definitions for QUOTA flow action. Quota flow action requires WQE READ capability and access to token fields. Signed-off-by: Gregory Etelson --- drivers/common/mlx5/mlx5_prm.h | 4 1 file changed, 4 insertions(+) diff --git a/drivers/common/mlx5/mlx5_prm.h b/drivers/common/m

[PATCH 1/5] net/mlx5: update query fields in async job structure

Query fields defined in `mlx5_hw_q_job` target CT type only. The patch updates `mlx5_hw_q_job` for other query types as well. Signed-off-by: Gregory Etelson --- drivers/net/mlx5/mlx5.h | 10 +- drivers/net/mlx5/mlx5_flow_aso.c | 2 +- drivers/net/mlx5/mlx5_flow_hw.c | 6 +++--

[PATCH 2/5] net/mlx5: remove code duplication

Replace duplicated code with dedicated functions Signed-off-by: Gregory Etelson --- drivers/net/mlx5/mlx5.h | 6 +- drivers/net/mlx5/mlx5_flow_hw.c | 182 2 files changed, 95 insertions(+), 93 deletions(-) diff --git a/drivers/net/mlx5/mlx5.h b/drivers

[PATCH 0/5] net/mlx5: add indirect QUOTA create/query/modify

Add indirect quota flow action. Add match on quota flow item. Gregory Etelson (5): net/mlx5: update query fields in async job structure net/mlx5: remove code duplication common/mlx5: update MTR ASO definitions net/mlx5: add indirect QUOTA create/query/modify mlx5dr: Definer, translate RT

Re: [PATCH] event/cnxk: arm early to account for software delays

On Tue, Dec 13, 2022 at 8:41 PM Shijith Thotton wrote: > > Arm a bucket early to account for software delays in timer arm routine. > > Signed-off-by: Shijith Thotton Updated the git commit title as follows and applied to dpdk-next-net-mrvl/for-next-net. Thanks event/cnxk: arm timer early to ac

Re: [PATCH] net/af_xdp: AF_XDP PMD CNI Integration

On Tue, Dec 13, 2022 at 10:47:46AM +, Koikkara Reeny, Shibin wrote: > From: Shibin Koikkara Reeny > > Integrate support for the AF_XDP CNI and device plugin so that the > DPDK AF_XDP PMD can work in an unprivileged container environment. > Part of the AF_XDP PMD initialization process involve

RE: [PATCH v2] net/af_xdp: AF_XDP PMD CNI Integration

> -Original Message- > From: Koikkara Reeny, Shibin > Sent: Wednesday, December 14, 2022 11:41 PM > To: dev@dpdk.org; Burakov, Anatoly ; > Richardson, Bruce > Cc: Loftus, Ciara ; Zhang, Qi Z > ; Koikkara Reeny, Shibin > > Subject: [PATCH v2] net/af_xdp: AF_XDP PMD CNI Integration > >

Re: [RFC] ethdev: sharing indirect actions between ports

28/12/2022 17:54, Viacheslav Ovsiienko: > The RTE Flow API implements the concept of shared objects, > known as indirect actions (RTE_FLOW_ACTION_TYPE_INDIRECT). > An application can create the indirect action of desired > type and configuration with rte_flow_action_handle_create > call and then sp

Re: [PATCH v5 4/4] eal: deprecate rte thread setname API

On Tue, Jan 17, 2023 at 7:21 PM Tyler Retzlaff wrote: > > Notify deprecation of rte_thread_setname API, it is being removed as it > exposes platform-specific thread details. The functionality it provided > is now implicitly provided via the rte_lcore_set_name API if the > underlying platform suppo

Re: [PATCH v4] devtools: parallelize ABI check

On 1/18/2023 10:45 AM, David Marchand wrote: > On Thu, Jan 12, 2023 at 3:15 PM Ferruh Yigit wrote: abidiff $ABIDIFF_OPTIONS $dump $dump2 || { abiret=$? - echo "Error: ABI issue reported for 'abidiff $ABIDIFF_OPTIONS $dump $dump2'" >&2

Re: [RFC 2/5] ethdev: introduce the affinity field in Tx queue API

21/12/2022 11:29, Jiawei Wang: > For the multiple hardware ports connect to a single DPDK port (mhpsdp), > the previous patch introduces the new rte flow item to match the port > affinity of the received packets. > > This patch adds the tx_affinity setting in Tx queue API, the affinity value > ref

RE: [PATCH v5 1/4] eal: add lcore info in telemetry

> From: Kevin Laatz [mailto:kevin.la...@intel.com] > Sent: Wednesday, 18 January 2023 12.03 > > On 18/01/2023 10:21, Morten Brørup wrote: > >> From: Kevin Laatz [mailto:kevin.la...@intel.com] > >> > >> On 16/12/2022 10:21, Robin Jarry wrote: > >>> Report the same information than rte_lcore_dump()

Re: [PATCH] eal: replace lcore direct use of pthread in the EAL

On Thu, Dec 8, 2022 at 10:48 PM Tyler Retzlaff wrote: > > * Replace the use of pthread_t in struct lcore_config with the EAL > rte_thread_t type. > > * Replace the direct use of pthread_create(), pthread_self() > pthread_getaffinity_np() and pthread_setaffinity_np(). > > Minor tweaks to return

RE: [PATCH v1] examples/l3fwd: fix for coverity scan

> This patch fixes (Logically dead code) coverity issue. > This patch also fixes (Uninitialized scalar variable) coverity issue. > > Coverity issue: 381687 > Coverity issue: 381686 > Fixes: 6a094e328598 ("examples/l3fwd: implement FIB lookup method") > > Signed-off-by: Mohammad Iqbal Ahmad Acke

Re: [RFC 1/5] ethdev: add port affinity match item

21/12/2022 11:29, Jiawei Wang: > + /** > + * Matches on the physical port affinity of the received packet. > + * > + * See struct rte_flow_item_port_affinity. > + */ > + RTE_FLOW_ITEM_TYPE_PORT_AFFINITY, > }; I'm not sure about the word "affinity". I think you want to

Re: [PATCH] net/af_xdp: parse numa node id from sysfs

On 12/12/2022 12:48 AM, Frank Du wrote: > Get from /sys/class/net/{if}/device/numa_node. > > Signed-off-by: Frank Du Acked-by: Ferruh Yigit Applied to dpdk-next-net/main, thanks.

[PATCH v2] crypto/qat: fix build

When building QAT PMD, the following issue comes up: intel-ipsec-mb.h:333: error: "AES_BLOCK_SIZE" redefined 333 | #define AES_BLOCK_SIZE IMB_AES_BLOCK_SIZE In file included from drivers/crypto/qat/qat_sym_session.c:8: /usr/include/openssl/aes.h:26: previous definition 26 | # define

Re: [PATCH v5 1/4] eal: add lcore info in telemetry

On 18/01/2023 10:21, Morten Brørup wrote: From: Kevin Laatz [mailto:kevin.la...@intel.com] Sent: Wednesday, 18 January 2023 10.42 To: Robin Jarry; dev@dpdk.org Cc: Tyler Retzlaff; Morten Brørup Subject: Re: [PATCH v5 1/4] eal: add lcore info in telemetry On 16/12/2022 10:21, Robin Jarry wrote:

Re: [PATCH RESEND v2 02/11] net/tap: check if name is null

On 11/22/2022 3:30 PM, ok...@kernel.org wrote: > From: Sinan Kaya > > In rte_pmd_tun_probe result of call to rte_vdev_device_name is > dereferenced here and may be null. > > Signed-off-by: Sinan Kaya > --- > drivers/net/tap/rte_eth_tap.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --g

RE: [PATCH v2 1/6] dma/ioat: fix device stop if no copies done

> The HW DMA devices supported by IOAT driver do not transition to > the "active" state until the first operation is started by the HW. > Therefore, if the user calls "rte_dma_stop()" on a device without > triggering any operations, the sequence of commands to be sent to > the HW is different, as i

RE: [PATCH v2 4/6] test/dmadev: check result for device stop

> The DMA device stop API can return an error value so check that return > value when running dmadev unit tests. > > Signed-off-by: Bruce Richardson Reviewed-by: Conor Walsh

RE: [PATCH v2 3/6] dma/ioat: fix incorrect error reporting on restart

> When the DMA device was stopped and restarted by the driver, the control > register specifying the behaviour on error was not getting correctly > reset. This caused unit tests to fail as explicitly introduced errors > were got getting reported back. > > Fix by moving the setting of the register

RE: [PATCH v2 2/6] dma/ioat: fix incorrectly set indexes after restart

> As part of the process of restarting a dma instance, the IOAT driver > will reset the HW addresses and state values. The read and write > indexes for SW use need to be similarly reset to keep HW and SW in > sync. > > Fixes: 583f046dd404 ("dma/ioat: add start and stop") > Cc: conor.wa...@intel.co

Re: [PATCH v4] devtools: parallelize ABI check

On Thu, Jan 12, 2023 at 3:15 PM Ferruh Yigit wrote: > >> abidiff $ABIDIFF_OPTIONS $dump $dump2 || { > >> abiret=$? > >> - echo "Error: ABI issue reported for 'abidiff > >> $ABIDIFF_OPTIONS $dump $dump2'" >&2 > >> - error=1 > >> - e

Re: [PATCH v5 2/2] app/testpmd: add command to process Rx metadata negotiation

21/12/2022 03:07, Hanumanth Pothula: > Presently, Rx metadata is sent to PMD by default, leading > to a performance drop as processing for the same in Rx path > takes extra cycles. > > Hence, add new testpmd command, > 'enable port nic_to_pmd_rx_metadata' > > This command helps in sending Rx m

  1   2   >