[PATCH v7] doc: add PMD known issue

2022-12-22 Thread Mingjin Ye
Add a known issue: Rx path dynamic routing is not supported for PMD. Fixes: de853a3bb151 ("net/ice: disable DDP package on Windows") Cc: sta...@dpdk.org Signed-off-by: Mingjin Ye --- doc/guides/nics/ice.rst | 23 +++ 1 file changed, 23 insertions(+) diff --git a/doc/guides/

RE: [RFC PATCH 0/7] support vfio platform PMD

2022-12-22 Thread Xia, Chenbo
> -Original Message- > From: Tomasz Duszynski > Sent: Friday, December 23, 2022 7:24 AM > To: dev@dpdk.org > Cc: tho...@monjalon.net; jer...@marvell.com; Tomasz Duszynski > > Subject: [RFC PATCH 0/7] support vfio platform PMD > > This series aims to add support for managing vfio platform

[PATCH 21/21] net/cpfl: add xstats ops

2022-12-22 Thread Mingxia Liu
Add support for these device ops: -idpf_dev_xstats_get -idpf_dev_xstats_get_names -idpf_dev_xstats_reset Signed-off-by: Mingxia Liu --- drivers/net/cpfl/cpfl_ethdev.c | 80 ++ 1 file changed, 80 insertions(+) diff --git a/drivers/net/cpfl/cpfl_ethdev.c b/drivers/

[PATCH 20/21] net/cpfl: support single q scatter RX datapath

2022-12-22 Thread Mingxia Liu
This patch add single q recv scatter rx function. Signed-off-by: Wenjun Wu Signed-off-by: Mingxia Liu --- drivers/net/cpfl/cpfl_ethdev.c | 3 ++- drivers/net/cpfl/cpfl_rxtx.c | 26 -- drivers/net/cpfl/cpfl_rxtx.h | 2 ++ 3 files changed, 28 insertions(+), 3 deletio

[PATCH 19/21] net/cpfl: add RSS set/get ops

2022-12-22 Thread Mingxia Liu
Add support for these device ops: - rss_reta_update - rss_reta_query - rss_hash_update - rss_hash_conf_get Signed-off-by: Mingxia Liu --- drivers/net/cpfl/cpfl_ethdev.c | 303 + 1 file changed, 303 insertions(+) diff --git a/drivers/net/cpfl/cpfl_ethdev.c b/drive

[PATCH 18/21] net/cpfl: add hw statistics

2022-12-22 Thread Mingxia Liu
This patch add hardware packets/bytes statistics. Signed-off-by: Mingxia Liu --- drivers/net/cpfl/cpfl_ethdev.c | 88 ++ 1 file changed, 88 insertions(+) diff --git a/drivers/net/cpfl/cpfl_ethdev.c b/drivers/net/cpfl/cpfl_ethdev.c index 4e5d4e124a..026ac52997 100

[PATCH 17/21] net/cpfl: add AVX512 data path for split queue model

2022-12-22 Thread Mingxia Liu
Add support of AVX512 data path for split queue model. Signed-off-by: Wenjun Wu Signed-off-by: Mingxia Liu --- drivers/net/cpfl/cpfl_rxtx.c| 25 + drivers/net/cpfl/cpfl_rxtx_vec_common.h | 14 +- 2 files changed, 38 insertions(+), 1 deletion(-) d

[PATCH 16/21] net/cpfl: support timestamp offload

2022-12-22 Thread Mingxia Liu
Add support for timestamp offload. Signed-off-by: Mingxia Liu --- doc/guides/nics/features/cpfl.ini | 1 + drivers/net/cpfl/cpfl_ethdev.c| 3 ++- drivers/net/cpfl/cpfl_rxtx.c | 7 +++ 3 files changed, 10 insertions(+), 1 deletion(-) diff --git a/doc/guides/nics/features/cpfl.ini b

[PATCH 15/21] net/cpfl: add AVX512 data path for single queue model

2022-12-22 Thread Mingxia Liu
Add support of AVX512 vector data path for single queue model. Signed-off-by: Wenjun Wu Signed-off-by: Mingxia Liu --- doc/guides/nics/cpfl.rst| 24 +- drivers/net/cpfl/cpfl_ethdev.c | 3 +- drivers/net/cpfl/cpfl_rxtx.c| 85 + driver

[PATCH 14/21] net/cpfl: support Tx offloading

2022-12-22 Thread Mingxia Liu
Add Tx offloading support: - support TSO for single queue model and split queue model. Signed-off-by: Mingxia Liu --- doc/guides/nics/features/cpfl.ini | 1 + drivers/net/cpfl/cpfl_ethdev.c| 8 +++- 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/doc/guides/nics/features/c

[PATCH 13/21] net/cpfl: support Rx offloading

2022-12-22 Thread Mingxia Liu
Add Rx offloading support: - support CHKSUM and RSS offload for split queue model - support CHKSUM offload for single queue model Signed-off-by: Mingxia Liu --- doc/guides/nics/features/cpfl.ini | 2 ++ drivers/net/cpfl/cpfl_ethdev.c| 6 ++ 2 files changed, 8 insertions(+) diff --git

[PATCH 12/21] net/cpfl: support RSS

2022-12-22 Thread Mingxia Liu
Add RSS support. Signed-off-by: Mingxia Liu --- drivers/net/cpfl/cpfl_ethdev.c | 52 ++ drivers/net/cpfl/cpfl_ethdev.h | 15 ++ 2 files changed, 67 insertions(+) diff --git a/drivers/net/cpfl/cpfl_ethdev.c b/drivers/net/cpfl/cpfl_ethdev.c index ccd9783f5c

[PATCH 10/21] net/cpfl: support basic Tx data path

2022-12-22 Thread Mingxia Liu
Add basic Tx support in split queue mode and single queue mode. Signed-off-by: Mingxia Liu --- drivers/net/cpfl/cpfl_ethdev.c | 3 +++ drivers/net/cpfl/cpfl_rxtx.c | 14 ++ drivers/net/cpfl/cpfl_rxtx.h | 1 + 3 files changed, 18 insertions(+) diff --git a/drivers/net/cpfl/cpfl

[PATCH 11/21] net/cpfl: support write back based on ITR expire

2022-12-22 Thread Mingxia Liu
Enable write back on ITR expire, then packets can be received one by Signed-off-by: Mingxia Liu --- drivers/net/cpfl/cpfl_ethdev.c | 38 ++ drivers/net/cpfl/cpfl_ethdev.h | 2 ++ 2 files changed, 40 insertions(+) diff --git a/drivers/net/cpfl/cpfl_ethdev.c b/dri

[PATCH 09/21] net/cpfl: support basic Rx data path

2022-12-22 Thread Mingxia Liu
Add basic Rx support in split queue mode and single queue mode. Signed-off-by: Mingxia Liu --- drivers/net/cpfl/cpfl_ethdev.c | 2 ++ drivers/net/cpfl/cpfl_rxtx.c | 11 +++ drivers/net/cpfl/cpfl_rxtx.h | 1 + 3 files changed, 14 insertions(+) diff --git a/drivers/net/cpfl/cpfl_eth

[PATCH 08/21] net/cpfl: support MTU configuration

2022-12-22 Thread Mingxia Liu
Add dev ops mtu_set. Signed-off-by: Mingxia Liu --- doc/guides/nics/features/cpfl.ini | 1 + drivers/net/cpfl/cpfl_ethdev.c| 13 + 2 files changed, 14 insertions(+) diff --git a/doc/guides/nics/features/cpfl.ini b/doc/guides/nics/features/cpfl.ini index a2d1ca9e15..470ba81579

[PATCH 07/21] net/cpfl: support queue release

2022-12-22 Thread Mingxia Liu
Add support for queue operations: - rx_queue_release - tx_queue_release Signed-off-by: Mingxia Liu --- drivers/net/cpfl/cpfl_ethdev.c | 2 ++ drivers/net/cpfl/cpfl_rxtx.c | 35 ++ drivers/net/cpfl/cpfl_rxtx.h | 2 ++ 3 files changed, 39 insertions(+) diff

[PATCH 06/21] net/cpfl: support queue stop

2022-12-22 Thread Mingxia Liu
Add support for these device ops: - rx_queue_stop - tx_queue_stop Signed-off-by: Mingxia Liu --- drivers/net/cpfl/cpfl_ethdev.c | 9 +++- drivers/net/cpfl/cpfl_rxtx.c | 87 ++ drivers/net/cpfl/cpfl_rxtx.h | 3 ++ 3 files changed, 98 insertions(+), 1 deleti

[PATCH 04/21] net/cpfl: support device start and stop

2022-12-22 Thread Mingxia Liu
Add dev ops dev_start, dev_stop and link_update. Signed-off-by: Mingxia Liu --- drivers/net/cpfl/cpfl_ethdev.c | 45 ++ 1 file changed, 45 insertions(+) diff --git a/drivers/net/cpfl/cpfl_ethdev.c b/drivers/net/cpfl/cpfl_ethdev.c index 6d1992dd6e..4c259f24e8 1006

[PATCH 05/21] net/cpfl: support queue start

2022-12-22 Thread Mingxia Liu
Add support for these device ops: - rx_queue_start - tx_queue_start Signed-off-by: Mingxia Liu --- drivers/net/cpfl/cpfl_ethdev.c | 41 ++ drivers/net/cpfl/cpfl_rxtx.c | 138 + drivers/net/cpfl/cpfl_rxtx.h | 4 + 3 files changed, 183 insertions(+)

[PATCH 03/21] net/cpfl: add Rx queue setup

2022-12-22 Thread Mingxia Liu
Add support for rx_queue_setup ops. Signed-off-by: Mingxia Liu --- drivers/net/cpfl/cpfl_ethdev.c | 11 ++ drivers/net/cpfl/cpfl_rxtx.c | 232 + drivers/net/cpfl/cpfl_rxtx.h | 6 + 3 files changed, 249 insertions(+) diff --git a/drivers/net/cpfl/cpfl_ethde

[PATCH 02/21] net/cpfl: add Tx queue setup

2022-12-22 Thread Mingxia Liu
Add support for tx_queue_setup ops. In the single queue model, the same descriptor queue is used by SW to post buffer descriptors to HW and by HW to post completed descriptors to SW. In the split queue model, "RX buffer queues" are used to pass descriptor buffers from SW to HW while Rx queues are

[PATCH 01/21] net/cpfl: support device initialization

2022-12-22 Thread Mingxia Liu
Support device init and add the following dev ops: - dev_configure - dev_close - dev_infos_get - link_update - cpfl_dev_supported_ptypes_get Signed-off-by: Mingxia Liu --- MAINTAINERS| 9 + doc/guides/nics/cpfl.rst | 66 +++ doc/guides/nics/featu

[PATCH 00/21] add support for cpfl PMD in DPDK

2022-12-22 Thread Mingxia Liu
The patchset introduced the cpfl (Control Plane Function Library) PMD for Intel® IPU E2100’s Configure Physical Function (Device ID: 0x1453) The cpfl PMD inherits all the features from idpf PMD which will follow an ongoing standard data plan function spec https://www.oasis-open.org/committees/tc_h

[RFC PATCH 7/7] raw/vfio_platform: support DMA map/unmap

2022-12-22 Thread Tomasz Duszynski
Add support for DMA map/unmap operations. Signed-off-by: Tomasz Duszynski --- .../raw/vfio_platform/rte_pmd_vfio_platform.h | 40 +++ drivers/raw/vfio_platform/version.map | 2 + drivers/raw/vfio_platform/vfio_platform.c | 67 +++ 3 files changed, 109 inserti

[RFC PATCH 6/7] raw/vfio_platform: support rawdev device info

2022-12-22 Thread Tomasz Duszynski
Add support for querying rawdev device info. Signed-off-by: Tomasz Duszynski --- .../raw/vfio_platform/rte_pmd_vfio_platform.h | 34 ++ drivers/raw/vfio_platform/vfio_platform.c | 45 +++ 2 files changed, 79 insertions(+) diff --git a/drivers/raw/vfio_platform/rt

[RFC PATCH 5/7] raw/vfio_platform: support rawdev configure

2022-12-22 Thread Tomasz Duszynski
Add support for binding device VFIO group to a VFIO container. Signed-off-by: Tomasz Duszynski --- .../raw/vfio_platform/rte_pmd_vfio_platform.h | 6 + drivers/raw/vfio_platform/vfio_platform.c | 147 ++ 2 files changed, 153 insertions(+) diff --git a/drivers/raw/vfio_plat

[RFC PATCH 4/7] raw/vfio_platform: support rawdev close

2022-12-22 Thread Tomasz Duszynski
Add support for closing raw device allocated during platform probe. Signed-off-by: Tomasz Duszynski --- drivers/raw/vfio_platform/vfio_platform.c | 49 +++ 1 file changed, 49 insertions(+) diff --git a/drivers/raw/vfio_platform/vfio_platform.c b/drivers/raw/vfio_platform/vf

[RFC PATCH 3/7] raw/vfio_platform: add platform probe and remove

2022-12-22 Thread Tomasz Duszynski
Add platform bus probe and remove. Signed-off-by: Tomasz Duszynski --- drivers/raw/vfio_platform/vfio_platform.c | 56 +++ drivers/raw/vfio_platform/vfio_platform.h | 35 ++ 2 files changed, 91 insertions(+) create mode 100644 drivers/raw/vfio_platform/vfio_platf

[RFC PATCH 2/7] raw/vfio_platform: add driver skeleton

2022-12-22 Thread Tomasz Duszynski
Add driver skeleton which does not do anything beyond registering driver itself to platform bus and providing means to create and destroy VFIO container. Signed-off-by: Tomasz Duszynski --- doc/guides/rawdevs/index.rst | 1 + doc/guides/rawdevs/vfio_platform.rst | 24 +

[RFC PATCH 1/7] lib: add helper to read strings from sysfs files

2022-12-22 Thread Tomasz Duszynski
Reading strings from sysfs files is a re-occurring pattern hence add helper for doing that. Signed-off-by: Tomasz Duszynski --- app/test/test_eal_fs.c | 108 lib/eal/common/eal_filesystem.h | 6 ++ lib/eal/unix/eal_filesystem.c | 24 --- lib/eal

[RFC PATCH 0/7] support vfio platform PMD

2022-12-22 Thread Tomasz Duszynski
This series aims to add support for managing vfio platform devices from userspace application conveniently i.e without going through the configuration required by vfio and opencoding everything. Instead convenience helpers are provided. vfio platform devices, from the kernel standpoint, are ones t

RE: [PATCH v2] mempool cache: add zero-copy get and put functions

2022-12-22 Thread Morten Brørup
> From: Konstantin Ananyev [mailto:konstantin.anan...@huawei.com] > Sent: Thursday, 22 December 2022 16.57 > > > Zero-copy access to mempool caches is beneficial for PMD performance, > and > > must be provided by the mempool library to fix [Bug 1052] without a > > performance regression. > > LGTM

RE: [PATCH v2] mempool cache: add zero-copy get and put functions

2022-12-22 Thread Konstantin Ananyev
> Zero-copy access to mempool caches is beneficial for PMD performance, and > must be provided by the mempool library to fix [Bug 1052] without a > performance regression. LGTM in general, thank you for working on it. Few comments below. > > [Bug 1052]: https://bugs.dpdk.org/show_bug.cgi?id=10

Re: [PATCH dpdk-kmod] linux/igb_uio: fix build with kernel 5.18

2022-12-22 Thread Luca Boccassi
On Fri, 16 Dec 2022 at 12:57, Ferruh Yigit wrote: > > In Linux kernel v5.18, "pci-dma-compat.h" wrapper file is removed [1]. > > Some APIs in that wrapper file were used by igb_uio kernel module and > kernel module build fails after mentioned commit. > > Fixed build for v5.18 by replacing APIs in

Re: [PATCH kmods] linux/igb_uio: fix build on Linux 5.18+

2022-12-22 Thread Luca Boccassi
On Sun, 18 Dec 2022 at 15:25, Ferruh Yigit wrote: > > On 12/16/2022 5:18 PM, luca.bocca...@gmail.com wrote: > > From: Luca Boccassi > > > > Reported-by: Paolo Pisati > > Signed-off-by: Luca Boccassi > > --- > > Only build-tested. > > > > linux/igb_uio/igb_uio.c | 8 > > 1 file changed

RE: [PATCH v4 1/6] eal: trace: add trace point emit for array

2022-12-22 Thread Ankur Dwivedi
Hi Morten, Thanks for your comments and suggestions. My comments are inline. >-Original Message- >From: Morten Brørup >Sent: Thursday, December 22, 2022 4:03 PM >To: Ankur Dwivedi ; dev@dpdk.org >Cc: tho...@monjalon.net; david.march...@redhat.com; m...@ashroe.eu; >or...@nvidia.com; ferru

RE: [PATCH v2] mempool: micro-optimize put function

2022-12-22 Thread Morten Brørup
> From: Konstantin Ananyev [mailto:konstantin.anan...@huawei.com] > Sent: Thursday, 22 December 2022 14.52 > > Hi Morten, > > > PING mempool maintainers. > > > > If you don't provide ACK or Review to patches, how should Thomas know > that it is ready for merging? > > > > -Morten > > The code cha

RE: [PATCH v2] mempool: micro-optimize put function

2022-12-22 Thread Konstantin Ananyev
Hi Morten, > PING mempool maintainers. > > If you don't provide ACK or Review to patches, how should Thomas know that it > is ready for merging? > > -Morten The code changes itself looks ok to me. Though I don't think it would really bring any noticeable speedup. But yes, it looks a bit nice

RE: [PATCH v5 4/4] testpmd: report lcore usage

2022-12-22 Thread Konstantin Ananyev
> Reuse the --record-core-cycles option to account for busy cycles. One > turn of packet_fwd_t is considered "busy" if there was at least one > received or transmitted packet. > > Add a new busy_cycles field in struct fwd_stream. Update get_end_cycles > to accept an additional argument for the n

RE: [PATCH v5 3/4] testpmd: add dump_lcores command

2022-12-22 Thread Konstantin Ananyev
> > Add a simple command that calls rte_lcore_dump(). > > Signed-off-by: Robin Jarry > Acked-by: Morten Brørup > --- > v4 -> v5: no change > > app/test-pmd/cmdline.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c > index b32dc8bf

RE: [PATCH v5 2/4] eal: allow applications to report their cpu usage

2022-12-22 Thread Konstantin Ananyev
> > Allow applications to register a callback that will be invoked in > rte_lcore_dump() and when requesting lcore info in the telemetry API. > > The callback is expected to return the number of TSC cycles that have > passed since application start and the number of these cycles that were > spe

Re: [PATCH] net/iavf:fix slow memory allocation

2022-12-22 Thread Ferruh Yigit
On 12/22/2022 7:23 AM, You, KaisenX wrote: > > >> -Original Message- >> From: Ferruh Yigit >> Sent: 2022年12月21日 21:49 >> To: You, KaisenX ; dev@dpdk.org; Burakov, >> Anatoly ; David Marchand >> >> Cc: sta...@dpdk.org; Yang, Qiming ; Zhou, YidingX >> ; Wu, Jingjing ; Xing, >> Beilei ; Zh

RE: [PATCH v4 2/6] ethdev: add trace points for ethdev

2022-12-22 Thread Morten Brørup
> From: Ankur Dwivedi [mailto:adwiv...@marvell.com] > Sent: Thursday, 22 December 2022 07.33 > > Adds trace points for ethdev functions. > Moved the rte_ethdev_trace_rx_burst and rte_ethdev_trace_tx_burst to > a new file rte_ethdev_trace_fp_burst.h. This is needed to resolve > cyclic dependency be

RE: [PATCH v4 1/6] eal: trace: add trace point emit for array

2022-12-22 Thread Morten Brørup
> From: Ankur Dwivedi [mailto:adwiv...@marvell.com] > Sent: Thursday, 22 December 2022 07.33 > > Adds a trace point emit function for array. The maximum array > bytes which can be captured is set to 32. This seems very useful. Disclaimer: I am not familiar with the trace library or the CTF file

[PATCH 4/5] app/test: pdcp HFN tests in combined mode

2022-12-22 Thread Anoob Joseph
From: Volodymyr Fialko Add tests to verify HFN/SN behaviour. Signed-off-by: Anoob Joseph Signed-off-by: Kiran Kumar K Signed-off-by: Volodymyr Fialko --- app/test/test_pdcp.c | 390 --- 1 file changed, 363 insertions(+), 27 deletions(-) diff --git a/a

[PATCH 5/5] doc: add PDCP library guide

2022-12-22 Thread Anoob Joseph
Add guide for PDCP library. Signed-off-by: Anoob Joseph Signed-off-by: Kiran Kumar K Signed-off-by: Volodymyr Fialko --- .../img/pdcp_functional_overview.svg | 1 + doc/guides/prog_guide/index.rst | 1 + doc/guides/prog_guide/pdcp_lib.rst| 211 +++

[PATCH 2/5] lib: add pdcp protocol

2022-12-22 Thread Anoob Joseph
Add Packet Data Convergence Protocol (PDCP) processing library. The library is similar to lib_ipsec which provides IPsec processing capabilities in DPDK. PDCP would involve roughly the following options, 1. Transfer of user plane data 2. Transfer of control plane data 3. Header compression 4. Upl

[PATCH 3/5] app/test: add lib pdcp tests

2022-12-22 Thread Anoob Joseph
Add tests to verify lib PDCP operations. Tests leverage existing PDCP test vectors. Signed-off-by: Anoob Joseph Signed-off-by: Kiran Kumar K Signed-off-by: Volodymyr Fialko --- app/test/meson.build | 1 + app/test/test_cryptodev.h | 3 + app/test/test_pdcp.c | 663 +++

[PATCH 0/5] lib: add pdcp protocol

2022-12-22 Thread Anoob Joseph
Add Packet Data Convergence Protocol (PDCP) processing library. The library is similar to lib_ipsec which provides IPsec processing capabilities in DPDK. PDCP would involve roughly the following options, 1. Transfer of user plane data 2. Transfer of control plane data 3. Header compression 4. Upl

[PATCH 1/5] net: add PDCP header

2022-12-22 Thread Anoob Joseph
From: Volodymyr Fialko Added PDCP protocol header to be used for supporting PDCP protocol processing. Signed-off-by: Anoob Joseph Signed-off-by: Kiran Kumar K Signed-off-by: Volodymyr Fialko --- doc/api/doxy-api-index.md | 3 +- lib/net/meson.build | 1 + lib/net/rte_pdcp_hdr.h|

RE: [PATCH v4 1/6] eal: trace: add trace point emit for array

2022-12-22 Thread Sunil Kumar Kori
> -Original Message- > From: Ankur Dwivedi > Sent: Thursday, December 22, 2022 12:03 PM > To: dev@dpdk.org > Cc: tho...@monjalon.net; david.march...@redhat.com; m...@ashroe.eu; > or...@nvidia.com; ferruh.yi...@amd.com; ch...@att.com; > humi...@huawei.com; linvi...@tuxdriver.com; ciara.lof.