RE: [PATCH v2] eal: add nonnull and access function attributes

> From: Morten Brørup [mailto:m...@smartsharesystems.com] > Sent: Saturday, 3 December 2022 15.23 > > Add "nonnull" function attribute to help the compiler detect a NULL > pointer being passed to a function not accepting NULL pointers as an > argument at build time. > > Add "access" function attr

[PATCH] net/ice: support IOVA as PA mode

Claim pmd_supports_disable_iova_as_pa. Remove buf_iova access when RTE_IOVA_AS_PA is not defined. The patch simply replace buf_iova with buf_addr at no IOVA as PA mode. Some SIMD instructions in data path may be over used, further optimization is expected. Signed-off-by: Qi Zhang --- drivers/co

RE: [PATCH v1 4/4] common/ml: add Arm NEON type conversion routines

> -Original Message- > From: Srikanth Yalavarthi > Sent: Friday, December 9, 2022 3:36 AM > To: Srikanth Yalavarthi ; Ruifeng Wang > > Cc: dev@dpdk.org; sshankarn...@marvell.com; jer...@marvell.com; > apra...@marvell.com > Subject: [PATCH v1 4/4] common/ml: add Arm NEON type conversion

[PATCH v2] net: not build PMD AVX library when no IOVA as PA

PMD not announce pmd_supports_disable_iova_as_pa will not be build when RTE_IOVA_AS_PA is not defined, but some AVX library for vector path is not skipped by the build system which cause compile error. The patch modify i40e, iavf, ice's meson file to skip AVX library build when RTE_IOVA_AS_PA is n

[PATCH V3 10/11] test: add test cases for adding hex integer values API

Add test cases for adding hexadecimal u32 and u64 values API. Signed-off-by: Huisong Li Acked-by: Morten Brørup Acked-by: Chengwen Feng --- app/test/test_telemetry_data.c | 164 + 1 file changed, 164 insertions(+) diff --git a/app/test/test_telemetry_data.c b/a

[PATCH V3 11/11] ethdev: display capability values in hexadecimal format

The 'dev_flags', 'rx_offloads', 'tx_offloads' and 'rss_hf' are better displayed in hexadecimal format. Like: -->old display by input /ethdev/info,0 "dev_flags": 3, "rx_offloads": 524288, "tx_offloads": 65536, "ethdev_rss_hf": 9100 --> now display "dev_flags": "0x3",

[PATCH V3 09/11] telemetry: support adding integer value as hexadecimal

Sometimes displaying a integer value as hexadecimal encoded style is more expected for human consumption, such as, offload capability and device flag. This patch introduces some APIs to add 'u32' and 'u64' value as hexadecimal encoded string to array or dictionary. Signed-off-by: Huisong Li Acked

[PATCH V3 08/11] telemetry: refactor mapping betwween value and array type

Currently, use rte_tel_value_type as index of array to find the tel_container_types in rte_tel_data_start_array. It's not good for maintenance. Fixes: ed1bfad7d384 ("telemetry: add functions for returning callback data") Cc: sta...@dpdk.org Signed-off-by: Huisong Li Acked-by: Morten Brørup Acke

[PATCH V3 07/11] mem: possible data truncation and conversion error

The 'u32' and 'u64' data can not assigned to 'int' type variable. The 'u32' data need to use the 'u32' telemetry API to add, and the 'u64' data need to use the 'u64' telemetry API to add. Fixes: e6732d0d6e26 ("mem: add telemetry infos") Cc: sta...@dpdk.org Signed-off-by: Huisong Li Acked-by: Mor

[PATCH V3 02/11] telemetry: add u32 value type

Currently, 32-bit integer value only is signed in telemetry. The u32 data can not be assigned to signed 32-bit integer. However, assigning to u64 is very wasteful, after all, the buffer capacity of each transfer is limited. So it is necessary for 'u32' data to add usigned 32-bit integer type and co

[PATCH V3 05/11] mempool: fix possible data truncation and conversion error

The 'u32' and 'u64' data can not assigned to 'int' type variable. The 'u32' data need to use the 'u32' telemetry API to add, and the 'u64' data need to use the 'u64' telemetry API to add. Fixes: 2f5c4025abb3 ("mempool: add telemetry endpoint") Cc: sta...@dpdk.org Signed-off-by: Huisong Li Acked-

[PATCH V3 03/11] test: add test cases for adding u32 value API

Add test cases for adding u32 value API. Cc: sta...@dpdk.org Signed-off-by: Huisong Li Acked-by: Morten Brørup Acked-by: Chengwen Feng --- app/test/test_telemetry_data.c | 85 +- app/test/test_telemetry_json.c | 23 - 2 files changed, 104 insertions(+),

[PATCH V3 04/11] ethdev: fix possible data truncation and conversion error

The 'u32' and 'u64' data can not assigned to 'int' type variable. The 'u32' data need to use the 'u32' telemetry API to add, and the 'u64' data need to use the 'u64' telemetry API to add. Fixes: 58b43c1ddfd1 ("ethdev: add telemetry endpoint for device info") Cc: sta...@dpdk.org Signed-off-by: Hui

[PATCH V3 00/11] telemetry: add u32 value type and hex integer string API

Some lib telemetry interfaces add the 'u32' and 'u64' data by the rte_tel_data_add_dict/array_int API. This may cause data conversion error or data truncation. The 'u32' data can not be assigned to signed 32-bit integer. However, assigning to u64 is very wasteful, after all, the buffer capacity of

[PATCH V3 01/11] telemetry: move to header to controllable range

The "stdint.h" header is outside '_RTE_TELEMETRY_H_' macro, which cause this header is uncontrollable. So this patch moves this header to inside '_RTE_TELEMETRY_H_'. Fixes: 99a2dd955fba ("lib: remove librte_ prefix from directory names") Cc: sta...@dpdk.org Signed-off-by: Huisong Li Acked-by: Mo

[PATCH V3 06/11] cryptodev: fix possible data conversion error

The 'u32' data can not assigned to 'int' type variable. The 'u32' data need to use the 'u32' telemetry API to add. Fixes: d3d98f5ce9d0 ("cryptodev: support telemetry") Cc: sta...@dpdk.org Signed-off-by: Huisong Li Acked-by: Morten Brørup Acked-by: Chengwen Feng --- lib/cryptodev/rte_cryptodev

[PATCH v2] net: not build PMD AVX library when no IOVA as PA

PMD not announce pmd_supports_disable_iova_as_pa will not be build when RTE_IOVA_AS_PA is not defined, but some AVX library for vector path is not skipped by the build system which cause compile error. The patch modify i40e, iavf, ice's meson file to skip AVX library build when RTE_IOVA_AS_PA is n

Re: [PATCH V2 00/11] telemetry: add u32 value type and hex integer string API

在 2022/12/10 2:24, Morten Brørup 写道: From: Huisong Li [mailto:lihuis...@huawei.com] Sent: Friday, 9 December 2022 12.05 Some lib telemetry interfaces add the 'u32' and 'u64' data by the rte_tel_data_add_dict/array_int API. This may cause data conversion error or data truncation. The 'u32' dat

DPDK RX Ring number dump

Hello All, We have an application where we need to dump the received packet rx ring number from the queue. Can anyone share the DPDK api to dump the rx ringnumber for the packet which we received (debug and troubleshoot)? Thanks, Kamaraj

[dpdk-dev] [PATCH v2] common/cnxk: fix dual VLAN parsing issue

From: Satheesh Paul Flow parsing was not handling pattern matching on the fields of inner VLAN even though MKEX profile could be extracting inner VLAN fields. Code has been modified to handle matching fields on two VLAN tags. Fixes: c34ea71b878 ("common/cnxk: add NPC parsing API") Cc: sta...@dpd

[PATCH] net: not compile PMD AVX library when no IOVA as PA

PMD not announce pmd_supports_disable_iova_as_pa will not be build when RTE_IOVA_AS_PA is not defined, but some AVX library for vector path is not skipped by the build system which cause compile error. The patch modify i40e, iavf, ice's meson file to skip AVX library build when RTE_IOVA_AS_PA is n

[PATCH] net/af_xdp: parse numa node id from sysfs

Get from /sys/class/net/{if}/device/numa_node. Signed-off-by: Frank Du --- drivers/net/af_xdp/rte_eth_af_xdp.c | 17 ++--- 1 file changed, 14 insertions(+), 3 deletions(-) diff --git a/drivers/net/af_xdp/rte_eth_af_xdp.c b/drivers/net/af_xdp/rte_eth_af_xdp.c index b6ec9bf490..38b9d

RE: [PATCH 0/3] support no IOVA as PA mode for some Intel NIC

> -Original Message- > From: Zhang, Qi Z > Sent: Monday, December 12, 2022 5:53 AM > To: m...@smartsharesystems.com; Richardson, Bruce > ; Lu, Wenzhuo > Cc: dev@dpdk.org; Wu, Wenjun1 ; Zhang, Qi Z > > Subject: [PATCH 0/3] support no IOVA as PA mode for some Intel NIC > > > Qi Zhang (

RE: 20.11.7 patches review and test

> -Original Message- > From: luca.bocca...@gmail.com > Sent: Monday, November 28, 2022 12:53 PM > To: sta...@dpdk.org > Cc: dev@dpdk.org; Abhishek Marathe ; > Ali Alnubani ; benjamin.wal...@intel.com; David > Christensen ; Hemant Agrawal > ; Ian Stokes ; Jerin > Jacob ; John McNamara ; > J

RE: 19.11.14 patches review and test

> -Original Message- > From: christian.ehrha...@canonical.com > > Sent: Monday, November 28, 2022 3:17 PM > To: sta...@dpdk.org > Cc: dev@dpdk.org; Abhishek Marathe ; > Ali Alnubani ; benjamin.wal...@intel.com; David > Christensen ; Hemant Agrawal > ; Ian Stokes ; Jerin > Jacob ; John McNa

[PATCH 3/3] net/iavf: support no IOVA as PA mode

Remove buf_iova access when RTE_IOVA_AS_PA is not defined. Cc: sta...@dpdk.org Signed-off-by: Qi Zhang --- drivers/net/iavf/iavf_rxtx_vec_avx512.c | 20 ++-- drivers/net/iavf/iavf_rxtx_vec_common.h | 12 2 files changed, 22 insertions(+), 10 deletions(-) diff --git

[PATCH 2/3] net/i40e: support no IOVA as PA mode

Remove buf_iova access when RTE_IOVA_AS_PA is not defined. Cc: sta...@dpdk.org Signed-off-by: Qi Zhang --- drivers/net/i40e/i40e_rxtx_common_avx.h | 12 drivers/net/i40e/i40e_rxtx_vec_avx512.c | 17 +++-- 2 files changed, 23 insertions(+), 6 deletions(-) diff --git a/d

[PATCH 1/3] net/ice: support no IOVA as PA mode

Remove buf_iova access when RTE_IOVA_AS_PA is not defined. Cc: sta...@dpdk.org Signed-off-by: Qi Zhang --- drivers/net/ice/ice_rxtx_common_avx.h | 24 drivers/net/ice/ice_rxtx_vec_avx2.c | 11 +-- drivers/net/ice/ice_rxtx_vec_avx512.c | 17 +++-- 3

[PATCH 0/3] support no IOVA as PA mode for some Intel NIC

Qi Zhang (3): net/ice: support no IOVA as PA mode net/i40e: support no IOVA as PA mode net/iavf: support no IOVA as PA mode drivers/net/i40e/i40e_rxtx_common_avx.h | 12 drivers/net/i40e/i40e_rxtx_vec_avx512.c | 17 +++-- drivers/net/iavf/iavf_rxtx_vec_avx512.c |

Re: [PATCH V2 00/11] telemetry: add u32 value type and hex integer string API

LGTM Series-acked-by: Chengwen Feng On 2022/12/9 19:04, Huisong Li wrote: Some lib telemetry interfaces add the 'u32' and 'u64' data by the rte_tel_data_add_dict/array_int API. This may cause data conversion error or data truncation. The 'u32' data can not be assigned to signed 32-bit integer.