[PATCH v11] mbuf perf test, please ignore

2022-12-06 Thread Morten Brørup
Playing around with the mbuf structure, trying to reduce the use of the second cache line in some common scenarios. v11: * Fix idpf to not fail when RTE_IOVA_AS_PA is 0. v10: * Restore enable_iova_as_pa meson option default. Set RTE_IOVA_AS_PA to 0 in x86 config instead. v9: * Set enable_iova_as

RE: Building DPDK with IOVA_AS_VA

2022-12-06 Thread Wu, Jingjing
Yes, thanks for the suggestion. > -Original Message- > From: Shijith Thotton > Sent: Wednesday, December 7, 2022 3:16 PM > To: Wu, Jingjing ; Xing, Beilei > Cc: dev@dpdk.org; Morten Brørup ; Richardson, > Bruce > > Subject: RE: Building DPDK with IOVA_AS_VA > > Hi Jingjing Wu/Beilei X

RE: Building DPDK with IOVA_AS_VA

2022-12-06 Thread Shijith Thotton
Hi Jingjing Wu/Beilei Xing. >I guess driver may not handle the attribute enable_iova_as_pa well right now. >Maybe you can have a try by disabling idpf driver by adding "- >Ddisable_drivers=net/idpf". > Please send a fix. A check can be added similar to hns3 PMD. +if dpdk_conf.get('RTE_IOVA_AS_P

dev@dpdk.org

2022-12-06 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1142 Bug ID: 1142 Summary: [19.11.14-rc1] kernel/linux/igb_uio make build failed with gcc12 on fedora37&&ubuntu22.10 Product: DPDK Version: 19.11 Hardware: All OS: All

RE: [PATCH v3 4/5] eventdev/crypto: fix overflow in circular buffer

2022-12-06 Thread Gujjar, Abhinandan S
Acked-by: Abhinandan Gujjar > -Original Message- > From: Kundapura, Ganapati > Sent: Wednesday, December 7, 2022 12:20 PM > To: dev@dpdk.org; jer...@marvell.com; Naga Harish K, S V > ; Gujjar, Abhinandan S > > Cc: Jayatheerthan, Jay ; vfia...@marvell.com > Subject: [PATCH v3 4/5] eventd

RE: [PATCH v3 5/5] eventdev/crypto: fix failed events

2022-12-06 Thread Gujjar, Abhinandan S
Acked-by: Abhinandan Gujjar > -Original Message- > From: Kundapura, Ganapati > Sent: Wednesday, December 7, 2022 12:20 PM > To: dev@dpdk.org; jer...@marvell.com; Naga Harish K, S V > ; Gujjar, Abhinandan S > > Cc: Jayatheerthan, Jay ; vfia...@marvell.com > Subject: [PATCH v3 5/5] eventd

RE: [PATCH v3 3/5] eventdev/crypto: fix wrong offset used while flushing events

2022-12-06 Thread Gujjar, Abhinandan S
Acked-by: Abhinandan Gujjar > -Original Message- > From: Kundapura, Ganapati > Sent: Wednesday, December 7, 2022 12:20 PM > To: dev@dpdk.org; jer...@marvell.com; Naga Harish K, S V > ; Gujjar, Abhinandan S > > Cc: Jayatheerthan, Jay ; vfia...@marvell.com > Subject: [PATCH v3 3/5] eventd

RE: [PATCH v3 2/5] eventdev/crypto: fix wrong crypto enqueue count stats

2022-12-06 Thread Gujjar, Abhinandan S
Acked-by: Abhinandan Gujjar > -Original Message- > From: Kundapura, Ganapati > Sent: Wednesday, December 7, 2022 12:20 PM > To: dev@dpdk.org; jer...@marvell.com; Naga Harish K, S V > ; Gujjar, Abhinandan S > > Cc: Jayatheerthan, Jay ; vfia...@marvell.com > Subject: [PATCH v3 2/5] eventd

RE: [PATCH v3 1/5] eventdev/event_crypto: process event port's impl rel cap

2022-12-06 Thread Gujjar, Abhinandan S
Acked-by: Abhinandan Gujjar > -Original Message- > From: Kundapura, Ganapati > Sent: Wednesday, December 7, 2022 12:20 PM > To: dev@dpdk.org; jer...@marvell.com; Naga Harish K, S V > ; Gujjar, Abhinandan S > > Cc: Jayatheerthan, Jay ; vfia...@marvell.com > Subject: [PATCH v3 1/5] eventd

RE: [PATCH v2 4/5] eventdev/crypto: fix overflow in circular buffer

2022-12-06 Thread Kundapura, Ganapati
Hi Abhi, > -Original Message- > From: Gujjar, Abhinandan S > Sent: Tuesday, December 6, 2022 9:56 PM > To: Kundapura, Ganapati ; dev@dpdk.org; > jer...@marvell.com; Naga Harish K, S V > Cc: Jayatheerthan, Jay > Subject: RE: [PATCH v2 4/5] eventdev/crypto: fix overflow in circular buffer

RE: [PATCH v2 1/5] eventdev/event_crypto: process event port's impl rel cap

2022-12-06 Thread Kundapura, Ganapati
Hi Abhi, > -Original Message- > From: Gujjar, Abhinandan S > Sent: Tuesday, December 6, 2022 9:14 PM > To: Kundapura, Ganapati ; dev@dpdk.org; > jer...@marvell.com; Naga Harish K, S V > Cc: Jayatheerthan, Jay > Subject: RE: [PATCH v2 1/5] eventdev/event_crypto: process event port's > im

RE: Building DPDK with IOVA_AS_VA

2022-12-06 Thread Wu, Jingjing
I guess driver may not handle the attribute enable_iova_as_pa well right now. Maybe you can have a try by disabling idpf driver by adding "-Ddisable_drivers=net/idpf". > -Original Message- > From: Morten Brørup > Sent: Wednesday, December 7, 2022 2:55 AM > To: Richardson, Bruce ; Wu, Jin

[PATCH v3 4/5] eventdev/crypto: fix overflow in circular buffer

2022-12-06 Thread Ganapati Kundapura
In case of crypto enqueue failures, even though backpressure flag is set to stop further dequeue from eventdev, the current logic does not stop dequeueing events for max_nb events. This is fixed by checking the backpressure just before dequeuing events from event device. Fixes: 7901eac3409a ("eve

[PATCH v3 5/5] eventdev/crypto: fix failed events

2022-12-06 Thread Ganapati Kundapura
Circular buffer stores events failed to enqueue to eventdev for retrying later. Current implementation adds the same crypto op to circular buffer instead of pointing all the ops in a batch. This fix updates the pointer to pointing to correct ops in the batch. Fixes: 7901eac3409a ("eventdev: add c

[PATCH v3 3/5] eventdev/crypto: fix wrong offset used while flushing events

2022-12-06 Thread Ganapati Kundapura
Events enqueued to eventdev from the beginning of the circular buffer. This leads to invalid or already freed events getting enqueued to eventdev from the circular buffer. Fixed by enqueuing the events to eventdev from the head pointer of circular buffer. Fixes: 7901eac3409a ("eventdev: add crypt

[PATCH v3 2/5] eventdev/crypto: fix wrong crypto enqueue count stats

2022-12-06 Thread Ganapati Kundapura
crypto_enq_count is updated on failure to enqueue ops to cryptodev. Updated crypto_enq_count on successful enqueue of ops to cryptodev. Fixes: 7901eac3409a ("eventdev: add crypto adapter implementation") Signed-off-by: Ganapati Kundapura --- v2: * Updated subject line in commit message diff --

[PATCH v3 1/5] eventdev/event_crypto: process event port's impl rel cap

2022-12-06 Thread Ganapati Kundapura
In the current implementation adapter queries event device's capability for implicit release support. This information is used to decide whether events are enqueued back as NEW or FWD events. This patch updates the adapter to query the port caps for implicit release to decide on events enqueuing

[Bug 1141] [19.11.14-rc1] kernel/linux/kni make build failed with gcc10.3.0 and clang11.0.1 on Opensuse15.4

2022-12-06 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1141 Bug ID: 1141 Summary: [19.11.14-rc1] kernel/linux/kni make build failed with gcc10.3.0 and clang11.0.1 on Opensuse15.4 Product: DPDK Version: 19.11 Hardware: All OS

[Bug 1140] [19.11.14-rc1] app/test-pmd/config meson build failed with clangClang15.0.4 on Fedora37/64

2022-12-06 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1140 Bug ID: 1140 Summary: [19.11.14-rc1] app/test-pmd/config meson build failed with clangClang15.0.4 on Fedora37/64 Product: DPDK Version: 19.11 Hardware: All OS: All

RE: [PATCH v2 2/5] eventdev/crypto: fix wrong crypto enqueue count stats

2022-12-06 Thread Gujjar, Abhinandan S
Acked-by: Abhinandan Gujjar > -Original Message- > From: Kundapura, Ganapati > Sent: Thursday, December 1, 2022 12:17 PM > To: dev@dpdk.org; jer...@marvell.com; Naga Harish K, S V > ; Gujjar, Abhinandan S > > Cc: Jayatheerthan, Jay > Subject: [PATCH v2 2/5] eventdev/crypto: fix wrong c

[PATCH v2] doc: update ice matching list

2022-12-06 Thread Qiming Yang
Add recommended matching list for ice PMD in DPDK 22.11. Signed-off-by: Qiming Yang --- doc/guides/nics/ice.rst | 2 ++ 1 file changed, 2 insertions(+) diff --git a/doc/guides/nics/ice.rst b/doc/guides/nics/ice.rst index ce075e067c..335b558338 100644 --- a/doc/guides/nics/ice.rst +++ b/doc/guid

[PATCH 6/6] net/nfp: add meter action logic

2022-12-06 Thread Chaoyong He
From: Jin Liu Add the rte_flow meter action logic, flow with meter action can offload and work well. Signed-off-by: Jin Liu Signed-off-by: Peng Zhang Reviewed-by: Chaoyong He Reviewed-by: Niklas Söderlund --- doc/guides/nics/features/nfp.ini | 1 + doc/guides/rel_notes/release_23_0

[PATCH 5/6] net/nfp: add meter stats options

2022-12-06 Thread Chaoyong He
From: Jin Liu Add support for meter stats mask feature, it indicate what type meter stats that NFP card support. Add function of update meter stats mask, it will change the stats mask used by the meter to another. Add function of read meter stats, get the meter stats that stored in driver. Sig

[PATCH 4/6] net/nfp: add meter options

2022-12-06 Thread Chaoyong He
From: Jin Liu Add function of meter options, a meter include a profile and a policy. Meter options include add a new meter object and destroy a exist meter object, enable meter object and disable meter object, update profile that been used by meter object to another. Signed-off-by: Jin Liu Sig

[PATCH 3/6] net/nfp: add meter policy options

2022-12-06 Thread Chaoyong He
From: Jin Liu Add support for meter policy options, include add a new policy and delete a exist policy, the meter policy indicate that action to be performed for messages of different colors. Signed-off-by: Jin Liu Signed-off-by: Peng Zhang Reviewed-by: Chaoyong He Reviewed-by: Niklas Söderlu

[PATCH 2/6] net/nfp: add meter profile options

2022-12-06 Thread Chaoyong He
From: Jin Liu Add support for meter options, finish DPDK meter architecture on NFP PMD. Get meter capabilities function, the meter capabilities indicate that what meter options NFP card support. Add support for meter profile functions, include add a new meter profile and delete a exist profile,

[PATCH 0/6] add offload support of meter for NFP cards

2022-12-06 Thread Chaoyong He
This patch series mainly add the offload support of the meter for NFP cards, includes: - Add meter profile - Add meter policy - Add meter stats - Add meter action - Add meter offload support Jin Liu (6): net/nfp: correct flower cmsg include dependencies net/nfp: add meter profile options ne

[PATCH 1/6] net/nfp: correct flower cmsg include dependencies

2022-12-06 Thread Chaoyong He
From: Jin Liu The function prototypes in nfp_flower_cmsg.h depends on struct nfp_app_fw_flower defined in nfp_flow.h, but does not include it. Avoid having to include both headers for all users of the flower cmsg helpers by adding the header dependency to the correct header file. Signed-off-by:

[PATCH 2/2] net/ixgbe: support new device for ixgbe

2022-12-06 Thread Jie Wang
Added IXGBE_DEV_ID_82599_LS support for ixgbe driver. Signed-off-by: Jie Wang --- drivers/net/ixgbe/ixgbe_ethdev.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c index ae9f65b334..3f8da11bd1 100644 --- a/drivers/net/ixgbe/i

[PATCH 1/2] net/ixgbe/base: support new device for ixgbe

2022-12-06 Thread Jie Wang
Added IXGBE_DEV_ID_82599_LS support for ixgbe. Signed-off-by: Jie Wang --- drivers/net/ixgbe/base/ixgbe_82599.c | 3 +++ drivers/net/ixgbe/base/ixgbe_type.h | 2 ++ 2 files changed, 5 insertions(+) diff --git a/drivers/net/ixgbe/base/ixgbe_82599.c b/drivers/net/ixgbe/base/ixgbe_82599.c index

[PATCH 0/2] support new device for ixgbe

2022-12-06 Thread Jie Wang
Added IXGBE_DEV_ID_82599_LS support for ixgbe. Jie Wang (2): net/ixgbe/base: support new device for ixgbe net/ixgbe: support new device for ixgbe drivers/net/ixgbe/base/ixgbe_82599.c | 3 +++ drivers/net/ixgbe/base/ixgbe_type.h | 2 ++ drivers/net/ixgbe/ixgbe_ethdev.c | 1 + 3 files ch

Re: [PATCH 1/3] eal: add rte control thread create API

2022-12-06 Thread Stephen Hemminger
On Tue, 6 Dec 2022 09:35:14 -0800 Tyler Retzlaff wrote: > On Mon, Dec 05, 2022 at 01:11:16PM -0800, Stephen Hemminger wrote: > > On Mon, 5 Dec 2022 12:24:26 -0800 > > Tyler Retzlaff wrote: > > > > > Signed-off-by: Tyler Retzlaff > > > --- > > > lib/eal/common/eal_common_thread.c | 93 > >

[PATCH v2 2/3] test/bbdev: fix build issue with optional build flag

2022-12-06 Thread Nicolas Chautru
Missing implementation for offload test with FFT. Only build when the optional build flag RTE_BBDEV_OFFLOAD_COST is set. Fixes: 0acdb9866756 ("test/bbdev: add FFT operations cases") Signed-off-by: Nicolas Chautru --- app/test-bbdev/test_bbdev_perf.c | 82 1 file

[PATCH v2 3/3] test/bbdev: explicit check for allocation failure

2022-12-06 Thread Nicolas Chautru
Adding check for error on return of the rte_bbdev_*_op_alloc_bulk calls in bbdev-test. Signed-off-by: Nicolas Chautru --- app/test-bbdev/test_bbdev_perf.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/app/test-bbdev/test_bbdev_perf.c b/app/test-bbdev/test_bbdev_per

[PATCH v2 1/3] test/bbdev: fix build issue with optional build flag

2022-12-06 Thread Nicolas Chautru
Incorrect bbdev member name used in test code under RTE_BBDEV_OFFLOAD_COST build flag. Fixes: 4f08028c5e24 ("bbdev: expose queue related warning and status") Signed-off-by: Nicolas Chautru --- app/test-bbdev/test_bbdev_perf.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH v2 0/3] test/bbdev: fix build issues with optional build flag

2022-12-06 Thread Nicolas Chautru
v2: add check in offload test function for error during allocation suggested by Maxime. Fixing compilation errors in bbdev-test application on rc4 when the optional flag RTE_BBDEV_OFFLOAD_COST is set manually. This was raised by Vipin. Nicolas Chautru (3): test/bbdev: fix build issue with optio

RE: Building DPDK with IOVA_AS_VA

2022-12-06 Thread Morten Brørup
+To: Intel idpf maintainers Jingjing Wu, Beilei Xing > From: Morten Brørup [mailto:m...@smartsharesystems.com] > Sent: Tuesday, 6 December 2022 17.58 > > Bruce, > > How do I build with IOVA_AS_VA, to benefit from Shijith Thotton's > patch? (Bonus question: How do I make the CI build this way?) >

Re: Commit broke 32-bit testpmd app

2022-12-06 Thread Sampath Peechu (speechu)
Hi Maxime, Did you get a chance to look into this? Please let me know if you need anything else. Thanks, Sampath From: Sampath Peechu (speechu) Date: Wednesday, November 23, 2022 at 5:15 PM To: Maxime Coquelin , chenbo@intel.com , dev@dpdk.org Cc: Roger Melton (rmelton) Subject: Re: Com

Re: [PATCH 1/3] eal: add rte control thread create API

2022-12-06 Thread Tyler Retzlaff
On Mon, Dec 05, 2022 at 01:11:16PM -0800, Stephen Hemminger wrote: > On Mon, 5 Dec 2022 12:24:26 -0800 > Tyler Retzlaff wrote: > > > Signed-off-by: Tyler Retzlaff > > --- > > lib/eal/common/eal_common_thread.c | 93 > > ++ > > lib/eal/include/rte_thread.h

[PATCH v2 1/3] eal: add rte control thread create API

2022-12-06 Thread Tyler Retzlaff
Add rte_control_thread_create API as a replacement for rte_ctrl_thread_create to allow deprecation of the use of platform specific types in DPDK public API. Signed-off-by: Tyler Retzlaff --- lib/eal/common/eal_common_thread.c | 93 ++ lib/eal/include/rte_threa

[PATCH v2 3/3] eal: deprecate pthread control thread create API

2022-12-06 Thread Tyler Retzlaff
Give notice of rte_ctrl_thread_create deprecation. Signed-off-by: Tyler Retzlaff --- doc/guides/rel_notes/deprecation.rst | 4 1 file changed, 4 insertions(+) diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst index b9b02dc..cb74e08 100644 --- a/doc/g

[PATCH v2 0/3] eal: rte_ctrl_thread_create API replacement

2022-12-06 Thread Tyler Retzlaff
Remove rte_ctrl_thread_create API which exposes pthread_t and provide new rte_control_thread_create API based on EALs rte_thread_t. To limit compatibility regression risk and ease of removal of the existing rte_ctrl_thread_create in the future duplicate most of the existing implementation. The dup

[PATCH v2 2/3] test: add rte control thread create API test

2022-12-06 Thread Tyler Retzlaff
Duplicate the rte_ctrl_thread_create test adapted to use rte_control_thread_create to keep both apis under test until rte_ctrl_thread_create is removed. Signed-off-by: Tyler Retzlaff --- app/test/test_lcores.c | 44 1 file changed, 44 insertions(+) d

Building DPDK with IOVA_AS_VA

2022-12-06 Thread Morten Brørup
Bruce, How do I build with IOVA_AS_VA, to benefit from Shijith Thotton's patch? (Bonus question: How do I make the CI build this way?) When I try this command: meson -Dplatform=generic -Dcheck_includes=true -Denable_iova_as_pa=false work It fails with: drivers/net/idpf/meson.build:36:8: ERROR:

RE: [PATCH v2 5/5] eventdev/crypto: add all failed events to circular buffer

2022-12-06 Thread Gujjar, Abhinandan S
> -Original Message- > From: Kundapura, Ganapati > Sent: Thursday, December 1, 2022 12:17 PM > To: dev@dpdk.org; jer...@marvell.com; Naga Harish K, S V > ; Gujjar, Abhinandan S > > Cc: Jayatheerthan, Jay > Subject: [PATCH v2 5/5] eventdev/crypto: add all failed events to circular > bu

RE: [PATCH v2 4/5] eventdev/crypto: fix overflow in circular buffer

2022-12-06 Thread Gujjar, Abhinandan S
> -Original Message- > From: Kundapura, Ganapati > Sent: Thursday, December 1, 2022 12:17 PM > To: dev@dpdk.org; jer...@marvell.com; Naga Harish K, S V > ; Gujjar, Abhinandan S > > Cc: Jayatheerthan, Jay > Subject: [PATCH v2 4/5] eventdev/crypto: fix overflow in circular buffer > > C

RE: [PATCH v2 3/5] eventdev/crypto: fix wrong offset used while flushing events

2022-12-06 Thread Gujjar, Abhinandan S
Acked-by: Abhinandan Gujjar > -Original Message- > From: Kundapura, Ganapati > Sent: Thursday, December 1, 2022 12:17 PM > To: dev@dpdk.org; jer...@marvell.com; Naga Harish K, S V > ; Gujjar, Abhinandan S > > Cc: Jayatheerthan, Jay > Subject: [PATCH v2 3/5] eventdev/crypto: fix wrong o

RE: [PATCH v2 1/5] eventdev/event_crypto: process event port's impl rel cap

2022-12-06 Thread Gujjar, Abhinandan S
> -Original Message- > From: Kundapura, Ganapati > Sent: Thursday, December 1, 2022 12:17 PM > To: dev@dpdk.org; jer...@marvell.com; Naga Harish K, S V > ; Gujjar, Abhinandan S > > Cc: Jayatheerthan, Jay > Subject: [PATCH v2 1/5] eventdev/event_crypto: process event port's impl rel >

Re: [PATCH] devtools: update Meson setup command

2022-12-06 Thread Tyler Retzlaff
On Tue, Dec 06, 2022 at 11:16:48AM +0100, Thomas Monjalon wrote: > The command "meson build" causes a deprecation warning with meson 0.64: > > WARNING: Running the setup command as `meson [options]` instead of > `meson setup [options]` is ambiguous and deprecated. > > Signed-off-by: Thomas

Re: [PATCH] eal: have unregistered non-EAL threads use dedicated PRNG

2022-12-06 Thread Mattias Rönnblom
On 2022-12-05 11:58, Morten Brørup wrote: >> From: Mattias Rönnblom [mailto:mattias.ronnb...@ericsson.com] >> Sent: Monday, 5 December 2022 11.04 >> >> Prior to this change, unregistered non-EAL threads shared a PRNG >> instance with the main lcore. The main lcore may well be used for fast >> path

[PATCH v2] vhost: exclude VM hugepages from coredumps

2022-12-06 Thread Mike Pattrick
Currently if an application wants to include shared hugepages in coredumps in conjunction with the vhost library, the coredump will be larger than expected and include unneeded virtual machine memory. This patch will mark all vhost huge pages as DONTDUMP, except for some select pages used by DPDK.

[PATCH] vhost: decrease log level for unimplemented request

2022-12-06 Thread Maxime Coquelin
This patch changes VHOST_USER_SET_VRING_ERR "not implemented" log level from INFO to DEBUG. Indeed, it is not required to support this message type, and since version 7.1, QEMU sends this message for every queue. It could confuse the end-user, thinking there is an issue where there are not. Imple

Re: [PATCH v1 2/2] test/bbdev: fix build issue with optional build flag

2022-12-06 Thread Maxime Coquelin
Hi Nicolas, On 12/6/22 01:18, Chautru, Nicolas wrote: Hi Maxime, -Original Message- From: Maxime Coquelin Sent: Thursday, November 24, 2022 12:09 PM To: Chautru, Nicolas ; dev@dpdk.org; tho...@monjalon.net; gak...@marvell.com Cc: Vargas, Hernan ; vipin.vargh...@amd.com; Mcnamara, John

[PATCH v10] mbuf perf test, please ignore

2022-12-06 Thread Morten Brørup
Playing around with the mbuf structure, trying to reduce the use of the second cache line in some common scenarios. v10: * Restore enable_iova_as_pa meson option default. Set RTE_IOVA_AS_PA to 0 in x86 config instead. v9: * Set enable_iova_as_pa meson option to false. v8: * Fix typo in compariso

[PATCH v2] vdpa/ifc: Match ANY subsystem IDs for modern virtio devices

2022-12-06 Thread Abhishek Maheshwari
Fixing the match table for vdpa/ifcvf driver because as per the Virtio device specification, for modern virtio devices, drivers MAY match any PCI Subsystem Vendor ID and any PCI Subsystem Device ID value. Fixes: a60b747d0ad ("vdpa/ifc: support virtio block device") Fixes: 5c806b94785 ("vdpa/ifc: a

[PATCH] vdpa/ifc: Match ANY subsystem IDs for modern virtio devices

2022-12-06 Thread Abhishek Maheshwari
Fixing the match table for vdpa/ifcvf driver because as per the Virtio device specification, drivers MAY match any PCI Subsystem Vendor ID and any PCI Subsystem Device ID value. Fixes: a60b747d0ad ("vdpa/ifc: support virtio block device") Fixes: 5c806b94785 ("vdpa/ifc: add PCI ID for legacy networ

Re: [PATCH v1 19/21] net/virtio-user: forward control messages to shadow queue

2022-12-06 Thread Maxime Coquelin
On 11/30/22 17:54, Stephen Hemminger wrote: On Wed, 30 Nov 2022 16:56:37 +0100 Maxime Coquelin wrote: + if (status != 0 || !dev->scvq) + goto out; + + status = virtio_send_command(&dev->scvq->cq, (struct virtio_pmd_ctrl *)hdr, dlen, nb_dlen); +out: Maybe I am lo

[PATCH v9] mbuf perf test, please ignore

2022-12-06 Thread Morten Brørup
Playing around with the mbuf structure, trying to reduce the use of the second cache line in some common scenarios. v9: * Set enable_iova_as_pa meson option to false. v8: * Fix typo in comparison. v7: * Add some likely/unlikely. * Implement new interpretation of 'nb_segs' in chain split in test_mb

Re: [EXT] Re: [PATCH v4 1/2] drivers: fix symbol exports when map is omitted

2022-12-06 Thread Ferruh Yigit
On 12/6/2022 10:18 AM, David Marchand wrote: > On Tue, Dec 6, 2022 at 11:13 AM Ferruh Yigit wrote: >> On 12/5/2022 3:37 PM, Thomas Monjalon wrote: >>> 05/12/2022 14:47, Akhil Goyal: But adding a tag on same repo is more convenient from developer point of view. However, it is my per

[PATCH 2/2] devtools: configure source repo to use as ABI reference

2022-12-06 Thread Ferruh Yigit
By default 'test-meson-builds.sh' script clones the repository which the script is in, and selects a configured branch ('DPDK_ABI_REF_VERSION') as a reference for ABI check. This patch enables selecting different repository to close for reference using 'DPDK_ABI_REF_SRC' environment variable. It

[PATCH 1/2] devtools: document test meson script config options

2022-12-06 Thread Ferruh Yigit
Document config options of script that can be provided by 'devel.config' config file. Signed-off-by: Ferruh Yigit --- devtools/test-meson-builds.sh | 10 ++ 1 file changed, 10 insertions(+) diff --git a/devtools/test-meson-builds.sh b/devtools/test-meson-builds.sh index 3a308bc9af65..bb

[PATCH v8] mbuf perf test, please ignore

2022-12-06 Thread Morten Brørup
Playing around with the mbuf structure, trying to reduce the use of the second cache line in some common scenarios. v8: * Fix typo in comparison. v7: * Add some likely/unlikely. * Implement new interpretation of 'nb_segs' in chain split in test_mbuf. v6: * Update the rte_kni_mbuf to match the rte_

[PATCH v7] mbuf perf test, please ignore

2022-12-06 Thread Morten Brørup
Playing around with the mbuf structure, trying to reduce the use of the second cache line in some common scenarios. v7: * Add some likely/unlikely. * Implement new interpretation of 'nb_segs' in chain split in test_mbuf. v6: * Update the rte_kni_mbuf to match the rte_mbuf modifications. v5: * Fix

Re: mlx5 rte_eth_dev_info.reta_size value

2022-12-06 Thread Robin Jarry
Robin Jarry, Dec 05, 2022 at 16:57: > Hi Ori, > > While working on a patch for OvS[1], I have tried to reconfigure the > redirection table using the code examples that are layout around in > testpmd and other places. > > [1]: > http://patchwork.ozlabs.org/project/openvswitch/patch/20221021145308.1

RE: [PATCH v7] mem: telemetry support for memseg and element information

2022-12-06 Thread Amit Prakash Shukla
Ping. > -Original Message- > From: Amit Prakash Shukla > Sent: Tuesday, October 25, 2022 6:32 PM > To: Anatoly Burakov > Cc: dev@dpdk.org; Jerin Jacob Kollanukkaran ; > david.march...@redhat.com; bruce.richard...@intel.com; > ciara.po...@intel.com; dmitry.kozl...@gmail.com; Amit Prakash

21.11.3 patches review and test

2022-12-06 Thread Kevin Traynor
Hi all, Here is a list of patches targeted for stable release 21.11.3. The planned date for the final release is 19th December. Please help with testing and validation of your use cases and report any issues/results with reply-all to this mail. For the final release the fixes and reported valida

[PATCH v6] mbuf perf test, please ignore

2022-12-06 Thread Morten Brørup
Playing around with the mbuf structure, trying to reduce the use of the second cache line in some common scenarios. v6: * Update the rte_kni_mbuf to match the rte_mbuf modifications. v5: * Fix rte_pktmbuf_chain() for the case where the head is a single segment. v4: * Use tabs, not spaces. * Fix co

Re: [PATCH] devtools: update Meson setup command

2022-12-06 Thread David Marchand
On Tue, Dec 6, 2022 at 11:17 AM Thomas Monjalon wrote: > > The command "meson build" causes a deprecation warning with meson 0.64: > > WARNING: Running the setup command as `meson [options]` instead of > `meson setup [options]` is ambiguous and deprecated. > > Signed-off-by: Thomas Monjalo

Re: [EXT] Re: [PATCH v4 1/2] drivers: fix symbol exports when map is omitted

2022-12-06 Thread David Marchand
On Tue, Dec 6, 2022 at 11:13 AM Ferruh Yigit wrote: > On 12/5/2022 3:37 PM, Thomas Monjalon wrote: > > 05/12/2022 14:47, Akhil Goyal: > >> But adding a tag on same repo is more convenient from developer point of > >> view. > >> However, it is my personal view, others may differ. > > > > From deve

[PATCH] devtools: update Meson setup command

2022-12-06 Thread Thomas Monjalon
The command "meson build" causes a deprecation warning with meson 0.64: WARNING: Running the setup command as `meson [options]` instead of `meson setup [options]` is ambiguous and deprecated. Signed-off-by: Thomas Monjalon --- .ci/linux-build.sh| 2 +- devtools/test-meson-bu

Re: [EXT] Re: [PATCH v4 1/2] drivers: fix symbol exports when map is omitted

2022-12-06 Thread Ferruh Yigit
On 12/5/2022 3:37 PM, Thomas Monjalon wrote: > 05/12/2022 14:47, Akhil Goyal: >>> On Mon, Dec 5, 2022 at 11:44 AM Akhil Goyal wrote: > Please, maintainers and CI teams, when you enable ABI checks in the > main branch, or in the 22.11 LTS branch, use the dpdk-stable 22.11.1 > tag as a r

Re: [PATCH] net/i40e: fix X722 NIC receives jumbo frame packets

2022-12-06 Thread Kevin Traynor
On 06/12/2022 00:01, Zhang, Qi Z wrote: Hi David: -Original Message- From: David Marchand Sent: Monday, December 5, 2022 7:15 PM To: Kevin Traynor ; Zhang, Qi Z Cc: sta...@dpdk.org; Yuan, DukaiX ; Wang, Jie1X ; dev@dpdk.org; Yang, SteveX ; Yang, Qiming ; Xing, Beilei ; Zhang, Yuying

[PATCH V4 1/5] drivers/bus: restore driver assignment at front of probing

2022-12-06 Thread Huisong Li
The driver assignment was moved back at the end of the device probing because there is no something to use rte_driver during the phase of probing. See commit 391797f04208 ("drivers/bus: move driver assignment to end of probing") However, it is necessary for probing callback to reference rte_driver

[PATCH V4 2/5] ethdev: fix skip valid port in probing callback

2022-12-06 Thread Huisong Li
The event callback in application may use the macro RTE_ETH_FOREACH_DEV to iterate over all enabled ports to do something(like, verifying the port id validity) when receive a probing event. If the ethdev state of a port is RTE_ETH_DEV_UNUSED, this port will be skipped. Currently, this state is set

[PATCH V4 3/5] app/testpmd: check the validity of the port

2022-12-06 Thread Huisong Li
This patch checks the validity of port id for all events in 'eth_event_callback()'. Signed-off-by: Huisong Li Acked-by: Aman Singh --- app/test-pmd/testpmd.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index 134d79a555

[PATCH V4 4/5] app/testpmd: add attach and detach port for multiple process

2022-12-06 Thread Huisong Li
This patch supports attach and detach port in primary and secondary process. Signed-off-by: Huisong Li Signed-off-by: Dongdong Liu --- app/test-pmd/testpmd.c| 38 --- app/test-pmd/testpmd.h| 1 - drivers/net/bonding/bonding_testpmd.c | 1

[PATCH V4 5/5] app/testpmd: stop forwarding in new or destroy event

2022-12-06 Thread Huisong Li
When testpmd receives the new or destroy event, the port related information will be updated. Testpmd must stop packet forwarding before updating the information to avoid some serious problems. Signed-off-by: Huisong Li --- app/test-pmd/testpmd.c | 4 1 file changed, 4 insertions(+) diff -

[PATCH V4 0/5] app/testpmd: support mulitple process attach and detach port

2022-12-06 Thread Huisong Li
This patchset fix some bugs and support attaching and detaching port in primary and secondary. --- -v4: fix a misspelling. -v3: 1) merge patch 1/6 and patch 2/6 into patch 1/5, and add modification for other bus type. 2) add a RTE_ETH_DEV_ALLOCATED state in rte_eth_dev_state to reso

Re: [PATCH] build: fix missing crypto vec limits in version

2022-12-06 Thread Zhang, Fan
On 12/6/2022 9:23 AM, Volodymyr Fialko wrote: Add missing function `rte_event_crypto_adapter_vector_limits_get` to version.map. Fixes: c1749bc5ee10 ("eventdev: introduce event cryptodev vector type") Signed-off-by: Volodymyr Fialko --- lib/eventdev/version.map | 1 + 1 file changed, 1 inser

RE: [PATCH] app/testeventdev: add vector worker to perf test

2022-12-06 Thread Volodymyr Fialko
> -Original Message- > From: Volodymyr Fialko > Sent: Friday, December 2, 2022 11:12 AM > To: dev@dpdk.org; Jerin Jacob Kollanukkaran > Cc: Anoob Joseph ; Akhil Goyal ; > Volodymyr Fialko > > Subject: [PATCH] app/testeventdev: add vector worker to perf test > > Add worker for handlin

[PATCH] build: fix missing crypto vec limits in version

2022-12-06 Thread Volodymyr Fialko
Add missing function `rte_event_crypto_adapter_vector_limits_get` to version.map. Fixes: c1749bc5ee10 ("eventdev: introduce event cryptodev vector type") Signed-off-by: Volodymyr Fialko --- lib/eventdev/version.map | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/eventdev/version.map b/l

[PATCH v5] mbuf perf test, please ignore

2022-12-06 Thread Morten Brørup
Playing around with the mbuf structure, trying to reduce the use of the second cache line in some common scenarios. v5: * Fix rte_pktmbuf_chain() for the case where the head is a single segment. v4: * Use tabs, not spaces. * Fix copy-paste bug in linearize. v3: * Make 'next' depend on 'nb_segs' >

Mysterious CI/IOL failures in Patchwork

2022-12-06 Thread Morten Brørup
Hi Owen, For this patch [1], the three CI/IOL tests have Check "fail" with description "Testing issues". However, when I dig into the reports, e.g. [2], all of the tests are marked either PASS or SKIPPED. Digging deeper [3], the "dpdk_meson_compile" and "dpdk_unit_test" each have a bunch of gre

Re: [PATCH V5] ethdev: fix one address occupies two indexes in MAC addrs

2022-12-06 Thread lihuisong (C)
Hi Andrew and PMD maintainers, Can you have a look? 在 2022/10/20 17:31, Huisong Li 写道: The dev->data->mac_addrs[0] will be changed to a new MAC address when applications modify the default MAC address by .mac_addr_set(). However, if the new default one has been added as a non-default MAC addres