Re: [PATCH V5] ethdev: fix one address occupies two indexes in MAC addrs

Kindly ping. 在 2022/10/20 17:31, Huisong Li 写道: The dev->data->mac_addrs[0] will be changed to a new MAC address when applications modify the default MAC address by .mac_addr_set(). However, if the new default one has been added as a non-default MAC address by .mac_addr_add(), the .mac_addr_set(

Re: [PATCH v2] app/testpmd: fix interactive mode with no ports

Hi Gregory, Thanks for the patch. On 11/9/2022 10:39 PM, Gregory Etelson wrote: Testpmd terminated unconditionally if it failed to start all ports. The patch allows testpmd to get into the command line, if the interactive mode was requested. I tested testpmd in interactive mode with no ports

Re: [PATCH] doc: avoid meson deprecation in setup

On 2022/11/16 上午1:35, Stephen Hemminger wrote: The command "meson build" causes a deprecation warning with meson 0.64.0. WARNING: Running the setup command as `meson [options]` instead of `meson setup [options]`

Re: [RFC PATCH] net/memif: change socket listener owner uid/gid

On Tue, 15 Nov 2022 20:44:41 + Junxiao Shi wrote: > +static int > +memif_set_owner_uid(const char *key __rte_unused, const char *value, void > *extra_args) > +{ > + uid_t *uid = (uid_t *)extra_args; > + *uid = strtoul(value, NULL, 10); > + return 0; > +} > + > +static int > +memi

Re: [PATCH] maintainers: update for gve

This driver is for Google's virtual NIC and the team here at Google is working on DPDK support. We were unaware of this driver until just a few weeks ago. There are many features missing from the driver currently released and our team intends to make sure this driver support all relevant features

Re: Commit broke 32-bit testpmd app

++ dev@dpdk.org From: Maxime Coquelin Date: Tuesday, November 15, 2022 at 3:19 AM To: Sampath Peechu (speechu) , chenbo@intel.com Cc: Roger Melton (rmelton) Subject: Re: Commit broke 32-bit testpmd app Hi Sampath, Please add dev@dpdk.org, the upstream mailing list

RE: [PATCH v1 1/1] baseband/acc: fix check after deref and dead code

Hi David, Given we are already at RC3, let's keep the PMD as is and avoid code churn on top of lack of consensus. It is not worth spending more time on this for 22.11. I have marked the issue accordingly in Coverity, there is no concerning vulnerability just dead code which is minor and accept

[RFC PATCH] net/memif: change socket listener owner uid/gid

This allows a DPDK application running with root privilege to create a memif socket listener with non-root owner uid and gid, which can be connected from client applications running without root privilege. Signed-off-by: Junxiao Shi --- doc/guides/nics/memif.rst | 2 ++ drivers/net/memi

Re: [dpdk-dev v5] doc: support IPsec Multi-buffer lib v1.3

Hi, On 11/15/2022 5:11 PM, Kai Ji wrote: From: Pablo de Lara Updated AESNI MB and AESNI GCM, KASUMI, ZUC, SNOW3G and CHACHA20_POLY1305 PMD documentation guides with information about the latest Intel IPSec Multi-buffer library supported. Signed-off-by: Pablo de Lara Acked-by: Ciara Power Ac

Re: [PATCH] maintainers: update for gve

Done. Thanks Junfeng! On Tue, Nov 15, 2022 at 1:22 AM Guo, Junfeng wrote: > > > > > -Original Message- > > From: Thomas Monjalon > > Sent: Tuesday, November 15, 2022 16:33 > > To: Guo, Junfeng > > Cc: dev@dpdk.org; Zhang, Qi Z ; Wu, Jingjing > > ; ferruh.yi...@xilinx.com; Xing, Beilei

[PATCH v2 2/2] doc: simplify the binding steps

The steps for binding to kernel modules which are generic are now only implicit and pointing towards common documentation. Signed-off-by: Nicolas Chautru --- doc/guides/bbdevs/acc100.rst| 90 +++- doc/guides/bbdevs/acc200.rst| 92 +++- doc/guides/bbdevs/

[PATCH v2 1/2] doc: make the Linux drivers doc more generic

Minor change so that for the documentation to be less NIC centric, as these steps can apply more generally to PCIe devices. Signed-off-by: Nicolas Chautru --- doc/guides/linux_gsg/linux_drivers.rst | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/doc/guides/linux_gsg/lin

[PATCH v2 0/2] doc: simplify PMD steps

v2: Split the doc update into 2 as suggested by Thomas. Documentation update suggested by Thomas to point towards the common kernel modules steps. Nicolas Chautru (2): doc: make the Linux drivers doc more generic doc: simplify the binding steps doc/guides/bbdevs/acc100.rst | 90 +

RE: [PATCH v1 1/1] baseband/acc: fix check after deref and dead code

Hi David, I am not sure why the push back. The minimal and proper fix is that v1. We are not making that check for other dequeue function. It should not have been there in the first place. See previous discussion. Thanks Nic > -Original Message- > From: David Marchand > Sent: Tuesda

Re: [PATCH] doc: avoid meson deprecation in setup

On Tue, Nov 15, 2022 at 09:35:16AM -0800, Stephen Hemminger wrote: > The command "meson build" causes a deprecation warning with meson 0.64.0. > > WARNING: Running the setup command as `meson [options]` instead of `mes

[PATCH] doc: avoid meson deprecation in setup

The command "meson build" causes a deprecation warning with meson 0.64.0. WARNING: Running the setup command as `meson [options]` instead of `meson setup [options]` is ambiguous and deprecated. Therefore fix the exam

release candidate 22.11-rc3

A new DPDK release candidate is ready for testing: https://git.dpdk.org/dpdk/tag/?id=v22.11-rc3 There are 161 new patches in this snapshot. Release notes: https://doc.dpdk.org/guides/rel_notes/release_22_11.html Please test and report issues on bugs.dpdk.org. You may share some r

Re: [PATCH 0/4] remove unnecessary null checks

15/11/2022 17:46, Stephen Hemminger: > On Tue, 15 Nov 2022 15:03:14 +0100 > Thomas Monjalon wrote: > > > 10/11/2022 00:46, Stephen Hemminger: > > > This patch set is from running the null_free coccinelle > > > script on the current main branch. > > > > > > Stephen Hemminger (4): > > > gve: rem

Re: [PATCH] devtools: catch empty symbol maps

14/11/2022 16:10, Ferruh Yigit: > On 11/14/2022 2:31 PM, Bruce Richardson wrote: > > On Mon, Nov 14, 2022 at 03:16:51PM +0100, David Marchand wrote: > >> version.map are now optional for drivers if no symbol is exported. > >> Having no symbol exported from a library does not make sense. > >> > >> C

[dpdk-dev v5] doc: support IPsec Multi-buffer lib v1.3

From: Pablo de Lara Updated AESNI MB and AESNI GCM, KASUMI, ZUC, SNOW3G and CHACHA20_POLY1305 PMD documentation guides with information about the latest Intel IPSec Multi-buffer library supported. Signed-off-by: Pablo de Lara Acked-by: Ciara Power Acked-by: Brian Dooley Signed-off-by: Kai Ji

Re: [PATCH 0/4] remove unnecessary null checks

On Tue, 15 Nov 2022 15:03:14 +0100 Thomas Monjalon wrote: > 10/11/2022 00:46, Stephen Hemminger: > > This patch set is from running the null_free coccinelle > > script on the current main branch. > > > > Stephen Hemminger (4): > > gve: remove unnecessary null checks > > mlx5: remove unnecess

Re: [PATCH] rte_ring: remove leftover comment about watermark

31/05/2022 19:20, Stephen Hemminger: > The watermark support was removed from rte_ring since version > 17.02 but there is leftover in comments. > > Fixes: 77dd3064270c ("ring: remove watermark support") > Cc: bruce.richard...@intel.com > Signed-off-by: Stephen Hemminger Applied, thanks.

Re: [PATCH v1] ring: correct the comment and figure description

08/04/2022 14:40, Haiyue Wang: > The index description isn't right, correct it as the Programmer's guide > said. > > Also correct the guide's figure description about 'Dequeue First Step'. > > Signed-off-by: Haiyue Wang There was no comment, I assume it is OK. Applied, thanks.

RE: [PATCH] mempool: add object usage counts for the telemetry api

+CC mempool maintainers > From: Robin Jarry [mailto:rja...@redhat.com] > Sent: Tuesday, 15 November 2022 16.36 > > rte_mempool_dump() already returns the number of objects available and > in the cache. This information is missing from the telemetry API. Add > it > albeit with less granularity for

Re: [PATCH] doc: fix nic order in index.rst

11/10/2022 23:48, Stephen Hemminger: > The list was not quite in alpha order, and it looked > like it should be. Initially the virtual PMDs were at the end I think. OK to make it simple and sorted. > Signed-off-by: Stephen Hemminger Applied, thanks.

Re: [PATCH v4] doc/eal: add signal safety warning

On Tue, Jul 12, 2022 at 1:05 AM Stephen Hemminger wrote: > > The DPDK is not designed to be used from a signal handler. > Add a notice in the documentation describing this limitation, > similar to Linux signal-safety manual page. > > Bugzilla ID: 1030 > Signed-off-by: Stephen Hemminger > Acked-b

[PATCH] mempool cache: add zero-copy get and put functions

Zero-copy access to mempool caches is beneficial for PMD performance, and must be provided by the mempool library to fix [Bug 1052] without a performance regression. [Bug 1052]: https://bugs.dpdk.org/show_bug.cgi?id=1052 Changes from the RFC: * Removed run-time parameter checks. (Honnappa) Th

Re: [PATCH] drivers: various typos found by Lintian

14/11/2022 15:21, luca.bocca...@gmail.com: > From: Luca Boccassi > > Signed-off-by: Luca Boccassi Applied, thanks.

Re: [PATCH] doc: fix typos 'depreciated' instead of 'deprecated'

19/04/2022 17:44, Ray Kinsella: > > Stephen Coleman writes: > > > From 1871ee6f7b98ef89b7c4893d90b5ea264660c201 Mon Sep 17 00:00:00 2001 > > From: youcai > > Date: Tue, 19 Apr 2022 14:38:36 +0800 > > Subject: [PATCH] doc: fix typos 'depreciated' instead of 'deprecated' > > Cc: Ray Kinsella > >

Re: [PATCH v1 1/1] baseband/acc: fix check after deref and dead code

Hello Nicolas, Hernan, On Thu, Nov 10, 2022 at 10:15 PM Chautru, Nicolas wrote: > > > diff --git a/drivers/baseband/acc/rte_acc100_pmd.c > > > b/drivers/baseband/acc/rte_acc100_pmd.c > > > index 96daef87bc..30a718916d 100644 > > > --- a/drivers/baseband/acc/rte_acc100_pmd.c > > > +++ b/drivers/ba

Re: [PATCH v4] doc: update Linux core isolation guide

31/10/2022 12:57, pbhagavat...@marvell.com: > From: Pavan Nikhilesh > > Update Linux core isolation guide to include isolation from > timers, RCU processing and IRQs. > > Signed-off-by: Pavan Nikhilesh > Acked-by: Jerin Jacob > --- > v4 Changes: > - Give names to Links to make them clickable

Re: [PATCH 1/1] doc: expand description of no-huge and PMD issue

Ping for review 11/07/2022 23:09, Thomas Monjalon: > 13/06/2022 11:31, David Marchand: > > On Thu, Jun 9, 2022 at 3:40 PM Stanislaw Kardach wrote: > > > > > > Add more details to the description of a known issue of PMDs not being > > > usable when --no-huge EAL command line parameter is used. The

[PATCH] mempool: add object usage counts for the telemetry api

rte_mempool_dump() already returns the number of objects available and in the cache. This information is missing from the telemetry API. Add it albeit with less granularity for cached counts (only report the total_cache_count). Signed-off-by: Robin Jarry --- lib/mempool/rte_mempool.c | 13 ++

Re: [PATCH v5] doc: add removal warning for power empty poll API

02/11/2022 13:41, Reshma Pattan: > Add removal warning for experimental empty poll API. > > CC: David Hunt > > Signed-off-by: Reshma Pattan > Acked-by: David Hunt Applied, thanks.

RE: [PATCH v1 1/1] baseband/acc: fix check after deref and dead code

David, Reminder on this one. Ok to apply as is? If not consensus we cannot also mark the Coverity warning as not an issue but please check notes below. Thanks Nic > -Original Message- > From: Chautru, Nicolas > Sent: Thursday, November 10, 2022 1:15 PM > To: David Marchand ; Vargas, Her

[PATCH v1] doc: update QAT device support

Update Asymmetric Crypto Service on QAT devices. Signed-off-by: Brian Dooley --- doc/guides/cryptodevs/qat.rst | 1 - 1 file changed, 1 deletion(-) diff --git a/doc/guides/cryptodevs/qat.rst b/doc/guides/cryptodevs/qat.rst index 2d895e61ac..9a5a4e6203 100644 --- a/doc/guides/cryptodevs/qat.rst

Re: [PATCH v1 1/1] doc: simplify the binding steps

09/11/2022 00:43, Nicolas Chautru: > The steps for binding to kernel modules which are > generic are now only implicit and pointing towards > common documentation. > Minor change to the kernel documentation so that > not to be too NIC centric. Better to split the patch if there are changes coming

Re: [PATCH 0/4] remove unnecessary null checks

10/11/2022 00:46, Stephen Hemminger: > This patch set is from running the null_free coccinelle > script on the current main branch. > > Stephen Hemminger (4): > gve: remove unnecessary null checks > mlx5: remove unnecessary null checks > idpf: remove unnecessary null checks > examples: rem

Re: [PATCH v3 2/2] app/testpmd: support TCP TSO in Tx only mode

On 11/11/2022 9:04 AM, Andrew Rybchenko wrote: @@ -459,11 +486,16 @@ tx_only_begin(portid_t pi) { uint16_t pkt_hdr_len, pkt_data_len; int dynf; - uint8_t ip_proto = IPPROTO_UDP; + uint8_t ip_proto; pkt_hdr_len = (uint16_t)(sizeof(struct rte_ether_hdr) +

Re: [PATCH 1/2] app/testpmd: prepare to support TCP in Tx only mode

On 11/11/2022 8:36 AM, Andrew Rybchenko wrote: On 10/19/22 19:39, Ferruh Yigit wrote: On 10/17/2022 3:41 PM, Andrew Rybchenko wrote: This is useful for the incoming support of TCP TSO in Tx only mode. Signed-off-by: Georgiy Levashov Signed-off-by: Ivan Ilchenko Signed-off-by: Andrew Rybchenk

Re: [External] Re: [PATCH] mempool: fix rte_mempool_avail_count may segment fault when used in multiprocess

Olivier Matz 于2022年11月15日周二 16:29写道： > > Hi, > > On Tue, Nov 15, 2022 at 08:47:15AM +0100, David Marchand wrote: > > On Tue, Nov 15, 2022 at 2:51 AM Fengnan Chang > > wrote: > > > > > > David Marchand 于2022年11月15日周二 04:44写道： > > > > > > > > On Mon, Nov 14, 2022 at 9:13 AM changfengnan > > > >

RE: RSS on L2TP, Teredo, PPPoE Tunnels

Hello Team, A gentle reminder. Regards, From: Tarun Badnora Sent: 10 November 2022 20:18 To: dev@dpdk.org Subject: RSS on L2TP, Teredo, PPPoE Tunnels Hello DPDK Team, Hope you guys are doing great !! We are developing application with dpdk 22.03 & Mellanox Connectx-6 adapter, Want to use IP-

Re: [External] Re: [PATCH] mempool: fix rte_mempool_avail_count may segment fault when used in multiprocess

David Marchand 于2022年11月15日周二 04:44写道： > > On Mon, Nov 14, 2022 at 9:13 AM changfengnan > wrote: > > > > rte_mempool_create put tailq entry into rte_mempool_tailq list before > > populate, and pool_data set when populate. So in multi process, if > > process A create mempool, and process B can ge

Re: [PATCH v10 0/8] app/procinfo: add some extended features

On 2022/11/15 17:52, David Marchand wrote: On Tue, Oct 11, 2022 at 1:20 PM Dongdong Liu wrote: This patchset is to add some extended features for dpdk-proc-info. Thanks to Reshma and Stephen help to review the patchset. v9->v10: - Fix some comments for Rx/Tx descriptor dump. v8->v9: - Fi

Re: [PATCH v10 0/8] app/procinfo: add some extended features

On Tue, Oct 11, 2022 at 1:20 PM Dongdong Liu wrote: > > This patchset is to add some extended features for dpdk-proc-info. > > Thanks to Reshma and Stephen help to review the patchset. > > v9->v10: > - Fix some comments for Rx/Tx descriptor dump. > > v8->v9: > - Fixed some checkpatch warnings. > >

RE: [EXT] [PATCH 1/2] test/crypto-perf: fix number of sessions for cores

> Currently the performance application creates a device session per lcore. > This was not reflected in how many session objects were available > in the mempool, when using a scheduler device. > > The number of lcores is now taken into consideration when calculating > how many sessions are needed

RE: [dpdk-dev v2] app/test: fix of bitwise and operator in return

> > This patch remove incorrect bitwise and operator used in the return function > of > > sw snow3g testcase > > > > Fixes: 24342ade2c9d ("test/crypto: check SNOW3G when digest is encrypted") > > Cc: lukaszx.krakow...@intel.com > > > > Signed-off-by: Kai Ji > > --- > > Acked-by: Ciara Power App

RE: [PATCH] test/crypto: reset device after asym tests

> Subject: [PATCH] test/crypto: reset device after asym tests > > Reset the crypto device after asym tests so that the state from > asymmetric tests won't affect the tests executed later. > > Signed-off-by: Anoob Joseph Acked-by: Akhil Goyal Applied to dpdk-next-crypto Thanks.

RE: [PATCH v4] doc: support IPsec Multi-buffer lib v1.3

> Hi Akhil, > > I remember you have a comment in earlier version of this patch about to > include this ipsec mb v1.3 release doc update into release notes. > I have review the release_22_11.rst, but I'm not sure the best section to > capture > this info , any recommendations ? > It can be added

RE: [PATCH] maintainers: update for gve

> -Original Message- > From: Thomas Monjalon > Sent: Tuesday, November 15, 2022 16:33 > To: Guo, Junfeng > Cc: dev@dpdk.org; Zhang, Qi Z ; Wu, Jingjing > ; ferruh.yi...@xilinx.com; Xing, Beilei > ; dev@dpdk.org; jeroe...@google.com; > jr...@google.com; Zhang, Helin ; Rushil Gupta > ; J

RE: [PATCH v3 2/3] net/mlx5: document E-Switch limitations with HWS in mlx5 PMD

> -Original Message- > From: Dariusz Sosnowski > Sent: Monday, November 14, 2022 20:20 > To: Matan Azrad ; Slava Ovsiienko > Cc: dev@dpdk.org > Subject: [PATCH v3 2/3] net/mlx5: document E-Switch limitations with HWS in > mlx5 PMD > > This patch adds the following limitations to the mlx5

Re: [PATCH] maintainers: update for crypto and compressdev

08/11/2022 17:15, Fan Zhang: > Update email address. > > Signed-off-by: Fan Zhang Applied

Re: [PATCH] maintainers: update for gve

09/11/2022 20:37, Rushil Gupta: > Thanks a lot Junfeng! > > On Tue, Nov 8, 2022 at 11:26 PM Junfeng Guo wrote: > > > Add co-maintainers from Google team for gve (Google Virtual Ethernet). > > > > Signed-off-by: Junfeng Guo > > --- > > Google Virtual Ethernet > > M: Junfeng Guo > > +M: Jeroen

Re: [External] Re: [PATCH] mempool: fix rte_mempool_avail_count may segment fault when used in multiprocess

Hi, On Tue, Nov 15, 2022 at 08:47:15AM +0100, David Marchand wrote: > On Tue, Nov 15, 2022 at 2:51 AM Fengnan Chang > wrote: > > > > David Marchand 于2022年11月15日周二 04:44写道： > > > > > > On Mon, Nov 14, 2022 at 9:13 AM changfengnan > > > wrote: > > > > > > > > rte_mempool_create put tailq entry i

RE: [PATCH] config/arm: make SoC-generic more generic

> -Original Message- > From: fengchengwen > Sent: Tuesday, November 15, 2022 3:55 PM > To: Jerin Jacob ; Richardson, Bruce > ; > Konstantin Ananyev > Cc: tho...@monjalon.net; dev@dpdk.org; Ruifeng Wang > Subject: Re: [PATCH] config/arm: make SoC-generic more generic > > Hi Jerin, > >

Re: [PATCH v2] cleanup compat header inclusions

On Sun, Nov 6, 2022 at 9:36 AM Andrew Rybchenko wrote: > On 11/3/22 17:00, David Marchand wrote: > > With symbols going though experimental/stable stages, we accumulated > > a lot of discrepancies about inclusion of the rte_compat.h header. > > > > Some headers are including it where unneeded, whi

[Bug 759] testpmd: bonding mode 4 on mlx5 doesn't work

https://bugs.dpdk.org/show_bug.cgi?id=759 Thomas Monjalon (tho...@monjalon.net) changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolutio

[Bug 1095] librte_bbdev build failure with clang 3.4.2

https://bugs.dpdk.org/show_bug.cgi?id=1095 Thomas Monjalon (tho...@monjalon.net) changed: What|Removed |Added Resolution|--- |FIXED Status|