RE: [PATCH] app/testpmd: fix incorrect flow arguments name

> -Original Message- > From: Singh, Aman Deep > Sent: Thursday, 6 October 2022 10:59 > > > > On 9/30/2022 5:09 PM, Suanming Mou wrote: > > There should be no spaces in flow command arguments name. > > This commit removes incorrect arguments name in queue based table > > template. > >

RE: [RFC] net: add experimental UDP encapsulation PMD

> From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Tuesday, 11 October 2022 02.10 > > This is a new PMD which can be useful to test a DPDK application > from another test program. The PMD binds to a connected UDP socket > and expects to receive and send raw Ethernet packets over

RE: [PATCH v2 3/3] net/cnxk: support congestion management ops

Please look into these changes and provide feedback. Regards Sunil Kumar Kori > -Original Message- > From: sk...@marvell.com > Sent: Thursday, September 29, 2022 3:25 PM > To: Nithin Kumar Dabilpuram ; Kiran Kumar > Kokkilagadda ; Sunil Kumar Kori > ; Satha Koteswara Rao Kottidi > > Cc:

RE: [PATCH v2 2/3] common/cnxk: add congestion management ROC APIs

Please look into the changes. Regards Sunil Kumar Kori > -Original Message- > From: sk...@marvell.com > Sent: Thursday, September 29, 2022 3:25 PM > To: Nithin Kumar Dabilpuram ; Kiran Kumar > Kokkilagadda ; Sunil Kumar Kori > ; Satha Koteswara Rao Kottidi > ; Ray Kinsella > Cc: dev@dp

Fwd: [PATCH] gro : fix pkt length when extra bytes are padded to ethernet frame

On Tue, Oct 11, 2022 at 1:03 AM David Marchand wrote: > On Mon, Oct 10, 2022 at 7:51 PM Kumara Parameshwaran > wrote: > > > > From: Kumara Parameshwaran > > > > When GRO packets are merged the packet length is used while > > merging the adjacent packets. If the padded bytes are accounted > > we

[PATCH v6] lib/eal: fix segfaults in exiting

The 'eal-intr-thread' is not closed before memory cleanup in the process of exiting. There is a small chance when 'eal-intr-thread' use some pointers, meanwhile the memory was just cleaned, which causes segfaults. This patch closes the 'eal-intr-thread' before memory cleanup in 'rte_eal_cleanup' t

RE: [PATCH v2] sched: Fix subport profile id not set correctly.

> > Hi Megha, > > I noticed several patches from you that all fix small things, can you please > put all > of them into a series as opposed to isolated patches? This is to avoid apply > issues due to dependency order. No need for a cover letter in this case. > > Can you please also pay attentio

Re: GRO Support for IPv6

Thanks Jiyau. I would then like to add support for it. On Tue, Oct 11, 2022 at 6:51 AM Hu, Jiayu wrote: > Hi Kumara, > > > > No plan to support IPv6 in my side. > > > > Thanks, > > Jiayu > > > > *From:* kumaraparameshwaran rathinavel > *Sent:* Tuesday, October 11, 2022 1:08 AM > *To:* dev@dpdk

[PATCH v2 2/2] vhost: fix slot index calculation in async vhost

When the packet receiving failure and the DMA ring full occur simultaneously in the asynchronous vhost, the slot_idx needs to be decreased by 1. For packed virtqueue, the slot index should be ring_size - 1, if the slot_idx is currently 0, since the ring size is not necessarily the power of 2. Fixe

[PATCH v2 1/2] vhost: fix descs count in async vhost packed ring

When vhost receive packets from the front-end using packed virtqueue, it might use multiple descriptors for one packet, so we need calculate and record the descriptor number for each packet to update available descriptor counter and used descriptor counter, and rollback when DMA ring is full. Fixe

[PATCH v2 0/2] vhost: fix some async vhost index calculation issues

Fix some async vhost index calculation issues. v2: fixed fixes tag and replaced some words in commit message. Cheng Jiang (2): vhost: fix descs count in async vhost packed ring vhost: fix slot index calculation in async vhost lib/vhost/virtio_net.c | 40 +

[PATCH] example: vdpa: support run in nested virtualization environment

When we run dpdk vdpa in the nested virtual machine vm-L1 and ping test in vm-L2, the ping is NG. The reason for troubleshooting is that the virtio net in vm-L2 sends control information to the vring, and the qemu back-end device in vm-L1 cannot obtain correct data from the vring. This problem is r

[PATCH v2] vhost: enable CONFIG feature for vdpa

Enable this feature, so that libvirt or qemu can call vdpa vendor driver's ops '.get_config' through 'vhost_net_get_config' to get the mac address of the vdpa hardware without manual configuration. v1->v2: Move VHOST_USER_PROTOCOL_F_CONFIG from VHOST_USER_PROTOCOL_FEATURES to function 'rte_vhost_d

RE: [PATH 2/2] vhost: fix slot index calculation in async vhost

Hi, > -Original Message- > From: Maxime Coquelin > Sent: Monday, October 3, 2022 6:10 PM > To: Jiang, Cheng1 ; Xia, Chenbo > > Cc: dev@dpdk.org; Hu, Jiayu ; Ding, Xuan > ; Ma, WenwuX ; Wang, > YuanX ; Yang, YvonneX > ; He, Xingguang > Subject: Re: [PATH 2/2] vhost: fix slot index calcul

[PATCH v3] pci: read amd iommu virtual address width

Add code to read the virtual address width for AMD processors. Signed-off-by: Michael Piszczek --- drivers/bus/pci/linux/pci.c | 47 +++-- 1 file changed, 30 insertions(+), 17 deletions(-) diff --git a/drivers/bus/pci/linux/pci.c b/drivers/bus/pci/linux/pci.c ind

[PATCH v3] pci: read amd iommu virtual address width

Add code to read the virtual address width for AMD processors. Signed-off-by: Michael Piszczek --- drivers/bus/pci/linux/pci.c | 47 +++-- 1 file changed, 30 insertions(+), 17 deletions(-) diff --git a/drivers/bus/pci/linux/pci.c b/drivers/bus/pci/linux/pci.c ind

[PATCH] net/memif: default to physical socket

This patch changes the default value of the memif abstract socket flag to false. The implementation of memif with abstract sockets made abstract-socket=yes the default in [0] which might confuse users. This patches makes 'socket-abstract=no' the new default, and adds warnings mentionning the natur

[PATCH] net/memif: change link speed to 100G

This patch changes the advertised link speed for the memif driver from 10G to 100G as the memory interfaces can reach higher throughputs than 10G with large packets. Signed-off-by: Nathan Skrzypczak --- drivers/net/memif/rte_eth_memif.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

release candidate 22.11-rc1

A new DPDK release candidate is ready for testing: https://git.dpdk.org/dpdk/tag/?id=v22.11-rc1 There are 737 new patches in this snapshot, including many API/ABI compatibility breakages. This release won't be ABI-compatible with previous ones. Release notes: https://doc.dpdk.org/

Re: [PATCH v3] config/arm: add PHYTIUM tys2500

Thanks，i have modified and submitted 在 2022/10/11 3:58, Thomas Monjalon 写道: 17/09/2022 04:17, luzhipeng: Here adds configs for PHYTIUM server. Signed-off-by: luzhipeng --- v3: 1. fix typos 2. fix signed-off-by format The format is not correct. Please follow what Ferruh said

[PATCH v3] config/arm: add PHYTIUM tys2500

Here adds configs for PHYTIUM server. Signed-off-by: Zhipeng Lu --- v3: * fix typos * fix signed-off-by format v2: * add ccache for cross build * rename fts2500 to tys2500 and modify the corresponding code config/arm/arm64_tys2500_linux_gcc | 16 config/arm/meson.build

RE: GRO Support for IPv6

Hi Kumara, No plan to support IPv6 in my side. Thanks, Jiayu From: kumaraparameshwaran rathinavel Sent: Tuesday, October 11, 2022 1:08 AM To: dev@dpdk.org Cc: Hu, Jiayu ; Thomas Monjalon ; m...@smartsharesystems.com; Ferruh Yigit Subject: GRO Support for IPv6 Hi Everyone, We would require G

[PATCH v1 35/35] net/ionic: add watchdogs to protect each queue type

Ring the doorbell again for the following scenarios: * No receives posted but Rx queue not empty after deadline * No transmits posted but Tx work still pending after deadline * Admin queue work still pending after deadline This will help the queues recover in the extremely rare case that a door

[PATCH v1 34/35] net/ionic: retry init commands up to five times

In some configurations, the FW may return EAGAIN if it is not able to respond to commands immediately. Retry the init commands in this case to prevent errors from reaching the client. Fix up some return-code stuff while here, for clarity. Signed-off-by: Andrew Boyer --- drivers/net/ionic/ionic_

[PATCH v1 33/35] net/ionic: use a helper variable for page size

This improves readability. Signed-off-by: Andrew Boyer --- drivers/net/ionic/ionic_lif.c | 26 -- 1 file changed, 12 insertions(+), 14 deletions(-) diff --git a/drivers/net/ionic/ionic_lif.c b/drivers/net/ionic/ionic_lif.c index affb6a44af..0affdd9dc4 100644 --- a/driver

[PATCH v1 32/35] net/ionic: add optimized handlers for non-scattered Rx/Tx

The code is very similar, but the simple case can skip a few branches in the hot path. This improves PPS when 10KB mbufs are used. S/G is enabled on the Rx side by offload DEV_RX_OFFLOAD_SCATTER. S/G is enabled on the Tx side by offload DEV_TX_OFFLOAD_MULTI_SEGS. S/G is automatically enabled on t

[PATCH v1 31/35] net/ionic: allow client to specify Tx free threshold

Some clients have opinions about how often to flush the transmit ring. The default value is the number of Tx descriptors minus the default Tx burst size. Signed-off-by: Andrew Boyer --- drivers/net/ionic/ionic_dev.h| 1 + drivers/net/ionic/ionic_ethdev.c | 4 ++-- drivers/net/ionic/ionic_

[PATCH v1 30/35] net/ionic: add alignment and socket info in allocations

This will avoid memory access penalties on NUMA systems. Signed-off-by: Andrew Boyer --- drivers/net/ionic/ionic_ethdev.c| 5 +++-- drivers/net/ionic/ionic_lif.c | 13 - drivers/net/ionic/ionic_rx_filter.c | 3 +-- 3 files changed, 12 insertions(+), 9 deletions(-) diff -

[PATCH v1 29/35] net/ionic: update array allocations to use calloc

Use rte_calloc() where appropriate. This makes the code clearer. Signed-off-by: Andrew Boyer --- drivers/net/ionic/ionic_ethdev.c | 6 +++--- drivers/net/ionic/ionic_lif.c| 12 ++-- 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/net/ionic/ionic_ethdev.c b/dri

[PATCH v1 28/35] net/ionic: add Q-in-CMB option controlled by devarg

When 'ionic_cmb' is set to '1', queue memory will be allocated from the device's onboard memory (Controller Memory Buffer). In some configurations, this will dramatically reduce packet latency and increase PPS. Add the WC_ACTIVATE flag to the PCI driver flags. Write combining must be enabled to ac

[PATCH v1 27/35] net/ionic: add Tx descriptor status function

This may be useful for clients. Signed-off-by: Andrew Boyer Signed-off-by: Allen Hubbe --- doc/guides/nics/features/ionic.ini | 1 + drivers/net/ionic/ionic_ethdev.c | 1 + drivers/net/ionic/ionic_rxtx.c | 51 ++ drivers/net/ionic/ionic_rxtx.h | 1 + 4 f

[PATCH v1 26/35] net/ionic: add Rx descriptor status functions

These may be useful for clients. Signed-off-by: Andrew Boyer Signed-off-by: Allen Hubbe --- doc/guides/nics/features/ionic.ini | 1 + doc/guides/rel_notes/release_22_11.rst | 1 + drivers/net/ionic/ionic_ethdev.c | 2 ++ drivers/net/ionic/ionic_rxtx.c | 39 +

[PATCH v1 25/35] net/ionic: advertise supported packet types

This improves performance, since clients may be able to skip SW packet classification. Signed-off-by: Andrew Boyer --- doc/guides/rel_notes/release_22_11.rst | 1 + drivers/net/ionic/ionic_ethdev.c | 1 + drivers/net/ionic/ionic_rxtx.c | 19 +++ drivers/net/ionic/

[PATCH v1 24/35] net/ionic: add a lookup table for checksum flags

This improves performance by reducing branching. Signed-off-by: Andrew Boyer --- drivers/net/ionic/ionic_rxtx.c | 47 -- 1 file changed, 33 insertions(+), 14 deletions(-) diff --git a/drivers/net/ionic/ionic_rxtx.c b/drivers/net/ionic/ionic_rxtx.c index bb09c4eb1

[PATCH v1 22/35] net/ionic: do bulk allocations of receive mbufs

Do bulk allocations to improve performance. Signed-off-by: Andrew Boyer --- drivers/net/ionic/ionic_lif.h | 6 ++ drivers/net/ionic/ionic_rxtx.c | 35 ++ 2 files changed, 33 insertions(+), 8 deletions(-) diff --git a/drivers/net/ionic/ionic_lif.h b/drivers/

[PATCH v1 23/35] net/ionic: add a lookup table for packet type

This improves performance by reducing branching. Signed-off-by: Andrew Boyer --- drivers/net/ionic/ionic_rxtx.c | 63 -- 1 file changed, 29 insertions(+), 34 deletions(-) diff --git a/drivers/net/ionic/ionic_rxtx.c b/drivers/net/ionic/ionic_rxtx.c index 5ee6573a5

[PATCH v1 21/35] net/ionic: add support for mbuf fast free

Use a put() rather than a free() in the optimized case. Signed-off-by: Andrew Boyer --- doc/guides/nics/features/ionic.ini | 1 + doc/guides/rel_notes/release_22_11.rst | 1 + drivers/net/ionic/ionic_ethdev.c | 2 +- drivers/net/ionic/ionic_lif.h | 1 + drivers/net/ionic/ionic

[PATCH v1 20/35] net/ionic: overhaul transmit side for performance

Linearize Tx mbuf chains in the info array. This avoids walking the mbuf chain during flush. Move a few branches out of the hot path. Signed-off-by: Andrew Boyer --- drivers/net/ionic/ionic_lif.c | 2 +- drivers/net/ionic/ionic_rxtx.c | 143 - 2 files changed,

[PATCH v1 19/35] net/ionic: overhaul receive side for performance

Linearize RX mbuf chains in the expanded info array. Clean one and fill one per CQE (completions are not coalesced). Touch the mbufs as little as possible in the fill stage. When touching the mbuf in the clean stage, use the rearm_data unions. Ring the doorbell once at the end of the bulk clean/fil

[PATCH v1 18/35] net/ionic: do one-time init of receive descriptors

These fields don't need to be set in the hot path. This improves performance. Signed-off-by: Andrew Boyer --- drivers/net/ionic/ionic_rxtx.c | 38 ++ 1 file changed, 34 insertions(+), 4 deletions(-) diff --git a/drivers/net/ionic/ionic_rxtx.c b/drivers/net/ionic/

[PATCH v1 17/35] net/ionic: use a helper variable in packet Tx function

This improves readability. Signed-off-by: Andrew Boyer --- drivers/net/ionic/ionic_rxtx.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/drivers/net/ionic/ionic_rxtx.c b/drivers/net/ionic/ionic_rxtx.c index 0f251eca13..0c1cc842cf 100644 --- a/drivers/net/ionic/io

[PATCH v1 16/35] net/ionic: precalculate segment lengths on receive side

The first (header) segment includes the standard headroom. Subsequent segments do not. Store the fragment counts in the queue structure. Precalculating improves performance by reducing how much work must be done in the hot path. Signed-off-by: Andrew Boyer --- drivers/net/ionic/ionic_dev.h |

[PATCH v1 15/35] net/ionic: free all buffers during Rx queue stop

Free all of the mbufs in the receive queue when the queue is stopped. This will allow them to be resized when the MTU is changed. Signed-off-by: Andrew Boyer --- drivers/net/ionic/ionic_dev.c | 16 + drivers/net/ionic/ionic_dev.h | 2 + drivers/net/ionic/ionic_lif.c | 32 - dr

[PATCH v1 14/35] net/ionic: replace void pointer with actual type

This makes the code safer by helping the compiler catch errors. Rename the variables, too; they're not callbacks anymore. Signed-off-by: Andrew Boyer --- drivers/net/ionic/ionic_rxtx.c | 28 +--- 1 file changed, 13 insertions(+), 15 deletions(-) diff --git a/drivers/net/

[PATCH v1 13/35] net/ionic: only request notifyq interrupt if supported

Enable the interrupt if the platform & device support it. This prevents spurious interrupts on virtual platforms. Signed-off-by: Andrew Boyer --- drivers/net/ionic/ionic_lif.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/drivers/net/ionic/ionic_lif.c b/drivers

[PATCH v1 12/35] net/ionic: move PCI-specific code to a separate file

For future support of virtual devices, move the PCI code to its own file. Create a new device interface, struct ionic_dev_intf, to plug in to common code. Signed-off-by: Andrew Boyer Signed-off-by: Neel Patel Signed-off-by: R Mohamed Shah --- drivers/net/ionic/ionic.h | 13 +- drivers

[PATCH v1 11/35] net/ionic: only allocate interrupts if required

There is no need to allocate the interrupt vector list if datapath packet interrupts are not enabled. This conserves resources. Signed-off-by: Andrew Boyer --- drivers/net/ionic/ionic_ethdev.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/drivers/net/ionic/ioni

[PATCH v1 10/35] net/ionic: remove unused identifiers

These bits are not used. Remove them to simplify the code. Fix the spacing on the IONIC_ALIGN #define. Signed-off-by: Andrew Boyer --- drivers/net/ionic/ionic.h| 1 - drivers/net/ionic/ionic_dev.h| 4 +--- drivers/net/ionic/ionic_ethdev.h | 2 -- 3 files changed, 1 insertion(+), 6 de

[PATCH v1 09/35] net/ionic: simplify code by removing doorbell map helper

There is only one doorbell page in DPDK configurations, so no helper function is needed. Signed-off-by: Andrew Boyer --- drivers/net/ionic/ionic_lif.c | 13 + 1 file changed, 1 insertion(+), 12 deletions(-) diff --git a/drivers/net/ionic/ionic_lif.c b/drivers/net/ionic/ionic_lif.c i

[PATCH v1 08/35] net/ionic: update MTU calculations

Test min and max MTU against values read from firmware, for correctness. Update the firmware field name, for clarity. The device must be stopped before changing MTU, for correctness. Store the calculated frame size in the queue, for performance. Signed-off-by: Andrew Boyer Signed-off-by: R Mohame

[PATCH v1 07/35] net/ionic: update license terms to remove GPL

Remove GPL2 and leave only BSD-3-Clause. This is more in line with the norms of the DPDK community. Signed-off-by: Andrew Boyer --- drivers/net/ionic/ionic.h | 2 +- drivers/net/ionic/ionic_dev.c | 2 +- drivers/net/ionic/ionic_dev.h | 2 +- drivers/net/ionic/ionic_ethdev.c

[PATCH v1 06/35] net/ionic: update documentation and copyrights

Pensando Systems has been acquired by AMD. Update all copyright strings and email addresses. Signed-off-by: Andrew Boyer --- MAINTAINERS| 4 ++-- doc/guides/nics/ionic.rst | 16 doc/guides/rel_notes/release_22_11.rst | 7 ++- driver

[PATCH v1 04/35] net/ionic: fix up the Rx filter save API

Check the match variable after copying cmd info, or else there can be unexpected results. Fixes: a27e0e96ab77 ("net/ionic: observe endianness in Rx filter") Cc: andrew.bo...@amd.com Cc: sta...@dpdk.org Signed-off-by: Andrew Boyer --- drivers/net/ionic/ionic_rx_filter.c | 2 +- 1 file changed, 1

[PATCH v1 05/35] net/ionic: fix up reported error stats

Report descriptor errors in ierrors instead of imissed. Don't report rx_queue_empty or rx_queue_disabled in imissed, since those packet errors are already included in the rx_*_drop_packets counters. This makes the reported stats correct. Fixes: 3cdfd90579e7 ("net/ionic: add stats") Cc: cardigli...

[PATCH v1 02/35] net/ionic: fix up endianness for RSS

This field needs to be LE when talking to the FW. Fixes: 22e7171bc63b ("net/ionic: support RSS") Cc: cardigli...@ntop.org Cc: sta...@dpdk.org Signed-off-by: Andrew Boyer --- drivers/net/ionic/ionic_rxtx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ionic/ioni

[PATCH v1 03/35] net/ionic: fix to set the adapter name for logging

Otherwise the log messages will be garbled. Fixes: 4ae96cb88fa0 ("net/ionic: do minor logging fixups") Cc: sta...@dpdk.org Signed-off-by: Andrew Boyer --- drivers/net/ionic/ionic_dev.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/net/ionic/ionic_dev.c b/driver

[PATCH v1 01/35] net/ionic: fix up endianness for Rx and Tx handling

These fields all need to be LE when talking to the FW. Fixes: a27d901331da ("net/ionic: add Rx and Tx handling") Cc: cardigli...@ntop.org Cc: sta...@dpdk.org Signed-off-by: Andrew Boyer --- drivers/net/ionic/ionic_rxtx.c | 27 +++ 1 file changed, 15 insertions(+), 12 del

[PATCH v1 00/35] net/ionic: updates for 22.11 release

This patch series provides features and performance improvements relevant for the upstream release of DPDK 22.11. There are some bits (like struct ionic_dev_intf) only useful for drivers and device types which have not yet been upstreamed. All of the changes are confined to the ionic PMD. Signed-

Re: [PATCH 1/1] devtools: eol abi as a separate function

08/08/2022 12:58, Ray Kinsella: > Developer tools associated with abi are maintained with as part of > developer tooling, eal abi headers are maintained with eal, abi build > scripts are maintained with the build system and abi policy and version > documents along with rest of the documentation. >

Re: [PATCH] devtools: give checkpatches.sh some way of finding the perl script

07/09/2022 17:01, Henning Schild: > Try and find the script in the sources of the currently running kernel > so that users do not have to specify DPDK_CHECKPATCH_PATH which might > well be the same location found by the educated guess. > > Signed-off-by: Henning Schild Applied, thanks.

[RFC] net: add experimental UDP encapsulation PMD

This is a new PMD which can be useful to test a DPDK application from another test program. The PMD binds to a connected UDP socket and expects to receive and send raw Ethernet packets over that socket. This is especially useful for testing envirionments where you can't/don't want to give the test

Re: [PATCH v5 01/10] memarea: introduce memarea library

On 2022/10/11 0:53, Mattias Rönnblom wrote: On 2022-10-08 09:53, fengchengwen wrote: Hi Mattias, Thanks for your review, most will fix in v6. On 2022/10/7 4:15, Mattias Rönnblom wrote: On 2022-10-05 06:09, datshan wrote: From: Chengwen Feng The memarea library is an allocator of variable-si

Re: [PATCH v1] bbdev: prevent clang 3.4.2 compilation error

> > Casting explicitly from enum to uint8_t to avoid compilation > > warning with clang 3.4.2 -Wtautological-constant-out-of-range-compare > > > > Signed-off-by: Nicolas Chautru > > Verified that the build passes with this patch. Thanks Nicolas. > > Tested-by: Ali Alnubani Applied with more c

Re: [PATCH v2] buildtools: ensure the NUMA nodes are counted correct

22/09/2022 10:06, Niklas Söderlund: > From: Peng Zhang > > The method to fetch, sort and read the last entry of a list to figure > out the total number of NUMA nodes in the system fails with 10 or more > nodes. The reason being the usage of string compare while sorting, hence > node 'node10' will

Re: [PATCH v3] usertools: add check for IOMMU support in dpdk-devbind

31/03/2022 16:44, Bruce Richardson: > On Thu, Mar 31, 2022 at 03:37:40PM +0100, Burakov, Anatoly wrote: > > On 21-Mar-22 12:27 PM, Fidaullah Noonari wrote: > > > binding with vfio driver, when IOMMU is disabled, causes program to crash. > > > this patch adds a flag for noiommmu-mode. when this is s

Re: [PATCH v7] usertools: rewrite pmdinfo

04/10/2022 21:29, Robin Jarry: > dpdk-pmdinfo.py does not produce any parseable output. The -r/--raw flag > merely prints multiple independent JSON lines which cannot be fed > directly to any JSON parser. Moreover, the script complexity is rather > high for such a simple task: extracting PMD_INFO_S

Re: [PATCH] net/mana: fix dependencies

09/10/2022 16:18, Thomas Monjalon: > 09/10/2022 15:53, Thomas Monjalon: > > The reason for not building is updated > > to be consistent with other drivers. > > > > The libibverbs was not detected through pkg-config. > > The method dependency() needs to be used first. > > > > The support in rdma-c

Re: [PATCH] examples/l3fwd: fix issue with MTU set on event mode

02/06/2022 09:45, Jerin Jacob: > On Thu, Apr 21, 2022 at 7:47 PM Nithin Dabilpuram > wrote: > > > > MTU configuration is missing for ethdev when using eventmode > > when user provides it via "--max-pkt-len" config. It is only > > done in poll mode setup. Fix the event mode setup code to > > do the

Re: [PATCH v1] examples/l3fwd: fix core dump after packet match

> > This patch fixes a core dump which occurs on 32-bit-builds after sending a > > matched packet due to overrunning an array. > > > > Fixes: 6de0ea50e9b9 ("examples/l3fwd: merge l3fwd-acl example") > > Cc: sean.morris...@intel.com > > Cc: sta...@dpdk.org > > > > Signed-off-by: Sean Morrissey >

RE: [PATCH] net/mana: fix dependencies

> Subject: Re: [PATCH] net/mana: fix dependencies > > 10/10/2022 20:53, Long Li: > > I will send respin as soon as patch submission window reopens. > > So what do we do in DPDK? > Do you agree with the patch I sent to correct wrong assumptions in the doc? Yes, the patch looks good to me. > > M

Re: [PATCH v3] config/arm: add Graviton3

> > Add meson build configuration for Graviton3 platform with 64-bit ARM > > Neoverse V1 cores. > > > > Signed-off-by: Ruifeng Wang > Reviewed-by: Juraj Linkeš Applied, thanks.

RE: [EXT] [PATCH] common/cnxk: add CPT LF reset sequence

> Adds code to reset CPT LF as part of cpt_lf_fini. > > Signed-off-by: Srujana Challa > --- > drivers/common/cnxk/roc_cpt.c | 82 > ++ > drivers/common/cnxk/roc_mbox.h | 6 +++ > 2 files changed, 88 insertions(+) > Applied to dpdk-next-crypto Thanks.

Re: [PATCH v3] config/arm: add PHYTIUM tys2500

17/09/2022 04:17, luzhipeng: > Here adds configs for PHYTIUM server. > > Signed-off-by: luzhipeng > > --- > v3: > 1. fix typos > 2. fix signed-off-by format The format is not correct. Please follow what Ferruh said on v2.

Re: [PATCH] net/mana: fix dependencies

10/10/2022 20:53, Long Li: > I will send respin as soon as patch submission window reopens. So what do we do in DPDK? Do you agree with the patch I sent to correct wrong assumptions in the doc? My fear is that if we keep mana PMD as-is, it could break compilation when libmana will be released if

RE: [EXT] [PATCH v3] examples/fips_validation: add parsing for AES GMAC

> Added functionality to parse algorithm for AES GMAC test > > Signed-off-by: Brian Dooley > Acked-by: Kai Ji Added documentation update. Applied to dpdk-next-crypto Thanks.

Re: [PATCH V2 1/6] bus/pci: fix a segfault when call callback

15/09/2022 14:45, Huisong Li: > After the driver probe is executed, the callback in application will > be called. The callback in application may call some APIs which access the > rte_pci_driver::driver by the device::driver pointer to get driver > information. If the rte_pci_device::device::driver

RE: [EXT] [PATCH v5] examples/fips_validation: add parsing for AES CTR

> Added functionality to parse algorithm for AES CTR test > > Signed-off-by: Brian Dooley > Acked-by: Kai Ji > Acked-by: Gowrishankar Muthukrishnan > --- > v2: fix clang warning for int-in-bool-context > --- > v3: in reply to fix and patchwork CI > --- > v4: missing acks > --- > v5: add documen

Re: [PATCH v4] net/bonding: call Tx prepare before Tx burst

On 10/8/22 23:36, Chengwen Feng wrote: uint16_t slaves[RTE_MAX_ETHPORTS]; uint8_t tx_failed_flag = 0; uint16_t num_of_slaves; + uint16_t num_tx_prep; uint16_t max_nb_of_tx_pkts = 0; @@ -1320,12 +1339,18 @@ bond_ethdev_tx_burst_broadcast(void *queue, struc

RE: [EXT] [PATCH v2] crypto/qat: reallocate on openssl version check

> This patch reallocates the openssl version check from > qat_session_configure() to a proper qat_security_session_create() > routine > > Fixes: 3227bc7138f5 ("crypto/qat: use intel-ipsec-mb for partial hash and > AES") > Cc: sta...@dpdk.org > > Signed-off-by: Brian Dooley > --- > v2: rebase on

Re: [PATCH] gro : fix pkt length when extra bytes are padded to ethernet frame

On Mon, Oct 10, 2022 at 7:51 PM Kumara Parameshwaran wrote: > > From: Kumara Parameshwaran > > When GRO packets are merged the packet length is used while > merging the adjacent packets. If the padded bytes are accounted > we would end up acking unsent TCP segments. > > Signed-off-by: Kumara Para

RE: [EXT] [PATCH] examples/l2fwd-crypto: fix typo in error message

> Fixes spelling in one of the app's exit messages. > > Fixes: 387259bd6c67 ("examples/l2fwd-crypto: add sample application") > Cc: declan.dohe...@intel.com > Cc: sta...@dpdk.org > > Signed-off-by: Ali Alnubani Applied to dpdk-next-crypto Thanks.

RE: [EXT] [PATCH v4] baseband/turbo_sw: remove Flexran SDK meson option

> 22/09/2022 18:40, Akhil Goyal: > > Hi Thomas, > > > > Do you have more comments on this patch? > > > > > The related dependency to build the PMD based on the > > > SDK libraries is now enabled through pkgconfig. > > > > > > Signed-off-by: Nicolas Chautru > > This patch looks OK. > Thank you for

RE: [PATCH v3 0/6] examples/ipsec-secgw: add lookaside event mode

> Subject: [PATCH v3 0/6] examples/ipsec-secgw: add lookaside event mode > > Add support for lookaside event mode for ipsec-secgw example application. > > * Changes since v1 > - Resolve issue with ipv6 free packet in case of error > - Rebase on top of dpdk-next-crypto > - Update release note > >

RE: [PATCH] net/mana: fix dependencies

I will send respin as soon as patch submission window reopens. Thanks, Long From: Jason Gunthorpe Sent: Sunday, October 9, 2022 7:08 AM To: thomas ; Long Li Cc: dev@dpdk.org; ferruh.yi...@amd.com; andrew.rybche...@oktetlabs.ru; step...@networkplumber.org Subject: Re: [PATCH] net/mana: fix depe

RE: [PATCH v1] bbdev: prevent clang 3.4.2 compilation error

> -Original Message- > From: Nicolas Chautru > Sent: Monday, October 10, 2022 8:04 PM > To: NBU-Contact-Thomas Monjalon (EXTERNAL) ; > dev@dpdk.org; gak...@marvell.com > Cc: Nicolas Chautru > Subject: [PATCH v1] bbdev: prevent clang 3.4.2 compilation error > > Casting explicitly from enu

RE: [EXT] Re: [PATCH v9 13/14] baseband/acc: add PF configure companion function

> Hi Akhil, Maxime, > > > From: Akhil Goyal > > Sent: Monday, October 10, 2022 3:09 AM > > Subject: RE: [EXT] Re: [PATCH v9 13/14] baseband/acc: add PF configure > > companion function > > > > > > diff --git a/drivers/baseband/acc/version.map > > > b/drivers/baseband/acc/version.map > > > > index

RE: [PATCH v9 09/14] baseband/acc: add LTE processing functions

> > > +/* Enqueue one encode operations for ACC200 device in TB mode. */ > > > +static inline int enqueue_enc_one_op_tb(struct acc_queue *q, struct > > > +rte_bbdev_enc_op *op, > > > + uint16_t total_enqueued_cbs, uint8_t cbs_in_tb) { > > > + union acc_dma_desc *desc = NULL; > > > + int ret

[PATCH] gro : fix pkt length when extra bytes are padded to ethernet frame

From: Kumara Parameshwaran When GRO packets are merged the packet length is used while merging the adjacent packets. If the padded bytes are accounted we would end up acking unsent TCP segments. Signed-off-by: Kumara Parameshwaran v1: If there is padding to the ethernet frame cases wher

Re: [PATCH v7 0/4] Add lcore poll busyness telemetry

On 2022-10-10 17:22, Morten Brørup wrote: From: Mattias Rönnblom [mailto:mattias.ronnb...@ericsson.com] Sent: Thursday, 6 October 2022 17.27 On 2022-10-06 15:25, Morten Brørup wrote: From: Kevin Laatz [mailto:kevin.la...@intel.com] Sent: Wednesday, 5 October 2022 15.45 On 14/09/2022 10:29, Kev

RE: [PATCH v9 09/14] baseband/acc: add LTE processing functions

Hi Maxime, > -Original Message- > From: Maxime Coquelin > Sent: Monday, October 10, 2022 2:48 AM > To: Chautru, Nicolas ; dev@dpdk.org; > gak...@marvell.com > Cc: t...@redhat.com; m...@ashroe.eu; Richardson, Bruce > ; hemant.agra...@nxp.com; > david.march...@redhat.com; step...@networkpl

RE: [EXT] Re: [PATCH v9 13/14] baseband/acc: add PF configure companion function

Hi Akhil, Maxime, > From: Akhil Goyal > Sent: Monday, October 10, 2022 3:09 AM > Subject: RE: [EXT] Re: [PATCH v9 13/14] baseband/acc: add PF configure > companion function > > > > diff --git a/drivers/baseband/acc/version.map > > b/drivers/baseband/acc/version.map > > > index b4ff13e38f..27fbb

GRO Support for IPv6

Hi Everyone, We would require GRO support for IPv6 in our product. I see that the current GRO library does not support it, is anyone working on it? If not, I would like to contribute. Please let me know your thoughts. Thanks, Kumara.

RE: [EXT] [PATCH v12 0/7] bbdev changes for 22.11

Hi Thomas, Akhil, I put a fix here : https://patches.dpdk.org/project/dpdk/patch/20221010170403.21201-1-nicolas.chau...@intel.com/ I did not reproduce that issue on gcc or recent clang, only with clang 3.4.2 on Centos7. Thanks Nic > -Original Message- > From: Thomas Monjalon > Sent:

[PATCH v1] bbdev: prevent clang 3.4.2 compilation error

Casting explicitly from enum to uint8_t to avoid compilation warning with clang 3.4.2 -Wtautological-constant-out-of-range-compare Signed-off-by: Nicolas Chautru --- lib/bbdev/rte_bbdev.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/lib/bbdev/rte_bbdev.c b/lib/bbdev/

[PATCH v3 6/6] examples/ipsec-secgw: reduce number of QP for event lookaside

Limit number of queue pairs to one for event lookaside mode, since all cores are using same queue in this mode. Signed-off-by: Volodymyr Fialko --- examples/ipsec-secgw/ipsec-secgw.c | 56 +++--- 1 file changed, 36 insertions(+), 20 deletions(-) diff --git a/examples/ips

[PATCH v3 5/6] examples/ipsec-secgw: add event vector support for lookaside

Add vector support for event crypto adapter in lookaside mode. Once --event-vector enabled, event crypto adapter will group processed crypto operation into rte_event_vector event with type RTE_EVENT_TYPE_CRYPTODEV_VECTOR. Signed-off-by: Volodymyr Fialko --- doc/guides/sample_app_ug/ipsec_secgw.r

[PATCH v3 4/6] examples/ipsec-secgw: add stats for event mode

Add per core statistic(rx/tx) counters for event mode worker. Signed-off-by: Volodymyr Fialko --- examples/ipsec-secgw/ipsec_worker.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/examples/ipsec-secgw/ipsec_worker.c b/examples/ipsec-secgw/ipsec_worker.c index 6c1ff

[PATCH v3 3/6] examples/ipsec-secgw: add lookaside event mode

Add base support for lookaside event mode. Events that are coming from ethdev will be enqueued to the event crypto adapter, processed and enqueued back to ethdev for the transmission. Signed-off-by: Volodymyr Fialko --- doc/guides/rel_notes/release_22_11.rst | 5 + doc/guides/sample_app_ug/i

[PATCH v3 2/6] examples/ipsec-secgw: add queue for event crypto adapter

Add separate event queue for event crypto adapter processing, to resolve queue contention between new and already processed events. Signed-off-by: Volodymyr Fialko --- examples/ipsec-secgw/event_helper.c | 95 + examples/ipsec-secgw/event_helper.h | 2 + 2 files chan

[PATCH v3 0/6] examples/ipsec-secgw: add lookaside event mode

Add support for lookaside event mode for ipsec-secgw example application. * Changes since v1 - Resolve issue with ipv6 free packet in case of error - Rebase on top of dpdk-next-crypto - Update release note * Changes since v2 - Fix compilation with old gcc Volodymyr Fialko (6): examples/ipsec-s

  1   2   >