Re: [PATCH 00/19] some bugfixes and clean code for hns3 - part2

2022-10-04 Thread Andrew Rybchenko
On 9/30/22 10:22, Dongdong Liu wrote: This patchset include some bugfixes and clean code for hns3. This patchset is based on the patchset [1] that have been sent out before. Depend on [1] applied first. [1]: [PATCH RESEND 00/13] some bugfixes and clean code for hns3 https://patches.dpdk.org/proj

Re: [PATCH v3 00/10] introduce memarea library

2022-10-04 Thread datshan
Hi David,   The v5 (send by dats...@qq.com) is sent to fix it, please have a look. Thanks. On 2022/10/3 15:42, David Marchand wrote: On Sat, Sep 24, 2022 at 9:56 AM Chengwen Feng wrote: The memarea library is an allocator of variable-size object which based on a memory region. The main featu

[PATCH v5 08/10] test/memarea: support backup memory test

2022-10-04 Thread datshan
From: Chengwen Feng This patch supports backup memory mechanism test. Signed-off-by: Chengwen Feng --- app/test/test_memarea.c | 41 + 1 file changed, 41 insertions(+) diff --git a/app/test/test_memarea.c b/app/test/test_memarea.c index ab360f0265..ec34

[PATCH v5 10/10] test/memarea: support no MT-safe test

2022-10-04 Thread datshan
From: Chengwen Feng MT-safe is enabled by default in previous test, this patch adds no MT-safe test. Signed-off-by: Chengwen Feng --- app/test/test_memarea.c | 30 ++ 1 file changed, 30 insertions(+) diff --git a/app/test/test_memarea.c b/app/test/test_memarea.c in

[PATCH v5 06/10] test/memarea: support dump test

2022-10-04 Thread datshan
From: Chengwen Feng This patch supports rte_memarea_dump() test. Signed-off-by: Chengwen Feng --- app/test/test_memarea.c | 35 ++- 1 file changed, 34 insertions(+), 1 deletion(-) diff --git a/app/test/test_memarea.c b/app/test/test_memarea.c index 0a54ede4c1..

[PATCH v5 09/10] memarea: detect memory corruption based on magic

2022-10-04 Thread datshan
From: Chengwen Feng This patch provides lightweight mechanism for detecting memory corruption which based on magic field in each element node. Signed-off-by: Chengwen Feng --- lib/memarea/memarea_private.h | 2 ++ lib/memarea/rte_memarea.c | 29 ++--- 2 files chang

[PATCH v5 07/10] memarea: support backup memory mechanism

2022-10-04 Thread datshan
From: Chengwen Feng This patch supports backup memory mechanism, the memarea could use another memarea as a backup. Signed-off-by: Chengwen Feng --- doc/guides/prog_guide/memarea_lib.rst | 3 +++ lib/memarea/memarea_private.h | 2 ++ lib/memarea/rte_memarea.c | 22 +++

[PATCH v5 04/10] test/memarea: support alloc/free/update-refcnt test

2022-10-04 Thread datshan
From: Chengwen Feng This patch supports rte_memarea_alloc()/rte_memarea_free()/ rte_memarea_update_refcnt() test. Signed-off-by: Chengwen Feng --- app/test/test_memarea.c | 150 +++- 1 file changed, 149 insertions(+), 1 deletion(-) diff --git a/app/test/tes

[PATCH v5 05/10] memarea: support dump API

2022-10-04 Thread datshan
From: Chengwen Feng This patch supports rte_memarea_dump() API which could be used for debug. Signed-off-by: Chengwen Feng --- doc/guides/prog_guide/memarea_lib.rst | 3 + lib/memarea/rte_memarea.c | 85 +++ lib/memarea/rte_memarea.h | 21 ++

[PATCH v5 03/10] memarea: support alloc/free/update-refcnt API

2022-10-04 Thread datshan
From: Chengwen Feng This patch supports rte_memarea_alloc()/rte_memarea_free()/ rte_memarea_update_refcnt() API. Signed-off-by: Chengwen Feng --- doc/guides/prog_guide/memarea_lib.rst | 10 ++ lib/memarea/memarea_private.h | 3 + lib/memarea/rte_memarea.c | 143 +

[PATCH v5 02/10] test/memarea: support memarea test

2022-10-04 Thread datshan
From: Chengwen Feng This patch supports memarea test about API rte_memarea_create and rte_memarea_destroy. Signed-off-by: Chengwen Feng --- MAINTAINERS | 1 + app/test/meson.build| 2 + app/test/test_memarea.c | 149 3 files changed,

[PATCH v5 01/10] memarea: introduce memarea library

2022-10-04 Thread datshan
From: Chengwen Feng The memarea library is an allocator of variable-size object which based on a memory region. This patch provides create/destroy API. Signed-off-by: Chengwen Feng --- MAINTAINERS| 5 + doc/api/doxy-api-index.md | 3 +- doc/api/dox

[PATCH v5 00/10] introduce memarea library

2022-10-04 Thread datshan
The memarea library is an allocator of variable-size object which based on a memory region. The main features are as follows: - The default alignment size is RTE_CACHE_LINE_SIZE. - The memory region can be initialized from the following memory sources: 1. RTE memory: e.g. invoke rte_malloc_so

[PATCH v4 10/10] test/memarea: support no MT-safe test

2022-10-04 Thread datshan
From: Chengwen Feng MT-safe is enabled by default in previous test, this patch adds no MT-safe test. Signed-off-by: Chengwen Feng --- app/test/test_memarea.c | 30 ++ 1 file changed, 30 insertions(+) diff --git a/app/test/test_memarea.c b/app/test/test_memarea.c in

[PATCH v4 09/10] memarea: detect memory corruption based on magic

2022-10-04 Thread datshan
From: Chengwen Feng This patch provides lightweight mechanism for detecting memory corruption which based on magic field in each element node. Signed-off-by: Chengwen Feng --- lib/memarea/memarea_private.h | 2 ++ lib/memarea/rte_memarea.c | 29 ++--- 2 files chang

[PATCH v4 04/10] test/memarea: support alloc/free/update-refcnt test

2022-10-04 Thread datshan
From: Chengwen Feng This patch supports rte_memarea_alloc()/rte_memarea_free()/ rte_memarea_update_refcnt() test. Signed-off-by: Chengwen Feng --- app/test/test_memarea.c | 150 +++- 1 file changed, 149 insertions(+), 1 deletion(-) diff --git a/app/test/tes

[PATCH v4 08/10] test/memarea: support backup memory test

2022-10-04 Thread datshan
From: Chengwen Feng This patch supports backup memory mechanism test. Signed-off-by: Chengwen Feng --- app/test/test_memarea.c | 41 + 1 file changed, 41 insertions(+) diff --git a/app/test/test_memarea.c b/app/test/test_memarea.c index ab360f0265..ec34

[PATCH v4 07/10] memarea: support backup memory mechanism

2022-10-04 Thread datshan
From: Chengwen Feng This patch supports backup memory mechanism, the memarea could use another memarea as a backup. Signed-off-by: Chengwen Feng --- doc/guides/prog_guide/memarea_lib.rst | 3 +++ lib/memarea/memarea_private.h | 2 ++ lib/memarea/rte_memarea.c | 22 +++

[PATCH v4 06/10] test/memarea: support dump test

2022-10-04 Thread datshan
From: Chengwen Feng This patch supports rte_memarea_dump() test. Signed-off-by: Chengwen Feng --- app/test/test_memarea.c | 35 ++- 1 file changed, 34 insertions(+), 1 deletion(-) diff --git a/app/test/test_memarea.c b/app/test/test_memarea.c index 0a54ede4c1..

[PATCH v4 05/10] memarea: support dump API

2022-10-04 Thread datshan
From: Chengwen Feng This patch supports rte_memarea_dump() API which could be used for debug. Signed-off-by: Chengwen Feng --- doc/guides/prog_guide/memarea_lib.rst | 3 + lib/memarea/rte_memarea.c | 85 +++ lib/memarea/rte_memarea.h | 21 ++

[PATCH v4 03/10] memarea: support alloc/free/update-refcnt API

2022-10-04 Thread datshan
From: Chengwen Feng This patch supports rte_memarea_alloc()/rte_memarea_free()/ rte_memarea_update_refcnt() API. Signed-off-by: Chengwen Feng --- doc/guides/prog_guide/memarea_lib.rst | 10 ++ lib/memarea/memarea_private.h | 3 + lib/memarea/rte_memarea.c | 143 +

[PATCH v4 02/10] test/memarea: support memarea test

2022-10-04 Thread datshan
From: Chengwen Feng This patch supports memarea test about API rte_memarea_create and rte_memarea_destroy. Signed-off-by: Chengwen Feng --- MAINTAINERS | 1 + app/test/meson.build| 2 + app/test/test_memarea.c | 149 3 files changed,

[PATCH v4 01/10] memarea: introduce memarea library

2022-10-04 Thread datshan
From: Chengwen Feng The memarea library is an allocator of variable-size object which based on a memory region. This patch provides create/destroy API. Signed-off-by: Chengwen Feng --- MAINTAINERS| 5 + doc/api/doxy-api-index.md | 3 +- doc/api/dox

[PATCH v4 00/10] introduce memarea library

2022-10-04 Thread datshan
The memarea library is an allocator of variable-size object which based on a memory region. The main features are as follows: - The default alignment size is RTE_CACHE_LINE_SIZE. - The memory region can be initialized from the following memory sources: 1. RTE memory: e.g. invoke rte_malloc_so

Re: [PATCH v9 1/5] ethdev: support get port error handling mode

2022-10-04 Thread fengchengwen
Hi Ferruh, On 2022/10/4 1:35, Ferruh Yigit wrote: On 9/22/2022 8:41 AM, Chengwen Feng wrote: This patch support gets port's error handling mode by rte_eth_dev_info_get() API. Currently, the defined modes include: 1) NONE: it means no error handling modes are supported by this port. 2) PASSIVE:

RE: [PATCH v7 1/4] eal: add lcore poll busyness telemetry

2022-10-04 Thread Konstantin Ananyev
Hi Bruce, > On Tue, Oct 04, 2022 at 11:15:19AM +0200, Morten Brørup wrote: > > > From: Mattias Rönnblom [mailto:hof...@lysator.liu.se] > > > Sent: Monday, 3 October 2022 22.02 > > > > [...] > > > > > The functionality provided is very useful, and the implementation is > > > clever in the way it

[PATCH v5] examples/vm_power_manager: use safe version of list iterator

2022-10-04 Thread Reshma Pattan
From: Hamza Khan Currently, when vm_power_manager exits, we are using a LIST_FOREACH macro to iterate over VM info structures while freeing them. This leads to use-after-free error. To address this, replace all usages of LIST_* with TAILQ_* macros, and use the RTE_TAILQ_FOREACH_SAFE macro to iter

RE: [PATCH v8 0/6] crypto/security session framework rework

2022-10-04 Thread Akhil Goyal
> Subject: [PATCH v8 0/6] crypto/security session framework rework > > This patchset reworks the symmetric crypto and security session > data structure to use a single virtual/physical contiguous buffer > for symmetric crypto/security session and driver private data. > In addition the session data

RE: [PATCH v4] mempool: fix mempool cache flushing algorithm

2022-10-04 Thread Morten Brørup
> From: Morten Brørup [mailto:m...@smartsharesystems.com] > Sent: Wednesday, 2 February 2022 11.34 > > This patch fixes the rte_mempool_do_generic_put() caching algorithm, > which was fundamentally wrong, causing multiple performance issues when > flushing. > > Although the bugs do have serious p

RE: [Patch v9 00/18] Introduce Microsoft Azure Network Adatper (MANA) PMD

2022-10-04 Thread Long Li
> Subject: Re: [Patch v9 00/18] Introduce Microsoft Azure Network Adatper > (MANA) PMD > > On 9/24/2022 3:45 AM, lon...@linuxonhyperv.com wrote: > > > > > From: Long Li > > > > MANA is a network interface card to be used in the Azure cloud > environment. > > MANA provides safe access to user mem

[PATCH v7] usertools: rewrite pmdinfo

2022-10-04 Thread Robin Jarry
dpdk-pmdinfo.py does not produce any parseable output. The -r/--raw flag merely prints multiple independent JSON lines which cannot be fed directly to any JSON parser. Moreover, the script complexity is rather high for such a simple task: extracting PMD_INFO_STRING from .rodata ELF sections. Rewrit

[Bug 1000] memory access overflow in skeleton_rawdev

2022-10-04 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1000 David Marchand (david.march...@redhat.com) changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Res

RE: [EXT] [dpdk-dev v3 1/1] lib/cryptodev: multi-process IPC request handler

2022-10-04 Thread Akhil Goyal
> This patch add a function to support queue-pair configuration > request to allow the primary or secondary process to setup/free the > queue-pair via IPC handler. Add in queue pair in-used by process id > array in rte_cryptodev_data for pid tracking. > > Signed-off-by: Kai Ji I had a comment on

RE: [PATCH v2] mempool: fix get objects from mempool with cache

2022-10-04 Thread Morten Brørup
> From: Andrew Rybchenko [mailto:andrew.rybche...@oktetlabs.ru] > Sent: Tuesday, 4 October 2022 17.59 > > On 10/4/22 18:13, Morten Brørup wrote: > > @Aaron, do you have any insights or comments to my curiosity below? > > > >> From: Andrew Rybchenko [mailto:andrew.rybche...@oktetlabs.ru] > >> Sent:

Re: [Patch v9 00/18] Introduce Microsoft Azure Network Adatper (MANA) PMD

2022-10-04 Thread Ferruh Yigit
On 9/24/2022 3:45 AM, lon...@linuxonhyperv.com wrote: From: Long Li MANA is a network interface card to be used in the Azure cloud environment. MANA provides safe access to user memory through memory registration. It has IOMMU built into the hardware. MANA uses IB verbs and RDMA layer to con

Re: [Patch v9 14/18] net/mana: receive packets

2022-10-04 Thread Ferruh Yigit
On 9/24/2022 3:45 AM, lon...@linuxonhyperv.com wrote: From: Long Li With all the RX queues created, MANA can use those queues to receive packets. Signed-off-by: Long Li <...> diff --git a/doc/guides/nics/features/mana.ini b/doc/guides/nics/features/mana.ini index 821443b292..fdbf22d335

Re: [Patch v9 15/18] net/mana: send packets

2022-10-04 Thread Ferruh Yigit
On 9/24/2022 3:45 AM, lon...@linuxonhyperv.com wrote: From: Long Li With all the TX queues created, MANA can send packets over those queues. Signed-off-by: Long Li --- Change log: v2: rename all camel cases. v7: return the correct number of packets sent v8: fix coding style to function defi

Re: [Patch v9 11/18] net/mana: implement the hardware layer operations

2022-10-04 Thread Ferruh Yigit
On 9/24/2022 3:45 AM, lon...@linuxonhyperv.com wrote: From: Long Li The hardware layer of MANA understands the device queue and doorbell formats. Those functions are implemented for use by packet RX/TX code. Signed-off-by: Long Li <...> + +#define DOORBELL_OFFSET_SQ 0x0 +#define DO

Re: [Patch v9 07/18] net/mana: configure RSS

2022-10-04 Thread Ferruh Yigit
On 9/24/2022 3:45 AM, lon...@linuxonhyperv.com wrote: From: Long Li Currently this PMD supports RSS configuration when the device is stopped. Configuring RSS in running state will be supported in the future. Signed-off-by: Long Li <...> + static int mana_dev_link_update(struct rte_e

Re: [Patch v9 01/18] net/mana: add basic driver with build environment and doc

2022-10-04 Thread Ferruh Yigit
On 9/24/2022 3:45 AM, lon...@linuxonhyperv.com wrote: From: Long Li MANA is a PCI device. It uses IB verbs to access hardware through the kernel RDMA layer. This patch introduces build environment and basic device probe functions. Signed-off-by: Long Li <...> +++ b/doc/guides/nics/mana.

[PATCH v8 6/6] security: hide session structure

2022-10-04 Thread Akhil Goyal
Structure rte_security_session is moved to internal headers which are not visible to applications. The only field which should be used by app is opaque_data. This field can now be accessed via set/get APIs added in this patch. Subsequent changes in app and lib are made to compile the code. Signed-

[PATCH v8 5/6] drivers/crypto: support security session get size op

2022-10-04 Thread Akhil Goyal
Added the support for rte_security_op.session_get_size() in all the PMDs which support rte_security sessions and the op was not supported. Signed-off-by: Akhil Goyal Acked-by: Kai Ji Tested-by: Gagandeep Singh Tested-by: David Coyle Tested-by: Kevin O'Sullivan --- drivers/crypto/caam_jr/caam

[PATCH v8 4/6] security: remove priv mempool usage

2022-10-04 Thread Akhil Goyal
As per current design, rte_security_session_create() unnecessarily use 2 mempool objects for a single session. To address this, the API will now take only 1 mempool object instead of 2. With this change, the library layer will get the object from mempool and session priv data is stored contiguousl

[PATCH v8 3/6] cryptodev: hide sym session structure

2022-10-04 Thread Akhil Goyal
Structure rte_cryptodev_sym_session is moved to internal headers which are not visible to applications. The only field which should be used by app is opaque_data. This field can now be accessed via set/get APIs added in this patch. Subsequent changes in app and lib are made to compile the code. Si

[PATCH v8 2/6] crypto/scheduler: use unified session

2022-10-04 Thread Akhil Goyal
From: Fan Zhang This patch updates the scheduler PMD to use unified session data structure. Previously thanks to the private session array in cryptodev sym session there are no necessary change needed for scheduler PMD other than the way ops are enqueued/dequeued. The patch inherits the same desi

[PATCH v8 0/6] crypto/security session framework rework

2022-10-04 Thread Akhil Goyal
This patchset reworks the symmetric crypto and security session data structure to use a single virtual/physical contiguous buffer for symmetric crypto/security session and driver private data. In addition the session data structure is now private. The session is represented as an opaque pointer in

[PATCH v12 7/7] bbdev: remove unnecessary if-check

2022-10-04 Thread Nicolas Chautru
Code clean up due to if-check not required Signed-off-by: Nicolas Chautru Acked-by: Maxime Coquelin --- lib/bbdev/rte_bbdev_op.h | 24 1 file changed, 4 insertions(+), 20 deletions(-) diff --git a/lib/bbdev/rte_bbdev_op.h b/lib/bbdev/rte_bbdev_op.h index c322d15dd5..e2

[PATCH v12 6/7] bbdev: add queue related warning and status information

2022-10-04 Thread Nicolas Chautru
This allows to expose more information with regards to any queue related failure and warning which cannot be supported in existing API. Signed-off-by: Nicolas Chautru Acked-by: Maxime Coquelin --- app/test-bbdev/test_bbdev_perf.c | 2 ++ doc/guides/rel_notes/release_22_11.rst | 3 ++ li

[PATCH v12 5/7] bbdev: add new operation for FFT processing

2022-10-04 Thread Nicolas Chautru
Extension of bbdev operation to support FFT based operations. Signed-off-by: Nicolas Chautru Acked-by: Hemant Agrawal Acked-by: Maxime Coquelin --- doc/guides/prog_guide/bbdev.rst| 103 + doc/guides/rel_notes/deprecation.rst | 4 - doc/guides/rel_notes/release_22_11

[PATCH v12 4/7] drivers/baseband: update PMDs to expose queue per operation

2022-10-04 Thread Nicolas Chautru
Add support in existing bbdev PMDs for the explicit number of queues and priority for each operation type configured on the device. Signed-off-by: Nicolas Chautru Acked-by: Maxime Coquelin Acked-by: Hemant Agrawal --- drivers/baseband/acc100/rte_acc100_pmd.c | 29 +++ .../

[PATCH v12 3/7] bbdev: add device info on queue topology

2022-10-04 Thread Nicolas Chautru
Adding more options in the API to expose the number of queues exposed and related priority. Signed-off-by: Nicolas Chautru Acked-by: Maxime Coquelin --- doc/guides/rel_notes/deprecation.rst | 3 --- doc/guides/rel_notes/release_22_11.rst | 2 +- lib/bbdev/rte_bbdev.h | 6

[PATCH v12 2/7] bbdev: add device status info

2022-10-04 Thread Nicolas Chautru
Added device status information, so that the PMD can expose information related to the underlying accelerator device status. Minor order change in structure to fit into padding hole. Signed-off-by: Nicolas Chautru Acked-by: Mingshan Zhang Acked-by: Hemant Agrawal --- doc/guides/rel_notes/depre

[PATCH v12 1/7] bbdev: allow operation type enum for growth

2022-10-04 Thread Nicolas Chautru
Updating the enum for rte_bbdev_op_type to allow to keep ABI compatible for enum insertion while adding padded maximum value for array need. Removing RTE_BBDEV_OP_TYPE_COUNT and instead exposing RTE_BBDEV_OP_TYPE_SIZE_MAX. Signed-off-by: Nicolas Chautru Acked-by: Maxime Coquelin --- app/test-bb

[PATCH v12 0/7] bbdev changes for 22.11

2022-10-04 Thread Nicolas Chautru
Hi Akhil, Thomas, v12: minor change to fix misaligned comment on patch 6 raised by Thomas. Thanks. v11: updated based on Thomas review notably on comments through the serie and ordering. Thanks. I have also updated rel_notes and deprecation through the serie this time. v10: replacing the _PAD

Re: [PATCH v7 1/3] power: add uncore frequency control API to the power library

2022-10-04 Thread Thomas Monjalon
28/09/2022 15:30, Tadhg Kearney: > Add API to allow uncore frequency adjustment. This is done through > manipulating related uncore frequency control sysfs entries to > adjust the minimum and maximum uncore frequency values. > Nine API's are being added that are all public and experimental. You ca

Re: [PATCH 1/7] ethdev: introduce hairpin memory capabilities

2022-10-04 Thread Thomas Monjalon
19/09/2022 18:37, Dariusz Sosnowski: > This patch introduces new hairpin queue configuration options through > rte_eth_hairpin_conf struct, allowing to tune Rx and Tx hairpin queues > memory configuration. Hairpin configuration is extended with the > following fields: What is the benefit? How the

[PATCH v9] eal: add bus cleanup to eal cleanup

2022-10-04 Thread Kevin Laatz
During EAL init, all buses are probed and the devices found are initialized. On eal_cleanup(), the inverse does not happen, meaning any allocated memory and other configuration will not be cleaned up appropriately on exit. Currently, in order for device cleanup to take place, applications must cal

Re: [PATCH 0/7] ethdev: introduce hairpin memory capabilities

2022-10-04 Thread Thomas Monjalon
19/09/2022 18:37, Dariusz Sosnowski: > This patch series introduces hairpin memory configuration options proposed in > http://patches.dpdk.org/project/dpdk/patch/20220811120530.191683-1-dsosnow...@nvidia.com/ > for Rx and Tx hairpin queues. It also implements handling of these options in > mlx5 PM

[PATCH v2] mempool: fix get objects from mempool with cache

2022-10-04 Thread Morten Brørup
RESENT for test purposes. A flush threshold for the mempool cache was introduced in DPDK version 1.3, but rte_mempool_do_generic_get() was not completely updated back then, and some inefficiencies were introduced. This patch fixes the following in rte_mempool_do_generic_get(): 1. The code that i

RE: [PATCH v2] mempool: fix get objects from mempool with cache

2022-10-04 Thread Morten Brørup
RESENT for test purposes. A flush threshold for the mempool cache was introduced in DPDK version 1.3, but rte_mempool_do_generic_get() was not completely updated back then, and some inefficiencies were introduced. This patch fixes the following in rte_mempool_do_generic_get(): 1. The code that i

[dpdk-dev v1] crypto/qat: fix of qat build request session in mp

2022-10-04 Thread Kai Ji
This patch fix the session pointer passed in set_session() when ctx has NULL build request pointer in multi-processes scenario. Fixes: fb3b9f492205 ("crypto/qat: rework burst data path") Cc: sta...@dpdk.org Signed-off-by: Kai Ji --- drivers/crypto/qat/qat_sym.c | 2 +- 1 file changed, 1 inserti

[PATCH v2] mempool: fix get objects from mempool with cache

2022-10-04 Thread Morten Brørup
RESENT for test purposes. A flush threshold for the mempool cache was introduced in DPDK version 1.3, but rte_mempool_do_generic_get() was not completely updated back then, and some inefficiencies were introduced. This patch fixes the following in rte_mempool_do_generic_get(): 1. The code that

Re: [PATCH RESEND 00/13] some bugfixes and clean code for hns3

2022-10-04 Thread Andrew Rybchenko
On 9/5/22 11:59, Dongdong Liu wrote: This patchset consists of two parts that have been sent out before. 1. [PATCH 0/5] some bugfixes and clean code for hns3 https://lore.kernel.org/all/20220713115002.8959-2-liudongdo...@huawei.com/T/ 2. [PATCH 0/8] some bugfixes for hns3 https://lore.kernel.org/

Re: [PATCH v2] mempool: fix get objects from mempool with cache

2022-10-04 Thread Andrew Rybchenko
On 10/4/22 18:13, Morten Brørup wrote: @Aaron, do you have any insights or comments to my curiosity below? From: Andrew Rybchenko [mailto:andrew.rybche...@oktetlabs.ru] Sent: Tuesday, 4 October 2022 14.58 Hi Morten, In general I agree that the fix is required. In sent v3 I'm trying to make it

[PATCH v8 6/6] test/cpuflags: add test for LoongArch cpu flag

2022-10-04 Thread Min Zhou
Add checks for all flag values defined in the LoongArch cpu feature table. Signed-off-by: Min Zhou --- app/test/test_cpuflags.c | 41 1 file changed, 41 insertions(+) diff --git a/app/test/test_cpuflags.c b/app/test/test_cpuflags.c index 98a99c2c7d..a0e3

[PATCH v8 4/6] net/tap: set BPF syscall ID for LoongArch

2022-10-04 Thread Min Zhou
Define the missing __NR_bpf syscall id to enable the tap PMD on LoongArch. Signed-off-by: Min Zhou --- drivers/net/tap/meson.build | 6 -- drivers/net/tap/tap_bpf.h | 2 ++ 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/net/tap/meson.build b/drivers/net/tap/meson.bu

[PATCH v8 1/6] eal/loongarch: support LoongArch architecture

2022-10-04 Thread Min Zhou
Add all necessary elements for DPDK to compile and run EAL on LoongArch64 Soc. This includes: - EAL library implementation for LoongArch ISA. - meson build structure for 'loongarch' architecture. RTE_ARCH_LOONGARCH define is added for architecture identification. - xmm_t structure operation stu

[PATCH v8 5/6] examples/l3fwd: enable LoongArch operation

2022-10-04 Thread Min Zhou
Add missing em_mask_key() implementation to enable the l3fwd to be run on LoongArch. Signed-off-by: Min Zhou --- examples/l3fwd/l3fwd_em.c | 8 examples/l3fwd/meson.build | 6 -- 2 files changed, 8 insertions(+), 6 deletions(-) diff --git a/examples/l3fwd/l3fwd_em.c b/examples/l3f

[PATCH v8 0/6] Introduce support for LoongArch architecture

2022-10-04 Thread Min Zhou
Dear team, The following patch set is intended to support DPDK running on LoongArch architecture. LoongArch is the general processor architecture of Loongson Corporation and is a new RISC ISA, which is a bit like MIPS or RISC-V. The online documents of LoongArch architecture are here: https:

[PATCH v8 2/6] net/ixgbe: add vector stubs for LoongArch

2022-10-04 Thread Min Zhou
Similar to RISC-V, the current version for LoongArch do not support vector. Re-use vector processing stubs in ixgbe PMD defined for PPC for LoongArch. This enables ixgbe PMD usage in scalar mode on LoongArch. The ixgbe PMD driver was validated with Intel X520-DA2 NIC and the test-pmd application,

[PATCH v8 3/6] net/memif: set memfd syscall ID on LoongArch

2022-10-04 Thread Min Zhou
Define the missing __NR_memfd_create syscall id to enable the memif PMD on LoongArch. Signed-off-by: Min Zhou --- drivers/net/memif/meson.build | 6 -- drivers/net/memif/rte_eth_memif.h | 2 ++ 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/net/memif/meson.build b

Re: [PATCH v8] eal: add bus cleanup to eal cleanup

2022-10-04 Thread Kevin Laatz
On 04/10/2022 16:28, David Marchand wrote: On Tue, Oct 4, 2022 at 3:08 PM Kevin Laatz wrote: During EAL init, all buses are probed and the devices found are initialized. On eal_cleanup(), the inverse does not happen, meaning any allocated memory and other configuration will not be cleaned up ap

Re: [PATCH v3 0/5] Add support for live migration and cleanup MCDI headers

2022-10-04 Thread Andrew Rybchenko
On 7/14/22 16:47, abhimanyu.sa...@xilinx.com wrote: From: Abhimanyu Saini In SW assisted live migration, vDPA driver will stop all virtqueues and setup up SW vrings to relay the communication between the virtio driver and the vDPA device using an event driven relay thread This will allow vDPA d

Re: [PATCH v8] eal: add bus cleanup to eal cleanup

2022-10-04 Thread David Marchand
On Tue, Oct 4, 2022 at 3:08 PM Kevin Laatz wrote: > > During EAL init, all buses are probed and the devices found are > initialized. On eal_cleanup(), the inverse does not happen, meaning any > allocated memory and other configuration will not be cleaned up > appropriately on exit. > > Currently,

RE: [PATCH] dumpcap: fix list interfaces

2022-10-04 Thread Kaur, Arshdeep
Hi Stephen, I tested the patch. "-D" option is now working properly. But I am facing an issue in this. Using "-D" provides me with the interfaces available. For me these are ":18:01.0" and ":18:09.0": ./dpdk-dumpcap -D --file-prefix wls_1 FlexRAN SDK bblib_lte_ldpc_decoder version #DIRT

RE: [PATCH v2] mempool: fix get objects from mempool with cache

2022-10-04 Thread Morten Brørup
@Aaron, do you have any insights or comments to my curiosity below? > From: Andrew Rybchenko [mailto:andrew.rybche...@oktetlabs.ru] > Sent: Tuesday, 4 October 2022 14.58 > > Hi Morten, > > In general I agree that the fix is required. > In sent v3 I'm trying to make it a bit better from my point

Re: [PATCH v2] net/ring: add monitor callback

2022-10-04 Thread Andrew Rybchenko
On 9/2/22 20:25, Herakliusz Lipiec wrote: Currently ring pmd does not support ``rte_power_monitor`` api. This patch adds support by adding monitor callback that is called whenever we enter sleep state and need to check if it is time to wake up. Signed-off-by: Herakliusz Lipiec Acked-by: Bruce R

Re: [PATCH] doc: relate bifurcated driver and flow isolated mode

2022-10-04 Thread Andrew Rybchenko
On 9/20/22 13:56, Ori Kam wrote: Hi, -Original Message- From: Dariusz Sosnowski Sent: Tuesday, 20 September 2022 11:49 Hi Thomas, -Original Message- From: Thomas Monjalon Sent: Wednesday, September 14, 2022 23:30 To: dev@dpdk.org Cc: Michael Savisko ; Slava Ovsiienko ; Mata

RE: [PATCH v7 2/4] ethdev: introduce protocol hdr based buffer split

2022-10-04 Thread Wang, YuanX
Hi Andrew, > -Original Message- > From: Andrew Rybchenko > Sent: Tuesday, October 4, 2022 4:23 PM > To: Wang, YuanX ; dev@dpdk.org; Thomas > Monjalon ; Ferruh Yigit > Cc: ferruh.yi...@xilinx.com; m...@ashroe.eu; Li, Xiaoyun > ; Singh, Aman Deep ; > Zhang, Yuying ; Zhang, Qi Z > ; Yang, Q

RE: [PATCH v7 1/4] ethdev: introduce protocol header API

2022-10-04 Thread Wang, YuanX
Hi Andrew, > -Original Message- > From: Andrew Rybchenko > Sent: Tuesday, October 4, 2022 3:53 PM > To: Wang, YuanX ; dev@dpdk.org; Thomas > Monjalon ; Ferruh Yigit ; > Ray Kinsella > Cc: ferruh.yi...@xilinx.com; Li, Xiaoyun ; Singh, Aman > Deep ; Zhang, Yuying > ; Zhang, Qi Z ; Yang, >

Re: [PATCH v2] net/axgbe: support segmented Tx

2022-10-04 Thread Andrew Rybchenko
On 9/9/22 12:31, Namburu, Chandu-babu wrote: -Original Message- From: Modali, Bhagyada Sent: Thursday, September 8, 2022 11:45 PM To: Namburu, Chandu-babu ; Yigit, Ferruh Cc: dev@dpdk.org; sta...@dpdk.org; Modali, Bhagyada Subject: [PATCH v2] net/axgbe: support segmented Tx Enable seg

[PATCH v2] drivers/bus: set device NUMA node to unknown by default

2022-10-04 Thread Olivier Matz
The dev->device.numa_node field is set by each bus driver for every device it manages to indicate on which NUMA node this device lies. When this information is unknown, the assigned value is not consistent across the bus drivers. Set the default value to SOCKET_ID_ANY (-1) by all bus drivers when

Re: [PATCH] memif: memif driver does not crashes when there's different N of TX and RX queues

2022-10-04 Thread Andrew Rybchenko
On 8/8/22 13:39, Joyce Kong wrote: Hi Huzaifa, This patch looks good to me. And would you please help review my memif patches? https://patches.dpdk.org/project/dpdk/cover/20220701102815.1444223-1-joyce.k...@arm.com/ Thanks, Joyce -Original Message- From: huzaifa.rahman Sent: Tuesday,

Re: [PATCH v2 1/1] app/testpmd: add command line argument 'nic-to-pmd-rx-metadata'

2022-10-04 Thread Andrew Rybchenko
On 9/1/22 11:03, Singh, Aman Deep wrote: On 8/2/2022 11:21 PM, Hanumanth Pothula wrote: Presently, rx metadata is sent to PMD by default, leading to a performance drop as processing for the same in rx path takes extra cycles. Hence, introducing command line argument, 'nic-to-pmd-rx-metadata'

Re: [PATCH] net/tap: add persist option

2022-10-04 Thread Andrew Rybchenko
On 8/9/22 22:34, Stephen Hemminger wrote: The TAP device only lasts as long as the DPDK application that opened it is running. This behavior is basd if the DPDK application needs to be updated transparently without disturbing other services using the tap device. This patch adds a persist feature

RE: [PATCH v3] mempool: fix get objects from mempool with cache

2022-10-04 Thread Morten Brørup
> From: Andrew Rybchenko [mailto:andrew.rybche...@oktetlabs.ru] > Sent: Tuesday, 4 October 2022 14.54 > To: Olivier Matz > Cc: dev@dpdk.org; Morten Brørup; Beilei Xing; Bruce Richardson; Jerin > Jacob Kollanukkaran > Subject: [PATCH v3] mempool: fix get objects from mempool with cache > > From: Mo

Re: [PATCH] net/tap: fix the overflow of the network interface index.

2022-10-04 Thread Andrew Rybchenko
On 7/21/22 18:19, Stephen Hemminger wrote: On Thu, 21 Jul 2022 11:13:01 + Alex Kiselev wrote: On Linux and most other systems, network interface index is a 32-bit integer. Indexes overflowing the 16-bit integer are frequently seen when used inside a Docker container. Signed-off-by: Alex

Re: [PATCH] app/testpmd: fix vlan offload of rxq

2022-10-04 Thread Singh, Aman Deep
On 9/30/2022 9:15 PM, Mingjin Ye wrote: After setting "vlan offload" in testpmd, the result does not update the rxq queues configuration. Therefore, this patch is to reconfigure rxq queues after executing the "vlan offload" command. Fixes: a47aa8b97afe ("app/testpmd: add vlan offload support"

Re: [PATCH v7 1/4] eal: add lcore poll busyness telemetry

2022-10-04 Thread Mattias Rönnblom
On 2022-10-04 13:57, Bruce Richardson wrote: > On Tue, Oct 04, 2022 at 11:15:19AM +0200, Morten Brørup wrote: >>> From: Mattias Rönnblom [mailto:hof...@lysator.liu.se] >>> Sent: Monday, 3 October 2022 22.02 >> >> [...] >> >>> The functionality provided is very useful, and the implementation is >>>

[PATCH v8] eal: add bus cleanup to eal cleanup

2022-10-04 Thread Kevin Laatz
During EAL init, all buses are probed and the devices found are initialized. On eal_cleanup(), the inverse does not happen, meaning any allocated memory and other configuration will not be cleaned up appropriately on exit. Currently, in order for device cleanup to take place, applications must cal

Re: [PATCH] remove prefix to some local macros in apps and examples

2022-10-04 Thread Ferruh Yigit
On 10/4/2022 9:01 AM, David Marchand wrote: RTE_TEST_[RT]X_DESC_DEFAULT and RTE_TEST_[RT]X_DESC_MAX macros have been copied in a lot of app/ and examples/ code. Those macros are local to each program. They are not related to a DPDK public header/API, drop the RTE_TEST_ prefix. Signed-off-by: Da

Re: [PATCH v2] mempool: fix get objects from mempool with cache

2022-10-04 Thread Andrew Rybchenko
Hi Morten, In general I agree that the fix is required. In sent v3 I'm trying to make it a bit better from my point of view. See few notes below. On 2/2/22 11:14, Morten Brørup wrote: A flush threshold for the mempool cache was introduced in DPDK version 1.3, but rte_mempool_do_generic_get() wa

[PATCH v4 5/5] test/crypto: add remaining blockcipher SGL tests

2022-10-04 Thread Ciara Power
The current blockcipher test function only has support for two types of SGL test, INPLACE or OOP_SGL_IN_LB_OUT. These types are hardcoded into the function, with the number of segments always set to 3. To ensure all SGL types are tested, blockcipher test vectors now have fields to specify SGL type

[PATCH v4 3/5] crypto/ipsec_mb: add remaining SGL support

2022-10-04 Thread Ciara Power
The intel-ipsec-mb library supports SGL for GCM and ChaChaPoly algorithms using the JOB API. This support was added to AESNI_MB PMD previously, but the SGL feature flags could not be added due to no SGL support for other algorithms. This patch adds a workaround SGL approach for other algorithms us

[PATCH v4 4/5] test/crypto: add OOP snow3g SGL tests

2022-10-04 Thread Ciara Power
More tests are added to test variations of OOP SGL for snow3g. This includes LB_IN_SGL_OUT and SGL_IN_LB_OUT. Signed-off-by: Ciara Power Acked-by: Fan Zhang Acked-by: Pablo de Lara --- app/test/test_cryptodev.c | 48 +++ 1 file changed, 39 insertions(+), 9 d

[PATCH v4 2/5] crypto/ipsec_mb: fix session creation for sessionless

2022-10-04 Thread Ciara Power
Currently, for a sessionless op, the session taken from the mempool contains some values previously set by a testcase that does use a session. This is due to the session object not being reset before going back into the mempool. This caused issues when multiple sessionless testcases ran, as the pr

[PATCH v4 1/5] test/crypto: fix wireless auth digest segment

2022-10-04 Thread Ciara Power
The segment size for some tests was too small to hold the auth digest. This caused issues when using op->sym->auth.digest.data for comparisons in AESNI_MB PMD after a subsequent patch enables SGL. For example, if segment size is 2, and digest size is 4, then 4 bytes are read from op->sym->auth.dig

[PATCH v4 0/5] add remaining SGL support to AESNI_MB

2022-10-04 Thread Ciara Power
Currently, the intel-ipsec-mb library only supports SGL for GCM and ChaCha20-Poly1305 algorithms through the JOB API. To add SGL support for other algorithms, a workaround approach is added in the AESNI_MB PMD. SGL feature flags can now be added to the PMD. This patchset also includes a fix for S

[PATCH v3] mempool: fix get objects from mempool with cache

2022-10-04 Thread Andrew Rybchenko
From: Morten Brørup A flush threshold for the mempool cache was introduced in DPDK version 1.3, but rte_mempool_do_generic_get() was not completely updated back then, and some inefficiencies were introduced. Fix the following in rte_mempool_do_generic_get(): 1. The code that initially screens t

DPDK build for Arm with GCC 12

2022-10-04 Thread Thomas Monjalon
Hello, GCC 12 suspects an out-of-bound write in NEON port_groupx4(): In file included from examples/ipsec-secgw/ipsec_neon.h:9, from examples/ipsec-secgw/ipsec_lpm_neon.h:9, from examples/ipsec-secgw/ipsec_worker.c:16: examples/common/neon/port_group.h: In functi

  1   2   >