RE: [RFC] Dynamic log/trace control via telemetry

> From: Dmitry Kozlyuk [mailto:dmitry.kozl...@gmail.com] > Sent: Saturday, 20 August 2022 17.20 > To: Morten Brørup > Cc: Stephen Hemminger; dev@dpdk.org > Subject: Re: [RFC] Dynamic log/trace control via telemetry > > 2022-08-17 17:34 (UTC+0200), Morten Brørup: > > > From: Dmitry Kozlyuk [mailto:

RE: [PATCH 11/13] ethdev: remove deprecated flow item VF

Hi Ivan Some comments inline, > -Original Message- > From: Ivan Malov > Sent: Friday, 12 August 2022 22:18 > Subject: [PATCH 11/13] ethdev: remove deprecated flow item VF > > Such deprecation was commenced in DPDK 21.11. > Since then, no parties have objected. Remove. > > The patch bre

RE: [PATCH v2 00/70] ice base code update

> -Original Message- > From: Zhang, Qi Z > Sent: Monday, August 15, 2022 3:31 PM > To: Yang, Qiming > Cc: dev@dpdk.org; Zhang, Qi Z > Subject: [PATCH v2 00/70] ice base code update > > Update ice base code to 2022-Aug internal release. > > Summary: > > 1. Baseline support for L2TPv

RE: [PATCH v2 31/70] net/ice/base: move function to internal

> -Original Message- > From: Zhang, Qi Z > Sent: Monday, August 15, 2022 3:31 PM > To: Yang, Qiming > Cc: dev@dpdk.org; Zhang, Qi Z ; Guo, Junfeng > > Subject: [PATCH v2 31/70] net/ice/base: move function to internal > > The function ice_disable_fd_swap should be defined as static. >

RE: [PATCH 13/13] ethdev: remove deprecated flow action PHY PORT

Hi Ivan, > -Original Message- > From: Ivan Malov > Sent: Friday, 12 August 2022 22:18 > Subject: [PATCH 13/13] ethdev: remove deprecated flow action PHY PORT > > Such deprecation was commenced in DPDK 21.11. > Since then, no parties have objected. Remove. > > The patch breaks ABI. > >

RE: [PATCH 12/13] ethdev: remove deprecated flow item PHY PORT

Hi > -Original Message- > From: Ivan Malov > Sent: Friday, 12 August 2022 22:18 > Subject: [PATCH 12/13] ethdev: remove deprecated flow item PHY PORT > > Such deprecation was commenced in DPDK 21.11. > Since then, no parties have objected. Remove. > > The patch breaks ABI. > > Signed-o

RE: [PATCH 10/13] ethdev: remove deprecated flow item PF

Hi Ivan > -Original Message- > From: Ivan Malov > Sent: Friday, 12 August 2022 22:18 PF > > Such deprecation was commenced in DPDK 21.11. > Since then, no parties have objected. Remove. > > The patch breaks ABI. > > Signed-off-by: Ivan Malov > Reviewed-by: Andrew Rybchenko > --- > a

Re: [PATCH v2] examples/ethtool: adds promiscuous mode functionality

Hi, The following test is failing on my patch and its is not related to my changes, can u please re-run it. test: ci/iol-x86_64-unit-testing Thanks Regards, Jawad On Thu, Aug 11, 2022 at 2:45 PM Muhammad Jawad Hussain < jawad.huss...@emumba.com> wrote: > ethtool did not have promiscuous mode f

[PATH 2/2] vhost: fix slot index calculation in async vhost

When the packet receiving failure and the DMA ring full occur simultaneously in the asynchronous vhost, the slot_idx needs to be reduced by 1. For packed virtqueue, the slot index should be ring_size - 1, if the slot_idx is currently 0, since the ring size is not necessarily the power of 2. Signed

[PATH 1/2] vhost: fix descs count in async vhost packed ring

When vhost receive packets from the front-end using packed virtqueue, it might use multiple descriptors for one packet, so we need calculate and record the descriptor number for each packet to update available descriptor counter and used descriptor counter, and rollback when DMA ring is full. Sign

[PATH 0/2] vhost: fix some async vhost index calculation issues

Fix some async vhost index calculation issues. Cheng Jiang (2): vhost: fix descs count in async vhost packed ring vhost: fix slot index calculation in async vhost lib/vhost/virtio_net.c | 40 +--- 1 file changed, 29 insertions(+), 11 deletions(-) -- 2.35.

[PATCH v3 2/2] net/memif: add a Tx fast path

For memif non-zero-copy mode, there is a branch to compare the mbuf and memif buffer size during memory copying. If all mbufs come from the same mempool, and memif buf size >= mbuf size, add a fast Tx memory copy path without the comparing branch and with mbuf bulk free, otherwise still run the ori

[PATCH v3 1/2] net/memif: add a Rx fast path

For memif non-zero-copy mode, there is a branch to compare the mbuf and memif buffer size during memory copying. Mbuf and memif buffer size is defined at compile time. If memif buf size <= mbuf size, add a fast Rx memory copy path by removing this branch and mbuf bulk alloc. The removal of the bra

[PATCH v3 0/2] add a fast path for memif Rx/Tx

For memif non-zero-copy mode, there is a branch to compare the mbuf and memif buffer size during memory copy. Add a fast memcpy path by removing this branch with mbuf and memif buffer size defined at compile time. For Rx fast path, bulk allocating mbufs to get additional speedup. For Tx fast path,

[PATCH] apps/dumpcap: fix interface parameter option

The dumpcap application supports an interface parameter via the `-i` [1] option however the current documentation utilizes a `-I` flag. [1] https://git.dpdk.org/dpdk/tree/app/dumpcap/main.c#n314 Fixes: cbb44143be74 ("app/dumpcap: add new packet capture application") Cc: sta...@dpdk.org Signed-of

[PATCH] linux/igb_uio: make module parameters visible in sysfs

- explicitly set default value for intr_mode - give read permission on wc_activate - applying patch gives below visibility ``` $ more /sys/module/igb_uio/parameters/* | cat :: /sys/module/igb_uio/parameters/intr_mode :: msix :: /sys/module/igb_uio/parameters/wc_

[PATCH 3/3] eal: deduplicate roundup code

RTE_CACHE_LINE_ROUNDUP() implementation repeated RTE_ALIGN_MUL_CEIL(). In other places RTE_CACHE_LINE_SIZE is assumed to be a power-of-2, so define RTE_CACHE_LINE_ROUNDUP() using RTE_ALIGN_CEIL(). Signed-off-by: Dmitry Kozlyuk --- lib/eal/include/rte_common.h | 4 +--- 1 file changed, 1 insertio

[PATCH 2/3] eal: uninline rte_str_to_size

There is no reason for rte_str_to_size() to be inline. Move the implementation out of . Export it as a stable ABI because it always has been public. Signed-off-by: Dmitry Kozlyuk --- Now doesn't need to #include and , but removing them breaks some DPDK code, may break user code too. I'm not sur

[PATCH 1/3] eal: fix pointer arithmetic with an expression argument

RTE_PTR_SUB(ptr, x) and RTE_PTR_ALIGN_FLOOR() worked incorrectly if "ptr" was an expression: uint32_t arr[3]; RTE_PTR_SUB(arr + 1, sizeof(arr[0])); // expected: (uint32_t *)((uintptr_t)(arr + 1) - 4) == arr // actual: (uint32_t *)((uintptr_t) arr + 1 - 4) != arr RTE_PTR_AL

[PATCH 0/3] eal: small rte_common.h fixes and cleanup

Dmitry Kozlyuk (3): eal: fix pointer arithmetic with an expression argument eal: uninline rte_str_to_size eal: deduplicate roundup code app/test/test_common.c | 11 lib/eal/common/eal_common_string_fns.c | 32 ++ lib/eal/include/rte_common.h