RE: [PATCH v2 21/70] net/ice/base: add E822 generic PCI device ID

> -Original Message- > From: Zhang, Qi Z > Sent: Monday, August 15, 2022 3:31 PM > To: Yang, Qiming > Cc: dev@dpdk.org; Zhang, Qi Z > Subject: [PATCH v2 21/70] net/ice/base: add E822 generic PCI device ID > > The E822 has a generic PCI device ID that can be used in the PLDM header >

RE: [PATCH v2 12/70] net/ice/base: move code block

> -Original Message- > From: Zhang, Qi Z > Sent: Monday, August 15, 2022 3:31 PM > To: Yang, Qiming > Cc: dev@dpdk.org; Zhang, Qi Z ; Temerkhanov, > Sergey > Subject: [PATCH v2 12/70] net/ice/base: move code block > > Move some code block to the beginning of ice_ptp_hw.c to align wit

RE: [PATCH v2 01/70] net/ice/base: add netlist helper functions

Hi, > -Original Message- > From: Zhang, Qi Z > Sent: Monday, August 15, 2022 3:31 PM > To: Yang, Qiming > Cc: dev@dpdk.org; Zhang, Qi Z ; Michalik, Michal > > Subject: [PATCH v2 01/70] net/ice/base: add netlist helper functions > > Add new functions to check in netlist if HW has: > - Re

RE: [PATCH] gro: fix gro with ethernet tail padding bytes

> -Original Message- > From: Jun Qiu > Sent: Thursday, July 28, 2022 7:02 PM > To: Hu, Jiayu ; dev@dpdk.org > Cc: sta...@dpdk.org > Subject: RE: [PATCH] gro: fix gro with ethernet tail padding bytes > > I don't think the stack(software) cares if the length of a packet is less > than 6

[PATCH v2 70/70] net/ice/base: update copyright

Updated copyright to 2022 and update base code version. Signed-off-by: Paul M. Stillwell Jr Signed-off-by: Qi Zhang --- drivers/net/ice/base/README | 4 ++-- drivers/net/ice/base/ice_acl.c | 2 +- drivers/net/ice/base/ice_acl.h | 2 +- drivers/net/ice/base/ice_a

[PATCH v2 69/70] net/ice/base: couple code clean

1. remove unused code 2. reduce variable scope 3. fix comment Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_common.c| 2 +- drivers/net/ice/base/ice_flex_pipe.c | 20 ++-- drivers/net/ice/base/ice_flow.c | 1 - drivers/net/ice/base/ice_nvm.c | 2 +- drive

[PATCH v2 68/70] net/ice/base: expose API for move sched element

Exposed ice_aq_move_sched_elems to support sched element moving by AQ command. Signed-off-by: Ben Shelton Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_sched.c | 2 +- drivers/net/ice/base/ice_sched.h | 10 +++--- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/driver

[PATCH v2 67/70] net/ice/base: check for PTP HW lock more frequently

PTP HW semaphore can be held for ~50 ms in worst case. SW should wait longer and check more frequently if the HW lock is held. Signed-off-by: Karol Kolacinski Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_ptp_hw.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git

[PATCH v2 66/70] net/ice/base: add GTP tunnel

Added GTP tunnel type and also re-order the code to align with kernel driver. Signed-off-by: Marcin Szycik Signed-off-by: Michal Swiatkowski Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_flex_type.h | 10 +++--- drivers/net/ice/base/ice_protocol_type.h | 2 +- drivers/net/ice/b

[PATCH v2 65/70] net/ice/base: remove unnecessary fields

Remove unnecessary fields in data structure for 1588 and QoS func capabilities. Signed-off-by: Karol Kolacinski Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_common.c | 5 ++--- drivers/net/ice/base/ice_switch.c | 2 -- drivers/net/ice/base/ice_type.h | 6 -- 3 files changed, 2 ins

[PATCH v2 64/70] net/ice/base: convert 1588 structs to use bitfields

Use bitfields in 1588 structs so they don't waste too much space. Signed-off-by: Karol Kolacinski Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_type.h | 28 ++-- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/drivers/net/ice/base/ice_type.h b/driv

[PATCH v2 63/70] net/ice/base: handle default VSI lookup type

ICE_SW_LKUP_DFLT is handled in ice_update_vsi_list_rule and ice_aq_alloc_free_vsi_list. Signed-off-by: Lukasz Kupczak Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_switch.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ice/base/ice_switch.c b/drivers/net/ice/base/ice

[PATCH v2 62/70] net/ice/base: add function to parse DCBX config

LLDP MIB Change Event (opcode 0x0A01) already contains MIB, which has been changed. Add ice_dcb_process_lldp_set_mib_change() function, which will set local/remote DCBX config from LLDP MIB Change Event's buffer. This function will be used in a base driver handler for LLDP MIB Change Event. Signe

[PATCH v2 61/70] net/ice/base: complete pending LLDP MIB

Completed structure ice_aqc_lldp_get_mib. Added 'Pending Event Enable' bit. Signed-off-by: Tsotne Chakhvadze Signed-off-by: Karen Sornek Signed-off-by: Anatolii Gerasymenko Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_adminq_cmd.h | 20 ++-- drivers/net/ice/base/ice_dc

[PATCH v2 60/70] net/ice/base: update comment for overloaded GCO bit

The bit that is overloaded is bit 11 in the flex descriptor, updating the comment to have the right one reflected. Signed-off-by: Alice Michael Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_lan_tx_rx.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ice/ba

[PATCH v2 59/70] net/ice/base: add unload flag for control queue shutdown

Admin queue command for shutdown AQ contains flag to indicate driver unload. However the flag is always set in driver, even for the resets. It causes Firmware to consider driver as unloaded once the PF reset is triggered on all ports of device. Firmware then restores default configuration of some f

[PATCH v2 58/70] net/ice/base: fix wrong inputset of GTPoGRE packet

For GTPoGRE, When setting the prot_id of prot, it should be set to second inner. Fixes: 34a0e7c44f2b ("net/ice/base: improve flow director masking") Cc: sta...@dpdk.org Signed-off-by: Kevin Liu Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_flow.c | 10 -- 1 file changed, 8 inser

[PATCH v2 57/70] net/ice/base: add GRE Tap tunnel type

Added new tunnel type to support NvGRE Signed-off-by: Michal Swiatkowski Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_flex_type.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ice/base/ice_flex_type.h b/drivers/net/ice/base/ice_flex_type.h index 2855d67831..070d2aeb1e

[PATCH v2 56/70] net/ice/base: enable FDIR support for L2TPv2

Add L2TPv2(include PPP over L2TPv2) support for FDIR. And add support PPPoL2TPv2oUDP with inner IPV4/IPV6/UDP/TCP for FDIR. The supported L2TPv2 packets are defined as below: ICE_FLTR_PTYPE_NONF_IPV4_L2TPV2_CONTROL ICE_FLTR_PTYPE_NONF_IPV4_L2TPV2 ICE_FLTR_PTYPE_NONF_IPV4_L2TPV2_PPP ICE_FLTR_PTYPE

[PATCH v2 55/70] net/ice/base: enable RSS support for L2TPv2 session ID

Add L2TPv2 session ID field support for RSS. Enable L2TPv2 non-tunneled packet types for UDP protocol header bitmaps. Signed-off-by: Jie Wang Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_flow.c | 12 drivers/net/ice/base/ice_flow.h | 14 ++ 2 files changed, 26

[PATCH v2 54/70] net/ice/base: add generic MAC with 3K signature segment

Define new type id ICE_MAC_GENERIC_3k in ice_mac_type enum, to distinguish devices which use RSA-3K/SHA-384 segment signature type. Use 3k signinig type for E824S device. Signed-off-by: Grzegorz Nitka Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_common.c | 3 ++- 1 file changed, 2 inser

[PATCH v2 53/70] net/ice/base: add support for custom WPC and LGB NICs

There are few custom Westport Channel (WPC) and Logan Beach (LGB) network interface cards (NICs) - add their subdevice IDs to be able to distinguish them. Signed-off-by: Michal Michalik Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_common.c | 15 --- drivers/net/ice/base/ice_

[PATCH v2 52/70] net/ice/base: clean the main timer command register

Clean the main timer command register after use to avoid residual command execution, such as re-initialization of the main timer. Signed-off-by: Sergey Temerkhanov Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_ptp_hw.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/net/i

[PATCH v2 51/70] net/ice/base: update PHY type high max index

ICE_PHY_TYPE_HIGH_MAX_INDEX should be the maximum index value and not the length/number of ICE_PHY_TYPE_HIGH. Signed-off-by: Paul Greenwalt Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_adminq_cmd.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ice/base/

[PATCH v2 50/70] net/ice/base: add support for Auto FEC with FEC disabled

The default Link Establishment State Machine (LESM) behavior does not allow the use of FEC disable mode if the media does not support FEC disabled. However users may want to override this behavior. Add support for setting Auto FEC with FEC disabled. Signed-off-by: Paul Greenwalt Signed-off-by: Q

[PATCH v2 49/70] net/ice/base: clean up with no lookups

The add rule functionality works fine with a NULL lookups parameter. However when running the undefined behavior sanitizer it noticed that the function could trigger a memcpy from a NULL target. Fix the code to handle NULL lkups and a zero lkups_cnt variable more explicitly, and clean up the test

[PATCH v2 48/70] net/ice/base: ignore already exist error

Ignore ERR_ALREADY_EXISTS error when setting promiscuous mode. This fix is needed because the driver could set promiscuous mode when it still has not cleared properly. Promiscuous mode could be set only once, so setting it second time will be rejected. Fixes: 60ff6f5ce2d8 ("net/ice/base: consolida

[PATCH v2 47/70] net/ice/base: refine header file include

The ice_switch.h and ice_fdir.h headers include ice_common.h. They are both themselves included in ice_common.h. This causes a circular dependency ordering. Signed-off-by: Jacob Keller Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_fdir.h | 2 +- drivers/net/ice/base/ice_switch.c | 1 +

[PATCH v2 46/70] net/ice/base: update macros of L2TPv2 ptype value

Because the macros of L2TPv2 packet type value were changed in ice_ppp-o-l2tpv2-o-udp-1.3.4.0.pkg. So update the macros of L2TPv2 packet type value and the bitmaps of packet types for relevant protocol header to match the new DDP package. Signed-off-by: Jie Wang Signed-off-by: Qi Zhang --- driv

[PATCH v2 45/70] net/ice/base: update definitions for AQ internal debug dump

Add defines for Queue Mng and Full CSR Space in debug dump internal data. This defines are used in Lanconf for debug dump. Added QV_SUPPORT macro in ifdef for ACL. Signed-off-by: Dawid Zielinski Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_adminq_cmd.h | 20 +++- 1 file

[PATCH v2 44/70] net/ice/base: complete support for Tx balancing

Add module ID and struct necessary to read and save Tx Scheduler Topology Tree User Selection data from PFA TLV. Signed-off-by: Lukasz Czapnik Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_adminq_cmd.h | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/net/ice/base/ice_

[PATCH v2 43/70] net/ice/base: move functions

Move function ice_ptp_set_vernier_wl and ice_ptp_src_cmd to align with kernel driver. Signed-off-by: Jacob Keller Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_ptp_hw.c | 130 +++--- 1 file changed, 66 insertions(+), 64 deletions(-) diff --git a/drivers/net/ice/b

[PATCH v2 42/70] net/ice/base: fix double VLAN error in promisc mode

Avoid enabling or disabling vlan 0 when trying to set promiscuous vlan mode if double vlan mode is enabled. This fix is needed because the driver tries to add the vlan 0 filter twice (once for inner and once for outer) when double VLAN mode is enabled. The filter program is rejected by the firmware

[PATCH v2 41/70] net/ice/base: add low latency Tx timestamp read

E810 products can support low latency Tx timestamp register read. Add a check for the device capability and use the new method if supported. Signed-off-by: Karol Kolacinski Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_common.c | 7 ++- drivers/net/ice/base/ice_ptp_hw.c | 95 +++

[PATCH v2 40/70] net/ice/base: add helper function to check if device is E823

Add a simple function checking if the device is E823-L or E823-C based. Signed-off-by: Karol Kolacinski Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_common.c | 25 + drivers/net/ice/base/ice_common.h | 1 + 2 files changed, 26 insertions(+) diff --git a/drivers

[PATCH v2 39/70] net/ice/base: add data typecasting to match sizes

Adding typecast to variables to avoid compiler warnings generated if variables of a particular data type are assigned to ones of a smaller data type. For example assigning an unsigned 16 bit integer to an 8 bit integer could trigger data loss warnings or errors. Signed-off-by: Vignesh Sridhar Sig

[PATCH v2 38/70] net/ice/base: adjust the VSI/Aggregator layers

Adjust the VSI/Aggregator layers based on the number of logical layers supported by the FW. Currently the VSI and aggregator layers are fixed based on the 9 layer scheduler tree layout. Due to performance reasons the number of layers of the scheduler tree is changing from 9 to 5. It requires a read

[PATCH v2 37/70] net/ice/base: support Tx topo config

Complete the Tx topo config implementation. Signed-off-by: Victor Raj Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_adminq_cmd.h | 3 +++ drivers/net/ice/base/ice_common.c | 3 +++ 2 files changed, 6 insertions(+) diff --git a/drivers/net/ice/base/ice_adminq_cmd.h b/drivers/net/ice

[PATCH v2 36/70] net/ice/base: fix add mac rule

Fix ice_add_mac_rule function by not overriding action value with vsi id. It's possible to add MAC based switch filters with action other than FWD_TO_VSI. In current implementation fwd_id member of filter config structure was always overwritten with hw vsi index, regardless of action type. Fix it,

[PATCH v2 35/70] net/ice/base: refine default VSI config

Refine API ice_cfg_dflt_vsi and add new API ice_check_if_dflt_vsi. Signed-off-by: Michal Wilczynski Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_switch.c | 95 +-- drivers/net/ice/base/ice_switch.h | 2 + 2 files changed, 53 insertions(+), 44 deletions(-) d

[PATCH v2 34/70] net/ice/base: fix null pointer dereference during

Sometimes, during the shutdown process, an PCIe unrecoverable error occurs. This leads to the following NULL pointer dereference error while clearing hardware tables: The patch fixes this bug by checking every table pointer against NULL before reference it, as some of them probably have been clear

[PATCH v2 33/70] net/ice/base: add AQ command to config node attribute

Added AQ command to config nod attribute. Signed-off-by: Ben Shelton Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_adminq_cmd.h | 17 + drivers/net/ice/base/ice_sched.c | 27 +++ drivers/net/ice/base/ice_sched.h | 4 3 files changed

[PATCH v2 32/70] net/ice/base: change PHY/QUAD/ports definitions

Rename PHY/QUAD/ports definitions to reflect the correct HW specification. Signed-off-by: Karol Kolacinski Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_ptp_hw.c | 45 --- drivers/net/ice/base/ice_type.h | 14 +- 2 files changed, 31 insertions(+), 28

[PATCH v2 31/70] net/ice/base: move function to internal

The function ice_disable_fd_swap should be defined as static. Signed-off-by: Junfeng Guo Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_flex_pipe.c | 2 +- drivers/net/ice/base/ice_flex_pipe.h | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/ice/base/ice_fl

[PATCH v2 30/70] net/ice/base: fix bit finding range over ptype bitmap

The 2nd argument to function ice_find_first_bit is the bitmap size, (in bits) not a mask. Thus, use of UINT16_MAX or 0x will allow a potential run off the end of the ptype array. Also, the ptype bitmap (i.e., prof->ptypes) is declared with size ICE_FLOW_PTYPE_MAX, thus finding the bits within t

[PATCH v2 29/70] net/ice/base: fix array overflow in add switch recipe code

The array indexes in this function are used with a zero index in the fv_idx table, and with a +1 index in the lkup_idx arrays. The code was using the lookup index for the field vector in only one place in this function, but the code was never used after this point so just remove the bad line. This

[PATCH v2 28/70] net/ice/base: convert array of u8 to bitmap

Previously the ice_add_prof function took an array of u8 and looped over it with for_each_set_bit, examining each 8 bit value as a bitmap. This was just hard to understand and unnecessary, and was triggering undefined behavior sanitizers with unaligned accesses within bitmap fields. Since the ptyp

[PATCH v2 27/70] net/ice/base: convert IO expander handle to u16

The io_expander_handle cached value is marked as an __le16, but several places track the node handle with u16 values. Unify all the interfaces so that it is stored and reported as a u16, and keep the low level conversion to LE16 only at the direct firmware interface. This fixes warnings from spars

[PATCH v2 26/70] net/ice/base: fix endian format

A few functions failed to properly convert some values into Little Endian format before sending them to the firmware. This will produce incorrect results when running on a Big Endian platform. Fix this by adding the necessary CPU_TO_LE* macros around the input to firmware. These issues were detec

[PATCH v2 25/70] net/ice/base: fix incorrect function descriptions for parser

Some function descriptions for parser are mismatched, thus fixed with this patch. Fixes: 7fe2d98070e0 ("net/ice/base: add parser create and destroy skeleton") Fixes: 1792942b2df6 ("net/ice/base: init boost TCAM table for parser") Fixes: f787952d13d2 ("net/ice/base: init flag redirect table for par

[PATCH v2 24/70] net/ice/base: create duplicate detection for ACL rules

Currently there is no check for adding duplicate ACL rules, this creates subtle bugs, for example unability to remove filters. Adding check + refactoring a redundant function. Signed-off-by: Michal Wilczynski Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_fdir.c | 99 -

[PATCH v2 23/70] net/ice/base: report NVM version numbers on mismatch

Report NVM version numbers (both detected and expected) when a mismatch b/w driver and firmware is detected. This would provide more useful information about which NVM version the driver expects instead of looking up the code Signed-off-by: Sergey Temerkhanov Signed-off-by: Qi Zhang --- drivers

[PATCH v2 22/70] net/ice/base: support double VLAN rules

Add support for double vlan rules with c-tag and s-tag in it. Enable the caller to configure double vlan rules, and use extended package capabilities to allow adding flow with double vlans. The patch also re-order the code in ice_switch.c to align with kernel driver. Signed-off-by: Wiktor Pilarcz

[PATCH v2 21/70] net/ice/base: add E822 generic PCI device ID

The E822 has a generic PCI device ID that can be used in the PLDM header when updating the device so add it. Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_devids.h | 3 ++- drivers/net/ice/ice_ethdev.c | 1 + 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/i

[PATCH v2 19/70] net/ice/base: fix PHY type 10G SFI C2C to media type mapping

PHY type ICE_PHY_TYPE_LOW_10G_SFI_C2C is incorrectly mapped to media type Fiber which results in ethtool reporting the wrong Supported ports. PHY type ICE_PHY_TYPE_LOW_10G_SFI_C2C should map to media type Backplane. Fixes: 453d087ccaff ("net/ice/base: add common functions") Cc: sta...@dpdk.org S

[PATCH v2 18/70] net/ice/base: enable calling of ETH56G functions

Enable calling of ETH56G functions in the base code when the appropriate PHY has been detected Signed-off-by: Sergey Temerkhanov Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_ptp_hw.c | 523 -- 1 file changed, 498 insertions(+), 25 deletions(-) diff --git a/d

[PATCH v2 17/70] net/ice/base: work around missing PTP caps

Provide a WA for missing PTP caps on Simics, this code shall be removed after cap reporting is fixed Signed-off-by: Sergey Temerkhanov Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_common.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/net/ice/base/ice

[PATCH v2 16/70] net/ice/base: implement 56G PHY setup functions

Implement setup functions for the 56G PHY Simics model Signed-off-by: Sergey Temerkhanov Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_ptp_hw.c | 29 + drivers/net/ice/base/ice_ptp_hw.h | 2 ++ 2 files changed, 31 insertions(+) diff --git a/drivers/net/ice/b

[PATCH v2 15/70] net/ice/base: implement 56G PHY access functions

Implement 56G PHY register and memory read/write functions to facilitate PTP support Signed-off-by: Sergey Temerkhanov Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_ptp_hw.c | 1094 +++-- drivers/net/ice/base/ice_ptp_hw.h | 44 +- drivers/net/ice/base/ice_type.h

[PATCH v2 14/70] net/ice/base: add 56G PHY register definitions

Add 56G PHY register address definitions to facilitate 56G PHY support. Signed-off-by: Sergey Temerkhanov Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_ptp_hw.h | 75 +++ 1 file changed, 75 insertions(+) diff --git a/drivers/net/ice/base/ice_ptp_hw.h b/drive

[PATCH v2 13/70] net/ice/base: add PHY 56G destination address

Add PHY 56G destination address. PHY56G is a single device incorporating all SerDes lanes Signed-off-by: Sergey Temerkhanov Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_sbq_cmd.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ice/base/ice_sbq_cmd.h b/drivers/net/ice/ba

[PATCH v2 12/70] net/ice/base: move code block

Move some code block to the beginning of ice_ptp_hw.c to align withkernel driver. Signed-off-by: Sergey Temerkhanov Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_ptp_hw.c | 997 +++--- 1 file changed, 498 insertions(+), 499 deletions(-) diff --git a/drivers/net/i

[PATCH v2 11/70] net/ice/base: explicitly name E822 HW-dependent functions

Add the suffix to E822 HW-dependent function names Signed-off-by: Sergey Temerkhanov Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_ptp_hw.c | 23 --- drivers/net/ice/base/ice_ptp_hw.h | 7 --- 2 files changed, 16 insertions(+), 14 deletions(-) diff --git a/drive

[PATCH v2 10/70] net/ice/base: complete the health status codes

add definitions for async health status codes. Signed-off-by: Leszek Zygo Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_adminq_cmd.h | 10 ++ 1 file changed, 10 insertions(+) diff --git a/drivers/net/ice/base/ice_adminq_cmd.h b/drivers/net/ice/base/ice_adminq_cmd.h index a3add4

[PATCH v2 09/70] net/ice/base: fix DSCP PFC TLV creation

When creating the TLV to send to the FW for configuring DSCP mode PFC, the PFCENABLE field was being masked with a 4 bit mask (0xF), but this is an 8 bit bitmask for enabled classes for PFC. This means that traffic classes 4-7 could not be enabled for PFC. Remove the mask completely, as it is not

[PATCH v2 08/70] net/ice/base: support VXLAN and GRE for RSS

Add RSS of inner headers for VXLAN tunnel packet. Add packet types for packets with outer IPv4/IPv6 header support GRE and VXLAN tunnel packet. Following rules can use new packet types: - eth / ipv4(6) / udp / vxlan / ipv4(6) - eth / ipv4(6) / udp / vxlan / ipv4(6) / tcp - eth / ipv4(

[PATCH v2 07/70] net/ice/base: fix 100M speed

Couple of 10GBase-T devices don't support advertising 100M speed. For these devices, ice_is_100m_speed_supported should return false. Meanwhile add device that supports 100M speed. Fixes: 486d29fda54c ("net/ice/base: add dedicate MAC type for E810") Cc: sta...@dpdk.org Signed-off-by: Anirudh Venk

[PATCH v2 06/70] net/ice/base: added auto drop blocking packets functionality

Extended ice_aq_set_mac_cfg()function to add support for auto drop blocking packets. Signed-off-by: Mateusz Rusinski Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_common.c | 22 -- drivers/net/ice/base/ice_common.h | 5 - drivers/net/ice/base/ice_type.h | 6 ++

[PATCH v2 05/70] net/ice/base: fix incorrect division during E822 PTP init

When initializing the device hardware for PTP, the E822 devices requirea number of values to be calculated and programmed to hardware.These values are calculated using unsigned 64-bit division. The DIV_64BIT macro currently translates into a specific Linux functionthat triggers a *signed* division

[PATCH v2 04/70] net/ice/base: make function names more generic

Previously "e810t" was part of few function names. In the future it will require to add similar functions for different NIC types. Make "NIC type" a suffix of the function name. Signed-off-by: Arkadiusz Kubalewski Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_ptp_hw.c | 12 ++--

[PATCH v2 03/70] net/ice/base: combine functions for VSI promisc

Remove ice_get_vsi_vlan_promisc, cause of similar implementation as ice_get_vsi_promisc, which will now handle the use case of ice_get_vsi_vlan_promisc. Signed-off-by: Wiktor Pilarczyk Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_switch.c | 58 ++- 1 file cha

[PATCH v2 02/70] net/ice/base: get NVM CSS Header length from the CSS Header

The CSS Header length is defined as ICE_CSS_HEADER_LENGTH. To support changes in CSS Header length, calculate the CSS Header length from the NVM CSS Header length field plus the Authentication Header length. Signed-off-by: Paul Greenwalt Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_nvm.

[PATCH v2 01/70] net/ice/base: add netlist helper functions

Add new functions to check in netlist if HW has: - Recovered Clock device, - Clock Generation Unit, - Clock Multiplexer, - GPS generic device. Signed-off-by: Michal Michalik Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_adminq_cmd.h | 54 +++ drivers/net/ice/base/ice_common.c

[PATCH v2 00/70] ice base code update

Update ice base code to 2022-Aug internal release. Summary: 1. Baseline support for L2TPv2 FDIR/RSS. 2. Refactor DDP module. 3. Support 56G PHY 4. Add GTP/GRE tunnel. 6. Clean code and fix bug 5. update copyright v2: - fix couple patchwork warnings. Qi Zhang (70): net/ice/base: add netlist h

[PATCH 70/70] net/ice/base: update copyright

Updated copyright to 2022 and update base code version. Signed-off-by: Paul M. Stillwell Jr Signed-off-by: Qi Zhang --- drivers/net/ice/base/README | 4 ++-- drivers/net/ice/base/ice_acl.c | 2 +- drivers/net/ice/base/ice_acl.h | 2 +- drivers/net/ice/base/ice_a

[PATCH 69/70] net/ice/base: couple code clean

1. remove unused code 2. reduce variable scope 3. fix comment Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_common.c| 2 +- drivers/net/ice/base/ice_flex_pipe.c | 20 ++-- drivers/net/ice/base/ice_flow.c | 1 - drivers/net/ice/base/ice_nvm.c | 2 +- drive

[PATCH 68/70] net/ice/base: expose API for move sched element

Exposed ice_aq_move_sched_elems to support sched element moving by AQ command. Signed-off-by: Ben Shelton Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_sched.c | 2 +- drivers/net/ice/base/ice_sched.h | 10 +++--- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/driver

[PATCH 67/70] net/ice/base: check for PTP HW lock more frequently

PTP HW semaphore can be held for ~50 ms in worst case. SW should wait longer and check more frequently if the HW lock is held. Signed-off-by: Karol Kolacinski Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_ptp_hw.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git

[PATCH 66/70] net/ice/base: add GTP tunnel

Added GTP tunnel type and also re-order the code to align with kernel driver. Signed-off-by: Marcin Szycik Signed-off-by: Michal Swiatkowski Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_flex_type.h | 10 +++--- drivers/net/ice/base/ice_protocol_type.h | 2 +- drivers/net/ice/b

[PATCH 65/70] net/ice/base: remove unnecessary fields

Remove unnecessary fields in data structure for 1588 and QoS func capabilities. Signed-off-by: Karol Kolacinski Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_common.c | 5 ++--- drivers/net/ice/base/ice_switch.c | 2 -- drivers/net/ice/base/ice_type.h | 6 -- 3 files changed, 2 ins

[PATCH 64/70] net/ice/base: convert 1588 structs to use bitfields

Use bitfields in 1588 structs so they don't waste too much space. Signed-off-by: Karol Kolacinski Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_type.h | 28 ++-- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/drivers/net/ice/base/ice_type.h b/driv

[PATCH 63/70] net/ice/base: handle default VSI lookup type

ICE_SW_LKUP_DFLT is handled in ice_update_vsi_list_rule and ice_aq_alloc_free_vsi_list. Signed-off-by: Lukasz Kupczak Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_switch.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ice/base/ice_switch.c b/drivers/net/ice/base/ice

[PATCH 62/70] net/ice/base: add function to parse DCBX config

LLDP MIB Change Event (opcode 0x0A01) already contains MIB, which has been changed. Add ice_dcb_process_lldp_set_mib_change() function, which will set local/remote DCBX config from LLDP MIB Change Event's buffer. This function will be used in a base driver handler for LLDP MIB Chang Event. Signed

[PATCH 61/70] net/ice/base: complete pending LLDP MIB

Completed structure ice_aqc_lldp_get_mib. Added 'Pending Event Enable' bit. Signed-off-by: Tsotne Chakhvadze Signed-off-by: Karen Sornek Signed-off-by: Anatolii Gerasymenko Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_adminq_cmd.h | 20 ++-- drivers/net/ice/base/ice_dc

[PATCH 60/70] net/ice/base: update comment for overloaded GCO bit

The bit that is overloaded is bit 11 in the flex descriptor, updating the comment to have the right one reflected. Signed-off-by: Alice Michael Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_lan_tx_rx.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ice/ba

[PATCH 59/70] net/ice/base: add unload flag for control queue shutdown

Admin queue command for shutdown AQ contains flag to indicate driver unload. However the flag is always set in driver, even for the resets. It causes Firmware to consider driver as unloaded once the PF reset is triggered on all ports of device. Firmware then restores default configuration of some f

[PATCH 58/70] net/ice/base: fix wrong inputset of GTPoGRE packet

For GTPoGRE, When setting the prot_id of prot, it should be set to second inner. Fixes: 34a0e7c44f2b ("net/ice/base: improve flow director masking") Cc: sta...@dpdk.org Signed-off-by: Kevin Liu Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_flow.c | 10 -- 1 file changed, 8 inser

[PATCH 57/70] net/ice/base: add GRE Tap tunnel type

Added new tunnel type to support NvGRE Signed-off-by: Michal Swiatkowski Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_flex_type.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ice/base/ice_flex_type.h b/drivers/net/ice/base/ice_flex_type.h index 2855d67831..070d2aeb1e

[PATCH 56/70] net/ice/base: enable FDIR support for L2TPv2

Add L2TPv2(include PPP over L2TPv2) support for FDIR. And add support PPPoL2TPv2oUDP with inner IPV4/IPV6/UDP/TCP for FDIR. The supported L2TPv2 packets are defined as below: ICE_FLTR_PTYPE_NONF_IPV4_L2TPV2_CONTROL ICE_FLTR_PTYPE_NONF_IPV4_L2TPV2 ICE_FLTR_PTYPE_NONF_IPV4_L2TPV2_PPP ICE_FLTR_PTYPE

[PATCH 55/70] net/ice/base: enable RSS support for L2TPv2 session ID

Add L2TPv2 session ID field support for RSS. Enable L2TPv2 non-tunneled packet types for UDP protocol header bitmaps. Signed-off-by: Jie Wang Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_flow.c | 12 drivers/net/ice/base/ice_flow.h | 14 ++ 2 files changed, 26

[PATCH 54/70] net/ice/base: add generic MAC with 3K signature segment

Define new type id ICE_MAC_GENERIC_3k in ice_mac_type enum, to distinguish devices which use RSA-3K/SHA-384 segment signature type. Use 3k signinig type for E824S device. Signed-off-by: Grzegorz Nitka Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_common.c | 3 ++- 1 file changed, 2 inser

[PATCH 53/70] net/ice/base: add support for custom WPC and LGB NICs

There are few custom Westport Channel (WPC) and Logan Beach (LGB) network interface cards (NICs) - add their subdevice IDs to be able to distinguish them. Signed-off-by: Michal Michalik Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_common.c | 15 --- drivers/net/ice/base/ice_

[PATCH 52/70] net/ice/base: clean the main timer command register

Clean the main timer command register after use to avoid residual command execution, such as re-initialization of the main timer. Signed-off-by: Sergey Temerkhanov Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_ptp_hw.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/net/i

[PATCH 51/70] net/ice/base: update PHY type high max index

ICE_PHY_TYPE_HIGH_MAX_INDEX should be the maximum index value and not the length/number of ICE_PHY_TYPE_HIGH. Signed-off-by: Paul Greenwalt Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_adminq_cmd.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ice/base/

[PATCH 50/70] net/ice/base: add support for Auto FEC with FEC disabled

The default Link Establishment State Machine (LESM) behavior does not allow the use of FEC disable mode if the media does not support FEC disabled. However users may want to override this behavior. Add support for settng Auto FEC with FEC disabled. Signed-off-by: Paul Greenwalt Signed-off-by: Qi

[PATCH 49/70] net/ice/base: clean up with no lookups

The add rule functionality works fine with a NULL lookups parameter. However when running the undefined behavior sanitizer it noticed that the function could trigger a memcpy from a NULL target. Fix the code to handle NULL lkups and a zero lkups_cnt variable more explicitly, and clean up the test

[PATCH 48/70] net/ice/base: ignore already exist error

Ignore ERR_ALREADY_EXISTS error when setting promiscuous mode. This fix is needed because the driver could set promiscuous mode when it still has not cleared properly. Promiscuous mode could be set only once, so setting it second time will be rejected. Fixes: 60ff6f5ce2d8 ("net/ice/base: consolida

[PATCH 47/70] net/ice/base: refine header file include

The ice_switch.h and ice_fdir.h headers include ice_common.h. They are both themselves included in ice_common.h. This causes a circular dependency ordering. Signed-off-by: Jacob Keller Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_fdir.h | 2 +- drivers/net/ice/base/ice_switch.c | 1 +

[PATCH 46/70] net/ice/base: update macros of L2TPv2 ptype value

Because the macros of L2TPv2 packet type value were changed in ice_ppp-o-l2tpv2-o-udp-1.3.4.0.pkg. So update the macros of L2TPv2 packet type value and the bitmaps of packet types for relevant protocol header to match the new DDP package. Signed-off-by: Jie Wang Signed-off-by: Qi Zhang --- driv

[PATCH 45/70] net/ice/base: update definitions for AQ internal debug dump

Add defines for Queue Mng and Full CSR Space in debug dump internal data. This defines are used in Lanconf for debug dump. Added QV_SUPPORT macro in ifdef for ACL. Signed-off-by: Dawid Zielinski Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_adminq_cmd.h | 20 +++- 1 file

  1   2   >