RE: [EXT] Re: [PATCH v3] doc: announce change in event queue conf structure

2022-07-12 Thread Pavan Nikhilesh Bhagavatula
+Cc timothy.mcdan...@intel.com; hemant.agra...@nxp.com; sachin.sax...@oss.nxp.com; mattias.ronnb...@ericsson.com; jer...@marvell.com; lian...@liangbit.com; peter.mccar...@intel.com; harry.van.haa...@intel.com; erik.g.carri...@intel.com; abhinandan.guj...@intel.com; jay.jayatheert...@intel.com; m...

RE: [PATCH] doc: announce changes to event vector structure

2022-07-12 Thread Gujjar, Abhinandan S
> -Original Message- > From: Thomas Monjalon > Sent: Tuesday, July 12, 2022 8:27 PM > To: Pavan Nikhilesh > Cc: dev@dpdk.org; Jerin Jacob ; Ray Kinsella > ; Jerin Jacob ; Jayatheerthan, Jay > ; Carrillo, Erik G ; > Gujjar, Abhinandan S ; McDaniel, Timothy > ; hemant.agra...@nxp.com; Va

RE: [EXT] Re: [PATCH] doc: announce change in crypto adapter queue add

2022-07-12 Thread Gujjar, Abhinandan S
> -Original Message- > From: Akhil Goyal > Sent: Tuesday, July 12, 2022 11:02 AM > To: Jerin Jacob ; Gujjar, Abhinandan S > > Cc: Volodymyr Fialko ; dev@dpdk.org; Ray Kinsella > ; Jerin Jacob Kollanukkaran ; Anoob > Joseph > Subject: RE: [EXT] Re: [PATCH] doc: announce change in crypto

Re: [PATCH v2] doc: announce changes to rte_eth_set_queue_rate_limit api

2022-07-12 Thread Jerin Jacob
On Wed, Jul 13, 2022 at 11:59 AM wrote: > > From: Satha Rao > > rte_eth_set_queue_rate_limit argument rate modified to uint32_t > to support more than 64Gbps. > > Signed-off-by: Satha Rao With api to API change in subject line Acked-by: Jerin Jacob > --- > doc/guides/rel_notes/deprecation

[PATCH v1] examples/fips_validation: fix memory allocation in aes mct test

2022-07-12 Thread Gowrishankar Muthukrishnan
Instead of allocating memory in every external iteration, do once in the beginning of AES MCT tests and free at the end. Fixes: 8b8546aaedf ("examples/fips_validation: add parsing for AES-CBC") Signed-off-by: Gowrishankar Muthukrishnan --- examples/fips_validation/main.c | 26 ++

[PATCH v1 2/2] examples/fips_validation: add parsing for tdes

2022-07-12 Thread Gowrishankar Muthukrishnan
Added function to parse algorithm for TDES CBC and ECB tests in json. Signed-off-by: Gowrishankar Muthukrishnan --- doc/guides/sample_app_ug/fips_validation.rst | 2 + examples/fips_validation/fips_validation.c| 5 +- examples/fips_validation/fips_validation.h| 4 + .../fips_valid

[PATCH v1 1/2] examples/fips_validation: skip offsetting source for json vectors

2022-07-12 Thread Gowrishankar Muthukrishnan
For JSON based test vectors, it is not required to offset further on source address where key value is read. Signed-off-by: Gowrishankar Muthukrishnan --- examples/fips_validation/fips_validation.c | 4 1 file changed, 4 insertions(+) diff --git a/examples/fips_validation/fips_validation.c

[PATCH v2] doc: announce changes to rte_eth_set_queue_rate_limit api

2022-07-12 Thread skoteshwar
From: Satha Rao rte_eth_set_queue_rate_limit argument rate modified to uint32_t to support more than 64Gbps. Signed-off-by: Satha Rao --- doc/guides/rel_notes/deprecation.rst | 5 + 1 file changed, 5 insertions(+) diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/d

Re: [PATCH] doc: add deprecation notice for kni example

2022-07-12 Thread Andrew Rybchenko
On 7/12/22 17:17, Thomas Monjalon wrote: 30/06/2022 18:50, Bruce Richardson: +* examples/kni: The ``kni`` kernel module and library are not recommended for use by new applications - + other technologies such as virtio-user are recommended instead. + Because of this, the example application fo

RE: [EXT] Re: [PATCH] doc: announce changes to rte_eth_set_queue_rate_limit api

2022-07-12 Thread Satha Koteswara Rao Kottidi
Thanks Thomas. I will send v2 with uint32_t type. Thanks, Satha. -Original Message- From: Thomas Monjalon Sent: Tuesday, July 12, 2022 7:34 PM To: Satha Koteswara Rao Kottidi Cc: Andrew Rybchenko ; Ray Kinsella ; dev@dpdk.org; ferruh.yi...@amd.com; bruce.richard...@intel.com; konstan

RE: [EXT] Re: [PATCH 1/2] doc: add enqueue depth for new event type

2022-07-12 Thread Hemant Agrawal
> > 27/06/2022 11:57, pbhagavat...@marvell.com: > > > From: Pavan Nikhilesh > > > > > > A new field ``max_event_port_enqueue_new_burst`` will be added to > > > the structure ``rte_event_dev_info``. The field defines the max > > > enqueue burst size of new events (OP_NEW) supported by the > > > und

Re: [EXT] Re: [PATCH 1/2] doc: add enqueue depth for new event type

2022-07-12 Thread Thomas Monjalon
12/07/2022 20:11, Pavan Nikhilesh Bhagavatula: > +Cc > timothy.mcdan...@intel.com; > hemant.agra...@nxp.com; > sachin.sax...@oss.nxp.com; > mattias.ronnb...@ericsson.com; > jer...@marvell.com; > lian...@liangbit.com; > peter.mccar...@intel.com; > harry.van.haa...@intel.com; > erik.g.carri...@intel.

Re: [EXT] Re: [PATCH v2 1/1] doc: announce addition of new ipsec event subtypes

2022-07-12 Thread Thomas Monjalon
12/07/2022 17:30, Akhil Goyal: > > 27/06/2022 07:29, Vamsi Attunuru: > > > New event subtypes need to be added for notifying expiry events > > > upon reaching IPsec SA soft packet expiry and hard packet/byte > > > expiry limits. This would be added in DPDK 22.11. > > > > > > Signed-off-by: Vamsi At

RE: [EXT] Re: [PATCH] doc: announce change in event vector structure

2022-07-12 Thread Pavan Nikhilesh Bhagavatula
+cc timothy.mcdan...@intel.com; hemant.agra...@nxp.com; sachin.sax...@oss.nxp.com; mattias.ronnb...@ericsson.com; jer...@marvell.com; lian...@liangbit.com; peter.mccar...@intel.com; harry.van.haa...@intel.com; erik.g.carri...@i

RE: [EXT] Re: [PATCH] doc: announce name change of stop flush callback

2022-07-12 Thread Pavan Nikhilesh Bhagavatula
+Cc timothy.mcdan...@intel.com; hemant.agra...@nxp.com; sachin.sax...@oss.nxp.com; mattias.ronnb...@ericsson.com; jer...@marvell.com; lian...@liangbit.com; peter.mccar...@intel.com; harry.van.haa...@intel.com; erik.g.carri...@intel.com; abhinandan.guj...@intel.com; jay.jayatheert...@intel.com; m...

RE: [EXT] Re: [PATCH 1/2] doc: add enqueue depth for new event type

2022-07-12 Thread Pavan Nikhilesh Bhagavatula
+Cc timothy.mcdan...@intel.com; hemant.agra...@nxp.com; sachin.sax...@oss.nxp.com; mattias.ronnb...@ericsson.com; jer...@marvell.com; lian...@liangbit.com; peter.mccar...@intel.com; harry.van.haa...@intel.com; erik.g.carri...@intel.com; abhinandan.guj...@intel.com; jay.jayatheert...@intel.com; m...

RE: [PATCH] doc: announce changes to event vector structure

2022-07-12 Thread McDaniel, Timothy
> -Original Message- > From: Thomas Monjalon > Sent: Tuesday, July 12, 2022 9:57 AM > To: Pavan Nikhilesh > Cc: dev@dpdk.org; Jerin Jacob ; Ray Kinsella > ; Jerin Jacob ; Jayatheerthan, Jay > ; Carrillo, Erik G ; > Gujjar, Abhinandan S ; McDaniel, Timothy > ; hemant.agra...@nxp.com; Va

Re: [PATCH] doc: announce some raw/ifpga API removal

2022-07-12 Thread Maxime Coquelin
On 6/30/22 11:41, David Marchand wrote: rte_pmd_ifpga_get_pci_bus() documentation is vague and it is unclear what could be done with it. On the other hand, EAL provides a standard API to retrieve a bus object by name. Announce removal of this driver specific API for v22.11. Signed-off-by: Da

RE: [EXT] Re: [PATCH v2 1/1] doc: announce addition of new ipsec event subtypes

2022-07-12 Thread Akhil Goyal
> 27/06/2022 07:29, Vamsi Attunuru: > > New event subtypes need to be added for notifying expiry events > > upon reaching IPsec SA soft packet expiry and hard packet/byte > > expiry limits. This would be added in DPDK 22.11. > > > > Signed-off-by: Vamsi Attunuru > > Acked-by: Akhil Goyal > > ---

Re: [PATCH v2] doc: add event timer expiry drop stat

2022-07-12 Thread Hemant Agrawal
On 7/12/2022 5:22 PM, Jerin Jacob wrote: On Tue, Jun 28, 2022 at 8:38 AM Naga Harish K S V wrote: The structure ``rte_event_timer_adapter_stats`` will be extended by adding a new field, ``evtim_drop_count``. This stat will represent the number of times an event_timer expiry event is dropped b

Re: [PATCH] doc: add event timer expiry drop stat

2022-07-12 Thread Hemant Agrawal
On 7/11/2022 8:25 PM, Jerin Jacob wrote: On Fri, Jul 1, 2022 at 12:43 AM Carrillo, Erik G wrote: -Original Message- From: Naga Harish K, S V Sent: Monday, June 27, 2022 10:40 AM To: m...@ashroe.eu; jer...@marvell.com; pbhagavat...@marvell.com; sthot...@marvell.com; Carrillo, Erik G

Re: [PATCH v2 1/1] doc: announce addition of new ipsec event subtypes

2022-07-12 Thread Thomas Monjalon
27/06/2022 07:29, Vamsi Attunuru: > New event subtypes need to be added for notifying expiry events > upon reaching IPsec SA soft packet expiry and hard packet/byte > expiry limits. This would be added in DPDK 22.11. > > Signed-off-by: Vamsi Attunuru > Acked-by: Akhil Goyal > --- > More details

Re: [PATCH 1/2] doc: add enqueue depth for new event type

2022-07-12 Thread Thomas Monjalon
I'm not your teacher, but please consider Cc'ing people outside of your company. 27/06/2022 11:57, pbhagavat...@marvell.com: > From: Pavan Nikhilesh > > A new field ``max_event_port_enqueue_new_burst`` will be added to the > structure ``rte_event_dev_info``. The field defines the max enqueue >

Re: [PATCH] doc: announce changes to event vector structure

2022-07-12 Thread Thomas Monjalon
Tip to get more reviews: add interested maintainers in Cc. Adding Jay, Erik, Abhinandan, Timothy, Hemant, Harry, Mattias and Liang. 11/07/2022 16:56, Jerin Jacob: > On Tue, Jun 28, 2022 at 5:01 PM wrote: > > > > From: Pavan Nikhilesh > > > > The structure ``rte_event_vector`` will be modified t

Re: [PATCH] doc: notice to deprecate DPAA2 cmdif raw driver

2022-07-12 Thread Bruce Richardson
On Tue, Jul 12, 2022 at 04:29:23PM +0200, Thomas Monjalon wrote: > 29/06/2022 08:23, Hemant Agrawal: > > Acked-by: Hemant Agrawal > > Beware Hemant you introduce double spaces in your ack. > > > > On 6/29/2022 10:08 AM, Gagandeep Singh wrote: > > > dpaa2_cmdif raw driver is no longer in use, s

Re: [PATCH] doc: notice to deprecate DPAA2 cmdif raw driver

2022-07-12 Thread Thomas Monjalon
29/06/2022 08:23, Hemant Agrawal: > Acked-by: Hemant Agrawal Beware Hemant you introduce double spaces in your ack. > On 6/29/2022 10:08 AM, Gagandeep Singh wrote: > > dpaa2_cmdif raw driver is no longer in use, so it > > will be removed in v22.11 > > > > Signed-off-by: Gagandeep Singh [...]

Re: [PATCH] doc: announce some raw/ifpga API removal

2022-07-12 Thread Thomas Monjalon
30/06/2022 11:41, David Marchand: > rte_pmd_ifpga_get_pci_bus() documentation is vague and it is unclear > what could be done with it. > On the other hand, EAL provides a standard API to retrieve a bus object > by name. > > Announce removal of this driver specific API for v22.11. > > Signed-off-b

Re: [PATCH] doc: add deprecation notice for kni example

2022-07-12 Thread Thomas Monjalon
30/06/2022 18:50, Bruce Richardson: > +* examples/kni: The ``kni`` kernel module and library are not recommended > for use by new applications - > + other technologies such as virtio-user are recommended instead. > + Because of this, the example application for kni is deprecated and will be > r

Re: [PATCH] doc: announce rename of octeontx_ep driver

2022-07-12 Thread Thomas Monjalon
30/06/2022 20:55, Veerasenareddy Burru: > To enable single unified driver to support current OcteonTx and > future Octeon PCI endpoint NICs, octeontx_ep driver is renamed to > octeon_ep to reflect common driver for all Octeon based > PCI endpoint NICs. > > Signed-off-by: Veerasenareddy Burru > --

Re: [PATCH v3] doc: announce change in event queue conf structure

2022-07-12 Thread Jerin Jacob
On Sun, May 15, 2022 at 3:56 PM Shijith Thotton wrote: > > Structure rte_event_queue_conf will be extended to include fields to > support weight and affinity attribute. Once it gets added in DPDK 22.11, > eventdev internal op, queue_attr_get can be removed. > > Signed-off-by: Shijith Thotton Ac

Re: [EXT] Re: [PATCH] doc: announce changes to rte_eth_set_queue_rate_limit api

2022-07-12 Thread Thomas Monjalon
07/07/2022 15:38, Satha Koteswara Rao Kottidi: > From: Andrew Rybchenko > > On 7/1/22 18:32, skotesh...@marvell.com wrote: > > > +* ethdev: The function ``rte_eth_set_queue_rate_limit`` takes ``rate`` > > > in Mbps. + This parameter declared as uint16_t, queue rate limited to > > > 64Gbps. +``ra

Re: [PATCH v1 00/10] baseband/acc200

2022-07-12 Thread Maxime Coquelin
Hi Nicolas, Hernan, (Adding Hernan in the recipients list) On 7/8/22 02:01, Nicolas Chautru wrote: This is targeting 22.11 and includes the PMD for the integrated accelerator on Intel Xeon SPR-EEC. There is a dependency on that parallel serie still in-flight which extends the bbdev api https:/

[PATCH v2] doc: announce transition to vDPA device name function

2022-07-12 Thread Thomas Monjalon
There is a layer violation in the vDPA API for getting the device name. Instead of providing the name at vDPA level, a function returns the low-level device object. The plan is to introduce a new function in 22.11, promote in 23.07, and remove rte_vdpa_get_rte_device() in 23.11. Signed-off-by: Tho

Re: DPDK 19.11.3 with multi processes and external physical memory: unable to receive traffic in the secondary processes

2022-07-12 Thread Burakov, Anatoly
Hi Asaf, On 12-Jul-22 7:05 AM, Asaf Sinai wrote: Hi, We run DPDK 19.11.3 with multi processes. When using external memory for DPDK (instead of huge pages), we are unable to receive traffic in the secondary processes. * We have external physical memory regions (excluded from Linux): /[ULP

RE: [EXT] Re: [PATCH] doc: announce changes to rte_eth_set_queue_rate_limit api

2022-07-12 Thread Satha Koteswara Rao Kottidi
Hi Andrew, Are you convinced with my response, or you want me to change this field to uint32_t? Thanks, Satha. -Original Message- From: Satha Koteswara Rao Kottidi Sent: Thursday, July 7, 2022 7:09 PM To: Andrew Rybchenko ; Ray Kinsella Cc: dev@dpdk.org Subject: RE: [EXT] Re: [PATCH

Re: [PATCH] doc: announce transition to vDPA port close function

2022-07-12 Thread Maxime Coquelin
On 7/12/22 14:28, Thomas Monjalon wrote: 12/07/2022 14:26, Thomas Monjalon: 12/07/2022 11:16, Maxime Coquelin: On 5/18/21 09:34, Thomas Monjalon wrote: There is a layer violation in the vDPA API which encourages to destroy a full device with rte_dev_remove() instead of just closing the por

Re: [PATCH] doc: announce transition to vDPA port close function

2022-07-12 Thread Thomas Monjalon
12/07/2022 14:26, Thomas Monjalon: > 12/07/2022 11:16, Maxime Coquelin: > > > > On 5/18/21 09:34, Thomas Monjalon wrote: > > > There is a layer violation in the vDPA API which encourages to destroy > > > a full device with rte_dev_remove() instead of just closing the port. > > > The plan is to int

Re: [PATCH] doc: announce transition to vDPA port close function

2022-07-12 Thread Thomas Monjalon
12/07/2022 11:16, Maxime Coquelin: > > On 5/18/21 09:34, Thomas Monjalon wrote: > > There is a layer violation in the vDPA API which encourages to destroy > > a full device with rte_dev_remove() instead of just closing the port. > > The plan is to introduce a new function in 21.08, promote in 21.1

RE: [PATCH] doc: announce change to cryptodev cb function prototype

2022-07-12 Thread Hemant Agrawal
Acked-by: Hemant Agrawal

RE: [PATCH] doc: announce change to cryptodev cb function prototype

2022-07-12 Thread Akhil Goyal
Hi Hemant, Can you please ack this deprecation notice? > Subject: [PATCH] doc: announce change to cryptodev cb function prototype > > Function rte_cryptodev_cb_fn prototype will be extended to > add new parameter qp_id, to return queue pair ID, which got > error interrupt to the application, so

Re: [PATCH v2] doc: add event timer expiry drop stat

2022-07-12 Thread Jerin Jacob
On Tue, Jun 28, 2022 at 8:38 AM Naga Harish K S V wrote: > > The structure ``rte_event_timer_adapter_stats`` will be > extended by adding a new field, ``evtim_drop_count``. This stat > will represent the number of times an event_timer expiry event > is dropped by the event timer adapter. > > Signe

Re: [PATCH] doc: add deprecation notice for kni example

2022-07-12 Thread Jerin Jacob
On Fri, Jul 1, 2022 at 1:48 PM David Marchand wrote: > > On Thu, Jun 30, 2022 at 6:50 PM Bruce Richardson > wrote: > > > > As agreed by DPDK Technical Board, the KNI example app is due to be > > removed from the repository to discourage use in future projects, given > > that better alternatives e

Re: [PATCH v2 1/1] doc: announce addition of new ipsec event subtypes

2022-07-12 Thread Andrew Rybchenko
On 7/11/22 17:53, Jerin Jacob wrote: On Wed, Jul 6, 2022 at 3:19 PM Zhang, Roy Fan wrote: -Original Message- From: Vamsi Attunuru Sent: Monday, June 27, 2022 6:30 AM To: dev@dpdk.org Cc: jer...@marvell.com; vattun...@marvell.com; gak...@marvell.com; ferruh.yi...@intel.com; tho...@mon

Re: [PATCH] doc: announce header split deprecation

2022-07-12 Thread Andrew Rybchenko
On 5/24/22 17:58, Ray Kinsella wrote: xuan.d...@intel.com writes: From: Xuan Ding RTE_ETH_RX_OFFLOAD_HEADER_SPLIT offload was introduced some time ago to substitute bit-field header_split in struct rte_eth_rxmode. It allows to enable header split offload with the header size controlled using

Re: [PATCH] doc: announce marking device and driver objects as internal

2022-07-12 Thread Andrew Rybchenko
On 7/12/22 11:24, Kevin Laatz wrote: On 10/07/2022 07:17, David Marchand wrote: rte_driver and rte_device are unnecessarily exposed in the public API/ABI. Announce that they will be made opaque in the public API and mark associated API as internal. This impacts all bus, as their driver registra

RE: [PATCH] vhost: fix missing copy length in batched copies

2022-07-12 Thread Xia, Chenbo
> -Original Message- > From: Maxime Coquelin > Sent: Tuesday, July 12, 2022 6:10 PM > To: dev@dpdk.org; Xia, Chenbo ; Jiang, YuX > ; tho...@monjalon.net; david.march...@redhat.com > Subject: Re: [PATCH] vhost: fix missing copy length in batched copies > > > > On 7/12/22 12:04, Maxime Co

Re: [PATCH] vhost: fix missing copy length in batched copies

2022-07-12 Thread Maxime Coquelin
On 7/12/22 12:04, Maxime Coquelin wrote: This patch fixes missing the assignement of the copy length s/assignement/assignment/ If this is the only change requested, could it be fixed while applying, or should I send a v2? Thanks, Maxime when doing batched copies in the sync dequeue path.

[PATCH] vhost: fix missing copy length in batched copies

2022-07-12 Thread Maxime Coquelin
This patch fixes missing the assignement of the copy length when doing batched copies in the sync dequeue path. Fixes: cd79d1b030bd ("vhost: fix unnecessary dirty page logging") Suggested-by: Chenbo Xia Signed-off-by: Maxime Coquelin --- lib/vhost/virtio_net.c | 2 +- 1 file changed, 1 inserti

RE: release candidate 22.07-rc4

2022-07-12 Thread Xia, Chenbo
> -Original Message- > From: Jiang, YuX > Sent: Tuesday, July 12, 2022 5:33 PM > To: Thomas Monjalon ; dev (dev@dpdk.org) > > Cc: Devlin, Michelle ; Mcnamara, John > ; Ferruh Yigit ; Xia, > Chenbo > Subject: RE: release candidate 22.07-rc4 > > > -Original Message- > > From: Thom

RE: release candidate 22.07-rc4

2022-07-12 Thread Jiang, YuX
> -Original Message- > From: Thomas Monjalon > Sent: Tuesday, July 12, 2022 6:37 AM > To: annou...@dpdk.org > Subject: release candidate 22.07-rc4 > > A new DPDK release candidate is ready for testing: > https://git.dpdk.org/dpdk/tag/?id=v22.07-rc4 > > There are 22 new patches in thi

Re: [PATCH] doc: announce transition to vDPA port close function

2022-07-12 Thread Maxime Coquelin
On 5/18/21 09:34, Thomas Monjalon wrote: There is a layer violation in the vDPA API which encourages to destroy a full device with rte_dev_remove() instead of just closing the port. The plan is to introduce a new function in 21.08, promote in 21.11, and deprecate rte_vdpa_get_rte_device() in 2

[PATCH v3] doc: add deprecation for restrictions in telemetry naming

2022-07-12 Thread Bruce Richardson
Following discussion on-list [1], we will look to limited the allowed characters in names for items in telemetry. This will simplify the escaping needed for json output, or any future output formats. The lists will initially be minimal, since expansion to allow more characters can be done without a

[PATCH v2] doc: add deprecation for restrictions in telemetry naming

2022-07-12 Thread Bruce Richardson
Following discussion on-list [1], we will look to limited the allowed characters in names for items in telemetry. This will simplify the escaping needed for json output, or any future output formats. The lists will initially be minimal, since expansion to allow more characters can be done without a

Re: [PATCH] doc: announce marking device and driver objects as internal

2022-07-12 Thread Kevin Laatz
On 10/07/2022 07:17, David Marchand wrote: rte_driver and rte_device are unnecessarily exposed in the public API/ABI. Announce that they will be made opaque in the public API and mark associated API as internal. This impacts all bus, as their driver registration mechanism will be made internal.