[Bug 1009] [dpdk-22.07*] drivers/crypto/qat meson build failed with gcc 11.2.0 on Ub22.04/64

2022-06-07 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1009 gaodaxue (daxuex@intel.com) changed: What|Removed |Added Resolution|--- |FIXED Status|UNCONF

RE: [PATCH v4] eventdev: add adapter instance get API

2022-06-07 Thread Naga Harish K, S V
Hi Ganapati, Some comments inline. > -Original Message- > From: Ganapati Kundapura > Sent: Tuesday, June 7, 2022 8:43 PM > To: jerinjac...@gmail.com; dev@dpdk.org; Jayatheerthan, Jay > > Subject: [PATCH v4] eventdev: add adapter instance get API > > Added rte_event_eth_rx_adapter_ins

RE: [PATCH] build: fix meson build when gcc >= 10.0

2022-06-07 Thread Wu, WenxuanX
Hi Thomas, > -Original Message- > From: Thomas Monjalon > Sent: 2022年6月7日 18:53 > To: Wu, WenxuanX > Cc: Richardson, Bruce ; dev@dpdk.org; > sta...@dpdk.org; david.march...@redhat.com > Subject: Re: [PATCH] build: fix meson build when gcc >= 10.0 > > 07/06/2022 04:56, wenxuanx...@intel.

[Bug 1028] [dpdk-22.07] dynamic_queue/txq_setup: after set “port 0 txq 1 stop”, this stopped queue not display transmits 255 packets

2022-06-07 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1028 Bug ID: 1028 Summary: [dpdk-22.07] dynamic_queue/txq_setup: after set “port 0 txq 1 stop”, this stopped queue not display transmits 255 packets Product: DPDK Version: uns

[PATCH] net/ice: fix race condition for multi-cores

2022-06-07 Thread Simei Su
In multi-cores cases for Rx timestamp offload, to avoid phc time being frequently overwritten, move related variables from ice_adapter to ice_rx_queue structure, and each queue will handle timestamp calculation by itself. Fixes: 953e74e6b73a ("net/ice: enable Rx timestamp on flex descriptor") Fixe

[PATCH v5] net/ice: add retry mechanism for DCF after failure

2022-06-07 Thread peng1x . zhang
From: Peng Zhang The origin design is if error happen during the step 3 of given situation, it will return error directly without retry. While in current patch, it will retry at every interval time during certain time. If retry succeed, rule can be continuously created. The given situation as

Re: [PATCH 4/4] doc: update instructions for running as non-root for MLX5

2022-06-07 Thread Stephen Hemminger
On Wed, 8 Jun 2022 02:49:49 +0300 Dmitry Kozlyuk wrote: > Reference the common guide for generic setup. > Remove excessive capabilities from the recommended list. > > Cc: sta...@dpdk.org > > Signed-off-by: Dmitry Kozlyuk > --- > doc/guides/platform/mlx5.rst | 22 ++ > 1 fi

Re: [PATCH 3/4] doc: give specific instructions for running as non-root

2022-06-07 Thread Stephen Hemminger
On Wed, 8 Jun 2022 02:49:48 +0300 Dmitry Kozlyuk wrote: > The guide to run DPDK applications as non-root in Linux > did not provide specific instructions to configure the required access > and did not explain why each bit is needed. > The latter is important because running as non-root > is one o

Re: [PATCH 2/4] usertools: add option to change mount point owner

2022-06-07 Thread Stephen Hemminger
On Wed, 8 Jun 2022 02:49:47 +0300 Dmitry Kozlyuk wrote: > > -def mount_huge(pagesize, mountpoint): > +def mount_huge(pagesize, mountpoint, owner): > '''Mount the huge TLB file system''' > if mountpoint in get_mountpoints(): > print(mountpoint, "already mounted") > @@ -180,6 +

[PATCH 3/4] doc: give specific instructions for running as non-root

2022-06-07 Thread Dmitry Kozlyuk
The guide to run DPDK applications as non-root in Linux did not provide specific instructions to configure the required access and did not explain why each bit is needed. The latter is important because running as non-root is one of the ways to tighten security and grant minimal permissions. Cc: s

[PATCH 4/4] doc: update instructions for running as non-root for MLX5

2022-06-07 Thread Dmitry Kozlyuk
Reference the common guide for generic setup. Remove excessive capabilities from the recommended list. Cc: sta...@dpdk.org Signed-off-by: Dmitry Kozlyuk --- doc/guides/platform/mlx5.rst | 22 ++ 1 file changed, 10 insertions(+), 12 deletions(-) diff --git a/doc/guides/platf

[PATCH 2/4] usertools: add option to change mount point owner

2022-06-07 Thread Dmitry Kozlyuk
Per mount(8), the previous owner and mode of the mount point become invisible as long as this filesystem remains mounted. Because dpdk-hugepages.py must be run as root, the new owner would be root. This is undesirable if the hugepage directory is being set up by the administrator for an unprivilege

[PATCH 1/4] usertools: add option to select hugetlbfs directory

2022-06-07 Thread Dmitry Kozlyuk
dpdk-hugepages.py had /dev/hugepages hardcoded as the mount point. It may be desirable to setup hugepage directory at another path, for example, when using hugepages of multiple sizes in different directories or when granting different permissions to mount points. Add --directory/-d option to the s

[PATCH 0/4] Improve documentation for running as non-root

2022-06-07 Thread Dmitry Kozlyuk
Dmitry Kozlyuk (4): usertools: add option to select hugetlbfs directory usertools: add option to change mount point owner doc: give specific instructions for running as non-root doc: update instructions for running as non-root for MLX5 doc/guides/linux_gsg/enable_func.rst | 53 ++

[PATCH v4 7/7] net/ark: add PMD support for devices as virtual functions

2022-06-07 Thread Ed Czeck
Add capabilities field isvf to dev struct Disable configuration calls as required by vf Signed-off-by: Ed Czeck --- v2: feature Arkville vf support in release notes v3: feature new PCI device ids in release notes v4: split release note --- doc/guides/rel_notes/release_22_07.rst | 2 + drivers/

[PATCH v4 6/7] net/ark: add new devices to support list

2022-06-07 Thread Ed Czeck
update device list is doc Signed-off-by: Ed Czeck --- v3: clarification in doc for LTS support v4: mention nee devices in release notes --- doc/guides/nics/ark.rst| 4 +++- doc/guides/rel_notes/release_22_07.rst | 2 ++ drivers/net/ark/ark_ethdev.c | 6 ++ 3 files

[PATCH v4 5/7] net/ark: report additional errors from firmware

2022-06-07 Thread Ed Czeck
detect and report completion errors from firmware Signed-off-by: Ed Czeck --- drivers/net/ark/ark_rqp.c | 6 -- drivers/net/ark/ark_rqp.h | 3 ++- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/net/ark/ark_rqp.c b/drivers/net/ark/ark_rqp.c index ef9ccd0706..efb9730fe6

[PATCH v4 4/7] net/ark: update UDM functions for firmware update

2022-06-07 Thread Ed Czeck
new firmware version for UDM (Upstream Data Mover) remove device-level start, stop, and reset operations add queue-based start, stop and reset as required by firmware remove performance structs as they are not in the firmware module Signed-off-by: Ed Czeck --- v2: reword commit message v3: inclu

[PATCH v4 3/7] net/ark: update DDM functions for firmware update

2022-06-07 Thread Ed Czeck
new firmware version for DDM (Downstream Data Mover) remove device-level start, stop, and reset operations add queue-based start, stop and reset as required by firmware Signed-off-by: Ed Czeck --- v2: reword commit message --- drivers/net/ark/ark_ddm.c | 80 +-

[PATCH v4 2/7] net/ark: update MPU functions for firmware update

2022-06-07 Thread Ed Czeck
new firmware version for MPU (Mbuf Prefetch Unit) remove device-level global operations remove ark_mpu_reset_stats function Signed-off-by: Ed Czeck --- v2: - document version compatibility between firmware and DPDK - reword commit message v4: - clarify version compatibility note - firmware chang

[PATCH v4 1/7] devtools: add Atomic Rules acronyms for commit checks

2022-06-07 Thread Ed Czeck
DDM -> Downstream Data Mover MPU -> Mbuf Prefetch Unit UDM -> Upstream Data Mover Signed-off-by: Ed Czeck --- devtools/words-case.txt | 3 +++ 1 file changed, 3 insertions(+) diff --git a/devtools/words-case.txt b/devtools/words-case.txt index 2f1753bdc8..53e029a958 100644 --- a/devtools/words-

Re: [PATCH] eal: remove unused arch specific headers for locks

2022-06-07 Thread Stephen Hemminger
On Tue, 7 Jun 2022 21:03:08 +0200 David Marchand wrote: > MCS lock, PF lock and Ticket lock have no arch specific implementation, > there is no need for the extra redirection in headers. > > Signed-off-by: David Marchand > --- > Note: this was mentionned during the seqlock patch review, and I

[PATCH] eal: remove unused arch specific headers for locks

2022-06-07 Thread David Marchand
MCS lock, PF lock and Ticket lock have no arch specific implementation, there is no need for the extra redirection in headers. Signed-off-by: David Marchand --- Note: this was mentionned during the seqlock patch review, and I spotted it again, while reviewing the RISC-V port, and I see the same f

Re: [PATCH 0/4] net/ena: v2.7.0 driver release

2022-06-07 Thread Ferruh Yigit
On 6/7/2022 5:43 PM, Michal Krawczyk wrote: Hi, this patchset contains 1 generic feature support (fast mbuf free), one improvement (simplification of the MTU verification), and 1 new device argument which enhances the ENA user's experience by allowing them to disable the LLQ (Low Latency Queue)

Re: [PATCH 1/2] bus/pci: fix a segfault when call callback

2022-06-07 Thread Thomas Monjalon
21/05/2022 09:05, Min Hu (Connor): > From: Huisong Li > > After the driver probe is executed, the callback in application will > be called. The callback in application may call some APIs which access the What is the "callback in application" ? Do you mean the callback on probing event like RTE_E

[RFC 8/8] ip_frag: fix gcc-12 warnings

2022-06-07 Thread Stephen Hemminger
The function rte_memcpy can derference past source buffer which will cause array out of bounds warnings. But there is no good reason to use rte_memcpy instead of memcpy in this code. Memcpy is just as fast for these small inputs, and compiler will optimize. Signed-off-by: Stephen Hemminger --- l

[RFC 7/8] vhost: replace rte_memcpy to fix warning

2022-06-07 Thread Stephen Hemminger
Using rte_memcpy is not needed here. Just use memcpy() which is safer and just as fast for this non-critical place. Signed-off-by: Stephen Hemminger --- lib/vhost/vhost_crypto.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/vhost/vhost_crypto.c b/lib/vhost/vhost_crypto.

[RFC 6/8] net/enetfc: fix array out of bounds warning

2022-06-07 Thread Stephen Hemminger
With gcc-12 it detects that this function could be passed a queue > 1 which would cause out of bounds access. Signed-off-by: Stephen Hemminger --- drivers/net/enetfec/enet_ethdev.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/net/enetfec/enet_ethdev.c b/drivers/net/enetfec/e

[RFC 3/8] net/ice: fix rte_memcpy warnings with gcc-12

2022-06-07 Thread Stephen Hemminger
There is no good reason to always use rte_memcpy. Regular memcpy is as fast or faster for small values and safer since it won't reference past end of input. Also static analysis tools know about regular memcpy and can analyze better. Signed-off-by: Stephen Hemminger --- drivers/net/ice/base/ice_

[RFC 5/8] test/ipsec: fix gcc-12 rte_memcpy warnings

2022-06-07 Thread Stephen Hemminger
It is not necessary to use rte_memcpy here, and it can cause warnings when gcc-12 detects that rte_memcpy will derference past input data. Signed-off-by: Stephen Hemminger --- app/test/test_ipsec.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/app/test/test_ip

[RFC 4/8] test/ipfrag: fix gcc-12 warnings

2022-06-07 Thread Stephen Hemminger
Using rte_memcpy is not necessary here. It also causes warnings from derefencing past end of input. Signed-off-by: Stephen Hemminger --- app/test/test_ipfrag.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/app/test/test_ipfrag.c b/app/test/test_ipfrag.c index

[RFC 2/8] net/qede: fix gcc-12 rte_memcpy warnings

2022-06-07 Thread Stephen Hemminger
The x86 version of rte_memcpy can cause warnings. The driver does not need to use rte_memcpy for everything. Standard memcpy is just as fast and safer; the compiler and static analysis tools treat memcpy specially. Signed-off-by: Stephen Hemminger --- drivers/net/qede/base/bcm_osal.h | 3 +-- d

[RFC 1/8] net/ena: fix warnings related to rte_memcpy and gcc-12

2022-06-07 Thread Stephen Hemminger
Rte_memcpy is not needed for small objects only used on control path. Regular memcpy is as fast or faster and there is more robust since static analysis etc knows what it does. In this driver it was redefining all memcpy as rte_memcpy which is even worse. Signed-off-by: Stephen Hemminger --- dr

[RFC 0/8] Gcc-12 warning fixes

2022-06-07 Thread Stephen Hemminger
Ths is early proposal on how to address some of the gcc-12 warnings. Most of these are related to rte_memcpy which can simply be addressed by using regular memcpy instead. Stephen Hemminger (8): net/ena: fix warnings related to rte_memcpy and gcc-12 net/qede: fix gcc-12 rte_memcpy warnings n

Re: [PATCH] common/cnxk: allow building generic arm64 target for cn9k/cn10k

2022-06-07 Thread Thomas Monjalon
04/06/2022 18:31, Tomasz Duszynski: > Allow building generic arm64 target using config/arm/arm64_armv8_linux_* > config which works on both cn9k and cn10k by relaxing cache line size > requirements a bit. > > While at it move cache line checks to common place. > > Signed-off-by: Tomasz Duszynski

Re: [EXT] Re: [PATCH] drivers: rename octeon ep PMD

2022-06-07 Thread Thomas Monjalon
07/06/2022 18:18, Veerasenareddy Burru: > From: Thomas Monjalon > > 07/06/2022 16:38, Ray Kinsella: > > > Sathesh B Edara writes: > > > > > > > This patch renames octeon end point driver from octeontx_ep to > > > > octeon_ep > > > > > > > > Signed-off-by: Sathesh B Edara > > > > > > Straight for

Re: [PATCH] maintainers: update for nxp devices

2022-06-07 Thread Thomas Monjalon
> > From: Nipun Gupta > > > > Update and add maintainers for NXP devices and RAW device API > > > > Signed-off-by: Nipun Gupta > Acked-by: Hemant Agrawal Applied

[PATCH 4/4] net/ena: update version to 2.7.0

2022-06-07 Thread Michal Krawczyk
This release contains changes listed below. - Fast mbuf free feature support. - Device argument to disable the LLQ. - Simplification of the MTU verification. Signed-off-by: Michal Krawczyk --- drivers/net/ena/ena_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a

[PATCH 3/4] net/ena: add an option to disable LLQ

2022-06-07 Thread Michal Krawczyk
The PMD attempts to enable the LLQ (Low Latency Queue) whenever it's possible. The LLQ requires the user to enable the Write Combining for the supported igb_uio/vfio-pci modules. The vfio-pci module officially doesn't support the WC. Moreover, in some Linux distributions, it can be built into the

[PATCH 2/4] net/ena: skip MTU verification

2022-06-07 Thread Michal Krawczyk
From: Dawid Gorecki Remove MTU verification from ena_mtu_set() and ena_start(). It is done by rte_ethdev already, so there is no reason to repeat it inside the ENA driver. Signed-off-by: Dawid Gorecki Reviewed-by: Michal Krawczyk Reviewed-by: Shai Brandes Reviewed-by: Amit Bernstein --- dri

[PATCH 1/4] net/ena: add fast mbuf free support

2022-06-07 Thread Michal Krawczyk
From: Dawid Gorecki Add support for RTE_ETH_TX_OFFLOAD_MBUF_FAST_FREE offload. It can be enabled if all the mbufs for a given queue belong to the same mempool and their reference count is equal to 1. Signed-off-by: Dawid Gorecki Reviewed-by: Michal Krawczyk Reviewed-by: Shai Brandes Reviewed-

[PATCH 0/4] net/ena: v2.7.0 driver release

2022-06-07 Thread Michal Krawczyk
Hi, this patchset contains 1 generic feature support (fast mbuf free), one improvement (simplification of the MTU verification), and 1 new device argument which enhances the ENA user's experience by allowing them to disable the LLQ (Low Latency Queue) mode. Thanks, Michal Dawid Gorecki (2): ne

Re: [PATCH v1] bbdev: add device status info

2022-06-07 Thread Stephen Hemminger
On Tue, 7 Jun 2022 18:20:38 +0200 Maxime Coquelin wrote: > Hi Nicolas, > > On 6/7/22 17:44, Chautru, Nicolas wrote: > > Hi Maxime, > > > >> -Original Message- > >> From: Maxime Coquelin > >> Sent: Tuesday, June 7, 2022 5:43 AM > >> To: Stephen Hemminger ; Chautru, Nicolas > >> > >>

Re: [PATCH] app/test: update skipped count when setup returns skipped

2022-06-07 Thread Thomas Monjalon
25/05/2022 08:10, Akhil Goyal: > > Subject: [PATCH] app/test: update skipped count when setup returns skipped > > > > If the setup function returns TEST_SKIPPED, the logs would say the test > > case is skipped while the summary count would consider it under failed > > cases. Address this by counti

[BUG] out of bounds reference in crypto snow3g driver.

2022-06-07 Thread Stephen Hemminger
Gcc-12 finds a bug in crypto_ipsec_mb_pmd_snow3g. The code here is trying to be clever and put the crypto operations into a ring. But if there are multiple operations in will dereference outside of the valid ops. The offending line is here: enqueued_op = rte_ring_enqueue_burst(qp->ingre

Re: [PATCH v1] bbdev: add device status info

2022-06-07 Thread Maxime Coquelin
Hi Nicolas, On 6/7/22 17:44, Chautru, Nicolas wrote: Hi Maxime, -Original Message- From: Maxime Coquelin Sent: Tuesday, June 7, 2022 5:43 AM To: Stephen Hemminger ; Chautru, Nicolas Cc: dev@dpdk.org; gak...@marvell.com; t...@redhat.com; hemant.agra...@nxp.com; Vargas, Hernan Subject

Re: [PATCH v3] build: add definitions for use as meson subproject

2022-06-07 Thread Thomas Monjalon
21/05/2022 02:54, Ben Magistro: > Currently utilizing this in an upcoming set of changes for TLDK and all > seems to be working for fallback dependency support under both shared and > static linkage. > > Reviewed-by: Ben Magistro > Tested-by: Ben Magistro > > On Fri, May 6, 2022 at 10:43 AM Bru

[PATCH v3 7/7] net/ark: add PMD support for devices as virtual functions

2022-06-07 Thread Ed Czeck
Add capabilities field isvf to dev struct Disable configuration calls as required by vf Signed-off-by: Ed Czeck --- v2: feature Arkville vf support in release notes v3: feature new PCI device ids in release notes --- doc/guides/rel_notes/release_22_07.rst | 5 ++ drivers/net/ark/ark_ethdev.c

[PATCH v3 6/7] net/ark: add new devices to support list

2022-06-07 Thread Ed Czeck
update device list is doc Signed-off-by: Ed Czeck --- v3: clarification in doc for LTS support --- doc/guides/nics/ark.rst | 7 +-- drivers/net/ark/ark_ethdev.c | 6 ++ 2 files changed, 11 insertions(+), 2 deletions(-) diff --git a/doc/guides/nics/ark.rst b/doc/guides/nics/ark.rst

[PATCH v3 5/7] net/ark: report additional errors from firmware

2022-06-07 Thread Ed Czeck
detect and report completion errors from firmware Signed-off-by: Ed Czeck --- drivers/net/ark/ark_rqp.c | 6 -- drivers/net/ark/ark_rqp.h | 3 ++- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/net/ark/ark_rqp.c b/drivers/net/ark/ark_rqp.c index ef9ccd0706..efb9730fe6

[PATCH v3 4/7] net/ark: update UDM functions for firmware update

2022-06-07 Thread Ed Czeck
new firmware version for UDM (Upstream Data Mover) remove device-level start, stop, and reset operations add queue-based start, stop and reset as required by firmware remove performance structs as they are not in the firmware module Signed-off-by: Ed Czeck --- v2: reword commit message v3: inclu

[PATCH v3 3/7] net/ark: update DDM functions for firmware update

2022-06-07 Thread Ed Czeck
new firmware version for DDM (Downstream Data Mover) remove device-level start, stop, and reset operations add queue-based start, stop and reset as required by firmware Signed-off-by: Ed Czeck --- v2: reword commit message --- drivers/net/ark/ark_ddm.c | 80 +-

[PATCH v3 2/7] net/ark: update MPU functions for firmware update

2022-06-07 Thread Ed Czeck
new firmware version for MPU (Mbuf Prefetch Unit) remove device-level global operations remove ark_mpu_reset_stats function Signed-off-by: Ed Czeck --- v2: - document version compatibility between firmware and DPDK - reword commit message --- doc/guides/nics/ark.rst | 15 +++

[PATCH v3 1/7] devtools: add Atomic Rules acronyms for commit checks

2022-06-07 Thread Ed Czeck
DDM -> Downstream Data Mover MPU -> Mbuf Prefetch Unit UDM -> Upstream Data Mover Signed-off-by: Ed Czeck --- devtools/words-case.txt | 3 +++ 1 file changed, 3 insertions(+) diff --git a/devtools/words-case.txt b/devtools/words-case.txt index bc33470532..fa92ab273e 100644 --- a/devtools/words-

Re: [PATCH V3 app/testpmd 4/4] app/testpmd: remove duplicated flow type to string table

2022-06-07 Thread Ferruh Yigit
On 6/7/2022 9:32 AM, Huisong Li wrote: From: Ferruh Yigit Flow type table has two instance, one is used for flow type to string conversion, and other is used for string to flow type conversion. And tables are diverged by time. Unifying tables to prevent maintaining two different tables. Not

Re: [PATCH V3 app/testpmd 3/4] app/testpmd: compact RSS types output in some commands

2022-06-07 Thread Ferruh Yigit
On 6/7/2022 9:32 AM, Huisong Li wrote: From: Ferruh Yigit In port info command output, 'show port info all', supported RSS offload types printed one type per line, and although this information is not most important part of the command it takes big part of the command output. In port RSS has

Re: [PATCH V3 app/testpmd 2/4] app/testpmd: unify RSS types display and obtaination

2022-06-07 Thread Ferruh Yigit
On 6/7/2022 9:32 AM, Huisong Li wrote: The 'rss_type_table[]' maintains string name and value of RSS types. This patch unifies a common interface to display or obtain RSS types. Signed-off-by: Huisong Li Signed-off-by: Ferruh Yigit <...> @@ -5669,6 +5681,7 @@ set_record_burst_stats(uint8

Re: [PATCH V3 app/testpmd 1/4] app/testpmd: fix supported RSS offload display

2022-06-07 Thread Ferruh Yigit
On 6/7/2022 9:32 AM, Huisong Li wrote: And rte_eth_dev_info.flow_type_rss_offloads is populated in terms of RTE_ETH_RSS_* bits. If PMD sets RTE_ETH_RSS_L3_SRC_ONLY to dev_info->flow_type_rss_offloads. testpmd will display "user defined 63" when run 'show port info 0'. Because testpmd use flowty

RE: [PATCH v1] bbdev: add device status info

2022-06-07 Thread Chautru, Nicolas
Hi Maxime, > -Original Message- > From: Maxime Coquelin > Sent: Tuesday, June 7, 2022 5:43 AM > To: Stephen Hemminger ; Chautru, Nicolas > > Cc: dev@dpdk.org; gak...@marvell.com; t...@redhat.com; > hemant.agra...@nxp.com; Vargas, Hernan > Subject: Re: [PATCH v1] bbdev: add device statu

Re: [PATCH] bus/fslmc: fix invalid use of default VFIO config

2022-06-07 Thread Thomas Monjalon
03/06/2022 17:18, Romain Delhomel: > At device probe, the fslmc bus driver calls rte_vfio_get_group_fd() to > get a fd associated to a vfio group. This function first checks if the > group is already opened, else it opens /dev/vfio/%u, and increases the > number of active groups in default_vfio_cfg

Re: [PATCH] build: fix meson build when gcc >= 10.0

2022-06-07 Thread Stephen Hemminger
On Tue, 7 Jun 2022 17:13:07 +0200 David Marchand wrote: > On Tue, Jun 7, 2022 at 5:10 PM Stephen Hemminger > wrote: > > On Tue, 07 Jun 2022 12:52:32 +0200 > > Thomas Monjalon wrote: > > > 07/06/2022 04:56, wenxuanx...@intel.com: > > > > From: Wenxuan Wu > > > > > > > > GCC version greater

Re: [PATCH] build: fix meson build when gcc >= 10.0

2022-06-07 Thread David Marchand
On Tue, Jun 7, 2022 at 5:10 PM Stephen Hemminger wrote: > On Tue, 07 Jun 2022 12:52:32 +0200 > Thomas Monjalon wrote: > > 07/06/2022 04:56, wenxuanx...@intel.com: > > > From: Wenxuan Wu > > > > > > GCC version greater than 10.0, with compile option -O2, several warnings > > > info would appear,

[PATCH v4] eventdev: add adapter instance get API

2022-06-07 Thread Ganapati Kundapura
Added rte_event_eth_rx_adapter_instance_get() and rte_event_eth_tx_adapter_instance_get() api's to get the adapter instance id for a specified event port and queue index. Signed-off-by: Ganapati Kundapura --- v4: * Moved instance array allocation and instance id storage before adapter's nb_queu

Re: [PATCH v7] eal: add bus cleanup to eal cleanup

2022-06-07 Thread David Marchand
On Tue, Jun 7, 2022 at 1:09 PM Thomas Monjalon wrote: > > 03/06/2022 16:36, Kevin Laatz: > > During EAL init, all buses are probed and the devices found are > > initialized. On eal_cleanup(), the inverse does not happen, meaning any > > allocated memory and other configuration will not be cleaned

Re: [PATCH] build: fix meson build when gcc >= 10.0

2022-06-07 Thread Stephen Hemminger
On Tue, 07 Jun 2022 12:52:32 +0200 Thomas Monjalon wrote: > 07/06/2022 04:56, wenxuanx...@intel.com: > > From: Wenxuan Wu > > > > GCC version greater than 10.0, with compile option -O2, several warnings > > info would appear, > > this fix omitted these warnings. > [...] > > # FIXME: Bugzill

Re: [PATCH] drivers: rename octeon ep PMD

2022-06-07 Thread Thomas Monjalon
07/06/2022 16:38, Ray Kinsella: > Sathesh B Edara writes: > > > This patch renames octeon end point driver from > > octeontx_ep to octeon_ep > > > > Signed-off-by: Sathesh B Edara > > Straight forward rename, > > Acked-by: Ray Kinsella The name change was not announced. Why is it required?

Re: [PATCH] drivers: rename octeon ep PMD

2022-06-07 Thread Ray Kinsella
Sathesh B Edara writes: > This patch renames octeon end point driver from > octeontx_ep to octeon_ep > > Signed-off-by: Sathesh B Edara > --- > MAINTAINERS | 6 +- > .../{octeontx_ep.ini => octeon_ep.ini}| 2 +- > doc/guides/nics/index.rst

Re: [PATCH v4] app/testpmd: fix slave device isn't released

2022-06-07 Thread Ferruh Yigit
On 6/7/2022 9:10 AM, Dongdong Liu wrote: From: Huisong Li Currently, some eth devices are added to bond device, these devices are not released when the quit command is executed in testpmd. This patch adds the release operation for all active slaves under a bond device. Fixes: 0e545d3047fe ("ap

Re: [PATCH v4 0/4] clean up zero-length arrays

2022-06-07 Thread David Marchand
On Fri, Jun 3, 2022 at 1:16 PM Bruce Richardson wrote: > > This patchset adds a coccinelle script to clean-up zero-length > arrays in structures. The final patches are the result of running > that script on the DPDK repository. > > > Bruce Richardson (4): > cocci: add script for zero-length arra

Re: [PATCH v5 0/5] Support OFS card

2022-06-07 Thread Thomas Monjalon
> Wei Huang (5): > raw/ifpga: remove experimental tag from ifpga APIs > raw/ifpga: remove vdev when ifpga is closed > raw/ifpga: unregister interrupt in ifpga close function > raw/ifpga: support ofs card probe > guides/rawdevs: add description of ofs in ifpga doc Applied, thanks.

Minutes of Technical Board Meeting, 2022-06-01

2022-06-07 Thread Olivier Matz
Members Attending = 9/11 - Aaron - Bruce - Hemant - Jerin - Kevin - Maxime - Olivier (chair) - Stephen - Thomas NOTE: The technical board meetings are on every second Wednesday at https://meet.jit.si/DPDK at 3 pm UTC. Meetings are public, and DPDK community members are welcome to

RE: [PATCH v3] eventdev: add adapter instance get API

2022-06-07 Thread Jayatheerthan, Jay
Hi Ganapati, This patch could be split into multiple patches in a patchset to make it easier to review. One way to split: 1. Rx adapter API 2. Telemetry changes for Rx adapter 3. Test changes for Rx adapter API 4. Tx adapter API 5. Telemetry changes for Tx adapter ? 6. Test changes for Tx adapter

[PATCH v5 4/7] net/mlx5: add LWM event handling support

2022-06-07 Thread Spike Du
When LWM meets RQ WQE, the kernel driver raises an event to SW. Use devx event_channel to catch this and to notify the user. Allocate this channel per shared device. The channel has a cookie that informs the specific event port and queue. Signed-off-by: Spike Du --- drivers/net/mlx5/mlx5.c

[PATCH v5 2/7] common/mlx5: share interrupt management

2022-06-07 Thread Spike Du
There are many duplicate code of creating and initializing rte_intr_handle. Add a new mlx5_os API to do this, replace all PMD related code with this API. Signed-off-by: Spike Du --- drivers/common/mlx5/linux/mlx5_common_os.c | 131 ++ drivers/common/mlx5/linux/mlx5_comm

Re: [PATCH] eal: fix segment fault when exit trace

2022-06-07 Thread David Marchand
On Tue, Jun 7, 2022 at 2:06 PM Chengwen Feng wrote: > > Bug scenario: > 1. start testpmd: > dpdk-testpmd -l 4-6 -a :7d:00.0 --trace=.* -- -i > 2. quit testpmd and then observed segment fault: > Bye... > Segmentation fault (core dumped) > > The root cause is that rte_tra

[PATCH v5 6/7] net/mlx5: add private API to config host port shaper

2022-06-07 Thread Spike Du
Host port shaper can be configured with QSHR(QoS Shaper Host Register). Add check in build files to enable this function or not. The host shaper configuration affects all the ethdev ports belonging to the same host port. Host shaper can configure shaper rate and lwm-triggered for a host port. The

[PATCH v5 7/7] app/testpmd: add Host Shaper command

2022-06-07 Thread Spike Du
Add command line options to support host shaper configure. - Command syntax: mlx5 set port host_shaper avail_thresh_triggered <0|1> rate - Example commands: To enable avail_thresh_triggered on port 1 and disable current host shaper: testpmd> mlx5 set port 1 host_shaper avail_thresh_triggered 1

[PATCH v5 5/7] net/mlx5: support Rx queue based available descriptor threshold

2022-06-07 Thread Spike Du
Add mlx5 specific available descriptor threshold configuration and query handler. In mlx5 PMD, available descriptor threshold is also called LWM(limit watermark). While the Rx queue fullness reaches the LWM limit, the driver catches an HW event and invokes the user callback. The query handler finds

[PATCH v5 3/7] ethdev: introduce Rx queue based available descriptor threshold

2022-06-07 Thread Spike Du
available descriptor threshold describes the availability of a Rx queue for hardware. If the availability is below the threshold, the device will trigger the event RTE_ETH_EVENT_RX_AVAIL_THRESH. available descriptor threshold is defined as a percentage of Rx queue size with valid value of [0,99]. S

[PATCH v5 1/7] net/mlx5: add LWM support for Rxq

2022-06-07 Thread Spike Du
Add lwm(Limit WaterMark) field to Rxq object which indicates the percentage of RX queue size used by HW to raise LWM event to the user. Allow LWM setting in modify_rq command. Allow the LWM configuration dynamically by adding RDY2RDY state change. Signed-off-by: Spike Du --- drivers/net/mlx5/mlx

[PATCH v5 0/7] introduce per-queue available descriptor threshold and host shaper

2022-06-07 Thread Spike Du
available descriptor threshold(ADT for short) is per RX queue attribute, when RX queue available descriptors for HW is below ADT, HW sends an event to application. Host shaper can configure shaper rate and avail_thresh-triggered for a host port. The shaper limits the rate of traffic from host po

Re: [PATCH v1] bbdev: add device status info

2022-06-07 Thread Maxime Coquelin
Hi Stephen, On 6/7/22 02:09, Stephen Hemminger wrote: On Mon, 6 Jun 2022 15:50:08 -0700 Nicolas Chautru wrote: @@ -298,6 +313,8 @@ struct rte_bbdev_driver_info { const struct rte_bbdev_op_cap *capabilities; /** Device cpu_flag requirements */ const enum rte_cpu_flag_t

RE: [EXT] [PATCH] examples/fips_validation: fix link to libjansson

2022-06-07 Thread Gowrishankar Muthukrishnan
> -Original Message- > From: David Marchand > Sent: Tuesday, June 7, 2022 3:32 PM > To: dev@dpdk.org > Cc: tho...@monjalon.net; Fan Zhang ; Brian > Dooley ; Gowrishankar Muthukrishnan > ; Brandon Lo > Subject: [EXT] [PATCH] examples/fips_validation: fix link to libjansson > > External

[PATCH 3/3] examples/vhost: update vhost usage message

2022-06-07 Thread Herakliusz Lipiec
updating vhost usage message to be aligned with the documentation. Signed-off-by: Herakliusz Lipiec --- examples/vhost/main.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/examples/vhost/main.c b/examples/vhost/main.c index c4d46de1c5..bb1aadffa9 100644 --- a/e

[PATCH 2/3] doc: update vhost sample app docs

2022-06-07 Thread Herakliusz Lipiec
Vhost sample app documentation describes parameters that are not in the code and ommits parameters that exist. Also switching the order of sections on running vhost and VM, since the --client parameter in the sample line requires a socket to be created by VM. Removing uio references and updating wi

[PATCH 1/3] examples/vhost: update makefile to match meson build system

2022-06-07 Thread Herakliusz Lipiec
Meson build system creates a vhost binary but Makefile and docs reference same as vhost-switch. Updating makefile to match meson. Signed-off-by: Herakliusz Lipiec --- examples/vhost/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/examples/vhost/Makefile b/examples/vh

Re: [PATCH v1] bbdev: add new operation for FFT processing

2022-06-07 Thread David Marchand
Hi guys, On Thu, May 26, 2022 at 8:05 AM Hemant Agrawal wrote: > On 5/26/2022 3:37 AM, Chautru, Nicolas wrote: > > Hi Hernant, > > Gentle reminder in case you can find the time. Could please have a look > > this patch for bbdev api extension. This is targeting 22.11. > > New operation type for F

[v2 2/3] net/mlx5: add support to modify ECN field

2022-06-07 Thread Sean Zhang
This patch is to support modify ECN field in IPv4/IPv6 header. Signed-off-by: Sean Zhang Acked-by: Viacheslav Ovsiienko --- doc/guides/nics/mlx5.rst | 1 + doc/guides/rel_notes/release_22_07.rst | 1 + drivers/net/mlx5/mlx5_flow_dv.c| 20 3 files cha

[v2 3/3] net/mlx5: add modify field support in meter

2022-06-07 Thread Sean Zhang
This patch introduces MODIFY_FIELD action support in meter. User can create meter policy with MODIFY_FIELD action in green/yellow action. For example: testpmd> add port meter policy 0 21 g_actions modify_field op set dst_type ipv4_ecn src_type value src_value 3 width 2 / ... Signed-off-b

[v2 1/3] common/mlx5: add modify ECN capability check

2022-06-07 Thread Sean Zhang
Flag outer_ip_ecn in header modify capabilities properties layout is added in order to check if the firmware supports modification of ecn field. Signed-off-by: Sean Zhang Acked-by: Viacheslav Ovsiienko --- drivers/common/mlx5/mlx5_devx_cmds.c | 3 ++ drivers/common/mlx5/mlx5_devx_cmds.h | 1 +

[v2 0/3] Add support for modifying ECN in IPv4/IPv6 header

2022-06-07 Thread Sean Zhang
This patch set adds support for modifying ECN fields in IPv4/IPv6 header, and also adds support for modify_filed action in meter. --- v2 --- rebase and add missing doc --- Sean Zhang (3): common/mlx5: add modify ECN capability check net/mlx5: add support to modify ECN field net/mlx5: add mod

[v2] net/mlx5: support represented port item

2022-06-07 Thread Sean Zhang
Add support for represented_port item in pattern. And if the spec and mask both are NULL, translate function will not add source vport to matcher. For example, testpmd starts with PF, VF-rep0 and VF-rep1, below command will redirect packets from VF0 and VF1 to wire: testpmd> flow create 0 ingress

Re: [PATCH] examples/pipeline: fix build

2022-06-07 Thread Thomas Monjalon
> > This patch fixes the following build failure seen on Ubuntu 16.04 > > with gcc 5.4.0 because of uninitialized variable: > > [..] > > examples/pipeline/cli.c:2853:9: error: 'session_id' may be used > > uninitialized in this function [-Werror=maybe-uninitialized] > > [..] > > > > Fixes

Re: [PATCH v7] eal: add bus cleanup to eal cleanup

2022-06-07 Thread Thomas Monjalon
03/06/2022 16:36, Kevin Laatz: > During EAL init, all buses are probed and the devices found are > initialized. On eal_cleanup(), the inverse does not happen, meaning any > allocated memory and other configuration will not be cleaned up > appropriately on exit. [...] > --- a/devtools/libabigail.abi

RE: [PATCH] dma/idxd: fix return value for pci device commands

2022-06-07 Thread Walsh, Conor
> Subject: [PATCH] dma/idxd: fix return value for pci device commands > > When sending a command to an idxd device via pci bar, the response from > HW is checked to ensure it was successful. The response was incorrectly > being negated before being returned by the function, meaning error codes >

Re: [PATCH] build: fix meson build when gcc >= 10.0

2022-06-07 Thread Thomas Monjalon
07/06/2022 04:56, wenxuanx...@intel.com: > From: Wenxuan Wu > > GCC version greater than 10.0, with compile option -O2, several warnings info > would appear, > this fix omitted these warnings. [...] > # FIXME: Bugzilla 396 > -warning_flags += '-Wno-zero-length-bounds' > +warning_flags +

Re: [PATCH] dma/skeleton: support multiple instances

2022-06-07 Thread Thomas Monjalon
Chengwen, as the maintainer of this driver, what do you think? 28/03/2022 16:40, Varghese, Vipin: > [AMD Official Use Only] > > Verified on ` AMD EPYC 7713 64-Core Processor` platform with argument ` > --vdev=dma_skeleton0,lcore=4 --vdev=dma_skeleton1,lcore=5`. > > Tested-by: Vipin Varghese

Re: [PATCH v8 1/3] ethdev: introduce protocol hdr based buffer split

2022-06-07 Thread Andrew Rybchenko
On 6/7/22 13:13, Ding, Xuan wrote: Hi Andrew, -Original Message- From: Andrew Rybchenko Sent: Saturday, June 4, 2022 10:26 PM To: Ding, Xuan ; Wu, WenxuanX ; tho...@monjalon.net; Li, Xiaoyun ; ferruh.yi...@xilinx.com; Singh, Aman Deep ; dev@dpdk.org; Zhang, Yuying ; Zhang, Qi Z ; jerin

Re: [PATCH v3] dma/idxd: add generic option for queue config

2022-06-07 Thread Thomas Monjalon
01/04/2022 12:51, Bruce Richardson: > On Fri, Apr 01, 2022 at 11:35:00AM +0100, Kevin Laatz wrote: > > The device config script currently uses some defaults to configure > > devices in a generic way. > > > > With the addition of this option, users have more control over how > > queues are configur

[PATCH RESEND v4 8/8] ci: add RISCV64 cross compilation job

2022-06-07 Thread Stanislaw Kardach
Checks cross-compilation using Ubuntu 20.04 x86. Signed-off-by: David Marchand Signed-off-by: Stanislaw Kardach --- .ci/linux-build.sh | 4 .github/workflows/build.yml | 11 ++- 2 files changed, 14 insertions(+), 1 deletion(-) diff --git a/.ci/linux-build.sh b/.ci/linux-

  1   2   >