RE: [PATCH v2] net/ice: fix DCF state checking mechanism

2022-05-17 Thread Zhang, Qi Z
> -Original Message- > From: Zhang, Peng1X > Sent: Wednesday, May 18, 2022 2:36 PM > To: Zhang, Qi Z ; Yang, Qiming > ; dev@dpdk.org > Cc: sta...@dpdk.org > Subject: RE: [PATCH v2] net/ice: fix DCF state checking mechanism > > Ok, because error phenomena happens during the period VF re

[DPDK v2] lib/eal: fix segfaults due to thread exit order

2022-05-17 Thread zhichaox . zeng
From: Zhichao Zeng The eal-intr-thread is not closed before exiting the main thread. There is a small probability that when the eal-intr-thread is about to use some pointers, the pointers were just released in the process of exiting, which cause the segment fault error caught by ASan. Close the

RE: [PATCH v2] net/ice: fix DCF state checking mechanism

2022-05-17 Thread Zhang, Peng1X
Ok, because error phenomena happens during the period VF reset again and again following situation will possible happen as following steps describe: step 1. DCF state has been set to on after VF has reset. step 2. A VF reset happen, kernel send an event to DCF and set STATE to pause. step 3. Before

Re: [PATCH] net/bnxt: fix compatibility with some old firmwares

2022-05-17 Thread Thomas Monjalon
18/05/2022 05:58, Ajit Khaparde: > On Tue, May 17, 2022 at 12:18 AM Thomas Monjalon wrote: > > > > 30/03/2022 01:21, Ajit Khaparde: > > > On Fri, Mar 18, 2022 at 8:03 AM David Marchand > > > wrote: > > > > > > > > This reverts commit 3972281f47b2cc0cf844698885f0e6b4228c0975. > > > > > > > > Repor

RE: [PATCH 01/12] config: add thundert83 config

2022-05-17 Thread Ruifeng Wang
> -Original Message- > From: Harman Kalra > Sent: Wednesday, May 18, 2022 1:40 AM > To: dev@dpdk.org; Ruifeng Wang ; Jan Viktorin > ; Bruce Richardson > Cc: Harman Kalra > Subject: [PATCH 01/12] config: add thundert83 config > > Adding support for marvell thunder t83 platform.

[PATCH v2] examples/vhost: fix floating point exception when no VMDq

2022-05-17 Thread Yuan Wang
If the VMDQ limits is 0, a divide-by-zero error occurs. This patch replaces throwing a floating point exception with a normal error message. Fixes: d19533e86f ("examples/vhost: copy old vhost example") Cc: sta...@dpdk.org Signed-off-by: Yuan Wang --- examples/vhost/main.c | 4 1 file chang

[PATCH v4] net/i40e: fix max frame size config at port level

2022-05-17 Thread wenxuanx . wu
From: Wenxuan Wu Previously, max frame size can only be set when link is up, and the wait time is 1 sec. Startup time of 10G_BASET longer than 1s would result in failure. Acctually, max frame size of media type I40E_MEDIA_TYPE_BASET can be set regardless of link status. This patch omitted the l

[PATCH v4] net/i40e: fix max frame size config at port level

2022-05-17 Thread wenxuanx . wu
From: Wenxuan Wu Previously, max frame size can only be set when link is up, and the wait time is 1 sec. Startup time of 10G_BASET longer than 1s would result in failure. Acctually, max frame size of media type I40E_MEDIA_TYPE_BASET can be set regardless of link status. This patch omitted the l

RE: [PATCH v1] net/iavf: fix resource leak issue

2022-05-17 Thread Zhang, Qi Z
> -Original Message- > From: Thomas Monjalon > Sent: Tuesday, May 17, 2022 2:52 PM > To: Zhang, Qi Z > Cc: Wu, Wenjun1 ; dev@dpdk.org; Wu, Jingjing > ; Xing, Beilei > Subject: Re: [PATCH v1] net/iavf: fix resource leak issue > > 17/05/2022 02:59, Zhang, Qi Z: > > From: Zhang, Qi Z >

RE: [PATCH] net/iavf: fix mask not allowed issue

2022-05-17 Thread Zhang, Qi Z
> -Original Message- > From: Yang, Qiming > Sent: Monday, May 16, 2022 10:03 AM > To: dev@dpdk.org; Zhang, Qi Z > Cc: Yang, Qiming ; sta...@dpdk.org > Subject: [PATCH] net/iavf: fix mask not allowed issue > How about "fix invalid flow mask handling" > Only zero-mask and full-mask fo

[PATCH 4/4] ethdev: add meter color mark flow action

2022-05-17 Thread Alexander Kozyrev
Create a new Flow API action: METER_MARK. It Meters an IP packet stream and marks its packets with colors. Unlike the METER action, it performs no policing at all. An user has the flexibility to create any policies with the help of the METER_COLOR item later, only meter profile is required now. Si

[PATCH 2/4] ethdev: allow meter color marker modification

2022-05-17 Thread Alexander Kozyrev
Extend modify_field Flow API with support of Meter Color Marker modifications. It allows setting the DS field of a packet to any color marker: green, yellow or red. User is able to specify an initial packet color for Meter API or create simple Metering and Marking flow rules based on his own colori

[PATCH 3/4] ethdev: add meter profile config calculation

2022-05-17 Thread Alexander Kozyrev
Introduce a new Meter API to calculate PMD-specific profile configuration values based on user-provided CIR, CBS and EBS. That will allow fast Meter configuration in hardware without the need to convert these values every time we use a profile. Signed-off-by: Alexander Kozyrev --- .../traffic_me

[PATCH 1/4] ethdev: add meter color flow matching item

2022-05-17 Thread Alexander Kozyrev
Provide an ability to use a Color Marker set by a Meter as a matching item in Flow API. The Color Marker reflects the metering result by setting the DS field of a packet to a particular codepoint: green, yellow or red. Signed-off-by: Alexander Kozyrev --- doc/guides/prog_guide/rte_flow.rst |

[PATCH 0/4] ethdev: separate metering and marking from policing

2022-05-17 Thread Alexander Kozyrev
Extend Metering and Marking support in the Flow API: 1. Add METER_COLOR item to match Color Marker set by a Meter. 2. Add the ability to set Color Marker via modify_field Flow API. 3. Add Meter API to calculate profile configuration values. 4. Add METER_MARK action to perform Meter color marking on

RE: [PATCH v1 2/2] app/testpmd: support dump_pkg command for ice

2022-05-17 Thread Zhang, Qi Z
> -Original Message- > From: Yang, SteveX > Sent: Wednesday, May 11, 2022 4:03 PM > To: dev@dpdk.org > Cc: Zhang, Yuying ; Yang, Qiming > ; Zhang, Qi Z ; > m...@ashroe.eu; Yang, SteveX > Subject: [PATCH v1 2/2] app/testpmd: support dump_pkg command for ice > > Support dump ice PF ddp

RE: [PATCH v2 3/7] examples/l2fwd-crypto: add signal handler for exit

2022-05-17 Thread Gagandeep Singh
Hi, > -Original Message- > From: Stephen Hemminger > Sent: Tuesday, May 17, 2022 10:02 PM > To: Gagandeep Singh > Cc: gak...@marvell.com; dev@dpdk.org > Subject: Re: [PATCH v2 3/7] examples/l2fwd-crypto: add signal handler for exit > > On Tue, 17 May 2022 09:08:54 +0530 > Gagandeep Sing

RE: [PATCH v1 1/2] net/ice: support dump ice ddp package

2022-05-17 Thread Zhang, Qi Z
> -Original Message- > From: Yang, SteveX > Sent: Wednesday, May 11, 2022 4:03 PM > To: dev@dpdk.org > Cc: Zhang, Yuying ; Yang, Qiming > ; Zhang, Qi Z ; > m...@ashroe.eu; Yang, SteveX > Subject: [PATCH v1 1/2] net/ice: support dump ice ddp package > > Send the AQ command to acquire i

RE: [PATCH v3] net/iavf: fix segfaults when calling API after VF reset failed

2022-05-17 Thread Zhang, Qi Z
> -Original Message- > From: Zhou, YidingX > Sent: Thursday, May 12, 2022 6:49 PM > To: dev@dpdk.org; Wu, Jingjing ; Xing, Beilei > > Cc: Zhang, Qi Z ; sta...@dpdk.org > Subject: [PATCH v3] net/iavf: fix segfaults when calling API after VF reset > failed > > Some pointers will be set

Re: [PATCH] net/bnxt: fix compatibility with some old firmwares

2022-05-17 Thread Ajit Khaparde
On Tue, May 17, 2022 at 12:18 AM Thomas Monjalon wrote: > > 30/03/2022 01:21, Ajit Khaparde: > > On Fri, Mar 18, 2022 at 8:03 AM David Marchand > > wrote: > > > > > > This reverts commit 3972281f47b2cc0cf844698885f0e6b4228c0975. > > > > > > Reported by Red Hat QE: with older firmware versions (at

RE: [PATCH v2] net/ice: fix missing MTU value setting

2022-05-17 Thread Zhang, Qi Z
> -Original Message- > From: Liu, KevinX > Sent: Friday, April 8, 2022 9:43 AM > To: dev@dpdk.org > Cc: Yang, Qiming ; Zhang, Qi Z > ; Yang, SteveX ; Liu, KevinX > ; sta...@dpdk.org > Subject: [PATCH v2] net/ice: fix missing MTU value setting > > In the DCF module, Missing maximum and

RE: [PATCH v1 0/2] add a fast path for memif Rx/Tx

2022-05-17 Thread Ruifeng Wang
> -Original Message- > From: Joyce Kong > Sent: Tuesday, May 17, 2022 6:51 PM > Cc: Ruifeng Wang ; dev@dpdk.org; nd > ; Joyce Kong > Subject: [PATCH v1 0/2] add a fast path for memif Rx/Tx > > For memif non-zero-copy mode, there is a branch to compare the mbuf and > memif buffer size dur

RE: [PATCH v2] ixgbe/base: Manual AN-37 for troublesome link partners for X550 SFI

2022-05-17 Thread Zhang, Qi Z
Jeff: > -Original Message- > From: Jeff Daly > Sent: Thursday, March 17, 2022 2:59 AM > To: dev@dpdk.org > Cc: Wang, Haiyue > Subject: [PATCH v2] ixgbe/base: Manual AN-37 for troublesome link partners > for X550 SFI > > Some SFP link partners exhibit a disinclination to autonegotiate wi

Re: Does ACL support field size of 8 bytes?

2022-05-17 Thread Konstantin Ananyev
-Original Message- From: Konstantin Ananyev Sent: Sunday, 15 May 2022 23:54 To: Ido Goshen ; Ananyev, Konstantin ; us...@dpdk.org; dev@dpdk.org Subject: Re: Does ACL support field size of 8 bytes? My concern was it is sort of awkward in terms of input_field value for rules with 8B l

Re: [PATCH v5 1/4] lib/ethdev: introduce protocol type based buffer split

2022-05-17 Thread Thomas Monjalon
Hello, It seems you didn't try to address my main comment on v4: " Before doing anything, the first patch of this series should make the current status clearer. Example, this line does not explain what it does: uint16_t split_hdr_size; /**< hdr buf size (header_split enabled).*/ And heade

Re: [PATCH v2] libpcapng: fix timestamp wrapping in output files

2022-05-17 Thread Stephen Hemminger
On Tue, 17 May 2022 11:01:15 +0100 Quentin Armitage wrote: > In pcap_tsc_to_ns(), delta * NSEC_PER_SEC will overflow approx 8 > seconds after pcap_init is called when using a TSC with a frequency > of 2.5GHz. > > To avoid the overflow, update the saved time and TSC value once > delta >= tsc_hz.

[PATCH v3] doc: update Linux core isolation guide

2022-05-17 Thread pbhagavatula
From: Pavan Nikhilesh Update Linux core isolation guide to include isolation from timers, rcu processing and IRQs. Signed-off-by: Pavan Nikhilesh --- v3 Changes: - Add additional information links for Cgroups. v2 Changes: - Add references to the parameters used. - Add note about Linux cgr

RE: [EXT] Re: [PATCH v2] doc: update Linux core isolation guide

2022-05-17 Thread Pavan Nikhilesh Bhagavatula
> On Tue, 17 May 2022 23:38:55 +0530 > wrote: > > > + > > +.. Note:: > > + > > + For more fine grained control over resource management and > performance tuning one can look > > + into ``Linux cgroups``. > > Please provide a better link than just search terms: > Sure, I will add

Re: [PATCH v2] doc: update Linux core isolation guide

2022-05-17 Thread Stephen Hemminger
On Tue, 17 May 2022 23:38:55 +0530 wrote: > + > +.. Note:: > + > + For more fine grained control over resource management and > performance tuning one can look > + into ``Linux cgroups``. Please provide a better link than just search terms: Suggestions: Cgroups uses cpusets. h

[PATCH v2] doc: update Linux core isolation guide

2022-05-17 Thread pbhagavatula
From: Pavan Nikhilesh Update Linux core isolation guide to include isolation from timers, rcu processing and IRQs. Signed-off-by: Pavan Nikhilesh --- v2 Changes: - Add references to the parameters used. - Add note about Linux cgroups. doc/guides/linux_gsg/enable_func.rst | 22

[PATCH 12/12] net/thunderx: populate max and min MTU values

2022-05-17 Thread Harman Kalra
From: Hanumanth Pothula Populate maximum and minimum MTU values while retrieving device information. Signed-off-by: Hanumanth Pothula --- drivers/net/thunderx/nicvf_ethdev.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/net/thunderx/nicvf_ethdev.c b/drivers/net/thunderx/nicv

[PATCH 11/12] net/thunderx: device attach from secondary

2022-05-17 Thread Harman Kalra
Adding support for device hotplugging - attach and detach from secondary Signed-off-by: Harman Kalra --- drivers/net/thunderx/base/nicvf_mbox.c | 17 ++--- 1 file changed, 14 insertions(+), 3 deletions(-) diff --git a/drivers/net/thunderx/base/nicvf_mbox.c b/drivers/net/thunderx/ba

[PATCH 05/12] net/octeontx: handle port reconfiguration

2022-05-17 Thread Harman Kalra
Adding support for port reconfiguration as user may require to do so on a running system. Signed-off-by: Harman Kalra --- drivers/net/octeontx/octeontx_ethdev.c | 38 +++--- drivers/net/octeontx/octeontx_ethdev.h | 1 + 2 files changed, 23 insertions(+), 16 deletions(-) dif

[PATCH 10/12] net/octeontx: support allmulticast

2022-05-17 Thread Harman Kalra
Implement allmulticast operations for octeontx driver: rte_eth_allmulticast_enable()/rte_eth_allmulticast_disable(). Signed-off-by: Harman Kalra --- drivers/net/octeontx/base/octeontx_bgx.c | 19 ++ drivers/net/octeontx/base/octeontx_bgx.h | 1 + drivers/net/octeontx/octeontx_ethdev.c

[PATCH 06/12] net/thunderx: implement polling of link state change

2022-05-17 Thread Harman Kalra
From: Hanumanth Pothula Moving the logic of link polling to VF from PF. Now VF is supposed to poll for the link status, rather PF alerting VF about any link change. Signed-off-by: Hanumanth Pothula --- drivers/net/thunderx/base/nicvf_mbox.c | 9 drivers/net/thunderx/base/nicvf_mbox.h

[PATCH 09/12] net/octeontx: implement xstats

2022-05-17 Thread Harman Kalra
Adding support for xstats eth operations. Signed-off-by: Harman Kalra --- drivers/net/octeontx/base/octeontx_bgx.c | 17 +++ drivers/net/octeontx/base/octeontx_bgx.h | 3 + drivers/net/octeontx/octeontx_ethdev.c | 126 +++ drivers/net/octeontx/octeontx_stats.h| 41 +

[PATCH 08/12] net/thunderx: setting link attributes

2022-05-17 Thread Harman Kalra
Adding support to configure link attributes like speed, duplex, negotiation. Signed-off-by: Harman Kalra --- drivers/net/thunderx/base/nicvf_mbox.c | 16 + drivers/net/thunderx/base/nicvf_mbox.h | 14 drivers/net/thunderx/nicvf_ethdev.c| 88 -- drivers/net/th

[PATCH 07/12] net/thunderx: reset Rx DMAC control register

2022-05-17 Thread Harman Kalra
From: Hanumanth Pothula During initialization, reset RX DMAC control register by sending mbox message NIC_MBOX_MSG_RESET_XCAST to PF. Signed-off-by: Hanumanth Pothula --- drivers/net/thunderx/base/nicvf_mbox.c | 9 + drivers/net/thunderx/base/nicvf_mbox.h | 2 ++ drivers/net/thunderx/n

[PATCH 03/12] net/octeontx: fix port close

2022-05-17 Thread Harman Kalra
Segmentation fault has been observed while closing the ethernet port. Reason for the segfault is, eth port close also shuts down event device while other ethernet port is still using the event device. Fixes: da6c687471a3 ("net/octeontx: add start and stop support") Signed-off-by: Harman Kalra --

[PATCH 04/12] net/octeontx: setting link attributes

2022-05-17 Thread Harman Kalra
Adding support to configure link attributes like speed, duplex, negotiation. Signed-off-by: Harman Kalra --- drivers/net/octeontx/base/octeontx_bgx.c | 19 ++ drivers/net/octeontx/base/octeontx_bgx.h | 12 drivers/net/octeontx/octeontx_ethdev.c | 80 ++-- 3 files c

[PATCH 02/12] event/octeontx: fix SSO fastpath

2022-05-17 Thread Harman Kalra
Segmentation fault is observed as soon as any dpdk application with ethdev event is launched. Handling the event types appropriately. Fixes: 8dc6c2f12ecf ("crypto/octeontx: add crypto adapter data path") Signed-off-by: Harman Kalra --- drivers/event/octeontx/ssovf_worker.h | 22 +---

[PATCH 01/12] config: add thundert83 config

2022-05-17 Thread Harman Kalra
Adding support for marvell thunder t83 platform. Signed-off-by: Harman Kalra --- config/arm/arm64_thunderxt83_linux_gcc | 16 config/arm/meson.build | 12 ++-- 2 files changed, 26 insertions(+), 2 deletions(-) create mode 100644 config/arm/arm64_thunderx

Re: [PATCH v3] net/cxgbe: read firmware configuration file from filesystem

2022-05-17 Thread Ferruh Yigit
On 5/16/2022 8:34 PM, Rahul Lakkireddy wrote: Add support to read firmware configuration file from /lib/firmware/cxgb4/ path in the filesystem. The firmware config file is used to enable or disable NIC features before firmware initialization to help retrieve better debug data to analyze firmware

Re: [PATCH v2] net/cxgbe: track packets dropped by TP due to congestion

2022-05-17 Thread Ferruh Yigit
On 5/6/2022 2:18 PM, Rahul Lakkireddy wrote: Transport Processor (TP) on the NIC delivers the incoming packets from the wire to NIC's DMA engine to place the packets in Rx buffers. TP sends signal towards the Multi-Port Switch (MPS) near the MAC when the Rxqs run out of Rx buffers posted by drive

Re: [PATCH v2 3/7] examples/l2fwd-crypto: add signal handler for exit

2022-05-17 Thread Stephen Hemminger
On Tue, 17 May 2022 09:08:54 +0530 Gagandeep Singh wrote: > Handle SIGINT and SIGTERM signals. > > Signed-off-by: Gagandeep Singh > --- > examples/l2fwd-crypto/main.c | 16 > 1 file changed, 16 insertions(+) > > diff --git a/examples/l2fwd-crypto/main.c b/examples/l2fwd-crypt

RE: [PATCH 1/1] drivers: define OPENSSL_API_COMPAT

2022-05-17 Thread Ji, Kai
Acked-by: Ji, Kai > -Original Message- > From: Heinrich Schuchardt > Sent: Tuesday, May 10, 2022 4:07 PM > To: Zhang, Roy Fan > Cc: Chandubabu Namburu ; dev@dpdk.org; Heinrich > Schuchardt > Subject: [PATCH 1/1] drivers: define OPENSSL_API_COMPAT > > The API of the OpenSSL library has

RE: [PATCH v3] app/testpmd: perform SW IP checksum for GRO/GSO packets

2022-05-17 Thread Zhang, Yuying
Hi Wenwu, LGTM. > -Original Message- > From: Ma, WenwuX > Sent: Thursday, May 12, 2022 9:08 AM > To: Li, Xiaoyun ; Singh, Aman Deep > ; Zhang, Yuying ; > dev@dpdk.org > Cc: Hu, Jiayu ; Wang, Yinan ; > He, Xingguang ; Ma, WenwuX > ; sta...@dpdk.org > Subject: [PATCH v3] app/testpmd: perfor

Re: [PATCH v4] eal: allow worker lcore stacks to be allocated from hugepage memory

2022-05-17 Thread Stephen Hemminger
On Tue, 17 May 2022 11:31:36 -0400 Don Wallwork wrote: > Add support for using hugepages for worker lcore stack memory. The > intent is to improve performance by reducing stack memory related TLB > misses and also by using memory local to the NUMA node of each lcore. > > EAL option '--huge-work

[PATCH v4] eal: allow worker lcore stacks to be allocated from hugepage memory

2022-05-17 Thread Don Wallwork
Add support for using hugepages for worker lcore stack memory. The intent is to improve performance by reducing stack memory related TLB misses and also by using memory local to the NUMA node of each lcore. EAL option '--huge-worker-stack [stack-size-in-kbytes]' is added to allow the feature to b

RE: [EXT] [DPDK] eal/linux: fix segfaults due to thread exit order

2022-05-17 Thread Harman Kalra
Hi Zhichao, Can you please add the same API for freebsd also. Thanks Harman > -Original Message- > From: zhichaox.z...@intel.com > Sent: Tuesday, May 17, 2022 9:35 PM > To: dev@dpdk.org; qiming.y...@intel.com > Cc: Zhichao Zeng ; Harman Kalra > > Subject: [EXT] [DPDK] eal/linux: fix se

RE: [PATCH 1/6] Revert "app/testpmd: modify mac in csum forwarding"

2022-05-17 Thread Zhang, Yuying
Hi Coquelin, Please fix the code style issue of commit log. > -Original Message- > From: Xia, Chenbo > Sent: Monday, May 16, 2022 9:04 PM > To: Maxime Coquelin ; dev@dpdk.org; > jasow...@redhat.com; david.march...@redhat.com; > olivier.m...@6wind.com > Cc: sta...@dpdk.org; Li, Xiaoyun ;

Re: [PATCH v2] libpcapng: fix timestamp wrapping in output files

2022-05-17 Thread Stephen Hemminger
On Tue, 17 May 2022 11:01:15 +0100 Quentin Armitage wrote: > In pcap_tsc_to_ns(), delta * NSEC_PER_SEC will overflow approx 8 > seconds after pcap_init is called when using a TSC with a frequency > of 2.5GHz. > > To avoid the overflow, update the saved time and TSC value once > delta >= tsc_hz.

RE: [dpdk-dev v2 2/2] crypto/qat: use intel-ipsec-mb for partial hash & aes

2022-05-17 Thread Zhang, Roy Fan
> -Original Message- > From: Ji, Kai > Sent: Tuesday, May 17, 2022 3:17 PM > To: dev@dpdk.org > Cc: Ji, Kai ; Zhang, Roy Fan > Subject: [dpdk-dev v2 2/2] crypto/qat: use intel-ipsec-mb for partial hash & > aes > > Since openssl 3.0 now deprecates the low level API QAT required to > perfo

RE: [dpdk-dev v2 1/2] build: add in option for qat use intel ipsec-mb lib

2022-05-17 Thread Zhang, Roy Fan
> -Original Message- > From: Kai Ji > Sent: Tuesday, May 17, 2022 3:17 PM > To: dev@dpdk.org > Cc: Ji, Kai > Subject: [dpdk-dev v2 1/2] build: add in option for qat use intel ipsec-mb lib > > Add in build option for QAT pmd use intel ipsec-mb lib > instead openssl for precompute partial

RE: [PATCH v3] net/i40e: fix max frame size config at port level

2022-05-17 Thread Zhang, Yuying
Hi Wenxuan, > -Original Message- > From: Wu, WenxuanX > Sent: Friday, May 13, 2022 3:21 PM > To: Xing, Beilei ; Zhang, Yuying > ; dev@dpdk.org > Cc: Wu, WenxuanX ; Zhou, YidingX > ; sta...@dpdk.org > Subject: [PATCH v3] net/i40e: fix max frame size config at port level > > From: Wenxuan

[Bug 1012] The rte_sched_queue_read_stats API requires a queue_id parameter but there is no public API to generate a queue_id

2022-05-17 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1012 Bug ID: 1012 Summary: The rte_sched_queue_read_stats API requires a queue_id parameter but there is no public API to generate a queue_id Product: DPDK Version: 21.11

Re: [PATCH v2] event/cnxk: flush event queues over multiple pass

2022-05-17 Thread Jerin Jacob
On Mon, May 16, 2022 at 9:52 PM Shijith Thotton wrote: > > If an event queue flush does not complete after a fixed number of tries, > remaining queues are flushed before retrying the one with incomplete > flush. > > Signed-off-by: Shijith Thotton Applied to dpdk-next-net-eventdev/for-main. Thank

RE: [External] : [PATCH] crypto/qat: use intel-ipsec-mb for partial hash

2022-05-17 Thread Ji, Kai
Please see v2: http://patchwork.dpdk.org/project/dpdk/list/?series=22973 Regards Kai Does it mean the intel-ipsec-mb would be prerequisite of applying QAT offloading for security application? It this is the case, as I know, the intel-ipsec-mb has no FIPS certification yet. Thus I am thinking

[dpdk-dev v2 2/2] crypto/qat: use intel-ipsec-mb for partial hash & aes

2022-05-17 Thread Kai Ji
Since openssl 3.0 now deprecates the low level API QAT required to perform partial hash & aes operation when creating the session. This patch is to transfer such dependency from openssl to intel-ipsec-mb. Signed-off-by: Kai Ji Signed-off-by: Fan Zhang --- drivers/crypto/qat/qat_sym_session.c |

[dpdk-dev v2 1/2] build: add in option for qat use intel ipsec-mb lib

2022-05-17 Thread Kai Ji
Add in build option for QAT pmd use intel ipsec-mb lib instead openssl for precompute partial hash & aes. Signed-off-by: Kai Ji --- drivers/common/qat/meson.build | 12 meson_options.txt | 2 ++ 2 files changed, 14 insertions(+) diff --git a/drivers/common/qat/meson.b

RE: [PATCH v1 0/2] add a fast path for memif Rx/Tx

2022-05-17 Thread Morten Brørup
> From: Joyce Kong [mailto:joyce.k...@arm.com] > Sent: Tuesday, 17 May 2022 12.51 > > For memif non-zero-copy mode, there is a branch to compare > the mbuf and memif buffer size during memory copying. Add > a fast memory copy path by removing this branch with mbuf > and memif buffer size defined a

Re: [PATCH v4 1/5] eventdev: support to set queue attributes at runtime

2022-05-17 Thread Jerin Jacob
On Tue, May 17, 2022 at 2:25 PM Mattias Rönnblom wrote: > > On 2022-05-16 20:02, Jerin Jacob wrote: > > On Mon, May 16, 2022 at 11:09 PM Shijith Thotton > > wrote: > >> > >> Added a new eventdev API rte_event_queue_attr_set(), to set event queue > >> attributes at runtime from the values set dur

Re: [PATCH 0/5] vhost: introduce per-virtqueue stats API

2022-05-17 Thread Maxime Coquelin
On 5/17/22 15:23, Maxime Coquelin wrote: On 5/10/22 22:17, Maxime Coquelin wrote: This series introduces a new Vhost API that provides per-virtqueue statistics to the application. It will be generally useful, but initial motivation for this series was to be able to get to get virtqueues sta

Re: [RFC PATCH v3 3/8] vhost: fix async access

2022-05-17 Thread Maxime Coquelin
On 4/11/22 13:00, David Marchand wrote: vq->async accesses must be protected with vq->access_lock. Fixes: eb666d24085f ("vhost: fix async unregister deadlock") Fixes: 0c0935c5f794 ("vhost: allow to check in-flight packets for async vhost") Cc: sta...@dpdk.org Signed-off-by: David Marchand A

Re: [PATCH v3] vhost: fix deadlock when message handling failed

2022-05-17 Thread Maxime Coquelin
On 5/7/22 15:27, Wenwu Ma wrote: In vhost_user_msg_handler(), if vhost message handling failed, we should check whether the queue is locked and release the lock before returning. Or, it will cause a deadlock later. Fixes: 7f31d4ea05ca ("vhost: fix lock on device readiness notification") Cc: s

Re: [PATCH 0/5] vhost: introduce per-virtqueue stats API

2022-05-17 Thread Maxime Coquelin
On 5/10/22 22:17, Maxime Coquelin wrote: This series introduces a new Vhost API that provides per-virtqueue statistics to the application. It will be generally useful, but initial motivation for this series was to be able to get to get virtqueues stats when Virtio RSS feature will be supported

Re: [PATCH v2] vhost: add runtime locking check in unsafe APIs

2022-05-17 Thread Maxime Coquelin
On 5/11/22 08:58, Maxime Coquelin wrote: This patch adds runtime checks in unsafe Vhost async APIs, to ensure the access lock is taken. The detection won't work every time, as another thread could take the lock, but it would help to detect misuse of these unsafe API. Signed-off-by: Maxime Co

Re: [PATCH v8 0/5] vhost: support async dequeue data path

2022-05-17 Thread Maxime Coquelin
On 5/16/22 13:10, xuan.d...@intel.com wrote: From: Xuan Ding The presence of asynchronous path allows applications to offload memory copies to DMA engine, so as to save CPU cycles and improve the copy performance. This patch set implements vhost async dequeue data path for split ring. The co

Re: [PATCH v3] vhost: fix deadlock when message handling failed

2022-05-17 Thread David Marchand
On Sat, May 7, 2022 at 7:30 AM Wenwu Ma wrote: > > In vhost_user_msg_handler(), if vhost message handling > failed, we should check whether the queue is locked and > release the lock before returning. Or, it will cause a > deadlock later. > > Fixes: 7f31d4ea05ca ("vhost: fix lock on device readine

Re: [PATCH 1/1] drivers: define OPENSSL_API_COMPAT

2022-05-17 Thread David Marchand
On Tue, May 10, 2022 at 5:06 PM Heinrich Schuchardt wrote: > > The API of the OpenSSL library has changed with version 3.0. This results > in a lot of compiler warnings like > > ../dpdk/drivers/crypto/ccp/ccp_crypto.c:182:9: > warning: ‘SHA256_Transform’ is deprecated: > Since OpenSSL

RE: [EXT] [PATCH v2] cryptodev: add elliptic curve diffie hellman

2022-05-17 Thread Kusztal, ArkadiuszX
> -Original Message- > From: Kusztal, ArkadiuszX > Sent: Tuesday, May 17, 2022 1:58 PM > To: 'Akhil Goyal' ; dev@dpdk.org > Cc: Zhang, Roy Fan > Subject: RE: [EXT] [PATCH v2] cryptodev: add elliptic curve diffie hellman > > > > > -Original Message- > > From: Akhil Goyal > >

RE: [EXT] [PATCH v2] cryptodev: add elliptic curve diffie hellman

2022-05-17 Thread Kusztal, ArkadiuszX
> -Original Message- > From: Akhil Goyal > Sent: Monday, May 16, 2022 8:42 PM > To: Kusztal, ArkadiuszX ; dev@dpdk.org > Cc: Zhang, Roy Fan > Subject: RE: [EXT] [PATCH v2] cryptodev: add elliptic curve diffie hellman > > > This commit adds Elliptic Curve Diffie-Hellman option to Crypt

RE: [EXT] [PATCH] cryptodev: add support for 25519 and 448 curves

2022-05-17 Thread Kusztal, ArkadiuszX
> -Original Message- > From: Akhil Goyal > Sent: Monday, May 16, 2022 8:58 PM > To: Kusztal, ArkadiuszX ; dev@dpdk.org > Cc: Zhang, Roy Fan > Subject: RE: [EXT] [PATCH] cryptodev: add support for 25519 and 448 curves > > > This commit adds support for following elliptic curves: > > 1)

RE: [EXT] [RFC PATCH] cryptodev: add basic asymmetric crypto capability structs

2022-05-17 Thread Kusztal, ArkadiuszX
> -Original Message- > From: Akhil Goyal > Sent: Monday, May 16, 2022 8:55 PM > To: Kusztal, ArkadiuszX ; dev@dpdk.org > Cc: Zhang, Roy Fan > Subject: RE: [EXT] [RFC PATCH] cryptodev: add basic asymmetric crypto > capability structs > > Hi Arek, > > Are you planning for a formal patc

[PATCH v1 2/2] net/memif: add a Tx fast path

2022-05-17 Thread Joyce Kong
For memif non-zero-copy mode, there is a branch to compare the mbuf and memif buffer size during memory copying. If all mbufs come from the same mempool, and memif buf size >= mbuf size, add a fast Tx memory copy path without the comparing branch and with mbuf bulk free, otherwise still run the ori

[PATCH v1 1/2] net/memif: add a Rx fast path

2022-05-17 Thread Joyce Kong
For memif non-zero-copy mode, there is a branch to compare the mbuf and memif buffer size during memory copying. Add a fast memory copy path by removing this branch with mbuf and memif buffer size defined at compile time. The removal of the branch leads to considerable performance uplift. When mem

[PATCH v1 0/2] add a fast path for memif Rx/Tx

2022-05-17 Thread Joyce Kong
For memif non-zero-copy mode, there is a branch to compare the mbuf and memif buffer size during memory copying. Add a fast memory copy path by removing this branch with mbuf and memif buffer size defined at compile time. And for Tx fast path, bulk free the mbufs which come from the same mempool.

RE: [PATCH] examples/vhost: fix floating point exception when there is no VMDQ

2022-05-17 Thread Wang, YuanX
Hi Chenbo, > -Original Message- > From: Xia, Chenbo > Sent: Monday, May 16, 2022 8:57 PM > To: Wang, YuanX ; maxime.coque...@redhat.com > Cc: dev@dpdk.org; Hu, Jiayu ; He, Xingguang > > Subject: RE: [PATCH] examples/vhost: fix floating point exception when > there is no VMDQ > > Hi Yuan

Re: [PATCH v3 1/3] eventdev: add function to quiesce an event port

2022-05-17 Thread Jerin Jacob
On Fri, May 13, 2022 at 11:31 PM wrote: > > From: Pavan Nikhilesh > > Add function to quiesce any core specific resources consumed by > the event port. > > When the application decides to migrate the event port to another lcore > or teardown the current lcore it may to call `rte_event_port_quiesc

[PATCH v2] libpcapng: fix timestamp wrapping in output files

2022-05-17 Thread Quentin Armitage
In pcap_tsc_to_ns(), delta * NSEC_PER_SEC will overflow approx 8 seconds after pcap_init is called when using a TSC with a frequency of 2.5GHz. To avoid the overflow, update the saved time and TSC value once delta >= tsc_hz. Fixes: 8d23ce8f5ee ("pcapng: add new library for writing pcapng files")

[Bug 925] lib/vhost build failure with gcc 12

2022-05-17 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=925 Ali Alnubani (alia...@nvidia.com) changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--

[Bug 1011] [dpdk-22.07*] lib/vhost meson build failed with gcc12.1.1 on Fedora36/64

2022-05-17 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1011 Bug ID: 1011 Summary: [dpdk-22.07*] lib/vhost meson build failed with gcc12.1.1 on Fedora36/64 Product: DPDK Version: unspecified Hardware: All OS: All

[Bug 1010] lib/librte_metrics build failure with rhel 7.2

2022-05-17 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1010 Bug ID: 1010 Summary: lib/librte_metrics build failure with rhel 7.2 Product: DPDK Version: 22.03 Hardware: x86 OS: Linux Status: UNCONFIRMED Severity: normal

Re: [PATCH v4 1/5] eventdev: support to set queue attributes at runtime

2022-05-17 Thread Mattias Rönnblom
On 2022-05-16 20:02, Jerin Jacob wrote: > On Mon, May 16, 2022 at 11:09 PM Shijith Thotton wrote: >> >> Added a new eventdev API rte_event_queue_attr_set(), to set event queue >> attributes at runtime from the values set during initialization using >> rte_event_queue_setup(). PMD's supporting this

RE: [DPDK] eal/linux: fix segfaults due to thread exit order

2022-05-17 Thread Morten Brørup
> From: zhichaox.z...@intel.com [mailto:zhichaox.z...@intel.com] > Sent: Tuesday, 17 May 2022 18.05 > > From: Zhichao Zeng > > The eal-intr-thread is not closed before exiting the main > thread. There is a small probability that when the > eal-intr-thread is about to use some pointers, the point

[PATCH v2] net/ice: fix missing MTU value setting

2022-05-17 Thread Kevin Liu
In the DCF module, Missing maximum and minimum MTU value settings. This patch adds the settings of the maximum and minimum MTU to correctly calculate the MTU value. Fixes: bf89db4409bb ("net/ice: complete device info get in DCF") Cc: sta...@dpdk.org v2: - update fixline Signed-off-by: Kevin Liu

RE: [PATCH] net/ice: fix missing MTU value setting

2022-05-17 Thread Liu, KevinX
Sorry, I misunderstood, I will send v2 > -Original Message- > From: Liu, KevinX > Sent: 2022年5月17日 16:00 > To: Zhang, Qi Z ; dev@dpdk.org > Cc: Yang, Qiming ; Yang, SteveX > ; sta...@dpdk.org > Subject: RE: [PATCH] net/ice: fix missing MTU value setting > > > > > -Original Message--

[DPDK] eal/linux: fix segfaults due to thread exit order

2022-05-17 Thread zhichaox . zeng
From: Zhichao Zeng The eal-intr-thread is not closed before exiting the main thread. There is a small probability that when the eal-intr-thread is about to use some pointers, the pointers were just released in the process of exiting, which cause the segment fault error caught by ASan. Close the

RE: [PATCH] net/ice: fix missing MTU value setting

2022-05-17 Thread Liu, KevinX
> -Original Message- > From: Zhang, Qi Z > Sent: 2022年5月17日 15:50 > To: Liu, KevinX ; dev@dpdk.org > Cc: Yang, Qiming ; Yang, SteveX > ; sta...@dpdk.org > Subject: RE: [PATCH] net/ice: fix missing MTU value setting > > > > > -Original Message- > > From: Liu, KevinX > > Sent:

RE: [PATCH v4 1/2] config/arm: add SVE ACLE control flag

2022-05-17 Thread Juraj Linkeš
> -Original Message- > From: Rahul Bhansali > Sent: Monday, May 9, 2022 12:20 PM > To: dev@dpdk.org; Ruifeng Wang ; Jan Viktorin > ; Bruce Richardson > Cc: jer...@marvell.com; Rahul Bhansali > Subject: [PATCH v4 1/2] config/arm: add SVE ACLE control flag > > This add the control flag

RE: [PATCH] net/ice: fix missing MTU value setting

2022-05-17 Thread Zhang, Qi Z
> -Original Message- > From: Liu, KevinX > Sent: Friday, April 8, 2022 3:57 AM > To: dev@dpdk.org > Cc: Yang, Qiming ; Zhang, Qi Z > ; Yang, SteveX ; Liu, KevinX > ; sta...@dpdk.org > Subject: [PATCH] net/ice: fix missing MTU value setting > > In the DCF module, Missing maximum and min

RE: [PATCH v2] net/ice/base: fix direction match of flow that matches any

2022-05-17 Thread Zhang, Qi Z
> -Original Message- > From: Zhang, Yuying > Sent: Thursday, May 12, 2022 3:42 PM > To: dev@dpdk.org; Zhang, Qi Z ; Yang, Qiming > > Cc: Zhang, Yuying ; sta...@dpdk.org > Subject: [PATCH v2] net/ice/base: fix direction match of flow that matches any > > The tx/rx packets were dropped whe

RE: [PATCH v2] net/ice: fix DCF state checking mechanism

2022-05-17 Thread Zhang, Qi Z
> -Original Message- > From: Zhang, Peng1X > Sent: Wednesday, May 11, 2022 11:50 PM > To: Yang, Qiming ; Zhang, Qi Z > ; dev@dpdk.org > Cc: Zhang, Peng1X ; sta...@dpdk.org > Subject: [PATCH v2] net/ice: fix DCF state checking mechanism > > From: Peng Zhang > > DCF state previous chec

[PATCH v2] raw/afu_mf: introduce AFU MF device driver

2022-05-17 Thread Wei Huang
Add afu_mf driver to manage various AFU (Acceleration Function Unit) in FPGA. Signed-off-by: Wei Huang Acked-by: Tianfei Zhang --- v2: fix typo --- drivers/raw/afu_mf/afu_mf_rawdev.c | 440 drivers/raw/afu_mf/afu_mf_rawdev.h | 89 ++ drivers/raw/afu_mf/he_hssi.c | 369 +++

RE: [PATCH v6] fix mbuf release function point corrupt in multi-process

2022-05-17 Thread Zhang, Qi Z
> -Original Message- > From: Ke Zhang > Sent: Monday, May 16, 2022 2:55 PM > To: Li, Xiaoyun ; Wu, Jingjing ; > Xing, Beilei ; dev@dpdk.org > Cc: Zhang, Ke1X > Subject: [PATCH v6] fix mbuf release function point corrupt in multi-process > Please fix the title format > In the multipl

RE: [PATCH v11 0/7] Enable ETS-based TX QoS on PF

2022-05-17 Thread Zhang, Qi Z
> -Original Message- > From: Wu, Wenjun1 > Sent: Tuesday, May 17, 2022 1:09 PM > To: dev@dpdk.org; Yang, Qiming ; Zhang, Qi Z > > Subject: [PATCH v11 0/7] Enable ETS-based TX QoS on PF > > This patch set enables ETS-based TX QoS on PF. It is supported to configure > bandwidth and prio

Re: [PATCH] net/bnxt: fix compatibility with some old firmwares

2022-05-17 Thread Thomas Monjalon
30/03/2022 01:21, Ajit Khaparde: > On Fri, Mar 18, 2022 at 8:03 AM David Marchand > wrote: > > > > This reverts commit 3972281f47b2cc0cf844698885f0e6b4228c0975. > > > > Reported by Red Hat QE: with older firmware versions (at least versions > > 20.6.112.0 and 20.6.143.0), initialisation never succ