[PATCH v3] eventdev/eth_rx: fix memory leak when token parsing finished

2022-02-02 Thread Weiguo Li
The memory get from strdup should be freed when parameter parsing finished, and also should be freed when error occurs. Fixes: 814d01709328 ("eventdev/eth_rx: support telemetry") Fixes: 9e583185318f ("eventdev/eth_rx: support telemetry") Signed-off-by: Weiguo Li --- v3: * validate "eth_dev_id"

Re: [dpdk-dev] [PATCH 1/3] app/testpmd: fix port status of active slave device

2022-02-02 Thread Singh, Aman Deep
On 11/16/2021 6:50 AM, lihuisong (C) wrote: 在 2021/11/15 21:01, Singh, Aman Deep 写道: On 10/25/2021 12:09 PM, Min Hu (Connor) wrote: From: Huisong Li Stopping a bond device also stops all active slaves under the bond device. If this port is bond device, we need to modify the port status of

Re: [PATCH] eventdev/eth_rx: fix memory leak when token parsing finished

2022-02-02 Thread Stephen Hemminger
On Wed, 2 Feb 2022 15:13:22 +0800 Weiguo Li wrote: > The memory get from strdup should be freed when parameter parsing > finished, and also should be freed when error occurs. > > Fixes: 814d01709328 ("eventdev/eth_rx: support telemetry") > Fixes: 9e583185318f ("eventdev/eth_rx: support telemetr

[PATCH 2/2] eal: support systemd service convention for runtime directory

2022-02-02 Thread Stephen Hemminger
Systemd.exec supports configuring the runtime directory of a service via RuntimeDirectory=. This creates the directory with the necessary permissions which actual service may not have if running in container. The change to DPDK is to look for the environment RUNTIME_DIRECTORY first and use that in

[PATCH 1/2] eal: remove size for eal_set_runtime_dir

2022-02-02 Thread Stephen Hemminger
The size argument to eal_set_runtime_dir is useless and was being used incorrectly in strlcpy. It worked only because all callers passed PATH_MAX which is same as sizeof the destination runtime_dir. Note: this is an internal API so no user exposed change. Fixes: 57a2efb30477 ("eal: move OS common

[PATCH 0/2] better support of configuring runtime directory

2022-02-02 Thread Stephen Hemminger
Found this while exploring running a DPDK service with systemd container environment. It helps if the place DPDK puts its runtime directory is configurable. This version supersedes earlier RFC and includes the feedback. Stephen Hemminger (2): eal: remove size for eal_set_runtime_dir eal: supp

RE: RE:[PATCH v2] eventdev/eth_rx: fix memory leak when token parsing finished

2022-02-02 Thread Kundapura, Ganapati
Hi Weighuo, > -Original Message- > From: Weiguo Li > Sent: 03 February 2022 09:08 > To: Kundapura, Ganapati > Cc: Jayatheerthan, Jay ; Naga Harish K, S V > ; dev@dpdk.org > Subject: RE:[PATCH v2] eventdev/eth_rx: fix memory leak when token > parsing finished > > Hi Ganapati, > > Thanks

RE: cryto_aesni_mb device data contaminated and causing crash when supporting vdev_scan/vdev_action

2022-02-02 Thread Changchun Zhang
The issue can be resolved by allocating the mb_mgr only for the primary process in the PMD probe/create function of the aesni_mb_pmd. Disabling the scanning/probe is just a work around, I guess that is the reason why the fix in this https://review.spdk.io/gerrit/c/spdk/dpdk/+/1056

RE:[PATCH v2] eventdev/eth_rx: fix memory leak when token parsing finished

2022-02-02 Thread Weiguo Li
Hi Ganapati, Thanks for your reminding. I'm a bit confused by "eth_dev_id validate" you metiond below. I'll post a new patch for your review if this make clear. Thanks, -Weiguo > -- Original -- > From: "Kundapura, Ganapati" ; > Date: Thu, Feb 3, 2022 00:47 AM > T

Re: [PATCH] eal/windows: set pthread affinity

2022-02-02 Thread Thomas Monjalon
> > > Sometimes OS tries to switch the core. So, bind the lcore thread to a > > > fixed core. > > > Implement affinity call on Windows similar to Linux. > > > > > > Signed-off-by: Qiao Liu > > > Signed-off-by: Pallavi Kadam > > Acked-by: Tal Shnaiderman > Tested-by: Idan Hackmon Applied, thank

Re: [PATCH v2] mempool: test performance with constant n

2022-02-02 Thread Thomas Monjalon
24/01/2022 15:59, Olivier Matz: > From: Morten Brørup > > "What gets measured gets done." > > This patch adds mempool performance tests where the number of objects to > put and get is constant at compile time, which may significantly improve > the performance of these functions. [*] > > Also, i

Re: [PATCH v2 0/6] Fast restart with many hugepages

2022-02-02 Thread David Marchand
Hello Dmitry, On Wed, Jan 19, 2022 at 10:09 PM Dmitry Kozlyuk wrote: > > This patchset is a new design and implementation of [1]. > > v2: > * Fix hugepage file removal when they are no longer used. > Disable removal with --huge-unlink=never as intended. > Document this behavior differen

Re: [RFC] eal: support systemd service convention for runtime directory

2022-02-02 Thread Stephen Hemminger
On Wed, 02 Feb 2022 22:03:44 +0100 Thomas Monjalon wrote: > 07/01/2022 13:07, Bruce Richardson: > > On Thu, Dec 23, 2021 at 03:39:07PM -0800, Stephen Hemminger wrote: > > > Systemd.exec supports configuring the runtime directory of a service > > > via RuntimeDirectory=. This creates the directo

Re: [RFC] eal: support systemd service convention for runtime directory

2022-02-02 Thread Thomas Monjalon
07/01/2022 13:07, Bruce Richardson: > On Thu, Dec 23, 2021 at 03:39:07PM -0800, Stephen Hemminger wrote: > > Systemd.exec supports configuring the runtime directory of a service > > via RuntimeDirectory=. This creates the directory with the necessary > > permissions which actual service may not hav

Re: [PATCH v2] devtools/cocci: update cocci for ethdev namespace

2022-02-02 Thread Thomas Monjalon
23/01/2022 18:20, Aman Singh: > Added two specific exceptions for ETH_SPEED_10G > and ETH_SPEED_25G to avoid there name change. > Added check for ETH_TUNNEL_FILTER and ETH_RSS_RETA Please could you explain why?

Re: [dpdk-dev] [PATCH v2] build: add definitions for use as meson subproject

2022-02-02 Thread Thomas Monjalon
05/11/2021 19:11, Bruce Richardson: > On Fri, Nov 05, 2021 at 10:22:13AM -0700, Stephen Hemminger wrote: > > +# If DPDK is being built as subproject then define > > +# variable with the dependency convention > > +if meson.is_subproject() > > +libdpdk_dep = declare_dependency( > > +versi

Re: [PATCH v1] doc: fix KNI PMD name typo

2022-02-02 Thread Thomas Monjalon
19/01/2022 18:29, Ferruh Yigit: > On 1/19/2022 12:26 PM, Haiyue Wang wrote: > > The KNI PMD name should be "net_kni". > > > > Fixes: 75e2bc54c018 ("net/kni: add KNI PMD") > > Cc: sta...@dpdk.org > > > > Signed-off-by: Haiyue Wang > > Acked-by: Ferruh Yigit Applied, thanks.

Re: [PATCH v3] kni: fix ioctl signature

2022-02-02 Thread Thomas Monjalon
03/12/2021 17:28, Stephen Hemminger: > On Fri, 3 Dec 2021 08:19:07 +0100 > Markus Theil wrote: > > > From: Markus Theil > > > > Fix kni's ioctl signature to correctly match the kernel's > > structs. This shaves off the (void*) casts and uses struct file* > > instead of struct inode*. With the

[PATCH] eal: remove unnecessary argv[0] handling

2022-02-02 Thread Stephen Hemminger
The rte_eal_init function looks at argv[0] to determine the program name to pass to the log init function. This is both unnecessary and in a corner case a problem. Parsing argv[0] is unnecessary because the function openlog() already determines the log identifier from program name if NULL is passe

RE: 回复: [RFC PATCH v1 0/4] Direct re-arming of buffers on receive side

2022-02-02 Thread Honnappa Nagarahalli
> > > > > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > > > Sent: Tuesday, 18 January 2022 17.54 > > > > > > > > [quick summary: ethdev API to bypass mempool] > > > > > > > > 18/01/2022 16:51, Ferruh Yigit: > > > > > On 12/28/2021 6:55 AM, Feifei Wang wrote: > > > > > > Morten Brørup :

Re: [PATCH v6] kni: allow configuring the kni thread granularity

2022-02-02 Thread Thomas Monjalon
20/01/2022 13:41, Tudor Cornea: > The Kni kthreads seem to be re-scheduled at a granularity of roughly > 1 millisecond right now, which seems to be insufficient for performing > tests involving a lot of control plane traffic. > > Even if KNI_KTHREAD_RESCHEDULE_INTERVAL is set to 5 microseconds, it

RE: [PATCH v6 20/50] pdump: remove unneeded header includes

2022-02-02 Thread Morten Brørup
> From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Wednesday, 2 February 2022 18.29 > > On Wed, 2 Feb 2022 17:03:44 + > Bruce Richardson wrote: > > > On Wed, Feb 02, 2022 at 05:45:47PM +0100, Morten Brørup wrote: > > > > From: Bruce Richardson [mailto:bruce.richard...@inte

Re: [PATCH] build: remove deprecated meson functions

2022-02-02 Thread Thomas Monjalon
24/01/2022 19:12, Jerin Jacob: > On Mon, Jan 24, 2022 at 11:20 PM Bruce Richardson > wrote: > > > > Starting in meson 0.56, the functions meson.source_root() and > > meson.build_root() are deprecated and to be replaced by the [more > > descriptive] functions: project_source_root()/global_source_ro

Re: [PATCH 0/8] net/sfc: improve flow action RSS support on EF100 boards

2022-02-02 Thread Ferruh Yigit
On 2/1/2022 8:49 AM, Ivan Malov wrote: The first patch reworks flow action RSS support in general, on all board types. Later patches add support for EF100-specific features: the even spread mode (no indirection table) and the ability to select indirection table size in the normal mode. Ivan Malo

Re: [Bug 932] tap stop fails because of 'tap_lsc_intr_handle_set()' failure

2022-02-02 Thread kumaraparameshwaran rathinavel
On Tue, Feb 1, 2022, 10:34 PM wrote: > https://bugs.dpdk.org/show_bug.cgi?id=932 > > Bug ID: 932 >Summary: tap stop fails because of 'tap_lsc_intr_handle_set()' > failure >Product: DPDK >Version: 20.11 > Hardware: All >

Re: [PATCH v6 20/50] pdump: remove unneeded header includes

2022-02-02 Thread Stephen Hemminger
On Wed, 2 Feb 2022 17:03:44 + Bruce Richardson wrote: > On Wed, Feb 02, 2022 at 05:45:47PM +0100, Morten Brørup wrote: > > > From: Bruce Richardson [mailto:bruce.richard...@intel.com] > > > Sent: Wednesday, 2 February 2022 17.01 > > > > > > On Wed, Feb 02, 2022 at 07:54:58AM -0800, Stephen H

Re: [PATCH v6 20/50] pdump: remove unneeded header includes

2022-02-02 Thread Bruce Richardson
On Wed, Feb 02, 2022 at 05:45:47PM +0100, Morten Brørup wrote: > > From: Bruce Richardson [mailto:bruce.richard...@intel.com] > > Sent: Wednesday, 2 February 2022 17.01 > > > > On Wed, Feb 02, 2022 at 07:54:58AM -0800, Stephen Hemminger wrote: > > > On Wed, 2 Feb 2022 09:47:32 + > > > Sean Mo

RE: [PATCH v2] eventdev/eth_rx: fix memory leak when token parsing finished

2022-02-02 Thread Kundapura, Ganapati
Hi Weiguo, Also noticed that usage of macros like RTE_EVENT_ETH_RX_ADAPTER_ID_VALID_OR_ERR_RET and RTE_ETH_VALID_PORTID_OR_ERR_RET to validate rx_adapter_id and eth_dev_id returns error bypassing the freeing of memory get from strdup() in error case. Thanks, Ganapati > -Original Message

RE: [PATCH v6 20/50] pdump: remove unneeded header includes

2022-02-02 Thread Morten Brørup
> From: Bruce Richardson [mailto:bruce.richard...@intel.com] > Sent: Wednesday, 2 February 2022 17.01 > > On Wed, Feb 02, 2022 at 07:54:58AM -0800, Stephen Hemminger wrote: > > On Wed, 2 Feb 2022 09:47:32 + > > Sean Morrissey wrote: > > > > > These header includes have been flagged by the iw

cryto_aesni_mb device data contaminated and causing crash when supporting vdev_scan/vdev_action

2022-02-02 Thread Changchun Zhang
Hi, Has anyone noticed that crypto_aesni_mb virtual crypto device has issue of memory crash caused by the scanning and probe on secondary process. Can anyone cast any lights on it. What I encountered is: On the primary process, the crypto_aesni_mb device is probed and created successfully and I

Re: [PATCH v6 20/50] pdump: remove unneeded header includes

2022-02-02 Thread Bruce Richardson
On Wed, Feb 02, 2022 at 07:54:58AM -0800, Stephen Hemminger wrote: > On Wed, 2 Feb 2022 09:47:32 + > Sean Morrissey wrote: > > > These header includes have been flagged by the iwyu_tool > > and removed. > > > > Signed-off-by: Sean Morrissey > > --- > > lib/pdump/rte_pdump.c | 1 - > > lib

Re: [PATCH v6 22/50] pcapng: remove unneeded header includes

2022-02-02 Thread Stephen Hemminger
On Wed, 2 Feb 2022 09:47:34 + Sean Morrissey wrote: > These header includes have been flagged by the iwyu_tool > and removed. > > Signed-off-by: Sean Morrissey > --- > lib/pcapng/rte_pcapng.c | 1 - > lib/pcapng/rte_pcapng.h | 2 -- > 2 files changed, 3 deletions(-) > > diff --git a/lib/

Re: [PATCH v6 20/50] pdump: remove unneeded header includes

2022-02-02 Thread Stephen Hemminger
On Wed, 2 Feb 2022 09:47:32 + Sean Morrissey wrote: > These header includes have been flagged by the iwyu_tool > and removed. > > Signed-off-by: Sean Morrissey > --- > lib/pdump/rte_pdump.c | 1 - > lib/pdump/rte_pdump.h | 2 -- > 2 files changed, 3 deletions(-) > > diff --git a/lib/pdum

Re: [PATCH] build: fix meson warning about using compiler warning flags

2022-02-02 Thread Thomas Monjalon
21/01/2022 17:41, Luca Boccassi: > On Fri, 2022-01-21 at 15:53 +, Bruce Richardson wrote: > > Each build, meson would issue a warning reporting that the > > "warning_level" setting should be used in place of adding -Wextra > > directly to our build commands. Testing with meson 0.61 shows that t

Re: [PATCH v3 0/5] Add JSON vector set support to fips validation

2022-02-02 Thread Brandon Lo
Hi Fan and Ciara, Could you please review this patch set? Not sure who the maintainer of the fips_validation example is (I think Marko Kovacevic stopped working on the FIPS validation example). Thanks, Brandon -- Brandon Lo UNH InterOperability Laboratory 21 Madbury Rd, Suite 100, Durham, NH 0

RE: [PATCH v2] eventdev/eth_rx: fix memory leak when token parsing finished

2022-02-02 Thread Kundapura, Ganapati
Hi Weigo, Could you please address the below issues also? Thanks, Ganapati > -Original Message- > From: Kundapura, Ganapati > Sent: 02 February 2022 13:18 > To: Weiguo Li ; Jayatheerthan, Jay > > Cc: Naga Harish K, S V ; dev@dpdk.org > Subject: RE: [PATCH v2] eventdev/eth_rx: fix memo

[Bug 882] ixgbe dirver may cause some unreleased mbufs be reused by application

2022-02-02 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=882 Thomas Monjalon (tho...@monjalon.net) changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolutio

[Bug 921] meson build warnings with 0.61.1

2022-02-02 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=921 Thomas Monjalon (tho...@monjalon.net) changed: What|Removed |Added Resolution|--- |FIXED Status|U

Re: [PATCH v2] build: fix warnings when running external commands

2022-02-02 Thread Thomas Monjalon
24/01/2022 15:08, Jerin Jacob: > On Thu, Jan 20, 2022 at 11:37 PM Bruce Richardson > wrote: > > > > Meson 0.61.1 is giving warnings that the calls to run_command do not > > always explicitly specify if the result is to be checked or not, i.e. > > there is a missing "check" parameter. This is becau

Re: [PATCH v5 1/1] eal: add internal function to get base address

2022-02-02 Thread Thomas Monjalon
Dmitry, Anatoly, any new comment on this v5? 18/01/2022 14:33, Srikanth Yalavarthi: > Added an internal helper to get OS-specific EAL mapping base address > > This helper can be used by the drivers to program offload / accelerator > devices, where the base address can be used as a reference addr

Re: [PATCH 1/1] ci: restrict concurrency

2022-02-02 Thread Thomas Monjalon
Aaron, David, Please could you review this patch? Thanks 13/01/2022 13:41, Josh Soref: > On Thu, Jan 13, 2022, 6:42 AM Thomas Monjalon wrote: > > > Hi, > > > > The explanation should be in the patch, not the cover letter. > > Actually, you don't need a cover letter for a single patch. > > Copyin

Re: [PATCH v2 0/6] Fast restart with many hugepages

2022-02-02 Thread Thomas Monjalon
2 weeks passed without any new comment except a test by Bruce. I would prefer avoiding a merge in the last minute. Anatoly, any comment? 19/01/2022 22:09, Dmitry Kozlyuk: > This patchset is a new design and implementation of [1]. > > v2: > * Fix hugepage file removal when they are no longer us

Re: [EXT] Re: [PATCH v3 1/4] ethdev: introduce IP reassembly offload

2022-02-02 Thread Ferruh Yigit
On 2/2/2022 10:57 AM, Akhil Goyal wrote: +/* Flag to offload IP reassembly for IPv4 packets. */ +#define RTE_ETH_DEV_REASSEMBLY_F_IPV4 (RTE_BIT32(0)) +/* Flag to offload IP reassembly for IPv6 packets. */ +#define RTE_ETH_DEV_REASSEMBLY_F_IPV6 (RTE_BIT32(1)) +/** + * A structure used to get/set I

Re: [EXT] Re: [PATCH v3 4/4] security: add IPsec option for IP reassembly

2022-02-02 Thread Ferruh Yigit
On 2/2/2022 9:15 AM, Akhil Goyal wrote: On 1/30/2022 5:59 PM, Akhil Goyal wrote: A new option is added in IPsec to enable and attempt reassembly of inbound packets. Signed-off-by: Akhil Goyal --- devtools/libabigail.abignore | 14 ++ lib/security/rte_security.h | 12 +

Re: [RFC] Python Version for DTS

2022-02-02 Thread Owen Hilyard
After some discussion in the working group, we decided that this is mostly a question of what the labs can support. The UNH Lab uses the version of python that ships with the latest Ubuntu LTS, which is 3.8. The Intel Lab is in a similar situation. Are there any objections to python 3.8 with update

Re: [PATCH] add missing file to meson build for installation

2022-02-02 Thread Thomas Monjalon
01/02/2022 10:26, Bruce Richardson: > On Mon, Jan 31, 2022 at 10:48:21PM +, Martijn Bakker wrote: > > Signed-off-by: Martijn Bakker > > --- > > + Cc: sta...@dpdk.org > > Acked-by: Bruce Richardson > > Originally buggy commit is hard to determine, but I believe the fixline > should be: > >

RE: [PATCH v1] net/mlx5: adding extern C to rte_pmd_mlx5.h

2022-02-02 Thread Raslan Darawsheh
Hi, > -Original Message- > From: eagost...@nvidia.com > Sent: Friday, December 17, 2021 1:39 AM > To: dev@dpdk.org > Cc: Elena Agostini > Subject: [PATCH v1] net/mlx5: adding extern C to rte_pmd_mlx5.h > > From: Elena Agostini > > The support for linking rte_pmd_mlx5.h functions with

Re: [PATCH v6 01/50] devtools: script to remove unused headers includes

2022-02-02 Thread Thomas Monjalon
02/02/2022 10:47, Sean Morrissey: > This script can be used for removing headers flagged for removal by the > include-what-you-use (IWYU) tool. The script has the ability to remove > headers from specified sub-directories or dpdk as a whole and tests the > build after each removal by calling meson

Re: [PATCH] net/enic: adjust memory check and use in proper order

2022-02-02 Thread ??????
This fix only moves the memcpy after null check.  so the misplaced of memcpy and null check is reordered. I thought it's too trival a fix to add more explanation. Sorry if makes any confusion. -Weiguo > -Original Message- > From: "Thomas Monjalon"

RE: [PATCH v2 03/10] ethdev: bring in async queue-based flow rules

2022-02-02 Thread Ori Kam
Hi Ivan, > -Original Message- > From: Ivan Malov > Sent: Wednesday, February 2, 2022 1:24 AM > Subject: RE: [PATCH v2 03/10] ethdev: bring in async queue-based flow rules > > Hi Ori, Alexander, > > On Tue, 1 Feb 2022, Ori Kam wrote: > > > Hi > > > >> -Original Message- > >> Fro

Re: [PATCH 5/8] common/sfc_efx/base: support selecting RSS table entry count

2022-02-02 Thread Ivan Malov
Hi, On Wed, 2 Feb 2022, Ray Kinsella wrote: Ivan Malov writes: On Riverhead boards, the client can control how many entries to have in the indirection table of an exclusive RSS context. Provide the new parameter to clients and indicate its bounds. Extend the API for writing the table to ha

RE: [PATCH v1 1/2] net/axgbe: add support for Yellow Carp ethernet device

2022-02-02 Thread Sebastian, Selwin
[AMD Official Use Only] Hi Ferruh, Linux kernel also handles it the same way using root complex ID (https://lore.kernel.org/netdev/20211217111557.1099919-3-rrang...@amd.com/T/) Documentation on v3xxx CPU is not yet available in public domain. Thanks and Regards Selwin Sebastian -Original Me

Re: [PATCH 5/8] common/sfc_efx/base: support selecting RSS table entry count

2022-02-02 Thread Ray Kinsella
Ivan Malov writes: > On Riverhead boards, the client can control how many entries > to have in the indirection table of an exclusive RSS context. > > Provide the new parameter to clients and indicate its bounds. > Extend the API for writing the table to have the flexibility. > > Signed-off-by:

Re: [PATCH] net/enic: adjust memory check and use in proper order

2022-02-02 Thread Thomas Monjalon
> > Subject: [PATCH] net/enic: adjust memory check and use in proper order > > > > Fixes: bb66d562aefc ("net/enic: share flow actions with same signature") > > > > Signed-off-by: Weiguo Li > > > > Reviewed-by: John Daley > > > Applied to dpdk-next-net/main, thanks. Please could we have a lit

Re: [dpdk-dev] [PATCH v7 1/4] ethdev: support device reset and recovery events

2022-02-02 Thread Ray Kinsella
Ferruh Yigit writes: > On 1/28/2022 12:48 PM, Kalesh A P wrote: >> From: Kalesh AP >> Adding support for the device reset and recovery events in the >> rte_eth_event framework. FW error and FW reset conditions would be >> managed internally by the PMD without needing application intervention.

rte_devargs_parse

2022-02-02 Thread Dmitry Kozlyuk
Hello, /** * Parse a device string. * * Verify that a bus is capable of handling the device passed * in argument. Store which bus will handle the device, its name * and the eventual device parameters. * * [SNIP] * * @param da * The devargs structure holding the device information. *

RE: [EXT] Re: [PATCH v3 1/4] ethdev: introduce IP reassembly offload

2022-02-02 Thread Akhil Goyal
> > +/* Flag to offload IP reassembly for IPv4 packets. */ > > +#define RTE_ETH_DEV_REASSEMBLY_F_IPV4 (RTE_BIT32(0)) > > +/* Flag to offload IP reassembly for IPv6 packets. */ > > +#define RTE_ETH_DEV_REASSEMBLY_F_IPV6 (RTE_BIT32(1)) > > +/** > > + * A structure used to get/set IP reassembly config

Re: [PATCH v1 1/2] net/axgbe: add support for Yellow Carp ethernet device

2022-02-02 Thread Ferruh Yigit
On 2/2/2022 8:56 AM, Sebastian, Selwin wrote: [AMD Official Use Only] Hi Ferruh, Yellow Carp is the name of the new V3xxx series CPU with same ethernet IP and same PCI id as older generation CPUs. We are using root complex device PCI ID to differentiate the CPUs so that right window settings c

[PATCH v4] mempool: fix mempool cache flushing algorithm

2022-02-02 Thread Morten Brørup
This patch fixes the rte_mempool_do_generic_put() caching algorithm, which was fundamentally wrong, causing multiple performance issues when flushing. Although the bugs do have serious performance implications when flushing, the function did not fail when flushing (or otherwise). Backporting could

RE: [PATCH] app/testpmd: skip stopped queues when forwarding

2022-02-02 Thread Dmitry Kozlyuk
> From: Dmitry Kozlyuk > Sent: Thursday, January 13, 2022 12:21 PM Hi Aman, Xiaoyun, Yuying, Any comments on the proposed behavior or the code?

Re: [PATCH 2/2] app/testpmd: fix stack overflow for EEPROM display

2022-02-02 Thread Singh, Aman Deep
Hi Steve The patch looks ok to me. On 1/20/2022 8:29 AM, Steve Yang wrote: When the size of EEPROM exceeds the default thread stack size(8MB), e.g.: 10Mb size, it will be cashed with stack overflow. Just spelling: 10Mb/10MB, cashed/crashed Can even rephrase, like: it will crash due to stack ove

[PATCH v6 50/50] acl: remove unneeded header includes

2022-02-02 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/acl/rte_acl.c | 1 - 1 file changed, 1 deletion(-) diff --git a/lib/acl/rte_acl.c b/lib/acl/rte_acl.c index 4e693b2488..a61c3ba188 100644 --- a/lib/acl/rte_acl.c +++ b/lib/acl/rte_acl.c @

[PATCH v6 49/50] cryptodev: remove unneeded header includes

2022-02-02 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/cryptodev/cryptodev_pmd.h | 4 lib/cryptodev/rte_cryptodev.c | 11 --- lib/cryptodev/rte_cryptodev.h | 2 -- 3 files changed, 17 deletions(-) diff --git a/lib/cryptodev/cry

[PATCH v6 48/50] bbdev: remove unneeded header includes

2022-02-02 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/bbdev/rte_bbdev.c | 4 lib/bbdev/rte_bbdev.h | 4 2 files changed, 8 deletions(-) diff --git a/lib/bbdev/rte_bbdev.c b/lib/bbdev/rte_bbdev.c index 7f353d4f7e..aaee7b7872 100644

[PATCH v6 47/50] bpf: remove unneeded header includes

2022-02-02 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/bpf/bpf.c | 4 lib/bpf/bpf_exec.c | 6 -- lib/bpf/bpf_jit_x86.c | 5 - lib/bpf/bpf_load.c | 8 lib/bpf/bpf_pkt.c | 12 lib/bpf

[PATCH v6 46/50] cmdline: remove unneeded header includes

2022-02-02 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/cmdline/cmdline.c| 2 -- lib/cmdline/cmdline_parse.c | 3 --- lib/cmdline/cmdline_parse_portlist.c | 3 --- lib/cmdline/cmdline_parse_string.c | 4 lib/cmdl

[PATCH v6 45/50] compressdev: remove unneeded header includes

2022-02-02 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/compressdev/rte_comp.c| 1 - lib/compressdev/rte_comp.h| 1 - lib/compressdev/rte_compressdev.c | 1 - lib/compressdev/rte_compressdev.h | 1 - lib/compress

[PATCH v6 44/50] distributor: remove unneeded header includes

2022-02-02 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey Acked-by: David Hunt --- lib/distributor/rte_distributor.c | 2 -- lib/distributor/rte_distributor_match_sse.c | 2 -- lib/distributor/rte_distributor_single.c| 2 -- 3 files change

[PATCH v6 43/50] dmadev: remove unneeded header includes

2022-02-02 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/dmadev/rte_dmadev.h | 1 - 1 file changed, 1 deletion(-) diff --git a/lib/dmadev/rte_dmadev.h b/lib/dmadev/rte_dmadev.h index 4abe79c536..ad9e7a0975 100644 --- a/lib/dmadev/rte_dmadev.h +

[PATCH v6 42/50] efd: remove unneeded header includes

2022-02-02 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/efd/rte_efd.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/lib/efd/rte_efd.c b/lib/efd/rte_efd.c index 86ef46863c..560cd78961 100644 --- a/lib/efd/rte_efd.c +++ b/lib/efd/rte_efd.

[PATCH v6 41/50] eventdev: remove unneeded header includes

2022-02-02 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/eventdev/rte_event_ring.c | 6 -- lib/eventdev/rte_event_ring.h | 2 -- lib/eventdev/rte_event_timer_adapter.c | 5 - lib/eventdev/rte_event_timer_adapter.h |

[PATCH v6 40/50] fib: remove unneeded header includes

2022-02-02 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/fib/dir24_8.c | 4 lib/fib/rte_fib.c | 2 -- lib/fib/rte_fib.h | 1 - lib/fib/rte_fib6.c | 2 -- lib/fib/rte_fib6.h | 1 - lib/fib/trie.c | 5 - lib/fib/trie.h | 2 --

[PATCH v6 39/50] flow_classify: remove unneeded header includes

2022-02-02 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/flow_classify/rte_flow_classify.c | 3 --- lib/flow_classify/rte_flow_classify.h | 4 lib/flow_classify/rte_flow_classify_parse.c | 1 - lib/flow_classify/rte_flow_classif

[PATCH v6 38/50] gpudev: remove unneeded header includes

2022-02-02 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/gpudev/gpudev.c | 1 - 1 file changed, 1 deletion(-) diff --git a/lib/gpudev/gpudev.c b/lib/gpudev/gpudev.c index 59e2169292..1083a3003e 100644 --- a/lib/gpudev/gpudev.c +++ b/lib/gpudev/

[PATCH v6 37/50] graph: remove unneeded header includes

2022-02-02 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/graph/graph_debug.c| 2 -- lib/graph/graph_ops.c | 1 - lib/graph/graph_populate.c | 2 -- lib/graph/node.c | 1 - 4 files changed, 6 deletions(-) diff --git a/lib/grap

[PATCH v6 36/50] gro: remove unneeded header includes

2022-02-02 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/gro/gro_tcp4.c | 1 - lib/gro/gro_tcp4.h | 2 -- lib/gro/gro_udp4.c | 1 - lib/gro/gro_udp4.h | 2 -- lib/gro/gro_vxlan_tcp4.c | 1 - lib/gro/gro_vxlan_udp4.c | 1 -

[PATCH v6 35/50] hash: remove unneeded header includes

2022-02-02 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/hash/rte_cuckoo_hash.c | 4 lib/hash/rte_fbk_hash.c| 6 -- lib/hash/rte_fbk_hash.h| 1 - lib/hash/rte_thash.c | 1 - lib/hash/rte_thash.h | 1 - 5 files change

[PATCH v6 32/50] jobstats: remove unneeded header includes

2022-02-02 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/jobstats/rte_jobstats.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/lib/jobstats/rte_jobstats.c b/lib/jobstats/rte_jobstats.c index 9b8fde5d55..af565a14ea 100644 --- a/lib/jobsta

[PATCH v6 33/50] ipsec: remove unneeded header includes

2022-02-02 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/ipsec/esp_inb.c | 1 - lib/ipsec/esp_outb.c | 1 - lib/ipsec/ipsec_sad.c | 1 - lib/ipsec/sa.c| 3 --- lib/ipsec/sa.h| 1 - 5 files changed, 7 deletions(-) diff --git a

[PATCH v6 34/50] ip_frag: remove unneeded header includes

2022-02-02 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/ip_frag/rte_ip_frag_common.c | 1 - lib/ip_frag/rte_ipv4_fragmentation.c | 2 -- 2 files changed, 3 deletions(-) diff --git a/lib/ip_frag/rte_ip_frag_common.c b/lib/ip_frag/rte_ip_fra

[PATCH v6 30/50] latencystats: remove unneeded header includes

2022-02-02 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/latencystats/rte_latencystats.c | 4 1 file changed, 4 deletions(-) diff --git a/lib/latencystats/rte_latencystats.c b/lib/latencystats/rte_latencystats.c index ab8db7a139..8985a377

[PATCH v6 31/50] kni: remove unneeded header includes

2022-02-02 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/kni/rte_kni.c | 2 -- lib/kni/rte_kni.h | 2 -- 2 files changed, 4 deletions(-) diff --git a/lib/kni/rte_kni.c b/lib/kni/rte_kni.c index fc8f0e7b5a..7971c56bb4 100644 --- a/lib/kni/rte_kn

[PATCH v6 28/50] mbuf: remove unneeded header includes

2022-02-02 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/mbuf/rte_mbuf.c | 11 --- lib/mbuf/rte_mbuf.h | 2 -- lib/mbuf/rte_mbuf_dyn.h | 2 -- lib/mbuf/rte_mbuf_pool_ops.c | 1 - lib/mbuf/rte_mbuf_pool_ops.h |

[PATCH v6 27/50] member: remove unneeded header includes

2022-02-02 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/member/rte_member.c | 2 -- lib/member/rte_member.h | 1 - lib/member/rte_member_vbf.c | 1 - 3 files changed, 4 deletions(-) diff --git a/lib/member/rte_member.c b/lib/member/rte

[PATCH v6 29/50] lpm: remove unneeded header includes

2022-02-02 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/lpm/rte_lpm.c | 7 --- lib/lpm/rte_lpm.h | 4 lib/lpm/rte_lpm6.c | 7 --- lib/lpm/rte_lpm6.h | 1 - 4 files changed, 19 deletions(-) diff --git a/lib/lpm/rte_lpm.c b/lib/lp

[PATCH v6 26/50] mempool: remove unneeded header includes

2022-02-02 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/mempool/rte_mempool.c | 7 --- lib/mempool/rte_mempool.h | 4 2 files changed, 11 deletions(-) diff --git a/lib/mempool/rte_mempool.c b/lib/mempool/rte_mempool.c index c5a699b1d6

[PATCH v6 25/50] metrics: remove unneeded header includes

2022-02-02 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/metrics/rte_metrics.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/lib/metrics/rte_metrics.c b/lib/metrics/rte_metrics.c index e2a0fbeda8..0c7878e65f 100644 --- a/lib/metrics/rte_

[PATCH v6 24/50] net: remove unneeded header includes

2022-02-02 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/net/net_crc_avx512.c | 3 --- lib/net/net_crc_sse.c| 1 - lib/net/rte_arp.c| 1 - lib/net/rte_ether.h | 1 - lib/net/rte_net.h| 1 - lib/net/rte_net_crc.c| 2 -

[PATCH v6 23/50] node: remove unneeded header includes

2022-02-02 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/node/ethdev_ctrl.c | 2 -- lib/node/ethdev_rx.c | 1 - lib/node/ethdev_tx.c | 1 - lib/node/ip4_lookup.c | 5 - lib/node/ip4_rewrite.c | 4 lib/node/pkt_cls.c | 4 l

[PATCH v6 22/50] pcapng: remove unneeded header includes

2022-02-02 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/pcapng/rte_pcapng.c | 1 - lib/pcapng/rte_pcapng.h | 2 -- 2 files changed, 3 deletions(-) diff --git a/lib/pcapng/rte_pcapng.c b/lib/pcapng/rte_pcapng.c index 03edabe73e..5ae96a5bc9 1006

[PATCH v6 21/50] pci: remove unneeded header includes

2022-02-02 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/pci/rte_pci.c | 15 +-- lib/pci/rte_pci.h | 1 - 2 files changed, 1 insertion(+), 15 deletions(-) diff --git a/lib/pci/rte_pci.c b/lib/pci/rte_pci.c index c91be8b167..355772f

[PATCH v6 20/50] pdump: remove unneeded header includes

2022-02-02 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/pdump/rte_pdump.c | 1 - lib/pdump/rte_pdump.h | 2 -- 2 files changed, 3 deletions(-) diff --git a/lib/pdump/rte_pdump.c b/lib/pdump/rte_pdump.c index af450695ec..b3a62df591 100644 --- a

[PATCH v6 19/50] pipeline: remove unneeded header includes

2022-02-02 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/pipeline/rte_pipeline.c | 4 lib/pipeline/rte_port_in_action.c| 2 -- lib/pipeline/rte_swx_ctl.h | 2 -- lib/pipeline/rte_swx_pipeline.c | 1 - lib/pipelin

[PATCH v6 18/50] port: remove unneeded header includes

2022-02-02 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/port/rte_port_fd.h | 1 - lib/port/rte_port_frag.c| 2 -- lib/port/rte_port_frag.h| 1 - lib/port/rte_port_kni.c | 1 - lib/port/rte_port_kni.h | 1

[PATCH v6 17/50] power: remove unneeded header includes

2022-02-02 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Also added rte_string_fns.h to example app vm_power_manager for users without libbsd. Signed-off-by: Sean Morrissey Acked-by: David Hunt --- examples/vm_power_manager/guest_cli/main.c | 1 + lib/power/guest_channel.c

[PATCH v6 16/50] rawdev: remove unneeded header includes

2022-02-02 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey Acked-by: Hemant Agrawal --- lib/rawdev/rte_rawdev.c | 14 -- 1 file changed, 14 deletions(-) diff --git a/lib/rawdev/rte_rawdev.c b/lib/rawdev/rte_rawdev.c index a6134e76ea..2f0a4f

[PATCH v6 15/50] rcu: remove unneeded header includes

2022-02-02 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/rcu/rte_rcu_qsbr.c | 4 lib/rcu/rte_rcu_qsbr.h | 4 2 files changed, 8 deletions(-) diff --git a/lib/rcu/rte_rcu_qsbr.c b/lib/rcu/rte_rcu_qsbr.c index 7510db2f81..17be93e830 100

[PATCH v6 14/50] regexdev: remove unneeded header includes

2022-02-02 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey Acked-by: Ori Kam --- lib/regexdev/rte_regexdev.c | 2 -- lib/regexdev/rte_regexdev.h | 3 --- 2 files changed, 5 deletions(-) diff --git a/lib/regexdev/rte_regexdev.c b/lib/regexdev/rte_regexd

[PATCH v6 13/50] reorder: remove unneeded header includes

2022-02-02 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/reorder/rte_reorder.c | 1 - 1 file changed, 1 deletion(-) diff --git a/lib/reorder/rte_reorder.c b/lib/reorder/rte_reorder.c index 9445853b79..f40a48201f 100644 --- a/lib/reorder/rte_reo

[PATCH v6 12/50] rib: remove unneeded header includes

2022-02-02 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/rib/rte_rib.c | 2 -- lib/rib/rte_rib.h | 1 - lib/rib/rte_rib6.c | 2 -- lib/rib/rte_rib6.h | 1 - 4 files changed, 6 deletions(-) diff --git a/lib/rib/rte_rib.c b/lib/rib/rte_rib.c in

  1   2   >