Re: [PATCH v2 1/1] net/tap: add a check that Rx/Tx have the same num of queues

On Tue, Jan 18, 2022 at 12:31:51PM +, Ferruh Yigit wrote: > On 1/12/2022 7:23 AM, Nobuhiro MIKI wrote: > > Users can create the desired number of RxQ and TxQ in DPDK. For > > example, if the number of RxQ = 2 and the number of TxQ = 5, > > a total of 8 file descriptors will be created for a tap

[PATCH v3 1/1] net/tap: add a check that Rx/Tx have the same num of queues

Users can create the desired number of RxQ and TxQ in DPDK. For example, if the number of RxQ = 2 and the number of TxQ = 5, a total of 8 file descriptors will be created for a tap device, including RxQ, TxQ, and one for keepalive. The RxQ and TxQ with the same ID are paired by dup(2). In this sce

RE: [PATCH v2 00/10] ethdev: datapath-focused flow rules management

> -Original Message- > From: Alexander Kozyrev > Sent: Tuesday, January 18, 2022 11:30 PM > To: dev@dpdk.org > Cc: Ori Kam ; NBU-Contact-Thomas Monjalon (EXTERNAL) > ; ivan.ma...@oktetlabs.ru; > andrew.rybche...@oktetlabs.ru; ferruh.yi...@intel.com; > mohammad.abdul.a...@intel.com; qi.z

[PATCH v2 4/4] net/cnxk: improve Rx performance

From: Pavan Nikhilesh Improve vWQE and CQ Rx performance by tuning perfetches to 64B cacheline size. Also, prefetch the vWQE array offsets at cacheline boundaries. Signed-off-by: Pavan Nikhilesh --- drivers/event/cnxk/cn10k_worker.h | 25 +++-- drivers/net/cnxk/cn10k_rx.h

[PATCH v2 3/4] event/cnxk: disable default wait time for dequeue

From: Pavan Nikhilesh Setting WAITW bit enables default min dequeue timeout of 1us. Avoid the min dequeue timeout by setting WAITW only when dequeue_timeout is configured. Signed-off-by: Pavan Nikhilesh --- drivers/event/cnxk/cn10k_eventdev.c | 8 +-- drivers/event/cnxk/cn9k_eventdev.c |

[PATCH v2 2/4] event/cnxk: store and reuse workslot status

From: Pavan Nikhilesh Store and reuse workslot status for TT, GRP and HEAD status instead of reading from GWC as reading from GWC imposes additional latency. Signed-off-by: Pavan Nikhilesh --- drivers/common/cnxk/roc_sso.h | 14 -- drivers/event/cnxk/cn10k_worker.h | 16 +

[PATCH v2 1/4] net/cnxk: avoid command copy from Tx queue

From: Pavan Nikhilesh Tx command is prepared based on offloads enabled and stored in Tx queue structure at tx_queue_setup phase. In fastpath the command is copied from Tx queue to LMT line for all the packets. Since, the command contents are mostly constants we can move the command preparation to

[PATCH v2 2/2] vhost: fix physical address mapping

From: Xuan Ding When choosing IOVA as PA mode, IOVA is likely to be discontinuous, which requires page by page mapping for DMA devices. To be consistent, this patch implements page by page mapping instead of mapping at the region granularity for both IOVA as VA and PA mode. Fixes: 7c61fa08b716 (

[PATCH v2 1/2] vhost: rename field in guest page struct

From: Xuan Ding This patch renames the host_phys_addr to host_iova in guest_page struct. The host_phys_addr is iova, it depends on the DPDK IOVA mode. Signed-off-by: Xuan Ding --- lib/vhost/vhost.h | 10 +- lib/vhost/vhost_user.c | 20 ++-- lib/vhost/virtio_net.c |

[PATCH v2 0/2] vhost: fix async address mapping

From: Xuan Ding This patchset fixes the issue of incorrect DMA mapping in PA mode. Due to the ambiguity of host_phys_addr naming in the guest page struct, rename it to host_iova. v2: * Change the order of patch. Xuan Ding (2): vhost: rename field in guest page struct vhost: fix physical ad

[PATCH v1] raw/ifpga: fix pthread cannot join

From: Tianfei Zhang When we want to close a thread, we should set a flag to thread handler function. Fixes: 9c006c45 ("raw/ifpga: scan PCIe BDF device tree") Cc: sta...@dpdk.org Signed-off-by: Tianfei Zhang --- drivers/raw/ifpga/ifpga_rawdev.c | 8 1 file changed, 4 insertions(+), 4

Re: [PATCH] net/tap: Bug fix to populate fds in secondary process

On Wed, 19 Jan 2022 10:03:49 +0530 kumaraparameshwaran rathinavel wrote: > > > Why is this necessary? dev->data is already in memory shared between > > primary > > > and secondary process. > > > > > The question is about the two assignments that happen in secondary proces > > > that chan

Re: [PATCH] net/tap: Bug fix to populate fds in secondary process

On Tue, Jan 18, 2022 at 9:51 PM Stephen Hemminger < step...@networkplumber.org> wrote: > On Tue, 18 Jan 2022 05:22:19 + > Kumara Parameshwaran wrote: > > > @Stephen Hemminger This is process > private as the tap fds are maintained in per process data structu

RE: [PATCH v1 1/1] vhost: integrate dmadev in asynchronous datapath

> -Original Message- > From: Hu, Jiayu > Sent: Monday, January 17, 2022 1:40 PM > To: Xia, Chenbo ; dev@dpdk.org > Cc: maxime.coque...@redhat.com; i.maxim...@ovn.org; Richardson, Bruce > ; Van Haaren, Harry ; > Pai G, Sunil ; Mcnamara, John > ; > Ding, Xuan ; Jiang, Cheng1 ; > lian...@lia

[PATCH v1] raw/ifpga/base: fix SPI transaction

From: Tianfei Zhang When EOP is detected, 2 more bytes should be received (may be a SPI_PACKET_ESC before last valid byte) then rx should be finished. Fixes: 96ebfcf8 ("raw/ifpga/base: add SPI and MAX10 device driver") Cc: sta...@dpdk.org Signed-off-by: Tianfei Zhang --- drivers/raw/ifpga/bas

RE: [PATCH v2 3/7] net/ixgbe: Check that SFF-8472 soft rate select is supported before write

> -Original Message- > From: Stephen Douthit > Sent: Wednesday, January 19, 2022 05:06 > To: Wang, Haiyue ; Morten Brørup > ; Lu, Wenzhuo > ; Zhang, Helin ; Zhang, Qi Z > > Cc: dev@dpdk.org; Wang, Wen ; sta...@dpdk.org > Subject: Re: [PATCH v2 3/7] net/ixgbe: Check that SFF-8472 soft ra

Re: [PATCH v2 3/7] net/ixgbe: Check that SFF-8472 soft rate select is supported before write

On 12/22/21 19:55, Wang, Haiyue wrote: OK, let's see in 2022, happy holidays. ;-) A bit of a slower start to 2022 than I had hoped, but I have a v3 of the hotplug fix in progress. It's now working for the 82599 and C3000 ixgbe devices under Linux, and I'm in the process of getting this built a

RE: [PATCH v5 41/50] eventdev: remove unneeded header includes

> -Original Message- > From: Morrissey, Sean > Sent: Monday, January 17, 2022 2:20 PM > To: Jerin Jacob ; Carrillo, Erik G > > Cc: dev@dpdk.org; Morrissey, Sean > Subject: [PATCH v5 41/50] eventdev: remove unneeded header includes > > These header includes have been flagged by the iwyu_

RE: [PATCH v5 07/50] timer: remove unneeded header includes

> -Original Message- > From: Morrissey, Sean > Sent: Monday, January 17, 2022 2:19 PM > To: Robert Sanford ; Carrillo, Erik G > > Cc: dev@dpdk.org; Morrissey, Sean > Subject: [PATCH v5 07/50] timer: remove unneeded header includes > > These header includes have been flagged by the iwyu_

RE: 回复: [RFC PATCH v1 0/4] Direct re-arming of buffers on receive side

> From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Tuesday, 18 January 2022 17.54 > > [quick summary: ethdev API to bypass mempool] > > 18/01/2022 16:51, Ferruh Yigit: > > On 12/28/2021 6:55 AM, Feifei Wang wrote: > > > Morten Brørup : > > >> The patch provides a significant performance

Re: 回复: [RFC PATCH v1 0/4] Direct re-arming of buffers on receive side

[quick summary: ethdev API to bypass mempool] 18/01/2022 16:51, Ferruh Yigit: > On 12/28/2021 6:55 AM, Feifei Wang wrote: > > Morten Brørup : > >> The patch provides a significant performance improvement, but I am > >> wondering if any real world applications exist that would use this. Only a > >>

RE: [EXT] [PATCH v4] maintainers: update for crypto api/crypto perf/sw crypto pmds using ipsec-mb

> Add myself as Crypto API, QAT, SW PMDs based on ipsec-mb, > NULL PMD, and crypto perf test maintainer. Also remove > Declan, Deepak, and John from the maintainers of these > areas. > > Signed-off-by: Fan Zhang > Acked-by: Declan Doherty > Acked-by: Fiona Trahe > Acked-by: John Griffin > A

Re: [PATCH] net/tap: Bug fix to populate fds in secondary process

On Tue, 18 Jan 2022 05:22:19 + Kumara Parameshwaran wrote: > @Stephen Hemminger This is process private > as the tap fds are maintained in per process data structures. In existing > scheme, the fds are opened by the primary during queue setup and exchanged

Re: [dpdk-dev] [PATCH] app/testpmd: log the largest free block when dumping socket memory

On 12/27/2021 10:49 AM, Yunjian Wang wrote: Add log print of the largest free block in dump_socket_mem. 1) What do you mean with "largest free block", is largest continuous block? If so is this physically continuous, or vfio continious? 2) Why this value is good for? Why we want to display

[PATCH v4] maintainers: update for crypto api/crypto perf/sw crypto pmds using ipsec-mb

Add myself as Crypto API, QAT, SW PMDs based on ipsec-mb, NULL PMD, and crypto perf test maintainer. Also remove Declan, Deepak, and John from the maintainers of these areas. Signed-off-by: Fan Zhang Acked-by: Declan Doherty Acked-by: Fiona Trahe Acked-by: John Griffin Acked-by: Pablo de Lara

Re: 回复: [RFC PATCH v1 0/4] Direct re-arming of buffers on receive side

On 12/28/2021 6:55 AM, Feifei Wang wrote: Thanks for your comments. -邮件原件- 发件人: Morten Brørup 发送时间: Sunday, December 26, 2021 6:25 PM 收件人: Feifei Wang 抄送: dev@dpdk.org; nd 主题: RE: [RFC PATCH v1 0/4] Direct re-arming of buffers on receive side From: Feifei Wang [mailto:feifei.wa...@

[v2,10/10] app/testpmd: implement rte flow queue indirect action

Add testpmd support for the rte_flow_q_action_handle API. Provide the command line interface for operations dequeue. Usage example: flow queue 0 indirect_action 0 create action_id 9 ingress drain yes action rss / end flow queue 0 indirect_action 0 update action_id 9 action queue index 0

[v2,09/10] app/testpmd: implement rte flow queue dequeue

Add testpmd support for the rte_flow_q_dequeue API. Provide the command line interface for operations dequeue. Usage example: flow dequeue 0 queue 0 Signed-off-by: Alexander Kozyrev --- app/test-pmd/cmdline_flow.c | 54 +++ app/test-pmd/config.c

[v2,08/10] app/testpmd: implement rte flow queue drain

Add testpmd support for the rte_flow_q_drain API. Provide the command line interface for the queue draining. Usage example: flow queue 0 drain 0 Signed-off-by: Alexander Kozyrev --- app/test-pmd/cmdline_flow.c | 56 - app/test-pmd/config.c

[v2,07/10] app/testpmd: implement rte flow queue create flow

Add testpmd support for the rte_flow_q_create/rte_flow_q_destroy API. Provide the command line interface for enqueueing flow creation/destruction operations. Usage example: testpmd> flow queue 0 create 0 drain yes table 6 item_template 0 action_template 0 pattern eth dst is

Re: [RFC v3] ethdev: introduce ethdev dump API

On Wed, Jan 12, 2022 at 4:06 AM Ray Kinsella wrote: > > > Min Hu (Connor) writes: > > > Added the ethdev dump API which provides functions for query private info > > from device. There exists many private properties in different PMD drivers, > > such as adapter state, Rx/Tx func algorithm in hns3

[v2,06/10] app/testpmd: implement rte flow table

Add testpmd support for the rte_flow_table API. Provide the command line interface for the flow table creation/destruction. Usage example: testpmd> flow table 0 create table_id 6 group 9 priority 4 ingress mode 1 rules_number 64 item_template 2 action_template 4 testpmd> flow table 0 de

[v2,05/10] app/testpmd: implement rte flow item/action template

Add testpmd support for the rte_flow_item_template and rte_flow_action_template APIs. Provide the command line interface for the template creation/destruction. Usage example: testpmd> flow item_template 0 create item_template_id 2 template eth dst is 00:16:3e:31:15:c3 / end testpmd>

Re: [RFC v2] ethdev: introduce ethdev dump API

On Fri, Jan 14, 2022 at 4:25 PM Min Hu (Connor) wrote: > > Hi, Ajit, > > 在 2022/1/15 1:56, Ajit Khaparde 写道: > > On Wed, Jan 12, 2022 at 3:15 AM Min Hu (Connor) wrote: > >> > >> Thanks Morten, fixed in v3. > >> > >> 在 2022/1/12 15:20, Morten Brørup 写道: > From: Min Hu (Connor) [mailto:humi...

[PATCH v2 01/10] ethdev: introduce flow pre-configuration hints

The flow rules creation/destruction at a large scale incurs a performance penalty and may negatively impact the packet processing when used as part of the datapath logic. This is mainly because software/hardware resources are allocated and prepared during the flow rule creation. In order to optimi

[PATCH v2 04/10] app/testpmd: implement rte flow configure

Add testpmd support for the rte_flow_configure API. Provide the command line interface for the Flow management. Usage example: flow configure 0 queues_number 8 queues_size 256 Signed-off-by: Alexander Kozyrev --- app/test-pmd/cmdline_flow.c | 109 +++- app/test-pm

[PATCH v2 03/10] ethdev: bring in async queue-based flow rules operations

A new, faster, queue-based flow rules management mechanism is needed for applications offloading rules inside the datapath. This asynchronous and lockless mechanism frees the CPU for further packet processing and reduces the performance impact of the flow rules creation/destruction on the datapath.

[PATCH v2 02/10] ethdev: add flow item/action templates

Treating every single flow rule as a completely independent and separate entity negatively impacts the flow rules insertion rate. Oftentimes in an application, many flow rules share a common structure (the same item mask and/or action list) so they can be grouped and classified together. This knowl

[PATCH v2 00/10] ethdev: datapath-focused flow rules management

Three major changes to a generic RTE Flow API were implemented in order to speed up flow rule insertion/destruction and adapt the API to the needs of a datapath-focused flow rules management applications: 1. Pre-configuration hints. Application may give us some hints on what type of resources are

Re: [RFC] DTS Commit Policies

Juraj, I think that both of those make sense. We should try to add those into the document next meeting. Owen Adding a link to the document here in case anyone doesn't want to go through the meeting minutes: https://docs.google.com/document/d/1G7_AEA-4MAd88bxjfP-IOcIy_6mnrMz3HCsUI8e-NN4/edit O

[PATCH v5 1/1] eal: add internal function to get base address

Added an internal helper to get OS-specific EAL mapping base address This helper can be used by the drivers to program offload / accelerator devices, where the base address can be used as a reference address by the accelerator to access the host memory An address can also be represented as an off

[PATCH v3 1/2] common/cnxk: support priority flow ctrl config API

From: Sunil Kumar Kori CNXK platforms support priority flow control(802.1qbb) to pause respective traffic per class on that link. Patch adds RoC interface to configure priority flow control on MAC block i.e. CGX on cn9k and RPM on cn10k. Signed-off-by: Sunil Kumar Kori --- v1..v2: - fix RoC A

[PATCH v3 2/2] net/cnxk: support priority flow control

From: Sunil Kumar Kori Patch implements priority flow control support for CNXK platforms. Signed-off-by: Sunil Kumar Kori --- v1..v2: - fix application restart issue. v2..v3: - fix pause quanta configuration for cn10k. - fix review comments. drivers/net/cnxk/cnxk_ethdev.c | 27 +

Re: [PATCH] app/testpmd: fix external buffer allocation

On 12/17/2021 9:58 AM, Dmitry Kozlyuk wrote: External pinned buffer memory (--mp-alloc=xbuf) was allocated as multiple IOVA-contiguous memzones of 2M size and 2M alignment. Due to the malloc overhead and the alignment requirement, each 2M memzone consumed 4M of hugepage memory: 2M of usable memor

Re: [PATCH v2] app/testpmd: fix dereference before null check

On 1/18/2022 10:53 AM, Sean Morrissey wrote: Assign 'left' variable only after null check on 'size' as function returns if 'size' is null. Coverity issue: 374381 Fixes: 169a9fed1f4 ("app/testpmd: fix hex string parser support for flow API") Cc: sta...@dpdk.org Cc: wei.zh...@intel.com Signed-off

[PATCH v5 11/11] raw/cnxk_gpio: add option to allow using subset of GPIOs

Add PMD parameter that allows one to select only subset of available GPIOs. This might be useful in cases where some GPIOs are already reserved yet still available for userspace access but particular app should not touch them. Signed-off-by: Tomasz Duszynski Reviewed-by: Jerin Jacob Kollanukkara

[PATCH v5 10/11] raw/cnxk_gpio: support selftest

Add support for performing selftest. Signed-off-by: Tomasz Duszynski --- doc/guides/rawdevs/cnxk_gpio.rst | 11 + drivers/raw/cnxk_gpio/cnxk_gpio.c | 1 + drivers/raw/cnxk_gpio/cnxk_gpio.h | 2 + drivers/raw/cnxk_gpio/cnxk_gpio_selftest.c | 386 ++

[PATCH v5 08/11] raw/cnxk_gpio: support standard GPIO operations

Add support for standard GPIO operations i.e ones normally provided by GPIO sysfs interface. Signed-off-by: Tomasz Duszynski --- doc/guides/rawdevs/cnxk_gpio.rst | 98 drivers/raw/cnxk_gpio/cnxk_gpio.c | 147 +++- drivers/raw/cnxk_gpio/rte_pmd_cnxk_gpio.h | 279

[PATCH v5 07/11] raw/cnxk_gpio: support dequeuing buffers

Add support for dequeuing buffers. Signed-off-by: Tomasz Duszynski --- drivers/raw/cnxk_gpio/cnxk_gpio.c | 26 ++ 1 file changed, 26 insertions(+) diff --git a/drivers/raw/cnxk_gpio/cnxk_gpio.c b/drivers/raw/cnxk_gpio/cnxk_gpio.c index 6f3795df41..46f9e63dd7 100644 ---

[PATCH v5 05/11] raw/cnxk_gpio: support queue release

Add support for queue release. Signed-off-by: Tomasz Duszynski --- drivers/raw/cnxk_gpio/cnxk_gpio.c | 34 +++ 1 file changed, 34 insertions(+) diff --git a/drivers/raw/cnxk_gpio/cnxk_gpio.c b/drivers/raw/cnxk_gpio/cnxk_gpio.c index 9baa43187e..ec82a55918 100644 ---

[PATCH v5 04/11] raw/cnxk_gpio: support queue setup

Add support for queue setup. Signed-off-by: Tomasz Duszynski --- drivers/raw/cnxk_gpio/cnxk_gpio.c | 84 ++- 1 file changed, 82 insertions(+), 2 deletions(-) diff --git a/drivers/raw/cnxk_gpio/cnxk_gpio.c b/drivers/raw/cnxk_gpio/cnxk_gpio.c index cee75e389a..9baa431

[PATCH v5 01/11] raw/cnxk_gpio: add GPIO driver skeleton

Add initial support for PMD that allows to control particular pins form userspace. Moreover PMD allows to attach custom interrupt handlers to controllable GPIOs. Main users of this PMD are dataplain applications requiring fast and low latency access to pin state. Signed-off-by: Tomasz Duszynski

[PATCH v5 03/11] raw/cnxk_gpio: support reading queue count

Add support for reading number of available queues. Single queue corresponds to GPIO. Signed-off-by: Tomasz Duszynski --- drivers/raw/cnxk_gpio/cnxk_gpio.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/raw/cnxk_gpio/cnxk_gpio.c b/drivers/raw/cnxk_gpio/cnxk_gpio.c index 1f

[PATCH v5 09/11] raw/cnxk_gpio: support custom irq handlers

Add support for custom interrupt handlers. Custom interrupt handlers bypass kernel completely and are meant for fast and low latency access to GPIO state. Signed-off-by: Tomasz Duszynski --- doc/guides/rawdevs/cnxk_gpio.rst | 21 +++ drivers/raw/cnxk_gpio/cnxk_gpio.c | 41 +++-

[PATCH v5 06/11] raw/cnxk_gpio: support enqueuing buffers

Add dummy support for enqueuing buffers. Signed-off-by: Tomasz Duszynski --- drivers/raw/cnxk_gpio/cnxk_gpio.c | 47 +++ drivers/raw/cnxk_gpio/cnxk_gpio.h | 1 + drivers/raw/cnxk_gpio/meson.build | 1 + drivers/raw/cnxk_gpio/rte_pmd_cnxk_gpio.h | 38

[PATCH v5 02/11] raw/cnxk_gpio: support reading default queue conf

Add support for reading default queue configuration. Signed-off-by: Tomasz Duszynski --- drivers/raw/cnxk_gpio/cnxk_gpio.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/drivers/raw/cnxk_gpio/cnxk_gpio.c b/drivers/raw/cnxk_gpio/cnxk_gpio.c index 61069b2185..1f36f6e22c

[PATCH v5 00/11] Add cnxk_gpio

This series introduces a new rawdevice PMD which allows to manage userspace GPIOs and install custom GPIO interrupt handlers which bypass kernel. This is especially useful for applications that, besides providing standard dataplane functionality, want to have fast and low latency access to GPIO pin

RE: [PATCH] app/testpmd: fix GENEVE parsing in csum forward mode

> -Original Message- > From: Ferruh Yigit > Sent: Tuesday, January 18, 2022 3:03 PM > To: Matan Azrad ; Raja Zidane ; > dev@dpdk.org > Cc: sta...@dpdk.org > Subject: Re: [PATCH] app/testpmd: fix GENEVE parsing in csum forward mode > > External email: Use caution opening links or attachm

Re: [PATCH] app/testpmd: fix GENEVE parsing in csum forward mode

On 1/18/2022 12:55 PM, Matan Azrad wrote: -Original Message- From: Ferruh Yigit Sent: Tuesday, January 18, 2022 2:28 PM To: Matan Azrad ; Raja Zidane ; dev@dpdk.org Cc: sta...@dpdk.org Subject: Re: [PATCH] app/testpmd: fix GENEVE parsing in csum forward mode External email: Use cauti

RE: [PATCH] app/testpmd: fix GENEVE parsing in csum forward mode

> -Original Message- > From: Ferruh Yigit > Sent: Tuesday, January 18, 2022 2:28 PM > To: Matan Azrad ; Raja Zidane ; > dev@dpdk.org > Cc: sta...@dpdk.org > Subject: Re: [PATCH] app/testpmd: fix GENEVE parsing in csum forward mode > > External email: Use caution opening links or attachm

Re: [PATCH v2 1/1] eal: add internal function to get base address

Srikanth Yalavarthi writes: > Added an internal helper to get OS-specific EAL mappping base addreess mapping address > > This helper can be used by the drivers to map host address range with > offload devices and would be need for device specific operations like > firmware load > > Signed-off

Re: [PATCH v2 1/1] net/tap: add a check that Rx/Tx have the same num of queues

On 1/12/2022 7:23 AM, Nobuhiro MIKI wrote: Users can create the desired number of RxQ and TxQ in DPDK. For example, if the number of RxQ = 2 and the number of TxQ = 5, a total of 8 file descriptors will be created for a tap device, including RxQ, TxQ, and one for keepalive. The RxQ and TxQ with t

Re: [PATCH] net/tap: Bug fix to populate fds in secondary process

18/01/2022 13:12, Ferruh Yigit: > On 1/18/2022 11:21 AM, kumaraparameshwaran rathinavel wrote: > > Comment moved down. > > Please don't top post, it makes very hard to follow the discussion and bad > for archives to visit discussion later. > > > > > On Tue, Jan 18, 2022 at 3:17 PM Ferruh Yigit

Re: [PATCH] app/testpmd: fix GENEVE parsing in csum forward mode

On 1/18/2022 11:27 AM, Matan Azrad wrote: -Original Message- From: Ferruh Yigit Sent: Tuesday, January 18, 2022 11:52 AM To: Raja Zidane ; dev@dpdk.org Cc: Matan Azrad ; sta...@dpdk.org Subject: Re: [PATCH] app/testpmd: fix GENEVE parsing in csum forward mode External email: Use caut

Re: [PATCH] net/tap: Bug fix to populate fds in secondary process

On 1/18/2022 10:52 AM, kumaraparameshwaran rathinavel wrote: Comment moved down, please avoid top posting. On Tue, Jan 18, 2022 at 2:40 PM Ferruh Yigit mailto:ferruh.yi...@intel.com>> wrote: On 1/18/2022 4:39 AM, Kumara Parameshwaran wrote: >>   static int >>   tap_dev_start(str

Re: [PATCH] net/tap: Bug fix to populate fds in secondary process

On 1/18/2022 11:21 AM, kumaraparameshwaran rathinavel wrote: Comment moved down. Please don't top post, it makes very hard to follow the discussion and bad for archives to visit discussion later. On Tue, Jan 18, 2022 at 3:17 PM Ferruh Yigit mailto:ferruh.yi...@intel.com>> wrote: On 1/17/

[PATCH] net/mlx5: reject jump to root table

Currently root table as destination is not supported. The jump action which finally be translated to underlying root table in rdma-core should be rejected. Fixes: f78f747f41d0 ("net/mlx5: allow jump to group lower than current") Cc: sta...@dpdk.org Signed-off-by: Xiaoyu Min Acked-by: Viacheslav

Re: [dpdk-dev] [PATCH 1/1] net/bondig: fix type-mismatch in bonding

On 12/11/2021 7:57 AM, Min Hu (Connor) wrote: 在 2021/12/10 19:41, Yunjian Wang 写道: There were some type-mismatch issues in bonding and fix them: - Use %u to fix argument type mismatch in RTE_BOND_LOG. - The internals->mode is of type uint8_t. But the function    parameter 'mode' is of type int.

RE: [PATCH] app/testpmd: fix GENEVE parsing in csum forward mode

> -Original Message- > From: Ferruh Yigit > Sent: Tuesday, January 18, 2022 11:52 AM > To: Raja Zidane ; dev@dpdk.org > Cc: Matan Azrad ; sta...@dpdk.org > Subject: Re: [PATCH] app/testpmd: fix GENEVE parsing in csum forward mode > > External email: Use caution opening links or attachme

Re: [PATCH] net/tap: Bug fix to populate fds in secondary process

Just wanted to bring it to your attention, In Mellanox driver there is a requirement to exchange fds between primary and secondary and similar usage is seen, the primary sends the port_id and the secondary refers to the rte_eth_devices in the driver, The functions are - mlx5_mp_secondar

[PATCH v2] app/testpmd: fix dereference before null check

Assign 'left' variable only after null check on 'size' as function returns if 'size' is null. Coverity issue: 374381 Fixes: 169a9fed1f4 ("app/testpmd: fix hex string parser support for flow API") Cc: sta...@dpdk.org Cc: wei.zh...@intel.com Signed-off-by: Sean Morrissey Reviewed-by: Ferruh Yigit

Re: [PATCH] net/tap: Bug fix to populate fds in secondary process

Yes, even I was confused if it had been the tap_intr_handle_set function. In general the tap_dev_start should not be invoked by the secondary and only primary should do it. I referred it to a couple of PMDs and that was the case. Please let me know if I am missing something in my understanding.

RE: [EXT] [PATCH] examples/l3fwd: fix Rx burst size for event mode

Regards Sunil Kumar Kori >-Original Message- >From: nipun.gu...@nxp.com >Sent: Tuesday, January 11, 2022 10:36 AM >To: dev@dpdk.org >Cc: Jerin Jacob Kollanukkaran ; Sunil Kumar Kori >; tho...@monjalon.net; hemant.agra...@nxp.com; >sta...@dpdk.org; Nipun Gupta >Subject: [EXT] [PATCH] e

Re: [PATCH] net/af_xdp: fix build with -Wunused-function

On 12/9/2021 5:19 PM, Ciara Loftus wrote: The get_shared_umem function is only called when the kernel flag XDP_UMEM_UNALIGNED_CHUNK_FLAG is defined. Move the function implementation and associated helper so that it only gets compiled when that flag is set. Fixes: 74b46340e2d4 ("net/af_xdp: suppo

Re: [PATCH v1] app/testpmd: fix dereference before null check

On 12/9/2021 4:27 PM, Sean Morrissey wrote: Assign 'left' variable only after null check on 'size' as function returns if 'size' is null. Coverity issue: 374381 Fixes: 169a9fed1f4 ("app/testpmd: fix hex string parser support for flow API") Cc: sta...@dpdk.org Cc: wei.zh...@intel.com Signed-off-

Re: [PATCH] app/testpmd: fix GENEVE parsing in csum forward mode

On 12/5/2021 3:44 AM, Raja Zidane wrote: The csum FWD mode parses any received packet to set mbuf offloads for the transmitting burst, mainly in the checksum/TSO areas. In the case of a tunnel header, the csum FWD tries to detect known tunnels by the standard definition using the header'sdata and

Re: [PATCH] net/tap: Bug fix to populate fds in secondary process

On 1/17/2022 6:33 PM, Thomas Monjalon wrote: 17/01/2022 19:28, Ferruh Yigit: + ret = rte_eth_dev_get_port_by_name(request_param->port_name, &port_id); + if (ret) { + TAP_LOG(ERR, "Failed to get port id for %s", + request_param->port_name); +

Re: [EXT] Re: [PATCH v4 1/1] eal: add internal function to get base address

2022-01-18 05:29 (UTC+), Srikanth Yalavarthi: > Hi Dmitry, > > This is to cater to use cases where chunks of memory are allocated by the > host / application, and would like to represent it as an offset from the > Linux virtual base address. One use case is for a firmware running on an > ac

Re: [PATCH] tap:remove maintainer

On 12/6/2021 2:12 PM, Ferruh Yigit wrote: On 12/2/2021 5:15 PM, Wiles, Keith wrote: I no longer have the bandwidth to support the TAP PMD, so I am removing myself as the maintainer so as to not hold up commits. Thanks Keith, introducing this PMD and maintaining up until now, when you have mor

Re: [PATCH] tap:remove maintainer

On 12/6/2021 2:12 PM, Ferruh Yigit wrote: On 12/2/2021 5:15 PM, Wiles, Keith wrote: I no longer have the bandwidth to support the TAP PMD, so I am removing myself as the maintainer so as to not hold up commits. Thanks Keith, introducing this PMD and maintaining up until now, when you have mor

Re: [PATCH] net/tap: Bug fix to populate fds in secondary process

On 1/18/2022 4:39 AM, Kumara Parameshwaran wrote:    static int    tap_dev_start(struct rte_eth_dev *dev)    {     int err, i; + tap_mp_req_on_rxtx(dev); + As for as I understand your logic is primary sends the message to the secondar(y|ies), so what happens first secondary is star

Re: [PATCH] mempool: fix get objects from mempool with cache

On Tue, Jan 18, 2022 at 09:25:22AM +0100, Morten Brørup wrote: > > From: Bruce Richardson [mailto:bruce.richard...@intel.com] > > Sent: Monday, 17 January 2022 18.35 > > > > On Fri, Jan 14, 2022 at 05:36:50PM +0100, Morten Brørup wrote: > > > A flush threshold for the mempool cache was introduced

Re: [PATCH] net/tap: Bug fix to populate fds in secondary process

@Stephen Hemminger This is process private as the tap fds are maintained in per process data structures. In existing scheme, the fds are opened by the primary during queue setup and exchanged to during secondary probe where the send_msg using SOL_SOCKET and SCM

Re: [PATCH] net/tap: Bug fix to populate fds in secondary process

From: Ferruh Yigit Sent: 17 January 2022 23:52 To: Kumara Parameshwaran ; keith.wi...@intel.com Cc: dev@dpdk.org ; Kumara Parameshwaran ; Raslan Darawsheh Subject: Re: [PATCH] net/tap: Bug fix to populate fds in secondary process On 11/26/2021 4:15 AM, Kumar

[PATCH] net/bonding: fix RSS not work for bonding

RSS don't work when bond_ethdev_configure called before rte_eth_bond_slave_add in DPDK21.11. e.g.: dont't work(examples/bond/main.c): rte_eth_bond_create() rte_eth_dev_configure() rte_eth_bond_slave_add() rte_eth_dev_start() work(testpmd): rte_eth_bond_create() rte_eth_bond_slave_add() rte_eth_

[PATCH] net/bonding: fix RSS not work for bonding

RSS don't work when bond_ethdev_configure called before rte_eth_bond_slave_add in DPDK21.11. e.g.: dont't work(examples/bond/main.c): rte_eth_bond_create() rte_eth_dev_configure() rte_eth_bond_slave_add() rte_eth_dev_start() work(testpmd): rte_eth_bond_create() rte_eth_bond_slave_add() rte_eth_

[PATCH] net/bonding: fix RSS not work for bonding

RSS don't work when bond_ethdev_configure called before rte_eth_bond_slave_add in DPDK21.11. e.g.: dont't work(examples/bond/main.c): rte_eth_bond_create() rte_eth_dev_configure() rte_eth_bond_slave_add() rte_eth_dev_start() work(testpmd): rte_eth_bond_create() rte_eth_bond_slave_add() rte_eth_

[PATCH] net/bonding: fix RSS not work for bonding in DPDK21.11

>From 85c4e32996fc262dd6f69d0ce272ae8e8350 Mon Sep 17 00:00:00 2001 From: Yu Wenjun Date: Wed, 12 Jan 2022 15:01:10 +0800 Subject: [PATCH] net/bonding: fix RSS not work for bonding RSS don't work when bond_ethdev_configure called before rte_eth_bond_slave_add in DPDK21.11. e.g.: dont't wor

[PATCH 1/1] eal: add internal function to get base address

Added an internal helper to get OS-specific EAL mappping base addreess This helper can be used by the drivers to map host address range with offload devices and would be need for device specific operations like firmware load Change-Id: Ief572468c291c1721699ba7af2bd4fa8054644a0 Signed-off-by: Srik

RE: [PATCH] net/mlx5: fix wrong MPRQ WQE size assertion

Hi, > -Original Message- > From: Alexander Kozyrev > Sent: Thursday, January 13, 2022 4:36 PM > To: dev@dpdk.org > Cc: Raslan Darawsheh ; Slava Ovsiienko > ; Matan Azrad ; Michael > Baum > Subject: [PATCH] net/mlx5: fix wrong MPRQ WQE size assertion > > Preparation of the stride size an

RE: [PATCH] net/mlx5: fix maximum packet headers size for TSO

Hi, > -Original Message- > From: Alexander Kozyrev > Sent: Thursday, January 13, 2022 4:32 PM > To: dev@dpdk.org > Cc: sta...@dpdk.org; Raslan Darawsheh ; Slava > Ovsiienko ; Matan Azrad > Subject: [PATCH] net/mlx5: fix maximum packet headers size for TSO > > The maximum packet headers

RE: [PATCH] mempool: fix get objects from mempool with cache

> From: Bruce Richardson [mailto:bruce.richard...@intel.com] > Sent: Monday, 17 January 2022 18.35 > > On Fri, Jan 14, 2022 at 05:36:50PM +0100, Morten Brørup wrote: > > A flush threshold for the mempool cache was introduced in DPDK > version > > 1.3, but rte_mempool_do_generic_get() was not compl