Re: [dpdk-dev] [PATCH v3 3/7] ethdev: copy ethdev 'fast' API into separate structure

2021-10-01 Thread Pavan Nikhilesh Bhagavatula
>Copy public function pointers (rx_pkt_burst(), etc.) and related >pointers to internal data from rte_eth_dev structure into a >separate flat array. That array will remain in a public header. >The intention here is to make rte_eth_dev and related structures >internal. >That should allow future poss

Re: [dpdk-dev] [RFC] mempool: implement index-based per core cache

2021-10-01 Thread Honnappa Nagarahalli
> > > Current mempool per core cache implementation is based on pointer For > > most architectures, each pointer consumes 64b Replace it with > > index-based implementation, where in each buffer is addressed by (pool > > address + index) > > I don't think it is going to work: > On 64-bit systems

Re: [dpdk-dev] [PATCH v3 1/7] ethdev: allocate max space for internal queue array

2021-10-01 Thread Pavan Nikhilesh Bhagavatula
>At queue configure stage always allocate space for maximum possible >number (RTE_MAX_QUEUES_PER_PORT) of queue pointers. >That will allow 'fast' inline functions (eth_rx_burst, etc.) to refer >pointer to internal queue data without extra checking of current >number >of configured queues. >That wou

[dpdk-dev] [PATCH 3/3] app/testpmd: fix hex string parser in flow commands

2021-10-01 Thread Viacheslav Ovsiienko
The hexadecimal string parser does not check the target field buffer size, buffer overflow happens and might cause the application failure (segmentation fault is observed usually). Fixes: 169a9fed1f4c ("app/testpmd: fix hex string parser support for flow API") Cc: sta...@dpdk.org Signed-off-by: V

[dpdk-dev] [PATCH 2/3] app/testpmd: update modify field flow action support

2021-10-01 Thread Viacheslav Ovsiienko
The testpmd flow create command updates provided: - modify field action supports the updated actions - pointer type added for action source field - pointer and value source field takes hex string instead of unsigned int in host endianness There are some examples of flow with update modi

[dpdk-dev] [PATCH 1/3] ethdev: update modify field flow action

2021-10-01 Thread Viacheslav Ovsiienko
The generic modify field flow action introduced in [1] has some issues related to the immediate source operand: - immediate source can be presented either as an unsigned 64-bit integer or pointer to data pattern in memory. There was no explicit pointer field defined in the union - the

[dpdk-dev] [PATCH 0/3] ethdev: update modify field flow action

2021-10-01 Thread Viacheslav Ovsiienko
ethdev: update modify field flow action The generic modify field flow action introduced in [1] has some issues related to the immediate source operand: - immediate source can be presented either as an unsigned 64-bit integer or pointer to data pattern in memory. There was no explicit po

[dpdk-dev] [PATCH v2 12/14] net/mlx5: translate flex item configuration

2021-10-01 Thread Viacheslav Ovsiienko
RTE Flow flex item configuration should be translated into actual hardware settings: - translate header length and next protocol field samplings - translate data field sampling, the similar fields with the same mode and matching related parameters are relocated and grouped to be covere

[dpdk-dev] [PATCH v2 11/14] net/mlx5: add flex parser DevX object management

2021-10-01 Thread Viacheslav Ovsiienko
From: Gregory Etelson The DevX flex parsers can be shared between representors within the same IB context. We should put the flex parser objects into the shared list and engage the standard mlx5_list_xxx API to manage ones. Signed-off-by: Gregory Etelson --- drivers/net/mlx5/linux/mlx5_os.c |

[dpdk-dev] [PATCH v2 14/14] net/mlx5: handle flex item in flows

2021-10-01 Thread Viacheslav Ovsiienko
From: Gregory Etelson Provide flex item recognition, validation and trabslation in flow patterns. Track the flex item referencing. Signed-off-by: Gregory Etelson --- drivers/net/mlx5/mlx5_flow.h | 8 +++- drivers/net/mlx5/mlx5_flow_dv.c | 70 +++ drivers/net

[dpdk-dev] [PATCH v2 13/14] net/mlx5: translate flex item pattern into matcher

2021-10-01 Thread Viacheslav Ovsiienko
The matcher is an steering engine entity that represents the flow pattern to hardware to match. It order to provide match on the flex item pattern the appropriate matcher fields should be confgiured with values and masks accordingly. The flex item related matcher fields is an array of eight 32-bit

[dpdk-dev] [PATCH v2 10/14] net/mlx5: add flex item API

2021-10-01 Thread Viacheslav Ovsiienko
This patch is a preparation step of implementing flex item feature in driver and it provides: - external entry point routines for flex item creation/deletion - flex item objects management over the ports. The flex item object keeps information about the item created over the port - refer

[dpdk-dev] [PATCH v2 07/14] common/mlx5: extend flex parser capabilities

2021-10-01 Thread Viacheslav Ovsiienko
From: Gregory Etelson MLX5 PARSE_GRAPH_NODE is the main data structure used by the Flex Parser when a new parsing protocol is defined. While software creates PARSE_GRAPH_NODE object for a new protocol, it must verify that configuration parameters it uses comply with hardware limits. The patch qu

[dpdk-dev] [PATCH v2 04/14] app/testpmd: add jansson library

2021-10-01 Thread Viacheslav Ovsiienko
From: Gregory Etelson Testpmd interactive mode provides CLI to configure application commands. Testpmd reads CLI command and parameters from STDIN, and converts input into C objects with internal parser. The patch adds jansson dependency to testpmd. With jansson, testpmd can read input in JSON fo

[dpdk-dev] [PATCH v2 06/14] common/mlx5: refactor HCA attributes query

2021-10-01 Thread Viacheslav Ovsiienko
There is the common part of code querying the HCA attributes from the device, and this part can be commoditized as dedicated routine. Signed-off-by: Viacheslav Ovsiienko --- drivers/common/mlx5/mlx5_devx_cmds.c | 173 +++ 1 file changed, 73 insertions(+), 100 deletions(-)

[dpdk-dev] [PATCH v2 02/14] ethdev: support flow elements with variable length

2021-10-01 Thread Viacheslav Ovsiienko
From: Gregory Etelson RTE flow API provides RAW item type for packet patterns of variable length. The RAW item structure has fixed size members that describe the variable pattern length and methods to process it. A new RTE flow item type with variable length pattern that does not fit the RAW ite

[dpdk-dev] [PATCH v2 08/14] common/mlx5: fix flex parser DevX creation routine

2021-10-01 Thread Viacheslav Ovsiienko
From: Gregory Etelson Add missing modify_field_select, next_header_field_size field values setting. Fixes: 38119ebe01d6 ("common/mlx5: add DevX command for flex parsers") Cc: sta...@dpdk.org Signed-off-by: Gregory Etelson --- drivers/common/mlx5/mlx5_devx_cmds.c | 9 +++-- 1 file changed,

[dpdk-dev] [PATCH v2 09/14] net/mlx5: update eCPRI flex parser structures

2021-10-01 Thread Viacheslav Ovsiienko
To handle eCPRI protocol in the flows the mlx5 PMD engages flex parser hardware feature. While we were implementing eCPRI support we anticipated the flex parser usage extension, and all related variables were named accordingly, containing flex syllabus. Now we are preparing to introduce more common

[dpdk-dev] [PATCH v2 01/14] ethdev: introduce configurable flexible item

2021-10-01 Thread Viacheslav Ovsiienko
1. Introduction and Retrospective Nowadays the networks are evolving fast and wide, the network structures are getting more and more complicated, the new application areas are emerging. To address these challenges the new network protocols are continuously being developed, considered by technical

[dpdk-dev] [PATCH v2 03/14] ethdev: implement RTE flex item API

2021-10-01 Thread Viacheslav Ovsiienko
From: Gregory Etelson RTE flex item API was introduced in "ethdev: introduce configurable flexible item" patch. The API allows DPDK application to define parser for custom network header in port hardware and offload flows that will match the custom header elements. Signed-off-by: Gregory Etelso

[dpdk-dev] [PATCH v2 05/14] app/testpmd: add flex item CLI commands

2021-10-01 Thread Viacheslav Ovsiienko
From: Gregory Etelson Network port hardware is shipped with fixed number of supported network protocols. If application must work with a protocol that is not included in the port hardware by default, it can try to add the new protocol to port hardware. Flex item or flex parser is port infrastruc

[dpdk-dev] [PATCH v2 00/14] ethdev: introduce configurable flexible item

2021-10-01 Thread Viacheslav Ovsiienko
1. Introduction and Retrospective Nowadays the networks are evolving fast and wide, the network structures are getting more and more complicated, the new application areas are emerging. To address these challenges the new network protocols are continuously being developed, considered by technical

Re: [dpdk-dev] [RFC] mempool: implement index-based per core cache

2021-10-01 Thread Ananyev, Konstantin
> Current mempool per core cache implementation is based on pointer > For most architectures, each pointer consumes 64b > Replace it with index-based implementation, where in each buffer > is addressed by (pool address + index) I don't think it is going to work: On 64-bit systems difference betwee

Re: [dpdk-dev] [PATCH 00/19] MLX5 FreeBSD support

2021-10-01 Thread Srikanth K
Got it, thanks for the clarification. Regards, Srikanth On Thu, Sep 30, 2021 at 10:25 PM Thomas Monjalon wrote: > 30/09/2021 18:27, Srikanth K: > > Sure, I will follow the Windows support approach. > > > > Regarding the patches organization, they were arranged logically to the > > best of my k

[dpdk-dev] [PATCH] common/cnxk: add new IDs to the supported devices lists

2021-10-01 Thread Tomasz Duszynski
CNF10KA does not differ it terms of RVU resources from CN10KA platform hence add it to list of devices respective drivers support. Otherwise devices on CNF10KA are not probed even though compatible drivers exist. Signed-off-by: Tomasz Duszynski --- drivers/common/cnxk/roc_api.h | 1 + dr

[dpdk-dev] [PATCH] config/arm: disable building octeontx2 on cn10k

2021-10-01 Thread Tomasz Duszynski
Common octeontx2 code shares some of the PCI identifiers with cn10k platform and if built wrong drivers may be probed. octeontx2 configuration disables common cn10k code so disable common octeontx2 on cn10k. Signed-off-by: Tomasz Duszynski Reviewed-by: Jerin Jacob Kollanukkaran --- config/arm/

Re: [dpdk-dev] [PATCH 1/3] bus/vmbus: fix leak on device scan

2021-10-01 Thread Long Li
> Subject: Re: [PATCH 1/3] bus/vmbus: fix leak on device scan > > On Thu, Sep 30, 2021 at 9:14 PM Long Li wrote: > > > rte_device name only points at some location where the name is stored. > > > In general this storage is in the bus object or (in some buses) the > > > devarg that resulted in the

[dpdk-dev] [PATCH] common/cnxk: add helpers for reading runplatform

2021-10-01 Thread Tomasz Duszynski
Add helper functions that allow one to check platform ROC is running on. Platform type is retrieved from device tree attribute runplatform which is updated by EBF accordingly. Signed-off-by: Tomasz Duszynski Reviewed-by: Jerin Jacob Kollanukkaran --- drivers/common/cnxk/roc_model.c | 53 +++

[dpdk-dev] [PATCH 2/2] raw/cnxk_bphy: use roc calls for max irq

2021-10-01 Thread Tomasz Duszynski
From: Jakub Palider Maximum interrupt number function used direct access to structure field while ROC helper exists and serves the same purpose. Signed-off-by: Jakub Palider Reviewed-by: Jerin Jacob Kollanukkaran --- drivers/common/cnxk/roc_bphy_irq.c| 6 ++ drivers/common/cnxk/roc_bp

[dpdk-dev] [PATCH 1/2] raw/cnxk_bphy: add wrappers for available message types

2021-10-01 Thread Tomasz Duszynski
One sends commands and receive responses by enqueuing or dequeuing custom messages. In order to simplify this scheme simple wrappers were added which take care of all the heavy lifting. Signed-off-by: Tomasz Duszynski Reviewed-by: Jakub Palider Reviewed-by: Jerin Jacob Kollanukkaran --- driver

[dpdk-dev] [PATCH 0/2] raw/cnxk_bphy: sync with upstream

2021-10-01 Thread Tomasz Duszynski
This series add some wrappers that simplify using existing BPHY APIs. Jakub Palider (1): raw/cnxk_bphy: use roc calls for max irq Tomasz Duszynski (1): raw/cnxk_bphy: add wrappers for available message types drivers/common/cnxk/roc_bphy_irq.c | 6 + drivers/common/cnxk/roc_bphy_ir

Re: [dpdk-dev] [PATCH v3 4/4] net/ixgbe: Add support for Windows

2021-10-01 Thread Dmitry Kozlyuk
Hi William, Recommended title: "net/ixgbe: build on Windows". 2021-10-01 17:33 (UTC-0700), William Tu: > This patch enables building the ixgbe driver for Windows. > It also enables its dependencies on security and cryptodev. > I tested on AWS using ixgbe VF device, using dpdk-testpmd. > > Signed

[dpdk-dev] Vlan not working with Mellanox NIC on VmWare

2021-10-01 Thread Dey, Souvik
Hi All, We were trying to test the vlan filter with Melloanox nic(SR-IOV) on VmWare using the mlx5_pmd. But found that after doing the mlx5_vlan_filter_set with the vlan id also, we are not receiving the tagged packets upto the application. The same works fine in we are using KV

Re: [dpdk-dev] [RFC] mempool: implement index-based per core cache

2021-10-01 Thread Jerin Jacob
On Fri, Oct 1, 2021 at 11:02 PM Jerin Jacob wrote: > > On Fri, Oct 1, 2021 at 9:14 PM Honnappa Nagarahalli > wrote: > > > > > > > > > > > > On Thu, Sep 30, 2021 at 10:57 PM Dharmik Thakkar > > > wrote: > > > > > > > > Current mempool per core cache implementation is based on pointer For > > > >

Re: [dpdk-dev] [RFC] mempool: implement index-based per core cache

2021-10-01 Thread Honnappa Nagarahalli
> > > > > > > > On Thu, Sep 30, 2021 at 10:57 PM Dharmik Thakkar > > > wrote: > > > > > > > > Current mempool per core cache implementation is based on pointer > > > > For most architectures, each pointer consumes 64b Replace it with > > > > index-based implementation, where in each buffer is add

Re: [dpdk-dev] [PATCH v3 4/7] ethdev: make burst functions to use new flat array

2021-10-01 Thread Ananyev, Konstantin
> On 10/1/2021 3:02 PM, Konstantin Ananyev wrote: > > Rework 'fast' burst functions to use rte_eth_fp_ops[]. > > While it is an API/ABI breakage, this change is intended to be > > transparent for both users (no changes in user app is required) and > > PMD developers (no changes in PMD is required

[dpdk-dev] [PATCH v3 4/4] net/ixgbe: Add support for Windows

2021-10-01 Thread William Tu
This patch enables building the ixgbe driver for Windows. It also enables its dependencies on security and cryptodev. I tested on AWS using ixgbe VF device, using dpdk-testpmd. Signed-off-by: William Tu --- drivers/net/ixgbe/base/ixgbe_hv_vf.c | 1 + drivers/net/ixgbe/base/ixgbe_osdep.h | 5

[dpdk-dev] [PATCH v3 3/4] cryptodev: build on Windows

2021-10-01 Thread William Tu
From: Tal Shnaiderman Build the cryptography device library on Windows OS by removing unneeded include and exports blocking the compilation. Signed-off-by: Tal Shnaiderman Acked-by: William Tu --- lib/cryptodev/cryptodev_pmd.c | 2 ++ lib/cryptodev/rte_cryptodev.c | 1 - lib/cryptodev/version

[dpdk-dev] [PATCH v3 2/4] security: build on Windows

2021-10-01 Thread William Tu
From: Tal Shnaiderman Build the security library on Windows. Remove unneeded export from version file. Signed-off-by: Tal Shnaiderman Acked-by: William Tu --- lib/meson.build | 1 + lib/security/version.map | 3 --- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/lib/m

[dpdk-dev] [PATCH v3 1/4] security: use the net library for IP structs

2021-10-01 Thread William Tu
From: Tal Shnaiderman Remove the netinet includes and replaces them with rte_ip.h to support the in_addr/in6_addr structs on all operating systems. Signed-off-by: Tal Shnaiderman Acked-by: William Tu --- lib/net/rte_ip.h| 1 + lib/security/meson.build| 2 +- lib/security/rte_s

[dpdk-dev] [PATCH v3 0/4] net/ixgbe: Add support for Windows

2021-10-01 Thread William Tu
This patch enables building the ixgbe driver for Windows. It also enables its dependencies on security and cryptodev. I tested on AWS using ixgbe VF device, using dpdk-testpmd. Signed-off-by: William Tu Tal Shnaiderman (3): security: use the net library for IP structs security: build on Wind

Re: [dpdk-dev] [RFC] mempool: implement index-based per core cache

2021-10-01 Thread Jerin Jacob
On Fri, Oct 1, 2021 at 9:14 PM Honnappa Nagarahalli wrote: > > > > > > > On Thu, Sep 30, 2021 at 10:57 PM Dharmik Thakkar > > wrote: > > > > > > Current mempool per core cache implementation is based on pointer For > > > most architectures, each pointer consumes 64b Replace it with > > > index-b

Re: [dpdk-dev] [PATCH 02/10] vdpa/sfc: add support for device initialization

2021-10-01 Thread Vijay Kumar Srivastava
Hi Chenbo, >-Original Message- >From: Xia, Chenbo >Sent: Monday, September 6, 2021 8:32 AM >To: Vijay Kumar Srivastava ; dev@dpdk.org >Cc: maxime.coque...@redhat.com; andrew.rybche...@oktetlabs.ru; Harpreet >Singh Anand ; Praveen Kumar Jain >Subject: RE: [PATCH 02/10] vdpa/sfc: add suppo

Re: [dpdk-dev] [PATCH v3 7/7] ethdev: hide eth dev related structures

2021-10-01 Thread Ferruh Yigit
On 10/1/2021 5:53 PM, Ferruh Yigit wrote: > On 10/1/2021 3:02 PM, Konstantin Ananyev wrote: >> Move rte_eth_dev, rte_eth_dev_data, rte_eth_rxtx_callback and related >> data into private header (ethdev_driver.h). >> Few minor changes to keep DPDK building after that. >> >> Signed-off-by: Konstantin

Re: [dpdk-dev] [PATCH v3 0/7] hide eth dev related structures

2021-10-01 Thread Ferruh Yigit
On 10/1/2021 3:02 PM, Konstantin Ananyev wrote: > v3 changes: > - Changes in public struct naming (Jerin/Haiyue) > - Split patches > - Update docs > - Shamelessly included Andrew's patch: > > https://patches.dpdk.org/project/dpdk/patch/20210928154856.1015020-1-andrew.rybche...@oktetlabs.ru/

[dpdk-dev] [PATCH v2 10/10] doc: update release note

2021-10-01 Thread Fan Zhang
This patch updates the release note to describe qat refactor changes made. Signed-off-by: Fan Zhang --- doc/guides/rel_notes/release_21_11.rst | 4 1 file changed, 4 insertions(+) diff --git a/doc/guides/rel_notes/release_21_11.rst b/doc/guides/rel_notes/release_21_11.rst index 3ade7fe5ac

[dpdk-dev] [PATCH v2 09/10] crypto/qat: add gen specific implementation

2021-10-01 Thread Fan Zhang
This patch replaces the mixed QAT symmetric and asymmetric support implementation by separate files with shared or individual implementation for specific QAT generation. Signed-off-by: Arek Kusztal Signed-off-by: Fan Zhang Signed-off-by: Kai Ji --- drivers/common/qat/meson.build

[dpdk-dev] [PATCH v2 08/10] crypto/qat: add gen specific data and function

2021-10-01 Thread Fan Zhang
This patch adds the symmetric and asymmetric crypto data structure and function prototypes for different QAT generations. Signed-off-by: Arek Kusztal Signed-off-by: Fan Zhang Signed-off-by: Kai Ji --- drivers/crypto/qat/README |7 - drivers/crypto/qat/meson.build

[dpdk-dev] [PATCH v2 07/10] crypto/qat: unified device private data structure

2021-10-01 Thread Fan Zhang
This patch unifies the QAT symmetric and asymmetric device private data structures and functions. Signed-off-by: Arek Kusztal Signed-off-by: Fan Zhang Signed-off-by: Kai Ji --- drivers/common/qat/meson.build | 2 +- drivers/common/qat/qat_device.h | 7 +- drivers/crypto/qat/qat_

[dpdk-dev] [PATCH v2 06/10] compress/qat: add gen specific implementation

2021-10-01 Thread Fan Zhang
This patch replaces the mixed QAT compression support implementation by separate files with shared or individual implementation for specific QAT generation. Signed-off-by: Adam Dybkowski Signed-off-by: Arek Kusztal Signed-off-by: Fan Zhang Signed-off-by: Kai Ji --- drivers/common/qat/meson.bu

[dpdk-dev] [PATCH v2 05/10] compress/qat: add gen specific data and function

2021-10-01 Thread Fan Zhang
This patch adds the compression data structure and function prototypes for different QAT generations. Signed-off-by: Adam Dybkowski Signed-off-by: Arek Kusztal Signed-off-by: Fan Zhang Signed-off-by: Kai Ji --- drivers/common/qat/dev/qat_dev_gen1.c | 2 - .../common/qat/qat_adf/icp_

[dpdk-dev] [PATCH v2 04/10] common/qat: add gen specific queue implementation

2021-10-01 Thread Fan Zhang
This patch replaces the mixed QAT queue pair configuration implementation by separate files with shared or individual implementation for specific QAT generation. Signed-off-by: Arek Kusztal Signed-off-by: Fan Zhang Signed-off-by: Kai Ji --- drivers/common/qat/dev/qat_dev_gen1.c | 193 +

[dpdk-dev] [PATCH v2 03/10] common/qat: add gen specific queue pair function

2021-10-01 Thread Fan Zhang
This patch adds the queue pair data structure and function prototypes for different QAT generations. Signed-off-by: Fan Zhang --- drivers/common/qat/qat_qp.c | 3 +++ drivers/common/qat/qat_qp.h | 45 + 2 files changed, 48 insertions(+) diff --git a/drivers/

[dpdk-dev] [PATCH v2 02/10] common/qat: add gen specific device implementation

2021-10-01 Thread Fan Zhang
This patch replaces the mixed QAT device configuration implementation by separate files with shared or individual implementation for specific QAT generation. Signed-off-by: Arek Kusztal Signed-off-by: Fan Zhang Signed-off-by: Kai Ji --- drivers/common/qat/dev/qat_dev_gen1.c | 66 + dr

[dpdk-dev] [PATCH v2 01/10] common/qat: add gen specific data and function

2021-10-01 Thread Fan Zhang
This patch adds the data structure and function prototypes for different QAT generations. Signed-off-by: Arek Kusztal Signed-off-by: Fan Zhang Signed-off-by: Kai Ji --- drivers/common/qat/qat_common.c | 8 drivers/common/qat/qat_common.h | 16 ++-- drivers/common/qat/qat_

[dpdk-dev] [PATCH v2 00/10] drivers/qat: isolate implementations of qat generations

2021-10-01 Thread Fan Zhang
This patchset introduces new qat driver structure and updates existing symmetric crypto qat PMD. The purpose of the change is to isolate QAT generation specific implementations from one to another. It is expected the changes to the specific generation driver code does minimum impact to other gene

Re: [dpdk-dev] [PATCH v3 7/7] ethdev: hide eth dev related structures

2021-10-01 Thread Ferruh Yigit
On 10/1/2021 3:02 PM, Konstantin Ananyev wrote: > Move rte_eth_dev, rte_eth_dev_data, rte_eth_rxtx_callback and related > data into private header (ethdev_driver.h). > Few minor changes to keep DPDK building after that. > > Signed-off-by: Konstantin Ananyev > --- > doc/guides/rel_notes/release_2

Re: [dpdk-dev] [PATCH v3 1/7] ethdev: allocate max space for internal queue array

2021-10-01 Thread Ferruh Yigit
On 10/1/2021 3:02 PM, Konstantin Ananyev wrote: > At queue configure stage always allocate space for maximum possible > number (RTE_MAX_QUEUES_PER_PORT) of queue pointers. > That will allow 'fast' inline functions (eth_rx_burst, etc.) to refer > pointer to internal queue data without extra checking

Re: [dpdk-dev] [PATCH v3 4/7] ethdev: make burst functions to use new flat array

2021-10-01 Thread Ferruh Yigit
On 10/1/2021 3:02 PM, Konstantin Ananyev wrote: > Rework 'fast' burst functions to use rte_eth_fp_ops[]. > While it is an API/ABI breakage, this change is intended to be > transparent for both users (no changes in user app is required) and > PMD developers (no changes in PMD is required). > One ext

Re: [dpdk-dev] [PATCH 2/2] buildtools: enable chkincs on Windows

2021-10-01 Thread Bruce Richardson
On Fri, Oct 01, 2021 at 07:37:26PM +0300, Dmitry Kozlyuk wrote: > Independent header compilation test (chkincs) was disabled on Windows. > The comment stated that the shebang line in the generator script was not > working. Meson 0.57.0, currently recommended for Windows, successfully > parses that

[dpdk-dev] [PATCH 2/2] buildtools: enable chkincs on Windows

2021-10-01 Thread Dmitry Kozlyuk
Independent header compilation test (chkincs) was disabled on Windows. The comment stated that the shebang line in the generator script was not working. Meson 0.57.0, currently recommended for Windows, successfully parses that line and invokes the script. Remove the OS restriction as its reason no

[dpdk-dev] [PATCH 1/2] eal/windows: do not install virt2phys header

2021-10-01 Thread Dmitry Kozlyuk
The header was not intended to be a public one. DPDK users should use `rte_mem_virt2iova()` to translate addresses. Other virt2phys users should use the header from the driver instead. Fixes: 2a5d547a4a9b ("eal/windows: implement basic memory management") Cc: sta...@dpdk.org Signed-off-by: Dmitry

[dpdk-dev] [PATCH 0/2] buildtools: enable chkincs on Windows

2021-10-01 Thread Dmitry Kozlyuk
Dmitry Kozlyuk (2): eal/windows: do not install virt2phys header buildtools: enable chkincs on Windows buildtools/chkincs/meson.build | 5 - lib/eal/windows/include/meson.build | 1 - 2 files changed, 6 deletions(-) -- 2.29.3

[dpdk-dev] [PATCH v2 1/2] net: rename Ethernet header fields

2021-10-01 Thread Dmitry Kozlyuk
Definition of `rte_ether_addr` structure used a workaround allowing DPDK and Windows SDK headers to be used in the same file, because Windows SDK defines `s_addr` as a macro. Rename `s_addr` to `src_addr` and `d_addr` to `dst_addr` to avoid the conflict and remove the workaround. Deprecation notice

[dpdk-dev] [PATCH v2 2/2] doc: remove unneeded deprecations

2021-10-01 Thread Dmitry Kozlyuk
It was announced that `min` and `max` fields and variables in public headers will be renamed to avoid clash with `min` and `max` macros defined in Windows headers. However, it is unnecessary, because these are function-like macros, which are not expanded unless the next token is an opening brace. I

[dpdk-dev] [PATCH v2 0/2] net: Windows compatibility renaming

2021-10-01 Thread Dmitry Kozlyuk
v2: Realized that issues with cryptodev and compressdev were nonexistent, dropped corresponding patches and removed the deprecation notices instead. Placed release notes in 21.11 file (Thomas). Some checkpatch warnings about long lines are left: - when they existed before; - in perform

[dpdk-dev] [PATCH v5 5/5] usertools/dpdk-telemetry: provide info on available sockets

2021-10-01 Thread Bruce Richardson
When a user runs the dpdk-telemetry script and fails to connect because the socket path does not exist, run a scan for possible sockets that could be connected to and inform the user of the command needed to connect to those. For example, when running the script without any parameters, but there a

[dpdk-dev] [PATCH v5 4/5] usertools/dpdk-telemetry: connect to in-memory processes

2021-10-01 Thread Bruce Richardson
Allow connecting to an in-memory process via "-p " flag, which can be used to identify the in-memory process to which to connect. Signed-off-by: Bruce Richardson --- doc/guides/howto/telemetry.rst | 6 ++ usertools/dpdk-telemetry.py| 7 ++- 2 files changed, 12 insertions(+), 1 deleti

[dpdk-dev] [PATCH v5 3/5] telemetry: use unique socket paths for in-memory mode

2021-10-01 Thread Bruce Richardson
When DPDK is run using "in-memory" flag, multiple processes can be run using the same file-prefix and hence the same runtime directory. To avoid problems with conflicting telemetry unix socket paths, we can put the pid of the process into the socket name. As with the existing telemetry socket files

[dpdk-dev] [PATCH v5 2/5] telemetry: fix deletion of active sockets

2021-10-01 Thread Bruce Richardson
When DPDK is run with --in-memory mode, multiple processes can run simultaneously using the same runtime dir. This leads to each process, as it starts up, removing the telemetry socket of another process, giving unexpected behaviour. This patch changes that behaviour to first check if the existing

[dpdk-dev] [PATCH v5 1/5] eal: limit telemetry to primary processes

2021-10-01 Thread Bruce Richardson
Telemetry interface should be exposed for primary processes only, since secondary processes will conflict on socket creation, and since all data in secondary process is generally available to primary. For example, all device stats for ethdevs, cryptodevs, etc. will all be common across processes.

[dpdk-dev] [PATCH v5 0/5] improve telemetry support with in-memory mode

2021-10-01 Thread Bruce Richardson
This patchset cleans up telemetry support for "in-memory" mode, so that multiple independent processes can be run using that mode and still have telemetry support. It also removes problems of one process removing the socket of another - which was the original issue reported. The main changes in thi

[dpdk-dev] [PATCH v12 12/12] MAINTAINERS: add entry for new packet capture features

2021-10-01 Thread Stephen Hemminger
Since the packet capture is just extension of existing pdump; add myself as maintainer of that. Signed-off-by: Stephen Hemminger --- MAINTAINERS | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 1d437ca29d0e..f316d1ac9972 100644 --- a

[dpdk-dev] [PATCH v12 11/12] doc: changes for new pcapng and dumpcap

2021-10-01 Thread Stephen Hemminger
Describe the new packet capture library and utilities Signed-off-by: Stephen Hemminger --- doc/api/doxy-api-index.md | 1 + doc/api/doxy-api.conf.in | 1 + .../howto/img/packet_capture_framework.svg| 96 +-- doc/guides/howto/packet_c

[dpdk-dev] [PATCH v12 10/12] test: enable bpf autotest

2021-10-01 Thread Stephen Hemminger
The BPF autotest is defined but not run automatically. Since it is short, it should be added to the autotest suite. Signed-off-by: Stephen Hemminger Acked-by: Konstantin Ananyev --- app/test/meson.build | 2 ++ 1 file changed, 2 insertions(+) diff --git a/app/test/meson.build b/app/test/meson.

[dpdk-dev] [PATCH v12 09/12] test: add a test for pcapng library

2021-10-01 Thread Stephen Hemminger
Simple unit test that created pcapng file using API. To run this test you need to have at least one device. For example: DPDK_TEST=pcapng_autotest ./build/app/test/dpdk-test -l 0-15 \ --no-huge -m 2048 --vdev=net_tap,iface=dummy Signed-off-by: Stephen Hemminger --- app/test/meson.build |

[dpdk-dev] [PATCH v12 08/12] test: add test for bpf_convert

2021-10-01 Thread Stephen Hemminger
Add some functional tests for the Classic BPF to DPDK BPF converter. Signed-off-by: Stephen Hemminger --- app/test/test_bpf.c | 200 1 file changed, 200 insertions(+) diff --git a/app/test/test_bpf.c b/app/test/test_bpf.c index 527c06b80708..543a5fd6

[dpdk-dev] [PATCH v12 07/12] app/dumpcap: add new packet capture application

2021-10-01 Thread Stephen Hemminger
This is a new packet capture application to replace existing pdump. The new application works like Wireshark dumpcap program and supports the pdump API features. It is not complete yet some features such as filtering are not implemented. Signed-off-by: Stephen Hemminger --- app/dumpcap/main.c

[dpdk-dev] [PATCH v12 06/12] pdump: support pcapng and filtering

2021-10-01 Thread Stephen Hemminger
This enhances the DPDK pdump library to support new pcapng format and filtering via BPF. The internal client/server protocol is changed to support two versions: the original pdump basic version and a new pcapng version. The internal version number (not part of exposed API or ABI) is intentionally

[dpdk-dev] [PATCH v12 05/12] bpf: add function to dump eBPF instructions

2021-10-01 Thread Stephen Hemminger
When debugging converted (and other) programs it is useful to see disassembled eBPF output. Signed-off-by: Stephen Hemminger Acked-by: Konstantin Ananyev --- lib/bpf/bpf_dump.c | 139 lib/bpf/meson.build | 1 + lib/bpf/rte_bpf.h | 14 + lib

[dpdk-dev] [PATCH v12 04/12] bpf: add function to convert classic BPF to DPDK BPF

2021-10-01 Thread Stephen Hemminger
The pcap library emits classic BPF (32 bit) and is useful for creating filter programs. The DPDK BPF library only implements extended BPF (eBPF). Add an function to convert from old to new. The rte_bpf_convert function uses rte_malloc to put the resulting program in hugepage shared memory so it

[dpdk-dev] [PATCH v12 03/12] bpf: allow self-xor operation

2021-10-01 Thread Stephen Hemminger
Some BPF programs may use XOR of a register with itself as a way to zero register in one instruction. The BPF filter converter generates this in the prolog to the generated code. The BPF validator would not allow this because the value of register was undefined. But after this operation it always

[dpdk-dev] [PATCH v12 02/12] librte_pcapng: add new library for writing pcapng files

2021-10-01 Thread Stephen Hemminger
This is utility library for writing pcapng format files used by Wireshark family of utilities. Older tcpdump also knows how to read (but not write) this format. See draft RFC https://www.ietf.org/id/draft-tuexen-opsawg-pcapng-03.html and https://github.com/pcapng/pcapng/ Signed-off-by: Stephe

[dpdk-dev] [PATCH v12 01/12] lib: pdump is not supported on Windows

2021-10-01 Thread Stephen Hemminger
The current version of the pdump library was building on Windows, but it was useless since the pdump utility was not being built and Windows does not have multi-process support. The new version of pdump with filtering now has dependency on bpf. But bpf library is not available on Windows. Signed-

[dpdk-dev] [PATCH v12 00/12] Packet capture framework update

2021-10-01 Thread Stephen Hemminger
This patch set is a more complete version of the the enhanced packet capture support described last year. The new capture library and utility are: - faster avoids lots of extra I/O, does bursting, etc. - gives more information (multiple ports, queues, etc) - has a better user interface (same

Re: [dpdk-dev] [RFC] mempool: implement index-based per core cache

2021-10-01 Thread Honnappa Nagarahalli
> > On Thu, Sep 30, 2021 at 10:57 PM Dharmik Thakkar > wrote: > > > > Current mempool per core cache implementation is based on pointer For > > most architectures, each pointer consumes 64b Replace it with > > index-based implementation, where in each buffer is addressed by (pool > > address +

Re: [dpdk-dev] [dpdk-stable] [PATCH] doc/examples: fix build on FreeBSD

2021-10-01 Thread Bruce Richardson
On Fri, Oct 01, 2021 at 05:36:51PM +0200, Thomas Monjalon wrote: > 01/10/2021 17:15, Bruce Richardson: > > On Fri, Oct 01, 2021 at 05:03:11PM +0200, Thomas Monjalon wrote: > > > 15/09/2021 19:36, Bruce Richardson: > > > > On FreeBSD, "find" does not support the "printf" flag, so we need to > > > >

Re: [dpdk-dev] [dpdk-stable] [PATCH] doc/examples: fix build on FreeBSD

2021-10-01 Thread Thomas Monjalon
01/10/2021 17:15, Bruce Richardson: > On Fri, Oct 01, 2021 at 05:03:11PM +0200, Thomas Monjalon wrote: > > 15/09/2021 19:36, Bruce Richardson: > > > On FreeBSD, "find" does not support the "printf" flag, so we need to > > > use "gfind" from the "findutils" package. > > > > It is one more dependenc

Re: [dpdk-dev] [PATCH 0/3] improvements for telemetry script

2021-10-01 Thread Thomas Monjalon
> >Patch 1 fixes errors reported by flake8 in the telemetry python script. > >Inspired by the work by Dave Hunt [1] the final two patches look to adjust > >the > >script so that it works nicer when commands come from an input pipe rather > >than from an interactive terminal. > > > >Without this se

Re: [dpdk-dev] [dpdk-stable] [PATCH] doc/examples: fix build on FreeBSD

2021-10-01 Thread Bruce Richardson
On Fri, Oct 01, 2021 at 05:03:11PM +0200, Thomas Monjalon wrote: > 15/09/2021 19:36, Bruce Richardson: > > On FreeBSD, "find" does not support the "printf" flag, so we need to > > use "gfind" from the "findutils" package. > > It is one more dependency. > Shouldn't we avoid it by rewritting the she

Re: [dpdk-dev] [PATCH v2] telemetry: remove experimental tags from APIs

2021-10-01 Thread Thomas Monjalon
27/09/2021 15:03, Kinsella, Ray: > On 15/09/2021 17:55, Bruce Richardson wrote: > > The telemetry APIs have been present and unchanged for >1 year now, so > > remove experimental tag from them. > > > > Signed-off-by: Bruce Richardson > > Needs to be stripped in MAINTAINERS also, but apart from t

Re: [dpdk-dev] [PATCH v3 1/6] ethdev: fix max Rx packet length

2021-10-01 Thread Stephen Hemminger
On Fri, 1 Oct 2021 15:36:18 +0100 Ferruh Yigit wrote: > Other issues causing confusion is: > * maximum transmission unit (MTU) is payload of the Ethernet frame. And > 'max_rx_pkt_len' is the size of the Ethernet frame. Difference is > Ethernet frame overhead, and this overhead may be differe

Re: [dpdk-dev] [dpdk-stable] [PATCH] doc/examples: fix build on FreeBSD

2021-10-01 Thread Thomas Monjalon
15/09/2021 19:36, Bruce Richardson: > On FreeBSD, "find" does not support the "printf" flag, so we need to > use "gfind" from the "findutils" package. It is one more dependency. Shouldn't we avoid it by rewritting the shell commands with loops?

Re: [dpdk-dev] [PATCH v5] net/af_packet: reinsert the stripped vlan tag

2021-10-01 Thread Stephen Hemminger
On Fri, 1 Oct 2021 11:35:01 +0300 Tudor Cornea wrote: > The af_packet pmd driver binds to a raw socket and allows > sending and receiving of packets through the kernel. > > Since commit [1], the kernel strips the vlan tags early in > __netif_receive_skb_core(), so we receive untagged packets wh

Re: [dpdk-dev] [PATCH v2] mempool/stack: build on Windows

2021-10-01 Thread Thomas Monjalon
01/10/2021 16:44, Thomas Monjalon: > 01/10/2021 09:42, Dmitry Kozlyuk: > > 2021-09-30 17:50 (UTC-0700), Jie Zhou: > > > enable build mempool/stack on Windows > > > > Nit: in commit body, we use correct capitalization, punctuation, and > > spelling. > > > > > > > > V2 change: > > > - enable

Re: [dpdk-dev] [EXT] Re: [PATCH v3 1/5] net/enetfec: introduce NXP ENETFEC driver

2021-10-01 Thread Ferruh Yigit
On 10/1/2021 11:22 AM, Apeksha Gupta wrote: >> -Original Message- >> From: Ferruh Yigit >> Sent: Thursday, September 23, 2021 3:40 PM >> To: Apeksha Gupta ; >> david.march...@redhat.com; andrew.rybche...@oktetlabs.ru; >> ferruh.yi...@intel.com >> Cc: dev@dpdk.org; Sachin Saxena ; Hemant >>

Re: [dpdk-dev] [PATCH v2] mempool/stack: build on Windows

2021-10-01 Thread Thomas Monjalon
01/10/2021 09:42, Dmitry Kozlyuk: > 2021-09-30 17:50 (UTC-0700), Jie Zhou: > > enable build mempool/stack on Windows > > Nit: in commit body, we use correct capitalization, punctuation, and spelling. > > > > > V2 change: > > - enable build lib stack on Windows which mempool/stack depends on

[dpdk-dev] [PATCH v3 5/6] ethdev: unify MTU checks

2021-10-01 Thread Ferruh Yigit
Both 'rte_eth_dev_configure()' & 'rte_eth_dev_set_mtu()' sets MTU but have slightly different checks. Like one checks min MTU against RTE_ETHER_MIN_MTU and other RTE_ETHER_MIN_LEN. Checks moved into common function to unify the checks. Also this has benefit to have common error logs. Suggested-by

[dpdk-dev] [PATCH v3 4/6] ethdev: remove jumbo offload flag

2021-10-01 Thread Ferruh Yigit
Removing 'DEV_RX_OFFLOAD_JUMBO_FRAME' offload flag. Instead of drivers announce this capability, application can deduct the capability by checking reported 'dev_info.max_mtu' or 'dev_info.max_rx_pktlen'. And instead of application explicitly set this flag to enable jumbo frames, this can be deduc

[dpdk-dev] [PATCH v3 6/6] examples/ip_reassembly: remove unused parameter

2021-10-01 Thread Ferruh Yigit
Remove 'max-pkt-len' parameter. Signed-off-by: Ferruh Yigit --- examples/ip_reassembly/main.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/examples/ip_reassembly/main.c b/examples/ip_reassembly/main.c index af67db49f7fb..2ff5ea3e7bc5 100644 --- a/examples/ip_reassembly/main.c +++ b/examp

  1   2   3   >