Re: [dpdk-dev] [PATCH v2 4/4] net/ixgbe: delete HW rings when releasing queues

2021-09-21 Thread wangyunjian
> -Original Message- > From: Wang, Haiyue [mailto:haiyue.w...@intel.com] > Sent: Wednesday, September 22, 2021 2:23 PM > To: wangyunjian ; dev@dpdk.org > Cc: Xing, Beilei ; Yang, Qiming > ; Zhang, Qi Z ; dingxiaoxiong > > Subject: RE: [dpdk-dev] [PATCH v2 4/4] net/ixgbe: delete HW rings wh

Re: [dpdk-dev] [PATCH v3] net/ice: add 1PPS support for E810

2021-09-21 Thread Zhang, Qi Z
> -Original Message- > From: Su, Simei > Sent: Wednesday, September 15, 2021 1:34 PM > To: Zhang, Qi Z > Cc: dev@dpdk.org; Wang, Haiyue ; Su, Simei > > Subject: [PATCH v3] net/ice: add 1PPS support for E810 > > The E810 supports four single-ended GPIO signals (SDP[20:23]). The 1PPS >

Re: [dpdk-dev] [PATCH] ethdev: fix one MAC address occupies two index in mac addrs

2021-09-21 Thread Andrew Rybchenko
On 9/22/21 6:36 AM, Min Hu (Connor) wrote: > From: Huisong Li > > Use the testpmd to perform the following operations: > 1) mac_addr add 0 00:18:2D:00:00:90 > 2) mac_addr add 0 00:18:2D:00:00:91 > 3) mac_addr add 0 00:18:2D:00:00:92 > 4) mac_addr set 0 00:18:2D:00:00:91 > 5) show port 0 macs > Nu

[dpdk-dev] [PATCH] app/testpmd: add cmdline to show LACP bonding info

2021-09-21 Thread Min Hu (Connor)
From: Chengchang Tang Add a new cmdline to help diagnostic the bonding mode 4 in testpmd. Show the lacp information about the bonded device and its slaves: show bonding lacp info Signed-off-by: Chengchang Tang Signed-off-by: Min Hu(Connor) --- app/test-pmd/cmdline.c | 1

Re: [dpdk-dev] [PATCH v2 4/4] net/ixgbe: delete HW rings when releasing queues

2021-09-21 Thread Wang, Haiyue
> -Original Message- > From: Yunjian Wang > Sent: Saturday, September 18, 2021 16:42 > To: dev@dpdk.org > Cc: Wang, Haiyue ; Xing, Beilei > ; Yang, Qiming > ; Zhang, Qi Z ; > dingxiaoxi...@huawei.com; Yunjian Wang > > Subject: [dpdk-dev] [PATCH v2 4/4] net/ixgbe: delete HW rings when re

Re: [dpdk-dev] [PATCH] net/memif: fix chained mbuf determination

2021-09-21 Thread Jakub Grajciar -X (jgrajcia - PANTHEON TECH SRO at Cisco)
> > Previously, TX functions call rte_pktmbuf_is_contiguous to determine > > whether an mbuf is chained. However, rte_pktmbuf_is_contiguous is > > designed to work on the first mbuf of a packet only. In case a packet > > contains three or more segment mbufs in a chain, it may cause > > truncated pa

[dpdk-dev] [PATCH v3 5/8] common/cnxk: support TM error type get

2021-09-21 Thread skoteshwar
From: Satha Rao Different TM handlers returns various platform specific errors, this patch introduces new API to convert these internal error types to RTE_TM* error types. Also updated error message API with missed TM error types. Signed-off-by: Satha Rao Acked-by: Nithin Dabilpuram --- drive

[dpdk-dev] [PATCH v3 8/8] net/cnxk: TM shaper and node operations

2021-09-21 Thread skoteshwar
From: Satha Rao Implemented TM node, shaper profile, hierarchy_commit and statistic operations. Signed-off-by: Satha Rao Acked-by: Nithin Dabilpuram --- doc/guides/rel_notes/release_21_11.rst | 1 + drivers/net/cnxk/cnxk_tm.c | 353 + drivers/net/cnxk/cnx

[dpdk-dev] [PATCH v3 7/8] net/cnxk: TM capabilities and queue rate limit handlers

2021-09-21 Thread skoteshwar
From: Satha Rao Initial version of TM implementation added basic infrastructure, TM node_get, capabilities operations and rate limit queue operation. Signed-off-by: Satha Rao Acked-by: Nithin Dabilpuram --- drivers/net/cnxk/cnxk_ethdev.c | 2 + drivers/net/cnxk/cnxk_ethdev.h | 3 + driver

[dpdk-dev] [PATCH v3 6/8] common/cnxk: set of handlers to get TM hierarchy internals

2021-09-21 Thread skoteshwar
From: Satha Rao Platform specific TM tree hierarchy details are part of common cnxk driver. This patch introduces missing HAL apis to return state of TM hierarchy required to support ethdev TM operations inside cnxk PMD. Signed-off-by: Satha Rao Acked-by: Nithin Dabilpuram --- drivers/common/

[dpdk-dev] [PATCH v3 2/8] common/cnxk: support SMQ flush

2021-09-21 Thread skoteshwar
From: Satha Rao Each NIX interface had one or more SMQs connected to SQs to send packets. When flush enabled on SMQ, hardware will push all packets from SMQ to physical link. This API will enable flush on all SMQs of an interface. Signed-off-by: Satha Rao Acked-by: Nithin Dabilpuram --- drive

[dpdk-dev] [PATCH v3 4/8] common/cnxk: handle packet mode shaper limits

2021-09-21 Thread skoteshwar
From: Satha Rao Add new macros to reflect HW shaper PPS limits. New API to validate input rates for packet mode. Increase adjust value to support lesser PPS (<61). Signed-off-by: Satha Rao Acked-by: Nithin Dabilpuram --- drivers/common/cnxk/hw/nix.h | 3 + drivers/common/cnxk/roc_n

[dpdk-dev] [PATCH v3 1/8] common/cnxk: set appropriate max frame size for SDP and LBK

2021-09-21 Thread skoteshwar
From: Satha Rao For SDP interface all platforms supports up to 65535 frame size. Updated api with new check for SDP interface. Signed-off-by: Satha Rao Acked-by: Nithin Dabilpuram --- drivers/common/cnxk/hw/nix.h | 1 + drivers/common/cnxk/roc_nix.c | 5 - 2 files changed, 5 insertions(+

[dpdk-dev] [PATCH v3 3/8] common/cnxk: increase sched weight and shaper burst limit

2021-09-21 Thread skoteshwar
From: Nithin Dabilpuram Increase sched weight and shaper burst limit for cn10k. Signed-off-by: Nithin Dabilpuram Acked-by: Nithin Dabilpuram --- drivers/common/cnxk/hw/nix.h | 13 ++--- drivers/common/cnxk/roc_nix.h | 23 ++- drivers/common/cnxk/roc_nix_priv

[dpdk-dev] [PATCH v3 0/8] Add TM Support for CN9K and CN10K

2021-09-21 Thread skoteshwar
From: Satha Rao Initial implementation of traffic management for CN9K and CN10K platforms. Nithin Dabilpuram (1): common/cnxk: increase sched weight and shaper burst limit Satha Rao (7): common/cnxk: set appropriate max frame size for SDP and LBK common/cnxk: support SMQ flush common/cn

Re: [dpdk-dev] [PATCH v4 1/2] app/testpmd: update forward engine beginning

2021-09-21 Thread Li, Xiaoyun
> -Original Message- > From: Zhang, AlvinX > Sent: Wednesday, September 22, 2021 10:50 > To: Li, Xiaoyun ; Ananyev, Konstantin > > Cc: dev@dpdk.org; Zhang, AlvinX ; sta...@dpdk.org > Subject: [PATCH v4 1/2] app/testpmd: update forward engine beginning > > For each forward engine, there m

Re: [dpdk-dev] [PATCH v4 2/2] app/testpmd: fix txonly forwording

2021-09-21 Thread Li, Xiaoyun
> -Original Message- > From: Zhang, AlvinX > Sent: Wednesday, September 22, 2021 10:50 > To: Li, Xiaoyun ; Ananyev, Konstantin > > Cc: dev@dpdk.org; Zhang, AlvinX ; sta...@dpdk.org > Subject: [PATCH v4 2/2] app/testpmd: fix txonly forwording > > When random number of Tx segments is ena

[dpdk-dev] [PATCH v2] net/mlx5: fix NULL err msg in mlx5_flow_tunnel_validate

2021-09-21 Thread wenxu
From: wenxu If the mlx5_flow_tunnel_validate validating the flow tunnel rule failed, the err_msg will be NULL in the rte_flow_error. Fixes: 4ec6360de37d ("net/mlx5: implement tunnel offload") Signed-off-by: wenxu --- drivers/net/mlx5/mlx5_flow.c | 43 --

Re: [dpdk-dev] [PATCH v4 01/11] dma/ioat: add device probe and removal functions

2021-09-21 Thread fengchengwen
Reviewed-by: Chengwen Feng On 2021/9/17 23:42, Conor Walsh wrote: > Add the basic device probe/remove skeleton code and initial documentation > for new IOAT DMA driver. Maintainers update is also included in this > patch. > > Signed-off-by: Conor Walsh > Reviewed-by: Kevin Laatz > --- > MAINT

Re: [dpdk-dev] [PATCH v5 11/16] dma/idxd: add operation statistic tracking

2021-09-21 Thread fengchengwen
Reviewed-by: Chengwen Feng On 2021/9/17 23:24, Kevin Laatz wrote: > Add statistic tracking for DSA devices. > > Signed-off-by: Bruce Richardson > Signed-off-by: Kevin Laatz > Reviewed-by: Conor Walsh > --- > doc/guides/dmadevs/idxd.rst | 11 +++ > drivers/dma/idxd/idxd_bus.c

Re: [dpdk-dev] [PATCH v5 10/16] dma/idxd: add data-path job completion functions

2021-09-21 Thread fengchengwen
On 2021/9/17 23:24, Kevin Laatz wrote: > Add the data path functions for gathering completed operations. > > Signed-off-by: Bruce Richardson > Signed-off-by: Kevin Laatz > Reviewed-by: Conor Walsh > > --- > v2: >- fixed typo in docs >- add completion status for invalid opcode > --- >

[dpdk-dev] [PATCH 2/2] net/hns3: fix input parameters of MAC related functions

2021-09-21 Thread Min Hu (Connor)
From: Huisong Li When adding multicast and unicast MAC addresses, three descriptors and one descriptor are required for querying or adding MAC VLAN table, respectively. This patch uses the number of descriptors as input parameter to complete this task to make the function more secure. Fixes: 7d7

[dpdk-dev] [PATCH 1/2] net/hns3: fix residual old MAC after setting default MAC

2021-09-21 Thread Min Hu (Connor)
From: Huisong Li This problem occurs in the following scenarios: 1) reset is encountered when the adapter is running. 2) set a new default MAC address After the above two steps, the old default MAC address should be not take effect. But the current behavior is contrary to that. This is due to th

[dpdk-dev] [PATCH 0/2] Bugfix for hns3 MAC

2021-09-21 Thread Min Hu (Connor)
Two bugfixes for hns3 MAC. Huisong Li (2): net/hns3: fix residual old MAC after setting default MAC net/hns3: fix input parameters of MAC related functions drivers/net/hns3/hns3_cmd.h| 3 +- drivers/net/hns3/hns3_ethdev.c | 126 - drivers/net/hns3/hns3_e

[dpdk-dev] [PATCH] ethdev: fix one MAC address occupies two index in mac addrs

2021-09-21 Thread Min Hu (Connor)
From: Huisong Li Use the testpmd to perform the following operations: 1) mac_addr add 0 00:18:2D:00:00:90 2) mac_addr add 0 00:18:2D:00:00:91 3) mac_addr add 0 00:18:2D:00:00:92 4) mac_addr set 0 00:18:2D:00:00:91 5) show port 0 macs Number of MAC address added: 4 00:18:2D:00:00:91 00:18:2D:0

Re: [dpdk-dev] [RFC V2] ethdev: fix issue that dev close in PMD calls twice

2021-09-21 Thread Huisong Li
在 2021/9/20 22:07, Ferruh Yigit 写道: On 8/25/2021 10:53 AM, Huisong Li wrote: 在 2021/8/24 22:42, Ferruh Yigit 写道: On 8/19/2021 4:45 AM, Huisong Li wrote: 在 2021/8/18 19:24, Ferruh Yigit 写道: On 8/13/2021 9:16 AM, Huisong Li wrote: 在 2021/8/13 14:12, Thomas Monjalon 写道: 13/08/2021 04:11, Hui

Re: [dpdk-dev] [PATCH v1 2/2] vfio: add errno on unsupported platforms

2021-09-21 Thread Xia, Chenbo
> -Original Message- > From: dev On Behalf Of Anatoly Burakov > Sent: Thursday, September 16, 2021 6:37 PM > To: dev@dpdk.org; Richardson, Bruce > Subject: [dpdk-dev] [PATCH v1 2/2] vfio: add errno on unsupported platforms > > Currently, when code is running on FreeBSD (or using fallback

Re: [dpdk-dev] [PATCH v1 1/2] vfio: make API return values consistent

2021-09-21 Thread Xia, Chenbo
Hi Anatoly, > -Original Message- > From: dev On Behalf Of Anatoly Burakov > Sent: Thursday, September 16, 2021 6:37 PM > To: dev@dpdk.org > Subject: [dpdk-dev] [PATCH v1 1/2] vfio: make API return values consistent > > Currently, when VFIO support is not compiled, FreeBSD and Linux have

Re: [dpdk-dev] [PATCH v5 09/16] dma/idxd: add data-path job submission functions

2021-09-21 Thread fengchengwen
On 2021/9/17 23:24, Kevin Laatz wrote: > Add data path functions for enqueuing and submitting operations to DSA > devices. > > Signed-off-by: Bruce Richardson > Signed-off-by: Kevin Laatz > Reviewed-by: Conor Walsh > --- > doc/guides/dmadevs/idxd.rst | 64 +++ > drivers/dma/i

Re: [dpdk-dev] [PATCH v8 2/2] app/testpmd: fix testpmd doesn't show RSS hash offload

2021-09-21 Thread Wang, Jie1X
> -Original Message- > From: Yigit, Ferruh > Sent: Monday, September 20, 2021 5:48 PM > To: Wang, Jie1X ; dev@dpdk.org > Cc: Li, Xiaoyun ; andrew.rybche...@oktetlabs.ru; > tho...@monjalon.net > Subject: Re: [PATCH v8 2/2] app/testpmd: fix testpmd doesn't show RSS hash > offload > > On 8

[dpdk-dev] [PATCH v4 2/2] app/testpmd: fix txonly forwording

2021-09-21 Thread Alvin Zhang
When random number of Tx segments is enabled, because the actual number of segments may be only one, the first segment of the Tx packets must accommodate a complete being sending Eth/IP/UDP packet. Besides, if multiple flow is enabled, the forwarding will update the IP and UDP header, these header

[dpdk-dev] [PATCH v4 1/2] app/testpmd: update forward engine beginning

2021-09-21 Thread Alvin Zhang
For each forward engine, there may be some special conditions must be met before the forwarding runs. Adding checks for these conditions in configuring is not suitable, because one condition may rely on multiple configurations, and the conditions required by each forward engine is not general. Th

Re: [dpdk-dev] [PATCH v5 08/16] dma/idxd: add start and stop functions for pci devices

2021-09-21 Thread fengchengwen
On 2021/9/17 23:24, Kevin Laatz wrote: > Add device start/stop functions for DSA devices bound to vfio. For devices > bound to the IDXD kernel driver, these are not required since the IDXD > kernel driver takes care of this. > > Signed-off-by: Bruce Richardson > Signed-off-by: Kevin Laatz > Revi

Re: [dpdk-dev] [PATCH v5 07/16] dma/idxd: add configure and info_get functions

2021-09-21 Thread fengchengwen
On 2021/9/17 23:24, Kevin Laatz wrote: > Add functions for device configuration. The info_get function is included > here since it can be useful for checking successful configuration. > > Signed-off-by: Bruce Richardson > Signed-off-by: Kevin Laatz > Reviewed-by: Conor Walsh > > --- > v2: >

Re: [dpdk-dev] [PATCH v5 15/16] devbind: add dma device class

2021-09-21 Thread fengchengwen
Reviewed-by: Chengwen Feng On 2021/9/17 23:24, Kevin Laatz wrote: > Add a new class for DMA devices. Devices listed under the DMA class are to > be used with the dmadev library. > > Signed-off-by: Kevin Laatz > Reviewed-by: Conor Walsh > --- > usertools/dpdk-devbind.py | 12 +--- > 1

Re: [dpdk-dev] [PATCH 0/2] support to clear in-flight packets for async

2021-09-21 Thread Yang, YvonneX
> -Original Message- > From: Wang, YuanX > Sent: Thursday, September 9, 2021 2:58 PM > To: dev@dpdk.org > Cc: maxime.coque...@redhat.com; Xia, Chenbo ; > Pai G, Sunil ; Hu, Jiayu ; Ding, > Xuan ; Jiang, Cheng1 ; Ma, > WenwuX ; Yang, YvonneX > ; Wang, YuanX > Subject: [PATCH 0/2] suppor

Re: [dpdk-dev] [PATCH 1/2] vhost: support to clear in-flight packets for async dequeue

2021-09-21 Thread Yang, YvonneX
> -Original Message- > From: Wang, YuanX > Sent: Thursday, September 9, 2021 2:58 PM > To: dev@dpdk.org > Cc: maxime.coque...@redhat.com; Xia, Chenbo ; > Pai G, Sunil ; Hu, Jiayu ; Ding, > Xuan ; Jiang, Cheng1 ; Ma, > WenwuX ; Yang, YvonneX > ; Wang, YuanX > Subject: [PATCH 1/2] vhost:

Re: [dpdk-dev] [PATCH 2/2] vhost: support thread-safe API for clearing in-flight packets in async vhost

2021-09-21 Thread Yang, YvonneX
> -Original Message- > From: Wang, YuanX > Sent: Thursday, September 9, 2021 2:58 PM > To: dev@dpdk.org > Cc: maxime.coque...@redhat.com; Xia, Chenbo ; > Pai G, Sunil ; Hu, Jiayu ; Ding, > Xuan ; Jiang, Cheng1 ; Ma, > WenwuX ; Yang, YvonneX > ; Wang, YuanX > Subject: [PATCH 2/2] vhost:

Re: [dpdk-dev] [PATCH] net/ice: add ability to reduce the Rx latency

2021-09-21 Thread Zhang, AlvinX
> -Original Message- > From: Kevin Traynor > Sent: Tuesday, September 21, 2021 5:21 PM > To: Zhang, AlvinX ; Zhang, Qi Z > ; Guo, Junfeng > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] net/ice: add ability to reduce the Rx latency > > On 18/09/2021 02:33, Zhang, AlvinX wrote: > >>

Re: [dpdk-dev] [PATCH v5 05/16] dma/idxd: create dmadev instances on pci probe

2021-09-21 Thread fengchengwen
On 2021/9/17 23:24, Kevin Laatz wrote: > When a suitable device is found during the PCI probe, create a dmadev > instance for each HW queue. HW definitions required are also included. > > Signed-off-by: Bruce Richardson > Signed-off-by: Kevin Laatz > Reviewed-by: Conor Walsh > > --- > v4: reba

Re: [dpdk-dev] [PATCH v5 04/16] dma/idxd: create dmadev instances on bus probe

2021-09-21 Thread fengchengwen
On 2021/9/17 23:24, Kevin Laatz wrote: > When a suitable device is found during the bus scan/probe, create a dmadev > instance for each HW queue. Internal structures required for device > creation are also added. > > Signed-off-by: Bruce Richardson > Signed-off-by: Kevin Laatz > Reviewed-by: Con

Re: [dpdk-dev] [PATCH v3 2/8] dmadev: add burst capacity API

2021-09-21 Thread fengchengwen
On 2021/9/22 2:11, Jerin Jacob wrote: > On Tue, Sep 21, 2021 at 10:42 PM Pai G, Sunil wrote: >> >> Hi Jerin, >> >> >> > To understand it better, Could you share more details on feedback > mechanism on your application enqueue > > app_enqueue_v1(.., nb_seg) > { >

Re: [dpdk-dev] I40e-dpdk_18.11-Bonding issue

2021-09-21 Thread Min Hu (Connor)
Hi, Nishant, according to the log, it failed when VF called rte_eth_dev_default_mac_addr_set. I think it may has nothing to do with bond. I suggest you check out the ops (i40e driver) ,that is, 'i40evf_set_default_mac_addr', maybe check out the input parameter, or the communication way between

Re: [dpdk-dev] Arm roadmap for 21.11

2021-09-21 Thread Honnappa Nagarahalli
> > 12/09/2021 00:01, Honnappa Nagarahalli: > > 1) New rte_wait_until_xxx APIs and their use in various libraries > > I don't understand what it is referring to. > Please could you explain? Currently we have rte_wait_until_equal API. However this API is not applicable in cases which can involv

Re: [dpdk-dev] Arm roadmap for 21.11

2021-09-21 Thread Thomas Monjalon
12/09/2021 00:01, Honnappa Nagarahalli: > 1) New rte_wait_until_xxx APIs and their use in various libraries I don't understand what it is referring to. Please could you explain? What about the old item "Arm CRC32 in generic API"?

Re: [dpdk-dev] [PATCH v2] examples/l3fwd: add changes to use event vector

2021-09-21 Thread Thomas Monjalon
04/09/2021 09:46, Shijith Thotton: > +* ``--enable-vector:`` Optional, Enable event vectorization. Only valid if > --mode=eventdev. As for the IPsec example, the option name --event-vector would be more appropriate because "vector" can refer to something else. > + > +* ``--vector-size:`` Optiona

Re: [dpdk-dev] [PATCH v2] net/af_packet: remove timestamp from packet status

2021-09-21 Thread Tudor Cornea
Thanks for the suggestion. I will send a new version of the patch with the required changes. Tudor On Mon, 20 Sept 2021 at 20:49, Ferruh Yigit wrote: > On 9/13/2021 6:23 PM, Tudor Cornea wrote: > > We should eliminate the timestamp status from the packet > > status. This should only matter if t

Re: [dpdk-dev] [PATCH v2] net/af_packet: reinsert the stripped vlan tag

2021-09-21 Thread Tudor Cornea
Thanks, Ferruh I will perform the suggested recommendations in version 3 of the patch. On Mon, 20 Sept 2021 at 18:41, Ferruh Yigit wrote: > On 9/8/2021 9:59 AM, Tudor Cornea wrote: > > The af_packet pmd driver binds to a raw socket and allows > > sending and receiving of packets through the ker

Re: [dpdk-dev] [EXT] [PATCH v2 4/5] eventdev/rx_adapter: implement per queue event buffer

2021-09-21 Thread Pavan Nikhilesh Bhagavatula
>this patch implement the per queue event buffer after >required validations. > >Signed-off-by: Naga Harish K S V >--- > lib/eventdev/rte_event_eth_rx_adapter.c | 188 >++-- > 1 file changed, 139 insertions(+), 49 deletions(-) > >@@ -2277,6 +2356,8 @@ >rte_event_eth_rx_adapte

Re: [dpdk-dev] [EXT] [PATCH v2 3/5] eventdev/rx_adapter:add per queue event buffer configure support

2021-09-21 Thread Pavan Nikhilesh Bhagavatula
>-Original Message- >From: dev On Behalf Of Naga Harish K S V >Sent: Tuesday, September 21, 2021 2:52 PM >To: Jerin Jacob Kollanukkaran ; >jay.jayatheert...@intel.com >Cc: dev@dpdk.org >Subject: [EXT] [dpdk-dev] [PATCH v2 3/5] eventdev/rx_adapter:add per >queue event buffer configure su

Re: [dpdk-dev] [EXT] [PATCH v2 2/5] test/event: add unit test for event buffer size config api

2021-09-21 Thread Pavan Nikhilesh Bhagavatula
>this patch adds unit test for >rte_event_eth_rx_adapter_create_with_params >api and validate all possible input combinations. > >Signed-off-by: Naga Harish K S V >--- > app/test/test_event_eth_rx_adapter.c | 53 >+--- > 1 file changed, 49 insertions(+), 4 deletions(-) > >di

Re: [dpdk-dev] [EXT] [PATCH v2 1/5] eventdev/rx_adapter: add support to configure event buffer size

2021-09-21 Thread Pavan Nikhilesh Bhagavatula
>Currently Rx event buffer is static array with a default size >of 192(6*BATCH_SIZE). > >``rte_event_eth_rx_adapter_create_with_params`` api is added which >takes >``struct rte_event_eth_rx_adapter_params`` to configure event >buffer size in addition other params . The event buffer is >allocated fr

Re: [dpdk-dev] [EXT] Re: [PATCH] RFC: ethdev: add reassembly offload

2021-09-21 Thread Thomas Monjalon
29/08/2021 15:14, Akhil Goyal: > > On 8/23/21 1:02 PM, Akhil Goyal wrote: > > > +#define DEV_RX_OFFLOAD_REASSEMBLY0x1000 > > > > I think it should be: > > RTE_ETH_RX_OFFLOAD_IPV4_REASSEMBLY > > > > i.e. have correct prefix similar to > > RTE_ETH_RX_OFFLOAD_BUFFER_SPLIT and mention IPv

[dpdk-dev] [PATCH v2] net: fix checksum API documentation

2021-09-21 Thread Lance Richardson
Minor corrections and improvements to documentation for checksum APIs. Fixes: 6006818cfb26 ("net: new checksum functions") Fixes: 45a08ef55e44 ("net: introduce functions to verify L4 checksums") Cc: sta...@dpdk.org Signed-off-by: Lance Richardson --- v2: - Updates for rte_ipv4_udptcp_cksum() l

Re: [dpdk-dev] [dpdk-stable] [PATCH] net: fix checksum API documentation

2021-09-21 Thread Lance Richardson
On Tue, Sep 21, 2021 at 6:11 AM Morten Brørup wrote: > Ferruh, the description of the return value is technically correct; it > mentions the IP packet, not the IP header. > So this change is a clarification only. > > However, I agree that the same clarification would also benefit > 'rte_ipv4_ud

Re: [dpdk-dev] [PATCH v5 2/2] ethdev: change queue release callback

2021-09-21 Thread Ferruh Yigit
On 9/18/2021 1:35 PM, Xueming Li wrote: > Currently, most ethdev callback API use queue ID as parameter, but Rx > and Tx queue release callback use queue object which is used by Rx and > Tx burst data plane callback. > > To align with other eth device queue configuration callbacks: > - queue relea

Re: [dpdk-dev] [PATCH v3 2/8] dmadev: add burst capacity API

2021-09-21 Thread Jerin Jacob
On Tue, Sep 21, 2021 at 10:42 PM Pai G, Sunil wrote: > > Hi Jerin, > > > > > > > To understand it better, Could you share more details on feedback > > > > mechanism on your application enqueue > > > > > > > > app_enqueue_v1(.., nb_seg) > > > > { > > > > /* Not enough space, Let appli

Re: [dpdk-dev] [PATCH v3 0/6] support oops handling

2021-09-21 Thread Jerin Jacob
On Tue, Sep 21, 2021 at 11:00 PM Thomas Monjalon wrote: > > 06/09/2021 06:17, jer...@marvell.com: > > It is handy to get detailed OOPS information like Linux kernel > > when DPDK application crashes without losing any of the features > > provided by coredump infrastructure by the OS. > > > > This

Re: [dpdk-dev] [PATCH] net/af_xdp: fix support of secondary process

2021-09-21 Thread Stephen Hemminger
On Mon, 20 Sep 2021 15:09:36 + "Loftus, Ciara" wrote: > > > > On Mon, 20 Sep 2021 13:23:57 + > > "Loftus, Ciara" wrote: > > > > > > -Original Message- > > > > From: dev On Behalf Of Stephen Hemminger > > > > Sent: Friday 3 September 2021 17:15 > > > > To: dev@dpdk.org > > >

Re: [dpdk-dev] [dpdk-stable] [DPDK] net/virtio: fix check scatter on all Rx queues

2021-09-21 Thread Kevin Traynor
On 15/09/2021 19:37, David Marchand wrote: On Wed, Aug 4, 2021 at 10:36 AM wrote: From: Zhihong Peng This patch fixes the wrong way to obtain virtqueue. The end of virtqueue cannot be judged based on whether the array is NULL. Indeed, good catch. I can reproduce a crash with v20.11.3 whic

Re: [dpdk-dev] [PATCH v3 0/6] support oops handling

2021-09-21 Thread Thomas Monjalon
06/09/2021 06:17, jer...@marvell.com: > It is handy to get detailed OOPS information like Linux kernel > when DPDK application crashes without losing any of the features > provided by coredump infrastructure by the OS. > > This patch series introduces the APIs to handle OOPS in DPDK. I don't unde

Re: [dpdk-dev] [PATCH v3] vhost: add unsafe API to check inflight packets

2021-09-21 Thread Kevin Traynor
On 16/09/2021 03:58, Xuan Ding wrote: In async data path, when vring state changes, it is necessary to know the number of inflight packets in DMA engine. This patch provides a thread unsafe API to return the number of inflight packets without using any lock. Signed-off-by: Xuan Ding --- v3: * F

Re: [dpdk-dev] [PATCH v3 2/8] dmadev: add burst capacity API

2021-09-21 Thread Pai G, Sunil
Hi Jerin, > > > To understand it better, Could you share more details on feedback > > > mechanism on your application enqueue > > > > > > app_enqueue_v1(.., nb_seg) > > > { > > > /* Not enough space, Let application handle it by > > > dropping or resubmitting */ > > >

Re: [dpdk-dev] [PATCH v3 2/8] dmadev: add burst capacity API

2021-09-21 Thread Jerin Jacob
On Tue, Sep 21, 2021 at 9:05 PM Pai G, Sunil wrote: > > Hi Jerin, > > > > > > > > The fact is that it's very hard for apps to calculate the > > > > > available space of a > > > > DMA ring. > > > > > > > > Yes, I agree. > > > > > > > > My question is more why to calculate the space per burst and

Re: [dpdk-dev] [PATCH v4 5/5] test/crypto: add UDP encapsulation test cases

2021-09-21 Thread Akhil Goyal
> Subject: [PATCH v4 5/5] test/crypto: add UDP encapsulation test cases Test/crypto: add UDP encapsulated IPSec cases > > From: Tejasree Kondoj > > Adding UDP encapsulation test cases. Elaborate the description as well Apart from that, Acked-by: Akhil Goyal > > Signed-off-by: Tejasree Kondoj

Re: [dpdk-dev] [PATCH v5 1/2] ethdev: make queue release callback optional

2021-09-21 Thread Ferruh Yigit
On 9/18/2021 1:35 PM, Xueming Li wrote: > Some drivers don't need Rx and Tx queue release callback, make them > optional. Clean up empty queue release callbacks for some drivers. > > Signed-off-by: Xueming Li > Reviewed-by: Andrew Rybchenko Acked-by: Ferruh Yigit

Re: [dpdk-dev] [PATCH v4 06/11] dma/ioat: add data path job submission functions

2021-09-21 Thread Conor Walsh
On 20/09/2021 14:36, Bruce Richardson wrote: On Fri, Sep 17, 2021 at 03:42:22PM +, Conor Walsh wrote: Add data path functions for enqueuing and submitting operations to IOAT devices. Signed-off-by: Conor Walsh Reviewed-by: Kevin Laatz --- doc/guides/dmadevs/ioat.rst| 54 ++

Re: [dpdk-dev] [PATCH v4 3/5] test/crypto: add lookaside IPsec ICV corrupt test case

2021-09-21 Thread Akhil Goyal
> Subject: [PATCH v4 3/5] test/crypto: add lookaside IPsec ICV corrupt test case > > From: Tejasree Kondoj > > Adding lookaside IPsec ICV corrupt test case. Please elaborate the test case a bit more. There is no documentation for the test cases, we can Atleast add appropriate description. Apart

Re: [dpdk-dev] [PATCH v4 01/11] dma/ioat: add device probe and removal functions

2021-09-21 Thread Conor Walsh
On Fri, Sep 17, 2021 at 03:42:17PM +, Conor Walsh wrote: Add the basic device probe/remove skeleton code and initial documentation for new IOAT DMA driver. Maintainers update is also included in this patch. Signed-off-by: Conor Walsh Reviewed-by: Kevin Laatz --- MAINTAINERS

Re: [dpdk-dev] [PATCH v2 3/5] eventdev/rx_adapter:add per queue event buffer configure support

2021-09-21 Thread Jerin Jacob
On Tue, Sep 21, 2021 at 2:52 PM Naga Harish K S V wrote: > > To configure per queue event buffer size, applications sets > ``rte_event_eth_rx_adapter_params::use_queue_event_buf`` flag > as true and is passed to ``rte_event_eth_rx_adapter_create_with_params`` > api. > > The per queue event buffer

Re: [dpdk-dev] [PATCH v4 4/5] test/crypto: add IV gen tests

2021-09-21 Thread Akhil Goyal
> Subject: [PATCH v4 4/5] test/crypto: add IV gen tests > > From: Tejasree Kondoj > > Add test cases to verify IV generated by PMD. Title and description of the patch do not specify that This is for lookaside IPSec. Title: test/crypto: add IV gen cases for IPsec Description: Added cases to ver

Re: [dpdk-dev] [PATCH v4 11/11] devbind: move ioat device ID for ICX to dmadev category

2021-09-21 Thread Conor Walsh
On Fri, Sep 17, 2021 at 03:42:27PM +, Conor Walsh wrote: Move Intel IOAT devices on Ice Lake systems from Misc to DMA devices. Signed-off-by: Conor Walsh Reviewed-by: Kevin Laatz --- usertools/dpdk-devbind.py | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/us

Re: [dpdk-dev] [PATCH v4 02/11] dma/ioat: create dmadev instances on PCI probe

2021-09-21 Thread Conor Walsh
On Fri, Sep 17, 2021 at 03:42:18PM +, Conor Walsh wrote: When a suitable device is found during the PCI probe, create a dmadev instance for each channel. Internal structures and HW definitions required for device creation are also included. Signed-off-by: Conor Walsh Reviewed-by: Kevin L

Re: [dpdk-dev] [PATCH v4 2/5] test/crypto: add combined mode tests

2021-09-21 Thread Akhil Goyal
> Subject: [PATCH v4 2/5] test/crypto: add combined mode tests Title: test/crypto: add combined mode IPSec cases > In description explain the meaning of combined mode. Also mention that the encap and decap are done one after the other, Hence known test vectors are not required. Apart from that

[dpdk-dev] [PATCH v2] stack: fix reload head when pop fails

2021-09-21 Thread Julien Meunier
The previous commit 18effad9cfa7 ("stack: reload head when pop fails") only changed C11 implementation, not generic implementation. List head must be loaded right before continue (when failed to find the new head). Without this, one thread might keep trying and failing to pop items without ever lo

Re: [dpdk-dev] [PATCH v4 1/5] test/crypto: add lookaside IPsec tests

2021-09-21 Thread Akhil Goyal
Hi Anoob, Few minor comments, Please see inline. Apart from that, Acked-by: Akhil Goyal > Update title as Test/crypto: add lookaside IPsec cases. > +static int > +security_proto_supported(enum rte_security_session_action_type action, > + enum rte_security_session_protocol proto); > + > +sta

Re: [dpdk-dev] [PATCH v3 2/8] dmadev: add burst capacity API

2021-09-21 Thread Pai G, Sunil
Hi Jerin, > > > > The fact is that it's very hard for apps to calculate the > > > > available space of a > > > DMA ring. > > > > > > Yes, I agree. > > > > > > My question is more why to calculate the space per burst and > > > introduce yet another fastpath API. > > > For example, the applicatio

Re: [dpdk-dev] [PATCH] net/sfc: fix getting accumulative SW xstat

2021-09-21 Thread Ferruh Yigit
On 9/15/2021 11:40 AM, Andrew Rybchenko wrote: > From: Ivan Ilchenko > > Add missing initialisation of the accumulative SW xstat to > zero since it is sum of per-queue xstats. > > Fixes: fdd7719eb3c ("net/sfc: add xstats for Rx/Tx doorbells") > Cc: sta...@dpdk.org > > Signed-off-by: Ivan Ilchen

Re: [dpdk-dev] [PATCH v3 1/2] eal: add additional info if core list too long

2021-09-21 Thread David Hunt
On 21/9/2021 2:51 PM, David Marchand wrote: On Tue, Sep 21, 2021 at 1:50 PM David Hunt wrote: static int eal_parse_coremask(const char *coremask, int *cores) { @@ -839,54 +880,89 @@ eal_parse_service_corelist(const char *corelist) static int eal_parse_corelist(const char *corelist,

Re: [dpdk-dev] [PATCH v3 2/8] dmadev: add burst capacity API

2021-09-21 Thread Jerin Jacob
On Tue, Sep 21, 2021 at 7:46 PM Pai G, Sunil wrote: > > Hi Jerin, Hi Sunil, > > > > > > > From: Kevin Laatz <[2]kevin.la...@intel.com> > > > > > > Add a burst capacity check API to the dmadev library. This API > > > > > > is > > > > > > useful to > > > > > > applications wh

Re: [dpdk-dev] [EXT] [PATCH] app: fix buffer overrun

2021-09-21 Thread Pavan Nikhilesh Bhagavatula
>This patch fixes a possible buffer overrun problem in crypto perf test. >Previously when user configured aad size is over 12 bytes the copy of >template aad will cause a buffer overrun. >The problem is fixed by only copy up to 12 bytes of aad template. > >Fixes: 761a321acf91 ("event/cnxk: support

Re: [dpdk-dev] [PATCH v2] update Windows roadmap

2021-09-21 Thread Thomas Monjalon
11/09/2021 01:07, Dmitry Kozlyuk: > Add the current status and the actual roadmap, remove completed entries. > More detailed plan in the mailing list: > https://mails.dpdk.org/archives/dev/2021-August/217463.html > > Signed-off-by: Dmitry Kozlyuk > --- > v2: improve wording, fix typos, remove imp

Re: [dpdk-dev] [PATCH v3 2/8] dmadev: add burst capacity API

2021-09-21 Thread Pai G, Sunil
Hi Jerin, > > > > > From: Kevin Laatz <[2]kevin.la...@intel.com> > > > > > Add a burst capacity check API to the dmadev library. This API is > > > > > useful to > > > > > applications which need to how many descriptors can be enqueued > in > > > > > the > > > > > cur

Re: [dpdk-dev] [PATCH] kni: Fix request overwritten

2021-09-21 Thread Ferruh Yigit
On 9/17/2021 1:31 PM, Elad Nachman wrote: > Fix lack of multiple KNI requests handling support by introducing a > rotating ring mechanism for the sync buffer. > Thanks Elad for the patch. I have missed that 'rte_kni_handle_request()' can be called by multiple cores, at least kni sample app does

Re: [dpdk-dev] [PATCH v1 3/5] eventdev:rx_adapter:add per queue event buffer configure support

2021-09-21 Thread Naga Harish K, S V
Hi Jerin, > -Original Message- > From: Jerin Jacob > Sent: Monday, September 20, 2021 11:53 AM > To: Naga Harish K, S V ; Pavan Nikhilesh > ; mattias.ronnblom > > Cc: Jerin Jacob ; Jayatheerthan, Jay > ; dpdk-dev > Subject: Re: [dpdk-dev] [PATCH v1 3/5] eventdev:rx_adapter:add per queue

Re: [dpdk-dev] [PATCH v1 1/5] eventdev: rx_adapter: add support to configure event buffer size

2021-09-21 Thread Naga Harish K, S V
Hi Jerin, Please see the replies inline. > -Original Message- > From: Jerin Jacob > Sent: Monday, September 20, 2021 11:50 AM > To: Naga Harish K, S V > Cc: Jerin Jacob ; Jayatheerthan, Jay > ; dpdk-dev ; Kundapura, > Ganapati > Subject: Re: [dpdk-dev] [PATCH v1 1/5] eventdev: rx_adap

Re: [dpdk-dev] [PATCH] net/mlx5: fix empty err msg in mlx5_flow_tunnel_validate

2021-09-21 Thread Slava Ovsiienko
Hi, Winxu Thank you for the patch. > If the mlx5_flow_tunnel_validate validate the flow tunnel rule failed, the Typo? "validate" -> "validating" ? > err_msg is empty in the rte_flow_error. Sorry, what do you mean "empty"? It is NULL, not pointing to empty string "". Patch looks OK for me, could

Re: [dpdk-dev] [PATCH 3/3] net/mlx5: Fix RSS RETA update

2021-09-21 Thread Slava Ovsiienko
Hi, Maxime Very nice catch, thank you for the patch. Minor typo in the commit message "ithat" -> "that". Besides this: Acked-by: Viacheslav Ovsiienko > -Original Message- > From: Maxime Coquelin > Sent: Friday, September 10, 2021 12:18 > To: dev@dpdk.org; chenbo@intel.com; amore..

Re: [dpdk-dev] [PATCH v3 1/2] eal: add additional info if core list too long

2021-09-21 Thread David Marchand
On Tue, Sep 21, 2021 at 1:50 PM David Hunt wrote: > static int > eal_parse_coremask(const char *coremask, int *cores) > { > @@ -839,54 +880,89 @@ eal_parse_service_corelist(const char *corelist) > static int > eal_parse_corelist(const char *corelist, int *cores) > { > - unsigned count

Re: [dpdk-dev] [PATCH v6 1/3] security: enforce semantics for Tx inline processing

2021-09-21 Thread Akhil Goyal
> > Not all net PMD's/HW can parse packet and identify L2 header and > L3 header locations on Tx. This is inline with other Tx offloads > requirements such as L3 checksum, L4 checksum offload, etc, > where mbuf.l2_len, mbuf.l3_len etc, needs to be set for HW to be > able to generate checksum. Sinc

Re: [dpdk-dev] [PATCH v3 00/20] ice/base: add parser module

2021-09-21 Thread Zhang, Qi Z
> -Original Message- > From: Zhang, Qi Z > Sent: Tuesday, September 21, 2021 9:20 PM > To: Yang, Qiming > Cc: Guo, Junfeng ; dev@dpdk.org; Zhang, Qi Z > > Subject: [PATCH v3 00/20] ice/base: add parser module > > Add the parser module that can parse on a raw packet then figure out th

[dpdk-dev] [PATCH] app: fix buffer overrun

2021-09-21 Thread Przemyslaw Zegan
This patch fixes a possible buffer overrun problem in crypto perf test. Previously when user configured aad size is over 12 bytes the copy of template aad will cause a buffer overrun. The problem is fixed by only copy up to 12 bytes of aad template. Fixes: 761a321acf91 ("event/cnxk: support vecto

Re: [dpdk-dev] [PATCH v3 1/2] eal: add additional info if core list too long

2021-09-21 Thread Bruce Richardson
On Tue, Sep 21, 2021 at 02:16:35PM +0100, David Hunt wrote: >On 21/9/2021 1:04 PM, David Hunt wrote: > > On 21/9/2021 12:57 PM, Bruce Richardson wrote: > > On Tue, Sep 21, 2021 at 12:50:14PM +0100, David Hunt wrote: > > If the user requests to use an lcore above 128 using -l,

[dpdk-dev] [PATCH v3 20/20] net/ice/base: add API for parser profile initialization

2021-09-21 Thread Qi Zhang
Add API ice_parser_profile_init to init a parser profile base on a parser result and a mask buffer. The ice_parser_profile can feed to low level FXP engine to create HW profile / field vector directly. Signed-off-by: Qi Zhang Acked-by: Junfeng Guo --- drivers/net/ice/base/ice_parser.c | 112 +++

[dpdk-dev] [PATCH v3 19/20] net/ice/base: add tunnel port support for parser

2021-09-21 Thread Qi Zhang
UDP tunnel can be added/deleted for vxlan, geneve, ecpri through below APIs: ice_parser_vxlan_tunnel_set ice_parser_geneve_tunnel_set ice_parser_ecpri_tunnel_set Signed-off-by: Qi Zhang Acked-by: Junfeng Guo --- drivers/net/ice/base/ice_parser.c | 75 +++ drivers/net

[dpdk-dev] [PATCH v3 18/20] net/ice/base: support double VLAN mode configure for parser

2021-09-21 Thread Qi Zhang
Add API ice_parser_dvm_set to support turn on/off parser's double vlan mode. Signed-off-by: Qi Zhang Acked-by: Junfeng Guo --- drivers/net/ice/base/ice_bst_tcam.c | 28 drivers/net/ice/base/ice_bst_tcam.h | 4 drivers/net/ice/base/ice_parser.c | 27 +

[dpdk-dev] [PATCH v3 17/20] net/ice/base: add parser execution main loop

2021-09-21 Thread Qi Zhang
Implement function ice_parser_rt_execute which perform the main loop of the parser. Signed-off-by: Qi Zhang Acked-by: Junfeng Guo --- drivers/net/ice/base/ice_parser_rt.c | 782 ++- drivers/net/ice/base/ice_parser_rt.h | 27 +- 2 files changed, 803 insertions(+), 6 dele

[dpdk-dev] [PATCH v3 16/20] net/ice/base: add helper function to aggregate flags

2021-09-21 Thread Qi Zhang
Add internal helper function ice_xlt_kb_flg_get to aggregate 64 bit packet flag into 16 bit key builder flags. Signed-off-by: Qi Zhang Acked-by: Junfeng Guo --- drivers/net/ice/base/ice_xlt_kb.c | 27 +++ drivers/net/ice/base/ice_xlt_kb.h | 1 + 2 files changed, 28 inse

[dpdk-dev] [PATCH v3 15/20] net/ice/base: add helper function to redirect flags

2021-09-21 Thread Qi Zhang
Add internal helper function ice_flg_redirect to redirect parser flags to packet flags. Signed-off-by: Qi Zhang Acked-by: Junfeng Guo --- drivers/net/ice/base/ice_flg_rd.c | 23 +++ drivers/net/ice/base/ice_flg_rd.h | 1 + 2 files changed, 24 insertions(+) diff --git a/dri

[dpdk-dev] [PATCH v3 14/20] net/ice/base: add helper function for ptype markers match

2021-09-21 Thread Qi Zhang
Add internal helper function ice_ptype_mk_tcam_match for ptype markers matching in tcam table. Signed-off-by: Qi Zhang Acked-by: Junfeng Guo --- drivers/net/ice/base/ice_ptype_mk.c | 22 ++ drivers/net/ice/base/ice_ptype_mk.h | 3 +++ 2 files changed, 25 insertions(+) diff

  1   2   >