Re: [dpdk-dev] [PATCH] test/atomic: fix false failures for 128-bit atomic compare exchange test

2021-09-02 Thread Ruifeng Wang
> -Original Message- > From: dev On Behalf Of David Christensen > Sent: Friday, September 3, 2021 1:41 AM > To: dev@dpdk.org > Cc: Phil Yang ; sta...@dpdk.org; David Christensen > > Subject: [dpdk-dev] [PATCH] test/atomic: fix false failures for 128-bit atomic > compare exchange test > >

[dpdk-dev] [Bug 806] Throughput with dpdk + vhost-user + vIOMMU is lower with it's first connection

2021-09-02 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=806 Bug ID: 806 Summary: Throughput with dpdk + vhost-user + vIOMMU is lower with it's first connection Product: DPDK Version: 20.11 Hardware: x86 OS: Linux

Re: [dpdk-dev] [PATCH] eventdev: cryptodev start in crypto adapter spec

2021-09-02 Thread Akhil Goyal
> Event crypto adapter spec does not mention about cryptodev start and > stop. Cryptodev attached to the adapter should be started before calling > crypto adapter start. Added the same in spec and test application. > > Signed-off-by: Shijith Thotton > --- Acked-by: Akhil Goyal

[dpdk-dev] [PATCH] eventdev: cryptodev start in crypto adapter spec

2021-09-02 Thread Shijith Thotton
Event crypto adapter spec does not mention about cryptodev start and stop. Cryptodev attached to the adapter should be started before calling crypto adapter start. Added the same in spec and test application. Signed-off-by: Shijith Thotton --- app/test/test_event_crypto_adapter.c| 8

[dpdk-dev] Intel FW 8.15 with DPDK 20.11 & 21.02

2021-09-02 Thread Korolevskiy, Igor
Dear DPDK community, Would you please help us to understand if we can use Intel 8.15 firmware with DPDK 20.11 and 21.02 versions? We have huge demand on our servers with usage of Nokia SBC and DPDK, but stuck on validation. Thank you in advance! Igor Korolevskiy | System Consultant @ Dell Tec

[dpdk-dev] [PATCH v3] build: add meson options of max_memseg_lists and atomic_mbuf_ref_counts

2021-09-02 Thread Kefu Chai
RTE_MAX_MEMSEG_LISTS = 128 is not enough for high-memory machines, in our case, we need to increase it to 8192. so add an option so user can override it. RTE_MBUF_REFCNT_ATOMIC = 0 is not necessary for applications like Seastar, where it's safe to assume that the mbuf refcnt is only updated by a si

[dpdk-dev] [PATCH v2] build: add meson option of "max_memseg_lists" and "mbuf_refcnt_atomic"

2021-09-02 Thread Kefu Chai
RTE_MAX_MEMSEG_LISTS = 128 is not enough for high-memory machines, so add an option so user can override it. RTE_MBUF_REFCNT_ATOMIC = 0 is not necessary for applications like Seastar, where it's safe to assume that the mbuf refcnt is only updated by a single core only. --- v2: revise the commit

[dpdk-dev] [PATCH] build: add meson option of "max_memseg_lists" and "mbuf_refcnt_atomic"

2021-09-02 Thread Kefu Chai
RTE_MAX_MEMSEG_LISTS = 128 is not enough for some use cases, so add an option so user can override it. RTE_MBUF_REFCNT_ATOMIC = 0 is enough for applications like Seastar, where it's safe to assume that the mbuf refcnt is only updated by a single core only. Signed-off-by: Kefu Chai --- config/mes

[dpdk-dev] [PATCH v2] net/ice: fix representor port segmentation fault

2021-09-02 Thread dapengx . yu
From: Dapeng Yu If DCF representor port is closed after DCF port is closed, there will be segmentation fault because representor accesses the released resource of DCF port. This patch makes DCF representor port is always closed before DCF port is closed. Fixes: 5674465a32c8 ("net/ice: add DCF V

[dpdk-dev] [PATCH v3 5/5] test/crypto: add UDP encapsulation test cases

2021-09-02 Thread Anoob Joseph
From: Tejasree Kondoj Adding UDP encapsulation test cases. Signed-off-by: Tejasree Kondoj --- app/test/test_cryptodev.c| 19 +++ app/test/test_cryptodev_security_ipsec.c | 28 app/test/test_cryptodev_security_ipsec.h | 1 + 3 files

[dpdk-dev] [PATCH v3 4/5] test/crypto: add IV gen tests

2021-09-02 Thread Anoob Joseph
From: Tejasree Kondoj Add test cases to verify IV generated by PMD. Signed-off-by: Anoob Joseph Signed-off-by: Tejasree Kondoj --- app/test/test_cryptodev.c| 19 app/test/test_cryptodev_security_ipsec.c | 52 app/test/test_cryptode

[dpdk-dev] [PATCH v3 3/5] test/crypto: add lookaside IPsec ICV corrupt test case

2021-09-02 Thread Anoob Joseph
From: Tejasree Kondoj Adding lookaside IPsec ICV corrupt test case. Signed-off-by: Anoob Joseph Signed-off-by: Tejasree Kondoj --- app/test/test_cryptodev.c| 16 app/test/test_cryptodev_security_ipsec.c | 30 -- app/test/test_crypto

[dpdk-dev] [PATCH v3 2/5] test/crypto: add combined mode tests

2021-09-02 Thread Anoob Joseph
Add framework to test IPsec features with all supported combinations of ciphers. Signed-off-by: Anoob Joseph Signed-off-by: Tejasree Kondoj --- app/test/test_cryptodev.c| 73 +++-- app/test/test_cryptodev_security_ipsec.c | 107 +-- a

[dpdk-dev] [PATCH v3 1/5] test/crypto: add lookaside IPsec tests

2021-09-02 Thread Anoob Joseph
Added test case for lookaside IPsec. Inbound known vector tests are added. Cipher list: AES-GCM 128, 192 & 256 Signed-off-by: Anoob Joseph Signed-off-by: Tejasree Kondoj --- app/test/meson.build | 1 + app/test/test.h| 6 +

[dpdk-dev] [PATCH v3 0/5] Add lookaside IPsec tests

2021-09-02 Thread Anoob Joseph
Add lookaside IPsec functional tests. Known vector tests and combined mode framework is added. Known vectors are outbound vectors based on https://datatracker.ietf.org/doc/html/draft-mcgrew-gcm-test-01 The vectors are updated to have sequence number as 1 & L4 checksum computed correctly. And they

Re: [dpdk-dev] [PATCH] net/ice: fix representor port segmentation fault

2021-09-02 Thread Wang, Haiyue
> -Original Message- > From: Yu, DapengX > Sent: Friday, September 3, 2021 11:09 > To: Wang, Haiyue ; Yang, Qiming > ; Zhang, Qi Z > > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: RE: [PATCH] net/ice: fix representor port segmentation fault > > > > > -Original Message- > > Fro

[dpdk-dev] [Bug 805] af_xdp PMD is broken with primary/secondary process

2021-09-02 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=805 Bug ID: 805 Summary: af_xdp PMD is broken with primary/secondary process Product: DPDK Version: 21.11 Hardware: All OS: Linux Status: UNCONFIRMED Severity: major

Re: [dpdk-dev] [PATCH] net/ice: fix representor port segmentation fault

2021-09-02 Thread Yu, DapengX
> -Original Message- > From: Wang, Haiyue > Sent: Thursday, September 2, 2021 10:45 PM > To: Yu, DapengX ; Yang, Qiming > ; Zhang, Qi Z > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: RE: [PATCH] net/ice: fix representor port segmentation fault > > > -Original Message- > > From

Re: [dpdk-dev] [PATCH 3/5] app/dumpcap: add new packet capture application

2021-09-02 Thread Stephen Hemminger
Ken Thompson lives on... WARNING:TYPO_SPELLING: 'CREAT' may be misspelled - perhaps 'CREATE'? #705: FILE: app/dumpcap/main.c:605: + fd = open(output_name, O_WRONLY | O_CREAT, mode);

[dpdk-dev] [PATCH 5/5] MAINTAINERS: add entry for new pcapng and dumper

2021-09-02 Thread Stephen Hemminger
Claim responsibility for the new code. Signed-off-by: Stephen Hemminger --- MAINTAINERS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 266f5ac1dae8..06384ac2702d 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1429,6 +1429,12 @@ F: app/test/test_pdump.*

[dpdk-dev] [PATCH 4/5] doc: changes for new pcapng and dumpcap

2021-09-02 Thread Stephen Hemminger
Describe the new packet capture library and utilities Signed-off-by: Stephen Hemminger --- doc/api/doxy-api-index.md | 1 + doc/api/doxy-api.conf.in | 1 + doc/guides/howto/packet_capture_framework.rst | 67 doc/guides/prog_guide/index.

[dpdk-dev] [PATCH 3/5] app/dumpcap: add new packet capture application

2021-09-02 Thread Stephen Hemminger
This is a new packet capture application to replace existing pdump. The new application works like Wireshark dumpcap program and supports the pdump API features. It is not complete yet some features such as filtering are not implemented. Signed-off-by: Stephen Hemminger --- app/dumpcap/main.c

[dpdk-dev] [PATCH 2/5] pdump: support pcapng and filtering

2021-09-02 Thread Stephen Hemminger
This enhances the DPDK pdump library to support new pcapng format and filtering via BPF. The internal client/server protocol is changed to support two versions: the original pdump basic version and a new pcapng version. The internal version number (not part of exposed API or ABI) is intentionally

[dpdk-dev] [PATCH 1/5] librte_pcapng: add new library for writing pcapng files

2021-09-02 Thread Stephen Hemminger
This is utility library for writing pcapng format files used by Wireshark family of utilities. Older tcpdump also knows how to read (but not write) this format. See draft RFC https://www.ietf.org/id/draft-tuexen-opsawg-pcapng-03.html and https://github.com/pcapng/pcapng/ Signed-off-by: Stephe

[dpdk-dev] [PATCH 0/5] Packet capture framework enhancements

2021-09-02 Thread Stephen Hemminger
This patch set is a more complete version of the the enhanced packet capture support described last year. The new capture library and utility are: - faster avoids lots of extra I/O, does bursting, etc. - gives more information (multiple ports, queues, etc) - has a better user interface (same

Re: [dpdk-dev] [PATCH v19 7/7] app/test: add dmadev API test

2021-09-02 Thread fengchengwen
This is a tradeoff point. If we changed the log level of dmadev, it is difficult to know where the test case fails. So I prefer add more meaningful information, at least print out the function name. And V19 add format function name in log default, so the rte_dmadev's log will show like: rte_d

[dpdk-dev] [PATCH v2 5/5] net/sfc: allow to discern user flag on EF100 native datapath

2021-09-02 Thread Ivan Malov
Read out user flag from Rx prefix and indicate it to callers. Signed-off-by: Ivan Malov Reviewed-by: Andrew Rybchenko --- drivers/net/sfc/sfc_ef100_rx.c | 18 ++ drivers/net/sfc/sfc_rx.c | 3 +++ 2 files changed, 21 insertions(+) diff --git a/drivers/net/sfc/sfc_ef100_rx

[dpdk-dev] [PATCH v2 4/5] common/sfc_efx/base: add RxQ flag to use Rx prefix user flag

2021-09-02 Thread Ivan Malov
Add an RxQ flag to request support for user flag field of Rx prefix. The feature is supported only on EF100 and EF10 ESSB. Signed-off-by: Ivan Malov Reviewed-by: Andrew Rybchenko --- drivers/common/sfc_efx/base/ef10_rx.c | 54 -- drivers/common/sfc_efx/base/efx.h |

[dpdk-dev] [PATCH v2 3/5] net/sfc: allow to use EF100 native datapath Rx mark in flows

2021-09-02 Thread Ivan Malov
As of now, reading out mark on EF100 native datapath is used only by MAE counter support for delivery of generation count values. Make the feature available to flow action MARK users. Signed-off-by: Ivan Malov Reviewed-by: Andrew Rybchenko --- drivers/net/sfc/sfc_ef100_rx.c | 1 + drivers/net/s

[dpdk-dev] [PATCH v2 2/5] net/sfc: provide API to negotiate supported Rx meta features

2021-09-02 Thread Ivan Malov
This is a preparation step. Later patches will make features FLAG and MARK on EF100 native Rx datapath available to users. Signed-off-by: Ivan Malov Reviewed-by: Andrew Rybchenko --- drivers/net/sfc/sfc.h| 2 ++ drivers/net/sfc/sfc_ethdev.c | 34 ++ driv

[dpdk-dev] [PATCH v2 1/5] ethdev: add API to negotiate support for Rx meta information

2021-09-02 Thread Ivan Malov
Per-packet meta information (flag, mark and the likes) might be expensive to deliver in terms of small packet performance. If the features are not enabled by default, enabling them at short notice (for example, when a flow rule with action MARK gets created) without traffic disruption may not be po

[dpdk-dev] [PATCH v2 0/5] A means to negotiate support for Rx meta information

2021-09-02 Thread Ivan Malov
Back in 2019, commit c5b2e78d1172 ("doc: announce ethdev API changes in offload flags") announced changes in DEV_RX_OFFLOAD namespace intending to add new flags, RSS_HASH and FLOW_MARK. Since then, only the former has been added. Currently, there's no way for the application to configure the eth

[dpdk-dev] [PATCH v2] config/ppc: ignore gcc 11 psabi warnings

2021-09-02 Thread David Christensen
Suppress the gcc warning "note: the layout of aggregates containing vectors with 4-byte alignment has changed in GCC 5" on POWER systems by setting "-Wno-psabi". Warning was originally added to gcc in commit https://gcc.gnu.org/git/gitweb.cgi?p=gcc.git;h=9832651 to warn of the vector alignment cha

[dpdk-dev] [PATCH] eal/ppc: ignore gcc 10 stringop-overflow warnings

2021-09-02 Thread David Christensen
Suppress gcc warning "warning: writing 16 bytes into a region of size 0" for users of the POWER rte_memcpy() function. Existing rte_memcpy() code takes different code paths based on the actual size of the move so the warning is already addressed. See also commit b5b3ea803e47 ("eal/x86: ignore gcc

[dpdk-dev] [Bug 804] distributor: exiting workers can hang distributor core

2021-09-02 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=804 Bug ID: 804 Summary: distributor: exiting workers can hang distributor core Product: DPDK Version: 21.08 Hardware: All OS: All Status: UNCONFIRMED Severity: normal

[dpdk-dev] [PATCH v2 5/5] net/enetfec: add features

2021-09-02 Thread Apeksha Gupta
This patch adds checksum and VLAN offloads in enetfec network poll mode driver. Signed-off-by: Sachin Saxena Signed-off-by: Apeksha Gupta --- doc/guides/nics/enetfec.rst | 2 ++ doc/guides/nics/features/enetfec.ini | 3 ++ drivers/net/enetfec/enet_ethdev.c| 17 +- drivers

[dpdk-dev] [PATCH v2 4/5] net/enetfec: add enqueue and dequeue support

2021-09-02 Thread Apeksha Gupta
This patch adds burst enqueue and dequeue operations to the enetfec PMD. Loopback mode is also added, compile time flag 'ENETFEC_LOOPBACK' is used to enable this feature. By default loopback mode is disabled. Basic features added like promiscuous enable, basic stats. Signed-off-by: Sachin Saxena

[dpdk-dev] [PATCH v2 3/5] net/enetfec: support queue configuration

2021-09-02 Thread Apeksha Gupta
This patch adds Rx/Tx queue configuration setup operations. On packet reception the respective BD Ring status bit is set which is then used for packet processing. Signed-off-by: Sachin Saxena Signed-off-by: Apeksha Gupta --- drivers/net/enetfec/enet_ethdev.c | 230 +-

[dpdk-dev] [PATCH v2 2/5] net/enetfec: add UIO support

2021-09-02 Thread Apeksha Gupta
Implemented the fec-uio driver in kernel. enetfec PMD uses UIO interface to interact with "fec-uio" driver implemented in kernel for PHY initialisation and for mapping the allocated memory of register & BD from kernel to DPDK which gives access to non-cacheable memory for BD. Signed-off-by: Sachin

[dpdk-dev] [PATCH v2 1/5] net/enetfec: introduce NXP ENETFEC driver

2021-09-02 Thread Apeksha Gupta
ENETFEC (Fast Ethernet Controller) is a network poll mode driver for NXP SoC i.MX 8M Mini. This patch adds skeleton for enetfec driver with probe function. Signed-off-by: Sachin Saxena Signed-off-by: Apeksha Gupta --- doc/guides/nics/enetfec.rst | 121 doc/guides/

[dpdk-dev] [PATCH v2 0/5] drivers/net: add NXP ENETFEC driver

2021-09-02 Thread Apeksha Gupta
This patch series introduce the enetfec driver, ENETFEC (Fast Ethernet Controller) is a network poll mode driver for the inbuilt NIC found in the NXP i.MX 8M Mini SoC. An overview of the enetfec driver with probe and remove are in patch 1. Patch 2 design UIO interface so that user space directly c

[dpdk-dev] [PATCH] test/atomic: fix false failures for 128-bit atomic compare exchange test

2021-09-02 Thread David Christensen
When checking the results of the rte_atomic128_cmp_exchange() function, current code compares the values of a uint32_t and a uint64_t variable. If the number of lcores used by the test is large, or the value of the iteration count N is increased, the variable size mimatch can cause a false test fai

Re: [dpdk-dev] [PATCH] driver: i40evf device initialization

2021-09-02 Thread Xueming(Steven) Li
> -Original Message- > From: Ferruh Yigit > Sent: Monday, August 30, 2021 5:43 PM > To: Xueming(Steven) Li ; Kevin Traynor > ; Ben Magistro ; > dev@dpdk.org; Beilei Xing ; Luca Boccassi > ; Christian Ehrhardt > > Cc: ben.magis...@trinitycyber.com; stefan.baran...@trinitycyber.com; Qi

Re: [dpdk-dev] [PATCH v2] app/testpmd: add command to print representor info

2021-09-02 Thread Xueming(Steven) Li
> -Original Message- > From: Andrew Rybchenko > Sent: Wednesday, September 1, 2021 12:13 AM > To: Xiaoyun Li > Cc: dev@dpdk.org; Xueming(Steven) Li ; Viacheslav > Galaktionov ; Andy > Moreton > Subject: [PATCH v2] app/testpmd: add command to print representor info > > From: Viachesl

Re: [dpdk-dev] [PATCH v8] doc: add release milestones definition

2021-09-02 Thread Ferruh Yigit
On 8/26/2021 11:11 AM, Thomas Monjalon wrote: > From: Asaf Penso > > Adding more information about the release milestones. > This includes the scope of change, expectations, etc. > > Signed-off-by: Asaf Penso > Signed-off-by: Thomas Monjalon > Acked-by: John McNamara > Acked-by: Ajit Khaparde

Re: [dpdk-dev] [PATCH 1/5] ethdev: add API to negotiate support for Rx meta information

2021-09-02 Thread Kinsella, Ray
On 02/09/2021 15:23, Ivan Malov wrote: > Per-packet meta information (flag, mark and the likes) might > be expensive to deliver in terms of small packet performance. > If the features are not enabled by default, enabling them at > short notice (for example, when a flow rule with action MARK > ge

Re: [dpdk-dev] [PATCH] doc: announce change in vfio dma mapping

2021-09-02 Thread Kinsella, Ray
On 02/09/2021 10:50, Ferruh Yigit wrote: > On 9/1/2021 2:25 PM, Burakov, Anatoly wrote: >> On 01-Sep-21 12:42 PM, Ferruh Yigit wrote: >>> On 9/1/2021 12:01 PM, Burakov, Anatoly wrote: On 01-Sep-21 10:56 AM, Ferruh Yigit wrote: > On 9/1/2021 2:41 AM, Ding, Xuan wrote: >> Hi Ferruh, >

Re: [dpdk-dev] [PATCH v4] app/testpmd: add option to display extended statistics

2021-09-02 Thread Ferruh Yigit
On 8/20/2021 2:55 PM, Andrew Rybchenko wrote: > From: Ivan Ilchenko > > Add 'display-xstats' option for using in accompanying with Rx/Tx statistics > (i.e. 'stats-period' option or 'show port stats' interactive command) to > display specified list of extended statistics. > Overall +1 to the fea

Re: [dpdk-dev] [RFC] devbind: conform to PEP 8 recommended style

2021-09-02 Thread Stephen Hemminger
On Thu, 2 Sep 2021 16:50:14 +0100 Bruce Richardson wrote: > On Thu, Sep 02, 2021 at 08:24:58AM -0700, Stephen Hemminger wrote: > > On Thu, 2 Sep 2021 09:10:47 +0100 > > Bruce Richardson wrote: > > > > > On Wed, Sep 01, 2021 at 02:27:07PM -0700, Stephen Hemminger wrote: > > > > This fixes mo

Re: [dpdk-dev] [PATCH] ethdev: promote set ptypes API to stable

2021-09-02 Thread Kinsella, Ray
On 02/09/2021 09:17, pbhagavat...@marvell.com wrote: > From: Pavan Nikhilesh > > Remove experimental tag from rte_eth_dev_set_ptypes(). > > Signed-off-by: Pavan Nikhilesh Acked-by: Ray Kinsella

Re: [dpdk-dev] [EXT] [PATCH] crypto/mlx5: support timestamp format

2021-09-02 Thread Michael Baum
Hi, > -Original Message- > From: Akhil Goyal > Sent: Thursday, September 2, 2021 1:14 PM > To: Michael Baum ; dev@dpdk.org > Cc: Matan Azrad ; sta...@dpdk.org > Subject: RE: [EXT] [dpdk-dev] [PATCH] crypto/mlx5: support timestamp > format > > External email: Use caution opening links or

Re: [dpdk-dev] [RFC] devbind: conform to PEP 8 recommended style

2021-09-02 Thread Bruce Richardson
On Thu, Sep 02, 2021 at 08:24:58AM -0700, Stephen Hemminger wrote: > On Thu, 2 Sep 2021 09:10:47 +0100 > Bruce Richardson wrote: > > > On Wed, Sep 01, 2021 at 02:27:07PM -0700, Stephen Hemminger wrote: > > > This fixes most of the warnings from the Flake8 style checker. > > > The ones remaing are

[dpdk-dev] [PATCH v7] vhost: fix crash on port deletion

2021-09-02 Thread Gaoxiang Liu
The rte_vhost_driver_unregister() and vhost_user_read_cb() can be called at the same time by 2 threads. when memory of vsocket is freed in rte_vhost_driver_unregister(), the invalid memory of vsocket is accessed in vhost_user_read_cb(). It's a bug of both mode for vhost as server or client. E.g.,

Re: [dpdk-dev] [PATCH v6] vhost: fix crash on port deletion

2021-09-02 Thread Gaoxiang Liu
Hi chenbo, why this is not moved up? >> +if (vsocket->is_server) { >> +close(vsocket->socket_fd); >> +unlink(path); >> } ==>Because if this is moved up, and if deleting conn fd from fdsets failed, it will arrive the "again" label,

Re: [dpdk-dev] [RFC] devbind: conform to PEP 8 recommended style

2021-09-02 Thread Stephen Hemminger
On Thu, 2 Sep 2021 09:10:47 +0100 Bruce Richardson wrote: > On Wed, Sep 01, 2021 at 02:27:07PM -0700, Stephen Hemminger wrote: > > This fixes most of the warnings from the Flake8 style checker. > > The ones remaing are long lines (we allow > 79 characters) > > and a line break warning. The line

Re: [dpdk-dev] [PATCH] eal: make rte_lcore_cpuset and rte_lcore_to_cpu_id stable

2021-09-02 Thread Stephen Hemminger
On Thu, 2 Sep 2021 09:01:58 +0300 Andrew Rybchenko wrote: > On 9/1/21 8:16 PM, Stephen Hemminger wrote: > > > >>> /** > >>> - * @warning > >>> - * @b EXPERIMENTAL: this API may change without prior notice. > >>> - * > >>> * Return the cpuset for a given lcore. > >>> * @param lcore_id > >>

Re: [dpdk-dev] [RFC PATCH v1 0/5] add new API for wait until scheme

2021-09-02 Thread Stephen Hemminger
On Thu, 2 Sep 2021 13:32:48 +0800 Feifei Wang wrote: > Add new API for wait_until scheme, and apply this new API into lib to > replace rte_pause. > > Feifei Wang (5): > eal: add new API for wait until scheme > eal: use wait until scheme for read pflock > eal: use wait until scheme for mcs

Re: [dpdk-dev] [PATCH] build: add meson option of "max_memseg_lists" and "mbuf_refcnt_atomic"

2021-09-02 Thread Bruce Richardson
On Thu, Sep 02, 2021 at 10:48:05PM +0800, Kefu Chai wrote: > RTE_MAX_MEMSEG_LISTS = 128 is not enough for some use cases, so add an > option so user can override it. How big a value do you need? Can you share anything about the use-case where you are hitting this limit? > RTE_MBUF_REFCNT_ATOMIC =

Re: [dpdk-dev] [PATCH 1/5] ethdev: add API to negotiate support for Rx meta information

2021-09-02 Thread Jerin Jacob
On Thu, Sep 2, 2021 at 7:54 PM Ivan Malov wrote: > > Per-packet meta information (flag, mark and the likes) might > be expensive to deliver in terms of small packet performance. > If the features are not enabled by default, enabling them at > short notice (for example, when a flow rule with action

Re: [dpdk-dev] [PATCH v5 0/5] eal: enable global device syntax by default

2021-09-02 Thread Thomas Monjalon
14/04/2021 21:49, Thomas Monjalon: > 13/04/2021 05:14, Xueming Li: > > Xueming Li (5): > > devargs: unify scratch buffer storage > > devargs: fix memory leak on parsing error > > kvargs: add get by key function > > bus: add device arguments name parsing API > > devargs: parse global devic

Re: [dpdk-dev] [PATCH] net/ice: fix representor port segmentation fault

2021-09-02 Thread Wang, Haiyue
> -Original Message- > From: Yu, DapengX > Sent: Thursday, September 2, 2021 17:44 > To: Yang, Qiming ; Zhang, Qi Z > Cc: dev@dpdk.org; Wang, Haiyue ; Yu, DapengX > ; > sta...@dpdk.org > Subject: [PATCH] net/ice: fix representor port segmentation fault > > From: Dapeng Yu > > If DCF r

[dpdk-dev] [PATCH v3 8/8] event/cnxk: add cn10k crypto adapter fast path ops

2021-09-02 Thread Shijith Thotton
Set crypto adapter enqueue and dequeue operations for CN10K. Signed-off-by: Shijith Thotton --- doc/guides/rel_notes/release_21_11.rst | 3 ++ drivers/event/cnxk/cn10k_eventdev.c | 45 +++- drivers/event/cnxk/cn10k_worker.c| 11 drivers/event/cnxk/cn10k_worker.h

[dpdk-dev] [PATCH v3 7/8] crypto/cnxk: add cn10k crypto adapter fast path ops

2021-09-02 Thread Shijith Thotton
Added crypto adapter enqueue and dequeue operations for CN10K. Signed-off-by: Shijith Thotton Acked-by: Ray Kinsella Acked-by: Anoob Joseph --- drivers/crypto/cnxk/cn10k_cryptodev_ops.c | 95 +++ drivers/crypto/cnxk/cn10k_cryptodev_ops.h | 6 ++ drivers/crypto/cnxk/version

[dpdk-dev] [PATCH v3 6/8] event/cnxk: add cn9k crypto adapter fast path ops

2021-09-02 Thread Shijith Thotton
Set crypto adapter enqueue and dequeue operations for CN9K. Signed-off-by: Shijith Thotton --- drivers/event/cnxk/cn9k_eventdev.c | 94 +++- drivers/event/cnxk/cn9k_worker.c | 22 + drivers/event/cnxk/cn9k_worker.h | 41 - drivers/eve

[dpdk-dev] [PATCH v3 5/8] crypto/cnxk: add cn9k crypto adapter fast path ops

2021-09-02 Thread Shijith Thotton
Added crypto adapter enqueue and dequeue operations for CN9K. Signed-off-by: Shijith Thotton Acked-by: Ray Kinsella Acked-by: Anoob Joseph --- drivers/crypto/cnxk/cn9k_cryptodev_ops.c | 235 --- drivers/crypto/cnxk/cn9k_cryptodev_ops.h | 6 + drivers/crypto/cnxk/cnxk_cryp

[dpdk-dev] [PATCH v3 4/8] drivers: add cnxk crypto adapter eventdev ops

2021-09-02 Thread Shijith Thotton
Added eventdev ops required to initialize crypto adapter. Signed-off-by: Shijith Thotton --- drivers/crypto/cnxk/cnxk_cryptodev_ops.h | 9 +++ drivers/event/cnxk/cn10k_eventdev.c | 46 drivers/event/cnxk/cn9k_eventdev.c | 45 drivers/event/cnxk/cnxk_eventdev

[dpdk-dev] [PATCH v3 3/8] common/cnxk: add API to check CPT IQ is full

2021-09-02 Thread Shijith Thotton
Added flow control based check to determine CPT IQ is full. Signed-off-by: Shijith Thotton --- drivers/common/cnxk/roc_cpt.c | 6 -- drivers/common/cnxk/roc_cpt.h | 11 +++ drivers/common/cnxk/roc_cpt_priv.h | 6 -- 3 files changed, 15 insertions(+), 8 deletions(-) d

[dpdk-dev] [PATCH v3 2/8] event/cnxk: add macro to set eventdev ops

2021-09-02 Thread Shijith Thotton
Added a common macro to set eventdev enqueue and dequeue operations to reduce code. Signed-off-by: Shijith Thotton Signed-off-by: Nithin Dabilpuram --- drivers/event/cnxk/cn10k_eventdev.c | 134 +- drivers/event/cnxk/cn9k_eventdev.c | 268 +++- 2 files chang

[dpdk-dev] [PATCH v3 1/8] net/cnxk: add flag to show CPT can enqueue events

2021-09-02 Thread Shijith Thotton
CPT can be told to submit events to SSO upon completion. Crypto adapter uses this feature and the new flag can be used to optimize receive path in those cases. Signed-off-by: Shijith Thotton --- drivers/net/cnxk/cn10k_rx.h | 5 +++-- drivers/net/cnxk/cn9k_rx.h | 3 ++- 2 files changed, 5 insert

[dpdk-dev] [PATCH v3 0/8] Crypto adapter support for Marvell CNXK driver

2021-09-02 Thread Shijith Thotton
First three patches are to support crypto adapter implementation and the remaining patches add event crypto adapter OP_FORWARD mode support on Marvell CN9K and CN10K SOC. v3: * Fixed checkpatch errors. v2: * Fixed checkpatch errors. Shijith Thotton (8): net/cnxk: add flag to show CPT can enque

[dpdk-dev] [PATCH] net/virtio: fix device configure without jumbo Rx offload

2021-09-02 Thread Andrew Rybchenko
From: Ivan Ilchenko Use max-pkt-len only if jumbo frames offload is requested since otherwise this field isn't valid. Fixes: 8b90e4358112 ("net/virtio: set offload flag for jumbo frames") Fixes: 4e8169eb0d2d ("net/virtio: fix Rx scatter offload") Cc: sta...@dpdk.org Signed-off-by: Ivan Ilchenko

[dpdk-dev] [PATCH 5/5] net/sfc: allow to discern user flag on EF100 native datapath

2021-09-02 Thread Ivan Malov
Read out user flag from Rx prefix and indicate it to callers. Signed-off-by: Ivan Malov Reviewed-by: Andrew Rybchenko --- drivers/net/sfc/sfc_ef100_rx.c | 18 ++ drivers/net/sfc/sfc_rx.c | 3 +++ 2 files changed, 21 insertions(+) diff --git a/drivers/net/sfc/sfc_ef100_rx

[dpdk-dev] [PATCH 4/5] common/sfc_efx/base: add RxQ flag to use Rx prefix user flag

2021-09-02 Thread Ivan Malov
Add an RxQ flag to request support for user flag field of Rx prefix. The feature is supported only on EF100 and EF10 ESSB. Signed-off-by: Ivan Malov Reviewed-by: Andrew Rybchenko --- drivers/common/sfc_efx/base/ef10_rx.c | 54 -- drivers/common/sfc_efx/base/efx.h |

[dpdk-dev] [PATCH 3/5] net/sfc: allow to use EF100 native datapath Rx mark in flows

2021-09-02 Thread Ivan Malov
As of now, reading out mark on EF100 native datapath is used only by MAE counter support for delivery of generation count values. Make the feature available to flow action MARK users. Signed-off-by: Ivan Malov Reviewed-by: Andrew Rybchenko --- drivers/net/sfc/sfc_ef100_rx.c | 1 + drivers/net/s

[dpdk-dev] [PATCH 2/5] net/sfc: provide API to negotiate supported Rx meta features

2021-09-02 Thread Ivan Malov
This is a preparation step. Later patches will make features FLAG and MARK on EF100 native Rx datapath available to users. Signed-off-by: Ivan Malov Reviewed-by: Andrew Rybchenko --- drivers/net/sfc/sfc.h| 2 ++ drivers/net/sfc/sfc_ethdev.c | 34 ++ driv

[dpdk-dev] [PATCH 1/5] ethdev: add API to negotiate support for Rx meta information

2021-09-02 Thread Ivan Malov
Per-packet meta information (flag, mark and the likes) might be expensive to deliver in terms of small packet performance. If the features are not enabled by default, enabling them at short notice (for example, when a flow rule with action MARK gets created) without traffic disruption may not be po

[dpdk-dev] [PATCH 0/5] A means to negotiate support for Rx meta information

2021-09-02 Thread Ivan Malov
Back in 2019, commit c5b2e78d1172 ("doc: announce ethdev API changes in offload flags") announced changes in DEV_RX_OFFLOAD namespace intending to add new flags, RSS_HASH and FLOW_MARK. Since then, only the former has been added. Currently, there's no way for the application to configure the eth

Re: [dpdk-dev] [PATCH v2 3/6] app/test: add basic dmadev copy tests

2021-09-02 Thread Bruce Richardson
On Thu, Sep 02, 2021 at 06:35:07PM +0530, Jerin Jacob wrote: > On Thu, Sep 2, 2021 at 5:13 PM Bruce Richardson > wrote: > > > > On Thu, Sep 02, 2021 at 04:24:18PM +0530, Jerin Jacob wrote: > > > > > > I think 25us will not be enough, e.s.p If is PCI-Dev to PCI-Dev kind > > > of test cases. > > > S

Re: [dpdk-dev] [PATCH v2 1/6] dmadev: add device idle check for testing use

2021-09-02 Thread Bruce Richardson
On Thu, Sep 02, 2021 at 08:54:11PM +0800, fengchengwen wrote: > When some hardware is faulty, the error code cannot be set, and it just stops > working. > In addition, interrupts are generally not enabled. Therefore, for such > hardware, the > framework needs to have a mechanism to transmit the s

Re: [dpdk-dev] [PATCH v19 7/7] app/test: add dmadev API test

2021-09-02 Thread Walsh, Conor
Hi Chengwen, The output from the API tests is not very straightforward to interpret if you are not familiar with these tests. Could we change the log level of the dmadev library before and after the API tests using something similar to The code I have included inline below? > +static int > +te

Re: [dpdk-dev] [EXT] [PATCH v2 01/11] crypto/dpaa2_sec: fix to check next null for auth only case

2021-09-02 Thread Hemant Agrawal
On 9/2/2021 6:16 PM, Akhil Goyal wrote: This patch fixes the issue to check for next pointer as null in the integrity only case in pdcp-security context. Fixes: bef594ec5cc8 ("crypto/dpaa2_sec: support PDCP offload") Cc: sta...@dpdk.org This patch is not a fix and need not be backported, beca

Re: [dpdk-dev] [EXT] [PATCH v2 05/11] crypto/dpaa_sec: add support for AES CMAC integrity check

2021-09-02 Thread Akhil Goyal
> From: Gagandeep Singh > > This patch adds support for AES_CMAC integrity in non-security mode. > This patch modifies the camm flib to handles the AES CMAC > without conflicting the proto ALG operations. i.e. by creating > another ALG operation routine. Description do not match with the patch.

[dpdk-dev] [PATCH 8/8] crypto/cnxk: update feature flag for cn9k lookaside IPsec

2021-09-02 Thread Archana Muniganti
Update device feature flag to support lookaside IPsec for cn9k. Signed-off-by: Ankur Dwivedi Signed-off-by: Archana Muniganti Signed-off-by: Tejasree Kondoj Signed-off-by: Vamsi Attunuru --- doc/guides/cryptodevs/cnxk.rst | 14 -- doc/guides/cryptodevs/features/cn9k.ini |

[dpdk-dev] [PATCH 7/8] crypto/cnxk: update tailroom requirement

2021-09-02 Thread Archana Muniganti
Update min tailroom to reflect IPsec additions. PMD crypto_cn9k & crypto_cn10k would have packet grow into tailroom post IPsec processing. Signed-off-by: Archana Muniganti --- drivers/crypto/cnxk/cnxk_cryptodev_ops.c | 2 +- drivers/crypto/cnxk/cnxk_cryptodev_ops.h | 1 + 2 files changed, 2 inse

[dpdk-dev] [PATCH 6/8] crypto/cnxk: add cn9k lookaside IPsec datapath

2021-09-02 Thread Archana Muniganti
Adds support for cn9k lookaside enqueue and dequeue operations. Signed-off-by: Archana Muniganti Signed-off-by: Tejasree Kondoj Signed-off-by: Vamsi Attunuru --- drivers/crypto/cnxk/cn9k_cryptodev_ops.c | 78 +++- drivers/crypto/cnxk/cn9k_ipsec_la_ops.h | 90 ++

[dpdk-dev] [PATCH 5/8] crypto/cnxk: add cn9k IPsec inbound session create function

2021-09-02 Thread Archana Muniganti
Adding logic for IPsec inbound session creation. Signed-off-by: Ankur Dwivedi Signed-off-by: Archana Muniganti Signed-off-by: Tejasree Kondoj Signed-off-by: Vamsi Attunuru --- drivers/crypto/cnxk/cn9k_ipsec.c | 64 +--- 1 file changed, 59 insertions(+), 5 deletions

[dpdk-dev] [PATCH 4/8] crypto/cnxk: add cn9k IPsec outbound session create function

2021-09-02 Thread Archana Muniganti
Adding logic for IPsec outbound session creation. Signed-off-by: Ankur Dwivedi Signed-off-by: Archana Muniganti Signed-off-by: Tejasree Kondoj Signed-off-by: Vamsi Attunuru --- drivers/crypto/cnxk/cn9k_ipsec.c | 143 +-- drivers/crypto/cnxk/cn9k_ipsec.h | 17

[dpdk-dev] [PATCH 3/8] crypto/cnxk: add cn9k IPsec session related functions

2021-09-02 Thread Archana Muniganti
Add helper functions useful in implementing IPsec outbound and inbound session create apis. Signed-off-by: Archana Muniganti Signed-off-by: Tejasree Kondoj Signed-off-by: Vamsi Attunuru --- drivers/crypto/cnxk/cn9k_cryptodev.c | 2 + drivers/crypto/cnxk/cn9k_ipsec.c | 425 +++

[dpdk-dev] [PATCH 2/8] common/cnxk: add cn9k IPsec microcode defines

2021-09-02 Thread Archana Muniganti
Microcode IE opcodes support IPsec operations. Add defines and structs defined by microcode. Signed-off-by: Ankur Dwivedi Signed-off-by: Archana Muniganti Signed-off-by: Tejasree Kondoj Signed-off-by: Vamsi Attunuru --- drivers/common/cnxk/roc_cpt.h | 1 + drivers/common/cnxk/roc_ie_on.h

[dpdk-dev] [PATCH 1/8] crypto/cnxk: add cn9k security ctx

2021-09-02 Thread Archana Muniganti
Add security ctx in cn9k crypto PMD. Signed-off-by: Archana Muniganti Signed-off-by: Vamsi Attunuru Signed-off-by: Tejasree Kondoj --- drivers/crypto/cnxk/cn9k_cryptodev.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/crypto/cnxk/cn9k_cryptodev.c b/drivers/crypto/cnxk/c

[dpdk-dev] [PATCH 0/8] add cn9k lookaside IPsec support

2021-09-02 Thread Archana Muniganti
This series adds lookaside IPsec support in crypto_cn9k PMD. Depends on: http://patches.dpdk.org/project/dpdk/list/?series=18628 Archana Muniganti (8): crypto/cnxk: add cn9k security ctx common/cnxk: add cn9k IPsec microcode defines crypto/cnxk: add cn9k IPsec session related functions cr

Re: [dpdk-dev] [PATCH v18 8/8] maintainers: add for dmadev

2021-09-02 Thread fengchengwen
Fix in v19 I think there many patches wait for dmadev framework upstream, so could you help review unreviewd patches (like dma/skeleton and app/test)? Also, we have developed the dma driver for hisilicon, and corresponding test app (like examples/vhost and testpmd) is being developed. examples/v

[dpdk-dev] [PATCH v19 6/7] dma/skeleton: introduce skeleton dmadev driver

2021-09-02 Thread Chengwen Feng
Skeleton dmadevice driver, on the lines of rawdev skeleton, is for showcasing of the dmadev library. Design of skeleton involves a virtual device which is plugged into VDEV bus on initialization. Also, enable compilation of dmadev skeleton drivers. Signed-off-by: Chengwen Feng --- MAINTAINERS

[dpdk-dev] [PATCH v19 5/7] doc: add DMA device library guide

2021-09-02 Thread Chengwen Feng
This patch adds dmadev library guide. Signed-off-by: Chengwen Feng Acked-by: Conor Walsh --- MAINTAINERS | 1 + doc/guides/prog_guide/dmadev.rst | 125 doc/guides/prog_guide/img/dmadev.svg | 283 +++ doc/guides/prog

[dpdk-dev] [PATCH v19 7/7] app/test: add dmadev API test

2021-09-02 Thread Chengwen Feng
This patch add dmadev API test which based on 'dma_skeleton' vdev. The test cases could be executed using 'dmadev_autotest' command in test framework. Signed-off-by: Chengwen Feng Signed-off-by: Bruce Richardson --- MAINTAINERS| 1 + app/test/meson.build | 4 + app/tes

[dpdk-dev] [PATCH v19 1/7] dmadev: introduce DMA device library public APIs

2021-09-02 Thread Chengwen Feng
The 'dmadevice' is a generic type of DMA device. This patch introduce the 'dmadevice' public APIs which expose generic operations that can enable configuration and I/O with the DMA devices. Maintainers update is also included in this patch. Signed-off-by: Chengwen Feng Acked-by: Bruce Richardso

[dpdk-dev] [PATCH v19 4/7] dmadev: introduce DMA device library implementation

2021-09-02 Thread Chengwen Feng
This patch introduce DMA device library implementation which includes configuration and I/O with the DMA devices. Signed-off-by: Chengwen Feng Acked-by: Bruce Richardson Acked-by: Morten Brørup --- config/rte_config.h | 3 + lib/dmadev/meson.build | 1 + lib/dmadev/rte_dmade

[dpdk-dev] [PATCH v19 2/7] dmadev: introduce DMA device library internal header

2021-09-02 Thread Chengwen Feng
This patch introduce DMA device library internal header, which contains internal data types that are used by the DMA devices in order to expose their ops to the class. Signed-off-by: Chengwen Feng Acked-by: Bruce Richardson Acked-by: Morten Brørup --- lib/dmadev/meson.build | 1 + lib/

[dpdk-dev] [PATCH v19 3/7] dmadev: introduce DMA device library PMD header

2021-09-02 Thread Chengwen Feng
This patch introduce DMA device library PMD header which was driver facing APIs for a DMA device. Signed-off-by: Chengwen Feng Acked-by: Bruce Richardson Acked-by: Morten Brørup --- lib/dmadev/meson.build | 1 + lib/dmadev/rte_dmadev.h | 2 ++ lib/dmadev/rte_dmadev_pmd.h | 72 ++

[dpdk-dev] [PATCH v19 0/7] support dmadev

2021-09-02 Thread Chengwen Feng
This patch set contains seven patch for new add dmadev. Chengwen Feng (7): dmadev: introduce DMA device library public APIs dmadev: introduce DMA device library internal header dmadev: introduce DMA device library PMD header dmadev: introduce DMA device library implementation doc: add DM

  1   2   >