Re: [dpdk-dev] [PATCH] net/bnxt: fix seg fault on Thor

2021-07-30 Thread Ajit Khaparde
On Fri, Jul 30, 2021 at 2:15 PM Ajit Khaparde wrote: > > In a few cases with Thor device, PMD can segfault when VF > representors are specified. Temporarily fix it by preventing > VF reps for Thor device. This will be addressed in next release. > > Fixes: 3fe124d2536c ("net/bnxt: support Thor plat

[dpdk-dev] [PATCH] net/bnxt: fix seg fault on Thor

2021-07-30 Thread Ajit Khaparde
In a few cases with Thor device, PMD can segfault when VF representors are specified. Temporarily fix it by preventing VF reps for Thor device. This will be addressed in next release. Fixes: 3fe124d2536c ("net/bnxt: support Thor platform") Cc: sta...@dpdk.org Signed-off-by: Ajit Khaparde --- dr

[dpdk-dev] [PATCH v11 10/10] Add unit tests for thread API

2021-07-30 Thread Narcisa Ana Maria Vasile
From: Narcisa Vasile As a new API for threading is introduced, a set of unit tests have been added to test the new interface. Signed-off-by: Narcisa Vasile --- app/test/meson.build| 2 + app/test/test_threads.c | 419 2 files changed, 421 insertio

[dpdk-dev] [PATCH v11 09/10] eal: add EAL argument for setting thread priority

2021-07-30 Thread Narcisa Ana Maria Vasile
From: Narcisa Vasile Allow the user to choose the thread priority through an EAL command line argument. The user can choose thread priority through an EAL parameter, when starting an application. If EAL parameter is not used, the per-platform default value for thread priority is used. Otherwise

[dpdk-dev] [PATCH v11 06/10] eal: add thread lifetime management

2021-07-30 Thread Narcisa Ana Maria Vasile
From: Narcisa Vasile Add functions for thread creation, joining, detaching. The *rte_thread_create()* function can optionally receive an rte_thread_attr_t object that will cause the thread to be created with the affinity and priority described by the attributes object. If no rte_thread_attr_t is

[dpdk-dev] [PATCH v11 08/10] eal: implement functions for thread barrier management

2021-07-30 Thread Narcisa Ana Maria Vasile
From: Narcisa Vasile Add functions for barrier init, destroy, wait. A portable type is used to represent a barrier identifier. The rte_thread_barrier_wait() function returns the same value on all platforms. Signed-off-by: Narcisa Vasile --- lib/eal/common/rte_thread.c | 61 ++

[dpdk-dev] [PATCH v11 07/10] eal: implement functions for mutex management

2021-07-30 Thread Narcisa Ana Maria Vasile
From: Narcisa Vasile Add functions for mutex init, destroy, lock, unlock. Add RTE_STATIC_MUTEX macro to replace static initialization of mutexes. Windows does not have a static initializer. Initialization is only done through InitializeCriticalSection(). The RTE_STATIC_MUTEX calls into the rte_

[dpdk-dev] [PATCH v11 04/10] eal: implement functions for thread affinity management

2021-07-30 Thread Narcisa Ana Maria Vasile
From: Narcisa Vasile Implement functions for getting/setting thread affinity. Threads can be pinned to specific cores by setting their affinity attribute. Signed-off-by: Narcisa Vasile Signed-off-by: Dmitry Malloy --- lib/eal/common/rte_thread.c | 16 lib/eal/include/rte_thread.h |

[dpdk-dev] [PATCH v11 05/10] eal: implement thread priority management functions

2021-07-30 Thread Narcisa Ana Maria Vasile
From: Narcisa Vasile Add function for setting the priority for a thread. Priorities on multiple platforms are similarly determined by a priority value and a priority class/policy. On Linux, the following mapping is created: RTE_THREAD_PRIORITY_NORMAL corresponds to * policy SCHED_OTHER * priorit

[dpdk-dev] [PATCH v11 03/10] eal/windows: translate Windows errors to errno-style errors

2021-07-30 Thread Narcisa Ana Maria Vasile
From: Narcisa Vasile Add function to translate Windows error codes to errno-style error codes. The possible return values are chosen so that we have as much semantical compatibility between platforms as possible. Signed-off-by: Narcisa Vasile --- lib/eal/common/rte_thread.c | 6 +-- lib/eal/

[dpdk-dev] [PATCH v11 02/10] eal: add thread attributes

2021-07-30 Thread Narcisa Ana Maria Vasile
From: Narcisa Vasile Implement thread attributes for: * thread affinity * thread priority Implement functions for managing thread attributes. Priority is represented through an enum that allows for two levels: - RTE_THREAD_PRIORITY_NORMAL - RTE_THREAD_PRIORITY_REALTIME_CRITICAL

[dpdk-dev] [PATCH v11 01/10] eal: add basic threading functions

2021-07-30 Thread Narcisa Ana Maria Vasile
From: Narcisa Vasile Use a portable, type-safe representation for the thread identifier. Add functions for comparing thread ids and obtaining the thread id for the current thread. Signed-off-by: Narcisa Vasile --- lib/eal/common/meson.build| 1 + lib/eal/{unix => common}/rte_threa

[dpdk-dev] [PATCH v11 00/10] eal: Add EAL API for threading

2021-07-30 Thread Narcisa Ana Maria Vasile
From: Narcisa Vasile EAL thread API **Problem Statement** DPDK currently uses the pthread interface to create and manage threads. Windows does not support the POSIX thread programming model, so it currently relies on a header file that hides the Windows calls under pthread matched interfaces. Gi

Re: [dpdk-dev] [PATCH] doc: announce security API changes for Inline IPsec

2021-07-30 Thread Thomas Monjalon
27/07/2021 19:36, Nithin Dabilpuram: > Announce changes to make rte_security_set_pkt_metadata() and > rte_security_get_userdata() inline instead of C functions and > also addition of another field in structure rte_security_ctx for > holding flags. I guess there is a performance reason but the moti

Re: [dpdk-dev] [PATCH v3 0/8] use compiler atomic builtins for test

2021-07-30 Thread Thomas Monjalon
> Joyce Kong (8): > test/ticketlock: use compiler atomics for lcores sync > test/spinlock: use compile atomics for lcores sync > test/rwlock: use compiler atomics for lcores sync > test/mcslock: use compiler atomics for lcores sync > test/mempool: remove unused variable for lcores sync >

[dpdk-dev] [PATCH] doc: abstract the behaviour of rte_ctrl_thread_create

2021-07-30 Thread Honnappa Nagarahalli
The current expected behaviour of the function rte_ctrl_thread_create is rigid which makes the implementation of the function complex. Make the expected behaviour abstract to allow for simplified implementation. With this change, the calls to pthread_setaffinity_np can be moved to the control thre

[dpdk-dev] [RFC] eal: simplify the implementation of rte_ctrl_thread_create

2021-07-30 Thread Honnappa Nagarahalli
The current described behaviour of rte_ctrl_thread_create is rigid which makes the implementation of the function complex. The behavior is abstracted to allow for simplified implementation. Signed-off-by: Honnappa Nagarahalli --- lib/eal/common/eal_common_thread.c | 65 +-

[dpdk-dev] [PATCH] doc: announce the deprecation of lcore state FINISHED

2021-07-30 Thread Honnappa Nagarahalli
Lcore state FINISHED is used by the worker thread to indicate that it has completed the assigned task. The state is changed to WAIT by another thread after it observes the updated state. This additional step is redundant. After this deprecation, the worker thread will update the state to WAIT. Sig

Re: [dpdk-dev] [PATCH] crypto/octeontx: fix heap use after free

2021-07-30 Thread Akhil Goyal
> Subject: [PATCH] crypto/octeontx: fix heap use after free > > When the PMD is removed, rte_cryptodev_pmd_release_device > is called which frees cryptodev->data, and then tries to free > cryptodev->data->dev_private, which causes the heap use > after free issue. > > A temporary pointer is set be

Re: [dpdk-dev] [EXT] [PATCH] crypto/mlx5: fix driver probing error flow

2021-07-30 Thread Akhil Goyal
> In crypto driver probing, there are two validations after context > allocation. > > When one of them fails, the context structure was not freed what caused > a memory leak. > > Free it. > > Fixes: debb27ea3442 ("crypto/mlx5: create login object using DevX") > Fixes: e8db4413cba5 ("crypto/mlx5:

Re: [dpdk-dev] [EXT] [PATCH 2/2] crypto/qat: fix asymmetric crypto pmd create on gen3

2021-07-30 Thread Akhil Goyal
> This patch disables asymmetric crypto pmd on gen3 devices. > > Fixes: 1f5e4053f9b4 ("common/qat: support GEN3 devices") Cc: sta...@dpdk.org > > Signed-off-by: Arek Kusztal > --- > drivers/crypto/qat/qat_asym_pmd.c | 4 > 1 file changed, 4 insertions(+) > > diff --git a/drivers/crypto/

Re: [dpdk-dev] [EXT] [PATCH 1/2] drivers/qat: fix wrong return value for invalid service

2021-07-30 Thread Akhil Goyal
> Subject: [EXT] [PATCH 1/2] drivers/qat: fix wrong return value for invalid > service > Title changed as " drivers: fix return value for QAT PMDs " Please check ./devtools/check-git-log.sh before sending patch. > Fix invalid value that is returned when asymmetric crypto > or compression service

Re: [dpdk-dev] [EXT] [PATCH v2] examples/l2fwd-crypto: support cipher multiple data-unit

2021-07-30 Thread Akhil Goyal
> The support for multiple data-units includes the next: > - Add a new command-line argument to provide the data-unit length. > - Set the length in the cipher xform. > - Validate device capabilities for this feature. > - Pad the AES-XTS operation length to be aligned to the defined data-unit. > >

Re: [dpdk-dev] [EXT] [PATCH] crypto: fix heap use after free bug

2021-07-30 Thread Akhil Goyal
> Fixed title > Cryptodev: fix heap use after free > > > The PMD destroy function was calling the release function, which frees > > > cryptodev->data, and then tries to free cryptodev->data->dev_private, > > > which causes the heap use after free issue. > > > > > > A temporary pointer is set before

Re: [dpdk-dev] [EXT] [PATCH] crypto: fix heap use after free bug

2021-07-30 Thread Akhil Goyal
Fixed title Cryptodev: fix heap use after free > > The PMD destroy function was calling the release function, which frees > > cryptodev->data, and then tries to free cryptodev->data->dev_private, > > which causes the heap use after free issue. > > > > A temporary pointer is set before the free of c

Re: [dpdk-dev] [PATCH] doc: announce security API changes for Inline IPsec

2021-07-30 Thread Akhil Goyal
> Announce changes to make rte_security_set_pkt_metadata() and > rte_security_get_userdata() inline instead of C functions and > also addition of another field in structure rte_security_ctx for > holding flags. > > Signed-off-by: Nithin Dabilpuram > Acked-by: Akhil Goyal > --- Applied to dpdk-ne

Re: [dpdk-dev] [dpdk-announce] release candidate 21.08-rc2

2021-07-30 Thread Thinh Tran
Hi all, IBM - DPDK on Power Systems * Basic PF on Mellanox: No new issues or regressions were seen. * Performance: not tested. Systems tested: - IBM Power9 PowerNV 9006-22P OS: RHEL 8.3 GCC: version 8.3.1 20191121 (Red Hat 8.3.1-5) NICs: - Mellanox Technologies MT28800 Family

[dpdk-dev] [PATCH] crypto/octeontx: fix heap use after free

2021-07-30 Thread Akhil Goyal
When the PMD is removed, rte_cryptodev_pmd_release_device is called which frees cryptodev->data, and then tries to free cryptodev->data->dev_private, which causes the heap use after free issue. A temporary pointer is set before the free of cryptodev->data, which can then be used afterwards to free

Re: [dpdk-dev] [PATCH 0/2] fixes to bnxt PMD

2021-07-30 Thread Ajit Khaparde
On Thu, Jul 29, 2021 at 10:36 PM Ajit Khaparde wrote: > > Fixes to bnxt PMD to address compatibility issues with different FW versions. Patches applied to dpdk-next-net-brcm. > > Jay Ding (1): > net/bnxt: fix resource qcap list handling > > Kishore Padmanabha (1): > net/bnxt: fix stats counte

Re: [dpdk-dev] [PATCH] examples/l3fwd: change mq-mode on single queue devices

2021-07-30 Thread Thomas Monjalon
13/05/2021 11:59, Bruce Richardson: > On Wed, May 12, 2021 at 09:43:57PM +0300, Medvedkin, Vladimir wrote: > > Hi Bruce, > > > > On 12/05/2021 19:32, Bruce Richardson wrote: > > > On Mon, May 10, 2021 at 06:53:19PM +0200, Heinrich Kuhn wrote: > > > > From: "Chaoyong.He" > > > > > > > > Set the R

Re: [dpdk-dev] [PATCH v3] app/procinfo: add device registers dump

2021-07-30 Thread Thomas Monjalon
29/07/2021 16:14, Pattan, Reshma: > > > Signed-off-by: Chengchang Tang > > Signed-off-by: Min Hu (Connor) > > Acked-by: Reshma Pattan Applied, thanks.

Re: [dpdk-dev] [PATCH] eal/windows: cleanup virt2phys handle

2021-07-30 Thread Thomas Monjalon
27/07/2021 07:43, Menon, Ranjit: > On 7/26/2021 2:36 PM, Dmitry Kozlyuk wrote: > > eal_mem_virt2phys_init() opens a handle for use by rte_mem_virt2phy(). > > Close this handle on EAL cleanup. > > > > Fixes: 2a5d547a4a9b ("eal/windows: implement basic memory management") > > Cc: sta...@dpdk.org > >

Re: [dpdk-dev] [PATCH v2 0/2] app/acl: help to automate testing

2021-07-30 Thread Thomas Monjalon
26/07/2021 13:51, Konstantin Ananyev: > The purpose of this series is to help automate ACL library functional > testing using test-acl app. > First patch adds into test-acl ability to skip comment/empty lines. > Second patch adds script for automate testing. > Sample input files are also provided.

Re: [dpdk-dev] [dpdk-stable] [PATCH v4] bus: clarify log for non-NUMA-aware devices

2021-07-30 Thread Thomas Monjalon
29/07/2021 00:06, Dmitry Kozlyuk: > EAL: PCI device :00:06.0 on NUMA socket -1 > - EAL: Invalid NUMA socket, default to 0 > + EAL: Device is not NUMA-aware, defaulting socket to 0 > EAL: probe driver: 1d0f:ec20 net_ena The indentation in logs are wrong because they are not al

[dpdk-dev] [PATCH 2/2] common/cnxk: update npc mcam range for 98xx

2021-07-30 Thread Harman Kalra
NPC mcam entry distribution is based on maximum number of PFs and LFs available. Fixing the max no of PFs and LFs available on 98xx to fix the mcam alloc entry range. Signed-off-by: Harman Kalra --- drivers/common/cnxk/roc_npc.c | 2 ++ drivers/common/cnxk/roc_npc_priv.h | 6 ++ 2 files

[dpdk-dev] [PATCH 1/2] common/cnxk: setup nix and lbk in loop mode in 98xx

2021-07-30 Thread Harman Kalra
In case of 98xx, 2 NIX blocks and 4 LBK blocks are present. Moreover AF VFs are alternatively attached to NIX0 and NIX1 to ensure load balancing. To support loopback functionality between pairs NIX0/NIX1 are attached to LBK1/LBK2 for transmission/reception respectively. But in this default configur

[dpdk-dev] [PATCH 2/2] net/cnxk: callback for getting link status

2021-07-30 Thread Harman Kalra
Adding a new callback for reading the link status. PF can read it's link status and can forward the same to VF once it comes up. Signed-off-by: Harman Kalra --- drivers/net/cnxk/cnxk_ethdev.c | 9 + drivers/net/cnxk/cnxk_ethdev.h | 2 ++ drivers/net/cnxk/cnxk_link.c | 23

[dpdk-dev] [PATCH 1/2] common/cnxk: send link event to VF

2021-07-30 Thread Harman Kalra
Currently link event is only sent to the PF by AF as soon as it comes up, or in case of any physical change in link. PF will broadcast these link events to all its VFs as soon as it receives it. But no event is sent when a new VF comes up, hence it will not have the link status. Adding support for

[dpdk-dev] [PATCH] common/octeontx2: fix link event message size

2021-07-30 Thread Harman Kalra
Due to wrong size of mbox message allocated for sending link status to the VF, incorrect link status is observed. Fixes: cb8d769fb6fe ("common/octeontx2: send link event to VF") Signed-off-by: Harman Kalra --- drivers/common/octeontx2/otx2_dev.c | 5 - 1 file changed, 4 insertions(+), 1 del

[dpdk-dev] [PATCH] doc: announce renaming of mbuf offload flags

2021-07-30 Thread Olivier Matz
The mbuf offload flags do not match the DPDK namespace (they are not prefixed by RTE_). Announce their rename in 21.11, and the removal of the old names in 22.11. A draft coccinelle script is provided to anticipate what the renaming will be. Signed-off-by: Olivier Matz --- .../cocci/prefix_mbuf

Re: [dpdk-dev] [dpdk-stable] [PATCH v4] mbuf: fix reset on mbuf free

2021-07-30 Thread Morten Brørup
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Olivier Matz > Sent: Friday, 30 July 2021 17.15 > > Hi, > > On Fri, Jul 30, 2021 at 04:54:05PM +0200, Thomas Monjalon wrote: > > 30/07/2021 16:35, Morten Brørup: > > > > From: Olivier Matz [mailto:olivier.m...@6wind.com] > > > > Sent: Friday,

Re: [dpdk-dev] [pull-request] dpdk-next-eventdev - v21.08-rc3

2021-07-30 Thread Thomas Monjalon
30/07/2021 13:02, Jerin Jacob Kollanukkaran: > http://dpdk.org/git/next/dpdk-next-eventdev Pulled, thanks.

Re: [dpdk-dev] [dpdk-stable] [PATCH v4] mbuf: fix reset on mbuf free

2021-07-30 Thread Olivier Matz
Hi, On Fri, Jul 30, 2021 at 04:54:05PM +0200, Thomas Monjalon wrote: > 30/07/2021 16:35, Morten Brørup: > > > From: Olivier Matz [mailto:olivier.m...@6wind.com] > > > Sent: Friday, 30 July 2021 14.37 > > > > > > Hi Thomas, > > > > > > On Sat, Jul 24, 2021 at 10:47:34AM +0200, Thomas Monjalon wro

Re: [dpdk-dev] [dpdk-stable] [PATCH v4] mbuf: fix reset on mbuf free

2021-07-30 Thread Thomas Monjalon
30/07/2021 16:35, Morten Brørup: > > From: Olivier Matz [mailto:olivier.m...@6wind.com] > > Sent: Friday, 30 July 2021 14.37 > > > > Hi Thomas, > > > > On Sat, Jul 24, 2021 at 10:47:34AM +0200, Thomas Monjalon wrote: > > > What's the follow-up for this patch? > > > > Unfortunatly, I still don't

[dpdk-dev] [PATCH] net/virtio: fix repeated memory free of vq

2021-07-30 Thread Gaoxiang Liu
When virtio_init_queue returns error, the memory of vq is freed. But the value of hw->vqs[queue_idx] does not restore.` If hw->vqs[queue_idx] != NULL, the memory of vq is freed again in virtio_free_queues. Fixes: 69c80d4ef89b ("net/virtio: allocate queue at init stage") Cc: sta...@dpdk.org Signed

Re: [dpdk-dev] [dpdk-stable] [PATCH v4] mbuf: fix reset on mbuf free

2021-07-30 Thread Morten Brørup
> From: Olivier Matz [mailto:olivier.m...@6wind.com] > Sent: Friday, 30 July 2021 14.37 > > Hi Thomas, > > On Sat, Jul 24, 2021 at 10:47:34AM +0200, Thomas Monjalon wrote: > > What's the follow-up for this patch? > > Unfortunatly, I still don't have the time to work on this topic yet. > > In my

[dpdk-dev] [RFC PATCH v2 7/7] hcdev: add communication list

2021-07-30 Thread Thomas Monjalon
From: Elena Agostini In heterogeneous computing system, processing is not only in the CPU. Some tasks can be delegated to devices working in parallel. When mixing network activity with task processing there may be the need to put in communication the CPU with the device in order to synchronize op

[dpdk-dev] [RFC PATCH v2 6/7] hcdev: add communication flag

2021-07-30 Thread Thomas Monjalon
From: Elena Agostini In heterogeneous computing system, processing is not only in the CPU. Some tasks can be delegated to devices working in parallel. When mixing network activity with task processing there may be the need to put in communication the CPU with the device in order to synchronize op

[dpdk-dev] [RFC PATCH v2 5/7] hcdev: add memory API

2021-07-30 Thread Thomas Monjalon
From: Elena Agostini In heterogeneous computing system, processing is not only in the CPU. Some tasks can be delegated to devices working in parallel. Such workload distribution can be achieved by sharing some memory. As a first step, the features are focused on memory management. A function all

[dpdk-dev] [RFC PATCH v2 4/7] hcdev: support multi-process

2021-07-30 Thread Thomas Monjalon
The device data shared between processes are moved in a struct allocated in a shared memory (a new memzone for all hcdevs). The main struct rte_hcdev references the shared memory via the pointer mpshared. The API function rte_hcdev_attach() is added to attach a device from the secondary process. T

[dpdk-dev] [RFC PATCH v2 3/7] hcdev: add child device representing a device context

2021-07-30 Thread Thomas Monjalon
The computing device may operate in some isolated contexts. Memory and processing are isolated in a silo represented by a child device. The context is provided as an opaque by the caller of rte_hcdev_add_child(). Signed-off-by: Thomas Monjalon --- lib/hcdev/hcdev.c| 45 ++

[dpdk-dev] [RFC PATCH v2 2/7] hcdev: add event notification

2021-07-30 Thread Thomas Monjalon
Callback functions may be registered for a device event. Callback management is per-process and not thread-safe. The events RTE_HCDEV_EVENT_NEW and RTE_HCDEV_EVENT_DEL are notified respectively after creation and before removal of a device, as part of the library functions. Some future events may

[dpdk-dev] [RFC PATCH v2 1/7] hcdev: introduce heterogeneous computing device library

2021-07-30 Thread Thomas Monjalon
From: Elena Agostini In heterogeneous computing system, processing is not only in the CPU. Some tasks can be delegated to devices working in parallel. The new library hcdev is for dealing with computing devices from a DPDK application running on the CPU. The infrastructure is prepared to welcom

[dpdk-dev] [RFC PATCH v2 0/7] heterogeneous computing library

2021-07-30 Thread Thomas Monjalon
From: Elena Agostini In heterogeneous computing system, processing is not only in the CPU. Some tasks can be delegated to devices working in parallel. The goal of this new library is to enhance the collaboration between DPDK, that's primarily a CPU framework, and other type of devices like GPUs.

Re: [dpdk-dev] [PATCH] doc: note KNI alternatives and deprecation plan

2021-07-30 Thread Olivier Matz
Hi Ferruh, Few minor comments below. On Wed, Jun 23, 2021 at 06:31:42PM +0100, Ferruh Yigit wrote: > Add a note that KNI kernel module will be moved to dpdk-kmods git repo > and there is a long term plan to deprecate it. > > Also add some more details on the alternatives to KNI and cons of the >

Re: [dpdk-dev] [dpdk-stable] [PATCH v4] mbuf: fix reset on mbuf free

2021-07-30 Thread Olivier Matz
Hi Thomas, On Sat, Jul 24, 2021 at 10:47:34AM +0200, Thomas Monjalon wrote: > What's the follow-up for this patch? Unfortunatly, I still don't have the time to work on this topic yet. In my initial tests, in our lab, I didn't notice any performance regression, but Ali has seen an impact (0.5M PP

Re: [dpdk-dev] [PATCH] app/testpmd: fix vm_hotplug after removal of rte_eth_devices

2021-07-30 Thread Thomas Monjalon
> > After removing rte_eth_devices from testpmd the vm_hotplug no longer > > recovered after removal of a device, this patch fixes this issue. > > > > Fixes: 0a0821bcf312 ("app/testpmd: remove most uses of internal ethdev > > array") > > > > Signed-off-by: Paulis Gributs > > --- > > app/test-p

Re: [dpdk-dev] [EXT] Re: [v1, 1/3] telemetry: enable storing pointer value

2021-07-30 Thread Gowrishankar Muthukrishnan
Hi Bruce, > I'm a little curious as to the usefulness of having a pointer value in > telemetry > output? How would a telemetry user be expected to use pointer information > returned? Printing pointers seems something more useful for a debugging or > tracing interface than a telemetry one. > Tha

Re: [dpdk-dev] [PATCH v4] app/testpmd: fix TX checksum calculation for tunnel

2021-07-30 Thread Thomas Monjalon
30/07/2021 10:39, Olivier Matz: > On Thu, Jul 29, 2021 at 08:01:41PM +0300, Gregory Etelson wrote: > > csumonly engine calculates TX checksum of a tunnelled packet for outer > > headers only or separately for outer and inner headers. The > > calculation method is determined by checksum configuratio

Re: [dpdk-dev] [PATCH v2] net/softnic: fix memory leak as profile is freed

2021-07-30 Thread Thomas Monjalon
28/07/2021 08:05, dapengx...@intel.com: > From: Dapeng Yu > > In function softnic_table_action_profile_free(), the memory referenced > by pointer "ap" in the instance of "struct softnic_table_action_profile" > is not freed. > > This patch fixes it. > > Fixes: a737dd4e5863 ("net/softnic: add tab

Re: [dpdk-dev] [PATCH] net/softnic: fix null pointer dereference

2021-07-30 Thread Thomas Monjalon
> > From: Dapeng Yu > > > > When there is no "firmware" in arguments, the "firmware" pointer is null, > > and will be dereferenced by rte_strscpy(). > > > > This patch moves the code block which copies character string from > > "firmware" to "p->firmware" into the "if" statements where "firmware

Re: [dpdk-dev] [PATCH v1] test/func_reentrancy: free memzones after creating test case

2021-07-30 Thread Olivier Matz
Hi Joyce, On Wed, Jul 28, 2021 at 02:33:22AM -0500, Joyce Kong wrote: > Function reentrancy test limits maximum number of iterations > simultaneously, however it doesn't free the 'fr_test_once' > memzones after the fact, so introduce freeing 'fr_test_once' > in ring/mempool/hash/fbk/lpm_clean. >

Re: [dpdk-dev] [PATCH v2] net/memif: fix abstract socket addr_len

2021-07-30 Thread Thomas Monjalon
> > This fixes using abstract sockets with memifs. > > we were not passing the exact addr_len, which requires zeroing the remaining > > sun_path and doesn't appear well in other utilities (e.g. > > lsof -U) > > > > Signed-off-by: Nathan Skrzypczak > > Looks ok to me. > > Reviewed-by: Jakub Graj

Re: [dpdk-dev] RFC: Enahancements to Rx adapter for DPDK 21.11

2021-07-30 Thread Jerin Jacob
On Wed, Jul 28, 2021 at 11:53 AM Kundapura, Ganapati wrote: > > Comments inlined Please fix your email client for adding proper > > > -Original Message- > From: Jerin Jacob > Sent: 28 July 2021 11:38 > To: Kundapura, Ganapati > Cc: dpdk-dev ; Jayatheerthan, Jay > Subject: Re: RFC: Ena

Re: [dpdk-dev] [PATCH] common/sfc_efx/base: do not validate MAE action COUNT order

2021-07-30 Thread Thomas Monjalon
29/07/2021 11:32, Ivan Malov: > In DPDK + Open vSwitch use case, action COUNT is always the > first one to be added. In particular, it goes before action > DECAP in that use case. The current code enforces the right > order (DECAP goes before COUNT), and this provokes failures. > As an exception, d

Re: [dpdk-dev] [PATCH v3] net: fix Intel-specific Prepare the outer ipv4 hdr for checksum

2021-07-30 Thread Olivier Matz
On Wed, Jul 28, 2021 at 06:46:53PM +0300, Andrew Rybchenko wrote: > On 7/7/21 12:40 PM, Mohsin Kazmi wrote: > > Preparation the headers for the hardware offload > > misses the outer ipv4 checksum offload. > > It results in bad checksum computed by hardware NIC. > > > > This patch fixes the issue b

Re: [dpdk-dev] [PATCH 2/3] mbuf: avoid cast-align warning in pktmbuf mtod offset macro

2021-07-30 Thread Olivier Matz
Hi Eli, On Thu, Jul 29, 2021 at 10:13:45AM +0300, Eli Britstein wrote: > > On 7/28/2021 6:28 PM, Olivier Matz wrote: > > External email: Use caution opening links or attachments > > > > > > On Tue, Jul 13, 2021 at 09:49:09AM +0300, Eli Britstein wrote: > > > In rte_pktmbuf_mtod_offset macro, th

[dpdk-dev] [pull-request] dpdk-next-eventdev - v21.08-rc3

2021-07-30 Thread Jerin Jacob Kollanukkaran
The following changes since commit f8c42c53ce744180e1fb4203b2cf976054726360: net/mlx5: fix meter hierarchy validation with yellow (2021-07-29 22:06:43 +0200) are available in the Git repository at: http://dpdk.org/git/next/dpdk-next-eventdev for you to fetch changes up to 9661f6ac433d3dd84

Re: [dpdk-dev] [PATCH v2] eventdev: fix event port setup in tx adapter

2021-07-30 Thread Jerin Jacob
On Wed, Jul 28, 2021 at 4:27 PM Jayatheerthan, Jay wrote: > > > -Original Message- > > From: Jerin Jacob > > Sent: Wednesday, July 28, 2021 3:01 PM > > To: Jayatheerthan, Jay > > Cc: Naga Harish K, S V ; dev@dpdk.org > > Subject: Re: [PATCH v2] eventdev: fix event port setup in tx adapte

Re: [dpdk-dev] [PATCH] event/cnxk: fix reading stale Tx queue depth

2021-07-30 Thread Jerin Jacob
On Tue, Jul 20, 2021 at 12:35 PM wrote: > > From: Pavan Nikhilesh > > Reads to Tx queue FC memory need to be atomic to avoid cores using > same Tx queue spinning on stale values. > > Fixes: 313e884a22fd ("event/cnxk: support Tx adapter fast path") > > Signed-off-by: Pavan Nikhilesh Applied to d

Re: [dpdk-dev] [PATCH 1/3] net: avoid cast-align warning in VLAN insert function

2021-07-30 Thread Olivier Matz
On Tue, Jul 13, 2021 at 09:49:08AM +0300, Eli Britstein wrote: > In rte_vlan_insert there is a casting of rte_pktmbuf_prepend returned > value to (struct rte_ether_hdr *), which causes cast-align warning when > using gcc flags '-Werror -Wcast-align': > > In file included from .../include/rte_ethde

Re: [dpdk-dev] [PATCH v2] eventdev: fix event port setup in tx adapter

2021-07-30 Thread Jerin Jacob
On Fri, Jul 30, 2021 at 4:00 PM Thomas Monjalon wrote: > > 30/07/2021 12:24, Jerin Jacob: > > On Wed, Jul 28, 2021 at 4:27 PM Jayatheerthan, Jay > > wrote: > > > > > > > -Original Message- > > > > From: Jerin Jacob > > > > Sent: Wednesday, July 28, 2021 3:01 PM > > > > To: Jayatheerthan,

Re: [dpdk-dev] [PATCH v2] eventdev: fix event port setup in tx adapter

2021-07-30 Thread Thomas Monjalon
30/07/2021 12:24, Jerin Jacob: > On Wed, Jul 28, 2021 at 4:27 PM Jayatheerthan, Jay > wrote: > > > > > -Original Message- > > > From: Jerin Jacob > > > Sent: Wednesday, July 28, 2021 3:01 PM > > > To: Jayatheerthan, Jay > > > Cc: Naga Harish K, S V ; dev@dpdk.org > > > Subject: Re: [PATC

Re: [dpdk-dev] [PATCH v2] eventdev: fix event port setup in tx adapter

2021-07-30 Thread Jerin Jacob
On Wed, Jul 28, 2021 at 4:27 PM Jayatheerthan, Jay wrote: > > > -Original Message- > > From: Jerin Jacob > > Sent: Wednesday, July 28, 2021 3:01 PM > > To: Jayatheerthan, Jay > > Cc: Naga Harish K, S V ; dev@dpdk.org > > Subject: Re: [PATCH v2] eventdev: fix event port setup in tx adapte

Re: [dpdk-dev] [PATCH v2] net/ena: enable multi segment in Tx offload flags

2021-07-30 Thread Thomas Monjalon
30/07/2021 11:37, Michał Krawczyk: > pt., 30 lip 2021 o 10:35 Olivier Matz napisał(a): > > > > From: Ghalem Boudour > > > > The DPDK ENA driver does not provide multi-segment tx offload capability. > > Let's add DEV_TX_OFFLOAD_MULTI_SEGS to ports offload capability by > > default, and always set

Re: [dpdk-dev] [PATCH v2] net/ena: enable multi segment in Tx offload flags

2021-07-30 Thread Michał Krawczyk
pt., 30 lip 2021 o 10:35 Olivier Matz napisał(a): > > From: Ghalem Boudour > > The DPDK ENA driver does not provide multi-segment tx offload capability. > Let's add DEV_TX_OFFLOAD_MULTI_SEGS to ports offload capability by > default, and always set it in dev->data->dev_conf.txmode.offload. > > Thi

[dpdk-dev] [PATCH 2/2] net/bnxt: fix stats counter resource

2021-07-30 Thread Ajit Khaparde
From: Kishore Padmanabha The flow counters is reduced from 8192 to 6912 for Whitney for compatibility with different versions of FW. Fixes: 6fad9115101c ("net/bnxt: reorganize ULP template directory structure") Cc: sta...@dpdk.org Signed-off-by: Kishore Padmanabha Reviewed-by: Randy Schacher A

[dpdk-dev] [PATCH 1/2] net/bnxt: fix resource qcap list handling

2021-07-30 Thread Ajit Khaparde
From: Jay Ding The size of resource qcap list could be different when FW and application are not match. Application should be able to handle it when the FW is older and the size of qcap is smaller. This patch is needed for backward compatibility on older firmware versions. Fixes: 873661aa641a1

[dpdk-dev] [PATCH 0/2] fixes to bnxt PMD

2021-07-30 Thread Ajit Khaparde
Fixes to bnxt PMD to address compatibility issues with different FW versions. Jay Ding (1): net/bnxt: fix resource qcap list handling Kishore Padmanabha (1): net/bnxt: fix stats counter resource drivers/net/bnxt/tf_core/tf_msg.c| 12 ++-- .../tf_ulp/generic_templ

[dpdk-dev] [PATCH] net/i40e: fix clang warning on non-x86

2021-07-30 Thread Ruifeng Wang
Build on aarch64 with clang-10 has warning: i40e_rxtx.c:3228:1: warning: unused function 'get_avx_supported' [-Wunused-function] The function is used in x86 specific path. Moved it into ifdef to fix build on non-x86. Fixes: c30751afc360 ("net/i40e: fix data path selection in secondary process")

Re: [dpdk-dev] [dpdk-announce] release candidate 21.08-rc2

2021-07-30 Thread Jiang, YuX
Hi All, Update the test status for Intel part. Till now dpdk21.08-rc2 test is finished. No critical issue is found. # Basic Intel(R) NIC testing * Build or compile: *Build: cover the build test combination with latest GCC/Clang/ICC version and the popular OS revision such as Ubuntu20.04,

[dpdk-dev] 6/6] test/oops: support unit test case for oops handling APIs

2021-07-30 Thread jerinj
From: Jerin Jacob Added unit test cases for all the oops handling APIs. Signed-off-by: Jerin Jacob --- app/test/meson.build | 2 + app/test/test_oops.c | 121 +++ 2 files changed, 123 insertions(+) create mode 100644 app/test/test_oops.c diff --git a

[dpdk-dev] 5/6] eal/arm64: support register dump for oops

2021-07-30 Thread jerinj
From: Jerin Jacob Dump the arm64 arch state register in oops handling routine. Signed-off-by: Jerin Jacob --- lib/eal/unix/eal_oops.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/lib/eal/unix/eal_oops.c b/lib/eal/unix/eal_oops.c index da71481ade..7469610d96 100644 -

[dpdk-dev] 4/6] eal/x86: support register dump for oops

2021-07-30 Thread jerinj
From: Jerin Jacob Dump the x86 arch state register in oops handling routine. Signed-off-by: Jerin Jacob --- lib/eal/unix/eal_oops.c | 34 ++ 1 file changed, 34 insertions(+) diff --git a/lib/eal/unix/eal_oops.c b/lib/eal/unix/eal_oops.c index 118b236f35..da7148

[dpdk-dev] 3/6] eal: support libunwind based backtrace

2021-07-30 Thread jerinj
From: Jerin Jacob adding optional libwind library dependency to DPDK for enhanced backtrace based on ucontext. Signed-off-by: Jerin Jacob --- .github/workflows/build.yml | 2 +- .travis.yml | 2 +- config/meson.build | 8 +++ lib/eal/unix/eal_oops.c | 47 +++

[dpdk-dev] 2/6] eal: oops handling API implementation

2021-07-30 Thread jerinj
From: Jerin Jacob Implement the base oops handling APIs. Signed-off-by: Jerin Jacob --- lib/eal/unix/eal_oops.c | 175 ++-- 1 file changed, 168 insertions(+), 7 deletions(-) diff --git a/lib/eal/unix/eal_oops.c b/lib/eal/unix/eal_oops.c index 53b580f733..11

[dpdk-dev] 1/6] eal: introduce oops handling API

2021-07-30 Thread jerinj
From: Jerin Jacob Introducing oops handling API with following specification and enable stub implementation for Linux and FreeBSD. On rte_eal_init() invocation, the EAL library installs the oops handler for the essential signals. The rte_oops_signals_enabled() API provides the list of signals th

[dpdk-dev] 0/6] support oops handling

2021-07-30 Thread jerinj
From: Jerin Jacob It is handy to get detailed OOPS information like Linux kernel when DPDK application crashes without losing any of the features provided by coredump infrastructure by the OS. This patch series introduces the APIs to handle OOPS in DPDK. Following section details the implementa

Re: [dpdk-dev] [PATCH v4] app/testpmd: fix TX checksum calculation for tunnel

2021-07-30 Thread Olivier Matz
On Thu, Jul 29, 2021 at 08:01:41PM +0300, Gregory Etelson wrote: > csumonly engine calculates TX checksum of a tunnelled packet for outer > headers only or separately for outer and inner headers. The > calculation method is determined by checksum configuration options. > If TX checksum calculation

[dpdk-dev] [PATCH v2] vhost: announce experimental tag removal of vhost APIs

2021-07-30 Thread Chenbo Xia
This patch announces the experimental tag removal of 10 vhost APIs, which have been experimental for more than 2 years. All APIs could be made stable in DPDK 21.11. Signed-off-by: Chenbo Xia Acked-by: Maxime Coquelin --- doc/guides/rel_notes/deprecation.rst | 8 1 file changed, 8 inser

[dpdk-dev] [PATCH v2] net/ena: enable multi segment in Tx offload flags

2021-07-30 Thread Olivier Matz
From: Ghalem Boudour The DPDK ENA driver does not provide multi-segment tx offload capability. Let's add DEV_TX_OFFLOAD_MULTI_SEGS to ports offload capability by default, and always set it in dev->data->dev_conf.txmode.offload. This flag in not listed in doc/guides/nics/features/default.ini, so

[dpdk-dev] [PATCH] vhost: announce experimental tag removal of vhost APIs

2021-07-30 Thread Chenbo Xia
This patch announces the experimental tag removal of 10 vhost APIs, which have been experimental for more than 2 years. All APIs could be made stable in DPDK 21.11. Signed-off-by: Chenbo Xia Acked-by: Maxime Coquelin --- doc/guides/rel_notes/deprecation.rst | 8 1 file changed, 8 inser

[dpdk-dev] [PATCH v2 2/2] vhost: notice Vhost ops struct renaming

2021-07-30 Thread Maxime Coquelin
This patch announces the renaming of struct vhost_device_ops to rte_vhost_device_ops in DPDK v21.11. Acked-by: Chenbo Xia Signed-off-by: Maxime Coquelin --- doc/guides/rel_notes/deprecation.rst | 3 +++ 1 file changed, 3 insertions(+) diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/gu

[dpdk-dev] [PATCH v2 1/2] vhost: announce vDPA driver API marking as internal

2021-07-30 Thread Maxime Coquelin
This patch announces the marking of all the vDPA driver APIs as internal. Acked-by: Chenbo Xia Signed-off-by: Maxime Coquelin --- doc/guides/rel_notes/deprecation.rst | 4 1 file changed, 4 insertions(+) diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation

[dpdk-dev] [PATCH v2 0/2] vhost: v21.11 deprecation notices

2021-07-30 Thread Maxime Coquelin
Two deprecations planned for DPDK v21.11 in Vhost: - marking vDPA driver API as internal - prefixing Vhost ops struct with rte_ Maxime Coquelin (2): vhost: announce vDPA driver API marking as internal vhost: notice Vhost ops struct renaming doc/guides/rel_notes/deprecation.rst | 7 +++

[dpdk-dev] [PATCH v2] drivers: remove warning with meson 0.59.0

2021-07-30 Thread jerinj
From: Jerin Jacob Since meson 0.59.0 version, the extract_all_objects() API need to pass explicit boolean value. To remove the following warning[1], added explicit `true` for extract_all_objects() use in codebase whever there is no argument. [1] WARNING: extract_all_objects called without setti

Re: [dpdk-dev] [PATCH 1/2] vhost: announce vDPA driver API marking as internal

2021-07-30 Thread Maxime Coquelin
On 7/30/21 7:32 AM, Xia, Chenbo wrote: > Hi Maxime, > >> -Original Message- >> From: Maxime Coquelin >> Sent: Thursday, July 29, 2021 10:43 PM >> To: dev@dpdk.org; Xia, Chenbo ; amore...@redhat.com; >> Richardson, Bruce ; Yigit, Ferruh >> ; tho...@monjalon.net; acon...@redhat.com >> Cc

Re: [dpdk-dev] [PATCH] doc: announce security API changes for Inline IPsec

2021-07-30 Thread Hemant Agrawal
Acked-by: Hemant Agrawal