Functions and macros in x86 rte_memcpy.h may cause cast-align warnings,
when using gcc flags '-Werror -Wcast-align':
For example:
.../include/rte_memcpy.h:499:42: error: cast increases required alignment
of target type [-Werror=cast-align]
499 | xmm0 = _mm_loadu_si128((const __m128i *)(cons
In rte_pktmbuf_mtod_offset macro, there is a casting from char * to type
't', which may cause cast-align warning when using gcc flags
'-Werror -Wcast-align':
.../include/rte_mbuf_core.h:723:3: error: cast increases required alignment
of target type [-Werror=cast-align]
723 | ((t)((char *)(m
In rte_vlan_insert there is a casting of rte_pktmbuf_prepend returned
value to (struct rte_ether_hdr *), which causes cast-align warning when
using gcc flags '-Werror -Wcast-align':
In file included from .../include/rte_ethdev.h:165,
from lib/netdev-dpdk.c:33:
.../include/rte_ethe
Various functions/macros assume valid alignment for casting. Compiling
an application against it with -Werror and -Wcast-align may trigger
cast-align warnings.
To avoid those, add first (void *) castings.
Note: for eal/arm64 similar changes could be applied to
lib/eal/arm/include/rte_memcpy_64.h.
> -Original Message-
> From: stable On Behalf Of Viacheslav Ovsiienko
> Sent: Monday, July 12, 2021 20:41
> To: dev@dpdk.org
> Cc: Singh, Aman Deep ;
> arybche...@solarflare.com; sta...@dpdk.org
> Subject: [dpdk-stable] [PATCH v3] app/testpmd: fix offloads for the newly
> attached port
> -Original Message-
> From: Wang, Jie1X
> Sent: Tuesday, July 13, 2021 10:34
> To: Li, Xiaoyun ; andrew.rybche...@oktetlabs.ru;
> dev@dpdk.org
> Cc: sta...@dpdk.org
> Subject: RE: [dpdk-dev] [PATCH] app/testpmd: fix testpmd doesn't show RSS
> hash offload
>
> Hi all,
> I have tested th
> -Original Message-
> From: Zhang, AlvinX
> Sent: Tuesday, July 13, 2021 10:36 AM
> To: Zhang, Qi Z
> Cc: dev@dpdk.org; Zhang, AlvinX
> Subject: [PATCH v2] net/ice/base: support MPLS ethertype switch filter
>
> Add MPLS training packet and offsets.
> Add check to identify MPLS ether
> -Original Message-
> From: Su, Simei
> Sent: Tuesday, July 13, 2021 10:10 AM
> To: Zhang, Qi Z
> Cc: dev@dpdk.org; Cao, Yahui ; Su, Simei
>
> Subject: [PATCH v2] net/ice: fix FDIR when SPI as input set for ESP flow
>
> FDIR can't work when SPI as inputset for both ESP over IP and E
> -Original Message-
> From: Wu, Wenjun1
> Sent: Tuesday, July 13, 2021 10:31 AM
> To: dev@dpdk.org; Yang, Qiming ; Zhang, Qi Z
>
> Cc: Wu, Wenjun1
> Subject: [PATCH v2] net/ice/base: revert the change of first profile mask
>
> Segmentation fault mentioned in patch[1] is related to h
Segmentation fault mentioned in patch[1] is related to hardware
issue.
This patch revert patch[1], since patch[1] may have potential
risk and side effect if the first profile mask is set to 0.
[1]:
commit 148fdf2d3537 ("net/ice/base: fix first profile mask")
Signed-off-by: Wenjun Wu
---
v2: cor
Add MPLS training packet and offsets.
Add check to identify MPLS ethertype filters.
For example:
testpmd> flow create 0 ingress pattern eth dst is 00:11:22:33:44:55 \
type is 0x8847 / end actions queue index 2 / end
This flow will result in all the matched ingress packets be
forwarded to
FDIR can't work when SPI as inputset for both ESP over IP and ESP
over UDP flow. This patch fixes this issue by adding the corresponding
input set for ESP over IP and ESP over UDP when parsing input set. Also,
it adds input set bit for NAT_T_ESP to distinguish ESP over IP and ESP
over UDP.
Fixes:
Segmentation fault mentioned in patch[1] is related to hardware
issue.
This patch revert patch[1], since patch[1] may have protential
risk and side effect if the first profile mask is set to 0.
[1]:
commit 148fdf2d3537 ("net/ice/base: fix first profile mask")
Signed-off-by: Wenjun Wu
---
driver
On Sun, Jul 11, 2021 at 7:34 PM Ruifeng Wang wrote:
> > -Original Message-
> > From: Lance Richardson
> > Sent: Saturday, July 10, 2021 12:39 AM
> > To: Ajit Khaparde (ajit.khapa...@broadcom.com)
> > ; Somnath Kotur
> > ; Bruce Richardson
> > ; Konstantin Ananyev
> > ; jer...@marvell.com
Hi, Qi
> -Original Message-
> From: Zhang, Qi Z
> Sent: Tuesday, July 13, 2021 9:07 AM
> To: Su, Simei
> Cc: dev@dpdk.org; Cao, Yahui
> Subject: RE: [PATCH] net/ice: fix SPI for ESP and NATT not work issue
>
>
>
> > -Original Message-
> > From: Su, Simei
> > Sent: Monday, Ju
This patch adds thread unsafe version for async register and
unregister functions.
Signed-off-by: Jiayu Hu
---
doc/guides/prog_guide/vhost_lib.rst | 12 +++
lib/vhost/rte_vhost_async.h | 39 ++
lib/vhost/version.map | 4 +
lib/vhost/vhost.c | 1
This patch reworks the async configuration structure to improve code
readability. In addition, add preserved padding fields on the structure
for future usage.
Signed-off-by: Jiayu Hu
---
doc/guides/prog_guide/vhost_lib.rst | 19 +++
examples/vhost/main.c | 8 --
The vhost notifies the application of device readiness via
vhost_user_notify_queue_state(), but calling this function
is not protected by the lock. This patch is to make this
function call lock protected.
Fixes: d0fcc38f5fa4 ("vhost: improve device readiness notifications")
Cc: sta...@dpdk.org
Si
Lock protection is needed during the vhost notifies the application of
device readiness, so the first patch adds lock protection. In addition,
the second patch reworks async feature structure to improve readability.
After performing locking, existed async vhost registration functions will
cause dea
This patch defines new RSS offload types for IPv4 and
L4(TCP/UDP/SCTP) checksum, which are required when users want
to distribute packets based on the IPv4 or L4 checksum field.
For example "flow create 0 ingress pattern eth / ipv4 / end
actions rss types ipv4-chksum end queues end / end", this fl
> -Original Message-
> From: Su, Simei
> Sent: Monday, July 12, 2021 5:39 PM
> To: Zhang, Qi Z
> Cc: dev@dpdk.org; Cao, Yahui ; Su, Simei
>
> Subject: [PATCH] net/ice: fix SPI for ESP and NATT not work issue
What is "ESP and NATT"
Do you mean
fix FDIR when SPI as inputset for an ES
> -Original Message-
> From: Joyce Kong
> Sent: Tuesday, July 6, 2021 2:54 PM
> To: Xing, Beilei ; Zhang, Qi Z ;
> ruifeng.w...@arm.com; honnappa.nagaraha...@arm.com; Richardson, Bruce
> ; Zhang, Helin
> Cc: dev@dpdk.org; sta...@dpdk.org; n...@arm.com
> Subject: [PATCH v3 2/2] net/i40e
> -Original Message-
> From: Wu, Wenjun1
> Sent: Monday, July 12, 2021 4:28 PM
> To: dev@dpdk.org; Wu, Jingjing ; Xing, Beilei
> ; Zhang, Qi Z
> Cc: Wu, Wenjun1
> Subject: [PATCH v2] net/iavf: support default RSS for IP fragment packet
>
> This patch adds default RSS support for IPv4
Hi Raslan,
> -Original Message-
> From: Raslan Darawsheh
> Sent: Monday, July 12, 2021 10:59 PM
> To: Suanming Mou ; Slava Ovsiienko
> ; Matan Azrad
> Cc: Ori Kam ; dev@dpdk.org
> Subject: RE: [PATCH v5 14/26] common/mlx5: add list lcore share
>
> Hi Suanming,
>
> This patch will cause
On 7/5/21 2:28 AM, David Marchand wrote:
On Wed, Jun 23, 2021 at 6:13 PM David Christensen
wrote:
Suppress gcc warning "warning: writing 16 bytes into a region of
size 0" for users of the POWER rte_memcpy() function. Existing
rte_memcpy() code takes different code paths based on the actual
Fix the incorrect array out of bounds check within the function
pipeline_selector_group_member_read().
Coverity issue: 371911
Fixes: 598fe0dd0d8e3 ("examples/pipeline: support selector table")
Signed-off-by: Cristian Dumitrescu
---
examples/pipeline/cli.c | 2 +-
1 file changed, 1 insertion(+),
Due to a typo, the selector_free() function incorrectly takes an early
return when the selectors array is non-NULL, as opposed to the other
way around.
Coverity issue: 371912
Fixes: cdaa937d3eaab ("pipeline: support selector table")
Signed-off-by: Cristian Dumitrescu
---
lib/pipeline/rte_swx_ct
>
> Hi,
>
> I would like to open a discussion about RHEL 7 support in DPDK.
> How long do we want to support it in new DPDK versions?
> Can we drop RHEL 7 support starting DPDK 21.11?
I think the concerns were from Redhat and Intel.
>
> If we decide to drop RHEL 7 support, does it mean we can
The DPDK ENA driver does not provide multi-segment tx offload capability.
Let's add DEV_TX_OFFLOAD_MULTI_SEGS to ports offload capability by default.
This flag in not listed in doc/guides/nics/features/default.ini, so
ena.ini does not need to be updated.
Signed-off-by: Ghalem Boudour
Reviewed-by
On Sat, Jul 10, 2021 at 12:57:19PM +, Ananyev, Konstantin wrote:
>
> > > > > > > > > > For Tx inline processing, when
> > > > > > > > > > RTE_SECURITY_TX_OLOAD_NEED_MDATA is
> > > > > > > > > > set, rte_security_set_pkt_metadata() needs to be called for
> > > > > > > > > > pkts
> > > > > > >
On Mon, Jul 12, 2021 at 10:04:07PM +0530, Jerin Jacob wrote:
> On Mon, Jul 12, 2021 at 7:02 PM Bruce Richardson
> wrote:
> >
> > On Mon, Jul 12, 2021 at 03:29:27PM +0530, Jerin Jacob wrote:
> > > On Sun, Jul 11, 2021 at 2:59 PM Chengwen Feng
> > > wrote:
> > > >
> > > > This patch introduce 'dma
On Mon, Jul 12, 2021 at 7:02 PM Bruce Richardson
wrote:
>
> On Mon, Jul 12, 2021 at 03:29:27PM +0530, Jerin Jacob wrote:
> > On Sun, Jul 11, 2021 at 2:59 PM Chengwen Feng
> > wrote:
> > >
> > > This patch introduce 'dmadevice' which is a generic type of DMA
> > > device.
> > >
> > > The APIs of
From: Viacheslav Galaktionov
Fix representor port ID search by name if the representor itself
does not provide representors info. Getting a list of representors
from a representor does not make sense. Instead, a parent device
should be used.
To this end, extend the rte_eth_dev_data structure to
On Tue, Jul 6, 2021 at 1:49 PM wrote:
>
> From: Satheesh Paul
>
> Preallocation of MCAM entries is not valid anymore since the
> AF side MCAM allocation scheme has changed. This patch disables
> preallocation by changing the default MCAM preallocation size
> from 8 to 1.
>
> Fixes: 168c59cfe42 ("
On Sun, Jul 11, 2021 at 05:25:56PM +0800, Chengwen Feng wrote:
> This patch introduce 'dmadevice' which is a generic type of DMA
> device.
>
> The APIs of dmadev library exposes some generic operations which can
> enable configuration and I/O with the DMA devices.
>
> Signed-off-by: Chengwen Feng
> -Original Message-
> From: Ruifeng Wang
> Sent: Wednesday, July 7, 2021 12:03
> To: Raslan Darawsheh ; Matan Azrad
> ; Shahaf Shuler ; Slava
> Ovsiienko
> Cc: dev@dpdk.org; jer...@marvell.com; n...@arm.com;
> honnappa.nagaraha...@arm.com; Ruifeng Wang
> Subject: [PATCH v2 2/2] net/mlx5
> -Original Message-
> From: Ruifeng Wang
> Sent: Wednesday, July 7, 2021 12:03
> To: Raslan Darawsheh ; Matan Azrad
> ; Shahaf Shuler ; Slava
> Ovsiienko
> Cc: dev@dpdk.org; jer...@marvell.com; n...@arm.com;
> honnappa.nagaraha...@arm.com; Ruifeng Wang ;
> sta...@dpdk.org
> Subject: [PAT
Hi Suanming,
This patch will cause the following failure in compilation with CLANG :
[1443/3183] Compiling C object
drivers/libtmp_rte_common_mlx5.a.p/common_mlx5_mlx5_common_utils.c.o
FAILED: drivers/libtmp_rte_common_mlx5.a.p/common_mlx5_mlx5_common_utils.c.o
clang -Idrivers/libtmp_rte_common_m
The replenishment scheme for the vectorized MPRQ Rx burst aims
to improve the cache locality by allocating new mbufs only when
there are almost no mbufs left: one burst gap between allocated
and consumed indexes.
This gap is not big enough to accommodate a corner case when we
have a very aggressiv
On Mon, Jul 12, 2021 at 03:29:27PM +0530, Jerin Jacob wrote:
> On Sun, Jul 11, 2021 at 2:59 PM Chengwen Feng wrote:
> >
> > This patch introduce 'dmadevice' which is a generic type of DMA
> > device.
> >
> > The APIs of dmadev library exposes some generic operations which can
> > enable configurat
Hi Jan,
> -Original Message-
> From: Jan Viktorin
> Sent: Monday, July 12, 2021 12:46 AM
>
> On Sun, 11 Jul 2021 08:49:18 +
> Ori Kam wrote:
>
> > Hi Jan,
>
> Hi Ori,
>
> >
> >
> > > -Original Message-
> > > From: dev On Behalf Of Jan Viktorin
> > > Sent: Wednesday, July
Older compilers may not support all arch versions and all features that
the target SoC supports, in which case it's better to figure out the
highest arch version and features that the compiler supports. Implement
a way to achieve this:
1. Find the highest arch version that the compiler supports, ke
For the newly attached ports (with "port attach" command) the
default offloads settings, configured from application command
line, were not applied, causing port start failure following
the attach.
For example, if scattering offload was configured in command
line and rxpkts was configured for mult
On Thu, Jul 1, 2021 at 2:59 PM Anoob Joseph wrote:
>
> In the inline inound path, a custom header would be present at L3 which
> has sequence number & SPI. L2 need to be adjusted such that the eventual
> packet would have L3 after L2. Remove assumption of L2 type in this
> handling.
>
> Signed-off
On Sun, Jul 11, 2021 at 05:25:56PM +0800, Chengwen Feng wrote:
> This patch introduce 'dmadevice' which is a generic type of DMA
> device.
>
> The APIs of dmadev library exposes some generic operations which can
> enable configuration and I/O with the DMA devices.
>
> Signed-off-by: Chengwen Feng
For the newly attached ports (with "port attach" command) the
default offloads settings, configured from application command
line, were not applied, causing port start failure following
the attach.
For example, if scattering offload was configured in command
line and rxpkts was configured for mult
On Sun, Jul 11, 2021 at 2:59 PM Chengwen Feng wrote:
>
> This patch introduce 'dmadevice' which is a generic type of DMA
> device.
>
> The APIs of dmadev library exposes some generic operations which can
> enable configuration and I/O with the DMA devices.
>
> Signed-off-by: Chengwen Feng
> ---
>
This patch fixes this issue by adding the correspongding input set for
ESP and NATT when parsing input set. Also, it adds input set bit for
NAT_T_ESP to distinguish ESP over IP and ESP over UDP.
Fixes: 70feafc1a3f2 ("net/ice: support ESP/NATT flow director to match outer
IP")
Signed-off-by: Sime
Hi Cheng,
Thanks for catching the issue.
It was an accident, that I thought I had resolved already :)
This is fixed now.
Maxime
On 7/12/21 8:53 AM, Jiang, Cheng1 wrote:
> Hi Maxime,
>
> I have noticed you changed the state this patch to Superseded.
> So are you going to submit a new version of
On Sun, Jul 11, 2021 at 6:43 PM wrote:
>
> From: Meir Levi
>
> vlan_strip and vlan_extend features need to return "unsupported"
> error value.
>
> Fixes: ff0b8b10dc4 ("net/mvpp2: support VLAN offload")
> Cc: sta...@dpdk.org
>
> Signed-off-by: Meir Levi
> Reviewed-by: Liron Himi
Changed the su
This patch adds default RSS support for IPv4 and IPv6 fragment packet.
Signed-off-by: Wenjun Wu
---
v2: modify error implementation
---
drivers/net/iavf/iavf_hash.c | 32
1 file changed, 32 insertions(+)
diff --git a/drivers/net/iavf/iavf_hash.c b/drivers/net/i
On Sun, Jul 11, 2021 at 6:42 PM wrote:
>
> From: Dana Vardi
>
> Need to set configure flag to allow create and commit mrvl tm
> hierarchy tree. tm configuration depends on parameters that are
> being set in port configure stage, e.g. nb_tx_queues.
> This also aligned with the tm api description.
This patch disables asymmetric crypto pmd on gen3 devices.
Fixes: 1f5e4053f9b4 ("common/qat: support GEN3 devices")
Cc: sta...@dpdk.org
Signed-off-by: Arek Kusztal
---
drivers/crypto/qat/qat_asym_pmd.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/drivers/crypto/qat/qat_asym_pmd.c
b
> -Original Message-
> From: Ali Alnubani
> Sent: Monday, July 12, 2021 8:51 AM
> To: Dumitrescu, Cristian ; dev@dpdk.org;
> NBU-Contact-Thomas Monjalon
> Cc: Khangar, Churchill
> Subject: RE: [dpdk-dev] [PATCH V4 4/5] examples/pipeline: add support for
> selector tables
>
> > -O
> -Original Message-
> From: Ali Alnubani
> Sent: Monday, July 12, 2021 8:47 AM
> To: dev@dpdk.org
> Cc: tho...@monjalon.net; Khangar, Churchill
> ; Dumitrescu, Cristian
>
> Subject: [PATCH] examples/pipeline: fix build
>
> This patch fixes the following build failures seen on Ubuntu
Hi,
> -Original Message-
> From: dev On Behalf Of Xiaoyu Min
> Sent: Wednesday, July 7, 2021 5:33 AM
> To: Matan Azrad ; Shahaf Shuler
> ; Slava Ovsiienko ; Dekel
> Peled ; Ori Kam
> Cc: dev@dpdk.org; sta...@dpdk.org
> Subject: [dpdk-dev] [PATCH 2/2] net/mlx5: fix missing RSS expansion o
Update the incorrect description about atomic operations
with provided wrappers in deprecation doc[1].
[1]https://mails.dpdk.org/archives/dev/2021-July/21.html
Fixes: 7518c5c4ae6a ("doc: announce adoption of C11 atomic operations
semantics")
Cc: sta...@dpdk.org
Signed-off-by: Joyce Kong
Re
On Sun, Jul 11, 2021 at 6:41 PM wrote:
>
> From: Dana Vardi
>
> ethtool_cmd_speed return uint32 and after the arithmetic
> operation in mrvl_get_max_rate func the result is out of range.
>
> Fixes: 429c394417 ("net/mvpp2: support traffic manager")
> Cc: t...@semihalf.com
> Cc: sta...@dpdk.org
>
>
On Mon, Jul 12, 2021 at 12:31 PM Morten Brørup
wrote:
>
> > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Jerin Jacob
>
> > Probably we can remove rte_dmadev_fill_sg() variant and keep sg only
> > for copy to save 8B.
>
> Perhaps the scatter/gather functions can be on a separate cache line
> -Original Message-
> From: dev On Behalf Of Ali Alnubani
> Sent: Sunday, July 11, 2021 2:27 PM
> To: Cristian Dumitrescu ; dev@dpdk.org;
> NBU-Contact-Thomas Monjalon
> Cc: Churchill Khangar
> Subject: Re: [dpdk-dev] [PATCH V4 4/5] examples/pipeline: add support for
> selector tables
>
This patch fixes the following build failures seen on Ubuntu 16.04
with gcc 5.4.0 because of uninitialized variables:
...
examples/pipeline/cli.c:1559:11: error: 'weight_val' may be used
uninitialized in this function [-Werror=maybe-uninitialized]
...
examples/pipeline/cli.c:1545:13: error: 'memb
From: Somnath Kotur
FW has been modified to send a new async event when it detects
a pause storm. Register for this new event and log it upon receipt.
Signed-off-by: Somnath Kotur
Reviewed-by: Ajit Khaparde
---
drivers/net/bnxt/bnxt.h | 5 +
drivers/net/bnxt/bnxt_cpr.c | 19 +++
From: Somnath Kotur
Store the async event completion data1 and data2 in separate variables
at the start of the function before the switch case for the different
events so they can be used by any of the event handlers.
Signed-off-by: Somnath Kotur
Reviewed-by: Ajit Khaparde
---
drivers/net/bnx
From: Kalesh AP
This enables device firmware to respond appropriately to BMC queries
about the driver's configured MTU.
Signed-off-by: Kalesh AP
Reviewed-by: Ajit Khaparde
Reviewed-by: Lance Richardson
---
drivers/net/bnxt/bnxt_ethdev.c | 3 +++
drivers/net/bnxt/bnxt_hwrm.c | 24 +
From: Kalesh AP
- HWRM version updated to 1.10.2.44
- Added corresponding driver changes for the Admin MTU field name change.
Signed-off-by: Kalesh AP
Reviewed-by: Ajit Khaparde
Reviewed-by: Somnath Kotur
---
drivers/net/bnxt/bnxt_hwrm.c | 14 +-
drivers/net/bnxt/hsi_struct_def_d
From: Kalesh AP
Please apply.
Kalesh AP (2):
net/bnxt: update HSI structure
net/bnxt: inform firmware about host MTU
Somnath Kotur (2):
net/bnxt: minor refactoring of async handling code
net/bnxt: add handler for pause storm event
drivers/net/bnxt/bnxt.h|5 +
drive
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Jerin Jacob
>
> On Sun, Jul 11, 2021 at 3:12 PM fengchengwen
> wrote:
> >
> > Note:
> > 1) This patch hold dmadev <> vchan layer, I think vchan can be very
> >conceptually separated from hw-channel.
>
> I would like to keep it as channel
The issue can cause illegal physical address access while a huge-page A
is released and huge-page B is allocated on the same virtual address.
The old MR can be matched using the virtual address of huge-page B but
the HW will access the physical address of huge-page A which is no more
part of the DP
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Chengwen Feng
>
> This patch introduce 'dmadevice' which is a generic type of DMA
> device.
>
> The APIs of dmadev library exposes some generic operations which can
> enable configuration and I/O with the DMA devices.
>
> Signed-off-by: Chen
In the PCI removal function, PMD releases all driver resources and
cancels the regexdev registry.
However, regexdev registration is accidentally canceled twice.
Remove one of them.
Fixes: b34d816363b5 ("regex/mlx5: support rules import")
Cc: sta...@dpdk.org
Signed-off-by: Michael Baum
---
dri
The issue can cause illegal physical address access while a huge-page A
is released and huge-page B is allocated on the same virtual address.
The old MR can be matched using the virtual address of huge-page B but
the HW will access the physical address of huge-page A which is no more
part of the DP
In the PCI removal function, PMD releases all driver resources allocated
in the probe function.
The MR btree memory is allocated in the probe function, but it is not
freed in remove function what caused a memory leak.
Release it.
Fixes: cda883bbb655 ("regex/mlx5: add dynamic memory registration
Some independent fixes in MLX5 RegEx driver.
v1: Initial fixes.
v2: Initialize pointer of global generation number.
Add global generation number checking in indirect mkey creation.
v3: Rebase.
v4: Rebase after integrating the patch on which it is based
(https://patchwork.dpdk.org/project/
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Jerin Jacob
> Probably we can remove rte_dmadev_fill_sg() variant and keep sg only
> for copy to save 8B.
Perhaps the scatter/gather functions can be on a separate cache line, following
the cache line with the simple functions?
Of course, th
74 matches
Mail list logo
