Re: [dpdk-dev] [EXT] Re: [pull-request] next-crypto 21.08 rc1

2021-07-08 Thread David Marchand
On Fri, Jul 9, 2021 at 6:25 AM Anoob Joseph wrote: > > Hi Ali, David, > > Thanks for pointing it out. The suggestion from David should do. Should we > submit a patch with fix on master? How do you suggest we proceed? Yes, please send a patch. I'll take those three fixes directly in main. Probab

Re: [dpdk-dev] [PATCH] crypto/cnxk: add PCI ID for cn9k

2021-07-08 Thread Akhil Goyal
> Add PCI ID for crypo_cn9k PMD. > > To avoid conflicting PCI ID in crypto_octeontx2 and > crypto_cn9k PMDs, disable crypto_cn9k PMD when built with > octeontx2 config. > > The lack of PCI ID is causing debug build to fail for > crypto_cn9k PMD. > > Reported-by: Ali Alnubani > Suggested-by: Dav

[dpdk-dev] [PATCH] crypto/cnxk: add PCI ID for cn9k

2021-07-08 Thread Anoob Joseph
Add PCI ID for crypo_cn9k PMD. To avoid conflicting PCI ID in crypto_octeontx2 and crypto_cn9k PMDs, disable crypto_cn9k PMD when built with octeontx2 config. The lack of PCI ID is causing debug build to fail for crypto_cn9k PMD. Reported-by: Ali Alnubani Suggested-by: David Marchand Signed-of

Re: [dpdk-dev] [PATCH v3] doc: policy on the promotion of experimental APIs

2021-07-08 Thread Jerin Jacob
On Thu, Jul 1, 2021 at 4:08 PM Ray Kinsella wrote: > > Clarifying the ABI policy on the promotion of experimental APIS to stable. > We have a fair number of APIs that have been experimental for more than > 2 years. This policy amendment indicates that these APIs should be > promoted or removed, or

[dpdk-dev] [PATCH v1] net/octeontx/base: fix debug build with clang

2021-07-08 Thread Shijith Thotton
From: David Marchand Remove conflicting declaration of this symbol. Fixes: d0d654986018 ("net/octeontx: support event Rx adapter") Cc: sta...@dpdk.org Signed-off-by: David Marchand --- drivers/net/octeontx/base/octeontx_pkivf.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/oc

[dpdk-dev] [PATCH] net/softnic: fix memory leak in connection init

2021-07-08 Thread dapengx . yu
From: Dapeng Yu In function softnic_conn_init(), a block of memory is allocated as connection buffer, but it is never freed in softnic_conn_free(), which cause memory leak. This patch fixes it. Fixes: 7709a63bf178 ("net/softnic: add connection agent") Cc: sta...@dpdk.org Signed-off-by: Dapeng

Re: [dpdk-dev] [PATCH] net/bnxt: fix missing barriers in completion handling

2021-07-08 Thread Ruifeng Wang
> -Original Message- > From: Lance Richardson > Sent: Friday, July 9, 2021 3:15 AM > To: Ajit Khaparde (ajit.khapa...@broadcom.com) > ; Somnath Kotur > ; Bruce Richardson > ; Konstantin Ananyev > ; jer...@marvell.com; Ruifeng Wang > ; Stephen Hurd ; > David Christensen > Cc: dev@dpdk.org;

Re: [dpdk-dev] [PATCH v2] net/ixgbe: fix using heap pointer after free

2021-07-08 Thread Wang, Haiyue
> -Original Message- > From: Yu, DapengX > Sent: Friday, July 9, 2021 11:15 > To: Wang, Haiyue > Cc: dev@dpdk.org; Yu, DapengX ; sta...@dpdk.org > Subject: [PATCH v2] net/ixgbe: fix using heap pointer after free > > From: Dapeng Yu > > The original code use a heap pointer after it is f

Re: [dpdk-dev] [EXT] Re: [pull-request] next-crypto 21.08 rc1

2021-07-08 Thread Anoob Joseph
Hi Ali, David, Thanks for pointing it out. The suggestion from David should do. Should we submit a patch with fix on master? How do you suggest we proceed? Thanks, Anoob > -Original Message- > From: dev On Behalf Of David Marchand > Sent: Friday, July 9, 2021 1:46 AM > To: Ali Alnubani

[dpdk-dev] [PATCH v7 2/2] test/power: round cpuinfo cur freq only in CPPC cpufreq

2021-07-08 Thread Richael Zhuang
On arm platform, the value in "/sys/.../cpuinfo_cur_freq" may not be exactly the same as what was set when using CPPC cpufreq driver. For other cpufreq driver, no need to round it currently, or else this check will fail with turbo enabled. For example, with acpi_cpufreq, cpuinfo_cur_freq can be 240

[dpdk-dev] [PATCH v7 1/2] power: add support for cppc cpufreq

2021-07-08 Thread Richael Zhuang
Currently in DPDK only acpi_cpufreq and pstate_cpufreq drivers are supported, which are both not available on arm64 platforms. Add support for cppc_cpufreq driver which works on most arm64 platforms. Signed-off-by: Richael Zhuang --- app/test/test_power.c | 3 +- app/test/test

[dpdk-dev] [PATCH v7 0/2] power: add support for cppc cpufreq driver

2021-07-08 Thread Richael Zhuang
v7: base on new API(open_core_sysfs_file) in http://dpdk.org/patch/95581, update release note in release_21_08.rst. Richael Zhuang (2): power: add support for cppc cpufreq test/power: round cpuinfo cur freq only in CPPC cpufreq app/test/test_power.c | 3 +- app/test/test_p

[dpdk-dev] [PATCH v2] net/ixgbe: fix using heap pointer after free

2021-07-08 Thread dapengx . yu
From: Dapeng Yu The original code use a heap pointer after it is freed. This patch fix it. Fixes: a14de8b498d1 ("net/ixgbe: destroy consistent filter") Cc: sta...@dpdk.org Signed-off-by: Dapeng Yu --- V2: * Simplify the patch according to maintainer's comment: only one "pmd_flow" in the list

[dpdk-dev] [PATCH v3 3/3] vhost: add thread unsafe async registeration functions

2021-07-08 Thread Jiayu Hu
This patch adds thread unsafe version for async register and unregister functions. Signed-off-by: Jiayu Hu --- doc/guides/prog_guide/vhost_lib.rst | 12 +++ lib/vhost/rte_vhost_async.h | 39 + lib/vhost/version.map | 4 + lib/vhost/vhost.c | 15

[dpdk-dev] [PATCH v3 2/3] vhost: rework async configuration struct

2021-07-08 Thread Jiayu Hu
This patch reworks the async configuration structure to improve code readability. In addition, add preserved padding fields on the structure for future usage. Signed-off-by: Jiayu Hu --- doc/guides/prog_guide/vhost_lib.rst | 19 +++ examples/vhost/main.c | 8 --

[dpdk-dev] [PATCH v3 1/3] vhost: fix lock on device readiness notification

2021-07-08 Thread Jiayu Hu
The vhost notifies the application of device readiness via vhost_user_notify_queue_state(), but calling this function is not protected by the lock. This patch is to make this function call lock protected. Fixes: d0fcc38f5fa4 ("vhost: improve device readiness notifications") Cc: sta...@dpdk.org Sig

[dpdk-dev] [PATCH v3 0/3] provide thread unsafe async registration functions

2021-07-08 Thread Jiayu Hu
Lock protection is needed during the vhost notifies the application of device readiness, so the first patch adds lock protection. In addition, the second patch reworks async feature structure to improve readability. After performing locking, existed async vhost registration functions will cause dea

Re: [dpdk-dev] [PATCH v3 1/2] net/i40e: add logic of processing continuous DD bits for Arm

2021-07-08 Thread Zhang, Qi Z
> -Original Message- > From: Joyce Kong > Sent: Tuesday, July 6, 2021 2:54 PM > To: Xing, Beilei ; Zhang, Qi Z ; > ruifeng.w...@arm.com; honnappa.nagaraha...@arm.com; Richardson, Bruce > ; Zhang, Helin > Cc: dev@dpdk.org; sta...@dpdk.org; n...@arm.com > Subject: [PATCH v3 1/2] net/i40e

Re: [dpdk-dev] [PATCH 2/2] net/ice: fix VXLAN flow director creation error

2021-07-08 Thread Zhang, Qi Z
> -Original Message- > From: Yu, DapengX > Sent: Wednesday, June 16, 2021 9:21 AM > To: Yang, Qiming ; Zhang, Qi Z > > Cc: dev@dpdk.org; Guo, Junfeng ; Yan, Zhirun > ; Yu, DapengX ; > sta...@dpdk.org > Subject: [PATCH 2/2] net/ice: fix VXLAN flow director creation error > > From: Dape

Re: [dpdk-dev] [PATCH 1/2] net/ice/base: fix VXLAN flow director creation error

2021-07-08 Thread Zhang, Qi Z
> -Original Message- > From: Yu, DapengX > Sent: Wednesday, June 16, 2021 9:21 AM > To: Yang, Qiming ; Zhang, Qi Z > > Cc: dev@dpdk.org; Guo, Junfeng ; Yan, Zhirun > ; Yu, DapengX ; > sta...@dpdk.org > Subject: [PATCH 1/2] net/ice/base: fix VXLAN flow director creation error > > From:

[dpdk-dev] [PATCH] net/bnxt: fix build failure

2021-07-08 Thread Ajit Khaparde
Fix build failures because of uninitialized variable usage. Fixes: 05b405d58148 ("net/bnxt: add dpool allocator for EM allocation") Signed-off-by: Kishore Padmanabha Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/tf_core/dpool.c | 1 + drivers/net/bnxt/tf_ulp/ulp_mapper.c | 2 +- 2 file

Re: [dpdk-dev] [PATCH] net/ixgbe: fix using heap pointer after free

2021-07-08 Thread Wang, Haiyue
> -Original Message- > From: Yu, DapengX > Sent: Friday, July 9, 2021 10:30 > To: Wang, Haiyue > Cc: dev@dpdk.org; Yu, DapengX ; sta...@dpdk.org > Subject: [PATCH] net/ixgbe: fix using heap pointer after free > > From: Dapeng Yu > > The original code use a heap pointer after it is free

Re: [dpdk-dev] [PATCH v6 1/2] power: add support for cppc cpufreq

2021-07-08 Thread Richael Zhuang
Thanks so much, I will rework it soon. Best Regards, Richael > -Original Message- > From: David Marchand > Sent: Thursday, July 8, 2021 9:30 PM > To: Richael Zhuang > Cc: dev ; Yu Jiang ; David Hunt > > Subject: Re: [dpdk-dev] [PATCH v6 1/2] power: add support for cppc cpufreq > > On T

[dpdk-dev] [PATCH] net/ixgbe: fix using heap pointer after free

2021-07-08 Thread dapengx . yu
From: Dapeng Yu The original code use a heap pointer after it is freed. This patch fix it. Fixes: a14de8b498d1 ("net/ixgbe: destroy consistent filter") Cc: sta...@dpdk.org Signed-off-by: Dapeng Yu --- drivers/net/ixgbe/ixgbe_flow.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) dif

Re: [dpdk-dev] [PATCH 0/4] features for hns3 PMD

2021-07-08 Thread Min Hu (Connor)
Thanks Andrew, "net/hns3: supports disabling PFC by dev configure API" this patch could be abandoned. The other three can be applied. 在 2021/6/14 23:00, Andrew Rybchenko 写道: On 6/13/21 6:05 AM, Min Hu (Connor) wrote: This patch set contains 4 features for hns3 PMD: add query basic info suppor

Re: [dpdk-dev] RFC enabling dll/dso for dpdk on windows

2021-07-08 Thread Tyler Retzlaff
On Thu, Jul 08, 2021 at 11:49:53PM +0300, Dmitry Kozlyuk wrote: > Hi Tyler, > > 2021-07-08 12:21 (UTC-0700), Tyler Retzlaff: > > hi folks, > > > > we would like to submit a a patch series that makes dll/dso for dpdk > > work on windows. there are two differences in the windows platform that > > w

Re: [dpdk-dev] RFC enabling dll/dso for dpdk on windows

2021-07-08 Thread Tyler Retzlaff
On Thu, Jul 08, 2021 at 10:39:13PM +0200, Thomas Monjalon wrote: > 08/07/2021 21:21, Tyler Retzlaff: > > (2) importing exported data symbols from a dll/dso on windows requires > > that the symbol be decorated with dllimport. optionally loading > > performance of dll/dso is also further impr

Re: [dpdk-dev] [PATCH 2/3] net/bonding: fix not checked return value

2021-07-08 Thread Min Hu (Connor)
在 2021/7/8 21:20, Havlík Martin 写道: Dne 2021-07-08 14:43, Min Hu (Connor) napsal: 在 2021/6/22 17:25, Martin Havlik 写道: Return value from bond_ethdev_8023ad_flow_set() is now checked and appropriate message is logged on error. Fixes: 112891cd27e5 ("net/bonding: add dedicated HW queues for LA

[dpdk-dev] [PATCH] net/bnxt: fix missing barriers in completion handling

2021-07-08 Thread Lance Richardson
Ensure that Rx/Tx/Async completion entry fields are accessed only after the completion's valid flag has been loaded and verified. This is needed for correct operation on systems that use relaxed memory consistency models. Fixes: 2eb53b134aae ("net/bnxt: add initial Rx code") Fixes: 6eb3cc2294fd ("

Re: [dpdk-dev] RFC enabling dll/dso for dpdk on windows

2021-07-08 Thread Dmitry Kozlyuk
Hi Tyler, 2021-07-08 12:21 (UTC-0700), Tyler Retzlaff: > hi folks, > > we would like to submit a a patch series that makes dll/dso for dpdk > work on windows. there are two differences in the windows platform that > would need to be address through enhancements to dpdk. > > (1) windows dynamic o

Re: [dpdk-dev] [PATCH v6 1/2] power: add support for cppc cpufreq

2021-07-08 Thread David Marchand
On Thu, Jul 8, 2021 at 3:30 PM David Marchand wrote: > > On Thu, Jul 8, 2021 at 4:35 AM Richael Zhuang wrote: > > > > Currently in DPDK only acpi_cpufreq and pstate_cpufreq drivers are > > supported, which are both not available on arm64 platforms. Add > > support for cppc_cpufreq driver which wo

Re: [dpdk-dev] [PATCH v7 1/2] power: don't use rte prefix in internal code

2021-07-08 Thread David Marchand
On Thu, Jul 8, 2021 at 5:39 PM David Hunt wrote: > > From: Anatoly Burakov > > Currently, ACPI code uses rte_power_info as the struct name, which > gives the appearance that this is an externally visible API. Fix to > use internal namespace. > > Signed-off-by: Anatoly Burakov > Acked-by: David H

Re: [dpdk-dev] RFC enabling dll/dso for dpdk on windows

2021-07-08 Thread Thomas Monjalon
08/07/2021 21:21, Tyler Retzlaff: > (2) importing exported data symbols from a dll/dso on windows requires > that the symbol be decorated with dllimport. optionally loading > performance of dll/dso is also further improved by decorating > exported function symbols. [3] > > for (2) we w

Re: [dpdk-dev] [pull-request] next-crypto 21.08 rc1

2021-07-08 Thread David Marchand
On Thu, Jul 8, 2021 at 7:14 PM Ali Alnubani wrote: > """ > $ meson --werror -Dc_args='-DRTE_ENABLE_ASSERT' --buildtype=debug build && > ninja -C build > ... > ../../root/dpdk/drivers/crypto/cnxk/cn10k_cryptodev_ops.c: In function > 'cn10k_cpt_sec_post_process': > ../../root/dpdk/drivers/crypto/c

Re: [dpdk-dev] [PATCH v2 01/20] crypto/cnxk: add driver skeleton

2021-07-08 Thread David Marchand
On Thu, Jul 8, 2021 at 7:08 PM Ali Alnubani wrote: > > -Original Message- > > From: dev On Behalf Of Anoob Joseph > > Sent: Friday, June 25, 2021 8:56 AM > > To: Akhil Goyal ; NBU-Contact-Thomas Monjalon > > > > Cc: Ankur Dwivedi ; Jerin Jacob > > ; Tejasree Kondoj ; > > dev@dpdk.org; An

[dpdk-dev] RFC enabling dll/dso for dpdk on windows

2021-07-08 Thread Tyler Retzlaff
hi folks, we would like to submit a a patch series that makes dll/dso for dpdk work on windows. there are two differences in the windows platform that would need to be address through enhancements to dpdk. (1) windows dynamic objects don't export sufficient information for tls variables and t

Re: [dpdk-dev] [PATCH v2 00/58] enhancements to host based flow table management

2021-07-08 Thread Ajit Khaparde
On Thu, Jul 8, 2021 at 5:51 AM Thomas Monjalon wrote: > 08/07/2021 05:57, Ajit Khaparde: > > On Wed, Jul 7, 2021 at 1:43 AM Thomas Monjalon > wrote: > > > 15/06/2021 21:33, Ajit Khaparde: > > > > On Sat, Jun 12, 2021 at 5:06 PM Ajit Khaparde > > > > wrote: > > > > > > > > > > This patchset adds

Re: [dpdk-dev] [PATCH] dmadev: introduce DMA device library

2021-07-08 Thread Jerin Jacob
On Thu, Jul 8, 2021 at 8:41 AM fengchengwen wrote: > > >>> > >>> It's just more conditionals and branches all through the code. Inside the > >>> user application, the user has to check whether to set the flag or not (or > >>> special-case the last transaction outside the loop), and within the >

Re: [dpdk-dev] [PATCH v3 2/2] net/i40e: replace SMP barrier with thread fence

2021-07-08 Thread Lance Richardson
On Thu, Jul 8, 2021 at 8:09 AM Zhang, Qi Z wrote: > > > > > -Original Message- > > From: Joyce Kong > > Sent: Tuesday, July 6, 2021 2:54 PM > > To: Xing, Beilei ; Zhang, Qi Z > > ; > > ruifeng.w...@arm.com; honnappa.nagaraha...@arm.com; Richardson, Bruce > > ; Zhang, Helin > > Cc: dev@d

Re: [dpdk-dev] [pull-request] next-crypto 21.08 rc1

2021-07-08 Thread Ali Alnubani
Hi, > -Original Message- > From: dev On Behalf Of Akhil Goyal > Sent: Wednesday, July 7, 2021 10:31 PM > To: NBU-Contact-Thomas Monjalon > Cc: dev@dpdk.org > Subject: [dpdk-dev] [pull-request] next-crypto 21.08 rc1 > > crypto/cnxk: add IPsec datapath I don't have this patch in

Re: [dpdk-dev] [PATCH v2 01/20] crypto/cnxk: add driver skeleton

2021-07-08 Thread Ali Alnubani
Hi, > -Original Message- > From: dev On Behalf Of Anoob Joseph > Sent: Friday, June 25, 2021 8:56 AM > To: Akhil Goyal ; NBU-Contact-Thomas Monjalon > > Cc: Ankur Dwivedi ; Jerin Jacob > ; Tejasree Kondoj ; > dev@dpdk.org; Anoob Joseph ; Archana Muniganti > > Subject: [dpdk-dev] [PATCH

Re: [dpdk-dev] Use WFE for spinlock and ring

2021-07-08 Thread Honnappa Nagarahalli
> > > > On Sun, 25 Apr 2021 05:56:51 + > > Ruifeng Wang wrote: > > > > > The rte_wait_until_equal_xxx APIs abstract the functionality of > > > 'polling for a memory location to become equal to a given value'[1]. > > > > > > Use the API for the rte spinlock and ring implementations. > > > Wit

Re: [dpdk-dev] [PATCH v8 1/7] power_intrinsics: use callbacks for comparison

2021-07-08 Thread McDaniel, Timothy
> -Original Message- > From: Burakov, Anatoly > Sent: Thursday, July 8, 2021 9:14 AM > To: dev@dpdk.org; McDaniel, Timothy ; Xing, > Beilei ; Wu, Jingjing ; Yang, > Qiming ; Zhang, Qi Z ; Wang, > Haiyue ; Matan Azrad ; Shahaf > Shuler ; Viacheslav Ovsiienko ; > Richardson, Bruce ; Anany

Re: [dpdk-dev] [PATCH v4 1/2] common/mlx5: add provider query port support to glue library

2021-07-08 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Slava Ovsiienko > Sent: Wednesday, July 7, 2021 6:54 PM > To: dev@dpdk.org > Cc: Raslan Darawsheh ; Matan Azrad > ; NBU-Contact-Thomas Monjalon > ; david.march...@redhat.com; sta...@dpdk.org > Subject: [PATCH v4 1/2] common/mlx5: add provider query port su

[dpdk-dev] [PATCH v7 1/2] power: don't use rte prefix in internal code

2021-07-08 Thread David Hunt
From: Anatoly Burakov Currently, ACPI code uses rte_power_info as the struct name, which gives the appearance that this is an externally visible API. Fix to use internal namespace. Signed-off-by: Anatoly Burakov Acked-by: David Hunt --- lib/power/power_acpi_cpufreq.c | 34 +---

[dpdk-dev] [PATCH v7 2/2] power: refactor pstate and acpi code

2021-07-08 Thread David Hunt
From: Anatoly Burakov Currently, ACPI and PSTATE modes have lots of code duplication, confusing logic, and a bunch of other issues that can, and have, led to various bugs and resource leaks. This commit factors out the common parts of sysfs reading/writing for ACPI and PSTATE drivers. Signed-of

[dpdk-dev] [PATCH v6 15/15] test/crypto: add data-unit and wrapped vectors

2021-07-08 Thread Shiri Kuzin
The AES-XTS algorithm supports using a wrapped key. In AES-XTS the data-unit defines the data block size to be encrypted\decrypted. Add AES-XTS vectors with a wrapped key. Add a variable stating whether the key is wrapped or not. Add the AES-XTS data-unit. Signed-off-by: Shiri Kuzin --- app/tes

[dpdk-dev] [PATCH v6 14/15] test/crypto: add mlx5 crypto driver

2021-07-08 Thread Shiri Kuzin
In order to test the new mlx5 crypto PMD, the driver is added to the crypto test application. Signed-off-by: Shiri Kuzin --- app/test/test_cryptodev.c | 7 +++ app/test/test_cryptodev.h | 1 + doc/guides/cryptodevs/mlx5.rst | 3 +++ 3 files changed, 11 insertions(+) diff --git a/a

[dpdk-dev] [PATCH v6 13/15] crypto/mlx5: add statistic get and reset operations

2021-07-08 Thread Shiri Kuzin
From: Suanming Mou This commit adds mlx5 crypto statistic get and reset operations. Signed-off-by: Suanming Mou Signed-off-by: Matan Azrad --- drivers/crypto/mlx5/mlx5_crypto.c | 40 --- 1 file changed, 37 insertions(+), 3 deletions(-) diff --git a/drivers/crypto/

[dpdk-dev] [PATCH v6 12/15] crypto/mlx5: add enqueue and dequeue operations

2021-07-08 Thread Shiri Kuzin
From: Suanming Mou The crypto operations are done with the WQE set which contains one UMR WQE and one rdma write WQE. Most segments of the WQE set are initialized properly during queue setup, only limited segments are initialized according to the crypto detail in the datapath process. This commi

[dpdk-dev] [PATCH v6 11/15] crypto/mlx5: add WQE set initialization

2021-07-08 Thread Shiri Kuzin
From: Suanming Mou Currently, HW handles the WQEs much faster than the software, Using the constant WQE set layout can initialize most of the WQE segments in advanced, and software only needs to configure very limited segments in datapath. This accelerates the software WQE organize in datapath.

[dpdk-dev] [PATCH v6 10/15] crypto/mlx5: add maximum segments devarg

2021-07-08 Thread Shiri Kuzin
From: Suanming Mou The mlx5 HW crypto operations are done by attaching crypto property to a memory region. Once done, every access to the memory via the crypto-enabled memory region will result with in-line encryption or decryption of the data. As a result, the design choice is to provide two ty

[dpdk-dev] [PATCH v6 09/15] crypto/mlx5: add keytag devarg

2021-07-08 Thread Shiri Kuzin
From: Suanming Mou A keytag is a piece of data encrypted together with a DEK. When a DEK is referenced by an MKEY.bsf through its index, the keytag is also supplied in the BSF as plaintext. The HW will decrypt the DEK (and the attached keytag) and will fail the operation if the keytags don't mat

[dpdk-dev] [PATCH v6 08/15] crypto/mlx5: create login object using DevX

2021-07-08 Thread Shiri Kuzin
To work with crypto engines that are marked with wrapped_import_method, a login session is required. A crypto login object needs to be created using DevX. The crypto login object contains: - The credential pointer. - The import_KEK pointer to be used for all secured information

[dpdk-dev] [PATCH v6 07/15] crypto/mlx5: add memory region management

2021-07-08 Thread Shiri Kuzin
Mellanox user space drivers don't deal with physical addresses as part of a memory protection mechanism. The device translates the given virtual address to a physical address using the given memory key as an address space identifier. That's why any mbuf virtual address is moved directly to the HW d

[dpdk-dev] [PATCH v6 06/15] crypto/mlx5: add dev stop and start operations

2021-07-08 Thread Shiri Kuzin
Add the dev_start function that is used to start a configured device. Add the dev_stop function that is used to stop a configured device. Both functions set the dev parameter as used and return 0. Signed-off-by: Shiri Kuzin Acked-by: Matan Azrad --- drivers/crypto/mlx5/mlx5_crypto.c | 17 +

[dpdk-dev] [PATCH v6 05/15] crypto/mlx5: add queue pairs operations

2021-07-08 Thread Shiri Kuzin
The HW queue pairs are a pair of send queue and receive queue of independent work queues packed together in one object for the purpose of transferring data between nodes of a network. Completion Queue is a FIFO queue of completed work requests. In crypto driver we use one QP in loopback in order

[dpdk-dev] [PATCH v6 04/15] crypto/mlx5: add basic operations

2021-07-08 Thread Shiri Kuzin
The basic dev control operations are configure, close and get info. Extended the existing support of configure and close: -mlx5_crypto_dev_configure- function used to configure device. -mlx5_crypto_dev_close- function used to close a configured device. Added config struc

[dpdk-dev] [PATCH v6 03/15] crypto/mlx5: add session operations

2021-07-08 Thread Shiri Kuzin
Sessions are used in symmetric transformations in order to prepare objects and data for packet processing stage. A mlx5 session includes iv_offset, pointer to mlx5_crypto_dek struct, bsf_size, bsf_p_type, block size index, encryption_order and encryption standard. Implement the next session opera

[dpdk-dev] [PATCH v6 02/15] crypto/mlx5: add DEK object management

2021-07-08 Thread Shiri Kuzin
A DEK(Data encryption Key) is an mlx5 HW object which represents the cipher algorithm key. The DEKs are used during data encryption/decryption operations. In symmetric algorithms like AES-STS, we use the same DEK for both encryption and decryption. Use the mlx5 hash-list tool to manage the DEK ob

[dpdk-dev] [PATCH v6 01/15] drivers: introduce mlx5 crypto PMD

2021-07-08 Thread Shiri Kuzin
Add a new PMD for Mellanox devices- crypto PMD. The crypto PMD will be supported starting Nvidia ConnectX6 and BlueField2. The crypto PMD will add the support of encryption and decryption using the AES-XTS symmetric algorithm. The crypto PMD requires rdma-core and uses mlx5 DevX. This patch add

[dpdk-dev] [PATCH v6 00/15] drivers: introduce mlx5 crypto PMD

2021-07-08 Thread Shiri Kuzin
Add a new PMD for Nvidia devices- crypto PMD. The crypto PMD will be supported on Nvidia ConnectX6. The crypto PMD will add the support of encryption and decryption using the AES-XTS symmetric algorithm. The crypto PMD requires rdma-core and uses mlx5 DevX. v2: Add data-path part. v3: Rebase. v4

Re: [dpdk-dev] [PATCH v3 2/2] net/i40e: replace SMP barrier with thread fence

2021-07-08 Thread Honnappa Nagarahalli
> > > > > > > > Simply replace the SMP barrier with atomic thread fence for i40e > > > > hw ring > > sacn, > > > > if there is no synchronization point. > > > > > > > > Signed-off-by: Joyce Kong > > > > Reviewed-by: Ruifeng Wang > > > > --- > > > > drivers/net/i40e/i40e_rxtx.c | 3 ++- > > > >

Re: [dpdk-dev] [PATCH v3 2/2] net/i40e: replace SMP barrier with thread fence

2021-07-08 Thread Zhang, Qi Z
> -Original Message- > From: Lance Richardson > Sent: Thursday, July 8, 2021 9:51 PM > To: Zhang, Qi Z > Cc: Joyce Kong ; Xing, Beilei ; > ruifeng.w...@arm.com; honnappa.nagaraha...@arm.com; Richardson, Bruce > ; Zhang, Helin ; > dev@dpdk.org; sta...@dpdk.org; n...@arm.com > Subject: Re

[dpdk-dev] [PATCH v8 7/7] l3fwd-power: support multiqueue in PMD pmgmt modes

2021-07-08 Thread Anatoly Burakov
Currently, l3fwd-power enforces the limitation of having one queue per lcore. This is no longer necessary, so remove the limitation. Signed-off-by: Anatoly Burakov --- examples/l3fwd-power/main.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/examples/l3fwd-power/main.c b/examples/l3fw

[dpdk-dev] [PATCH v8 6/7] power: support monitoring multiple Rx queues

2021-07-08 Thread Anatoly Burakov
Use the new multi-monitor intrinsic to allow monitoring multiple ethdev Rx queues while entering the energy efficient power state. The multi version will be used unconditionally if supported, and the UMWAIT one will only be used when multi-monitor is not supported by the hardware. Signed-off-by: A

[dpdk-dev] [PATCH v8 5/7] power: support callbacks for multiple Rx queues

2021-07-08 Thread Anatoly Burakov
Currently, there is a hard limitation on the PMD power management support that only allows it to support a single queue per lcore. This is not ideal as most DPDK use cases will poll multiple queues per core. The PMD power management mechanism relies on ethdev Rx callbacks, so it is very difficult

[dpdk-dev] [PATCH v8 4/7] power: remove thread safety from PMD power API's

2021-07-08 Thread Anatoly Burakov
Currently, we expect that only one callback can be active at any given moment, for a particular queue configuration, which is relatively easy to implement in a thread-safe way. However, we're about to add support for multiple queues per lcore, which will greatly increase the possibility of various

[dpdk-dev] [PATCH v8 3/7] eal: add power monitor for multiple events

2021-07-08 Thread Anatoly Burakov
Use RTM and WAITPKG instructions to perform a wait-for-writes similar to what UMWAIT does, but without the limitation of having to listen for just one event. This works because the optimized power state used by the TPAUSE instruction will cause a wake up on RTM transaction abort, so if we add the a

[dpdk-dev] [PATCH v8 2/7] net/af_xdp: add power monitor support

2021-07-08 Thread Anatoly Burakov
Implement support for .get_monitor_addr in AF_XDP driver. Signed-off-by: Anatoly Burakov --- Notes: v8: - Fix checkpatch issue v2: - Rewrite using the callback mechanism drivers/net/af_xdp/rte_eth_af_xdp.c | 34 + 1 file changed, 34 insertions(+

[dpdk-dev] [PATCH v8 1/7] power_intrinsics: use callbacks for comparison

2021-07-08 Thread Anatoly Burakov
Previously, the semantics of power monitor were such that we were checking current value against the expected value, and if they matched, then the sleep was aborted. This is somewhat inflexible, because it only allowed us to check for a specific value in a specific way. This commit replaces the co

[dpdk-dev] [PATCH v8 0/7] Enhancements for PMD power management

2021-07-08 Thread Anatoly Burakov
This patchset introduces several changes related to PMD power management: - Changed monitoring intrinsics to use callbacks as a comparison function, based on previous patchset [1] but incorporating feedback [2] - this hopefully will make it possible to add support for .get_monitor_addr in virt

Re: [dpdk-dev] [EXT] [PATCH] test: fix crypto_op length for sessionless case

2021-07-08 Thread Gujjar, Abhinandan S
Hi Akhil, > -Original Message- > From: Akhil Goyal > Sent: Wednesday, July 7, 2021 7:38 PM > To: Gujjar, Abhinandan S ; dev@dpdk.org; > Jerin Jacob Kollanukkaran > Cc: Power, Ciara > Subject: RE: [EXT] [PATCH] test: fix crypto_op length for sessionless case > > Hi Abhinandan, > > > Cu

[dpdk-dev] [PATCH v2] net/vmxnet3: add interrupt support in MSI-X

2021-07-08 Thread Jochen Behrens
Add support for MSI-X interrupt vectors to the vmxnet3 driver. This will allow more efficient deployments in cloud environments. By default it will try to allocate 1 vector (0) for link event and one MSI-X vector for each Rx queue. To simplify things, it will only be enabled if the number of Tx a

Re: [dpdk-dev] [PATCH v2 1/3] vhost: add unsafe API to drain pkts in async vhost

2021-07-08 Thread Hu, Jiayu
Hi Maxime, > -Original Message- > From: Maxime Coquelin > Sent: Tuesday, July 6, 2021 10:09 PM > To: Jiang, Cheng1 ; Xia, Chenbo > > Cc: dev@dpdk.org; Hu, Jiayu ; Yang, YvonneX > > Subject: Re: [PATCH v2 1/3] vhost: add unsafe API to drain pkts in async vhost > > > > On 6/15/21 4:15

Re: [dpdk-dev] [PATCH v6 1/2] power: add support for cppc cpufreq

2021-07-08 Thread David Marchand
On Thu, Jul 8, 2021 at 4:35 AM Richael Zhuang wrote: > > Currently in DPDK only acpi_cpufreq and pstate_cpufreq drivers are > supported, which are both not available on arm64 platforms. Add > support for cppc_cpufreq driver which works on most arm64 platforms. Worth a release note update. WDYT of

Re: [dpdk-dev] [PATCH v6 2/2] power: refactor pstate and acpi code

2021-07-08 Thread David Hunt
On 8/7/2021 1:49 PM, David Marchand wrote: On Wed, Jun 23, 2021 at 2:04 PM David Hunt wrote: From: Anatoly Burakov Currently, ACPI and PSTATE modes have lots of code duplication, confusing logic, and a bunch of other issues that can, and have, led to various bugs and resource leaks. This c

Re: [dpdk-dev] [PATCH 2/3] net/bonding: fix not checked return value

2021-07-08 Thread Havlík Martin
Dne 2021-07-08 14:43, Min Hu (Connor) napsal: 在 2021/6/22 17:25, Martin Havlik 写道: Return value from bond_ethdev_8023ad_flow_set() is now checked and appropriate message is logged on error. Fixes: 112891cd27e5 ("net/bonding: add dedicated HW queues for LACP control") Cc: tomaszx.kula...@intel

Re: [dpdk-dev] [PATCH v15] app/testpmd: support multi-process

2021-07-08 Thread Min Hu (Connor)
Hi,Andrew , 在 2021/7/8 20:30, Andrew Rybchenko 写道: On 7/8/21 3:20 PM, Min Hu (Connor) wrote: Hi, Andrew , 在 2021/7/2 20:47, Andrew Rybchenko 写道: On 7/2/21 3:09 PM, Andrew Rybchenko wrote: From: "Min Hu (Connor)" For example the following commands run two testpmd processes:   * the primar

Re: [dpdk-dev] [PATCH v2 00/58] enhancements to host based flow table management

2021-07-08 Thread Thomas Monjalon
08/07/2021 05:57, Ajit Khaparde: > On Wed, Jul 7, 2021 at 1:43 AM Thomas Monjalon wrote: > > 15/06/2021 21:33, Ajit Khaparde: > > > On Sat, Jun 12, 2021 at 5:06 PM Ajit Khaparde > > > wrote: > > > > > > > > This patchset adds flow table management support for > > > > Thor network adapter and intr

Re: [dpdk-dev] [PATCH v6 2/2] power: refactor pstate and acpi code

2021-07-08 Thread David Marchand
On Wed, Jun 23, 2021 at 2:04 PM David Hunt wrote: > > From: Anatoly Burakov > > Currently, ACPI and PSTATE modes have lots of code duplication, > confusing logic, and a bunch of other issues that can, and have, led to > various bugs and resource leaks. > > This commit factors out the common parts

Re: [dpdk-dev] [PATCH 2/3] net/bonding: fix not checked return value

2021-07-08 Thread Min Hu (Connor)
在 2021/6/22 17:25, Martin Havlik 写道: Return value from bond_ethdev_8023ad_flow_set() is now checked and appropriate message is logged on error. Fixes: 112891cd27e5 ("net/bonding: add dedicated HW queues for LACP control") Cc: tomaszx.kula...@intel.com Signed-off-by: Martin Havlik Cc: Jan Vi

Re: [dpdk-dev] [PATCH 1/3] net/bonding: fix proper return value check and correct log message

2021-07-08 Thread Min Hu (Connor)
The old code has just low-level error, which just copied the "printf" above. Thanks for your patch. Acked-by: Min Hu (Connor) 在 2021/6/22 17:25, Martin Havlik 写道: Return value is now saved to errval and log message on error reports correct function name, doesn't use q_id which was out of conte

Re: [dpdk-dev] [PATCH v15] app/testpmd: support multi-process

2021-07-08 Thread Andrew Rybchenko
On 7/8/21 3:20 PM, Min Hu (Connor) wrote: > Hi, Andrew , > > 在 2021/7/2 20:47, Andrew Rybchenko 写道: >> On 7/2/21 3:09 PM, Andrew Rybchenko wrote: >>> From: "Min Hu (Connor)" >>> >>> For example the following commands run two testpmd processes: >>> >>>   * the primary process: >>> >>> ./dpdk-testp

Re: [dpdk-dev] [PATCH v15] app/testpmd: support multi-process

2021-07-08 Thread Min Hu (Connor)
Hi, Andrew , 在 2021/7/2 20:47, Andrew Rybchenko 写道: On 7/2/21 3:09 PM, Andrew Rybchenko wrote: From: "Min Hu (Connor)" For example the following commands run two testpmd processes: * the primary process: ./dpdk-testpmd --proc-type=auto -l 0-1 -- -i \ --rxq=4 --txq=4 --num-procs=2 --pr

Re: [dpdk-dev] [PATCH v3 2/2] net/i40e: replace SMP barrier with thread fence

2021-07-08 Thread Zhang, Qi Z
> -Original Message- > From: Joyce Kong > Sent: Tuesday, July 6, 2021 2:54 PM > To: Xing, Beilei ; Zhang, Qi Z ; > ruifeng.w...@arm.com; honnappa.nagaraha...@arm.com; Richardson, Bruce > ; Zhang, Helin > Cc: dev@dpdk.org; sta...@dpdk.org; n...@arm.com > Subject: [PATCH v3 2/2] net/i40e

[dpdk-dev] [PATCH 2/2] crypto/cnxk: add dev start and dev stop

2021-07-08 Thread Ankur Dwivedi
The instruction queue is enabled in dev start and is disabled in dev stop. Signed-off-by: Ankur Dwivedi --- drivers/crypto/cnxk/cnxk_cryptodev_ops.c | 16 ++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/drivers/crypto/cnxk/cnxk_cryptodev_ops.c b/drivers/crypto/cn

[dpdk-dev] [PATCH 1/2] common/cnxk: move instruction queue enable to roc API

2021-07-08 Thread Ankur Dwivedi
The code for enabling instruction queue is moved to roc API. Signed-off-by: Ankur Dwivedi --- drivers/common/cnxk/roc_cpt.c | 41 - drivers/common/cnxk/roc_cpt.h | 1 + drivers/common/cnxk/version.map | 1 + 3 files changed, 27 insertions(+), 16 deletions(-)

[dpdk-dev] [PATCH 0/2] add dev start and dev stop ops in cnxk crypto PMD

2021-07-08 Thread Ankur Dwivedi
The dev start and dev stop ops are added in cnxk crypto PMD. The instruction queues are enabled in dev start and disabled in dev stop. Ankur Dwivedi (2): common/cnxk: move instruction queue enable to roc API crypto/cnxk: add dev start and dev stop drivers/common/cnxk/roc_cpt.c| 4

[dpdk-dev] [PATCH v3] eal: allow hugetlbfs sub-directories

2021-07-08 Thread John Levon
get_hugepage_dir() was implemented in such a way that a --huge-dir option had to exactly match the mountpoint, but there's no reason for this restriction. Fix the implementation to allow a sub-directory within a suitable hugetlbfs mountpoint to be specified, preferring the closest match. Signed-of

[dpdk-dev] [PATCH] vhost: fix index overflow issue in async vhost

2021-07-08 Thread Cheng Jiang
We introduced some new indexes in async vhost. If we don't pay attention to the management of these indexes, they will eventually overflow and lead to errors. This patch is to check and keep these indexes within a reasonable range. Fixes: 873e8dad6f49 ("vhost: support packed ring in async datapath

[dpdk-dev] [PATCH] vhost: fix async packed ring batch datapath

2021-07-08 Thread Cheng Jiang
We assume that in the sync path, if there is no buffer wrap in the avail descriptors fetched in a batch, there is no buffer wrap in the used descriptors which need to be written back in this batch, but this assumption is wrong in the async path since there are inflight descriptors which are process

Re: [dpdk-dev] [PATCH v6] ethdev: add new ext hdr for gtp psc

2021-07-08 Thread Thomas Monjalon
08/07/2021 11:39, Andrew Rybchenko: > On 7/8/21 12:27 PM, Raslan Darawsheh wrote: > > Thank you for the review, > > > > Basically it's not used yet since it will break the abi > > The main usage was in rte_flow item of gtp_psc > > To replace the current structure with the header definition. And si

Re: [dpdk-dev] [PATCH v4 3/3] build: add option to enable wait until equal

2021-07-08 Thread Thomas Monjalon
08/07/2021 11:21, Ruifeng Wang: > From: Thomas Monjalon > > 08/07/2021 08:32, Jerin Jacob: > > > On Thu, Jul 8, 2021 at 11:55 AM Ruifeng Wang > > wrote: > > > > From: Jerin Jacob > > > > > On Wed, Jul 7, 2021 at 5:57 PM Bruce Richardson > > > > > wrote: > > > > > > On Wed, Jul 07, 2021 at 06:46

[dpdk-dev] [PATCH] net/virtio: fix refill order in packed ring datapath

2021-07-08 Thread Cheng Jiang
The front-end should refill the descriptor with the mbuf indicated by the buff_id rather then the index of used descriptor. Back-end may return buffers out of order if async copy mode is enabled. When initializing rxq, refill the descriptors in order as buff_id is not available at that time. Fixe

Re: [dpdk-dev] [PATCH v8 00/19] net: ngbe PMD

2021-07-08 Thread Andrew Rybchenko
On 7/8/21 12:32 PM, Jiawen Wu wrote: > This patch set provides a skeleton of ngbe PMD, > which adapted to Wangxun WX1860 series NICs. Applied, thanks.

[dpdk-dev] [PATCH V2] pipeline: add support for LPM lookup

2021-07-08 Thread Cristian Dumitrescu
Add support for the Longest Prefix Match (LPM) lookup to the SWX pipeline. Signed-off-by: Cristian Dumitrescu Signed-off-by: Churchill Khangar --- Depends-on: series-17609 ("examples/pipeline: improve table update CLI commands") Depends-on: patch-17642 ("[V2] pipeline: fix table entry read")

Re: [dpdk-dev] [PATCH V3] ethdev: add dev configured flag

2021-07-08 Thread David Marchand
On Wed, Jul 7, 2021 at 11:54 AM Huisong Li wrote: > > Currently, if dev_configure is not called or fails to be called, users > can still call dev_start successfully. So it is necessary to have a flag > which indicates whether the device is configured, to control whether > dev_start can be called a

Re: [dpdk-dev] [PATCH v2] ipc: stop mp control thread on cleanup

2021-07-08 Thread David Marchand
On Thu, Jul 8, 2021 at 9:23 AM Maxime Coquelin wrote: > On 7/7/21 1:02 PM, David Marchand wrote: > > When calling rte_eal_cleanup, the mp channel cleanup routine only sets > > mp_fd to -1 leaving the rte_mp_handle control thread running. > > This control thread can spew warnings on reading on an i

Re: [dpdk-dev] [PATCH v6] ethdev: add new ext hdr for gtp psc

2021-07-08 Thread Singh, Aman Deep
Thanks Raslan for the rfc link.The structure order for RTE_BIG_ENDIAN seems ok. I doubt for RTE_LITTLE_ENDIAN case, if there is a need to reverse the order of fields, as we are using uint8_t only. If you have already tested on x86 then it should be fine ? Regards Aman On 7/6/2021 7:54 PM, Rasl

  1   2   >