[dpdk-dev] 19.11.9 patches review and test - V2

2021-06-03 Thread Christian Ehrhardt
Hi all, Here is version 2 of the list of patches targeted for stable release 19.11.9. Thanks to plenty of helpful developers we've collected a few more backports by now and sorted out a few rare compile time issues that were found with -rc1. The planned date for the final release of 19.11.9 is no

Re: [dpdk-dev] [PATCH] gpudev: introduce memory API

2021-06-03 Thread Wang, Haiyue
> -Original Message- > From: dev On Behalf Of Thomas Monjalon > Sent: Thursday, June 3, 2021 04:36 > To: dev@dpdk.org > Cc: Elena Agostini > Subject: [dpdk-dev] [PATCH] gpudev: introduce memory API > > From: Elena Agostini > > The new library gpudev is for dealing with GPU from a DPDK

[dpdk-dev] [PATCH] eal/arm: enable FreeBSD build

2021-06-03 Thread Ruifeng Wang
Build on FreeBSD on aarch64 failed with error: lib/eal/arm/rte_cpuflags.c:86:9: error: unknown type name 'Elf64_auxv_t' The data type is used by OS Linux auxiliary vector read, and not used by arch specific cpu flag API implementations. Hence remove it from Arm file. Reported-by: James Grant Sig

Re: [dpdk-dev] [PATCH v2] ethdev: add IPv4 checksum RSS offload type

2021-06-03 Thread Zhang, AlvinX
> > This patch defines new RSS offload type for IPv4 checksum, which is > > required when users want to distribute packets based on the IPv4 > > checksum field. > > > > For example "flow create 0 ingress pattern eth / ipv4 / end actions > > rss types ipv4-chksum end queues end / end", this flow cau

Re: [dpdk-dev] [PATCH v7 2/3] net/iavf: enable PCI bus master after reset

2021-06-03 Thread Xing, Beilei
> -Original Message- > From: Wang, Haiyue > Sent: Monday, May 24, 2021 9:24 AM > To: dev@dpdk.org > Cc: Zhang, Qi Z ; Wang, Liang-min min.w...@intel.com>; david.march...@redhat.com; Wang, Haiyue > ; Wu, Jingjing ; Xing, Beilei > > Subject: [PATCH v7 2/3] net/iavf: enable PCI bus maste

[dpdk-dev] [PATCH] net/i40e: fix using heap pointer after free

2021-06-03 Thread dapengx . yu
From: Dapeng Yu The original code use a heap pointer after it is freed. Fixes: 460d1679586e ("drivers/net: delete HW rings while freeing queues") Cc: sta...@dpdk.org Signed-off-by: Dapeng Yu --- drivers/net/i40e/i40e_fdir.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [dpdk-dev] [PATCH v7 3/3] net/i40e: enable PCI bus master after reset

2021-06-03 Thread Xing, Beilei
> -Original Message- > From: Wang, Haiyue > Sent: Monday, May 24, 2021 9:24 AM > To: dev@dpdk.org > Cc: Zhang, Qi Z ; Wang, Liang-min min.w...@intel.com>; david.march...@redhat.com; Wang, Haiyue > ; Xing, Beilei > Subject: [PATCH v7 3/3] net/i40e: enable PCI bus master after reset >

Re: [dpdk-dev] [PATCH v2 2/2] eal: handle compressed firmwares

2021-06-03 Thread Dmitry Kozlyuk
2021-06-03 18:55 (UTC+0200), David Marchand: [...] > diff --git a/config/meson.build b/config/meson.build > index 017bb2efbb..c6985139b4 100644 > --- a/config/meson.build > +++ b/config/meson.build > @@ -172,6 +172,13 @@ if libexecinfo.found() and cc.has_header('execinfo.h') > dpdk_extra_ldfla

Re: [dpdk-dev] [Bug 725] hugepages.py script broken

2021-06-03 Thread Stephen Hemminger
On Thu, 03 Jun 2021 15:08:52 + bugzi...@dpdk.org wrote: > https://bugs.dpdk.org/show_bug.cgi?id=725 > > Bug ID: 725 >Summary: hugepages.py script broken >Product: DPDK >Version: unspecified > Hardware: All > OS: All >

Re: [dpdk-dev] code.dpdk.org bugfix releases

2021-06-03 Thread Morten Brørup
> From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Thursday, 3 June 2021 21.18 k-dev] code.dpdk.org bugfix releases > > 03/06/2021 20:15, Morten Brørup: > > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Thomas > Monjalon > > > Sent: Thursday, 3 June 2021 18.11 > > > > > > 03/06/

Re: [dpdk-dev] code.dpdk.org bugfix releases

2021-06-03 Thread Thomas Monjalon
03/06/2021 20:15, Morten Brørup: > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Thomas Monjalon > > Sent: Thursday, 3 June 2021 18.11 > > > > 03/06/2021 17:18, Morten Brørup: > > > Hi all, > > > > > > Bugfix releases are missing on code.dpdk.org. > > > > > > E.g. version 17.11 is present

[dpdk-dev] [dpdk-announce] CFP Due Friday! DPDK Summit North America

2021-06-03 Thread Jill Lovato
Hello DPDK Community, Speaking submissions for DPDK Summit North America (a virtual event taking place July 12-13), are due by 11:59pm PST this FRIDAY, JUNE 4. If you have not already, please get your submissions in, here: https://events.linuxfoundation.org/dpdk-summit-north-america/program/cfp/

[dpdk-dev] rte_mempool_create conflicting parameter advice

2021-06-03 Thread Morten Brørup
Olivier, Andrew (Memory pool maintainers) While reviewing documentation for the parameters to rte_mempool_create(), I noticed these two conflicting recommendations: 1. n (the number of elements in the pool) is advised to be a power of two minus one. 2. cache_size is advised to have "n modulo ca

Re: [dpdk-dev] code.dpdk.org bugfix releases

2021-06-03 Thread Morten Brørup
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Thomas Monjalon > Sent: Thursday, 3 June 2021 18.11 > > 03/06/2021 17:18, Morten Brørup: > > Hi all, > > > > Bugfix releases are missing on code.dpdk.org. > > > > E.g. version 17.11 is present, but version 17.11.10 is missing. > > > > Can whoe

[dpdk-dev] [PATCH 2/2] net/cxgbe: remove queue stats from basic stats

2021-06-03 Thread Rahul Lakkireddy
Remove queue stats from basic stats because they're now available via xstats API. Also remove RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS flag. Signed-off-by: Rahul Lakkireddy --- drivers/net/cxgbe/cxgbe_ethdev.c | 18 +++--- 1 file changed, 3 insertions(+), 15 deletions(-) diff --git a/drive

[dpdk-dev] [PATCH 1/2] net/cxgbe: add support for xstats API

2021-06-03 Thread Rahul Lakkireddy
Add support to fetch port and queue stats via xstats API. Signed-off-by: Rahul Lakkireddy --- drivers/net/cxgbe/cxgbe_ethdev.c | 302 ++- 1 file changed, 293 insertions(+), 9 deletions(-) diff --git a/drivers/net/cxgbe/cxgbe_ethdev.c b/drivers/net/cxgbe/cxgbe_ethdev.

[dpdk-dev] [PATCH 0/2] net/cxgbe: add support for xstats API

2021-06-03 Thread Rahul Lakkireddy
This series of patches add support to fetch port and queue stats via xstats API. Patch 1 adds support to fetch port and queue stats via xstats API. Patch 2 removes queue stats from basic stats since they're available via xstats API. Also removes RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS flag. Rahul Lakk

[dpdk-dev] [PATCH v2 2/2] eal: handle compressed firmwares

2021-06-03 Thread David Marchand
Introduce an internal firmware loading helper to remove code duplication in our drivers and handle xz compressed firmwares by calling libarchive. This helper tries to look for .xz suffixes so that drivers are not aware the firmwares have been compressed. libarchive is set as an optional dependenc

[dpdk-dev] [PATCH v2 1/2] net/ice: factorize firmware loading

2021-06-03 Thread David Marchand
Both "normal" and "dcf" inits have their copy of some firmware loading code. The DSN query is moved in specific parts for the "normal" and "dcf" init. A common helper ice_load_pkg is then introduced and takes an adapter pointer as its main input. This helper takes care of finding the right firmw

[dpdk-dev] [PATCH v2 0/2] Support compressed firmwares

2021-06-03 Thread David Marchand
Fedora 34 only provides compressed firmwares. Introduce an internal driver helper to handle transparently compression. I chose libarchive for decompressing as it seems widely available and DPDK had used it in the past. Windows support only matters for net/ice and firmware loading was skipped in

Re: [dpdk-dev] [PATCH] telemetry: remove static limit on callbacks count

2021-06-03 Thread David Marchand
On Thu, May 6, 2021 at 12:59 PM Power, Ciara wrote: > >This code is not performance sensitive and can be switched to dynamic > >allocations. > > > >Signed-off-by: David Marchand > Acked-by: Ciara Power Applied. -- David Marchand

Re: [dpdk-dev] [PATCH v2 0/2] bugfix for graph

2021-06-03 Thread David Marchand
On Thu, May 6, 2021 at 9:16 AM Min Hu (Connor) wrote: > > This patchset contains two bugfixes for graph. > > HongBo Zheng (2): > graph: fix memory leak > graph: fix dereferencing null pointer > > lib/graph/graph_stats.c | 7 +-- > 1 file changed, 5 insertions(+), 2 deletions(-) Series ap

Re: [dpdk-dev] [PATCH v4] test: remove strict timing requirements from alarm and cycles tests

2021-06-03 Thread David Marchand
On Thu, Jun 3, 2021 at 5:22 PM Aaron Conole wrote: > > The tests 'alarm_autotest' and 'cycles_autotest' rely on the underlying > system having very accurate and precise timing. On systems where the > timing isn't as rigid, or the load is particularly high, these tests are > unreliable since the w

Re: [dpdk-dev] [PATCH] net/ice: fix wrong data path selection in secondary process

2021-06-03 Thread Wang, Yixue
Hi, Qi I've tested this patch and it works. Best Regards, Yixue. > -Original Message- > From: Zhang, Qi Z > Sent: Monday, May 24, 2021 17:08 > To: Yang, Qiming > Cc: Zhang, Liheng ; Wang, Yixue > ; Dong, Yao ; dev@dpdk.org; > Zhang, Qi Z ; sta...@dpdk.org > Subject: [PATCH] net/ice: fi

Re: [dpdk-dev] [External] : Re: Problem while running dpdk

2021-06-03 Thread Raunak Laddha
Hi Bruce, Thank you for giving solution to my problem. I will try it and let you know if it works or not. Thanks, Raunak From: Bruce Richardson Sent: Tuesday, June 1, 2021 4:03 AM To: Raunak Laddha Cc: dev@dpdk.org ; Mike Banatt Subject: [External] : Re: [dpdk-

Re: [dpdk-dev] code.dpdk.org bugfix releases

2021-06-03 Thread Thomas Monjalon
03/06/2021 17:18, Morten Brørup: > Hi all, > > Bugfix releases are missing on code.dpdk.org. > > E.g. version 17.11 is present, but version 17.11.10 is missing. > > Can whoever is the maintainer of code.dpdk.org please fix this. Ali is the admin of dpdk.org. I'm not sure your request is easy be

[dpdk-dev] [PATCH v4] test: remove strict timing requirements from alarm and cycles tests

2021-06-03 Thread Aaron Conole
The tests 'alarm_autotest' and 'cycles_autotest' rely on the underlying system having very accurate and precise timing. On systems where the timing isn't as rigid, or the load is particularly high, these tests are unreliable since the wake latency from the scheduler can be high enough to miss the

[dpdk-dev] code.dpdk.org bugfix releases

2021-06-03 Thread Morten Brørup
Hi all, Bugfix releases are missing on code.dpdk.org. E.g. version 17.11 is present, but version 17.11.10 is missing. Can whoever is the maintainer of code.dpdk.org please fix this. -Morten

[dpdk-dev] [Bug 725] hugepages.py script broken

2021-06-03 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=725 Bug ID: 725 Summary: hugepages.py script broken Product: DPDK Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: N

Re: [dpdk-dev] [RFC 3/3] net/virtio: add MAC device config getter and setter

2021-06-03 Thread Maxime Coquelin
Hi Chenbo, On 4/19/21 8:24 AM, Xia, Chenbo wrote: > Hi Maxime, > >> -Original Message- >> From: Maxime Coquelin >> Sent: Friday, March 19, 2021 6:35 AM >> To: dev@dpdk.org; Xia, Chenbo ; amore...@redhat.com; >> david.march...@redhat.com >> Cc: Maxime Coquelin >> Subject: [RFC 3/3] net/v

[dpdk-dev] [PATCH v3] test: remove strict timing requirements from alarm and cycles tests

2021-06-03 Thread Aaron Conole
The tests 'alarm_autotest' and 'cycles_autotest' rely on the underlying system having very accurate and precise timing. On systems where the timing isn't as rigid, or the load is particularly high, these tests are unreliable since the wake latency from the scheduler can be high enough to miss the

Re: [dpdk-dev] [PATCH] gpudev: introduce memory API

2021-06-03 Thread Jerin Jacob
On Thu, Jun 3, 2021 at 4:00 PM Thomas Monjalon wrote: > > 03/06/2021 12:04, Jerin Jacob: > > On Thu, Jun 3, 2021 at 3:06 PM Thomas Monjalon wrote: > > > > > > 03/06/2021 11:20, Jerin Jacob: > > > > On Thu, Jun 3, 2021 at 2:23 PM Thomas Monjalon > > > > wrote: > > > > > > > > > > 03/06/2021 10:4

Re: [dpdk-dev] [RFC PATCH] ethdev: clarify flow action PORT ID semantics

2021-06-03 Thread Ivan Malov
On 03/06/2021 12:29, Ilya Maximets wrote: On 6/2/21 9:35 PM, Ivan Malov wrote: On 02/06/2021 20:35, Ilya Maximets wrote: (Dropped Broadcom folks from CC.  Mail server refuses to accept their emails for some reason: "Recipient address rejected: Domain not found." Please, try to ad them back on r

Re: [dpdk-dev] [RFC PATCH] ethdev: clarify flow action PORT ID semantics

2021-06-03 Thread Ilya Maximets
On 6/3/21 12:33 PM, Andrew Rybchenko wrote: > On 6/3/21 12:29 PM, Ilya Maximets wrote: >> On 6/2/21 9:35 PM, Ivan Malov wrote: >>> On 02/06/2021 20:35, Ilya Maximets wrote: (Dropped Broadcom folks from CC.  Mail server refuses to accept their emails for some reason: "Recipient address rej

Re: [dpdk-dev] [RFC PATCH] ethdev: clarify flow action PORT ID semantics

2021-06-03 Thread Andrew Rybchenko
On 6/3/21 12:29 PM, Ilya Maximets wrote: > On 6/2/21 9:35 PM, Ivan Malov wrote: >> On 02/06/2021 20:35, Ilya Maximets wrote: >>> (Dropped Broadcom folks from CC.  Mail server refuses to accept their >>> emails for some reason: "Recipient address rejected: Domain not found." >>> Please, try to ad th

Re: [dpdk-dev] [PATCH] gpudev: introduce memory API

2021-06-03 Thread Thomas Monjalon
03/06/2021 12:04, Jerin Jacob: > On Thu, Jun 3, 2021 at 3:06 PM Thomas Monjalon wrote: > > > > 03/06/2021 11:20, Jerin Jacob: > > > On Thu, Jun 3, 2021 at 2:23 PM Thomas Monjalon > > > wrote: > > > > > > > > 03/06/2021 10:47, Jerin Jacob: > > > > > On Thu, Jun 3, 2021 at 2:13 PM Thomas Monjalon

Re: [dpdk-dev] [PATCH] net/ice: fix wrong data path selection in secondary process

2021-06-03 Thread Zhang, Qi Z
> -Original Message- > From: Wang, Yixue > Sent: Thursday, June 3, 2021 6:04 PM > To: Zhang, Qi Z ; Yang, Qiming > > Cc: Zhang, Liheng ; Dong, Yao > ; dev@dpdk.org; sta...@dpdk.org > Subject: RE: [PATCH] net/ice: fix wrong data path selection in secondary > process > > Hi, Qi > > I'v

Re: [dpdk-dev] [PATCH] gpudev: introduce memory API

2021-06-03 Thread Jerin Jacob
On Thu, Jun 3, 2021 at 3:06 PM Thomas Monjalon wrote: > > 03/06/2021 11:20, Jerin Jacob: > > On Thu, Jun 3, 2021 at 2:23 PM Thomas Monjalon wrote: > > > > > > 03/06/2021 10:47, Jerin Jacob: > > > > On Thu, Jun 3, 2021 at 2:13 PM Thomas Monjalon > > > > wrote: > > > > > > > > > > 03/06/2021 10:4

Re: [dpdk-dev] [RFC PATCH] ethdev: clarify flow action PORT ID semantics

2021-06-03 Thread Andrew Rybchenko
On 6/3/21 12:18 PM, Ori Kam wrote: > Hi All, > >> -Original Message- >> From: Ivan Malov >> >> On 02/06/2021 14:21, Eli Britstein wrote: >>> >>> On 6/2/2021 1:50 PM, Andrew Rybchenko wrote: External email: Use caution opening links or attachments On 6/2/21 12:57 PM, El

Re: [dpdk-dev] [PATCH] gpudev: introduce memory API

2021-06-03 Thread Thomas Monjalon
03/06/2021 11:20, Jerin Jacob: > On Thu, Jun 3, 2021 at 2:23 PM Thomas Monjalon wrote: > > > > 03/06/2021 10:47, Jerin Jacob: > > > On Thu, Jun 3, 2021 at 2:13 PM Thomas Monjalon > > > wrote: > > > > > > > > 03/06/2021 10:41, Jerin Jacob: > > > > > On Thu, Jun 3, 2021 at 1:58 PM Thomas Monjalon

Re: [dpdk-dev] [PATCH] gpudev: introduce memory API

2021-06-03 Thread Ferruh Yigit
On 6/3/2021 8:47 AM, Jerin Jacob wrote: > On Thu, Jun 3, 2021 at 2:05 AM Thomas Monjalon wrote: >> >> From: Elena Agostini >> >> The new library gpudev is for dealing with GPU from a DPDK application >> in a vendor-agnostic way. >> >> As a first step, the features are focused on memory management

Re: [dpdk-dev] [RFC PATCH] ethdev: clarify flow action PORT ID semantics

2021-06-03 Thread Ilya Maximets
On 6/2/21 9:35 PM, Ivan Malov wrote: > On 02/06/2021 20:35, Ilya Maximets wrote: >> (Dropped Broadcom folks from CC.  Mail server refuses to accept their >> emails for some reason: "Recipient address rejected: Domain not found." >> Please, try to ad them back on reply.) >> >> On 6/2/21 6:26 PM, And

Re: [dpdk-dev] [RFC PATCH] ethdev: add support for testpmd-compliant flow rule dumping

2021-06-03 Thread Ori Kam
Hi Andrew, > -Original Message- > From: Andrew Rybchenko > > Hi Ori, > > Cc Eli and Ilya since I think OvS could be interested in the feature. > > On 6/3/21 11:25 AM, Ori Kam wrote: > > Hi Andrew, > > > >> -Original Message- > >> From: Andrew Rybchenko > >> > >> Hi Ori, > >> >

Re: [dpdk-dev] [PATCH] gpudev: introduce memory API

2021-06-03 Thread Jerin Jacob
On Thu, Jun 3, 2021 at 2:23 PM Thomas Monjalon wrote: > > 03/06/2021 10:47, Jerin Jacob: > > On Thu, Jun 3, 2021 at 2:13 PM Thomas Monjalon wrote: > > > > > > 03/06/2021 10:41, Jerin Jacob: > > > > On Thu, Jun 3, 2021 at 1:58 PM Thomas Monjalon > > > > wrote: > > > > > > > > > > 03/06/2021 09:4

Re: [dpdk-dev] [RFC PATCH] ethdev: clarify flow action PORT ID semantics

2021-06-03 Thread Ori Kam
Hi All, > -Original Message- > From: Ivan Malov > > On 02/06/2021 14:21, Eli Britstein wrote: > > > > On 6/2/2021 1:50 PM, Andrew Rybchenko wrote: > >> External email: Use caution opening links or attachments > >> > >> > >> On 6/2/21 12:57 PM, Eli Britstein wrote: > >>> On 6/1/2021 5:53

Re: [dpdk-dev] [PATCH] gpudev: introduce memory API

2021-06-03 Thread Andrew Rybchenko
On 6/3/21 11:26 AM, Thomas Monjalon wrote: > 03/06/2021 09:49, Andrew Rybchenko: >> On 6/3/21 10:26 AM, Thomas Monjalon wrote: >>> 03/06/2021 09:06, Andrew Rybchenko: On 6/2/21 11:35 PM, Thomas Monjalon wrote: > + * Allocate a chunk of memory on the GPU. Looking a below function

Re: [dpdk-dev] [PATCH] gpudev: introduce memory API

2021-06-03 Thread Thomas Monjalon
03/06/2021 10:47, Jerin Jacob: > On Thu, Jun 3, 2021 at 2:13 PM Thomas Monjalon wrote: > > > > 03/06/2021 10:41, Jerin Jacob: > > > On Thu, Jun 3, 2021 at 1:58 PM Thomas Monjalon > > > wrote: > > > > > > > > 03/06/2021 09:47, Jerin Jacob: > > > > > On Thu, Jun 3, 2021 at 2:05 AM Thomas Monjalon

Re: [dpdk-dev] [PATCH] gpudev: introduce memory API

2021-06-03 Thread Jerin Jacob
On Thu, Jun 3, 2021 at 2:13 PM Thomas Monjalon wrote: > > 03/06/2021 10:41, Jerin Jacob: > > On Thu, Jun 3, 2021 at 1:58 PM Thomas Monjalon wrote: > > > > > > 03/06/2021 09:47, Jerin Jacob: > > > > On Thu, Jun 3, 2021 at 2:05 AM Thomas Monjalon > > > > wrote: > > > > > --- a/doc/api/doxy-api-in

[dpdk-dev] [PATCH v3] vhost: enable IOMMU for async vhost

2021-06-03 Thread xuan . ding
From: Xuan Ding For async copy, it is unsafe to directly use the physical address. And current address translation from GPA to HPA via SW also takes CPU cycles, these can all benefit from IOMMU. Since the existing DMA engine supports to use platform IOMMU, this patch enables IOMMU for async vhos

Re: [dpdk-dev] [PATCH] gpudev: introduce memory API

2021-06-03 Thread Thomas Monjalon
03/06/2021 10:41, Jerin Jacob: > On Thu, Jun 3, 2021 at 1:58 PM Thomas Monjalon wrote: > > > > 03/06/2021 09:47, Jerin Jacob: > > > On Thu, Jun 3, 2021 at 2:05 AM Thomas Monjalon > > > wrote: > > > > --- a/doc/api/doxy-api-index.md > > > > +++ b/doc/api/doxy-api-index.md > > > > @@ -21,6 +21,7 @

Re: [dpdk-dev] [RFC PATCH] ethdev: add support for testpmd-compliant flow rule dumping

2021-06-03 Thread Andrew Rybchenko
Hi Ori, Cc Eli and Ilya since I think OvS could be interested in the feature. On 6/3/21 11:25 AM, Ori Kam wrote: > Hi Andrew, > >> -Original Message- >> From: Andrew Rybchenko >> >> Hi Ori, >> >> On 6/2/21 4:32 PM, Ori Kam wrote: >>> Hi Ivan, >>> -Original Message- Fro

Re: [dpdk-dev] [PATCH] gpudev: introduce memory API

2021-06-03 Thread Jerin Jacob
On Thu, Jun 3, 2021 at 1:58 PM Thomas Monjalon wrote: > > 03/06/2021 09:47, Jerin Jacob: > > On Thu, Jun 3, 2021 at 2:05 AM Thomas Monjalon wrote: > > > --- a/doc/api/doxy-api-index.md > > > +++ b/doc/api/doxy-api-index.md > > > @@ -21,6 +21,7 @@ The public API headers are grouped by topics: > >

Re: [dpdk-dev] [PATCH] gpudev: introduce memory API

2021-06-03 Thread Thomas Monjalon
03/06/2021 09:47, Jerin Jacob: > On Thu, Jun 3, 2021 at 2:05 AM Thomas Monjalon wrote: > > --- a/doc/api/doxy-api-index.md > > +++ b/doc/api/doxy-api-index.md > > @@ -21,6 +21,7 @@ The public API headers are grouped by topics: > >[compressdev](@ref rte_compressdev.h), > >[compress]

Re: [dpdk-dev] [PATCH] gpudev: introduce memory API

2021-06-03 Thread Thomas Monjalon
03/06/2021 09:49, Andrew Rybchenko: > On 6/3/21 10:26 AM, Thomas Monjalon wrote: > > 03/06/2021 09:06, Andrew Rybchenko: > >> On 6/2/21 11:35 PM, Thomas Monjalon wrote: > >>> + * Allocate a chunk of memory on the GPU. > >> > >> Looking a below function it is required to clarify here if > >> the mem

Re: [dpdk-dev] [RFC PATCH] ethdev: add support for testpmd-compliant flow rule dumping

2021-06-03 Thread Ori Kam
Hi Andrew, > -Original Message- > From: Andrew Rybchenko > > Hi Ori, > > On 6/2/21 4:32 PM, Ori Kam wrote: > > Hi Ivan, > > > >> -Original Message- > >> From: Ivan Malov > >> > >> Hi Ori, > >> > >> Your review efforts are much appreciated. I understand your concern > >> about t

Re: [dpdk-dev] [PATCH v2] ethdev: add IPv4 checksum RSS offload type

2021-06-03 Thread Andrew Rybchenko
On 6/3/21 11:03 AM, Alvin Zhang wrote: > This patch defines new RSS offload type for IPv4 checksum, > which is required when users want to distribute packets based > on the IPv4 checksum field. > > For example "flow create 0 ingress pattern eth / ipv4 / end > actions rss types ipv4-chksum end queu

Re: [dpdk-dev] [PATCH 2/2] eal: handle compressed firmwares

2021-06-03 Thread Bruce Richardson
On Thu, Jun 03, 2021 at 09:53:44AM +0200, David Marchand wrote: > On Thu, Jun 3, 2021 at 9:23 AM David Marchand > wrote: > > > > diff --git a/config/meson.build b/config/meson.build index > > > > 017bb2efbb..337daa2719 100644 --- a/config/meson.build +++ > > > > b/config/meson.build @@ -166,6 +166

[dpdk-dev] [PATCH v2] ethdev: add IPv4 checksum RSS offload type

2021-06-03 Thread Alvin Zhang
This patch defines new RSS offload type for IPv4 checksum, which is required when users want to distribute packets based on the IPv4 checksum field. For example "flow create 0 ingress pattern eth / ipv4 / end actions rss types ipv4-chksum end queues end / end", this flow causes all matching packet

Re: [dpdk-dev] [PATCH 2/2] eal: handle compressed firmwares

2021-06-03 Thread David Marchand
On Thu, Jun 3, 2021 at 9:23 AM David Marchand wrote: > > > diff --git a/config/meson.build b/config/meson.build > > > index 017bb2efbb..337daa2719 100644 > > > --- a/config/meson.build > > > +++ b/config/meson.build > > > @@ -166,6 +166,15 @@ if fdt_dep.found() and cc.has_header('fdt.h') > > >

Re: [dpdk-dev] [PATCH] gpudev: introduce memory API

2021-06-03 Thread Andrew Rybchenko
On 6/3/21 10:26 AM, Thomas Monjalon wrote: > 03/06/2021 09:06, Andrew Rybchenko: >> On 6/2/21 11:35 PM, Thomas Monjalon wrote: >>> + * Allocate a chunk of memory on the GPU. >> >> Looking a below function it is required to clarify here if >> the memory is visible or invisible to GPU (or both allowe

Re: [dpdk-dev] [PATCH] gpudev: introduce memory API

2021-06-03 Thread Jerin Jacob
On Thu, Jun 3, 2021 at 2:05 AM Thomas Monjalon wrote: > > From: Elena Agostini > > The new library gpudev is for dealing with GPU from a DPDK application > in a vendor-agnostic way. > > As a first step, the features are focused on memory management. > A function allows to allocate memory inside t

Re: [dpdk-dev] [PATCH] gpudev: introduce memory API

2021-06-03 Thread Thomas Monjalon
03/06/2021 09:18, David Marchand: > Quick pass: > > On Wed, Jun 2, 2021 at 10:36 PM Thomas Monjalon wrote: > > diff --git a/lib/gpudev/gpu_driver.h b/lib/gpudev/gpu_driver.h > > new file mode 100644 > > index 00..5ff609e49d > > --- /dev/null > > +++ b/lib/gpudev/gpu_driver.h [...] > > +st

Re: [dpdk-dev] [PATCH] ethdev: add RSS offload type for L3 checksum

2021-06-03 Thread Zhang, AlvinX
Hi Rybchenko, Thanks for your review. We will add more descriptions and update testpmd app in V2. > -Original Message- > From: Andrew Rybchenko > Sent: Thursday, June 3, 2021 3:15 PM > To: Zhang, AlvinX ; Yigit, Ferruh > ; Zhang, Qi Z > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH]

Re: [dpdk-dev] [PATCH] gpudev: introduce memory API

2021-06-03 Thread Thomas Monjalon
03/06/2021 09:06, Andrew Rybchenko: > On 6/2/21 11:35 PM, Thomas Monjalon wrote: > > From: Elena Agostini > > > > The new library gpudev is for dealing with GPU from a DPDK application > > in a vendor-agnostic way. > > > > As a first step, the features are focused on memory management. > > A fun

Re: [dpdk-dev] [PATCH 2/2] eal: handle compressed firmwares

2021-06-03 Thread David Marchand
On Wed, Jun 2, 2021 at 11:19 PM Dmitry Kozlyuk wrote: > > 2021-06-02 11:58 (UTC+0200), David Marchand: > > Introduce an internal firmware loading helper to remove code duplication > > in our drivers and handle xz compressed firmwares by calling libarchive. > > > > This helper tries to look for .xz

Re: [dpdk-dev] [PATCH] gpudev: introduce memory API

2021-06-03 Thread David Marchand
Quick pass: On Wed, Jun 2, 2021 at 10:36 PM Thomas Monjalon wrote: > diff --git a/lib/gpudev/gpu_driver.h b/lib/gpudev/gpu_driver.h > new file mode 100644 > index 00..5ff609e49d > --- /dev/null > +++ b/lib/gpudev/gpu_driver.h > @@ -0,0 +1,44 @@ > +/* SPDX-License-Identifier: BSD-3-Clause

Re: [dpdk-dev] [PATCH] ethdev: add RSS offload type for L3 checksum

2021-06-03 Thread Andrew Rybchenko
On 6/3/21 6:12 AM, Alvin Zhang wrote: > Add ETH_RSS_L3_CHKSUM macro. Sorry, too short description. I could be an existing practice to add more RSS offload types, but I want to break it. Please, add motivation in the description why it is useful etc. > > Signed-off-by: Alvin Zhang > --- > lib/e

Re: [dpdk-dev] [PATCH] gpudev: introduce memory API

2021-06-03 Thread Andrew Rybchenko
On 6/2/21 11:35 PM, Thomas Monjalon wrote: > From: Elena Agostini > > The new library gpudev is for dealing with GPU from a DPDK application > in a vendor-agnostic way. > > As a first step, the features are focused on memory management. > A function allows to allocate memory inside the GPU, > wh