[dpdk-dev] Can we run KNI under a container

2021-05-27 Thread chetan bhasin
Hello Everyone, We can run dpdk app with KNI on container with below options - * --network host --privileged* -v /sys/bus/pci/drivers:/sys/bus/pci/drivers -v /sys/kernel/mm/hugepages:/sys/kernel/mm/hugepages -v /sys/devices/system/node:/sys/devices/system/node -v /dev:/dev Is there any way we cou

Re: [dpdk-dev] [PATCH v3] crypto/ccp: enable IOMMU for CCP

2021-05-27 Thread Somalapuram, Amaranath
[Public] -Original Message- From: Thomas Monjalon Sent: Thursday, May 27, 2021 7:40 PM To: Somalapuram, Amaranath ; David Marchand Cc: dev ; Akhil Goyal ; Kumar, Ravi1 ; Song, Keesang Subject: Re: [dpdk-dev] [PATCH v3] crypto/ccp: enable IOMMU for CCP [CAUTION: External Email] 27

[dpdk-dev] [PATCH v1 4/4] net/iavf: support AVF RSS for GTPoGRE packet

2021-05-27 Thread Lingyu Liu
Support AVF RSS for inner most header of GTPoGRE packet. It supports RSS based on inner most IP src + dst address and TCP/UDP src + dst port. Signed-off-by: Lingyu Liu --- drivers/net/iavf/iavf_hash.c | 24 1 file changed, 24 insertions(+) diff --git a/drivers/net/iavf/

[dpdk-dev] [PATCH v1 3/4] net/iavf: support AVF FDIR for GRE tunnel packet

2021-05-27 Thread Lingyu Liu
Support AVF FDIR for inner header of GTPoGRE tunnel packet. +---+---+ | Pattern |Input Set | +---+---+ |eth/ipv4/gre/ipv4/udp/gtpu/

[dpdk-dev] [PATCH v1 2/4] common/iavf: add header types for GRE

2021-05-27 Thread Lingyu Liu
Add a virtchnl protocol header type to support AVF FDIR and RSS for GRE. Signed-off-by: Lingyu Liu --- drivers/common/iavf/virtchnl.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/common/iavf/virtchnl.h b/drivers/common/iavf/virtchnl.h index 3a60faff93..b35df618b8 100644 --- a/driv

[dpdk-dev] [PATCH v1 1/4] net/iavf: support flow pattern for GTPoGRE

2021-05-27 Thread Lingyu Liu
Add GTPoGRE pattern support for AVF FDIR and RSS. Signed-off-by: Lingyu Liu --- drivers/net/iavf/iavf_generic_flow.c | 288 +++ drivers/net/iavf/iavf_generic_flow.h | 40 2 files changed, 328 insertions(+) diff --git a/drivers/net/iavf/iavf_generic_flow.c b/driver

[dpdk-dev] [PATCH v1 0/4] support AVF RSS and FDIR for GTPoGRE packet

2021-05-27 Thread Lingyu Liu
Support AVF RSS and FDIR for GTPoGRE packet. Lingyu Liu (4): net/iavf: support flow pattern for GTPoGRE common/iavf: add header types for GRE net/iavf: support AVF FDIR for GRE tunnel packet net/iavf: support AVF RSS for GTPoGRE packet drivers/common/iavf/virtchnl.h | 1 + driver

[dpdk-dev] [PATCH 2/2] vhost: add thread unsafe async registration functions

2021-05-27 Thread Jiayu Hu
This patch is to add thread unsafe version for async register and unregister functions. Signed-off-by: Jiayu Hu --- doc/guides/prog_guide/vhost_lib.rst | 12 +++ lib/vhost/rte_vhost_async.h | 42 ++ lib/vhost/version.map | 4 + lib/vhost/vhost.c

[dpdk-dev] [PATCH 1/2] vhost: fix lock on device readiness notification

2021-05-27 Thread Jiayu Hu
The vhost notifies the application of device readiness via vhost_user_notify_queue_state(), but calling this function is not protected by the lock. This patch is to make this function call lock protected. Fixes: d0fcc38f5fa4 ("vhost: improve device readiness notifications") Cc: sta...@dpdk.org Sig

[dpdk-dev] [PATCH 0/2] provide thread unsafe async registration functions

2021-05-27 Thread Jiayu Hu
Lock protection is needed during the vhost notifies the application of device readiness, so the first patch is to add lock protection. After performing locking, existed async vhost registration functions will cause deadlock, as they acquire lock too. So the second patch is to provide unsafe registr

Re: [dpdk-dev] [21.08 PATCH v1 1/2] power: invert the monitor check

2021-05-27 Thread Liu, Yong
> -Original Message- > From: Burakov, Anatoly > Sent: Thursday, May 27, 2021 9:07 PM > To: Liu, Yong ; dev@dpdk.org; McDaniel, Timothy > ; Xing, Beilei ; Wu, > Jingjing ; Yang, Qiming ; > Zhang, Qi Z ; Wang, Haiyue > ; Matan Azrad ; Shahaf > Shuler ; Viacheslav Ovsiienko > ; Richardson,

[dpdk-dev] [PATCH v2] pmdinfogen: allow padding after NUL terminator

2021-05-27 Thread Dmitry Kozlyuk
Size of string constant symbol may be larger than its length measured up to NUL terminator. In this case pmdinfogen included padding bytes after NUL terminator in generated source, yielding incorrect code. Always trim string data to NUL terminator while reading ELF. It was already done for COFF be

Re: [dpdk-dev] [PATCH 2/2] net/bnxt: workaround for spurious zero counter values in Thor

2021-05-27 Thread Somnath Kotur
Hi Owen, Thank you for the heads up. I still could not figure out how to reproduce this though, i did not run into any issue on my end and i tried launching testpmd with similar cmdline parameters as specified here in the log(TestNicSingleCorePerf) , but no luck In any case, looks lik

Re: [dpdk-dev] rte_memcpy - fence and stream

2021-05-27 Thread Morten Brørup
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Bruce Richardson > Sent: Thursday, 27 May 2021 19.22 > > On Thu, May 27, 2021 at 10:39:59PM +0530, Manish Sharma wrote: > >For the case I have, hardly 2% of the data buffers which are being > >copied get looked at - mostly its for DMA.

Re: [dpdk-dev] [PATCH v3] build: fix symlink of drivers for Windows

2021-05-27 Thread Nick Connolly
Hi Bruce, Would you have some time to take a look at this?  It's a replacement for the symlink-drivers-solibs.sh script for windows builds. Thanks, Nick On 26/04/2021 11:07, Nick Connolly wrote: The symlink-drivers-solibs.sh script was disabled as part of 'install' for Windows because there is

Re: [dpdk-dev] rte_memcpy - fence and stream

2021-05-27 Thread Bruce Richardson
On Thu, May 27, 2021 at 10:39:59PM +0530, Manish Sharma wrote: >For the case I have, hardly 2% of the data buffers which are being >copied get looked at - mostly its for DMA. Having a version of DPDK >memcopy that does non temporal copies would definitely be good. >If in my case, I

Re: [dpdk-dev] rte_memcpy - fence and stream

2021-05-27 Thread Manish Sharma
For the case I have, hardly 2% of the data buffers which are being copied get looked at - mostly its for DMA. Having a version of DPDK memcopy that does non temporal copies would definitely be good. If in my case, I have a lot of CPUs doing the copy in parallel, would I/OAT driver copy accelerator

Re: [dpdk-dev] rte_memcpy - fence and stream

2021-05-27 Thread Bruce Richardson
On Thu, May 27, 2021 at 05:49:19PM +0200, Morten Brørup wrote: > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Bruce Richardson > > Sent: Tuesday, 25 May 2021 11.20 > > > > On Mon, May 24, 2021 at 11:43:24PM +0530, Manish Sharma wrote: > > > I am looking at the source for rte_memcpy (this

[dpdk-dev] [PATCH] app/testpmd: send failure logs to stderr

2021-05-27 Thread Andrew Rybchenko
Running with stdout suppressed or redirected for further processing is very confusing in the case of errors. Signed-off-by: Andrew Rybchenko --- app/test-pmd/testpmd.c | 151 - 1 file changed, 75 insertions(+), 76 deletions(-) diff --git a/app/test-pmd/te

Re: [dpdk-dev] [PATCH] net: introduce IPv4 ihl and version fields

2021-05-27 Thread Morten Brørup
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Gregory Etelson > Sent: Thursday, 27 May 2021 17.29 and version fields > > RTE IPv4 header definition combines the `version' and `ihl' fields > into a single structure member. > This patch introduces dedicated structure members for both `vers

Re: [dpdk-dev] rte_memcpy - fence and stream

2021-05-27 Thread Morten Brørup
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Bruce Richardson > Sent: Tuesday, 25 May 2021 11.20 > > On Mon, May 24, 2021 at 11:43:24PM +0530, Manish Sharma wrote: > > I am looking at the source for rte_memcpy (this is a discussion only > > for x86-64) > > > > For one of the cases, when

[dpdk-dev] [PATCH] net: introduce IPv4 ihl and version fields

2021-05-27 Thread Gregory Etelson
RTE IPv4 header definition combines the `version' and `ihl' fields into a single structure member. This patch introduces dedicated structure members for both `version' and `ihl' IPv4 fields. Separated header fields definitions allow to create simplified code to match on the IHL value in a flow rul

[dpdk-dev] [PATCH 19/20] net/sfc: support flow action COUNT in transfer rules

2021-05-27 Thread Andrew Rybchenko
From: Igor Romanov For now, a rule may have only one dedicated counter, shared counters are not supported. HW delivers (or "streams") counter readings using special packets. The driver creates a dedicated Rx queue to receive such packets and requests that HW start "streaming" the readings to it.

[dpdk-dev] [PATCH 20/20] net/sfc: support flow API query for count actions

2021-05-27 Thread Andrew Rybchenko
From: Igor Romanov The query reports the number of hits for a counter associated with a flow rule. Signed-off-by: Igor Romanov Signed-off-by: Andrew Rybchenko Reviewed-by: Andy Moreton Reviewed-by: Ivan Malov --- drivers/net/sfc/sfc_flow.c| 40 ++- drivers/net/sfc/sf

[dpdk-dev] [PATCH 18/20] common/sfc_efx/base: add packetiser packet format definition

2021-05-27 Thread Andrew Rybchenko
Packetiser composes packets with MAE counters update. Signed-off-by: Andrew Rybchenko Reviewed-by: Andy Moreton --- .../base/efx_regs_counters_pkt_format.h | 87 +++ 1 file changed, 87 insertions(+) create mode 100644 drivers/common/sfc_efx/base/efx_regs_counters_pkt_form

[dpdk-dev] [PATCH 17/20] common/sfc_efx/base: add max MAE counters to limits

2021-05-27 Thread Andrew Rybchenko
From: Igor Romanov The information about the maximum number of MAE counters is crucial to the counter support in the driver. Signed-off-by: Igor Romanov Signed-off-by: Andrew Rybchenko Reviewed-by: Andy Moreton Reviewed-by: Ivan Malov --- drivers/common/sfc_efx/base/efx.h | 1 + drivers

[dpdk-dev] [PATCH 16/20] net/sfc: add Rx datapath method to get pushed buffers count

2021-05-27 Thread Andrew Rybchenko
From: Igor Romanov The information about the number of pushed Rx buffers is required for counter Rx queue to know when to give credits to counter stream. Signed-off-by: Igor Romanov Signed-off-by: Andrew Rybchenko Reviewed-by: Andy Moreton Reviewed-by: Ivan Malov --- drivers/net/sfc/sfc_dp_

[dpdk-dev] [PATCH 15/20] common/sfc_efx/base: support counter in action set

2021-05-27 Thread Andrew Rybchenko
From: Igor Romanov User will be able to associate counter with MAE action set to collect counter packets and bytes for a specific action set. Signed-off-by: Igor Romanov Signed-off-by: Andrew Rybchenko Reviewed-by: Andy Moreton Reviewed-by: Ivan Malov --- drivers/common/sfc_efx/base/efx.h

[dpdk-dev] [PATCH 14/20] common/sfc_efx/base: add counter stream MCDI wrappers

2021-05-27 Thread Andrew Rybchenko
From: Igor Romanov The MCDIs will be used to control counter Rx queue packet flow. Signed-off-by: Igor Romanov Signed-off-by: Andrew Rybchenko Reviewed-by: Andy Moreton Reviewed-by: Ivan Malov --- drivers/common/sfc_efx/base/efx.h | 32 ++ drivers/common/sfc_efx/base/efx_mae.c | 13

[dpdk-dev] [PATCH 13/20] common/sfc_efx/base: add counter creation MCDI wrappers

2021-05-27 Thread Andrew Rybchenko
From: Igor Romanov User will be able to create and free MAE counters. Support for associating counters with action set will be added in upcoming patches. Signed-off-by: Igor Romanov Signed-off-by: Andrew Rybchenko Reviewed-by: Andy Moreton Reviewed-by: Ivan Malov --- drivers/common/sfc_efx/

[dpdk-dev] [PATCH 12/20] net/sfc: reserve RxQ for counters

2021-05-27 Thread Andrew Rybchenko
From: Igor Romanov MAE delivers counters data as special packets via dedicated Rx queue. Reserve an RxQ so that it does not interfere with ethdev Rx queues. A routine will be added later to handle these packets. There is no point to reserve the queue if no service cores are available and counter

[dpdk-dev] [PATCH 11/20] net/sfc: add NUMA-aware registry of service logical cores

2021-05-27 Thread Andrew Rybchenko
The driver requires service cores for housekeeping. Share these cores for many adapters and various purposes to avoid extra CPU overhead. Since housekeeping services will talk to NIC, it should be possible to choose logical core on matching NUMA node. Signed-off-by: Andrew Rybchenko Reviewed-by:

[dpdk-dev] [PATCH 10/20] net/sfc: add support for initialising different RxQ types

2021-05-27 Thread Andrew Rybchenko
From: Igor Romanov Add extra EFX flags to RxQ info initialization API to support choosing different RxQ types and make the API public to use it in for counter queues. Signed-off-by: Igor Romanov Signed-off-by: Andrew Rybchenko Reviewed-by: Andy Moreton --- drivers/net/sfc/sfc_rx.c | 10 +

[dpdk-dev] [PATCH 09/20] net/sfc: add abstractions for the management EVQ identity

2021-05-27 Thread Andrew Rybchenko
From: Igor Romanov Add a function returning management event queue software index. Signed-off-by: Igor Romanov Signed-off-by: Andrew Rybchenko Reviewed-by: Andy Moreton --- drivers/net/sfc/sfc_ev.c | 2 +- drivers/net/sfc/sfc_ev.h | 6 ++ 2 files changed, 7 insertions(+), 1 deletion(-)

[dpdk-dev] [PATCH 08/20] common/sfc_efx/base: add user mark RxQ flag

2021-05-27 Thread Andrew Rybchenko
From: Igor Romanov Add a flag to request support for user mark field on an RxQ. The field is required to retrieve generation count value from counter RxQ. Implement it only for Riverhead and EF10 ESSB since they support the field in the Rx prefix. Signed-off-by: Igor Romanov Signed-off-by: And

[dpdk-dev] [PATCH 07/20] common/sfc_efx/base: add ingress m-port RxQ flag

2021-05-27 Thread Andrew Rybchenko
From: Igor Romanov Add a flag to request support for ingress m-port on an RxQ. Implement it only for Riverhead, other families will return an error if the flag is set. Signed-off-by: Igor Romanov Signed-off-by: Andrew Rybchenko Reviewed-by: Andy Moreton Reviewed-by: Ivan Malov --- drivers/c

[dpdk-dev] [PATCH 06/20] net/sfc: introduce ethdev Tx queue ID

2021-05-27 Thread Andrew Rybchenko
From: Igor Romanov Make software index of a Tx queue and ethdev index separate. When an ethdev TxQ is accessed in ethdev callbacks, an explicit ethdev queue index is used. This is a preparation to introducing non-ethdev Tx queues. Signed-off-by: Igor Romanov Signed-off-by: Andrew Rybchenko Re

[dpdk-dev] [PATCH 05/20] net/sfc: explicitly control IRQ used for Rx queues

2021-05-27 Thread Andrew Rybchenko
Interrupts support has assumptions on interrupt numbers used for LSC and Rx queues. The first interrupt is used for LSC, subsequent interrupts are used for Rx queues. Signed-off-by: Andrew Rybchenko Reviewed-by: Andy Moreton --- drivers/net/sfc/sfc_ev.c | 32 1

[dpdk-dev] [PATCH 04/20] common/sfc_efx/base: support custom EvQ to IRQ mapping

2021-05-27 Thread Andrew Rybchenko
Custom mapping is actually supported for EF10 and EF100 families only. A driver (e.g. DPDK PMD) may require to customize mapping of EvQ to interrupts if, for example, extra EvQ are used for house-keeping in polling or wake up (via another EvQ) mode. Signed-off-by: Andrew Rybchenko Reviewed-by: A

[dpdk-dev] [PATCH 03/20] common/sfc_efx/base: separate target EvQ and IRQ config

2021-05-27 Thread Andrew Rybchenko
Target EvQ and IRQ number are specified in the same location in MCDI request. The value is treated as IRQ number if the event queue is interrupting (corresponding flag is set) and as target event queue otherwise. However it is better to separate it on helper API level to make it more clear. Signe

[dpdk-dev] [PATCH 02/20] net/sfc: do not enable interrupts on internal Rx queues

2021-05-27 Thread Andrew Rybchenko
rxq_intr flag requests support for interrupt mode for ethdev Rx queues. There is no internal Rx queues yet. Signed-off-by: Andrew Rybchenko --- drivers/net/sfc/sfc_ev.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/sfc/sfc_ev.c b/drivers/net/sfc/sfc_ev.c inde

[dpdk-dev] [PATCH 01/20] net/sfc: introduce ethdev Rx queue ID

2021-05-27 Thread Andrew Rybchenko
From: Igor Romanov Make software index of an Rx queue and ethdev index separate. When an ethdev RxQ is accessed in ethdev callbacks, an explicit ethdev queue index is used. This is a preparation to introducing non-ethdev Rx queues. Signed-off-by: Igor Romanov Signed-off-by: Andrew Rybchenko R

[dpdk-dev] [PATCH 00/20] net/sfc: support flow API COUNT action

2021-05-27 Thread Andrew Rybchenko
Update base driver and support COUNT action in transfer flow rules. Andrew Rybchenko (6): net/sfc: do not enable interrupts on internal Rx queues common/sfc_efx/base: separate target EvQ and IRQ config common/sfc_efx/base: support custom EvQ to IRQ mapping net/sfc: explicitly control IRQ u

[dpdk-dev] [PATCH] net/mlx5: fix RSS expansion pattern

2021-05-27 Thread Gregory Etelson
Flow rule pattern may be implicitly expanded by the PMD if the rule has RSS flow action. The expansion adds network headers to the original pattern. The new pattern lists all network levels that participate in the rule RSS action. The patch fixes expanded pattern for cases when original pattern in

Re: [dpdk-dev] [PATCH] raw/ioat: extend python script functionality

2021-05-27 Thread Laatz, Kevin
<...> > Hi Kevin, > > since you list out two changes here, it's a good indication that this might > be better as two separate patches. Can you please split it, thanks. > > Couple of minor comments inline below too. > > Regards, > /Bruce > Thanks for the feedback, Bruce. I'll split the changes a

Re: [dpdk-dev] [PATCH] raw/ioat: fix missing device name in idxd bus scan

2021-05-27 Thread Bruce Richardson
On Thu, May 27, 2021 at 02:36:09PM +0100, Kevin Laatz wrote: > The device name is not being initialized during the idxd bus scan which > will cause segmentation faults when an appliation tries to access this > information. > > This patch adds the required initialization of the device name so that

[dpdk-dev] [PATCH] net/sfc: check for ID overflow in action PORT ID

2021-05-27 Thread Ivan Malov
The container in the action configuration is U32, but the ID is U16, and overflow check is missing. Fixes: 1fb65e4dae8a ("net/sfc: support flow action port ID in transfer rules") Cc: sta...@dpdk.org Signed-off-by: Ivan Malov Reviewed-by: Andrew Rybchenko Reviewed-by: Andy Moreton --- drivers/

Re: [dpdk-dev] [PATCH] raw/ioat: extend python script functionality

2021-05-27 Thread Bruce Richardson
On Thu, May 27, 2021 at 02:26:46PM +0100, Kevin Laatz wrote: > Currently the user needs to find the DSA instance number for any DSA > device they would like to configure using this script, which can be > cumbersome and error-prone since the instance numbering changes when > changing the binding of

Re: [dpdk-dev] [PATCH v3] crypto/ccp: enable IOMMU for CCP

2021-05-27 Thread Thomas Monjalon
27/05/2021 15:24, David Marchand: > On Fri, Dec 25, 2020 at 9:06 AM wrote: > > > > From: Amaranath Somalapuram > > > > CCP use vdev framework, and vdev framework don’t support IOMMU. > > Adding custom IOMMU support for AMD CCP driver. > > I am currently looking at pci bus patches/cleanups. > I e

[dpdk-dev] [RFC 13/14] vdpa/mlx5: support SubFunction

2021-05-27 Thread Xueming Li
From: Thomas Monjalon Signed-off-by: Thomas Monjalon --- drivers/vdpa/mlx5/mlx5_vdpa.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/vdpa/mlx5/mlx5_vdpa.c b/drivers/vdpa/mlx5/mlx5_vdpa.c index 967234193f..2f4420becd 100644 --- a/drivers/vdpa/mlx5/mlx5_vdpa.

[dpdk-dev] [RFC 14/14] net/mlx5: support SubFunction

2021-05-27 Thread Xueming Li
This patch introduces SF support. Similar to VF, SF on auxiliary bus is a portion of hardware PF, no representor or bonding parameters for SF. Devargs to support SF: -a auxiliary:mlx5_core.sf.8,dv_flow_en=1 New global syntax to support SF: -a bus=auxiliary,name=mlx5_core.sf.8/class=eth/driver=mlx

[dpdk-dev] [RFC 12/14] common/mlx5: get PCI device address from any bus

2021-05-27 Thread Xueming Li
From: Thomas Monjalon A function is exported to allow retrieving the PCI address of the parent PCI device of a Sub-Function in auxiliary bus sysfs. The function mlx5_dev_to_pci_str() is accepting both PCI and auxiliary devices. In case of a PCI device, it is simply using the device name. The fun

[dpdk-dev] [RFC 11/14] common/mlx5: support auxiliary bus

2021-05-27 Thread Xueming Li
This patch adds auxiliary bus driver and delegate to registered internal mlx5 common device drivers, i.e. eth, vdpa... Current major target is to support SubFunction on auxiliary bus. As a limitation of current driver, numa node of device is detected from PCI bus of device symbol link, will remov

[dpdk-dev] [RFC 10/14] bus/auxiliary: introduce auxiliary bus

2021-05-27 Thread Xueming Li
Auxiliary [1] provides a way to split function into child-devices representing sub-domains of functionality. Each auxiliary_device represents a part of its parent functionality. Auxiliary device is identified by unique device name, sysfs path: /sys/bus/auxiliary/devices/ [1] kernel auxiliary bu

[dpdk-dev] [PATCH] raw/ioat: fix missing device name in idxd bus scan

2021-05-27 Thread Kevin Laatz
The device name is not being initialized during the idxd bus scan which will cause segmentation faults when an appliation tries to access this information. This patch adds the required initialization of the device name so that it can be read without issues. Fixes: b7aaf417f936 ("raw/ioat: add bus

[dpdk-dev] [RFC 08/14] vdpa/mlx5: remove PCI specifics

2021-05-27 Thread Xueming Li
From: Thomas Monjalon Signed-off-by: Thomas Monjalon --- drivers/vdpa/mlx5/mlx5_vdpa.c | 119 ++ drivers/vdpa/mlx5/mlx5_vdpa.h | 1 - 2 files changed, 34 insertions(+), 86 deletions(-) diff --git a/drivers/vdpa/mlx5/mlx5_vdpa.c b/drivers/vdpa/mlx5/mlx5_vdpa.c

[dpdk-dev] [RFC 09/14] common/mlx5: clean up legacy PCI bus driver

2021-05-27 Thread Xueming Li
Clean up legacy PCI bus driver since all mlx5 PMDs moved to new common PCI bus driver. Signed-off-by: Xueming Li --- drivers/common/mlx5/linux/mlx5_common_os.c | 28 -- drivers/common/mlx5/linux/mlx5_common_os.h | 4 - drivers/common/mlx5/mlx5_common.c | 1 - drivers/common/mlx5/ml

[dpdk-dev] [RFC 07/14] vdpa/mlx5: fix driver name

2021-05-27 Thread Xueming Li
From: Thomas Monjalon Signed-off-by: Thomas Monjalon --- drivers/vdpa/mlx5/mlx5_vdpa.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/vdpa/mlx5/mlx5_vdpa.c b/drivers/vdpa/mlx5/mlx5_vdpa.c index 8b5bfd8c3d..5ab7c525c2 100644 --- a/drivers/vdpa/mlx5/mlx5_vdpa

[dpdk-dev] [RFC 06/14] compress/mlx5: migrate to common driver

2021-05-27 Thread Xueming Li
To support auxiliary bus, upgrades driver to use mlx5 common driver structure. Signed-off-by: Xueming Li --- drivers/compress/mlx5/mlx5_compress.c | 71 ++- 1 file changed, 15 insertions(+), 56 deletions(-) diff --git a/drivers/compress/mlx5/mlx5_compress.c b/drivers/co

[dpdk-dev] [RFC 05/14] regex/mlx5: migrate to common driver

2021-05-27 Thread Xueming Li
To support auxiliary bus, upgrades driver to use mlx5 common driver structure. Signed-off-by: Xueming Li --- drivers/regex/mlx5/mlx5_regex.c | 49 - drivers/regex/mlx5/mlx5_regex.h | 1 - 2 files changed, 18 insertions(+), 32 deletions(-) diff --git a/drivers/re

[dpdk-dev] [RFC 03/14] net/mlx5: remove PCI dependency

2021-05-27 Thread Xueming Li
To support more bus types, remove PCI dependency where possible. Signed-off-by: Xueming Li --- drivers/common/mlx5/mlx5_common_pci.c | 6 +-- drivers/net/mlx5/linux/mlx5_ethdev_os.c | 2 +- drivers/net/mlx5/linux/mlx5_os.c| 4 +- drivers/net/mlx5/mlx5.c | 53

[dpdk-dev] [RFC 04/14] net/mlx5: migrate to bus-agnostic common driver

2021-05-27 Thread Xueming Li
To support SubFunction based on auxiliary bus, common driver supports new bus-agnostic driver. This patch migrates net driver to new common driver. Signed-off-by: Xueming Li --- drivers/net/mlx5/linux/mlx5_os.c | 46 +- drivers/net/mlx5/linux/mlx5_os.h | 3 -- d

[dpdk-dev] [RFC 02/14] common/mlx5: move description of PCI sysfs functions

2021-05-27 Thread Xueming Li
From: Thomas Monjalon The Linux-specific functions mlx5_get_pci_addr() and mlx5_get_ifname_sysfs() are better described in the .h file. The requirement for using mlx5_get_pci_addr() is explicited: the node /device must exist in the provided sysfs path. Signed-off-by: Thomas Monjalon --- drive

[dpdk-dev] [RFC 01/14] common/mlx5: add common device driver

2021-05-27 Thread Xueming Li
To support auxiliary bus, introduces common device driver and callbacks, suppose to replace current mlx5 common PCI bus driver. mlx5 common PCI bus driver still used by mlx5 eth, vDPA and regex PMD, will remove once all PMD drivers adapt to new common driver. Signed-off-by: Xueming Li --- drive

[dpdk-dev] [RFC 00/14] mlx5: support SubFunction

2021-05-27 Thread Xueming Li
SubFunction [1] is a portion of the PCI device, a SF netdev has its own dedicated queues(txq, rxq). A SF shares PCI level resources with other SFs and/or with its parent PCI function. Auxiliary bus is the fundamental of SF. This patch set introduces SubFunction support for mlx5 PMD driver includin

[dpdk-dev] [PATCH] raw/ioat: extend python script functionality

2021-05-27 Thread Kevin Laatz
Currently the user needs to find the DSA instance number for any DSA device they would like to configure using this script, which can be cumbersome and error-prone since the instance numbering changes when changing the binding of the devices between vfio-pci and idxd. In addition to this, once the

Re: [dpdk-dev] [PATCH v3] crypto/ccp: enable IOMMU for CCP

2021-05-27 Thread David Marchand
On Fri, Dec 25, 2020 at 9:06 AM wrote: > > From: Amaranath Somalapuram > > CCP use vdev framework, and vdev framework don’t support IOMMU. > Adding custom IOMMU support for AMD CCP driver. I am currently looking at pci bus patches/cleanups. I ended up looking at crypto/ccp. This driver code cont

Re: [dpdk-dev] [21.08 PATCH v1 1/2] power: invert the monitor check

2021-05-27 Thread Burakov, Anatoly
On 25-May-21 10:15 AM, Liu, Yong wrote: -Original Message- From: dev On Behalf Of Anatoly Burakov Sent: Tuesday, May 11, 2021 11:32 PM To: dev@dpdk.org; McDaniel, Timothy ; Xing, Beilei ; Wu, Jingjing ; Yang, Qiming ; Zhang, Qi Z ; Wang, Haiyue ; Matan Azrad ; Shahaf Shuler ; Viachesl

[dpdk-dev] [PATCH 2/2] net/bnxt: workaround for spurious zero counter values in Thor

2021-05-27 Thread Somnath Kotur
There is a HW bug that can result in certain stats being reported as zero. Workaround this by ignoring stats with a value of zero based on the previously stored snapshot of the same stat. This bug mainly manifests in the output of func_qstats as FW aggregrates each ring's stat value to give the per

[dpdk-dev] [PATCH 1/2] net/bnxt: detect bad opaque in Rx completion

2021-05-27 Thread Somnath Kotur
There is a rare hardware bug that can cause a bad opaque value in the RX or TPA start completion. When this happens, the hardware may have used the same buffer twice for 2 rx packets. In addition, the driver might also crash later using the bad opaque as an index into the ring. The rx opaque valu

Re: [dpdk-dev] [PATCH v1] net/iavf: fix RSS key access out of index

2021-05-27 Thread Zhang, Qi Z
> -Original Message- > From: Xing, Beilei > Sent: Thursday, May 20, 2021 9:24 AM > To: Wang, Haiyue ; dev@dpdk.org > Cc: Zhang, Qi Z ; sta...@dpdk.org; Wu, Jingjing > > Subject: RE: [PATCH v1] net/iavf: fix RSS key access out of index > > > > > -Original Message- > > From: W

[dpdk-dev] [PATCH] net/mlx5: fix incorrect r/w lock usage in DMA unmap

2021-05-27 Thread Feifei Wang
For mlx5 DMA unmap, write lock should be used for rebuilding memory region cache table rather than read lock. Fixes: 989e999d9305 ("net/mlx5: support PCI device DMA map and unmap") Cc: shah...@mellanox.com Cc: sta...@dpdk.org Signed-off-by: Feifei Wang Reviewed-by: Ruifeng Wang --- drivers/net

[dpdk-dev] [PATCH 4/4] net/mlx5: replace flow list with index pool

2021-05-27 Thread Suanming Mou
The flow list is used to save the create flows and to be used only when port closes all the flows need to be flushed. This commit creates a new function to get the available entries from the index pool. Then flows can be flushed from index pool. Signed-off-by: Suanming Mou --- drivers/net/mlx5/

[dpdk-dev] [PATCH 3/4] net/mlx5: add index pool cache flush

2021-05-27 Thread Suanming Mou
This commit adds the per-core cache indexed pool cache flush function. Signed-off-by: Suanming Mou --- drivers/net/mlx5/mlx5_utils.c | 70 +++ drivers/net/mlx5/mlx5_utils.h | 13 +++ 2 files changed, 83 insertions(+) diff --git a/drivers/net/mlx5/mlx5_utils.c

[dpdk-dev] [PATCH 2/4] net/mlx5: add indexed pool local cache

2021-05-27 Thread Suanming Mou
For object which wants efficient index allocate and free, local cache will be very helpful. Two level cache is added, one as local and another as global. The global cache is able to save all the allocated index. That means all the allocated index will not be freed. Once the local cache is full, th

[dpdk-dev] [PATCH 1/4] net/mlx5: add index allocate with up limit

2021-05-27 Thread Suanming Mou
The index pool can be used as ID allocator. In the ID allocator case, to support the maximum ID can be allocated is very useful since some registers only want limited bits of ID. This patch add the maximum ID configurable for the index pool. Signed-off-by: Suanming Mou --- drivers/net/mlx5/mlx5

[dpdk-dev] [PATCH 0/4] net/mlx5: add indexed pool local cache

2021-05-27 Thread Suanming Mou
For object which wants efficient index allocate and free, local cache will be very helpful. Two level cache is added, one as local and another as global. The global cache is able to save all the allocated index. That means all the allocated index will not be freed. Once the local cache is full, th

Re: [dpdk-dev] [PATCH v3 0/2] remove wmb for net/mlx

2021-05-27 Thread Raslan Darawsheh
Hi, > -Original Message- > From: dev On Behalf Of Feifei Wang > Sent: Tuesday, May 18, 2021 11:51 AM > Cc: dev@dpdk.org; n...@arm.com; Feifei Wang > Subject: [dpdk-dev] [PATCH v3 0/2] remove wmb for net/mlx > > For net/mlx4 and net/mlx5, remove unnecessary wmb for Memory Region > cache.

[dpdk-dev] Broadcom PMD roadmap for DPDK 21.08 release

2021-05-27 Thread Ajit Khaparde
The following is Broadcom's roadmap for DPDK 21.08 release: * Vector PMD improvement with AVX2 * Support rte_flow RSS action * Flow redirection support * Dynamic queue support

[dpdk-dev] [RFC PATCH] ethdev: add support for testpmd-compliant flow rule dumping

2021-05-27 Thread Ivan Malov
DPDK applications (for example, OvS) or tests which use RTE flow API need to log created or rejected flow rules to help to recognise what goes right or wrong. From this standpoint, testpmd-compliant format is nice for the purpose because it allows to copy-paste the flow rules and debug using testpm

Re: [dpdk-dev] [Bug 721] Wrong event pointer in rx adapter

2021-05-27 Thread Van Haaren, Harry
> -Original Message- > From: Pavan Nikhilesh Bhagavatula > Sent: Wednesday, May 26, 2021 2:02 PM > To: Van Haaren, Harry ; bugzi...@dpdk.org; > dev@dpdk.org; Rao, Nikhil ; Jayatheerthan, Jay > ; heng.w...@ericsson.com > Subject: RE: [dpdk-dev] [Bug 721] Wrong event pointer in rx adapter >

[dpdk-dev] [PATCH v1 2/2] net/i40e: improve performance for vector Tx

2021-05-27 Thread Feifei Wang
For i40e vector Tx path, if tx_offload is set as FAST_FREE_MBUF mode, no mbuf fast free operations are executed. To fix this, add mbuf fast free mode for vector Tx path. Furthermore, for i40e vector Tx path, if implement FAST_FREE_MBUF mode, it means per-queue all mbufs come from the same mempool

[dpdk-dev] [PATCH v1 1/2] net/i40e: improve performance for scalar Tx

2021-05-27 Thread Feifei Wang
For i40e scalar Tx path, if implement FAST_FREE_MBUF mode, it means per-queue all mbufs come from the same mempool and have refcnt = 1. Thus we can use bulk free of the buffers when mbuf fast free mode is enabled. For scalar path in arm platform: In n1sdp, performance is improved by 7.8%; In thun

[dpdk-dev] [PATCH v1 0/2] net/i40e: improve free mbuf

2021-05-27 Thread Feifei Wang
For i40e Tx path, use bulk free of the buffers when mbuf fast free mode is enabled. This can efficiently improve the performance. Feifei Wang (2): net/i40e: improve performance for scalar Tx net/i40e: improve performance for vector Tx drivers/net/i40e/i40e_rxtx.c| 5 - drive

[dpdk-dev] [PATCH v1 6/6] net/ice/base: support FDIR for GRE tunnel packet

2021-05-27 Thread Wenjun Wu
Add support for FDIR of inner header of GRE tunnel packet. Signed-off-by: Wenjun Wu --- drivers/net/ice/base/ice_fdir.c | 352 drivers/net/ice/base/ice_fdir.h | 2 + drivers/net/ice/base/ice_flow.c | 16 +- drivers/net/ice/base/ice_type.h | 14 ++ 4 files cha

[dpdk-dev] [PATCH v1 5/6] net/iavf: support AVF FDIR for GRE tunnel packet

2021-05-27 Thread Wenjun Wu
Support AVF FDIR for inner header of GRE tunnel packet. +--+---+ | Pattern|Input Set | +--+---+ | eth/ipv4/gre/ipv4

[dpdk-dev] [PATCH v1 4/6] net/iavf: support AVF RSS for GRE tunnel packet

2021-05-27 Thread Wenjun Wu
Support AVF RSS for inner header of GRE tunnel packet. It supports RSS based on fields inner IP src + dst address and TCP/UDP src + dst port. Signed-off-by: Wenjun Wu --- drivers/net/iavf/iavf_hash.c | 37 ++-- 1 file changed, 31 insertions(+), 6 deletions(-) dif

[dpdk-dev] [PATCH v1 3/6] ethdev: add GRE RSS offload type

2021-05-27 Thread Wenjun Wu
Define new RSS offload type for GRE. Signed-off-by: Wenjun Wu --- lib/ethdev/rte_ethdev.h | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/ethdev/rte_ethdev.h b/lib/ethdev/rte_ethdev.h index faf3bd901d..be83456257 100644 --- a/lib/ethdev/rte_ethdev.h +++ b/lib/ethdev/rte_ethdev.h @@ -537,

[dpdk-dev] [PATCH v1 2/6] common/iavf: add header types for GRE

2021-05-27 Thread Wenjun Wu
Add a virtchnl protocol header type to support AVF FDIR and RSS for GRE. Signed-off-by: Wenjun Wu --- drivers/common/iavf/virtchnl.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/common/iavf/virtchnl.h b/drivers/common/iavf/virtchnl.h index 3a60faff93..197edce8a1 100644 --- a/drive

[dpdk-dev] [PATCH v1 1/6] net/iavf: support flow pattern for GRE

2021-05-27 Thread Wenjun Wu
Add GRE pattern support for AVF FDIR and RSS. Patterns are listed below: 1. eth/ipv4/gre/ipv4 2. eth/ipv4/gre/ipv6 3. eth/ipv6/gre/ipv4 4. eth/ipv6/gre/ipv6 5. eth/ipv4/gre/ipv4/tcp 6. eth/ipv4/gre/ipv6/tcp 7. eth/ipv4/gre/ipv4/udp 8. eth/ipv4/gre/ipv6/udp 9. eth/ipv6/gre/ipv4/tc

[dpdk-dev] [PATCH v1 0/6] support AVF RSS and FDIR for GRE tunnel packet

2021-05-27 Thread Wenjun Wu
[PATCH v1 1/6] support flow pattern for GRE [PATCH v1 2/6] add header types for GRE [PATCH v1 3/6] add GRE RSS offload type [PATCH v1 4/6] support AVF RSS for GRE tunnel packet [PATCH v1 5/6] support AVF FDIR for GRE tunnel packet [PATCH v1 6/6] support FDIR for GRE tunnel packet Wenjun Wu (6):

Re: [dpdk-dev] [PATCH] pmdinfogen: allow padding after NUL terminator

2021-05-27 Thread David Marchand
On Wed, May 26, 2021 at 11:44 PM Dmitry Kozlyuk wrote: > > Size of string constant symbol may be larger than its length > measured up to NUL terminator. In this case pmdinfogen included padding > bytes after NUL terminator in generated source, yielding incorrect code. > > Always trim string data t

Re: [dpdk-dev] [PATCH v3] build: fix SVE compile error with gcc8.3

2021-05-27 Thread Fengchengwen
Hi, Thomas Could you review this patch? Thanks From:Ruifeng Wang To:Fengchengwen ;Thomas Monjalon ;ferruh.yigit Cc:dev ;Richardson, Bruce ;vladimir.medvedkin ;viktorin ;Jerin Jacob ;nd Date:2021-05-25 14:02:20 Subject:RE: [PATCH v3] build: fix SVE compile error with gcc8.3 > -Ori

Re: [dpdk-dev] [PATCH] pmdinfogen: allow padding after NUL terminator

2021-05-27 Thread Dmitry Kozlyuk
On Thu, May 27, 2021, 09:53 David Marchand wrote: > Just to confirm my reading of the C version of pmdinfogen: the C version > formats those symbols fine with printf %s. > So there should be no need for a fix in stable branches, right? > Yes. >

Re: [dpdk-dev] [PATCH v8 2/2] net/hns3: refactor SVE code compile method

2021-05-27 Thread Fengchengwen
Hi, Ferruh Could you review this patch ? Thanks From:Ruifeng Wang To:Fengchengwen ;Thomas Monjalon ;ferruh.yigit Cc:dev ;Jerin Jacob ;viktorin ;Richardson, Bruce ;Honnappa Nagarahalli ;jerinjacobk ;Juraj Linkeš ;nd ;nd Date:2021-05-25 14:04:52 Subject:RE: [PATCH v8 2/2] net/hns3: re