在 2021/5/6 10:36, Li, Xiaoyun 写道:
-Original Message-
From: Huisong Li
Sent: Tuesday, May 4, 2021 09:46
To: Li, Xiaoyun
Cc: Yigit, Ferruh ; dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2 1/2] app/testpmd: add link speed check
before port start
在 2021/4/30 12:46, Li, Xiaoyun 写道:
--
Return value of a function 'rte_zmalloc' is dereferenced without
checking, and it may call segmentation fault.
This patch fixed it.
Fixes: f8be1786b1b8 ("app/crypto-perf: introduce performance test application")
Cc: sta...@dpdk.org
Signed-off-by: Min Hu (Connor)
---
v3:
* fix compiling warning.
Hello Ferruh,
> >> The were some questions around testpmd part of this patch in previous
> >> version, they are not answered and this version is dropping the
> >> testpmd part.
> >>
> >
> > The tunnel offload API allows application to place tunnel offload elements
> at any valid location in a flow
> -Original Message-
> From: dev On Behalf Of Alvin Zhang
> Sent: Tuesday, April 27, 2021 4:59 PM
> To: Wu, Jingjing ; Xing, Beilei
> Cc: dev@dpdk.org; Zhang, AlvinX ; sta...@dpdk.org
> Subject: [dpdk-dev] [PATCH] net/i40e: fix offload flag checking in simple Tx
> datapath
Tested-by: Ju
The VF reset can be triggerred by the PF reset event, in this case, the
PCI bus master will be cleared, then the VF is not allowed to issue any
Memory or I/O Requests.
So after the reset event is detected, always enable the PCI bus master.
And if failed, the device or system may be in an invalid s
The VF reset can be triggerred by the PF reset event, in this case, the
PCI bus master will be cleared, then the VF is not allowed to issue any
Memory or I/O Requests.
So after the reset event is detected, always enable the PCI bus master.
And if failed, the device or system may be in an invalid s
Add the API to set 'Bus Master Enable' bit to be enabled or disabled in
the PCI command register.
Signed-off-by: Haiyue Wang
Acked-by: Ray Kinsella
---
drivers/bus/pci/pci_common.c | 28
drivers/bus/pci/rte_bus_pci.h | 14 ++
drivers/bus/pci/version.map
By triggerring the VF reset from PF reset,
echo 1 > /sys/bus/pci/devices/PF-BDF/reset
the PCI bus master bit will cleared on VF, so the VF needs to enable
this bit before restart.
This patch set adds the API to enable PCI bus master.
v5: error handling if bus master enable failed
v4: ch
From: Huisong Li
Currently, ethtool directly ends the process after 'quit' cmd. In this
case, software resources are not released and hardware resources of the
device are not uninstalled.
This patch adds closing port operation to release resources.
Fixes: bda68ab9d1e7 ("examples/ethtool: add us
From: Chengwen Feng
In DPDK, 'rte_socket_id' means the running socket while
'rte_eth_dev_socket_id' is the device socket. For better performance,
memory which queue setup used and device should be in the same socket.
This patch make sure it calls rte_eth_dev_socket_id API to get device
socket_id
This patch fixed fix bugs for ethtool APP.
Chengwen Feng (1):
examples/ethtool: fix Rx/Tx queue setup with rte socket id
Huisong Li (1):
examples/ethtool: add closing port operation
examples/ethtool/ethtool-app/main.c | 18 ++
examples/ethtool/lib/rte_ethtool.c | 4 ++--
2
On April 29, 2021 10:31 PM, Ferruh Yigit wrote:
> On 4/29/2021 11:33 AM, Jiawen Wu wrote:
> > Support to enable and disable QINQ hardware strip, when configure vlan
> > offload with QINQ strip mask, to avoid RSS does not work for QINQ
> > packets.
> >
>
> Hi Jiawen,
>
> What was not working and f
> -Original Message-
> From: David Marchand
> Sent: Wednesday, May 5, 2021 16:39
> To: Wang, Haiyue
> Cc: dev ; Zhang, Qi Z ; Wang, Liang-min
> ;
> Wu, Jingjing ; Xing, Beilei
> Subject: Re: [PATCH v4 2/3] net/iavf: enable PCI bus master after reset
>
> On Wed, May 5, 2021 at 4:56 AM W
On Thu, 6 May 2021 00:54:35 +0300
Dmitry Kozlyuk wrote:
> This fixes -Wformat warning with clang 10.0.0 on Windows.
>
> Fixes: f8244c6399d9 ("ethdev: increase port id range")
> Cc: sta...@dpdk.org
>
> Signed-off-by: Dmitry Kozlyuk
> Acked-by: Tyler Retzlaff
> ---
> v3: PRIx16 -> PRIu16
> v2:
On Thu, 6 May 2021 00:51:33 +0300
Dmitry Kozlyuk wrote:
> This fixes -Wformat warning with clang 10.0.0 on Windows.
>
> Fixes: f8244c6399d9 ("ethdev: increase port id range")
> Cc: sta...@dpdk.org
>
> Signed-off-by: Dmitry Kozlyuk
> Acked-by: Tyler Retzlaff
> ---
> v2: use PRIx16 instead of
Hi, Slava
Would you have more comments about this patch?
For my sight, only one wmb before "dev_gen" updating is enough to synchronize.
Thanks very much for your attention.
Best Regards
Feifei
> -邮件原件-
> 发件人: Feifei Wang
> 发送时间: 2021年4月20日 16:42
> 收件人: Slava Ovsiienko ; Matan Azrad
>
Hi Ferruh,
Thanks for your advice. I'll update the commit log in V2.
If the following changes are appropriate?
net/ice: fix txq vector path selection
If Tx vector mode is disabled, the txq vector mode should be disabled too.
This patch adds checking of Tx vector mode before enabling txq vector m
Originally, the default RSS for GTPU is inner fields. Now, we hope outer
RSS for GTPU to be the default.
Since RSS for ipv4, RSS for ipv6, RSS for UDP and RSS for TCP can cover
the cases of outer RSS for GTPU, this patch deletes redundant default
RSS configurations for GTPU.
Signed-off-by: Wenjun
> -Original Message-
> From: Huisong Li
> Sent: Tuesday, May 4, 2021 09:46
> To: Li, Xiaoyun
> Cc: Yigit, Ferruh ; dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v2 1/2] app/testpmd: add link speed check
> before port start
>
>
> 在 2021/4/30 12:46, Li, Xiaoyun 写道:
> >
> >> -Origina
On 2021/5/6 5:37, Thomas Monjalon wrote:
> 15/04/2021 09:12, Min Hu (Connor):
>> From: Chengchang Tang
>>
>> Timer sample example assumes that the frequency of the timer is about
>> 2Ghz to control the period of calling rte_timer_manage(). But this
>> assumption is easy to fail. For example. th
On April 29, 2021 11:00 PM, Ferruh Yigit wrote:
> On 4/29/2021 11:33 AM, Jiawen Wu wrote:
> > Add the dev_started check to remove the limitation of VF MTU setting.
> > When device is stopped, it is allowed to set MTU bigger than mbuf size.
> > Scattered rx may be enabled in next starting, exempt fr
06/05/2021 00:45, Tyler Retzlaff:
> as a side question, what is the projects stance on getting more warnings
> clean? there are a few not enabled that i'd really like to see e.g.
> format, conversion, truncation etc..
>
> i looked at lib/eal previously and there are... hundreds? of instances so
>
A new DPDK release candidate is ready for testing:
https://git.dpdk.org/dpdk/tag/?id=v21.05-rc2
There are 296 new patches in this snapshot,
most of them adding or fixing features in drivers.
Release notes:
https://doc.dpdk.org/guides/rel_notes/release_21_05.html
Please test and r
On Wed, May 05, 2021 at 11:39:23PM +0200, Thomas Monjalon wrote:
> 05/05/2021 18:00, Tyler Retzlaff:
> > On Tue, May 04, 2021 at 09:48:22AM +0300, Dmitry Kozlyuk wrote:
> > > >
> > > > what was the -Wformat clang on windows complaint?
> > >
> > > PRIx16 would work, but I noticed that in other pla
This fixes -Wformat warning with clang 10.0.0 on Windows.
Fixes: f8244c6399d9 ("ethdev: increase port id range")
Cc: sta...@dpdk.org
Signed-off-by: Dmitry Kozlyuk
Acked-by: Tyler Retzlaff
---
v3: PRIx16 -> PRIu16
v2: u% and a cast -> PRIx16 (Tyler, Thomas)
examples/rxtx_callbacks/main.c | 2 +-
05/05/2021 23:31, Owen Hilyard:
> The Intel 10G and Intel 40G systems at the community lab had test jobs
> begin to crash a few hours ago. This was the result of DTS crashing
> severely enough that the job was unable to continue. A brief investigation
> makes it seem like the "-a" flag for testpmd
This fixes -Wformat warning with clang 10.0.0 on Windows.
Fixes: f8244c6399d9 ("ethdev: increase port id range")
Cc: sta...@dpdk.org
Signed-off-by: Dmitry Kozlyuk
Acked-by: Tyler Retzlaff
---
v2: use PRIx16 instead of %u and a cast (Tyler, Thomas).
examples/rxtx_callbacks/main.c | 2 +-
1 fil
23/04/2021 10:56, David Hunt:
>
> On 21/4/2021 11:45 AM, Reshma Pattan wrote:
> > VM channel number should not be validated against the
> > host vm_power_manager coremask core indexes, as VM
> > cores need not to be same as host cores.
> > So remove this check, to allow all the vm channels
> > to
05/05/2021 18:00, Tyler Retzlaff:
> On Tue, May 04, 2021 at 09:48:22AM +0300, Dmitry Kozlyuk wrote:
> > 2021-05-03 17:11 (UTC-0700), Tyler Retzlaff:
> > > On Sun, May 02, 2021 at 05:56:56AM +0300, Dmitry Kozlyuk wrote:
> > > > Use "%u" and a cast as in other places when port ID is formatted.
> > >
15/04/2021 09:12, Min Hu (Connor):
> From: Chengchang Tang
>
> Timer sample example assumes that the frequency of the timer is about
> 2Ghz to control the period of calling rte_timer_manage(). But this
> assumption is easy to fail. For example. the frequency of tsc on ARM64
> is much less than 2G
The Intel 10G and Intel 40G systems at the community lab had test jobs
begin to crash a few hours ago. This was the result of DTS crashing
severely enough that the job was unable to continue. A brief investigation
makes it seem like the "-a" flag for testpmd has been removed, which is
causing the t
05/05/2021 12:43, Van Haaren, Harry:
> From: Chengwen Feng
> >
> > This patch adds checking for service core index validity when parsing
> > service corelist.
> >
> > Fixes: 7dbd7a6413ef ("service: add -S corelist option")
> > Cc: sta...@dpdk.org
> >
> > Signed-off-by: Chengwen Feng
> > Signed
22/04/2021 07:05, Li, Xiaoyun:
> > From: Chengwen Feng
> >
> > This patch adds checking spad user index validity when set or get attr.
> >
> > Fixes: 277310027965 ("raw/ntb: introduce NTB raw device driver")
> > Cc: sta...@dpdk.org
> >
> > Signed-off-by: Chengwen Feng
> > Signed-off-by: Min Hu
On Tue, May 4, 2021 at 2:43 PM David Marchand wrote:
>
> Keep the list of socs in a single place and include it so that the
> documentation won't get outdated.
>
> Fixes: 8f5ea6a464ac ("config/arm: fix implementer and its SoCs")
> Fixes: 1b4c86a721c9 ("config/arm: add Marvell CN10K")
> Fixes: 7cf3
21/04/2021 08:08, Min Hu (Connor):
> 在 2021/4/21 12:54, Li, Xiaoyun 写道:
> > From: Min Hu (Connor)
> >> 在 2021/4/21 11:31, Li, Xiaoyun 写道:
> >>> From: Min Hu (Connor)
> From: Chengwen Feng
> --- a/drivers/raw/ntb/ntb.c
> +++ b/drivers/raw/ntb/ntb.c
> index = a
On Wed, May 5, 2021 at 6:30 PM Tyler Retzlaff
wrote:
>
> On Fri, Mar 12, 2021 at 09:07:22AM +0100, David Marchand wrote:
> > On Thu, Mar 11, 2021 at 10:08 PM Tyler Retzlaff
> > wrote:
> > >
> > > Avoid expanding v and mul parameters multiple times in the macro. based
> > > on usage of the macro i
05/05/2021 17:30, Bruce Richardson:
> On Wed, May 05, 2021 at 07:55:25PM +0530, jer...@marvell.com wrote:
> > From: Jerin Jacob
> >
> > Move pkg-config override to beginning in the Makefile to allow
> > use PKGCONF variable to detect the libdpdk availability.
> >
> > Fixes: fda34680eb9a ("exampl
> > The variable inc_dir is not defined in this file.
> >
> > Fixes: 4cd1c5fd9ed4 ("regex/octeontx2: introduce REE driver")
> > Cc: sta...@dpdk.org
> >
> > Signed-off-by: Thomas Monjalon
>
> Acked-by: Guy Kaneti
Applied
05/05/2021 17:34, Bruce Richardson:
> On Wed, May 05, 2021 at 04:21:05PM +0200, David Marchand wrote:
> > Most of the checks on developer_mode have been accidentally dropped.
> > Restore them.
> >
> > Fixes: 7d611e35b077 ("lib: simplify main build file")
> >
> > Signed-off-by: David Marchand
> >
On Tue, May 04, 2021 at 03:25:04PM +0100, Vladimir Medvedkin wrote:
> rte_thash_adjust_tuple() uses random to generate a new subtuple if
> fn() callback reports about collision. In some cases random changes
> the subtuple in a way that after complementary bits are applied the
> original tuple is ob
Function print_fdir_mask and print_fdir_flex_payload is only called
when either i40e or ixgbe presents. Add #if defined to remove
"unused function" compilation warning.
Signed-off-by: Jie Zhou
Signed-off-by: Jie Zhou
Acked-by: Tal Shnaiderman
---
app/test-pmd/config.c | 82
From: Jie Zhou
- Disable unsupported Apps on Windows
- Enable building of testpmd on Windows
Signed-off-by: Jie Zhou
Signed-off-by: Jie Zhou
Acked-by: Tal Shnaiderman
---
app/meson.build| 4
app/pdump/meson.build | 6 ++
app/proc-info/meson.build
- Make printf format OS independent
- Replace htons with RTE_BE16
- Replace POSIX specific inet_aton with OS independent inet_pton
- Replace sleep with rte_delay_us_sleep
- Repalce random with rte_rand
- #ifndef mman related code for now
Signed-off-by: Jie Zhou
Signed-off-by: Jie Zhou
---
Resolve name collisions with Windows types
Signed-off-by: Jie Zhou
Signed-off-by: Jie Zhou
Acked-by: Tal Shnaiderman
---
app/test-pmd/cmdline_flow.c | 512 ++--
1 file changed, 256 insertions(+), 256 deletions(-)
diff --git a/app/test-pmd/cmdline_flow.c b/app/t
Replace parse_fec_mode misleading return type name mode with fec_capa
Fixes: b19da32e3151 ("app/testpmd: add FEC command")
Cc: sta...@dpdk.org
Signed-off-by: Jie Zhou
Signed-off-by: Jie Zhou
---
app/test-pmd/cmdline.c | 6 +++---
app/test-pmd/config.c | 4 ++--
app/test-pmd/testpmd.h | 2 +-
- Include rte_os_shim.h in testpmd.h
- Remove redundant headers
Signed-off-by: Jie Zhou
Signed-off-by: Jie Zhou
Acked-by: Tal Shnaiderman
---
app/test-pmd/cmdline.c | 3 ---
app/test-pmd/cmdline_flow.c | 2 --
app/test-pmd/parameters.c | 1 -
app/test-pmd/testpmd.h | 1 +
4 files c
Add required macros by testpmd on Windows in rte_os_shim.h
Signed-off-by: Jie Zhou
Signed-off-by: Jie Zhou
Acked-by: Tal Shnaiderman
---
lib/eal/windows/include/rte_os_shim.h | 9 +
1 file changed, 9 insertions(+)
diff --git a/lib/eal/windows/include/rte_os_shim.h
b/lib/eal/windows/i
Add clock_gettime on Windows in rte_os_shim.h
Signed-off-by: Jie Zhou
Signed-off-by: Jie Zhou
---
lib/eal/windows/include/rte_os_shim.h | 38 +++
1 file changed, 38 insertions(+)
diff --git a/lib/eal/windows/include/rte_os_shim.h
b/lib/eal/windows/include/rte_os_shim.h
This patchset is to enable testpmd on windows. It mainly includes:
- Enable building libraries on Windows that testpmd depends on
- Add necessary macros required by testpmd on Windows in rte_os_shim.h
- Add device event stubs for Windows
- Resolve name collisions with Windows types
- Add clock_gett
Add device event stubs in eal_dev.c for Windows
Signed-off-by: Jie Zhou
Signed-off-by: Jie Zhou
Acked-by: Tal Shnaiderman
---
lib/eal/windows/eal_dev.c | 33 +
lib/eal/windows/meson.build | 1 +
2 files changed, 34 insertions(+)
create mode 100644 lib/eal/wi
Enable building libraries that testpmd depends on for Windows
Signed-off-by: Jie Zhou
Signed-off-by: Jie Zhou
---
lib/meson.build | 7 +++
1 file changed, 7 insertions(+)
diff --git a/lib/meson.build b/lib/meson.build
index 64a59abab..3fd1ffa0b 100644
--- a/lib/meson.build
+++ b/lib/meson.
The admin-configured vNIC settings (i.e. via CIMC or UCSM) now include
Geneve offload. Use that setting to decide whether to enable or
disable Geneve offload and remove the devarg 'geneve-opt'.
Also, the firmware now allows the driver to change the Geneve port
number. So extend udp_tunnel_port_{ad
On 5/5/2021 1:23 PM, Bing Zhao wrote:
> In the release notes and mlx5 NIC document, the support and
> limitation of connection tracking are added.
>
A new NIC feature seems added, better to be acked beyond the mlx5 scope.
> Signed-off-by: Bing Zhao
> Acked-by: Viacheslav Ovsiienko
> ---
> doc
> -Original Message-
> From: Medvedkin, Vladimir
> Sent: Tuesday, May 4, 2021 7:25 AM
> To: dev@dpdk.org
> Cc: Ananyev, Konstantin ; Chilikin, Andrey
> ; Kinsella, Ray ; Wang,
> Yipeng1 ; Gobriel, Sameh
> ; Richardson, Bruce
> ; david.march...@redhat.com;
> k...@semihalf.com; Medvedkin, Vl
On 5/4/2021 10:12 AM, Gregory Etelson wrote:
> Hello Ferruh,
>
> [:snip:]
>
>> Hi Gregory,
>>
>> The were some questions around testpmd part of this patch in previous
>> version, they are not answered and this version is dropping the testpmd
>> part.
>>
>
> The tunnel offload API allows applicat
Function print_fdir_mask and print_fdir_flex_payload is only called
when either i40e or ixgbe presents. Add #if defined to remove
"unused function" compilation warning.
Signed-off-by: Jie Zhou
Signed-off-by: Jie Zhou
Acked-by: Tal Shnaiderman
---
app/test-pmd/config.c | 82
Resolve name collisions with Windows types
Signed-off-by: Jie Zhou
Signed-off-by: Jie Zhou
Acked-by: Tal Shnaiderman
---
app/test-pmd/cmdline_flow.c | 512 ++--
1 file changed, 256 insertions(+), 256 deletions(-)
diff --git a/app/test-pmd/cmdline_flow.c b/app/
- Make printf format OS independent
- Replace htons with RTE_BE16
- Replace POSIX specific inet_aton with OS independent inet_pton
- Replace sleep with rte_delay_us_sleep
- Repalce random with rte_rand
- #ifndef mman related code for now
Signed-off-by: Jie Zhou
Signed-off-by: Jie Zhou
---
Add clock_gettime on Windows in rte_os_shim.h
Signed-off-by: Jie Zhou
Signed-off-by: Jie Zhou
---
lib/eal/windows/include/rte_os_shim.h | 38 +++
1 file changed, 38 insertions(+)
diff --git a/lib/eal/windows/include/rte_os_shim.h
b/lib/eal/windows/include/rte_os_shim.h
From: Jie Zhou
- Disable unsupported Apps on Windows
- Enable building of testpmd on Windows
Signed-off-by: Jie Zhou
Signed-off-by: Jie Zhou
Acked-by: Tal Shnaiderman
---
app/meson.build| 4
app/pdump/meson.build | 6 ++
app/proc-info/meson.build
- Include rte_os_shim.h in testpmd.h
- Remove redundant headers
Signed-off-by: Jie Zhou
Signed-off-by: Jie Zhou
Acked-by: Tal Shnaiderman
---
app/test-pmd/cmdline.c | 3 ---
app/test-pmd/cmdline_flow.c | 2 --
app/test-pmd/parameters.c | 1 -
app/test-pmd/testpmd.h | 1 +
4 files c
Future work:
- Some issues discovered at validation need further investigations
* Perf inconsistency: TPUT fluctuated significantly from runs
* After traffic stop, port stats shows pps being 0 while bps not
* mempool allocation only succeed with native. Other methods failed
at rte_mem_loc
Replace parse_fec_mode misleading return type name mode with fec_capa
Fixes: b19da32e3151 ("app/testpmd: add FEC command")
Cc: sta...@dpdk.org
Signed-off-by: Jie Zhou
Signed-off-by: Jie Zhou
---
app/test-pmd/cmdline.c | 6 +++---
app/test-pmd/config.c | 4 ++--
app/test-pmd/testpmd.h | 2 +-
Add device event stubs in eal_dev.c for Windows
Signed-off-by: Jie Zhou
Signed-off-by: Jie Zhou
Acked-by: Tal Shnaiderman
---
lib/eal/windows/eal_dev.c | 33 +
lib/eal/windows/meson.build | 1 +
2 files changed, 34 insertions(+)
create mode 100644 lib/eal/w
Enable building libraries that testpmd depends on for Windows
Signed-off-by: Jie Zhou
Signed-off-by: Jie Zhou
---
lib/meson.build | 7 +++
1 file changed, 7 insertions(+)
diff --git a/lib/meson.build b/lib/meson.build
index c9a20f65b..2d499b238 100644
--- a/lib/meson.build
+++ b/lib/meson.
Add required macros by testpmd on Windows in rte_os_shim.h
Signed-off-by: Jie Zhou
Signed-off-by: Jie Zhou
Acked-by: Tal Shnaiderman
---
lib/eal/windows/include/rte_os_shim.h | 9 +
1 file changed, 9 insertions(+)
diff --git a/lib/eal/windows/include/rte_os_shim.h
b/lib/eal/windows/
Hi,
> -Original Message-
> From: Bing Zhao
> Sent: Wednesday, May 5, 2021 3:23 PM
> To: Slava Ovsiienko ; Matan Azrad
> ; NBU-Contact-Thomas Monjalon
>
> Cc: dev@dpdk.org; Ori Kam ; Raslan Darawsheh
>
> Subject: [PATCH v7 00/17] conntrack support in mlx5 PMD
>
> This patch set adds the
From: Jie Zhou
- Disable unsupported Apps on Windows
- Enable building of testpmd on Windows
Signed-off-by: Jie Zhou
Signed-off-by: Jie Zhou
Acked-by: Tal Shnaiderman
---
app/meson.build| 4
app/pdump/meson.build | 6 ++
app/proc-info/meson.build
Resolve name collisions with Windows types
Signed-off-by: Jie Zhou
Signed-off-by: Jie Zhou
Acked-by: Tal Shnaiderman
---
app/test-pmd/cmdline_flow.c | 512 ++--
1 file changed, 256 insertions(+), 256 deletions(-)
diff --git a/app/test-pmd/cmdline_flow.c b/app/
Function print_fdir_mask and print_fdir_flex_payload is only called
when either i40e or ixgbe presents. Add #if defined to remove
"unused function" compilation warning.
Signed-off-by: Jie Zhou
Signed-off-by: Jie Zhou
Acked-by: Tal Shnaiderman
---
app/test-pmd/config.c | 82 +++
- Make printf format OS independent
- Replace htons with RTE_BE16
- Replace POSIX specific inet_aton with OS independent inet_pton
- Replace sleep with rte_delay_us_sleep
- Repalce random with rte_rand
- #ifndef mman related code for now
Signed-off-by: Jie Zhou
Signed-off-by: Jie Zhou
---
- Include rte_os_shim.h in testpmd.h
- Remove redundant headers
Signed-off-by: Jie Zhou
Signed-off-by: Jie Zhou
Acked-by: Tal Shnaiderman
---
app/test-pmd/cmdline.c | 3 ---
app/test-pmd/cmdline_flow.c | 2 --
app/test-pmd/parameters.c | 1 -
app/test-pmd/testpmd.h | 1 +
4 files
Replace parse_fec_mode misleading return type name mode with fec_capa
Fixes: b19da32e3151 ("app/testpmd: add FEC command")
Cc: sta...@dpdk.org
Signed-off-by: Jie Zhou
Signed-off-by: Jie Zhou
---
app/test-pmd/cmdline.c | 6 +++---
app/test-pmd/config.c | 4 ++--
app/test-pmd/testpmd.h | 2 +-
Add clock_gettime on Windows in rte_os_shim.h
Signed-off-by: Jie Zhou
Signed-off-by: Jie Zhou
---
lib/eal/windows/include/rte_os_shim.h | 38 +++
1 file changed, 38 insertions(+)
diff --git a/lib/eal/windows/include/rte_os_shim.h
b/lib/eal/windows/include/rte_os_shim.h
Add device event stubs in eal_dev.c for Windows
Signed-off-by: Jie Zhou
Signed-off-by: Jie Zhou
Acked-by: Tal Shnaiderman
---
lib/eal/windows/eal_dev.c | 33 +
lib/eal/windows/meson.build | 1 +
2 files changed, 34 insertions(+)
create mode 100644 lib/eal/w
This patchset is to enable testpmd on windows. It mainly includes:
- Enable building libraries on Windows that testpmd depends on
- Add necessary macros required by testpmd on Windows in rte_os_shim.h
- Add device event stubs for Windows
- Resolve name collisions with Windows types
- Add clock_gett
Enable building libraries that testpmd depends on for Windows
Signed-off-by: Jie Zhou
Signed-off-by: Jie Zhou
---
lib/meson.build | 7 +++
1 file changed, 7 insertions(+)
diff --git a/lib/meson.build b/lib/meson.build
index c9a20f65b..2d499b238 100644
--- a/lib/meson.build
+++ b/lib/meson.
Add required macros by testpmd on Windows in rte_os_shim.h
Signed-off-by: Jie Zhou
Signed-off-by: Jie Zhou
Acked-by: Tal Shnaiderman
---
lib/eal/windows/include/rte_os_shim.h | 9 +
1 file changed, 9 insertions(+)
diff --git a/lib/eal/windows/include/rte_os_shim.h
b/lib/eal/windows/
This patch enable out-of-place auth-cipher operations where
digest should be encrypted among with the rest of raw data.
It also adds support for partially encrypted digest when using
auth-cipher operations.
Fixes: 7c87e2d7b359 ("crypto/snow3g: use IPsec library")
Cc: pablo.de.lara.gua...@intel.com
On Wed, May 05, 2021 at 12:37:50AM +, Honnappa Nagarahalli wrote:
>
>
>
> > > >
> > > > your subject line indicates the use of C11 which is a standard [1].
> > > >
> > > > the patch itself uses gcc atomics builtins which are not part of C11
> > > > standard so the subject line is incorrect a
On Wed, May 05, 2021 at 09:09:20AM -0700, Jie Zhou wrote:
> On Wed, May 05, 2021 at 08:34:34AM +, Tal Shnaiderman wrote:
> > > Subject: [PATCH v10 07/10] app/testpmd: replace POSIX specific code
> > >
> > > External email: Use caution opening links or attachments
> > >
> > >
> > > - Make pr
On Fri, Mar 12, 2021 at 09:07:22AM +0100, David Marchand wrote:
> On Thu, Mar 11, 2021 at 10:08 PM Tyler Retzlaff
> wrote:
> >
> > Avoid expanding v and mul parameters multiple times in the macro. based
> > on usage of the macro it seems like side effects were not intended.
> >
> > For example:
>
On Wed, May 5, 2021 at 5:36 PM Bruce Richardson
wrote:
>
> On Wed, May 05, 2021 at 03:22:48PM +, Ciara Power wrote:
> > The list_commands() function accessed the callbacks list,
> > but did not take the lock. This may have caused inconsistencies if
> > callbacks were being registered at the sa
On Tue, May 4, 2021 at 6:19 PM Power, Ciara wrote:
> >> Remove TELEMETRY_MAX_CALLBACKS symbol from public rte_telemetry.h
> >> header file.
> >>
> >> Signed-off-by: Jerin Jacob
> >Acked-by: Bruce Richardson
> Acked-by: Ciara Power
Applied, thanks.
I'll post my suggestion as a patch aimed at 2
On Wed, May 05, 2021 at 08:34:34AM +, Tal Shnaiderman wrote:
> > Subject: [PATCH v10 07/10] app/testpmd: replace POSIX specific code
> >
> > External email: Use caution opening links or attachments
> >
> >
> > - Make printf format OS independent
> > - Replace htons with RTE_BE16
> > - Rep
On Tue, May 04, 2021 at 09:48:22AM +0300, Dmitry Kozlyuk wrote:
> 2021-05-03 17:11 (UTC-0700), Tyler Retzlaff:
> > On Sun, May 02, 2021 at 05:56:56AM +0300, Dmitry Kozlyuk wrote:
> > > Use "%u" and a cast as in other places when port ID is formatted.
> > > This fixes -Wformat warning with clang 10.
On Tue, May 04, 2021 at 09:31:08AM +0200, Thomas Monjalon wrote:
> When you receive an ack in previous versions,
> you should add it manually in your patch
> so we keep track of it.
>
Will send out V11 with adding back the acked-by from V9. Thanks.
Updated AESNI MB and AESNI GCM, KASUMI, ZUC and SNOW3G PMD documentation
guides with information about the latest Intel IPSec Multi-buffer
library supported.
Signed-off-by: Pablo de Lara
---
doc/guides/cryptodevs/aesni_gcm.rst | 6 +++---
doc/guides/cryptodevs/aesni_mb.rst | 6 +++---
doc/guide
On Tue, May 04, 2021 at 09:36:24AM +, Ananyev, Konstantin wrote:
>
>
> >
> > 2021-04-29 09:16 (UTC-0700), Tyler Retzlaff:
> > > On Wed, Apr 07, 2021 at 05:10:00PM +0100, Ferruh Yigit wrote:
> > > > On 4/7/2021 4:25 PM, Hemant Agrawal wrote:
> > > > >>+1
> > > > >>But are we going to check al
HI Haifei,
> -Original Message-
> From: Dumitrescu, Cristian
> Sent: Monday, May 3, 2021 3:11 PM
> Subject: RE: [PATCH] app/testpmd: support meter color action in policy
>
>
>
> > -Original Message-
> > From: Yigit, Ferruh
> > Sent: Friday, April 30, 2021 1:51 PM
> > To: Haife
On Wed, May 05, 2021 at 03:22:48PM +, Ciara Power wrote:
> The list_commands() function accessed the callbacks list,
> but did not take the lock. This may have caused inconsistencies if
> callbacks were being registered at the same time.
> This is now fixed to lock before iterating the list,
>
On Wed, May 05, 2021 at 04:21:05PM +0200, David Marchand wrote:
> Most of the checks on developer_mode have been accidentally dropped.
> Restore them.
>
> Fixes: 7d611e35b077 ("lib: simplify main build file")
>
> Signed-off-by: David Marchand
> ---
Thanks.
Acked-by: Bruce Richardson
On Wed, May 05, 2021 at 07:55:25PM +0530, jer...@marvell.com wrote:
> From: Jerin Jacob
>
> Move pkg-config override to beginning in the Makefile to allow
> use PKGCONF variable to detect the libdpdk availability.
>
> Fixes: fda34680eb9a ("examples: remove legacy sections of makefiles")
> Cc: st
> Copy over the offset data required for auth in out-of-place op
> when auth offset and cipher offset are not aligned.
>
> Fixes: e847fc512817 ("test/crypto: add encrypted digest case for AES-CTR-
> CMAC")
> Cc: adamx.dybkow...@intel.com
>
> Signed-off-by: Kai Ji
> ---
> v2:
>- rebase to hea
The list_commands() function accessed the callbacks list,
but did not take the lock. This may have caused inconsistencies if
callbacks were being registered at the same time.
This is now fixed to lock before iterating the list,
and unlock afterwards.
Fixes: f38748736eb2 ("telemetry: add default ca
> The init function was calling the dpseci_open
> while dpseci_close was called by the open function.
> This is a mismatch un-init shall clean the init configurations and
> close shall clear the configure function settings.
>
> This was causing issue with recent changes in test framework, where
>
> DPAA requires the I/O shall be done in a HW portal context only.
> The portal affinity is currently only being done in session create
> and config APIs with the assumption that same thread will be used
> for IO. This is causing issue.
> This patch add support during I/O to check the HW portal aff
> > Subject: [dpdk-dev] test/crypto: fix auth-cipher compare length in oop
> >
> > For out-of-place operations, comparing expected ciphertext with
> > the operation result should skip cipher_offset bytes, as those
> > will not be copied from source to the destination buffer, making
> > the tests fa
> Return value of a function 'rte_zmalloc' is dereferenced without
> checking, and it may call segmentation fault.
>
> This patch fixed it.
>
> Fixes: f8be1786b1b8 ("app/crypto-perf: introduce performance test
> application")
> Cc: sta...@dpdk.org
>
> Signed-off-by: Min Hu (Connor)
> ---
> v2:
On Tue, Mar 23, 2021 at 6:48 PM Piotr Kubaj wrote:
>
> Looks like I forgot to commit the change that includes headers for
> sysctlbyname().
>
> Patch attached.
The mailing list drops attachments.
Please submit a v2.
Thanks.
--
David Marchand
1 - 100 of 242 matches
Mail list logo
