[dpdk-dev] [PATCH v1] net/ice/base: fix inner L4 offset for gptu dummy packet

2021-04-25 Thread Yuying Zhang
Fix inner L4 offset of ipv6_gtpu_ipv6_tcp/udp dummy packet. Fixes: bd4d9a89dbc1 ("net/ice/base: add GTP filtering via advanced switch filter") Cc: sta...@dpdk.org Signed-off-by: Yuying Zhang --- drivers/net/ice/base/ice_switch.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff -

[dpdk-dev] [PATCH v4 2/2] net/ice: refactor input set fields for switch filter

2021-04-25 Thread Yuying Zhang
Input set has been divided into inner and outer part to distinguish different fields. However, the parse method of switch filter doesn't match this update. Refactor switch filter to distingush inner and outer input set in the same way as other filters. Signed-off-by: Yuying Zhang --- v4: - Chan

[dpdk-dev] [PATCH v4 1/2] net/ice: clean redundant macro definition of filters

2021-04-25 Thread Yuying Zhang
The input set has been divided into two parts to distinguish inner and outer field. ICE_INSET_TUN_* is the same as non tunnel macro definition. Clean redundant ICE_INSET_TUN_* codes. Signed-off-by: Yuying Zhang --- drivers/net/ice/ice_fdir_filter.c | 22 ++--- drivers/net/ice/ice_generic_flow

Re: [dpdk-dev] [PATCH v3 2/2] ring: use wfe to wait for ring tail update on aarch64

2021-04-25 Thread Jerin Jacob
On Sun, Apr 25, 2021 at 11:27 AM Ruifeng Wang wrote: > > Instead of polling for tail to be updated, use wfe instruction. > > Signed-off-by: Gavin Hu > Signed-off-by: Ruifeng Wang > Reviewed-by: Steve Capper > Reviewed-by: Ola Liljedahl > Reviewed-by: Honnappa Nagarahalli > Acked-by: Konstanti

[dpdk-dev] [PATCH] net/iavf: fix performance drop

2021-04-25 Thread Wenzhuo Lu
AVX2 and SSE don't have the offload path. Not necessary doing any check. Or the scalar path will be chosen. Fixes: eff56a7b9f97 ("net/iavf: add offload path for Rx AVX512") Signed-off-by: Wenzhuo Lu --- drivers/net/iavf/iavf_rxtx.c | 12 +--- 1 file changed, 5 insertions(+), 7 deletions

Re: [dpdk-dev] [PATCH] vdpa/mlx5: improve portability of thread naming

2021-04-25 Thread Xia, Chenbo
> -Original Message- > From: dev On Behalf Of Thomas Monjalon > Sent: Thursday, April 22, 2021 1:59 AM > To: dev@dpdk.org > Cc: Matan Azrad ; Viacheslav Ovsiienko > > Subject: [dpdk-dev] [PATCH] vdpa/mlx5: improve portability of thread naming > > The function pthread_setname_np is non-po

Re: [dpdk-dev] [PATCH v2] net/iavf: fix PF returning error

2021-04-25 Thread Zhang, Qi Z
> -Original Message- > From: dev On Behalf Of Xing, Beilei > Sent: Monday, April 26, 2021 9:34 AM > To: Zhang, AlvinX ; Wu, Jingjing > > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2] net/iavf: fix PF returning error > > > > > -Original Message- > > F

[dpdk-dev] [PATCH 6/6] net/hns3: fix vector Rx burst default value

2021-04-25 Thread Min Hu (Connor)
From: Chengwen Feng Currently, driver uses the macro HNS3_DEFAULT_RX_BURST whose value is 32 to limit the vector Rx burst size, as a result, the burst size user configure can't exceed 32. This patch fixes this problem by defining the macro HNS3_DEFAULT_RX_BURST as 64. Fixes: a3d4f4d291d7 ("net/

[dpdk-dev] [PATCH 4/6] net/hns3: improve IO path data cache usage

2021-04-25 Thread Min Hu (Connor)
From: Chengwen Feng This patch improves data cache usage by: 1. Rearrange the rxq frequency accessed fields in the IO path to the first 128B. 2. Rearrange the txq frequency accessed fields in the IO path to the first 64B. 3. Make sure ptype table align cacheline size which is 128B instead of min

[dpdk-dev] [PATCH 5/6] net/hns3: log fdir configuration

2021-04-25 Thread Min Hu (Connor)
From: Chengwen Feng The rte flow interface does not support the API of the capability set. Therefore, fdir configuration logs are added to facilitate debugging. Signed-off-by: Chengwen Feng Signed-off-by: Min Hu (Connor) --- drivers/net/hns3/hns3_fdir.c | 13 + 1 file changed, 13

[dpdk-dev] [PATCH 0/6] optimization and bugfix for hns3 PMD

2021-04-25 Thread Min Hu (Connor)
This patch set contains one patch for performance optimization, this is: 'net/hns3: improve IO path data cache usage'. The others are bugfixes for hns3 PMD. Chengwen Feng (6): net/hns3: delete some unused capabilities net/hns3: modify write reg opt API impl net/hns3: use RTE DIM instead of A

[dpdk-dev] [PATCH 3/6] net/hns3: use RTE DIM instead of ARRAY SIZE

2021-04-25 Thread Min Hu (Connor)
From: Chengwen Feng This patch uses RTE_DIM() instead of ARRAY_SIZE(). Signed-off-by: Chengwen Feng Signed-off-by: Min Hu (Connor) --- drivers/net/hns3/hns3_cmd.c| 4 ++-- drivers/net/hns3/hns3_ethdev.h | 2 -- drivers/net/hns3/hns3_flow.c | 18 +- drivers/net/hns3/hns

[dpdk-dev] [PATCH 1/6] net/hns3: delete some unused capabilities

2021-04-25 Thread Min Hu (Connor)
From: Chengwen Feng This patch deletes some unused capabilities, include: 1. Delete some unused firmware capabilities definition. 2. Delete some unused driver capabilities definition. Signed-off-by: Chengwen Feng Signed-off-by: Min Hu (Connor) --- drivers/net/hns3/hns3_cmd.c| 7 ---

[dpdk-dev] [PATCH 2/6] net/hns3: modify write reg opt API impl

2021-04-25 Thread Min Hu (Connor)
From: Chengwen Feng This patch modifies hns3_write_reg_opt() API implementation because the rte_write32() already uses rte_io_wmb(). Signed-off-by: Chengwen Feng Signed-off-by: Min Hu (Connor) --- drivers/net/hns3/hns3_ethdev.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) di

Re: [dpdk-dev] [PATCH v3 2/2] net/ice: refactor input set fields for switch filter

2021-04-25 Thread Zhang, Yuying
> -Original Message- > From: Zhang, Qi Z > Sent: Monday, April 26, 2021 9:48 AM > To: Zhang, Yuying ; dev@dpdk.org; Wang, Haiyue > > Cc: Yan, Zhirun ; Guo, Junfeng > Subject: RE: [PATCH v3 2/2] net/ice: refactor input set fields for switch > filter > > > > > -Original Message-

Re: [dpdk-dev] [PATCH v3 2/2] net/ice: refactor input set fields for switch filter

2021-04-25 Thread Zhang, Qi Z
> -Original Message- > From: Zhang, Yuying > Sent: Sunday, April 25, 2021 9:29 PM > To: dev@dpdk.org; Zhang, Qi Z ; Wang, Haiyue > > Cc: Yan, Zhirun ; Guo, Junfeng > ; Zhang, Yuying > Subject: [PATCH v3 2/2] net/ice: refactor input set fields for switch filter > > Input set has been

Re: [dpdk-dev] [PATCH v2] net/iavf: fix PF returning error

2021-04-25 Thread Xing, Beilei
> -Original Message- > From: Zhang, AlvinX > Sent: Sunday, April 25, 2021 3:40 PM > To: Wu, Jingjing ; Xing, Beilei > Cc: dev@dpdk.org; Zhang, AlvinX ; sta...@dpdk.org > Subject: [PATCH v2] net/iavf: fix PF returning error > > When the command sent by VF to PF fails, iavf may need to

Re: [dpdk-dev] [PATCH] net/iavf: fix incomplete rss initiation

2021-04-25 Thread Zhang, Qi Z
> -Original Message- > From: Ding, Xuan > Sent: Sunday, April 25, 2021 4:06 PM > To: Zhang, Qi Z ; Wu, Jingjing ; > Xing, Beilei > Cc: dev@dpdk.org; Ding, Xuan ; sta...@dpdk.org > Subject: [PATCH] net/iavf: fix incomplete rss initiation > > When the default RSS is disabled during init

Re: [dpdk-dev] [PATCH] app/bbdev: fix wrong variable

2021-04-25 Thread Min Hu (Connor)
在 2021/4/26 0:30, Thomas Monjalon 写道: Chautru, Nicolas: From: Min Hu (Connor) This patch corrected misused variable. Fixes: d819c08327f3 ("app/bbdev: update for 5GNR") Cc: sta...@dpdk.org Signed-off-by: Min Hu (Connor) Thanks Acked-by: Nicolas Chautru It is not enough. The commit

[dpdk-dev] [PATCH v2] app/bbdev: fix wrong variable

2021-04-25 Thread Min Hu (Connor)
The logging should show context by printing the two variable which compared to each other. 'nb_harq_inputs', not 'nb_hard_outputs'; 'nb_harq_outputs', not 'nb_hard_outputs'. This patch corrected misused variable. Fixes: d819c08327f3 ("app/bbdev: update for 5GNR") Cc: sta...@dpdk.org Signed-off-b

Re: [dpdk-dev] [PATCH v2 1/2] net/mlx5: fix tunnel offload private items location

2021-04-25 Thread Thomas Monjalon
Dim 25 avr 2021, à 19:01, Gregory Etelson a écrit : > Hello Thomas, > > > Dim 25 avr 2021, à 17:57, Gregory Etelson a écrit : > > > Tunnel offload API requires application to query PMD for specific flow > > > items and actions. Application uses these PMD specific elements to > > > build flow rule

Re: [dpdk-dev] [PATCH v2 1/2] net/mlx5: fix tunnel offload private items location

2021-04-25 Thread Gregory Etelson
Hello Thomas, > Dim 25 avr 2021, à 17:57, Gregory Etelson a écrit : > > Tunnel offload API requires application to query PMD for specific flow > > items and actions. Application uses these PMD specific elements to > > build flow rules according to the tunnel offload model. > > The model does not

Re: [dpdk-dev] [PATCH V4] ethdev: add queue state when retrieve queue information

2021-04-25 Thread Thomas Monjalon
Kinsella, Ray: > On 16/04/2021 10:57, Thomas Monjalon wrote: > > 16/04/2021 11:41, Ferruh Yigit: > >> On 4/16/2021 9:58 AM, Thomas Monjalon wrote: > >>> 16/04/2021 10:46, Lijun Ou: > Currently, upper-layer application could get queue state only > through pointers such as dev->data->tx_que

Re: [dpdk-dev] [PATCH] app/bbdev: fix wrong variable

2021-04-25 Thread Thomas Monjalon
Chautru, Nicolas: > From: Min Hu (Connor) > > > > This patch corrected misused variable. > > > > Fixes: d819c08327f3 ("app/bbdev: update for 5GNR") > > Cc: sta...@dpdk.org > > > > Signed-off-by: Min Hu (Connor) > > Thanks > > Acked-by: Nicolas Chautru It is not enough. The commit log must

Re: [dpdk-dev] [PATCH v2 1/2] net/mlx5: fix tunnel offload private items location

2021-04-25 Thread Thomas Monjalon
Dim 25 avr 2021, à 17:57, Gregory Etelson a écrit : > Tunnel offload API requires application to query PMD for specific flow > items and actions. Application uses these PMD specific elements to > build flow rules according to the tunnel offload model. > The model does not restrict private elements

Re: [dpdk-dev] [PATCH v4 1/8] bbdev: add network order data capability

2021-04-25 Thread Thomas Monjalon
Sam 24 avr 2021, à 23:59, Chautru, Nicolas a écrit : > + Thomas, Akhil > > In case this is for release 21.05 isn't it a bit late for introducing a > new API change? Yes API change should be in -rc1. Of course there is a bit of flexibility if you are sure an exception can be done without hurting

[dpdk-dev] [PATCH v2 2/2] app/testpmd: fix tunnel offload private items location

2021-04-25 Thread Gregory Etelson
Tunnel offload API requires application to query PMD for specific flow items and actions. Application uses these PMD specific elements to build flow rules according to the tunnel offload model. The model does not restrict private elements location in a flow rule, but the current MLX5 PMD implementa

[dpdk-dev] [PATCH v2 1/2] net/mlx5: fix tunnel offload private items location

2021-04-25 Thread Gregory Etelson
Tunnel offload API requires application to query PMD for specific flow items and actions. Application uses these PMD specific elements to build flow rules according to the tunnel offload model. The model does not restrict private elements location in a flow rule, but the current MLX5 PMD implementa

Re: [dpdk-dev] [PATCH v2 0/2] Use WFE for spinlock and ring

2021-04-25 Thread Thomas Monjalon
Ruifeng Wang: > From: David Marchand > > Any update? > > I suppose this would need some rebasing after the ring library changes. > > Sorry for the late response. > This series has been rebased and v3 posted. > I have problem to mark v2 as superseded. I did change v2 as superseded.

Re: [dpdk-dev] [PATCH] usertools/devbind: add dlb

2021-04-25 Thread Thomas Monjalon
Timothy McDaniel: > --- a/usertools/dpdk-devbind.py > +++ b/usertools/dpdk-devbind.py > @@ -59,11 +59,13 @@ > 'SVendor': None, 'SDevice': None} > intel_ntb_icx = {'Class': '06', 'Vendor': '8086', 'Device': '347e', > 'SVendor': None, 'SDevice': None} > +intel_dlb

[dpdk-dev] [PATCH v3 2/2] net/ice: refactor input set fields for switch filter

2021-04-25 Thread Yuying Zhang
Input set has been divided into inner and outer part to distinguish different fields. However, the parse method of switch filter doesn't match this update. Refactor switch filter to distingush inner and outer input set in the same way as other filters. Signed-off-by: Yuying Zhang --- drivers/net

[dpdk-dev] [PATCH v3 1/2] net/ice: clean redundant macro definition of filters

2021-04-25 Thread Yuying Zhang
The input set has been divided into two parts to distinguish inner and outer field. ICE_INSET_TUN_* is the same as non tunnel macro definition. Clean redundant ICE_INSET_TUN_* codes. Signed-off-by: Yuying Zhang --- drivers/net/ice/ice_fdir_filter.c | 22 ++--- drivers/net/ice/ice_generic_flow

[dpdk-dev] [PATCH] app/procinfo: add device registers dump

2021-04-25 Thread Min Hu (Connor)
From: Chengchang Tang This patch add support for dump the device registers from a running application. It can help developers locate the problem. Signed-off-by: Chengchang Tang Signed-off-by: Min Hu (Connor) --- app/proc-info/main.c | 92 +++- 1

[dpdk-dev] [PATCH] lib/librte_power: fix using variables before validity check

2021-04-25 Thread Min Hu (Connor)
From: HongBo Zheng In function power_guest_channel_read_msg, 'lcore_id' is used before validity check, which may cause buffer 'global_fds' accessed by index 'lcore_id' overflow. This patch moves the validity check of 'lcore_id' before the 'lcore_id' being used for the first time. Fixes: 9dc843e

[dpdk-dev] [PATCH] common/sfc_efx/base: fix the problem of using null pointer

2021-04-25 Thread Min Hu (Connor)
From: HongBo Zheng In function efx_pci_xilinx_cap_tbl_find, pointer entry_offsetp is used before null pointer check, which may cause access to null pointer. This patch fix this problem. Fixes: ba9568b8b4b7 ("common/sfc_efx/base: add Xilinx capabilities table lookup") Cc: sta...@dpdk.org Signe

[dpdk-dev] [PATCH] net/txgbe: fix null pointer check problem

2021-04-25 Thread Min Hu (Connor)
From: HongBo Zheng In function cons_parse_ntuple_filter, item->spec and item->mask should be confirmed not null before use memcmp on it, current judgement (item->spec || item->mask) just can confirm item->spec or item->mask is not null, and cause null pointer be used in memcmp. This patch fix th

[dpdk-dev] [PATCH 1/2] net/hns3: fix link status when port is stopped

2021-04-25 Thread Min Hu (Connor)
From: Huisong Li When port is stopped, link down should be reported to user. For HNS3 PF driver, link status comes from link status of hardware. If the port supports NCSI feature, hardware MAC will not be disabled. At this case, even if the port is stopped, the link status is still Up. So driver

[dpdk-dev] [PATCH 0/2] bugfix for link for hns3 PMD

2021-04-25 Thread Min Hu (Connor)
This patch set contains two bugfixes for hns3 PMD. Huisong Li (2): net/hns3: fix link status when port is stopped net/hns3: fix link speed when port is down drivers/net/hns3/hns3_ethdev.c | 18 +++--- 1 file changed, 15 insertions(+), 3 deletions(-) -- 2.7.4

[dpdk-dev] [PATCH 2/2] net/hns3: fix link speed when port is down

2021-04-25 Thread Min Hu (Connor)
From: Huisong Li When the port is link down state, it is meaningless to display the port link speed. It should be an undefined state. Fixes: 59fad0f32135 ("net/hns3: support link update operation") Cc: sta...@dpdk.org Signed-off-by: Huisong Li Signed-off-by: Min Hu (Connor) --- drivers/net/h

Re: [dpdk-dev] [dpdk-announce] release candidate 21.05-rc1

2021-04-25 Thread Jiang, YuX
All, Update the test status for Intel part. Till now 80% is executed, 80% is debuged and no critical issue blocked the test. # Basic Intel(R) NIC testing * Build or compile: *Build: cover the build test combination with latest GCC/Clang/ICC version and the popular OS revision such as Ubuntu20.0

[dpdk-dev] [DPDK] net/ice: fix txq mbuf release mode

2021-04-25 Thread Alvin Zhang
In some cases, it seems that the txq mbuf vector release mode is enabled first, and then it is confirmed that the conditions for using the vector mode are not met. This patch puts the txq vector mode startup process after the condition detection. Fixes: 28f9002ab67f ("net/ice: add Tx AVX512 offlo

Re: [dpdk-dev] [PATCH v3 0/7] test: refactor crypto unit test framework

2021-04-25 Thread Ruifeng Wang
> -Original Message- > From: Ciara Power > Sent: Saturday, April 24, 2021 12:18 AM > To: dev@dpdk.org > Cc: tho...@monjalon.net; declan.dohe...@intel.com; gak...@marvell.com; > acon...@redhat.com; hemant.agra...@nxp.com; ano...@marvell.com; > Ruifeng Wang ; asoma...@amd.com; Ajit > Khapard

[dpdk-dev] [PATCH] net/iavf: fix incomplete rss initiation

2021-04-25 Thread Xuan Ding
When the default RSS is disabled during initialization, the RSS should be turned on when creating RSS rule. This patch adds support to configure rss key and lookup table even when the default RSS is disabled. Fixes: c678299594a8 ("net/iavf: fix default RSS configuration") Cc: sta...@dpdk.org Sig

[dpdk-dev] [PATCH 2/4] net/txgbe: fix VF MTU limit setting

2021-04-25 Thread Jiawen Wu
Fix to set MTU bigger than mbuf size when device is stopped, scattered rx may be enabled in next starting, exempt from setting in EAL parameters. Fixes: a2beaa4a769e ("net/txgbe: support VF MTU update") Cc: sta...@dpdk.org Signed-off-by: Jiawen Wu --- drivers/net/txgbe/txgbe_ethdev_vf.c | 12 ++

[dpdk-dev] [PATCH 4/4] net/txgbe: add copyright owner

2021-04-25 Thread Jiawen Wu
All rights reserved by Beijing Wangxun Technology Co., Ltd. Part of the code references Intel. Signed-off-by: Jiawen Wu --- doc/guides/nics/txgbe.rst | 2 +- drivers/net/txgbe/base/meson.build| 2 +- drivers/net/txgbe/base/txgbe.h| 2 +- drivers/net/txgbe/base/txgbe_dcb.c

[dpdk-dev] [PATCH 1/4] net/txgbe: fix RSS in double VALN

2021-04-25 Thread Jiawen Wu
Regard QINQ as one case of extend VLAN, and always enable QINQ mode when double VLAN is set, to avoid RSS does not work for QINQ packets. Fixes: 220b0e49bc47 ("net/txgbe: support VLAN") Cc: sta...@dpdk.org Signed-off-by: Jiawen Wu --- drivers/net/txgbe/txgbe_ethdev.c | 12 1 file c

[dpdk-dev] [PATCH 3/4] net/txgbe: remove port representor

2021-04-25 Thread Jiawen Wu
Remove port representor in device probe process. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/txgbe_ethdev.c | 21 ++--- 1 file changed, 2 insertions(+), 19 deletions(-) diff --git a/drivers/net/txgbe/txgbe_ethdev.c b/drivers/net/txgbe/txgbe_ethdev.c index 87c041c2ec..afb25fb8

[dpdk-dev] [PATCH 0/4] Fixes for txgbe

2021-04-25 Thread Jiawen Wu
Fix some bugs, remove redundant code, add copyright. Jiawen Wu (4): net/txgbe: fix RSS in double VALN net/txgbe: fix VF MTU limit setting net/txgbe: remove port representor net/txgbe: add copyright owner doc/guides/nics/txgbe.rst | 2 +- drivers/net/txgbe/base/meson.build

[dpdk-dev] Recall: [PATCH v2] net/i40e: extend VF reset waiting time

2021-04-25 Thread Zhou, JunX W
Zhou, JunX W would like to recall the message, "[dpdk-dev] [PATCH v2] net/i40e: extend VF reset waiting time".

Re: [dpdk-dev] [PATCH v2] net/i40e: extend VF reset waiting time

2021-04-25 Thread Zhou, JunX W
> -Original Message- > From: dev On Behalf Of Wenjun Wu > Sent: Sunday, April 25, 2021 10:03 AM > To: dev@dpdk.org; Xing, Beilei > Cc: Wu, Wenjun1 > Subject: [dpdk-dev] [PATCH v2] net/i40e: extend VF reset waiting time Tested-by: Zhou, Jun

[dpdk-dev] [PATCH v2] net/iavf: fix PF returning error

2021-04-25 Thread Alvin Zhang
When the command sent by VF to PF fails, iavf may need to run different code paths according to the specific reason of the failure (not supported or other reasons). This patch adds support of identifying PF return error type. Fixes: 22b123a36d07 ("net/avf: initialize PMD") Cc: sta...@dpdk.org Si

[dpdk-dev] [Bug 688] [dpdk-21.05]metering_and_policing: Failed to add policy actions

2021-04-25 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=688 Bug ID: 688 Summary: [dpdk-21.05]metering_and_policing: Failed to add policy actions Product: DPDK Version: unspecified Hardware: All OS: All Status: UNC

Re: [dpdk-dev] [PATCH v17 4/8] eal/arm: update CPU flags

2021-04-25 Thread Ruifeng Wang
> -Original Message- > From: Juraj Linkeš > Sent: Thursday, April 22, 2021 8:49 PM > To: tho...@monjalon.net; david.march...@redhat.com; > bruce.richard...@intel.com; acon...@redhat.com; > maicolgabr...@hotmail.com; Honnappa Nagarahalli > ; Ruifeng Wang > ; jer...@marvell.com; vikto...@reh