[dpdk-dev] [PATCH] pipeline: fix deallocate null pointer

2021-04-21 Thread Min Hu (Connor)
From: HongBo Zheng Fix deallocate null pointer in instruction_config, while pointer 'data' or 'instr' may be null. Fixes: a1711f948dbf ("pipeline: add SWX Rx and extract instructions") Cc: sta...@dpdk.org Signed-off-by: HongBo Zheng Signed-off-by: Min Hu (Connor) --- lib/librte_pipeline/rte_

[dpdk-dev] [PATCH] raw/skeleton: fix return value check

2021-04-21 Thread Min Hu (Connor)
This patch adds return value check for setting an attribute. Fixes: 88a81bcecb7b ("raw/skeleton: remove compile-time constant for device id") Cc: sta...@dpdk.org Signed-off-by: Min Hu (Connor) --- drivers/raw/skeleton/skeleton_rawdev_test.c | 1 + 1 file changed, 1 insertion(+) diff --git a/dr

[dpdk-dev] [PATCH v1 1/1] power: add support for cppc cpufreq

2021-04-21 Thread Richael Zhuang
Currently in DPDK only acpi_cpufreq and pstate_cpufreq drivers are supported, which are both not available on arm64 platforms. Add support for cppc_cpufreq driver which works on most arm64 platforms. Signed-off-by: Richael Zhuang --- app/test/test_power.c | 3 +- app/test/test_power_c

[dpdk-dev] [PATCH v1 0/1] power: add support for cppc cpufreq driver

2021-04-21 Thread Richael Zhuang
v1: add support for cppc cpufreq driver Richael Zhuang (1): power: add support for cppc cpufreq app/test/test_power.c | 3 +- app/test/test_power_cpufreq.c | 3 +- lib/power/meson.build | 1 + lib/power/power_cppc_cpufreq.c | 807 + lib/

[dpdk-dev] [PATCH] test: fix flow classifier creating failure

2021-04-21 Thread Min Hu (Connor)
'cls->cls' will be NULL if flow classifier create has failed, then segmentation fault will occur if the variable is used. This patch fixed it. Fixes: 9c9befea4f57 ("test: add flow classify unit tests") Cc: sta...@dpdk.org Signed-off-by: Min Hu (Connor) --- app/test/test_flow_classify.c | 6 +++

[dpdk-dev] [PATCH v1] net/i40e: extend VF reset waiting time.

2021-04-21 Thread Wenjun Wu
When resetting VF, VF will issue reset command to PF, wait a fixed amount of time, and assume VF reset is done. However, due to the change of dpdk related library content, the original delay is not enough. When we use DPDK PF instead of kernel PF, it may cause VF start error. This patch extend VF

Re: [dpdk-dev] [PATCH v16 4/8] eal/arm: update CPU flags

2021-04-21 Thread Ruifeng Wang
> -Original Message- > From: Juraj Linkeš > Sent: Wednesday, April 21, 2021 10:28 PM > To: Juraj Linkeš ; tho...@monjalon.net; > david.march...@redhat.com; bruce.richard...@intel.com; > acon...@redhat.com; maicolgabr...@hotmail.com; Ruifeng Wang > ; jer...@marvell.com; vikto...@rehivetech.

[dpdk-dev] [PATCH v5] net/iavf: fix hash configuration on i40e VF

2021-04-21 Thread Alvin Zhang
In i40evf PMD, the VF directly accesses the hash enable registers to enable or disable hashing on ingress packets. When binding i40e VF to iavf, because the PF doesn't support VIRTCHNL_VF_OFFLOAD_ADV_RSS_PF capability. Therefore, the VF hashing cannot be enabled. This patch adds support of hash co

Re: [dpdk-dev] [PATCH 1/2] raw/ntb: check spad user index

2021-04-21 Thread Li, Xiaoyun
> -Original Message- > From: Min Hu (Connor) > Sent: Wednesday, April 21, 2021 10:08 > To: dev@dpdk.org > Cc: Yigit, Ferruh ; Li, Xiaoyun > ; > Wu, Jingjing > Subject: [PATCH 1/2] raw/ntb: check spad user index > > From: Chengwen Feng > > This patch adds checking spad user index valid

[dpdk-dev] [PATCH 3/3] kni: fix unchecked return value

2021-04-21 Thread Min Hu (Connor)
Return value 'rte_kni_init' of a function is not checked. If it fails, error handling (logging and return) should be done. This patch fixed it. Fixes: 0c6bc8ef70ba ("kni: memzone pool for alloc and release") Cc: sta...@dpdk.org Signed-off-by: Min Hu (Connor) --- app/test/test_kni.c | 6 +-

[dpdk-dev] [PATCH 1/3] kni: fix wrong comments

2021-04-21 Thread Min Hu (Connor)
This patch changed 'subsytem' to 'subsystem'. Fixes: 0c6bc8ef70ba ("kni: memzone pool for alloc and release") Cc: sta...@dpdk.org Signed-off-by: Min Hu (Connor) --- app/test/test_kni.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/test/test_kni.c b/app/test/test_kni.c

[dpdk-dev] [PATCH 2/3] net/kni: fix rewritten return value

2021-04-21 Thread Min Hu (Connor)
Return value of function 'eth_kni_dev_stop' passed to 'ret' is rewritten later, and this is unreasonable. This patch fixes it. Fixes: 62024eb82756 ("ethdev: change stop operation callback to return int") Cc: sta...@dpdk.org Signed-off-by: Min Hu (Connor) --- drivers/net/kni/rte_eth_kni.c | 5 +

[dpdk-dev] [PATCH 0/3] bugfix for kni

2021-04-21 Thread Min Hu (Connor)
This patchset contains three bugfixes for kni. Min Hu (Connor) (3): kni: fix wrong comments net/kni: fix rewritten return value kni: fix unchecked return value app/test/test_kni.c | 8 ++-- drivers/net/kni/rte_eth_kni.c | 5 + 2 files changed, 11 insertions(+), 2 deletion

[dpdk-dev] [PATCH] net/bnxt: remove unnecessary forward declaration

2021-04-21 Thread Kalesh A P
From: Kalesh AP This patch removes several redundant forward declarations of functions and structure. Fixes: 0b42b92ae429 ("net/bnxt: fix xstats by id") Fixes: cf4f055a6578 ("net/bnxt: remove EEM system memory support") Cc: sta...@dpdk.org Signed-off-by: Kalesh AP Reviewed-by: Ajit Khaparde R

[dpdk-dev] [PATCH v4] net/iavf: fix hash configuration on i40e VF

2021-04-21 Thread Alvin Zhang
In i40evf PMD, the VF directly accesses the hash enable registers to enable or disable hashing on ingress packets. When binding i40e VF to iavf, because the PF doesn't support VIRTCHNL_VF_OFFLOAD_ADV_RSS_PF capability. Therefore, the VF hashing cannot be enabled. This patch adds support of hash co

[dpdk-dev] [PATCH] net/iavf: fix VLAN tag extraction handling in AVX512 path

2021-04-21 Thread Leyi Rong
The new VIRTCHNL_VF_OFFLOAD_VLAN_V2 capability added support that allows the PF to set the location of the RX VLAN tag for stripping offloads. So the VF needs to extract the VLAN tag according to the location flags. This patch is the fix for AVX512 path, as AVX2 is already fixed. Fixes: 9c9aa004

[dpdk-dev] [PATCH] net/bonding: fix kvlist memory leakage

2021-04-21 Thread Min Hu (Connor)
From: Chengwen Feng If the bond device was created by vdev mode, the kvlist was not free when the bond device removed. Fixes: 8d30fe7fa737 ("bonding: support port hotplug") Cc: sta...@dpdk.org Signed-off-by: Chengwen Feng Signed-off-by: Min Hu (Connor) --- drivers/net/bonding/rte_eth_bond_pm

[dpdk-dev] [PATCH 4/4] net/hns3: delete unused macro and struct of mbx module

2021-04-21 Thread Min Hu (Connor)
From: Chengwen Feng In hns3_mbx.h, some macro and structure were defined in previous versions but never used. Fixes: 463e748964f5 ("net/hns3: support mailbox") Cc: sta...@dpdk.org Signed-off-by: Chengwen Feng Signed-off-by: Min Hu (Connor) --- drivers/net/hns3/hns3_mbx.h | 10 -- 1 f

[dpdk-dev] [PATCH 3/4] net/hns3: fix parse link fails code fail

2021-04-21 Thread Min Hu (Connor)
From: Chengwen Feng The link fails code should be parsed using the structure hns3_mbx_vf_to_pf_cmd, else it will parse fail. Fixes: 109e4dd1bd7a ("net/hns3: get link state change through mailbox") Cc: sta...@dpdk.org Signed-off-by: Chengwen Feng Signed-off-by: Min Hu (Connor) --- drivers/net

[dpdk-dev] [PATCH 0/4] bugfix for hns3 PMD

2021-04-21 Thread Min Hu (Connor)
This patchset contains four bugfixes for hns3 PMD. Chengwen Feng (4): net/hns3: fix error mbx messages prompt errors net/hns3: fix PF miss link status notify message net/hns3: fix parse link fails code fail net/hns3: delete unused macro and struct of mbx module drivers/net/hns3/hns3_mbx.

[dpdk-dev] [PATCH 2/4] net/hns3: fix PF miss link status notify message

2021-04-21 Thread Min Hu (Connor)
From: Chengwen Feng The opcode of the link status notification message reported by the firmware is zero, it will be filtered out because driver treats it as already processed message. As a result, the PF can't update the link status in a timely manner. Because only VF can set opcode to zero when

[dpdk-dev] [PATCH 1/4] net/hns3: fix error mbx messages prompt errors

2021-04-21 Thread Min Hu (Connor)
From: Chengwen Feng The hns3_dev_handle_mbx_msg() could be called under both PF and VF, but the error messages show VF. Fixes: 109e4dd1bd7a ("net/hns3: get link state change through mailbox") Cc: sta...@dpdk.org Signed-off-by: Chengwen Feng Signed-off-by: Min Hu (Connor) --- drivers/net/hns3

Re: [dpdk-dev] [PATCH] examples/timer: fix incorrect time interval

2021-04-21 Thread Chengchang Tang
Hi On 2021/4/22 2:34, Thomas Monjalon wrote: > 15/04/2021 09:12, Min Hu (Connor): >> From: Chengchang Tang >> >> Timer sample example assumes that the frequency of the timer is about >> 2Ghz to control the period of calling rte_timer_manage(). But this >> assumption is easy to fail. For example. t

[dpdk-dev] [PATCH v2 3/3] net/i40e: enable PCI bus master after reset

2021-04-21 Thread Haiyue Wang
The VF reset can be triggerred by the PF reset event, in this case, the PCI bus master will be cleared, then the VF is not allowed to issue any Memory or I/O Requests. So after the reset event is detected, always enable the PCI bus master. And align the VF reset event handling in device close mod

[dpdk-dev] [PATCH v2 2/3] net/iavf: enable PCI bus master after reset

2021-04-21 Thread Haiyue Wang
The VF reset can be triggerred by the PF reset event, in this case, the PCI bus master will be cleared, then the VF is not allowed to issue any Memory or I/O Requests. So after the reset event is detected, always enable the PCI bus master. Signed-off-by: Haiyue Wang Tested-by: Qi Zhang --- dri

[dpdk-dev] [PATCH v2 1/3] bus/pci: enable PCI master in command register

2021-04-21 Thread Haiyue Wang
This adds the support to set 'Bus Master Enable' bit in the PCI command register. Signed-off-by: Haiyue Wang Tested-by: Qi Zhang --- drivers/bus/pci/pci_common.c | 20 drivers/bus/pci/rte_bus_pci.h | 12 drivers/bus/pci/version.map | 1 + lib/pci/rte_pci.h

[dpdk-dev] [PATCH v2 0/3] fix PF reset causes VF memory request failure

2021-04-21 Thread Haiyue Wang
By triggerring the VF reset from PF reset, echo 1 > /sys/bus/pci/devices/PF-BDF/reset the PCI bus master bit will cleared on VF, so the VF needs to enable this bit before restart. This patch set adds the API to enable PCI bus master. v2: rebase to new librte directory path. Haiyue Wang

Re: [dpdk-dev] [PATCH v10 1/2] ethdev: add pre-defined meter policy API

2021-04-21 Thread Li Zhang
Hi Thomas, Thanks for your comments. Since this patch already accepted, I will fix it in RC2. Regards, Li Zhang > -Original Message- > From: Thomas Monjalon > Sent: Thursday, April 22, 2021 3:44 AM > To: Jiawei(Jonny) Wang > Cc: Matan Azrad ; Ori Kam ; Slava > Ovsiienko ; Shahaf Shuler

Re: [dpdk-dev] [PATCH v12] app/testpmd: support multi-process

2021-04-21 Thread Min Hu (Connor)
Hi, Singh, fixed in v13, thanks. 在 2021/4/21 17:56, Singh, Aman Deep 写道: This patch adds multi-process support for testpmd. The test cmd example as follows: the primary cmd: ./dpdk-testpmd -a xxx --proc-type=auto -l 0-1 -- -i \ --rxq=4 --txq=4 --num-procs=2 --proc-id=0 the secondary cmd: .

[dpdk-dev] [PATCH v13] app/testpmd: support multi-process

2021-04-21 Thread Min Hu (Connor)
This patch adds multi-process support for testpmd. The test cmd example as follows: the primary cmd: ./dpdk-testpmd -a xxx --proc-type=auto -l 0-1 -- -i \ --rxq=4 --txq=4 --num-procs=2 --proc-id=0 the secondary cmd: ./dpdk-testpmd -a xxx --proc-type=auto -l 2-3 -- -i \ --rxq=4 --txq=4 --num-procs=

[dpdk-dev] [PATCH] dpdk-kmods/windows: Add Intel 100GbE Ethernet adapter device IDs to netuio INF

2021-04-21 Thread Pallavi Kadam
Add Intel 100GbE Ethernet adapter device IDs to netuio inf file in order to enable them on Windows. Signed-off-by: Pallavi Kadam Reviewed-by: Ranjit Menon --- windows/netuio/netuio.inf | 12 1 file changed, 12 insertions(+) diff --git a/windows/netuio/netuio.inf b/windows/netuio/n

[dpdk-dev] [PATCH] bnxt: skip getting statistics for queues not started

2021-04-21 Thread Stephen Hemminger
An application using rte_flow may define a large number of queues but only use a small subset of them at any one time. Since querying the status of each queue requires a request/spin/reply with the firmware, optimize by skipping the request for queues not running. For those queues the statistics w

[dpdk-dev] [dpdk-announce] release candidate 21.05-rc1

2021-04-21 Thread Thomas Monjalon
A new DPDK release candidate is ready for testing: https://git.dpdk.org/dpdk/tag/?id=v21.05-rc1 There are 879 new patches in this snapshot. Release notes: https://doc.dpdk.org/guides/rel_notes/release_21_05.html Highlights of 21.05-rc1, grouped by category: * General - Al

Re: [dpdk-dev] [PATCH] doc: announce support of Alpine Linux

2021-04-21 Thread Thomas Monjalon
18/04/2021 00:16, Thomas Monjalon: > After many patches in several releases to make DPDK buildable with musl, > and few adjustments for busybox, it is time to show the support of DPDK > built in Alpine Linux. > > Signed-off-by: Thomas Monjalon Applied

Re: [dpdk-dev] [PATCH] doc: fix names of UIO drivers

2021-04-21 Thread Thomas Monjalon
18/03/2021 12:00, Thomas Monjalon: > Fix typos in the names of kernel drivers based on UIO, > and make sure the generic term for the interface is UIO in capitals. > > Fixes: 3a78b2f73206 ("doc: add virtio crypto PMD guide") > Fixes: 3cc4d996fa75 ("doc: update VFIO usage in qat crypto guide") > Fix

[dpdk-dev] [PATCH] drivers: fix indentation in build files

2021-04-21 Thread Thomas Monjalon
A couple of mistakes slipped in the mass change. More mistakes could happen, especially when rebasing pending patches, so we need an automatic check. Fixes: 4ad4b20a7905 ("drivers: change indentation in build files") Signed-off-by: Thomas Monjalon --- drivers/crypto/qat/meson.build | 4 ++--

Re: [dpdk-dev] [PATCH v5 0/3] net/pcap: build on Windows

2021-04-21 Thread Thomas Monjalon
> Dmitry Kozlyuk (3): > eal: add timespec_get shim > net/pcap: move OS-dependent code to separate files > net/pcap: build on Windows Unfortunately the CI testing FreeBSD 11 is not running on this series, but I feel it's OK to be part of the 21.05-rc1. Applied, thanks

Re: [dpdk-dev] [PATCH] drivers/net: fix FW version get

2021-04-21 Thread Ajit Khaparde
On Wed, Apr 21, 2021 at 9:21 AM Ferruh Yigit wrote: > > Fixes a few different things: > * Remove 'fw_version' NULL checks, it is allowed if the 'fw_size' is > zero, 'fw_version' being NULL but 'fw_size' not zero condition checked > in ethdev layer > * Be sure required buffer size is returned i

[dpdk-dev] [PATCH] usertools/devbind: add dlb

2021-04-21 Thread Timothy McDaniel
Add dlb to usertools/dpdk-devbind.py so that it shows up as an eventdev, and is identified as Intel dlb. Signed-off-by: Timothy McDaniel --- usertools/dpdk-devbind.py |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/usertools/dpdk-devbind.py b/usertools/dpdk-devbind.py i

Re: [dpdk-dev] [PATCH v10 1/2] ethdev: add pre-defined meter policy API

2021-04-21 Thread Thomas Monjalon
20/04/2021 16:04, Jiawei Wang: > --- a/doc/guides/rel_notes/release_21_05.rst > +++ b/doc/guides/rel_notes/release_21_05.rst > @@ -244,6 +244,27 @@ New Features >* Added support for crypto adapter forward mode in octeontx2 event and > crypto > device driver. > > + * deleted the port me

[dpdk-dev] [PATCH v5 3/3] net/pcap: build on Windows

2021-04-21 Thread Dmitry Kozlyuk
Implement OS-dependent functions and enable build for Windows. Account for different library name in Windows libpcap distributions. Signed-off-by: Dmitry Kozlyuk Acked-by: Tyler Retzlaff --- config/meson.build | 9 +- doc/guides/rel_notes/release_21_05.rst | 4 + drivers

[dpdk-dev] [PATCH v5 2/3] net/pcap: move OS-dependent code to separate files

2021-04-21 Thread Dmitry Kozlyuk
PCAP PMD queries interface information differently for Linux and FreeBSD, OS-specific code is guarded by #ifdef. This PMD also depends on POSIX bits, namely gettimeofday() and NAME_MAX. Move OS-dependent code to separate files. Replace POSIX bits with DPDK equivalents. Rename rte_eth_pcap.c to pca

[dpdk-dev] [PATCH v5 1/3] eal: add timespec_get shim

2021-04-21 Thread Dmitry Kozlyuk
C11 timespec_get() is not provided on some platforms: * MinGW-w64 does not currently implement it [1]. * FreeBSD 11 with Clang 10.0.0 does not provide it. Add internal shims to Windows and FreeBSD EALs. For Windows, it can be removed after [1] is fixed. [1]: https://sourceforge.net/p/mingw-w64/m

[dpdk-dev] [PATCH v5 0/3] net/pcap: build on Windows

2021-04-21 Thread Dmitry Kozlyuk
Most modern and actively maintained distribution of libpcap for Windows is Npcap [1]. It currently doesn't provide a pkg-config file [2]. By default it is installed to C:\Program Files\Npcap and can be located using standard environment variables [3]: $env:C_INCLUDE_PATH += ";C:\Program Files\

Re: [dpdk-dev] [PATCH] examples/timer: fix incorrect time interval

2021-04-21 Thread Carrillo, Erik G
> -Original Message- > From: Min Hu (Connor) > Sent: Thursday, April 15, 2021 2:12 AM > To: dev@dpdk.org > Cc: Yigit, Ferruh ; rsanf...@akamai.com; Carrillo, > Erik G > Subject: [PATCH] examples/timer: fix incorrect time interval > > From: Chengchang Tang > > Timer sample example assum

Re: [dpdk-dev] [PATCH] examples/l3fwd: fib skip tx queue drain on first iteration

2021-04-21 Thread Thomas Monjalon
> > The commit a8f8b672d575 ("examples/l3fwd: skip Tx queue drain on first > > iteration") implemented a change to the em and lpm lookup methods to > > prevent the TX queue drain running in the first iteration of their > > packet processing loops. This patch introduces this change into the > > fib

Re: [dpdk-dev] [PATCH] examples/timer: fix incorrect time interval

2021-04-21 Thread Thomas Monjalon
15/04/2021 09:12, Min Hu (Connor): > From: Chengchang Tang > > Timer sample example assumes that the frequency of the timer is about > 2Ghz to control the period of calling rte_timer_manage(). But this > assumption is easy to fail. For example. the frequency of tsc on ARM64 > is much less than 2G

Re: [dpdk-dev] [PATCH] examples/ethtool: remove redundant assignment

2021-04-21 Thread Thomas Monjalon
21/04/2021 04:39, Min Hu (Connor): > From: Chengwen Feng > > The new_mtu was assigned twice, the first assignment could be removed. > > Fixes: bda68ab9d1e7 ("examples/ethtool: add user-space ethtool sample > application") > Cc: sta...@dpdk.org > > Signed-off-by: Chengwen Feng > Signed-off-by:

Re: [dpdk-dev] [PATCH v2] examples: add eal cleanup to examples

2021-04-21 Thread Thomas Monjalon
15/04/2021 04:26, Min Hu (Connor): > From: Chengchang Tang > > According to the programming guide, the rte_eal_init should be used pairs > with rte_eal_cleanup. > > This patch add rte_eal_cleanup to examples to encourage new users of > DPDK to use it. > > Fixes: aec9c13c5257 ("eal: add function

Re: [dpdk-dev] [PATCH] telemetry: fix build on FreeBSD < 12.2

2021-04-21 Thread Thomas Monjalon
21/04/2021 20:11, Thomas Monjalon: > The function pthread_setname_np() was originally not available on > FreeBSD. It has been added in FreeBSD 12.2: > https://svnweb.freebsd.org/base?view=revision&revision=362264 > > The EAL implementation of rte_thread_setname() is duplicated > in the telemetry l

Re: [dpdk-dev] [PATCH v4 0/3] net/pcap: build on Windows

2021-04-21 Thread Thomas Monjalon
21/04/2021 16:53, Dmitry Kozlyuk: > 2021-04-21 00:20 (UTC+0200), Thomas Monjalon: > > > Dmitry Kozlyuk (3): > > > eal/windows: add timespec_get shim for MinGW > > > net/pcap: move OS-dependent code to separate files > > > net/pcap: build on Windows > > > > Compilation is failing on FreeBSD

[dpdk-dev] [PATCH] telemetry: fix build on FreeBSD < 12.2

2021-04-21 Thread Thomas Monjalon
The function pthread_setname_np() was originally not available on FreeBSD. It has been added in FreeBSD 12.2: https://svnweb.freebsd.org/base?view=revision&revision=362264 The EAL implementation of rte_thread_setname() is duplicated in the telemetry library, which does not depend on EAL, so the co

[dpdk-dev] [PATCH] vdpa/mlx5: improve portability of thread naming

2021-04-21 Thread Thomas Monjalon
The function pthread_setname_np is non-portable, so it may be unavailable in old glibc or other systems. The function rte_thread_setname is workarounding portability issues. Signed-off-by: Thomas Monjalon --- drivers/vdpa/mlx5/mlx5_vdpa_event.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(

Re: [dpdk-dev] net/mlx5: no TX in multi-process setup (testpmd working)

2021-04-21 Thread Tanmay Kishore
Nice!!! Tanmay From: Rajesh Kumar Sent: Tuesday, April 20, 2021 4:16 AM To: dev@dpdk.org ; RajeshKumar Kalidass ; suanmi...@nvidia.com ; Rakesh Jagota ; Tanmay Kishore ; Hung Nguyen Subject: Re: net/mlx5: no TX in multi-process setup (testpmd working) WARNIN

Re: [dpdk-dev] [PATCH v5 0/2] test/power: fix bugs in cpufreq test

2021-04-21 Thread Thomas Monjalon
> Richael Zhuang (2): > test/power: add delay before checking cpuinfo cur freq > test/power: round cpuinfo cur freq value in cpufreq autotest Applied, thanks

Re: [dpdk-dev] [PATCH v10] ethdev: add sanity checks in control APIs

2021-04-21 Thread Ferruh Yigit
On 4/21/2021 5:22 PM, Ferruh Yigit wrote: On 4/21/2021 3:19 PM, Ferruh Yigit wrote: On 4/21/2021 1:36 PM, Min Hu (Connor) wrote: This patch adds more sanity checks in control path APIs. Fixes: 214ed1acd125 ("ethdev: add iterator to match devargs input") Fixes: 3d98f921fbe9 ("ethdev: unify pref

[dpdk-dev] [PATCH 3/3] net/mlx5: support checksum offload on Windows

2021-04-21 Thread Tal Shnaiderman
Support of the checksum offloading by checking the relevant FW capability (csum_cap) for NIC support. RX supported offloads: DEV_RX_OFFLOAD_IPV4_CKSUM DEV_RX_OFFLOAD_UDP_CKSUM DEV_RX_OFFLOAD_TCP_CKSUM TX supported offloads: DEV_TX_OFFLOAD_IPV4_CKSUM DEV_TX_OFFLOAD_UDP_CKSUM DEV_TX_OFFLOAD_TCP_C

[dpdk-dev] [PATCH 2/3] common/mlx5: read checksum capability from DevX

2021-04-21 Thread Tal Shnaiderman
mlx5 in Windows needs the hca capability csum_cap to query the NIC for checksum offloading support Added the capability as part of the capabilities queried by the PMD using DevX. Signed-off-by: Tal Shnaiderman Acked-by: Matan Azrad --- drivers/common/mlx5/mlx5_devx_cmds.c | 2 ++ drivers/commo

[dpdk-dev] [PATCH 0/3] mlx5 - support checksum offloads on Windows

2021-04-21 Thread Tal Shnaiderman
Support the following checksum offloads on Windows. RX supported offloads: DEV_RX_OFFLOAD_IPV4_CKSUM DEV_RX_OFFLOAD_UDP_CKSUM DEV_RX_OFFLOAD_TCP_CKSUM TX supported offloads: DEV_TX_OFFLOAD_IPV4_CKSUM DEV_TX_OFFLOAD_UDP_CKSUM DEV_TX_OFFLOAD_TCP_CKSUM Tal Shnaiderman (3): net/mlx5: fix unsuppo

[dpdk-dev] [PATCH 1/3] net/mlx5: fix unsupported offloads disablement

2021-04-21 Thread Tal Shnaiderman
mlx5 offloads which are unsupported on Windows are currently disabled by checks with IBV/DV flags which are irrelevant to Windows. The checks are removed until they are fully available. Fixes: 93f4ece91a1f ("net/mlx5: spawn ethdev ports on Windows") Cc: sta...@dpdk.org Signed-off-by: Tal Shnaide

Re: [dpdk-dev] [PATCH v3 2/2] lib/mempool: distinguish debug counters from cache and pool

2021-04-21 Thread Olivier Matz
Hi Dharmik, Please see some comments below. On Mon, Apr 19, 2021 at 07:08:00PM -0500, Dharmik Thakkar wrote: > From: Joyce Kong > > If cache is enabled, objects will be retrieved/put from/to cache, > subsequently from/to the common pool. Now the debug stats calculate > the objects retrieved/put

Re: [dpdk-dev] [PATCH v10] ethdev: add sanity checks in control APIs

2021-04-21 Thread Ferruh Yigit
On 4/21/2021 3:19 PM, Ferruh Yigit wrote: On 4/21/2021 1:36 PM, Min Hu (Connor) wrote: This patch adds more sanity checks in control path APIs. Fixes: 214ed1acd125 ("ethdev: add iterator to match devargs input") Fixes: 3d98f921fbe9 ("ethdev: unify prefix for static functions and variables") Fix

[dpdk-dev] [PATCH] drivers/net: fix FW version get

2021-04-21 Thread Ferruh Yigit
Fixes a few different things: * Remove 'fw_version' NULL checks, it is allowed if the 'fw_size' is zero, 'fw_version' being NULL but 'fw_size' not zero condition checked in ethdev layer * Be sure required buffer size is returned if provided one is not big enough, instead of returning success

[dpdk-dev] [PATCH v2] eal/windows: fix build warnings in MinGW

2021-04-21 Thread Tal Shnaiderman
the strncasecmp macro defined in rte_os_shim.h is already defined in MinGW-w64, as a result the compiler prints out the warning below on function redefinition whenever compiling a file including the header in debug mode. ..\lib/librte_eal/windows/include/rte_os_shim.h:21: warning: "strncasecmp" re

Re: [dpdk-dev] [PATCH v3 1/2] lib/mempool: make stats macro generic

2021-04-21 Thread Olivier Matz
On Mon, Apr 19, 2021 at 07:07:59PM -0500, Dharmik Thakkar wrote: > Make __MEMPOOL_STAT_ADD macro more generic and delete > __MEMPOOL_CONTIG_BLOCKS_STAT_ADD macro > > Suggested-by: Olivier Matz > Signed-off-by: Dharmik Thakkar > Reviewed-by: Ruifeng Wang > Reviewed-by: Honnappa Nagarahalli Ack

Re: [dpdk-dev] [PATCH 00/14] Build file updates

2021-04-21 Thread Xueming(Steven) Li
> -Original Message- > From: Xueming(Steven) Li > Sent: Wednesday, April 21, 2021 9:02 PM > To: 'Bruce Richardson' > Cc: dev@dpdk.org > Subject: RE: [dpdk-dev] [PATCH 00/14] Build file updates > > > > -Original Message- > > From: Bruce Richardson > > Sent: Monday, April 19, 2

Re: [dpdk-dev] [PATCH v3] sched : fix traffic class oversubscription parameter

2021-04-21 Thread Dumitrescu, Cristian
> -Original Message- > From: Dharmappa, Savinay > Sent: Wednesday, April 21, 2021 7:50 AM > To: dev@dpdk.org; Singh, Jasvinder ; > Dumitrescu, Cristian > Cc: Dharmappa, Savinay ; sta...@dpdk.org > Subject: [PATCH v3] sched : fix traffic class oversubscription parameter > > This patch

Re: [dpdk-dev] [PATCH] test/bpf: fix wrong error variable

2021-04-21 Thread Thomas Monjalon
> > This patch fixed wrong error variable in logging message. > > > > Fixes: 83633ba23076 ("test/bpf: fix few small issues") > > Cc: sta...@dpdk.org > > > > Signed-off-by: Min Hu (Connor) > > Acked-by: Konstantin Ananyev Applied, thanks

Re: [dpdk-dev] [PATCH] examples/l3fwd: fib skip tx queue drain on first iteration

2021-04-21 Thread Medvedkin, Vladimir
On 21/04/2021 15:48, Conor Walsh wrote: The commit a8f8b672d575 ("examples/l3fwd: skip Tx queue drain on first iteration") implemented a change to the em and lpm lookup methods to prevent the TX queue drain running in the first iteration of their packet processing loops. This patch introduces

Re: [dpdk-dev] [PATCH 2/2] pipeline: autodetect endianness of action args

2021-04-21 Thread Dumitrescu, Cristian
Hi Ali, > -Original Message- > From: Ali Alnubani > Sent: Wednesday, April 21, 2021 3:25 PM > To: Dumitrescu, Cristian > Cc: dev@dpdk.org; NBU-Contact-Thomas Monjalon > ; Aaron Conole > Subject: RE: [dpdk-dev] [PATCH 2/2] pipeline: autodetect endianness of > action args > > Hi Cristian

Re: [dpdk-dev] [PATCH] autotest: disable lcores_autotest on ppc

2021-04-21 Thread Thomas Monjalon
20/04/2021 13:45, luca.bocca...@gmail.com: > This test consistently times out on ppc64 builds. Disable it. It looks like hiding an issue. Is there any specific reason for this timeout?

Re: [dpdk-dev] [PATCH] common/dpaax: fix possible null pointer access

2021-04-21 Thread Thomas Monjalon
21/04/2021 14:12, Hemant Agrawal: > On 4/21/2021 8:16 AM, Min Hu (Connor) wrote: > > From: Chengwen Feng > > > > This patch fixes possible null pointer access when dump iova table. > > > > Fixes: 2f3d633aa593 ("common/dpaax: add library for PA/VA translation > > table") > > Cc: sta...@dpdk.org >

Re: [dpdk-dev] [dpdk-ci] [RFC] Proposal for allowing rerun of tests

2021-04-21 Thread Aaron Conole
Thomas Monjalon writes: > 13/04/2021 17:04, Bruce Richardson: >> On Tue, Apr 13, 2021 at 04:59:00PM +0200, David Marchand wrote: >> > On Tue, Apr 13, 2021 at 4:47 PM Thomas Monjalon >> > wrote: >> > > >> > > 13/04/2021 15:50, Aaron Conole: >> > > >> > > > One proposal we (Michael and I) have to

Re: [dpdk-dev] [PATCH v3] sched : fix traffic class oversubscription parameter

2021-04-21 Thread Thomas Monjalon
21/04/2021 08:50, Savinay Dharmappa: > This patch fixes the traffic class oversubscription watermark > value by initialising it with computed value of maximum watermark. > > Fixes: ac6fcb841b0f ("sched: update subport rate dynamically") > Cc: sta...@dpdk.org > > Signed-off-by: Savinay Dharmappa

Re: [dpdk-dev] [PATCH v4 0/3] net/pcap: build on Windows

2021-04-21 Thread Dmitry Kozlyuk
2021-04-21 00:20 (UTC+0200), Thomas Monjalon: > > Dmitry Kozlyuk (3): > > eal/windows: add timespec_get shim for MinGW > > net/pcap: move OS-dependent code to separate files > > net/pcap: build on Windows > > Compilation is failing on FreeBSD 11: > http://mails.dpdk.org/archives/test-repor

Re: [dpdk-dev] [PATCH v2] ip_frag: fix fragmenting ipv4 packet with header option

2021-04-21 Thread Thomas Monjalon
> > From: Pu Xu <583493...@qq.com> > > > > When fragmenting ipv4 packet, the data offset should be calculated through > > the ihl field in ip header rather than using sizeof(struct rte_ipv4_hdr). > > > > Fixes: 4c38e5532a07 ("ip_frag: refactor IPv4 fragmentation into a proper > > library") + Cc

Re: [dpdk-dev] [PATCH v3] net/e1000: fix timed out for shadow RAM write

2021-04-21 Thread Zhang, Qi Z
> -Original Message- > From: dev On Behalf Of Wang, Haiyue > Sent: Wednesday, April 21, 2021 7:22 PM > To: Min Hu (Connor) ; dev@dpdk.org > Cc: Yigit, Ferruh ; Guo, Jia > Subject: Re: [dpdk-dev] [PATCH v3] net/e1000: fix timed out for shadow RAM > write > > > -Original Message

Re: [dpdk-dev] [PATCH v3] net/i40e: fix FDIR issue for common PCTYPEs

2021-04-21 Thread Zhang, Qi Z
> -Original Message- > From: dev On Behalf Of Xing, Beilei > Sent: Wednesday, April 21, 2021 1:11 PM > To: Yang, MurphyX ; dev@dpdk.org > Cc: Yang, Qiming ; Guo, Jia ; > Yang, SteveX ; Zhang, RobinX > > Subject: Re: [dpdk-dev] [PATCH v3] net/i40e: fix FDIR issue for common > PCTYPEs >

Re: [dpdk-dev] [PATCH v4 0/2] fix missing check for thread creation

2021-04-21 Thread Thomas Monjalon
> Chengwen Feng (2): > telemetry: fix missing check for thread creation > test: fix missing check for thread creation Applied, thanks

Re: [dpdk-dev] [PATCH v16 4/8] eal/arm: update CPU flags

2021-04-21 Thread Juraj Linkeš
Addining Jerin, Jan and Ruifeng > -Original Message- > From: Juraj Linkeš > Sent: Wednesday, April 21, 2021 10:50 AM > To: tho...@monjalon.net; david.march...@redhat.com; > bruce.richard...@intel.com; acon...@redhat.com; > maicolgabr...@hotmail.com > Cc: Juraj Linkeš ; dev@dpdk.org > Subj

Re: [dpdk-dev] [PATCH 2/2] pipeline: autodetect endianness of action args

2021-04-21 Thread Ali Alnubani
Hi Cristian, > -Original Message- > From: Dumitrescu, Cristian > Sent: Wednesday, April 21, 2021 4:58 PM > To: Ali Alnubani ; NBU-Contact-Thomas Monjalon > ; Aaron Conole > Cc: dev@dpdk.org > Subject: RE: [dpdk-dev] [PATCH 2/2] pipeline: autodetect endianness of > action args > > > >

Re: [dpdk-dev] [PATCH] doc/contributing/documentation: add info about including code

2021-04-21 Thread Thomas Monjalon
21/04/2021 16:17, Mcnamara, John: > From: Thomas Monjalon > > > > > > This is a very good suggestion and I think we should encourage doc > > > writers to use this when including code in the documentation. > > > > Yes, and we should try to clean-up existing code snippets. > > If there is no gener

Re: [dpdk-dev] [PATCH v16 1/8] net/sfc: fix aarch32 build

2021-04-21 Thread Andrew Rybchenko
On 4/21/21 5:08 PM, Juraj Linkeš wrote: > > >> -Original Message- >> From: Ruifeng Wang >> Sent: Wednesday, April 21, 2021 12:06 PM >> To: Andrew Rybchenko ; Juraj Linkeš >> ; tho...@monjalon.net; >> david.march...@redhat.com; bruce.richard...@intel.com; >> acon...@redhat.com; maicolgabr

Re: [dpdk-dev] [PATCH v10] ethdev: add sanity checks in control APIs

2021-04-21 Thread Ferruh Yigit
On 4/21/2021 1:36 PM, Min Hu (Connor) wrote: This patch adds more sanity checks in control path APIs. Fixes: 214ed1acd125 ("ethdev: add iterator to match devargs input") Fixes: 3d98f921fbe9 ("ethdev: unify prefix for static functions and variables") Fixes: 0366137722a0 ("ethdev: check for invali

Re: [dpdk-dev] [PATCH] doc/contributing/documentation: add info about including code

2021-04-21 Thread Mcnamara, John
> -Original Message- > From: Thomas Monjalon > Sent: Wednesday, April 21, 2021 11:31 AM > To: Walsh, Conor ; david.march...@redhat.com; > Yigit, Ferruh ; Richardson, Bruce > ; Burakov, Anatoly > ; Mcnamara, John > Cc: dev@dpdk.org > Subject: Re: [PATCH] doc/contributing/documentation: a

Re: [dpdk-dev] [PATCH v9] ethdev: add sanity checks in control APIs

2021-04-21 Thread Ferruh Yigit
On 4/21/2021 12:28 PM, Andrew Rybchenko wrote: On 4/21/21 5:36 AM, Ferruh Yigit wrote: From: "Min Hu (Connor)" This patch adds more sanity checks in control path APIs. Fixes: 214ed1acd125 ("ethdev: add iterator to match devargs input") Fixes: 3d98f921fbe9 ("ethdev: unify prefix for static fun

Re: [dpdk-dev] [PATCH v16 1/8] net/sfc: fix aarch32 build

2021-04-21 Thread Juraj Linkeš
> -Original Message- > From: Ruifeng Wang > Sent: Wednesday, April 21, 2021 12:06 PM > To: Andrew Rybchenko ; Juraj Linkeš > ; tho...@monjalon.net; > david.march...@redhat.com; bruce.richard...@intel.com; > acon...@redhat.com; maicolgabr...@hotmail.com > Cc: dev@dpdk.org; arybche...@sola

Re: [dpdk-dev] [PATCH v2 0/7] support set thread name

2021-04-21 Thread Thomas Monjalon
17/04/2021 11:09, Min Hu (Connor): > This set of patches support set thread name for debugging. > > Chengwen Feng (7): > net/ark: support set thread name > net/ice: support set VSI reset thread name > vdpa/ifc: support set notify and vring relay thread name > raw/ifpga: support set monitor

Re: [dpdk-dev] [PATCH 2/2] pipeline: autodetect endianness of action args

2021-04-21 Thread Dumitrescu, Cristian
> -Original Message- > From: Ali Alnubani > Sent: Wednesday, April 21, 2021 8:50 AM > To: NBU-Contact-Thomas Monjalon ; Dumitrescu, > Cristian ; Aaron Conole > > Cc: dev@dpdk.org > Subject: RE: [dpdk-dev] [PATCH 2/2] pipeline: autodetect endianness of > action args > > Hi, > > >

[dpdk-dev] [PATCH] pipeline: prevent some compiler warnings

2021-04-21 Thread Cristian Dumitrescu
Some older versions of the GCC compiler may trigger the -Werror=maybe-uninitialized warning if some local variables are not initialized. Signed-off-by: Cristian Dumitrescu --- lib/librte_pipeline/rte_swx_pipeline.c | 30 +- 1 file changed, 15 insertions(+), 15 deletions(-

Re: [dpdk-dev] [PATCH v9] ethdev: add sanity checks in control APIs

2021-04-21 Thread Andrew Rybchenko
On 4/21/21 4:40 PM, Ferruh Yigit wrote: > On 4/21/2021 2:19 PM, Ferruh Yigit wrote: >> On 4/21/2021 12:28 PM, Andrew Rybchenko wrote: >>> On 4/21/21 5:36 AM, Ferruh Yigit wrote: From: "Min Hu (Connor)" This patch adds more sanity checks in control path APIs. Fixes: 214ed1a

Re: [dpdk-dev] [PATCH v9] ethdev: add sanity checks in control APIs

2021-04-21 Thread Andrew Rybchenko
On 4/21/21 4:19 PM, Ferruh Yigit wrote: > On 4/21/2021 12:28 PM, Andrew Rybchenko wrote: >> On 4/21/21 5:36 AM, Ferruh Yigit wrote: >>> From: "Min Hu (Connor)" >>> >>> This patch adds more sanity checks in control path APIs. >>> >>> Fixes: 214ed1acd125 ("ethdev: add iterator to match devargs input

Re: [dpdk-dev] [PATCH v9] ethdev: add sanity checks in control APIs

2021-04-21 Thread Ferruh Yigit
On 4/21/2021 2:19 PM, Ferruh Yigit wrote: On 4/21/2021 12:28 PM, Andrew Rybchenko wrote: On 4/21/21 5:36 AM, Ferruh Yigit wrote: From: "Min Hu (Connor)" This patch adds more sanity checks in control path APIs. Fixes: 214ed1acd125 ("ethdev: add iterator to match devargs input") Fixes: 3d98f92

Re: [dpdk-dev] [PATCH 2/2] pipeline: autodetect endianness of action args

2021-04-21 Thread Aaron Conole
Ali Alnubani writes: >> -Original Message- >> From: Aaron Conole >> Sent: Wednesday, April 21, 2021 3:57 PM >> To: Ali Alnubani >> Cc: NBU-Contact-Thomas Monjalon ; Cristian >> Dumitrescu ; dev@dpdk.org >> Subject: Re: [dpdk-dev] [PATCH 2/2] pipeline: autodetect endianness of >> action

Re: [dpdk-dev] [PATCH v9] ethdev: add sanity checks in control APIs

2021-04-21 Thread Ferruh Yigit
On 4/21/2021 12:28 PM, Andrew Rybchenko wrote: On 4/21/21 5:36 AM, Ferruh Yigit wrote: From: "Min Hu (Connor)" This patch adds more sanity checks in control path APIs. Fixes: 214ed1acd125 ("ethdev: add iterator to match devargs input") Fixes: 3d98f921fbe9 ("ethdev: unify prefix for static fun

Re: [dpdk-dev] [PATCH 2/2] pipeline: autodetect endianness of action args

2021-04-21 Thread Ali Alnubani
> -Original Message- > From: Aaron Conole > Sent: Wednesday, April 21, 2021 3:57 PM > To: Ali Alnubani > Cc: NBU-Contact-Thomas Monjalon ; Cristian > Dumitrescu ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH 2/2] pipeline: autodetect endianness of > action args > > Ali Alnubani writes:

Re: [dpdk-dev] [PATCH] examples/l3fwd: fib skip tx queue drain on first iteration

2021-04-21 Thread Ananyev, Konstantin
> The commit a8f8b672d575 ("examples/l3fwd: skip Tx queue drain on first > iteration") implemented a change to the em and lpm lookup methods to > prevent the TX queue drain running in the first iteration of their > packet processing loops. This patch introduces this change into the > fib lookup met

Re: [dpdk-dev] [PATCH 00/14] Build file updates

2021-04-21 Thread Xueming(Steven) Li
> -Original Message- > From: Bruce Richardson > Sent: Monday, April 19, 2021 9:06 PM > To: Xueming(Steven) Li > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH 00/14] Build file updates > > On Sun, Apr 18, 2021 at 08:45:25AM +, Xueming(Steven) Li wrote: > > Hi Bruce, > > > > > --

Re: [dpdk-dev] [PATCH 2/2] pipeline: autodetect endianness of action args

2021-04-21 Thread Aaron Conole
Ali Alnubani writes: > Hi, > >> -Original Message- >> From: dev On Behalf Of Thomas Monjalon >> Sent: Tuesday, April 20, 2021 10:58 PM >> To: Cristian Dumitrescu >> Cc: dev@dpdk.org >> Subject: Re: [dpdk-dev] [PATCH 2/2] pipeline: autodetect endianness of >> action args >> >> 12/04/202

[dpdk-dev] [PATCH] examples/l3fwd: fib skip tx queue drain on first iteration

2021-04-21 Thread Conor Walsh
The commit a8f8b672d575 ("examples/l3fwd: skip Tx queue drain on first iteration") implemented a change to the em and lpm lookup methods to prevent the TX queue drain running in the first iteration of their packet processing loops. This patch introduces this change into the fib lookup method, this

  1   2   >