Re: [dpdk-dev] [PATCH v5 1/4] ethdev: add packet mode in meter profile structure

2021-04-17 Thread Thomas Monjalon
13/04/2021 17:59, Li Zhang: > Currently meter algorithms only supports rate is bytes per second(BPS). > Add packet_mode flag in meter profile parameters data structure. > So that it can meter traffic by packet per second. > > When packet_mode is 0, the profile rates and bucket sizes are > specifie

Re: [dpdk-dev] [PATCH v10] app/testpmd: support multi-process

2021-04-17 Thread Ferruh Yigit
On 4/17/2021 7:12 AM, Min Hu (Connor) wrote: This patch adds multi-process support for testpmd. The test cmd example as follows: the primary cmd: ./dpdk-testpmd -a xxx --proc-type=auto -l 0-1 -- -i \ --rxq=4 --txq=4 --num-procs=2 --proc-id=0 the secondary cmd: ./dpdk-testpmd -a xxx --proc-type=a

[dpdk-dev] [PATCH] doc: announce support of Alpine Linux

2021-04-17 Thread Thomas Monjalon
After many patches in several releases to make DPDK buildable with musl, and few adjustments for busybox, it is time to show the support of DPDK built in Alpine Linux. Signed-off-by: Thomas Monjalon --- doc/guides/linux_gsg/sys_reqs.rst | 8 +++- doc/guides/rel_notes/release_21_05.rst |

Re: [dpdk-dev] [PATCH V5] ethdev: add queue state when retrieve queue information

2021-04-17 Thread Ferruh Yigit
On 4/17/2021 4:09 AM, Lijun Ou wrote: Currently, upper-layer application could get queue state only through pointers such as dev->data->tx_queue_state[queue_id], this is not the recommended way to access it. So this patch add get queue state when call rte_eth_rx_queue_info_get and rte_eth_tx_queu

Re: [dpdk-dev] [PATCH v6] ethdev: add sanity checks in control APIs

2021-04-17 Thread Thomas Monjalon
17/04/2021 02:28, Min Hu (Connor): > > 在 2021/4/17 0:28, Stephen Hemminger 写道: > > On Fri, 16 Apr 2021 11:22:02 +0100 > > Kevin Traynor wrote: > > > >>> + if (dev_conf == NULL) { > >>> + RTE_ETHDEV_LOG(ERR, > >>> + "Cannot configure ethdev port %u to NULL dev_conf\n", > >

Re: [dpdk-dev] [PATCH v2 1/2] ethdev: introduce conntrack flow action and item

2021-04-17 Thread Ajit Khaparde
On Fri, Apr 16, 2021 at 11:10 PM Bing Zhao wrote: > > Hi Ajit, > > > -Original Message- > > From: Ajit Khaparde > > Sent: Saturday, April 17, 2021 5:47 AM > > To: Bing Zhao > > Cc: Ori Kam ; NBU-Contact-Thomas Monjalon > > ; ferruh.yi...@intel.com; > > andrew.rybche...@oktetlabs.ru; dev@

[dpdk-dev] [pull-request] next-eventdev 21.05-rc1

2021-04-17 Thread Jerin Jacob Kollanukkaran
The following changes since commit 74299cc7591192cbc72e8f411dff0c7f3cfdf309: buildtools: fix all drivers disabled on Windows (2021-04-17 12:49:23 +0200) are available in the Git repository at: http://dpdk.org/git/next/dpdk-next-eventdev for you to fetch changes up to 6e5aa8854846c884885391d

Re: [dpdk-dev] [PATCH v2] eventdev: fix case to initiate crypto adapter service

2021-04-17 Thread Jerin Jacob
On Wed, Apr 14, 2021 at 12:36 PM Gujjar, Abhinandan S wrote: > > > > > -Original Message- > > From: Shijith Thotton > > Sent: Tuesday, April 13, 2021 1:21 PM > > To: Gujjar, Abhinandan S > > Cc: Shijith Thotton ; dev@dpdk.org; Jerin Jacob > > ; Akhil Goyal ; Anoob Joseph > > > > Subject

[dpdk-dev] [PATCH] net/mlx4: fix buffer leakage on device close

2021-04-17 Thread Viacheslav Ovsiienko
The mlx4 PMD tracks the buffers (mbufs) for the packets being transmitted in the dedicated array named as "elts". The tx_burst routine frees the mbufs from this array once it needs to rearm the hardware descriptor and store the new mbuf, so it looks like as replacement mbuf pointer in the elts arra

Re: [dpdk-dev] [PATCH v11 1/3] eventdev: introduce crypto adapter enqueue API

2021-04-17 Thread Jerin Jacob
On Thu, Apr 15, 2021 at 2:44 PM wrote: > > From: Akhil Goyal > > In case an event from a previous stage is required to be forwarded > to a crypto adapter and PMD supports internal event port in crypto > adapter, exposed via capability > RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_OP_FWD, we do not

[dpdk-dev] [PATCH] devargs: backup entry when inserting duplicated item

2021-04-17 Thread Xueming Li
When insert devargs that already in list, existing one was reset and replaced completely by new once, the entry info was lost during copy. This patch backups entry info before copy. Fixes: 64051bb1f144 ("devargs: unify scratch buffer storage") Signed-off-by: Xueming Li --- lib/librte_eal/commo

Re: [dpdk-dev] Bug with commit 64051bb1 (devargs: unify scratch buffer storage)

2021-04-17 Thread Xueming(Steven) Li
Hi Jim, > From: Harris, James R > Sent: Saturday, April 17, 2021 6:05 AM > To: dev@dpdk.org; Xueming(Steven) Li > Subject: Bug with commit 64051bb1 (devargs: unify scratch buffer storage) > > Hi, > > SPDK has identified a regression with commit 64051bb1 (devargs: unify scratch > buffer stora

Re: [dpdk-dev] [PATCH v2] buildtools: fix all drivers disabled on Windows

2021-04-17 Thread Thomas Monjalon
16/04/2021 22:48, Dmitry Kozlyuk: > buildtools/list-dir-globs.py printed paths with OS directory separator, > which is "/" on Unices and "\" on Windows, while Meson code always > expected "/". This resulted in all drivers being disabled on Windows. > > Replace "\" with "/" in script output. Forwar

Re: [dpdk-dev] [PATCH] doc: add links for preconditions for meson

2021-04-17 Thread Thomas Monjalon
24/02/2021 09:53, as...@nvidia.com: > From: Asaf Penso > > To compile with meson some dependencies should be installed. > Section "Getting the Tools" describes what needed, but per > OS there are additional steps to do. > > Add links to Linux, FreeBSD, and Windows guide for more info. > > Signe

[dpdk-dev] [PATCH 6/7] net/hns3: fix FDIR lock bug

2021-04-17 Thread Min Hu (Connor)
From: Chengwen Feng Currently, the fdir lock was used to protect concurrent access in multiple processes, it has the following problems: 1) Lack of protection for fdir reset recover. 2) Only part data is protected, eg. the filterlist is not protected. We use the following scheme: 1) Del the fdir

[dpdk-dev] [PATCH 4/7] net/hns3: fix the check for DCB mode

2021-04-17 Thread Min Hu (Connor)
From: Huisong Li Currently, "ONLY DCB" and "DCB+RSS" mode are both supported by HNS3 PF driver. But the driver verifies only the "DCB+RSS" multiple queues mode. Fixes: 62e3ccc2b94c ("net/hns3: support flow control") Cc: sta...@dpdk.org Signed-off-by: Huisong Li Signed-off-by: Min Hu (Connor)

[dpdk-dev] [PATCH 5/7] net/hns3: fix the check for VMDq mode

2021-04-17 Thread Min Hu (Connor)
From: Huisong Li HNS3 PF driver only supports RSS, DCB or NONE multiple queues mode. Currently, driver doesn't verify the VMDq multi-queue mode completely. This patch fixes the verification for VMDq mode. Fixes: 62e3ccc2b94c ("net/hns3: support flow control") Cc: sta...@dpdk.org Signed-off-by:

[dpdk-dev] [PATCH 7/7] net/hns3: move the link speeds check to dev configure

2021-04-17 Thread Min Hu (Connor)
From: Huisong Li This patch moves the check for "link_speeds" in dev_conf to dev_configure, so that users know whether "link_speeds" is valid in advance. Fixes: 0d90a6b8e59f ("net/hns3: support link speed autoneg for PF") Fixes: 30b08275cb87 ("net/hns3: support fixed link speed") Signed-off-by:

[dpdk-dev] [PATCH 2/7] net/hns3: Rx vector add compile-time verify

2021-04-17 Thread Min Hu (Connor)
From: Chengwen Feng According the Rx vector implement, it depends on the MBUF's fields (such as rearm_data/rx_descriptor_fields1) layout, this patch adds compile-time verifies with this. Signed-off-by: Chengwen Feng Signed-off-by: Min Hu (Connor) --- drivers/net/hns3/hns3_rxtx_vec.c | 22

[dpdk-dev] [PATCH 1/7] net/hns3: check max SIMD bitwidth

2021-04-17 Thread Min Hu (Connor)
From: Chengwen Feng This patch supports check max SIMD bitwidth when choosing NEON and SVE vector path. Signed-off-by: Chengwen Feng Signed-off-by: Min Hu (Connor) --- drivers/net/hns3/hns3_rxtx.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/net/hns3/hns3_rxtx.c b/drivers/

[dpdk-dev] [PATCH 3/7] net/hns3: remove redundant code about mbx

2021-04-17 Thread Min Hu (Connor)
From: Huisong Li Some mbx messages do not need to reply with data. In this case, it is no need to set the response data address and the response length. This patch removes these redundant codes from mbx messages that do not need be replied. Fixes: a5475d61fa34 ("net/hns3: support VF") Signed-o

[dpdk-dev] [PATCH 0/7] features and bugfix for hns3 PMD

2021-04-17 Thread Min Hu (Connor)
This patchset contains 2 features and 5 bugfixes. Chengwen Feng (3): net/hns3: check max SIMD bitwidth net/hns3: Rx vector add compile-time verify net/hns3: fix FDIR lock bug Huisong Li (4): net/hns3: remove redundant code about mbx net/hns3: fix the check for DCB mode net/hns3: fix t

[dpdk-dev] [PATCH v2 2/7] net/ice: support set VSI reset thread name

2021-04-17 Thread Min Hu (Connor)
From: Chengwen Feng This patch supports set VSI reset thread name which is helpful for debugging. Signed-off-by: Chengwen Feng Signed-off-by: Min Hu (Connor) --- drivers/net/ice/ice_dcf_parent.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/net/ice/ice_d

[dpdk-dev] [PATCH v2 6/7] telemetry: support set init threads name

2021-04-17 Thread Min Hu (Connor)
From: Chengwen Feng This patch supports set init threads name which is helpful for debugging. Signed-off-by: Chengwen Feng Signed-off-by: Min Hu (Connor) --- lib/librte_telemetry/telemetry.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/librte_telemetry/telemetry.c

[dpdk-dev] [PATCH v2 7/7] examples/vhost_blk: support set ctrl worker thread name

2021-04-17 Thread Min Hu (Connor)
From: Chengwen Feng This patch supports set ctrl worker thread name which is helpful for debugging. Signed-off-by: Chengwen Feng Signed-off-by: Min Hu (Connor) --- examples/vhost_blk/vhost_blk.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/examples/vhost_blk/vhost_blk

[dpdk-dev] [PATCH v2 1/7] net/ark: support set thread name

2021-04-17 Thread Min Hu (Connor)
From: Chengwen Feng This patch supports set delay packet generator start thread name which is helpful for debugging. Signed-off-by: Chengwen Feng Signed-off-by: Min Hu (Connor) --- drivers/net/ark/ark_ethdev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net

[dpdk-dev] [PATCH v2 4/7] raw/ifpga: support set monitor thread name

2021-04-17 Thread Min Hu (Connor)
From: Chengwen Feng This patch supports set monitor thread name which is helpful for debugging. Signed-off-by: Chengwen Feng Signed-off-by: Min Hu (Connor) --- drivers/raw/ifpga/ifpga_rawdev.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/raw/ifpga/ifpga_

[dpdk-dev] [PATCH v2 0/7] support set thread name

2021-04-17 Thread Min Hu (Connor)
This set of patches support set thread name for debugging. Chengwen Feng (7): net/ark: support set thread name net/ice: support set VSI reset thread name vdpa/ifc: support set notify and vring relay thread name raw/ifpga: support set monitor thread name examples/performance-thread: suppo

[dpdk-dev] [PATCH v2 5/7] examples/performance-thread: support set thread name

2021-04-17 Thread Min Hu (Connor)
From: Chengwen Feng This patch supports set helloworld thread name which is helpful for debugging. Signed-off-by: Chengwen Feng Signed-off-by: Min Hu (Connor) --- examples/performance-thread/pthread_shim/main.c | 5 + 1 file changed, 5 insertions(+) diff --git a/examples/performance-thre

[dpdk-dev] [PATCH v2 3/7] vdpa/ifc: support set notify and vring relay thread name

2021-04-17 Thread Min Hu (Connor)
From: Chengwen Feng This patch supports set notify and vring relay thread name which is helpful for debugging. Signed-off-by: Chengwen Feng Signed-off-by: Min Hu (Connor) --- drivers/vdpa/ifc/ifcvf_vdpa.c | 20 ++-- 1 file changed, 14 insertions(+), 6 deletions(-) diff --git

Re: [dpdk-dev] [PATCH v6] ethdev: add sanity checks in control APIs

2021-04-17 Thread Min Hu (Connor)
在 2021/4/17 0:28, Stephen Hemminger 写道: On Fri, 16 Apr 2021 11:22:02 +0100 Kevin Traynor wrote: + if (dev_conf == NULL) { + RTE_ETHDEV_LOG(ERR, + "Cannot configure ethdev port %u to NULL dev_conf\n", The others use a natural sounding names instead

Re: [dpdk-dev] [PATCH v7] ethdev: add sanity checks in control APIs

2021-04-17 Thread Min Hu (Connor)
在 2021/4/16 20:02, Thomas Monjalon 写道: 16/04/2021 13:00, Min Hu (Connor): + if (iter == NULL) { + RTE_ETHDEV_LOG(ERR, "Cannot init iterator for NULL iterator\n"); Don't you think it would be better as "Cannot init NULL iterator"? rte_eth_iterator_cleanup(struct rte_d

[dpdk-dev] [PATCH v8] ethdev: add sanity checks in control APIs

2021-04-17 Thread Min Hu (Connor)
This patch adds more sanity checks in control path APIs. Fixes: 214ed1acd125 ("ethdev: add iterator to match devargs input") Fixes: 3d98f921fbe9 ("ethdev: unify prefix for static functions and variables") Fixes: 0366137722a0 ("ethdev: check for invalid device name") Fixes: d948f596fee2 ("ethdev: f