Re: [dpdk-dev] [PATCH] net/ice: fix illegal pointer access when removing mac filter

2021-04-12 Thread Zhang, Qi Z
> -Original Message- > From: Peng, ZhihongX > Sent: Tuesday, April 13, 2021 2:30 PM > To: Ma, WenwuX ; Yang, Qiming > ; Zhang, Qi Z > Cc: dev@dpdk.org > Subject: RE: [dpdk-dev] [PATCH] net/ice: fix illegal pointer access when > removing mac filter > > -Original Message- > From

[dpdk-dev] [PATCH v3] cryptodev: formalize key wrap method in API

2021-04-12 Thread Matan Azrad
The Key Wrap approach is used by applications in order to protect keys located in untrusted storage or transmitted over untrusted communications networks. The constructions are typically built from standard primitives such as block ciphers and cryptographic hash functions. The Key Wrap method and

Re: [dpdk-dev] [PATCH] net/ice: fix illegal pointer access when removing mac filter

2021-04-12 Thread Peng, ZhihongX
-Original Message- From: dev On Behalf Of Wenwu Ma Sent: Friday, April 2, 2021 9:53 PM To: Yang, Qiming ; Zhang, Qi Z Cc: dev@dpdk.org Subject: [dpdk-dev] [PATCH] net/ice: fix illegal pointer access when removing mac filter When removing the mac filter in ice_remove_all_mac_vlan_filters

Re: [dpdk-dev] [PATCH v2 00/14] base code update batch 2

2021-04-12 Thread Yang, Qiming
> -Original Message- > From: Zhang, Qi Z > Sent: 2021年4月13日 13:06 > To: Yang, Qiming > Cc: dev@dpdk.org; Zhang, Qi Z > Subject: [PATCH v2 00/14] base code update batch 2 > > v2: > - Added patch 9/14 - 14/14. > > Qi Zhang (14): > net/ice/base: code cleanup > net/ice/base: support

Re: [dpdk-dev] [EXT] [PATCH v4 4/4] net/mvpp2: check meter packet mode

2021-04-12 Thread Liron Himi
Acked-by: Liron Himi -Original Message- From: Li Zhang Sent: Tuesday, 13 April 2021 06:51 To: dek...@nvidia.com; or...@nvidia.com; viachesl...@nvidia.com; ma...@nvidia.com; shah...@nvidia.com; cristian.dumitre...@intel.com; Liron Himi ; Jerin Jacob Kollanukkaran ; ferruh.yi...@inte

[dpdk-dev] [PATCH v1] net/ice: update QinQ switch filter handling

2021-04-12 Thread Haiyue Wang
The hardware oueter/inner VLAN protocol types are now updated to map to new interface VLAN protocol types, so update the application to use new VLAN protocol types when the rte_flow is QinQ filter type. Signed-off-by: Haiyue Wang --- Depends-on: series-16315 ("base code update batch 2") --- driv

Re: [dpdk-dev] [PATCH v2] net/e1000: fix max Rx packet size

2021-04-12 Thread Zhang, Qi Z
> -Original Message- > From: dev On Behalf Of Wang, Haiyue > Sent: Friday, April 9, 2021 8:59 AM > To: Zhang, AlvinX ; Guo, Jia > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2] net/e1000: fix max Rx packet size > > > -Original Message- > > From: Zhang,

Re: [dpdk-dev] [PATCH] net/ice: use write combining store for tail updates on AVX512 path.

2021-04-12 Thread Zhang, Qi Z
> -Original Message- > From: Nicolau, Radu > Sent: Friday, April 9, 2021 6:09 PM > To: dev@dpdk.org > Cc: Richardson, Bruce ; Rong, Leyi > ; Zhang, Qi Z ; Lu, Wenzhuo > ; Nicolau, Radu > Subject: [PATCH] net/ice: use write combining store for tail updates on > AVX512 path. > > Perform

[dpdk-dev] 回复: [PATCH v1 3/4] net/mlx5: fix rebuild bug for Memory Region cache

2021-04-12 Thread Feifei Wang
Hi, Slava Thanks very much for your attention. Best Regards Feifei > -邮件原件- > 发件人: Slava Ovsiienko > 发送时间: 2021年4月12日 16:28 > 收件人: Feifei Wang ; Matan Azrad > ; Shahaf Shuler ; > ys...@mellanox.com > 抄送: dev@dpdk.org; nd ; sta...@dpdk.org; Ruifeng Wang > > 主题: RE: [PATCH v1 3/4] ne

[dpdk-dev] [PATCH v3 7/8] app/bbdev: add parameter to take input in network order

2021-04-12 Thread Hemant Agrawal
From: Nipun Gupta Test bbdev application is reading the input and output from the test vector files in the same endianness which is of the system. This patch adds an option to provide data in the network order i.e. big endian format Signed-off-by: Nipun Gupta --- app/test-bbdev/test_bbdev_vect

[dpdk-dev] [PATCH v3 8/8] app/bbdev: add test vectors for transport blocks

2021-04-12 Thread Hemant Agrawal
From: Nipun Gupta This patch adds two test vectors for transport block in network byte order: - LDPC encode for Transport Block - LDPC decode for Transport block Signed-off-by: Nipun Gupta --- app/test-bbdev/test_vectors/ldpc_dec_tb.data | 362 ++ app/test-bbdev/test_vectors/ldpc_e

[dpdk-dev] [PATCH v3 3/8] baseband/la12xx: add support for multiple modems

2021-04-12 Thread Hemant Agrawal
This patch add support for multiple modems by assigning a modem id as dev args in vdev creation. Signed-off-by: Hemant Agrawal --- drivers/baseband/la12xx/bbdev_la12xx.c | 60 -- drivers/baseband/la12xx/bbdev_la12xx.h | 56 drivers/baseband/la12xx

[dpdk-dev] [PATCH v3 6/8] baseband/la12xx: add documentation support

2021-04-12 Thread Hemant Agrawal
This patch add documentation for LA12xx PMD. Signed-off-by: Nipun Gupta Signed-off-by: Hemant Agrawal --- MAINTAINERS| 9 ++ doc/guides/bbdevs/features/la12xx.ini | 14 +++ doc/guides/bbdevs/index.rst| 1 + doc/guides/bbdevs/la12xx.rst | 1

[dpdk-dev] [PATCH v3 5/8] baseband/la12xx: add enqueue and dequeue support

2021-04-12 Thread Hemant Agrawal
Add support for enqueue and dequeue the LDPC enc/dec from the modem device. Signed-off-by: Nipun Gupta Signed-off-by: Hemant Agrawal --- drivers/baseband/la12xx/bbdev_la12xx.c | 397 - drivers/baseband/la12xx/bbdev_la12xx_ipc.h | 37 ++ 2 files changed, 430 insertions(+

[dpdk-dev] [PATCH v3 1/8] baseband: introduce NXP LA12xx driver

2021-04-12 Thread Hemant Agrawal
This patch introduce the baseband device drivers for NXP's LA1200 series software defined baseband modem. Signed-off-by: Nipun Gupta Signed-off-by: Hemant Agrawal --- drivers/baseband/la12xx/bbdev_la12xx.c| 109 ++ .../baseband/la12xx/bbdev_la12xx_pmd_logs.h | 38

[dpdk-dev] [PATCH v3 0/8] baseband: add NXP LA12xx driver

2021-04-12 Thread Hemant Agrawal
This series introduces the BBDEV LA12xx poll mode driver (PMD) to support an implementation for offloading High Phy processing functions like LDPC Encode / Decode 5GNR wireless acceleration function, using PCI based LA12xx Software defined radio. Please check the documentation patch for more info.

[dpdk-dev] [PATCH v3 4/8] baseband/la12xx: add queue and modem config support

2021-04-12 Thread Hemant Agrawal
This patch add support for connecting with modem and creating the ipc channel as queues with modem for the exchange of data. Signed-off-by: Nipun Gupta Signed-off-by: Hemant Agrawal --- drivers/baseband/la12xx/bbdev_la12xx.c | 564 - drivers/baseband/la12xx/bbdev_la12xx.

[dpdk-dev] [PATCH v3 2/8] baseband/la12xx: add devargs for max queues

2021-04-12 Thread Hemant Agrawal
This patch adds dev args to take max queues as input Signed-off-by: Nipun Gupta Signed-off-by: Hemant Agrawal --- drivers/baseband/la12xx/bbdev_la12xx.c | 72 +- 1 file changed, 70 insertions(+), 2 deletions(-) diff --git a/drivers/baseband/la12xx/bbdev_la12xx.c b/dri

Re: [dpdk-dev] [PATCH v1] net/ice: add invalid RSS combinations

2021-04-12 Thread Zhang, Qi Z
> -Original Message- > From: Liu, Lingyu > Sent: Thursday, April 8, 2021 11:55 PM > To: dev@dpdk.org; Zhang, Qi Z ; Xing, Beilei > > Cc: Liu, Lingyu > Subject: [PATCH v1] net/ice: add invalid RSS combinations > > When create a rule with following invalid RSS type combinations, it sho

[dpdk-dev] [PATCH v2 13/14] net/ice/base: add PTYPE values for PPPoL2TPv2oUDP

2021-04-12 Thread Qi Zhang
Add some new macros of PTYPE values to support PPPoL2TPv2oUDP. Signed-off-by: Ting Xu Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_flex_type.h | 31 +++- 1 file changed, 30 insertions(+), 1 deletion(-) diff --git a/drivers/net/ice/base/ice_flex_type.h b/drivers

[dpdk-dev] [PATCH v2 11/14] net/ice/base: add inner VLAN protocol type for QinQ filter

2021-04-12 Thread Qi Zhang
Since VLAN protocol type 'ICE_VLAN_OFOS' has been changed to map the hardware VLAN protocol ID to 'ICE_VLAN_OF_HW (16)' when in Double VLAN mode, and to 'ICE_VLAN_OL_HW (17)' when in Single VLAN mode. So 'ICE_VLAN_OFOS' can't be used with 'ICE_VLAN_EX' which is outer VLAN hardware protocol ID 'ICE

[dpdk-dev] [PATCH v2 14/14] net/ice/base: allow support for GTP-U filter using only inner protocols

2021-04-12 Thread Qi Zhang
Adds a support for switch filter: GTP-U using just inner fields. If user doesn't specify outer protocol and its fields but wants to add switch filter for GTP-U using inner protocols and related fields such as inner L3 and/or inner L4, this patch enables such filtering. Signed-off-by: Kiran Patil

[dpdk-dev] [PATCH v2 07/14] net/ice/base: enable I2C read/write commands

2021-04-12 Thread Qi Zhang
Enable I2C read/write AQ commands. They are now required for controlling the external physical connectors via external I2C port expander on E810-T adapters. Signed-off-by: Maciej Machnikowski Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_adminq_cmd.h | 29 + drivers/net/ice/base/

[dpdk-dev] [PATCH v2 12/14] net/ice/base: fix QinQ PPPoE dummy pkt selection

2021-04-12 Thread Qi Zhang
The dummy packet should be QinQ PPPoE ipv6 when ppp protocol is ipv6. Fixes: bb3386f348dd ("net/ice: enable QinQ filter for switch") Cc: sta...@dpdk.org Signed-off-by: Yuying Zhang Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_switch.c | 5 + 1 file changed, 5 insertions(+) diff --

[dpdk-dev] [PATCH v2 09/14] net/ice/base: add set/get GPIO helper functions

2021-04-12 Thread Qi Zhang
Add helper functions to set the GPIO pin state or get the value of a GPIO signal that's the part of the topology based on AQ commands. This change is needed to setup GPIO pins state for PTP, SyncE etc. Signed-off-by: Karol Kolacinski Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_adminq_c

[dpdk-dev] [PATCH v2 10/14] net/ice/base: add priority check of matching recipe

2021-04-12 Thread Qi Zhang
Check priority when look for a recipe which matches our request to enable flow priority for switch filter. Signed-off-by: Yuying Zhang Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_switch.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/net/ice/base/

[dpdk-dev] [PATCH v2 06/14] net/ice/base: change protocol ID for VLAN in case of DVM

2021-04-12 Thread Qi Zhang
Protocol id for first vlan in Double VLAN Mode (DVM) should be ICE_VLAN_OF_HW = 16, but for Single VLAN Mode (SVM) this should be ICE_VLAN_OL_HW = 17. Change protocol id in type to id translation array for outer vlan to 17 when DVM is enabled, which means the driver, package, and firmware support

[dpdk-dev] [PATCH v2 00/14] base code update batch 2

2021-04-12 Thread Qi Zhang
v2: - Added patch 9/14 - 14/14. Qi Zhang (14): net/ice/base: code cleanup net/ice/base: support removing VSI from flow profile net/ice/base: print link configure error net/ice/base: remove unused ptype field in PTT definition net/ice/base: set MAC type for E823C device net/ice/base: ch

[dpdk-dev] [PATCH v2 08/14] net/ice/base: add RSS support for PPPoL2TPv2oUDP

2021-04-12 Thread Qi Zhang
Add support for PPPoL2TPv2oUDP RSS hash. L2TPv2 and PPP ptypes and flow headers are added. Prot id for PPP is added. Signed-off-by: Ting Xu Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_flow.c | 65 ++-- drivers/net/ice/base/ice_flow.h | 2 + driver

[dpdk-dev] [PATCH v2 01/14] net/ice/base: code cleanup

2021-04-12 Thread Qi Zhang
1. There are a lots of function header mismatch its function name. 2. remove unnecessary header file include. 3. remove unnecessary macro. 4. remove unnecessary comment. Signed-off-by: Dave Ertman Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_common.c| 4 ++-- drivers/net/ice/base/i

[dpdk-dev] [PATCH v2 05/14] net/ice/base: set MAC type for E823C device

2021-04-12 Thread Qi Zhang
Set E823C device's MAC type as generic. Signed-off-by: Anirudh Venkataramanan Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_common.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/net/ice/base/ice_common.c b/drivers/net/ice/base/ice_common.c index 5c21d71b70..356a8b4d0

[dpdk-dev] [PATCH v2 02/14] net/ice/base: support removing VSI from flow profile

2021-04-12 Thread Qi Zhang
Adding a function ice_flow_rem_vsi_prof() to remove flow entries associated to the sw vsi handle. Once complete clear the vsi index from the flow profile bitmap. This will ensure that the a vsi once removed can be re-added and the package block rules will be added again. Signed-off-by: Vignesh Sri

[dpdk-dev] [PATCH v2 04/14] net/ice/base: remove unused ptype field in PTT definition

2021-04-12 Thread Qi Zhang
Remove the unused ptype entry, and use the gcc extension for ranged initializers in arrays for Linux, and explicitly target each table entry by index when initializing under Linux. Signed-off-by: Jesse Brandeburg Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_lan_tx_rx.h | 10 --

[dpdk-dev] [PATCH v2 03/14] net/ice/base: print link configure error

2021-04-12 Thread Qi Zhang
Newer NVMs return link_cfg_err for get_link_status AQ. Print it for debug use. Signed-off-by: Anirudh Venkataramanan Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_common.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ice/base/ice_common.c b/drivers/net/ice/base/ice_co

[dpdk-dev] [RFC][PATCH] bbdev: add raw operation support for additional offloads

2021-04-12 Thread Hemant Agrawal
The exisiting bbdev APIs are limited for the lookaside FEC offload only. The modem/FPGA can do much more than just the FEC offload. This patch extend the operation to userdefined raw parameters, where they can offload more than just the FEC offload processing. e.g. some of the devices are capable

Re: [dpdk-dev] [PATCH v9 0/4] eal/windows: do not expose POSIX symbols

2021-04-12 Thread Ranjit Menon
Hi Dmitry, On 4/10/2021 3:47 PM, Dmitry Kozlyuk wrote: On Windows, EAL contains two sets of functions and macros for POSIX compatibility: and a networking shim (socket headers). The latter conflicts with system headers and should not exist. Exposing the former from EAL can break consumer own PO

Re: [dpdk-dev] [PATCH v2] eventdev: fix case to initiate crypto adapter service

2021-04-12 Thread Gujjar, Abhinandan S
> -Original Message- > From: Shijith Thotton > Sent: Monday, April 12, 2021 2:24 PM > To: dev@dpdk.org > Cc: Shijith Thotton ; Gujjar, Abhinandan S > ; Jerin Jacob ; Akhil > Goyal ; Anoob Joseph > Subject: [PATCH v2] eventdev: fix case to initiate crypto adapter service > > Initiate s

[dpdk-dev] [PATCH v3 1/2] common/mlx5: add meter mode definition in PRM file

2021-04-12 Thread Li Zhang
Add meter mode definitions in PRM file Signed-off-by: Li Zhang Acked-by: Matan Azrad --- drivers/common/mlx5/mlx5_prm.h | 8 1 file changed, 8 insertions(+) diff --git a/drivers/common/mlx5/mlx5_prm.h b/drivers/common/mlx5/mlx5_prm.h index c6d8060bb9..efa5ae67bf 100644 --- a/drivers/c

[dpdk-dev] [PATCH v3 0/2] Support meter PPS(packet per second) in MLX5 PMD

2021-04-12 Thread Li Zhang
Currently meter algorithms only supports rate is bytes per second(BPS). Add packet_mode flag in meter profile parameters data structure. So that it can meter traffic by packet per second. Depends-on: series=16312 ("Support PPS(packet per second) on meter") https://patchwork.dpdk.org/project/dpdk/

[dpdk-dev] [PATCH v3 2/2] net/mlx5: support meter PPS profile

2021-04-12 Thread Li Zhang
Currently meter algorithms only supports bytes per second(BPS). Such as Single Rate Three Color Marker (srTCM rfc2697) Add packet_mode flag to support rate is packet per second. So that it can meter traffic by packet per second (PPS). Signed-off-by: Li Zhang Acked-by: Matan Azrad --- doc/guides

[dpdk-dev] [PATCH v4 4/4] net/mvpp2: check meter packet mode

2021-04-12 Thread Li Zhang
Currently meter algorithms only supports bytes per second(BPS). Check packet_mode set to TRUE are rejected. Signed-off-by: Li Zhang Acked-by: Matan Azrad --- drivers/net/mvpp2/mrvl_mtr.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/net/mvpp2/mrvl_mtr.c b/drivers/net/mvpp2/m

[dpdk-dev] [PATCH v4 0/4] Support PPS(packet per second) on meter

2021-04-12 Thread Li Zhang
Currently meter algorithms only supports rate is bytes per second(BPS). Add packet_mode flag in meter profile parameters data structure. So that it can meter traffic by packet per second. When packet_mode is 0, the profile rates and bucket sizes are specified in bytes per second and bytes when pac

[dpdk-dev] [PATCH v4 3/4] net/softnic: check meter packet mode

2021-04-12 Thread Li Zhang
Currently meter algorithms only supports bytes per second(BPS). Check packet_mode set to TRUE are rejected. Signed-off-by: Li Zhang Acked-by: Matan Azrad Acked-by: Cristian Dumitrescu --- drivers/net/softnic/rte_eth_softnic_meter.c | 8 1 file changed, 8 insertions(+) diff --git a/dr

[dpdk-dev] [PATCH v4 2/4] app/testpmd: add meter profile packet mode option

2021-04-12 Thread Li Zhang
add meter profile packet_mode to the ethernet device. One example: add port meter profile rfc2697 (port_id) (profile_id) (cir) (cbs) (ebs) (packet_mode) Signed-off-by: Li Zhang Acked-by: Matan Azrad --- app/test-pmd/cmdline.c | 6 ++-- app/test-pmd/cmdline_mtr.c

[dpdk-dev] [PATCH v4 1/4] ethdev: add packet mode in meter profile structure

2021-04-12 Thread Li Zhang
Currently meter algorithms only supports rate is bytes per second(BPS). Add packet_mode flag in meter profile parameters data structure. So that it can meter traffic by packet per second. When packet_mode is 0, the profile rates and bucket sizes are specified in bytes per second and bytes when pac

Re: [dpdk-dev] [PATCH v7 3/3] test/event_crypto: use crypto adapter enqueue API

2021-04-12 Thread Gujjar, Abhinandan S
Acked-by: abhinandan.guj...@intel.com > -Original Message- > From: Shijith Thotton > Sent: Monday, April 12, 2021 1:14 PM > To: dev@dpdk.org > Cc: Shijith Thotton ; tho...@monjalon.net; > jer...@marvell.com; Gujjar, Abhinandan S ; > hemant.agra...@nxp.com; nipun.gu...@nxp.com; > sachin.s

Re: [dpdk-dev] [PATCH v7 2/3] event/octeontx2: support crypto adapter forward mode

2021-04-12 Thread Gujjar, Abhinandan S
> -Original Message- > From: Shijith Thotton > Sent: Monday, April 12, 2021 1:14 PM > To: dev@dpdk.org > Cc: Shijith Thotton ; tho...@monjalon.net; > jer...@marvell.com; Gujjar, Abhinandan S ; > hemant.agra...@nxp.com; nipun.gu...@nxp.com; > sachin.sax...@oss.nxp.com; ano...@marvell.com

Re: [dpdk-dev] [PATCH v5 1/4] vhost: abstract and reorganize async split ring code

2021-04-12 Thread Jiang, Cheng1
Hi Jiayu, > -Original Message- > From: Hu, Jiayu > Sent: Tuesday, April 13, 2021 10:44 AM > To: Jiang, Cheng1 ; maxime.coque...@redhat.com; > Xia, Chenbo > Cc: dev@dpdk.org; Yang, YvonneX ; Wang, Yinan > ; Liu, Yong > Subject: RE: [PATCH v5 1/4] vhost: abstract and reorganize async spli

[dpdk-dev] [PATCH v1] bus/auxiliary: introduce auxiliary bus

2021-04-12 Thread Xueming Li
Auxiliary [1] provides a way to split function into child-devices representing sub-domains of functionality. Each auxiliary_device represents a part of its parent functionality. Auxiliary device is identified by unique device name, sysfs path: /sys/bus/auxiliary/devices/ [1] kernel auxiliary bu

Re: [dpdk-dev] [PATCH] ethdev: add sanity checks in control APIs

2021-04-12 Thread Min Hu (Connor)
Hi, Ferruh, Thanks for your comment. All has been fixed in v2, please check it out. Thanks. 在 2021/4/13 7:08, Ferruh Yigit 写道: On 4/10/2021 10:18 AM, Min Hu (Connor) wrote: This patch adds more sanity checks in control path APIs. Fixes: 214ed1acd125 ("ethdev: add iterat

Re: [dpdk-dev] [PATCH v7 1/3] eventdev: introduce crypto adapter enqueue API

2021-04-12 Thread Gujjar, Abhinandan S
> -Original Message- > From: Shijith Thotton > Sent: Monday, April 12, 2021 1:14 PM > To: dev@dpdk.org > Cc: Akhil Goyal ; tho...@monjalon.net; > jer...@marvell.com; Gujjar, Abhinandan S ; > hemant.agra...@nxp.com; nipun.gu...@nxp.com; > sachin.sax...@oss.nxp.com; ano...@marvell.com; ma

[dpdk-dev] [PATCH v2] ethdev: add sanity checks in control APIs

2021-04-12 Thread Min Hu (Connor)
This patch adds more sanity checks in control path APIs. Fixes: 214ed1acd125 ("ethdev: add iterator to match devargs input") Fixes: 3d98f921fbe9 ("ethdev: unify prefix for static functions and variables") Fixes: 0366137722a0 ("ethdev: check for invalid device name") Fixes: d948f596fee2 ("ethdev: f

[dpdk-dev] [PATCH v5 5/5] devargs: parse global device syntax

2021-04-12 Thread Xueming Li
When parsing a devargs, try to parse using the global device syntax first. Fallback on legacy syntax on error. Example of new global device syntax: -a bus=pci,addr=82:00.0/class=eth/driver=mlx5,dv_flow_en=1 Signed-off-by: Xueming Li Reviewed-by: Gaetan Rivet --- doc/guides/rel_notes/release_2

[dpdk-dev] [PATCH v5 2/5] devargs: fix memory leak on parsing error

2021-04-12 Thread Xueming Li
This patch fixes memory leak in parsing error handling. Fixes: 338327d731e6 ("devargs: add function to parse device layers") Cc: gaetan.ri...@6wind.com Cc: sta...@dpdk.org Signed-off-by: Xueming Li Reviewed-by: Gaetan Rivet --- lib/librte_eal/common/eal_common_devargs.c | 10 +- 1 file

[dpdk-dev] [PATCH v5 4/5] bus: add device arguments name parsing API

2021-04-12 Thread Xueming Li
For device probe and iterator, devargs name was key information, parsed by rte_devargs_parse. In legacy parser, devargs name was extracted after bus name: bus:name,kv_arguments,,, Example: pci:83:00.0,arguments,... vdev:pcap0,... To be compatible with legacy parser, this patch introduces new

[dpdk-dev] [PATCH v5 3/5] kvargs: add get by key function

2021-04-12 Thread Xueming Li
Adds a new function to get value of a specific key from kvargs list. Signed-off-by: Xueming Li Reviewed-by: Gaetan Rivet --- lib/librte_kvargs/rte_kvargs.c | 15 +++ lib/librte_kvargs/rte_kvargs.h | 20 lib/librte_kvargs/version.map | 3 +++ 3 files changed, 3

[dpdk-dev] [PATCH v5 1/5] devargs: unify scratch buffer storage

2021-04-12 Thread Xueming Li
In current design, legacy parser rte_devargs_parse() saved scratch buffer to devargs.args while new parser rte_devargs_layers_parse() saved to devargs.data. Code using devargs had to know the difference and cleaned up memory accordingly - error prone. This patch unifies scratch buffer to data fiel

[dpdk-dev] [PATCH v5 0/5] eal: enable global device syntax by default

2021-04-12 Thread Xueming Li
The new Global Device Syntax [1] is used to identify a device with full bus, class and driver description, example: -a bus=pci,addr=82:00.0/class=eth/driver=mlx5,... This patchset fixes bugs and enable global device syntax with backward compatibility by: - unify devargs memory buffer cleanup - pa

Re: [dpdk-dev] [PATCH v3 2/4] app/testpmd: add meter profile packet mode option

2021-04-12 Thread Li Zhang
Hi Ferruh, > -Original Message- > From: Ferruh Yigit > Sent: Tuesday, April 13, 2021 7:51 AM > To: Li Zhang ; dek...@nvidia.com; Ori Kam > ; Slava Ovsiienko ; Matan > Azrad ; Shahaf Shuler ; > cristian.dumitre...@intel.com; lir...@marvell.com; Xiaoyun Li > > Cc: dev@dpdk.org; NBU-Contact

Re: [dpdk-dev] [PATCH v3 0/4] Support PPS(packet per second) on meter

2021-04-12 Thread Li Zhang
Hi Ferruh, You are right. I will delete this series=15998 and also rebase on latest master in V4 patch. Regards, Li Zhang > -Original Message- > From: Ferruh Yigit > Sent: Tuesday, April 13, 2021 7:55 AM > To: Li Zhang ; dek...@nvidia.com; Ori Kam > ; Slava Ovsiienko ; Matan > Azrad ;

Re: [dpdk-dev] [PATCH v5 1/4] vhost: abstract and reorganize async split ring code

2021-04-12 Thread Hu, Jiayu
Hi Cheng, Some comments inline. > -Original Message- > From: Jiang, Cheng1 > Sent: Monday, April 12, 2021 7:34 PM > To: maxime.coque...@redhat.com; Xia, Chenbo > Cc: dev@dpdk.org; Hu, Jiayu ; Yang, YvonneX > ; Wang, Yinan ; Liu, > Yong ; Jiang, Cheng1 > Subject: [PATCH v5 1/4] vhost: a

Re: [dpdk-dev] [PATCH v3 4/4] net/iavf: support FDIR for IP fragment packet

2021-04-12 Thread Guo, Jia
Hi, Ting > -Original Message- > From: Xu, Ting > Sent: Monday, April 12, 2021 4:45 PM > To: Guo, Jia ; or...@nvidia.com; Zhang, Qi Z > ; Xing, Beilei ; Li, Xiaoyun > ; Wu, Jingjing ; Guo, Junfeng > > Cc: dev@dpdk.org > Subject: RE: [PATCH v3 4/4] net/iavf: support FDIR for IP fragment pa

Re: [dpdk-dev] [PATCH v3 1/3] net/ice/base: support IP fragment RSS and FDIR

2021-04-12 Thread Guo, Jia
Hi, Ting > -Original Message- > From: Xu, Ting > Sent: Monday, April 12, 2021 4:31 PM > To: Guo, Jia ; Zhang, Qi Z ; Yang, > Qiming > Cc: dev@dpdk.org > Subject: RE: [PATCH v3 1/3] net/ice/base: support IP fragment RSS and FDIR > > Hi, Jeff, > > Best Regards, > Xu Ting > > > -Orig

Re: [dpdk-dev] [PATCH v2 4/5] net/mlx5: add mlx5 APIs for single flow dump feature

2021-04-12 Thread Haifei Luo
Hi Slava, For #1, The steering tool send messages to DPDK to request dump. Server/Client use data structure "struct msghdr" to communicate. It has " msg_iov " ," msg_iovlen" and etc. In the tool side, Msg_iov is constructed as 1 byte for port_id, 8 bytes for flowptr. In DPDK, then

Re: [dpdk-dev] [PATCH v2 1/4] ethdev: introduce indirect action APIs

2021-04-12 Thread Bing Zhao
Hi Ferruh, > -Original Message- > From: Ferruh Yigit > Sent: Tuesday, April 13, 2021 3:42 AM > To: Bing Zhao ; Ori Kam ; NBU- > Contact-Thomas Monjalon ; > andrew.rybche...@oktetlabs.ru; Matan Azrad ; Slava > Ovsiienko > Cc: dev@dpdk.org; ajit.khapa...@broadcom.com; Gregory Etelson > ; A

Re: [dpdk-dev] [PATCH v2 0/4] Change shared action API to action handle API

2021-04-12 Thread Bing Zhao
Hi Ferruh, Thanks for your comments. > -Original Message- > From: Ferruh Yigit > Sent: Tuesday, April 13, 2021 3:40 AM > To: Bing Zhao ; Ori Kam ; NBU- > Contact-Thomas Monjalon ; > andrew.rybche...@oktetlabs.ru; Matan Azrad ; Slava > Ovsiienko > Cc: dev@dpdk.org; ajit.khapa...@broadcom

Re: [dpdk-dev] [PATCH 0/7] support set thread name

2021-04-12 Thread fengchengwen
On 2021/4/12 15:19, David Marchand wrote: > On Sat, Apr 10, 2021 at 12:40 PM Min Hu (Connor) wrote: >> >> This set of patches support set thread name for debugging. >> >> Chengwen Feng (7): >> net/ark: support set thread name >> net/ice: support set VSI reset thread name >> vdpa/ifc: supp

Re: [dpdk-dev] [PATCH 0/7] support set thread name

2021-04-12 Thread Min Hu (Connor)
在 2021/4/12 15:19, David Marchand 写道: On Sat, Apr 10, 2021 at 12:40 PM Min Hu (Connor) wrote: This set of patches support set thread name for debugging. Chengwen Feng (7): net/ark: support set thread name net/ice: support set VSI reset thread name vdpa/ifc: support set notify and

Re: [dpdk-dev] [PATCH 0/2] refactor support LSC event report

2021-04-12 Thread Ferruh Yigit
On 4/9/2021 5:45 AM, Min Hu (Connor) wrote: This set of patches refactor support LSC event report. Chengwen Feng (2): net/hns3: refactor VF support LSC event report net/hns3: refactor PF support LSC event report Series applied to dpdk-next-net/main, thanks.

[dpdk-dev] [PATCH v3 1/4] net/mlx5: support meter policy operations

2021-04-12 Thread Li Zhang
MLX5 PMD checks the validation of actions in policy while add a new meter policy, if pass the validation, allocates the new policy object from the meter policy indexed memory pool. It is common to use the same policy for multiple meters. MLX5 PMD supports two types of policy: termination policy an

[dpdk-dev] [PATCH v3 0/4] net/mlx5: support meter policy operations

2021-04-12 Thread Li Zhang
MLX5 PMD checks the validation of actions in policy while add a new meter policy, if pass the validation, allocates the new policy object from the meter policy indexed memory pool. It is common to use the same policy for multiple meters. MLX5 PMD supports two types of policy: termination policy an

[dpdk-dev] [PATCH v3 4/4] net/mlx5: connect meter policy to created flows

2021-04-12 Thread Li Zhang
From: Shun Hao Currently ASO meter must be followed by policy table, so this adds the support that connecting meter and policy table. There are several cases to be considered: 1. For non-termination policy, connect meter to the default policy table. 2. For non-RSS termination policy case, simply

[dpdk-dev] [PATCH v3 2/4] net/mlx5: support meter creation with policy

2021-04-12 Thread Li Zhang
Create a meter with the new pre-defined policy. The following cases to be considered: 1.Add entry match with meter_id in global drop table. 2.For non-termination policy (policy id 0), add jump rule to suffix table for green and jump rule to drop table for red. 3.Allocate counter per meter in d

[dpdk-dev] [PATCH v3 3/4] net/mlx5: prepare sub-policy for a flow with meter

2021-04-12 Thread Li Zhang
When a flow has a RSS action, the driver splits each sub flow finally is configured with a different HW TIR action. Any RSS action configured in meter policy may cause a split in the flow configuration. To save performance, any TIR action will be configured in different flow table, so policy can b

[dpdk-dev] [PATCH v3 2/2] app/testpmd: support policy actions per color

2021-04-12 Thread Li Zhang
From: Haifei Luo Add the create/del policy CLIs to support actions per color. The CLIs are: Create: add port meter policy (port_id) (policy_id) g_actions (actions) y_actions (actions) r_actions (actions) Delete: del port meter policy (port_id) (policy_id) Examples: testpmd> add port meter poli

[dpdk-dev] [PATCH v3 0/2] Support meter policy API

2021-04-12 Thread Li Zhang
Currently, the flow meter policy does not support multiple actions per color; also the allowed action types per color are very limited. In addition, the policy cannot be pre-defined. Due to the growing in flow actions offload abilities there is a potential for the user to use variety of actions pe

[dpdk-dev] [PATCH v3 1/2] ethdev: add pre-defined meter policy API

2021-04-12 Thread Li Zhang
Currently, the flow meter policy does not support multiple actions per color; also the allowed action types per color are very limited. In addition, the policy cannot be pre-defined. Due to the growing in flow actions offload abilities there is a potential for the user to use variety of actions pe

[dpdk-dev] [PATCH v3 11/14] net/mlx5: aso flow meter send WQE and CQE handle

2021-04-12 Thread Li Zhang
ASO flow meter send WQE and CQE handle functions Signed-off-by: Li Zhang Acked-by: Matan Azrad --- drivers/net/mlx5/mlx5.h| 4 + drivers/net/mlx5/mlx5_flow_aso.c | 183 - drivers/net/mlx5/mlx5_flow_meter.c | 143 +- 3 files changed

[dpdk-dev] [PATCH v3 13/14] net/mlx5: make ASO meter queue thread-safe

2021-04-12 Thread Li Zhang
Synchronize ASO meter queue accesses from different threads using a spinlock. Signed-off-by: Li Zhang Acked-by: Matan Azrad --- drivers/net/mlx5/mlx5.h | 1 + drivers/net/mlx5/mlx5_flow_aso.c | 16 +--- 2 files changed, 14 insertions(+), 3 deletions(-) diff --git a/driver

[dpdk-dev] [PATCH v3 10/14] net/mlx5: initialize the flow meter ASO SQ

2021-04-12 Thread Li Zhang
Initialize the flow meter ASO SQ WQEs with all the constant data that should not be updated per enqueue operation. Signed-off-by: Li Zhang Acked-by: Matan Azrad --- drivers/net/mlx5/linux/mlx5_os.c | 17 drivers/net/mlx5/meson.build | 2 +- drivers/net/mlx5/m

[dpdk-dev] [PATCH v3 08/14] common/mlx5: add DevX API to create ASO flow meter object

2021-04-12 Thread Li Zhang
Add DevX API to create ASO flow meter object. Signed-off-by: Li Zhang Acked-by: Matan Azrad --- drivers/common/mlx5/mlx5_devx_cmds.c | 54 drivers/common/mlx5/mlx5_devx_cmds.h | 18 +- drivers/common/mlx5/version.map | 1 + 3 files changed, 72 insertio

[dpdk-dev] [PATCH v3 14/14] net/mlx5: allow multiple flow tables on the same level

2021-04-12 Thread Li Zhang
The driver devices support creation of multiple flow tables. Jump action can be used in order to move the packet steering to different flow table. Table 0 is always the root table for packet steering. Jumping between tables may cause endless loops in steering mechanism, that's why each table has l

[dpdk-dev] [PATCH v3 07/14] common/mlx5: add read ASO flow meter HCA capability

2021-04-12 Thread Li Zhang
Read and store the device capability of FLOW_METER_ASO general object, using the DevX API. Signed-off-by: Li Zhang Acked-by: Matan Azrad --- drivers/common/mlx5/mlx5_devx_cmds.c | 14 ++ drivers/common/mlx5/mlx5_devx_cmds.h | 8 2 files changed, 22 insertions(+) diff --gi

[dpdk-dev] [PATCH v3 12/14] net/mlx5: add support of ASO meter action

2021-04-12 Thread Li Zhang
When ASO action is available, use it as the meter action Signed-off-by: Shun Hao Signed-off-by: Li Zhang Acked-by: Matan Azrad --- drivers/net/mlx5/linux/mlx5_os.c | 7 ++- drivers/net/mlx5/mlx5.c| 12 drivers/net/mlx5/mlx5.h| 7 ++- drivers/net/mlx5/mlx5_flow.

[dpdk-dev] [PATCH v3 06/14] common/mlx5: add definitions for ASO flow meter

2021-04-12 Thread Li Zhang
This patch adds different PRM definitions, related to ASO flow meter feature, in MLX5 PMD code. Signed-off-by: Li Zhang Acked-by: Matan Azrad --- drivers/common/mlx5/mlx5_prm.h | 75 -- 1 file changed, 71 insertions(+), 4 deletions(-) diff --git a/drivers/common

[dpdk-dev] [PATCH v3 09/14] net/mlx5: flow meter pool to manage meter object

2021-04-12 Thread Li Zhang
Add ASO flow meter pool to manage meter object Signed-off-by: Li Zhang Acked-by: Matan Azrad --- drivers/net/mlx5/mlx5.c| 2 +- drivers/net/mlx5/mlx5.h| 207 - drivers/net/mlx5/mlx5_flow.c | 70 - drivers/net/mlx5/mlx5_flow.h | 196 +++-

[dpdk-dev] [PATCH v3 03/14] net/mlx5: fix meter statistics

2021-04-12 Thread Li Zhang
From: Shun Hao Currently, packets after meter will be steered to a global policer table, which includes green/red color rules for every meter, so as to have counter statistics of each color in every meter. There's a bug that all the rules in global policer table are matching only color criteria,

[dpdk-dev] [PATCH v3 01/14] net/mlx5: support three level table walk

2021-04-12 Thread Li Zhang
From: Suanming Mou This commit adds table entry walk for the three level table. Signed-off-by: Suanming Mou Acked-by: Matan Azrad --- drivers/net/mlx5/mlx5_utils.h | 90 +++ 1 file changed, 90 insertions(+) diff --git a/drivers/net/mlx5/mlx5_utils.h b/drivers/

[dpdk-dev] [PATCH v3 05/14] net/mlx5: use mask for meter register setting

2021-04-12 Thread Li Zhang
From: Shun Hao ASO meter feature may require to locate the flow context tag action after the ASO action. When color register is shared by meter_id/flow_id, it's like: Bits[0-7] A meter color value set by the HW. Bits[8-31] A flow id and meter id set by SW. Currently the tag action for meter writ

[dpdk-dev] [PATCH v3 02/14] common/mlx5: add color register idle bits definition

2021-04-12 Thread Li Zhang
From: Shun Hao 8 bits are used for meter color in meter register. When the meter register can be shared, the rest 24 bits can be used by others. This adds the definination for the 24 bits that can be shared. Signed-off-by: Shun Hao Acked-by: Matan Azrad --- drivers/common/mlx5/mlx5_prm.h | 6

[dpdk-dev] [PATCH v3 00/14] Add ASO meter support in MLX5 PMD

2021-04-12 Thread Li Zhang
To support more meters and better performance, MLX HW provide ASO flow meter. It can expose millions of ASO flow meter context's in HW. This ASO object can allocate the large bulk meter objects. This patch set implement the ASO flow meter for mlx5 driver. MLX5 PMD driver will be responsible for ASO

Re: [dpdk-dev] [PATCH v3 0/4] Support PPS(packet per second) on meter

2021-04-12 Thread Ferruh Yigit
On 4/10/2021 8:24 AM, Li Zhang wrote: Currently meter algorithms only supports rate is bytes per second(BPS). Add packet_mode flag in meter profile parameters data structure. So that it can meter traffic by packet per second. When packet_mode is 0, the profile rates and bucket sizes are specifie

Re: [dpdk-dev] [PATCH v3 2/4] app/testpmd: add meter profile packet mode option

2021-04-12 Thread Ferruh Yigit
On 4/10/2021 8:24 AM, Li Zhang wrote: add meter profile packet_mode to the ethernet device. One example: add port meter profile rfc2697 (port_id) (profile_id) (cir) (cbs) (ebs) (packet_mode) Signed-off-by: Li Zhang Acked-by: Matan Azrad <...> @@ -365,7 +383,7 @@ static void cmd_add_port_me

Re: [dpdk-dev] [PATCH v4 5/5] devargs: parse global device syntax

2021-04-12 Thread Xueming(Steven) Li
> -Original Message- > From: Thomas Monjalon > Sent: Tuesday, April 13, 2021 5:25 AM > To: Xueming(Steven) Li > Cc: Gaetan Rivet ; dev@dpdk.org; Xueming(Steven) Li > ; Asaf Penso > ; Ferruh Yigit ; Andrew Rybchenko > > Subject: Re: [dpdk-dev] [PATCH v4 5/5] devargs: parse global devi

Re: [dpdk-dev] [PATCH v4 4/5] bus: add device arguments name parsing API

2021-04-12 Thread Xueming(Steven) Li
> -Original Message- > From: Thomas Monjalon > Sent: Tuesday, April 13, 2021 5:17 AM > To: Xueming(Steven) Li > Cc: Gaetan Rivet ; dev@dpdk.org; Asaf Penso > > Subject: Re: [dpdk-dev] [PATCH v4 4/5] bus: add device arguments name parsing > API > > 10/04/2021 16:23, Xueming Li: > >

Re: [dpdk-dev] [PATCH v2 1/2] ethdev: add packet integrity checks

2021-04-12 Thread Ferruh Yigit
On 4/12/2021 8:26 PM, Ori Kam wrote: Hi Ferruh, -Original Message- From: Ferruh Yigit Subject: Re: [PATCH v2 1/2] ethdev: add packet integrity checks On 4/11/2021 6:34 PM, Gregory Etelson wrote: From: Ori Kam Currently, DPDK application can offload the checksum check, and report it

Re: [dpdk-dev] [PATCH] ethdev: add sanity checks in control APIs

2021-04-12 Thread Ferruh Yigit
On 4/10/2021 10:18 AM, Min Hu (Connor) wrote: This patch adds more sanity checks in control path APIs. Fixes: 214ed1acd125 ("ethdev: add iterator to match devargs input") Fixes: 3d98f921fbe9 ("ethdev: unify prefix for static functions and variables") Fixes: 0366137722a0 ("ethdev: check for inval

Re: [dpdk-dev] [pull-request] dpdk-next-net-eventdev - 21.05 - PRE-RC1

2021-04-12 Thread Thomas Monjalon
12/04/2021 15:20, Jerin Jacob Kollanukkaran: > http://dpdk.org/git/next/dpdk-next-eventdev Pulled, thanks. Note few changes in titles like uppercases for acronyms, or "add support" simplified as "support", and release notes moved in the right place.

[dpdk-dev] [PATCH] devtools: test different build types

2021-04-12 Thread Thomas Monjalon
All builds were of type debugoptimized. It is kept only for builds having an ABI check. Others will have the default build type (release), except if specified differently as in the x86 generic build which will be a test of the non-optimized debug build type. Some static builds will test the minsize

Re: [dpdk-dev] [PATCH v4 5/5] devargs: parse global device syntax

2021-04-12 Thread Thomas Monjalon
10/04/2021 16:23, Xueming Li: > --- a/doc/guides/rel_notes/release_21_05.rst > +++ b/doc/guides/rel_notes/release_21_05.rst > @@ -131,6 +131,12 @@ New Features >* Added command to display Rx queue used descriptor count. > ``show port (port_id) rxq (queue_id) desc used count`` > > +* **En

  1   2   >