Re: [dpdk-dev] [PATCH] app/testpmd: fix Tx/Rx descriptor query error log

2021-03-28 Thread Min Hu (Connor)
Hi, xiaoyun, All has been done in v2, please review it, thanks. 在 2021/3/29 13:49, Li, Xiaoyun 写道: Hi -Original Message- From: Min Hu (Connor) Sent: Saturday, March 27, 2021 15:35 To: dev@dpdk.org Cc: Yigit, Ferruh ; Li, Xiaoyun Subject: [PATCH] app/testpmd: fix Tx/Rx descrip

[dpdk-dev] [PATCH v2] app/testpmd: fix Tx/Rx descriptor query error log

2021-03-28 Thread Min Hu (Connor)
From: Hongbo Zheng This patch adds more err info for Tx/Rx descriptor query command. Fixes: fae9aa717d6c ("app/testpmd: support checking descriptor status") Cc: sta...@dpdk.org Signed-off-by: Hongbo Zheng Signed-off-by: Min Hu (Connor) --- v2: * Fixed error log info and simply the commit info

[dpdk-dev] [PATCH] librte_eal: add APIs to speedup virt2iova/phys

2021-03-28 Thread Li Feng
Hi david, Sorry for late response. I just see your mail on my trip. I will update this patch, if anyone has interest in this feature. Currently it's in my own repo. 在 2021年3月25日星期四,David Marchand 写道: > Hello, > > On Mon, Apr 20, 2020 at 4:13 PM Li Feng wrote: > > > > Cool, thank you, Anatoly

Re: [dpdk-dev] [PATCH v8 4/8] eventdev: add Rx adapter event vector support

2021-03-28 Thread Jayatheerthan, Jay
> -Original Message- > From: Jerin Jacob > Sent: Sunday, March 28, 2021 1:49 PM > To: Pavan Nikhilesh > Cc: Jerin Jacob ; Jayatheerthan, Jay > ; Carrillo, Erik G ; > Gujjar, Abhinandan S ; McDaniel, Timothy > ; Hemant Agrawal > ; Van Haaren, Harry ; > mattias.ronnblom > ; Ma, Liang J ;

Re: [dpdk-dev] [PATCH v6] doc: add release milestones definition

2021-03-28 Thread Ajit Khaparde
On Sun, Mar 28, 2021 at 12:00 PM Thomas Monjalon wrote: > > From: Asaf Penso > > Adding more information about the release milestones. > This includes the scope of change, expectations, etc. > > Signed-off-by: Asaf Penso > Signed-off-by: Thomas Monjalon > Acked-by: John McNamara Acked-by: Ajit

Re: [dpdk-dev] [PATCH] app/testpmd: fix Tx/Rx descriptor query error log

2021-03-28 Thread Li, Xiaoyun
Hi > -Original Message- > From: Min Hu (Connor) > Sent: Saturday, March 27, 2021 15:35 > To: dev@dpdk.org > Cc: Yigit, Ferruh ; Li, Xiaoyun > Subject: [PATCH] app/testpmd: fix Tx/Rx descriptor query error log > > From: Hongbo Zheng > > Currently in testpmd, if we input "show port 0 rx

[dpdk-dev] [PATCH] net/ice/base: support MPLS ethertype switch filter

2021-03-28 Thread Alvin Zhang
Add MPLS training packet and offsets. Add check if the type is MPLS for ethertype filters. For example: flow create 0 ingress pattern eth dst is 00:11:22:33:44:55 type is 0x8847 / end actions queue index 2 / end This flow will result in all the matched ingress packets be forwarded to queue

[dpdk-dev] [PATCH v1] net/ice: remove the redundant function type

2021-03-28 Thread Haiyue Wang
The function 'ice_is_profile_rule' is defined as 'ice_is_prof_rule' in base code, which has the exactly same function body. So remove the 'ice_is_profile_rule', use the 'ice_is_prof_rule' instead. Signed-off-by: Haiyue Wang --- drivers/net/ice/ice_switch_filter.c | 22 +- 1

Re: [dpdk-dev] [PATCH v1 2/2] event/octeontx2: support crypto adapter forward mode

2021-03-28 Thread Shijith Thotton
On Sat, Mar 27, 2021 at 06:27:49AM +, Pavan Nikhilesh Bhagavatula wrote: > > > >-Original Message- > >From: Shijith Thotton > >Sent: Friday, March 26, 2021 2:42 PM > >To: dev@dpdk.org > >Cc: Shijith Thotton ; tho...@monjalon.net; > >Jerin Jacob Kollanukkaran ; > >abhinandan.guj...@in

[dpdk-dev] Questions about reporting auto-negotiation capability

2021-03-28 Thread Huisong Li
Hi, all         'speed_capa' in struct rte_eth_dev_info is defined as follows: uint32_t speed_capa;  /**< Supported speeds bitmap (ETH_LINK_SPEED_). */       Most PMD drivers use this field to report the speeds capability supported by the device to the upper-layer app. But it seems that few

[dpdk-dev] [PATCH v4 6/6] net/txgbe: add FFE parameters for user debugging

2021-03-28 Thread Jiawen Wu
Support to set PHY link mode by user defined. And update release notes 21.05 for txgbe. Signed-off-by: Jiawen Wu --- doc/guides/nics/txgbe.rst | 21 ++ doc/guides/rel_notes/release_21_05.rst | 1 + drivers/net/txgbe/base/txgbe_hw.c | 11 +++ drivers/net/txgbe/base/txgbe_ph

[dpdk-dev] [PATCH v4 5/6] net/txgbe: handle AN interrupt and link update

2021-03-28 Thread Jiawen Wu
Read AN interrupt from misc, and do the AN configuration action. When link status is down, PHY power should be restarted to config KR mode again. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/base/txgbe_hw.c | 4 +- drivers/net/txgbe/base/txgbe_phy.c | 14 +++ drivers/net/txgbe/base/txg

[dpdk-dev] [PATCH v4 4/6] net/txgbe/base: support to handle backplane AN73 flow

2021-03-28 Thread Jiawen Wu
Suppot to handle the interrupt of auto-negotiation, improve the link training process of connecting with other switches. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/base/txgbe_hw.c | 3 + drivers/net/txgbe/base/txgbe_phy.c | 461 +++- drivers/net/txgbe/base/txgbe_

[dpdk-dev] [PATCH v4 3/6] net/txgbe: update link setup process of backplane NICs

2021-03-28 Thread Jiawen Wu
Add device arguments to support runtime options. And use these configuration to control the link setup flow, to adapt to different NIC's construction. Use firmware version to control the impact of firmware update. And fix some left bugs. Signed-off-by: Jiawen Wu --- doc/guides/nics/txgbe.rst

[dpdk-dev] [PATCH v4 2/6] net/txgbe: move firmware version get function to base code

2021-03-28 Thread Jiawen Wu
Move firmware version get function to base code, and store firmware version in PHY info. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/base/txgbe_dummy.h | 6 ++ drivers/net/txgbe/base/txgbe_hw.c| 4 drivers/net/txgbe/base/txgbe_phy.c | 12 drivers/net/txgbe/base/t

[dpdk-dev] [PATCH v4 1/6] net/txgbe: update device ID

2021-03-28 Thread Jiawen Wu
For more different devices, update device ID and subsystem id. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/base/txgbe_devids.h | 44 ++--- drivers/net/txgbe/base/txgbe_hw.c | 55 --- drivers/net/txgbe/base/txgbe_phy.c| 40 +++ dr

[dpdk-dev] [PATCH v4 0/6] txgbe backplane AN training

2021-03-28 Thread Jiawen Wu
This series update link process for backplane NICs. And support to control AN training. v4: - Convert BP_LOG to dynamic log. v3: - Add devargs gradually in the patches they are used. - Update 21.05 relaese notes. v2: - Convert compile time flags to runtime options - Move firmware version get opera

Re: [dpdk-dev] [PATCH v3] pflock: implementation of phase-fair reader writer locks

2021-03-28 Thread Honnappa Nagarahalli
> Subject: [PATCH v3] pflock: implementation of phase-fair reader writer locks > > This is a new type of reader-writer lock that provides better fairness > guarantees which makes it better for typical DPDK applications. > They lock internally uses two ticket pools, one for readers and one for

Re: [dpdk-dev] [PATCH 2/3] app/testpmd: remove forwarding config from parsing Rx and Tx

2021-03-28 Thread Li, Xiaoyun
> -Original Message- > From: oulijun > Sent: Thursday, March 25, 2021 11:04 > To: Li, Xiaoyun ; Yigit, Ferruh > Cc: dev@dpdk.org; linux...@openeuler.org > Subject: Re: [PATCH 2/3] app/testpmd: remove forwarding config from parsing > Rx and Tx > > > > 在 2021/3/24 9:44, Li, Xiaoyun 写道

Re: [dpdk-dev] [PATCH] vhost: fix accessing uninitialized variables

2021-03-28 Thread Liu, Yong
> -Original Message- > From: wangyunjian > Sent: Saturday, March 27, 2021 6:06 PM > To: Maxime Coquelin ; Liu, Yong > ; Xia, Chenbo > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: RE: [dpdk-dev] [PATCH] vhost: fix accessing uninitialized variables > > > -Original Message- > > Fr

[dpdk-dev] [PATCH v6] doc: add release milestones definition

2021-03-28 Thread Thomas Monjalon
From: Asaf Penso Adding more information about the release milestones. This includes the scope of change, expectations, etc. Signed-off-by: Asaf Penso Signed-off-by: Thomas Monjalon Acked-by: John McNamara --- v2: fix styling format and add content in the commit message v3: change punctuation

[dpdk-dev] [PATCH v5 9/9] net/mlx5: probe host PF representor with SubFunction

2021-03-28 Thread Xueming Li
To simplify BlueField HPF representor(vf[-1]) probe, this patch allows probe it with "sf" syntax: "sf[-1]". Signed-off-by: Xueming Li --- drivers/net/mlx5/linux/mlx5_os.c | 14 ++ drivers/net/mlx5/mlx5.h | 3 ++- drivers/net/mlx5/mlx5_ethdev.c | 25 +--

[dpdk-dev] [PATCH v5 8/9] net/mlx5: improve xstats of bonding port

2021-03-28 Thread Xueming Li
In case of kernel bonding device, counter was read from first bonding PF member. This patch reads all member PFs and sums to get bond xstats. Signed-off-by: Xueming Li Acked-by: Viacheslav Ovsiienko --- drivers/net/mlx5/linux/mlx5_ethdev_os.c | 127 +++- 1 file changed, 102

[dpdk-dev] [PATCH v5 7/9] net/mlx5: fix setting VF default MAC through representor

2021-03-28 Thread Xueming Li
With kernel bonding, there was an error when setting VF MAC address through representor. The Netlink api requires ifindex of owner PF, not bonding device ifindex. Uses owner PF ifindex to modify VF default MAC in case of bonding device. Fixes: c21e5facf7d2 ("net/mlx5: use bond index for netdev op

[dpdk-dev] [PATCH v5 6/9] net/mlx5: save bonding member ports information

2021-03-28 Thread Xueming Li
Since kernel bonding netdev doesn't provide statistics counter that reflects all member ports, PMD has to manually summarize counters from each member ports. As a preparation, this patch collects bonding member port information and saves to shared context data. Signed-off-by: Xueming Li Acked-by

[dpdk-dev] [PATCH v5 4/9] net/mlx5: refactor bonding representor probe

2021-03-28 Thread Xueming Li
To probe representor on 2nd PF of kernel bonding device, had to specify PF1 BDF in devarg: ,representor=0 When closing bonding device, all representors had to be closed together and this implies all representors have to use primary PF of bonding device. So after probing representor port on 2nd PF

[dpdk-dev] [PATCH v5 5/9] net/mlx5: support list value of representor PF

2021-03-28 Thread Xueming Li
To probe representors from different kernel bonding PFs, had to specify 2 separate devargs like this: -a 03:00.0,representor=pf0vf[0-3] -a 03:00.0,representor=pf1vf[0-3] This patch supports range or list of PF section in devargs, so the alternative short devargs of above is: -a 03:00.0,rep

[dpdk-dev] [PATCH v5 3/9] net/mlx5: revert setting bonding representor to first PF

2021-03-28 Thread Xueming Li
With kernel bonding, representors on second PF are being probed by devargs: ,representor=pf1vf No need to save primary PF port ID and lookup when probing sibling ports, revert patch [1] [1]: commit e6818853c022 ("net/mlx5: set representor to first PF in bonding mode") Signed-off-by: Xuemi

[dpdk-dev] [PATCH v5 2/9] net/mlx5: support representor of sub function

2021-03-28 Thread Xueming Li
This patch adds support for SF representor. Similar to VF representor, switch port name of SF representor in phys_port_name sysfs key is "pfsf". Device representor argument is "representors=sf[list]", list member could be mix of instance and range. Example: representors=sf[0,2,4,8-12,-1] To pro

[dpdk-dev] [PATCH v5 1/9] common/mlx5: sub-function representor port name parsing

2021-03-28 Thread Xueming Li
This patch supports representor name parsing for SF. In sysfs, representor name stored under "phys_port_name" sysfs key, similar to VF representor, switch port name of SF representor is "pfsf". For netlink message, net SF type is supported. Examples: pf0sf1 pf0sf[0-3] Signed-off-by: Xueming Li

[dpdk-dev] [PATCH v5 0/9] net/mlx5: support SubFunction representor

2021-03-28 Thread Xueming Li
SubFunction [1] is a portion of the PCI device, a SF netdev has its own dedicated queues(txq, rxq). A SF netdev supports E-Switch representation offload similar to existing PF and VF representors. A SF shares PCI level resources with other SFs and/or with its parent PCI function. This patch set in

Re: [dpdk-dev] [PATCH] net/mlx5: add Rx checksum offload flag return bad

2021-03-28 Thread Jiawei Zhu
Hi, Slava Thanks for your detailed explanation!You are right,I didn't look carefully! With best regards, Jiawei On 2021/3/25 7:55 下午, Slava Ovsiienko wrote: Hi, Jiawei -Original Message- From: Jiawei Zhu <17826875...@163.com> Sent: Wednesday, March 24, 2021 18:22 To: Slava Ovsiienk

Re: [dpdk-dev] [PATCH] eal: update all buses default scan mode

2021-03-28 Thread Xueming(Steven) Li
Thanks for comments, new version sent: http://patchwork.dpdk.org/project/dpdk/patch/20210328131222.16584-1-xuemi...@nvidia.com/ >-Original Message- >From: Kinsella, Ray >Sent: Tuesday, March 23, 2021 5:59 PM >To: Dmitry Kozlyuk >Cc: Xueming(Steven) Li ; dev@dpdk.org; Narcisa Ana Maria >

[dpdk-dev] [PATCH v1] eal: update all buses default scan mode

2021-03-28 Thread Xueming Li
When parsing EAL allowed or blocked device arguments, only device bus being parsed got default scan mode updated. If the devargs was vdev, PCI bus default scan mode not touched, all PCI bus devices will got probed even none appear in allowed list. This patch update all buses default scan mode when

Re: [dpdk-dev] [PATCH v2] net/mlx5: fix using flow tunnel before null check

2021-03-28 Thread Raslan Darawsheh
Hi, > -Original Message- > From: dev On Behalf Of wangyunjian > Sent: Saturday, March 27, 2021 5:44 AM > To: dev@dpdk.org > Cc: Matan Azrad ; Shahaf Shuler > ; Slava Ovsiienko ; > jerry.lili...@huawei.com; chenchan...@huawei.com; Yunjian Wang > ; sta...@dpdk.org > Subject: [dpdk-dev] [PATC

Re: [dpdk-dev] [PATCH 5/6] mempool/cnxk: add cn10k batch enqueue/dequeue support

2021-03-28 Thread Jerin Jacob
On Fri, Mar 5, 2021 at 11:44 PM Ashwin Sekhar T K wrote: > > Add support for asynchronous batch enqueue/dequeue > of pointers from NPA pool. Please spilt the enq and deq as separate patches. The rest looks good to me. > > Signed-off-by: Ashwin Sekhar T K > ---

Re: [dpdk-dev] [PATCH 4/6] mempool/cnxk: add base cn10k mempool ops

2021-03-28 Thread Jerin Jacob
On Fri, Mar 5, 2021 at 11:43 PM Ashwin Sekhar T K wrote: > > Add base cn10k mempool ops. Could you add more description about why cn10k_mempool_alloc() different from cn9k in git commit. > > Signed-off-by: Ashwin Sekhar T K > --- > drivers/mempool/cnxk/cn10k_mempool_ops.c | 46

Re: [dpdk-dev] [PATCH 2/6] mempool/cnxk: add generic ops

2021-03-28 Thread Jerin Jacob
On Fri, Mar 5, 2021 at 11:43 PM Ashwin Sekhar T K wrote: > > Add generic cnxk mempool ops. > > Signed-off-by: Ashwin Sekhar T K > --- > +int > +cnxk_mempool_alloc(struct rte_mempool *mp) > +{ > + uint64_t aura_handle = 0; > + struct npa_aura_s aura; > + struct npa_pool_s pool;

Re: [dpdk-dev] [PATCH 1/6] mempool/cnxk: add build infra and device probe

2021-03-28 Thread Jerin Jacob
On Fri, Mar 5, 2021 at 11:43 PM Ashwin Sekhar T K wrote: > > Add the meson based build infrastructure along > with mempool device probe. > > Signed-off-by: Ashwin Sekhar T K > --- > drivers/mempool/cnxk/cnxk_mempool.c | 212 > drivers/mempool/cnxk/cnxk_mempool.h | 1

Re: [dpdk-dev] [PATCH 6/6] doc: add Marvell CNXK mempool documentation

2021-03-28 Thread Jerin Jacob
On Fri, Mar 5, 2021 at 11:44 PM Ashwin Sekhar T K wrote: > > Add Marvell OCTEON CNXK mempool documentation. > > Signed-off-by: Jerin Jacob > Signed-off-by: Nithin Dabilpuram > Signed-off-by: Ashwin Sekhar T K > --- > MAINTAINERS | 6 +++ > doc/guides/mempool/cnxk.rst | 84 ++

Re: [dpdk-dev] [PATCH v8 4/8] eventdev: add Rx adapter event vector support

2021-03-28 Thread Jerin Jacob
On Fri, Mar 26, 2021 at 7:40 PM wrote: > > From: Pavan Nikhilesh > > Add event vector support for event eth Rx adapter, the implementation > creates vector flows based on port and queue identifier of the received > mbufs. > The flow id for SW Rx event vectorization will use 12-bits of queue > ide