Re: [dpdk-dev] [PATCH v2 1/3] build: enable iavf base code to build on windows

2021-03-27 Thread Kadam, Pallavi
On 3/26/2021 4:41 AM, Ferruh Yigit wrote: On 3/11/2021 1:58 AM, Pallavi Kadam wrote: Enable IAVF driver to build on Windows as it is required to build ice PMD. Disable all other drivers from common directory. This patch also includes fix for a macro redefinition warning in the IAVF driver. Si

Re: [dpdk-dev] [PATCH v2 2/3] net/ice: build on Windows

2021-03-27 Thread Kadam, Pallavi
On 3/26/2021 4:58 AM, Ferruh Yigit wrote: On 3/11/2021 1:58 AM, Pallavi Kadam wrote: - Add Intel ice PMD support on Windows. - Remove #include sys/ioctl header file as it is not needed. - Replace x86intrin.h with rte_vect.h to avoid __m_prefetchw conflicting types. - Replace POSIX usleep() API

Re: [dpdk-dev] [PATCH v2 3/3] net/ice: disable ice DDP package on Windows

2021-03-27 Thread Kadam, Pallavi
On 3/26/2021 4:53 AM, Ferruh Yigit wrote: On 3/11/2021 1:58 AM, Pallavi Kadam wrote: Disable loading of external DDP package as it is not supported on Windows. Should this be documented in driver documentation as Windows support limitation? We have mentioned about it in Windows prerequis

Re: [dpdk-dev] [PATCH v2 2/3] net/ice: build on Windows

2021-03-27 Thread Kadam, Pallavi
On 3/26/2021 4:51 AM, Ferruh Yigit wrote: On 3/11/2021 1:58 AM, Pallavi Kadam wrote: - Add Intel ice PMD support on Windows. - Remove #include sys/ioctl header file as it is not needed. - Replace x86intrin.h with rte_vect.h to avoid __m_prefetchw conflicting types. - Replace POSIX usleep() API

Re: [dpdk-dev] [dpdk-stable] [PATCH] rte_ring: fix racy dequeue/enqueue in ppc64

2021-03-27 Thread Honnappa Nagarahalli
> Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] rte_ring: fix racy > dequeue/enqueue in ppc64 > > No reply after more than 2 years. > Unfortunately it is probably outdated now. > Classified as "Changes Requested". Looking at the code, I think this patch in fact fixes a bug. Appreciate rebasing

Re: [dpdk-dev] [PATCH] eal: changes for setting control thread mask

2021-03-27 Thread Kiran KN
Hi David, This task was supposed to be taken up by someone else in my organisation. Will check and update. Thanks On 25/03/21, 8:21 PM, "David Marchand" wrote: [External Email. Be cautious of content] On Tue, Apr 21, 2020 at 10:01 AM David Marchand wrote: > > On Tue, Ap

Re: [dpdk-dev] [PATCH v4 09/10] eal: add EAL argument for setting thread priority

2021-03-27 Thread Stephen Hemminger
On Fri, 26 Mar 2021 16:52:50 -0700 Narcisa Ana Maria Vasile wrote: > From: Narcisa Vasile > > Allow the user to choose the thread priority through an EAL > command line argument. > > The user can select the thread priority to be either 'normal' > or 'critical': > --thread-prio normal > --threa

Re: [dpdk-dev] [PATCH v1] net/octeontx2: support flow action port id

2021-03-27 Thread Jerin Jacob
On Fri, Mar 26, 2021 at 3:18 PM wrote: > > From: Smadar Fuks > > Action port_id was not supported until now. > In this patch the action port_id supports passing from input > port PF to output port which is one of input port respective VF > > Signed-off-by: Smadar Fuks Acked-by: Jerin Jacob App

Re: [dpdk-dev] [PATCH v2 0/7] Optimize qede use of Rx/Tx entries

2021-03-27 Thread Jerin Jacob
On Fri, Mar 26, 2021 at 4:32 PM Balazs Nemeth wrote: > > This patch set optimizes qede_{rx,tx}_entry and introduces > rte_pktmbuf_free_bulk in qede_process_tx_compl. The overall performance > improvement depends on the use-case; in a physical-virtual-physical test > on a ThunderX2 99xx system with

Re: [dpdk-dev] [PATCH 2/2] [RFC]: ethdev: manage meter API object handles by the drivers

2021-03-27 Thread Jerin Jacob
On Thu, Mar 25, 2021 at 1:51 PM Matan Azrad wrote: > > Hi Cristian > > From: Dumitrescu, Cristian > > Hi Li and Matan, > > > > > -Original Message- > > > From: Li Zhang > > > Sent: Thursday, March 18, 2021 8:58 AM > > > To: dek...@nvidia.com; or...@nvidia.com; viachesl...@nvidia.com; > >

Re: [dpdk-dev] [PATCH v8 7/8] doc: announce event Rx adapter config changes

2021-03-27 Thread Jayatheerthan, Jay
> -Original Message- > From: Jerin Jacob > Sent: Friday, March 26, 2021 8:13 PM > To: Pavan Nikhilesh > Cc: Jerin Jacob ; Jayatheerthan, Jay > ; Carrillo, Erik G ; > Gujjar, Abhinandan S ; McDaniel, Timothy > ; Hemant Agrawal > ; Van Haaren, Harry ; > mattias.ronnblom > ; Ma, Liang J ;

Re: [dpdk-dev] [PATCH v8 1/8] eventdev: introduce event vector capability

2021-03-27 Thread Jayatheerthan, Jay
> -Original Message- > From: pbhagavat...@marvell.com > Sent: Friday, March 26, 2021 7:39 PM > To: jer...@marvell.com; Jayatheerthan, Jay ; > Carrillo, Erik G ; Gujjar, > Abhinandan S ; McDaniel, Timothy > ; hemant.agra...@nxp.com; Van > Haaren, Harry ; mattias.ronnblom > ; Ma, Liang J

Re: [dpdk-dev] [PATCH] vhost: fix accessing uninitialized variables

2021-03-27 Thread wangyunjian
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Maxime Coquelin > Sent: Wednesday, March 24, 2021 5:55 PM > To: Marvin Liu ; chenbo@intel.com > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] vhost: fix accessing uninitialized variables >

[dpdk-dev] [PATCH 0/3] fix check of port and core

2021-03-27 Thread Min Hu (Connor)
Currently, some examples check that the port is on the same NUMA node as the polling thread for best performance. The method is to compare the socket id of port and that of current core. If the result is different, warning info will be given. But it ignores the port which is from numa node 0, that

[dpdk-dev] [PATCH 1/3] examples/flow_classify: fix check of port and core

2021-03-27 Thread Min Hu (Connor)
fix check of port and core in flow_classify example. Fixes: bab16ddaf2c1 ("examples/flow_classify: add sample application") Cc: sta...@dpdk.org Signed-off-by: Min Hu (Connor) --- examples/flow_classify/flow_classify.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/examples/

[dpdk-dev] [PATCH 3/3] examples/skeleton: fix check of port and core

2021-03-27 Thread Min Hu (Connor)
fix check of port and core in skeleton example. Fixes: 7107e471a6c7 ("examples/skeleton: very simple code for packet forwarding") Cc: sta...@dpdk.org Signed-off-by: Min Hu (Connor) --- examples/skeleton/basicfwd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/examples/ske

[dpdk-dev] [PATCH 2/3] examples/l2fwd-cat: fix check of port and core

2021-03-27 Thread Min Hu (Connor)
fix check of port and core in l2fwd-cat example. Fixes: f6baccbc2b3b ("examples/l2fwd-cat: add sample application for PQoS CAT and CDP") Cc: sta...@dpdk.org Signed-off-by: Min Hu (Connor) --- examples/l2fwd-cat/l2fwd-cat.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/exa

[dpdk-dev] [PATCH 1/3] ethdev: fix miss input validation in module EEPROM dump API

2021-03-27 Thread Min Hu (Connor)
From: Chengchang Tang The validity verification of input parameters should be performed at API layer, not in the PMD. Fixes: 3a18c44b45df ("ethdev: add access to EEPROM") Fixes: 40ff8b305ab8 ("net/e1000: add module EEPROM callbacks for e1000") Fixes: f2088e785cca ("net/i40e: fix dereference befo

[dpdk-dev] [PATCH 0/3] fix miss input validation

2021-03-27 Thread Min Hu (Connor)
The validity verification of input parameters should be performed at API layer, not in the PMD. This set of patches fix miss input validation. Chengchang Tang (3): ethdev: fix miss input validation in module EEPROM dump API ethdev: fix miss input validation when access reg info ethdev: fix

[dpdk-dev] [PATCH 3/3] ethdev: fix miss input validation when access EEPROM info

2021-03-27 Thread Min Hu (Connor)
From: Chengchang Tang This patch adds validity check of input pointer in EEPROM dump API. Fixes: 7a3f27cbf59b ("ethdev: add access to specific device info") Cc: sta...@dpdk.org Signed-off-by: Chengchang Tang Signed-off-by: Min Hu (Connor) --- lib/librte_ethdev/rte_ethdev.c | 4 lib/libr

[dpdk-dev] [PATCH 2/3] ethdev: fix miss input validation when access reg info

2021-03-27 Thread Min Hu (Connor)
From: Chengchang Tang This patch adds validity check of input pointer in regs dump API. Fixes: 7a3f27cbf59b ("ethdev: add access to specific device info") Fixes: 936eda25e8da ("net/hns3: support dump register") Cc: sta...@dpdk.org Signed-off-by: Chengchang Tang Signed-off-by: Min Hu (Connor)

[dpdk-dev] [PATCH] examples/ptpclient: delete wrong comments

2021-03-27 Thread Min Hu (Connor)
This patch deletes the comments which are wrong and unnecessary. Fixes: ab129e9065a5 ("examples/ptpclient: add minimal PTP client") Cc: sta...@dpdk.org Signed-off-by: Min Hu (Connor) --- examples/ptpclient/ptpclient.c | 4 1 file changed, 4 deletions(-) diff --git a/examples/ptpclient/ptp

[dpdk-dev] [PATCH] app/testpmd: fix Tx/Rx descriptor query error log

2021-03-27 Thread Min Hu (Connor)
From: Hongbo Zheng Currently in testpmd, if we input "show port 0 rxq 0 desc status" and if rte_eth_rx_descriptor_status return a negative value, testpmd will print "Invalid queueid = 0", seems user input an invalid queueid, while the actual situation may be that is out of bounds, curre