[dpdk-dev] [PATCH V3 04/14] net/hns3: add Rx and Tx bytes stats

2021-03-03 Thread Lijun Ou
From: "Min Hu (Connor)" In current HNS3 PMD, Rx/Tx bytes from packet stats are not implemented. This patch implemented Rx/Tx bytes using soft counters. Signed-off-by: Min Hu (Connor) Signed-off-by: Lijun Ou --- V2->V3: - remote the macro RTE_LIBRTE_HNS3_PMD_SOFT_COUNTER - update the commit lo

[dpdk-dev] [PATCH V3 12/14] net/hns3: fix memory leakage for mbuf

2021-03-03 Thread Lijun Ou
From: Huisong Li The mbufs of rx queue will be allocated in "hns3_do_start" function. But these mbufs are not released when "hns3_dev_start" executes failed. Fixes: c4ae39b2cfc5 ("net/hns3: fix Rx interrupt after reset") Cc: sta...@dpdk.org Signed-off-by: Huisong Li Signed-off-by: Lijun Ou --

[dpdk-dev] [PATCH V3 09/14] net/hns3: support RXD advanced layout

2021-03-03 Thread Lijun Ou
From: Chengwen Feng Currently, the driver get packet type by parse the L3_ID/L4_ID/OL3_ID/OL4_ID from Rx descriptor and then lookup multiple tables, it's time consuming. Now Kunpeng930 support advanced RXD layout, which: 1. Combine OL3_ID/OL4_ID to 8bit PTYPE filed, so the driver get packet type

[dpdk-dev] [PATCH V3 08/14] net/hns3: support PF device with copper phys

2021-03-03 Thread Lijun Ou
From: Huisong Li The normal operation of devices with copper phys depends on the initialization and configuration of the PHY chip. The task of driving the PHY chip is implemented in some firmware versions. If firmware supports the phy driver, it will report a capability flag to driver in probing

[dpdk-dev] [PATCH V3 05/14] net/hns3: add imissed packet stats

2021-03-03 Thread Lijun Ou
From: "Min Hu (Connor)" This patch implement Rx imissed stats by querying cmdq. Signed-off-by: Min Hu (Connor) Signed-off-by: Lijun Ou --- drivers/net/hns3/hns3_cmd.h| 7 +++ drivers/net/hns3/hns3_ethdev.c | 7 +++ drivers/net/hns3/hns3_ethdev.h | 1 + drivers/net/hns3/hns3_stats.c

[dpdk-dev] [PATCH V3 06/14] net/hns3: encapsulate a port shaping interface

2021-03-03 Thread Lijun Ou
From: Huisong Li When rate of port changes, the rate limit of the port needs to be updated. So it is necessary to encapsulate an interface that configures the rate limit based on the rate. Signed-off-by: Huisong Li Signed-off-by: Lijun Ou --- drivers/net/hns3/hns3_dcb.c| 22 ++

[dpdk-dev] [PATCH V3 02/14] net/hns3: add more registers to dump

2021-03-03 Thread Lijun Ou
From: Chengchang Tang This patch makes more registers dumped in the dump_reg API to help loacte the fault. Signed-off-by: Chengchang Tang Signed-off-by: Lijun Ou --- drivers/net/hns3/hns3_cmd.h | 13 drivers/net/hns3/hns3_regs.c | 171 ++- 2 file

[dpdk-dev] [PATCH V3 03/14] net/hns3: implement Tx mbuf free on demand

2021-03-03 Thread Lijun Ou
From: Chengwen Feng This patch add support tx_done_cleanup ops, which could support for the API rte_eth_tx_done_cleanup to free consumed mbufs on Tx ring. Signed-off-by: Chengwen Feng Signed-off-by: Lijun Ou --- V2->V3: - rewrite the patch title according to Ferruh Yigit's advice --- doc/guid

[dpdk-dev] [PATCH V3 07/14] net/hns3: fix device capabilities for copper media type

2021-03-03 Thread Lijun Ou
From: Huisong Li The configuration operation for PHY is implemented by firmware. And a capability flag will be report to driver, which means the firmware supports the PHY driver. However, the current implementation only supports obtaining the capability bit, but some basic functions of copper po

[dpdk-dev] [PATCH V3 01/14] net/hns3: support module EEPROM dump

2021-03-03 Thread Lijun Ou
From: Chengchang Tang This patch add support for dumping module EEPROM. Signed-off-by: Chengchang Tang Signed-off-by: Lijun Ou --- V2->V3: - add "Module EEPROM dump" feature to hns3.ini and hns3_vf.ini - fix the release notes location with Hisilicon hns3 --- doc/guides/nics/features/hns3.ini

[dpdk-dev] [PATCH V3 14/14] net/hns3: fix imprecise statistics

2021-03-03 Thread Lijun Ou
From: Chengchang Tang Currently, the hns3 statistics may be inaccurate due to the following two problems: 1. Queue-level statistics are read from the firmware, and only one Rx or Tx can be read at a time. This results in a large time interval between reading multiple queues statistics in a stres

[dpdk-dev] [PATCH V3 13/14] net/hns3: add process for MAC interrupt

2021-03-03 Thread Lijun Ou
From: Hongbo Zheng TNL is the abbreviation of tunnel, which means port here. MAC TNL interrupt indicates the MAC status report of the network port, which will be generated when the MAC status changes. This patch enables MAC TNL interrupt reporting, and queries and prints the corresponding MAC st

[dpdk-dev] [PATCH V3 11/14] net/hns3: remove unused parameter from func declaration

2021-03-03 Thread Lijun Ou
From: Huisong Li All input parameters in the "hns3_dev_xstats_get_by_id" API are used, so the rte_unused flag of some variables should be deleted. Fixes: 3213d584b698 ("net/hns3: fix xstats with id and names") Cc: sta...@dpdk.org Signed-off-by: Huisong Li Signed-off-by: Lijun Ou --- drivers/

[dpdk-dev] [PATCH V3 10/14] net/hns3: fix HW buffer size on MTU update

2021-03-03 Thread Lijun Ou
From: Chengchang Tang After MTU changed, the buffer used to store packets in HW should be reallocated. And buffer size is allocated based on the maximum frame size in the PF struct. However, the value of maximum frame size is not updated in time when MTU is changed. This would lead to a packet l

[dpdk-dev] [PATCH V3 00/14] Features and bugfixes for hns3

2021-03-03 Thread Lijun Ou
This series add three features according to the 21.05 roadmap as well as fix some bugs. v2->v3: - fix some patchs title. - delete the macro with patch[4/14]. v1->v2: - fix the commit log for patch[8/14]. - add more commit log information for patch[13/14]. - add a fix patch[7/14] because the versi

Re: [dpdk-dev] [PATCH v4] bus/pci/windows: support for PCI scan allowed and blocked lists

2021-03-03 Thread Dmitry Kozlyuk
2021-02-28 22:52, Khoa To: > EAL -a and -b options are used to specify which PCI devices are > explicitly allowed or blocked during PCI bus scan. This evaluation > is missing in the Windows implementation of rte_pci_scan. > > This patch provides this missing functionality, so that apps can specif

Re: [dpdk-dev] [PATCH] doc: announce renaming of rte_ether_hdr fields

2021-03-03 Thread Dmitry Kozlyuk
2021-03-03 15:54, Stephen Hemminger: > > + > > +* net: ``s_addr`` and ``d_addr`` fields of ``rte_ether_hdr`` structure > > + will be renamed to ``src_addr`` and ``dst_addr`` respectively in DPDK > > 20.11 > > + in order to avoid conflict with Windows Sockets headers. > > If those fields were

Re: [dpdk-dev] [PATCH v8 2/3] ethdev: tunnel offload model

2021-03-03 Thread Eli Britstein
On 3/3/2021 4:03 PM, Ivan Malov wrote: Hi, Could someone please also clarify the meaning (from PMD standpoint and from application's standpoint) of the 64-bit field "tun_id" in "rte_flow_tunnel"? The current comment reads: "Tunnel identification", which is quite ambiguous, not to mention th

Re: [dpdk-dev] [RFC v4 1/4] ethdev: add meter PPS profile

2021-03-03 Thread Matan Azrad
Hi Cristian From: Dumitrescu, Cristian > Hi Matan, > > > -Original Message- > > From: Matan Azrad > > Sent: Tuesday, March 2, 2021 6:10 PM > > To: Dumitrescu, Cristian ; Li Zhang > > ; Dekel Peled ; Ori Kam > > ; Slava Ovsiienko > > Cc: dev@dpdk.org; NBU-Contact-Thomas Monjalon ; > > Ra

Re: [dpdk-dev] [PATCH 00/14] ice: base code update

2021-03-03 Thread Yang, Qiming
Hi, > -Original Message- > From: Zhang, Qi Z > Sent: 2021年3月2日 15:24 > To: Yang, Qiming > Cc: dev@dpdk.org; Wang, Haiyue ; Guo, Junfeng > ; Zhang, Qi Z > Subject: [PATCH 00/14] ice: base code update > > Main change: > 1. Support GTPU inner l3/l4 for FDIR > 2. Support GTPU extention hea

Re: [dpdk-dev] [PATCH v2] net/ice: fix wrong RSS hash update

2021-03-03 Thread Yang, Qiming
Acked-by: Qiming Yang > -Original Message- > From: Wu, Wenjun1 > Sent: 2021年3月3日 15:57 > To: dev@dpdk.org; Yang, Qiming ; Zhang, Qi Z > > Cc: Wu, Wenjun1 ; sta...@dpdk.org > Subject: [PATCH v2] net/ice: fix wrong RSS hash update > > This patch change redundant judgment statements to di

Re: [dpdk-dev] [Linuxarm] Re: [PATCH V2 04/14] net/hns3: add Rx and Tx bytes stats

2021-03-03 Thread oulijun
在 2021/3/3 22:24, Ferruh Yigit 写道: On 3/3/2021 2:08 PM, oulijun wrote: 在 2021/3/3 21:28, Ferruh Yigit 写道: On 3/2/2021 1:58 PM, Lijun Ou wrote: From: "Min Hu (Connor)" In current HNS3 PMD, Rx/Tx bytes from packet stats are not implemented. This patch implemented Rx/Tx bytes using soft c

Re: [dpdk-dev] [PATCH 00/11] bnxt fixes

2021-03-03 Thread Ajit Khaparde
On Wed, Feb 24, 2021 at 7:33 AM Kalesh A P wrote: > From: Kalesh AP > > This patchset contain bnxt bug fixes and enhancements. > > Please apply. > > Ajit Khaparde (1): > net/bnxt: update to new version of backing store > > Kalesh AP (9): > net/bnxt: remove unused macro > net/bnxt: fix vnic

Re: [dpdk-dev] [PATCH v4] bus/pci/windows: support for PCI scan allowed and blocked lists

2021-03-03 Thread Khoa To
On Wed, 3 Mar 2021, Ranjit Menon wrote: On 2/28/2021 10:52 PM, Khoa To wrote: EAL -a and -b options are used to specify which PCI devices are explicitly allowed or blocked during PCI bus scan. This evaluation is missing in the Windows implementation of rte_pci_scan. This patch provides

Re: [dpdk-dev] [PATCH v4] bus/pci/windows: support for PCI scan allowed and blocked lists

2021-03-03 Thread Ranjit Menon
On 2/28/2021 10:52 PM, Khoa To wrote: EAL -a and -b options are used to specify which PCI devices are explicitly allowed or blocked during PCI bus scan. This evaluation is missing in the Windows implementation of rte_pci_scan. This patch provides this missing functionality, so that apps can spe

Re: [dpdk-dev] [PATCH] doc: announce renaming of rte_ether_hdr fields

2021-03-03 Thread Stephen Hemminger
> + > +* net: ``s_addr`` and ``d_addr`` fields of ``rte_ether_hdr`` structure > + will be renamed to ``src_addr`` and ``dst_addr`` respectively in DPDK 20.11 > + in order to avoid conflict with Windows Sockets headers. If those fields were a problem now, there might be others in future. Don't

Re: [dpdk-dev] [PATCH 4/4] doc: update ice PMD and 21.05 release notes

2021-03-03 Thread Dmitry Kozlyuk
2021-03-03 13:59, Pallavi Kadam: > Add documentation to support ice PMD on Windows. > Update the release notes and features list for the same. > > Signed-off-by: Pallavi Kadam > Reviewed-by: Ranjit Menon > --- > doc/guides/nics/features/ice.ini | 1 + > doc/guides/nics/ice.rst

Re: [dpdk-dev] [PATCH 3/4] net/ice: disable ice DDP package on Windows

2021-03-03 Thread Dmitry Kozlyuk
2021-03-03 13:59, Pallavi Kadam: > Disable loading of private DDP packages in ice PMD on Windows. > > Signed-off-by: Pallavi Kadam > Reviewed-by: Ranjit Menon > --- > drivers/net/ice/ice_ethdev.c | 6 ++ > 1 file changed, 6 insertions(+) Are DDP packages unavailable on Windows or is their

Re: [dpdk-dev] [PATCH v2 4/6] net/pcap: add libpcap wrappers

2021-03-03 Thread Dmitry Kozlyuk
2021-03-03 19:30, Ferruh Yigit: > On 3/3/2021 6:19 PM, Dmitry Kozlyuk wrote: > > 2021-03-03 16:47, Ferruh Yigit: > >> On 3/3/2021 4:32 PM, Dmitry Kozlyuk wrote: [...] > > +#pragma push_macro("s_addr") > > +#ifdef s_addr > > +#undef s_addr > > +#endif > > I guess this needs to be as following

[dpdk-dev] [PATCH] doc: announce renaming of rte_ether_hdr fields

2021-03-03 Thread Dmitry Kozlyuk
It is proposed to rename fields of `struct rte_ether_hdr`, `s_addr` tp `src_addr` and `d_addr` to `dst_addr`, due to the clash with system macro on Windows. Until remaining is done in 21.11, a workaround can be used. Windows Sockets headers contain `#define s_addr S_un.S_addr`, which conflicts wit

[dpdk-dev] [PATCH] ethdev: add Field ID doxygen description

2021-03-03 Thread Alexander Kozyrev
Field IDs for the MODIFY_FIELD action lack doxygen comments and not visible in online DPDK documentation because of that. Provide a meaningful description for every Field ID for the rte_flow_field_id enumeration. Fixes: 73b68f4c54 ("ethdev: introduce generic modify flow action") Cc: sta...@dpdk.or

[dpdk-dev] [PATCH 4/4] doc: update ice PMD and 21.05 release notes

2021-03-03 Thread Pallavi Kadam
Add documentation to support ice PMD on Windows. Update the release notes and features list for the same. Signed-off-by: Pallavi Kadam Reviewed-by: Ranjit Menon --- doc/guides/nics/features/ice.ini | 1 + doc/guides/nics/ice.rst| 16 ++-- doc/guides/rel_notes/

[dpdk-dev] [PATCH 3/4] net/ice: disable ice DDP package on Windows

2021-03-03 Thread Pallavi Kadam
Disable loading of private DDP packages in ice PMD on Windows. Signed-off-by: Pallavi Kadam Reviewed-by: Ranjit Menon --- drivers/net/ice/ice_ethdev.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c index d22bc92ff..1f5f16d42

[dpdk-dev] [PATCH 2/4] net/ice: build on Windows

2021-03-03 Thread Pallavi Kadam
Add Intel ice PMD support on Windows. Remove #include sys/ioctl header file as it is not needed. Replace x86intrin.h with rte_vect.h to avoid __m_prefetchw conflicting types. Replace POSIX usleep() API with rte API. Add a new macro for the access() API as the original function has been deprecated o

[dpdk-dev] [PATCH 1/4] build: enable iavf driver on Windows

2021-03-03 Thread Pallavi Kadam
Enable IAVF driver to build on Windows as it is required to build ice PMD. Disable all other drivers from common directory. This patch also includes fix for a macro redefinition warning in the IAVF driver. Signed-off-by: Pallavi Kadam Reviewed-by: Ranjit Menon --- drivers/common/cpt/meson.build

[dpdk-dev] [PATCH 0/4] Support ice PMD on Windows

2021-03-03 Thread Pallavi Kadam
This patch-set enables building the Intel ice PMD on Windows. Depends-on: series-15230 ("bus/pci: fix probing for non-netuio bound devices") Pallavi Kadam (4): build: enable iavf driver on Windows net/ice: build on Windows net/ice: disable ice DDP package on Windows doc: update ice PMD an

Re: [dpdk-dev] [RFC v4 1/4] ethdev: add meter PPS profile

2021-03-03 Thread Dumitrescu, Cristian
Hi Matan, > -Original Message- > From: Matan Azrad > Sent: Tuesday, March 2, 2021 6:10 PM > To: Dumitrescu, Cristian ; Li Zhang > ; Dekel Peled ; Ori Kam > ; Slava Ovsiienko > Cc: dev@dpdk.org; NBU-Contact-Thomas Monjalon > ; Raslan Darawsheh ; > m...@smartsharesystems.com; ajit.khapa...

Re: [dpdk-dev] [PATCH v1] bbdev: adding explicit enum for code block mode

2021-03-03 Thread Tom Rix
On 2/19/21 4:15 PM, Nicolas Chautru wrote: > Using explicit enum instead of ambiguous integer value > > Signed-off-by: Nicolas Chautru > --- > app/test-bbdev/test_bbdev_perf.c | 16 - > app/test-bbdev/test_bbdev_vector.c | 16 - > drivers/baseba

Re: [dpdk-dev] [PATCH v2 4/6] net/pcap: add libpcap wrappers

2021-03-03 Thread Ferruh Yigit
On 3/3/2021 6:19 PM, Dmitry Kozlyuk wrote: 2021-03-03 16:47, Ferruh Yigit: On 3/3/2021 4:32 PM, Dmitry Kozlyuk wrote: [...] If we can't help including / from public headers, might as well use `struct in_addr`, just replace `#include ` with `#include ` everywhere. The only remaining issue will

[dpdk-dev] [PATCH v3] pflock: implementation of phase-fair reader writer locks

2021-03-03 Thread Stephen Hemminger
This is a new type of reader-writer lock that provides better fairness guarantees which makes it better for typical DPDK applications. They lock internally uses two ticket pools, one for readers and one for writers. Phase fair reader writer locks ensure that neither reader or writer will be starve

[dpdk-dev] [PATCH v10 2/2] bus/pci: support MMIO in PCI ioport accessors

2021-03-03 Thread 谢华伟(此时此刻)
From: "huawei.xhw" With I/O BAR, we get PIO(port-mapped I/O) address. With MMIO(memory-mapped I/O) BAR, we get mapped virtual address. We distinguish PIO and MMIO by their address range like how kernel does, i.e, address below 64K is PIO.. ioread/write8/16/32 is provided to access PIO/MMIO. By th

[dpdk-dev] [PATCH v10 1/2] bus/pci: use PCI standard sysfs entry to get PIO address

2021-03-03 Thread 谢华伟(此时此刻)
From: "huawei.xhw" Currently virtio PMD asssumes legacy device uses PIO bar. There are three ways to get PIO(PortIO) address for virtio legacy device. under igb_uio, get pio address from uio/uio# sysfs attribute under uio_pci_generic: for X86, get PIO address from /proc/ioport

[dpdk-dev] [PATCH v10 0/2] support both PIO and MMIO BAR for legacy virito device

2021-03-03 Thread 谢华伟(此时此刻)
virtio PMD assumes legacy device only supports PIO(port-mapped) BAR resource. This is wrong. As we need to create lots of devices, as PIO resource on x86 is very limited, we expose MMIO(memory-mapped I/O) BAR. Kernel supports both PIO and MMIO BAR for legacy virtio-pci device, and for all other p

[dpdk-dev] [PATCH v2] pflock: implementation of phase-fair reader writer locks

2021-03-03 Thread Stephen Hemminger
This is a new type of reader-writer lock that provides better fairness guarantees which makes it better for typical DPDK applications. They lock internally uses two ticket pools, one for readers and one for writers. Phase fair reader writer locks ensure that neither reader or writer will be starve

[dpdk-dev] [PATCH] doc: update minimum supported kernel

2021-03-03 Thread Stephen Hemminger
The DPDK project is only committed to supporting upstream kernel versions that are still in support. The 3.16 kernel has reached End Of Life (in June 2020). The next LTS kernel is 4.19 and is supported until December 2024. This does not change the existing policy that distribution kernels that are

Re: [dpdk-dev] [PATCH v9 0/2] support both PIO and MMIO BAR for legacy device in virtio PMD

2021-03-03 Thread Stephen Hemminger
On Thu, 04 Mar 2021 01:46:50 +0800 "谢华伟(此时此刻)" wrote: > virtio PMD assumes legacy device only supports PIO BAR resource. This is > wrong. > As we need to create lots of devices, as PIO resource on x86 is very limited, > we expose MMIO(memory IO) BAR. > > Kernel supports both PIO and MMIO BAR f

Re: [dpdk-dev] [PATCH v2 4/6] net/pcap: add libpcap wrappers

2021-03-03 Thread Dmitry Kozlyuk
2021-03-03 16:47, Ferruh Yigit: > On 3/3/2021 4:32 PM, Dmitry Kozlyuk wrote: [...] > > If we can't help including / from public headers, > > might as well use `struct in_addr`, just replace `#include ` > > with `#include ` everywhere. > > > > The only remaining issue will be `s_addr` macro on Wind

[dpdk-dev] [PATCH v9 2/2] bus/pci: support MMIO in PCI ioport accessors

2021-03-03 Thread 谢华伟(此时此刻)
From: "huawei.xhw" With IO BAR, we get PIO(programmed IO) address. With MMIO BAR, we get mapped virtual address. We distinguish PIO(Programmed IO) and MMIO(memory mapped IO) by their address like how kernel does. ioread/write8/16/32 is provided to access PIO/MMIO. By the way, for virtio on arch

[dpdk-dev] [PATCH v9 1/2] bus/pci: use PCI standard sysfs entry to get PIO address

2021-03-03 Thread 谢华伟(此时此刻)
From: "huawei.xhw" Currently virtio PMD asssumes legacy device uses PIO bar. There are three ways to get PIO(PortIO) address for virtio legacy device. under igb_uio, get pio address from uio/uio# sysfs attribute under uio_pci_generic: for X86, get PIO address from /proc/ioport

[dpdk-dev] [PATCH v9 0/2] support both PIO and MMIO BAR for legacy device in virtio PMD

2021-03-03 Thread 谢华伟(此时此刻)
virtio PMD assumes legacy device only supports PIO BAR resource. This is wrong. As we need to create lots of devices, as PIO resource on x86 is very limited, we expose MMIO(memory IO) BAR. Kernel supports both PIO and MMIO BAR for legacy virtio-pci device, and for all other pci devices. This pa

Re: [dpdk-dev] [PATCH v2 4/6] net/pcap: add libpcap wrappers

2021-03-03 Thread Ferruh Yigit
On 3/3/2021 4:32 PM, Dmitry Kozlyuk wrote: 2021-03-02 11:22, Nick Connolly: Is posix_memalign() used more extensively in SPDK? In DPDK, it's 2 PMDs: Yes, there are about 80 references. A lot are in ISA-L where they are #defined to _aligned_malloc and can be ignored, but there still several in t

Re: [dpdk-dev] [PATCH v2 4/6] net/pcap: add libpcap wrappers

2021-03-03 Thread Dmitry Kozlyuk
2021-03-02 11:22, Nick Connolly: > > Is posix_memalign() used more extensively in SPDK? In DPDK, it's 2 PMDs: > Yes, there are about 80 references. A lot are in ISA-L where they are > #defined to _aligned_malloc and can be ignored, but there still several > in the rest of the code. I think por

Re: [dpdk-dev] [PATCH 0/4] net/mlx5: fix imissed statistic

2021-03-03 Thread Raslan Darawsheh
Hi, > -Original Message- > From: dev On Behalf Of Matan Azrad > Sent: Thursday, February 25, 2021 12:45 PM > To: dev@dpdk.org > Cc: Slava Ovsiienko > Subject: [dpdk-dev] [PATCH 0/4] net/mlx5: fix imissed statistic > > The imissed port statistic counts packets that were dropped > by the

Re: [dpdk-dev] [PATCH 1/3] net/af_xdp: Increase max batch size to 512

2021-03-03 Thread Ferruh Yigit
On 3/3/2021 3:07 PM, Loftus, Ciara wrote: On 2/24/2021 11:18 AM, Ciara Loftus wrote: Prior to this the max size was 32 which was unnecessarily small. Can you please describe the impact? Why changed from 32 to 512? I assume this is to improve the performance but can you please explicitly docum

Re: [dpdk-dev] [PATCH 1/3] net/af_xdp: Increase max batch size to 512

2021-03-03 Thread Loftus, Ciara
> > On 2/24/2021 11:18 AM, Ciara Loftus wrote: > > Prior to this the max size was 32 which was unnecessarily > > small. > > Can you please describe the impact? Why changed from 32 to 512? > I assume this is to improve the performance but can you please explicitly > document it in the commit log?

Re: [dpdk-dev] [PATCH] fbarray: fix uninitialized variable usage

2021-03-03 Thread Andrew Boyer
> On Mar 3, 2021, at 3:17 AM, David Marchand wrote: > > On Fri, Feb 19, 2021 at 6:55 PM Anatoly Burakov > wrote: >> >> When file truncation fails, the log message attempts to print a path of >> file we failed to truncate, but this path was never set to anything and, >> what's worse, was unin

Re: [dpdk-dev] [PATCH] net/pcap: fix fd leak on uninit

2021-03-03 Thread Ferruh Yigit
On 3/2/2021 4:51 PM, Tengfei Zhang wrote: pcap fd was opend when vdev probed, but not closed when vdev removed. Fixes: c956caa6eabf ("pcap: support port hotplug") Cc: sta...@dpdk.org Signed-off-by: Tengfei Zhang Acked-by: Ferruh Yigit Applied to dpdk-next-net/main, thanks.

Re: [dpdk-dev] [Linuxarm] Re: [PATCH V2 04/14] net/hns3: add Rx and Tx bytes stats

2021-03-03 Thread Ferruh Yigit
On 3/3/2021 2:08 PM, oulijun wrote: 在 2021/3/3 21:28, Ferruh Yigit 写道: On 3/2/2021 1:58 PM, Lijun Ou wrote: From: "Min Hu (Connor)" In current HNS3 PMD, Rx/Tx bytes from packet stats are not implemented. This patch implemented Rx/Tx bytes using soft counters. Rx/Tx bytes stats will be enab

Re: [dpdk-dev] [Linuxarm] Re: [PATCH V2 04/14] net/hns3: add Rx and Tx bytes stats

2021-03-03 Thread oulijun
在 2021/3/3 21:28, Ferruh Yigit 写道: On 3/2/2021 1:58 PM, Lijun Ou wrote: From: "Min Hu (Connor)" In current HNS3 PMD, Rx/Tx bytes from packet stats are not implemented. This patch implemented Rx/Tx bytes using soft counters. Rx/Tx bytes stats will be enabled if the macro RTE_LIBRTE_HNS3_PMD

Re: [dpdk-dev] [PATCH v8 2/3] ethdev: tunnel offload model

2021-03-03 Thread Ivan Malov
Hi, Could someone please also clarify the meaning (from PMD standpoint and from application's standpoint) of the 64-bit field "tun_id" in "rte_flow_tunnel"? The current comment reads: "Tunnel identification", which is quite ambiguous, not to mention the fact that it simply expands the field's

Re: [dpdk-dev] [PATCH 4/4] net/mlx5: fix imissed statistics

2021-03-03 Thread Slava Ovsiienko
> -Original Message- > From: Matan Azrad > Sent: Thursday, February 25, 2021 12:45 > To: dev@dpdk.org > Cc: Slava Ovsiienko ; sta...@dpdk.org > Subject: [PATCH 4/4] net/mlx5: fix imissed statistics > > The imissed port statistic counts packets that were dropped by the device Rx > queues.

Re: [dpdk-dev] [PATCH 3/4] common/mlx5: add DevX commands for queue counters

2021-03-03 Thread Slava Ovsiienko
> -Original Message- > From: Matan Azrad > Sent: Thursday, February 25, 2021 12:45 > To: dev@dpdk.org > Cc: Slava Ovsiienko ; sta...@dpdk.org > Subject: [PATCH 3/4] common/mlx5: add DevX commands for queue counters > > A queue counter set is an HW object that can be assigned to any RQ\QP

Re: [dpdk-dev] [PATCH 2/4] common/mlx5: add DevX command to query WQ

2021-03-03 Thread Slava Ovsiienko
> -Original Message- > From: Matan Azrad > Sent: Thursday, February 25, 2021 12:45 > To: dev@dpdk.org > Cc: Slava Ovsiienko ; sta...@dpdk.org > Subject: [PATCH 2/4] common/mlx5: add DevX command to query WQ > > Add a DevX command to query Rx queues attributes created by VERBS. > > Curren

Re: [dpdk-dev] [PATCH 1/4] common/mlx5/linux: add glue function to query WQ

2021-03-03 Thread Slava Ovsiienko
> -Original Message- > From: Matan Azrad > Sent: Thursday, February 25, 2021 12:45 > To: dev@dpdk.org > Cc: Slava Ovsiienko ; sta...@dpdk.org > Subject: [PATCH 1/4] common/mlx5/linux: add glue function to query WQ > > When Rx queue is created by VERBS API ibv_create_wq there is a dedicate

Re: [dpdk-dev] [PATCH V2 07/14] net/hns3: fix device capabilities for copper media type

2021-03-03 Thread Ferruh Yigit
On 3/3/2021 1:51 PM, oulijun wrote: 在 2021/3/3 21:27, Ferruh Yigit 写道: On 3/2/2021 1:58 PM, Lijun Ou wrote: From: Huisong Li The configuration operation for PHY is implemented by firmware. And a capability flag will be report to driver, which means the firmware supports the PHY driver.  How

Re: [dpdk-dev] [PATCH V2 07/14] net/hns3: fix device capabilities for copper media type

2021-03-03 Thread oulijun
在 2021/3/3 21:27, Ferruh Yigit 写道: On 3/2/2021 1:58 PM, Lijun Ou wrote: From: Huisong Li The configuration operation for PHY is implemented by firmware. And a capability flag will be report to driver, which means the firmware supports the PHY driver. However, the current implementation onl

Re: [dpdk-dev] [PATCH V2 01/14] net/hns3: support module EEPROM dump

2021-03-03 Thread oulijun
在 2021/3/3 21:26, Ferruh Yigit 写道: On 3/2/2021 1:58 PM, Lijun Ou wrote: From: Chengchang Tang This patch add support for dumping module EEPROM. Signed-off-by: Chengchang Tang Signed-off-by: Lijun Ou --- doc/guides/rel_notes/release_21_05.rst | 4 + drivers/net/hns3/hns3_cmd.h

Re: [dpdk-dev] [PATCH V2 04/14] net/hns3: add Rx and Tx bytes stats

2021-03-03 Thread Ferruh Yigit
On 3/2/2021 1:58 PM, Lijun Ou wrote: From: "Min Hu (Connor)" In current HNS3 PMD, Rx/Tx bytes from packet stats are not implemented. This patch implemented Rx/Tx bytes using soft counters. Rx/Tx bytes stats will be enabled if the macro RTE_LIBRTE_HNS3_PMD_SOFT_COUNTERS is defined. Signed-off-

Re: [dpdk-dev] [PATCH V2 07/14] net/hns3: fix device capabilities for copper media type

2021-03-03 Thread Ferruh Yigit
On 3/2/2021 1:58 PM, Lijun Ou wrote: From: Huisong Li The configuration operation for PHY is implemented by firmware. And a capability flag will be report to driver, which means the firmware supports the PHY driver. However, the current implementation only supports obtaining the capability bit

Re: [dpdk-dev] [PATCH 09/13] net/hns3: fix maximum frame size update after buffer alloc

2021-03-03 Thread Ferruh Yigit
On 2/24/2021 1:28 AM, Lijun Ou wrote: From: Chengchang Tang After MTU changed, the buffer used to store packets in HW should be reallocated. And buffer size is allocated based on the maximum frame size in the PF struct. However, the value of maximum frame size is not updated in time when MTU i

Re: [dpdk-dev] [PATCH V2 03/14] net/hns3: implement cleanup for Tx done

2021-03-03 Thread Ferruh Yigit
On 3/2/2021 1:58 PM, Lijun Ou wrote: From: Chengwen Feng This patch add support tx_done_cleanup ops, which could support for the API rte_eth_tx_done_cleanup to free consumed mbufs on Tx ring. dev_ops name is 'tx_done_cleanup' but I think better to have more descriptive patch title, what do y

Re: [dpdk-dev] [PATCH V2 01/14] net/hns3: support module EEPROM dump

2021-03-03 Thread Ferruh Yigit
On 3/2/2021 1:58 PM, Lijun Ou wrote: From: Chengchang Tang This patch add support for dumping module EEPROM. Signed-off-by: Chengchang Tang Signed-off-by: Lijun Ou --- doc/guides/rel_notes/release_21_05.rst | 4 + drivers/net/hns3/hns3_cmd.h| 16 drivers/net/hns3/hns3

[dpdk-dev] [PATCH 2/2] doc: add PMD power management to doxygen API index

2021-03-03 Thread Anatoly Burakov
Currently, the PMD power management API header is missing from the API index generated by doxygen. Add it. Fixes: 682a645438c5 ("power: add ethdev power management") Signed-off-by: Anatoly Burakov --- doc/api/doxy-api-index.md | 1 + 1 file changed, 1 insertion(+) diff --git a/doc/api/doxy-api

[dpdk-dev] [PATCH 1/2] doc: add power intrinsics to doxygen API index

2021-03-03 Thread Anatoly Burakov
Currently, the header `rte_power_intrinsics.h` is missing from the doxygen API index. Add it. Fixes: cda57d9388c0 ("eal: add power management intrinsics") Cc: sta...@dpdk.org Signed-off-by: Anatoly Burakov --- doc/api/doxy-api-index.md | 1 + 1 file changed, 1 insertion(+) diff --git a/doc/api

Re: [dpdk-dev] [PATCH v2 1/2] eal: error number enhancement for thread TLS API

2021-03-03 Thread Tal Shnaiderman
> Subject: Re: [PATCH v2 1/2] eal: error number enhancement for thread TLS > API > > External email: Use caution opening links or attachments > > > 2021-03-03 10:37, Tal Shnaiderman: > > > Subject: Re: [PATCH v2 1/2] eal: error number enhancement for thread > > > TLS API > > > > > > External ema

Re: [dpdk-dev] [PATCH v3 4/5] examples/l3fwd: implement FIB lookup method

2021-03-03 Thread Burakov, Anatoly
On 19-Feb-21 3:09 PM, Conor Walsh wrote: This patch implements the Forwarding Information Base (FIB) library in l3fwd using the function calls and infrastructure introduced in the previous patch. Signed-off-by: Conor Walsh --- +|| defined RTE_ARCH_PPC_64 +#define FI

Re: [dpdk-dev] [PATCH v3 3/5] examples/l3fwd: add FIB infrastructure

2021-03-03 Thread Burakov, Anatoly
On 19-Feb-21 3:09 PM, Conor Walsh wrote: The purpose of this commit is to add the necessary function calls and supporting infrastructure to allow the Forwarding Information Base (FIB) library to be integrated into the l3fwd sample app. The flag '-F' has been added to the applications options to a

Re: [dpdk-dev] [PATCH v2 1/2] eal: error number enhancement for thread TLS API

2021-03-03 Thread Dmitry Kozlyuk
2021-03-03 10:37, Tal Shnaiderman: > > Subject: Re: [PATCH v2 1/2] eal: error number enhancement for thread TLS > > API > > > > External email: Use caution opening links or attachments > > > > > > 2021-03-02 17:26, Tal Shnaiderman: > > > add error number reporting to rte_errno in all functions

[dpdk-dev] [PATCH v4] event/sw: add xstats to expose progress details

2021-03-03 Thread Harry van Haaren
Today it is difficult to know if the SW Eventdev PMD is making forward progress when it runs an iteration of its service. This commit adds two xstats to give better visibility to the application. The new xstats provide an application with which Eventdev ports recieved work in the last iteration of

Re: [dpdk-dev] [PATCH v2 1/2] eal: error number enhancement for thread TLS API

2021-03-03 Thread Tal Shnaiderman
> Subject: Re: [PATCH v2 1/2] eal: error number enhancement for thread TLS > API > > External email: Use caution opening links or attachments > > > 2021-03-02 17:26, Tal Shnaiderman: > > add error number reporting to rte_errno in all functions in the > > rte_thread_tls_* API. > > > > Suggested-b

Re: [dpdk-dev] [PATCH v4] eal: detach memsegs on cleanup

2021-03-03 Thread David Marchand
On Mon, Sep 14, 2020 at 3:06 PM Anatoly Burakov wrote: > > Currently, we don't detach the shared memory on EAL cleanup, which > leaves the page table descriptors still holding on to the file > descriptors as well as memory space occupied by them. Fix it by adding > another detach stage that closes

Re: [dpdk-dev] [PATCH v2] ci: catch coredumps

2021-03-03 Thread David Marchand
On Mon, Jan 25, 2021 at 4:06 PM David Marchand wrote: > > Parts of the unit tests code rely on forked/secondary processes > (expectedly) failing. > A crash in those situations could be missed so add a check on coredumps > presence after unit tests have run. > When unit tests fail, it can also help

Re: [dpdk-dev] Potential bug in QAT PMD code

2021-03-03 Thread Doherty, Declan
H On 23/02/2021 12:34 AM, Linfeng Li wrote: Hi, We believe we found a potential bug in the QAT PMD code. file link: https://github.com/DPDK/dpdk/blob/main/drivers/crypto/qat/qat_sym.c The undesired behavior happens when: * symmetric operation * out-of-place operation *

Re: [dpdk-dev] [PATCH] eal: fix return value comment

2021-03-03 Thread David Marchand
On Tue, Feb 9, 2021 at 2:52 PM Burakov, Anatoly wrote: > On 06-Jun-20 10:17 AM, wangyunjian wrote: > > From: Yunjian Wang > > > > Fix few comments and add detailed comments for return value. > > > > Fixes: 279b581c897d ("vfio: expose functions") > > Cc: sta...@dpdk.org > > > > Signed-off-by: Yunj

Re: [dpdk-dev] [PATCH] eal/ppc: add ppc specific TSC frequency value

2021-03-03 Thread David Marchand
On Wed, Feb 3, 2021 at 10:54 PM David Christensen wrote: > > Return a PPC specific value for get_tsc_freq_arch() rather than > depending on the EAL framework to estimate the frequency. > > Signed-off-by: David Christensen Applied, thanks. -- David Marchand

Re: [dpdk-dev] [PATCH] fbarray: fix uninitialized variable usage

2021-03-03 Thread David Marchand
On Wed, Mar 3, 2021 at 9:31 AM Andrew Rybchenko wrote: > > On 3/3/21 11:17 AM, David Marchand wrote: > > On Fri, Feb 19, 2021 at 6:55 PM Anatoly Burakov > > wrote: > >> > >> When file truncation fails, the log message attempts to print a path of > >> file we failed to truncate, but this path was

Re: [dpdk-dev] [PATCH] fbarray: fix uninitialized variable usage

2021-03-03 Thread Andrew Rybchenko
On 3/3/21 11:17 AM, David Marchand wrote: > On Fri, Feb 19, 2021 at 6:55 PM Anatoly Burakov > wrote: >> >> When file truncation fails, the log message attempts to print a path of >> file we failed to truncate, but this path was never set to anything and, >> what's worse, was uninitialized. Fix it

Re: [dpdk-dev] [PATCH] fbarray: fix uninitialized variable usage

2021-03-03 Thread David Marchand
On Fri, Feb 19, 2021 at 6:55 PM Anatoly Burakov wrote: > > When file truncation fails, the log message attempts to print a path of > file we failed to truncate, but this path was never set to anything and, > what's worse, was uninitialized. Fix it by passing path from the caller. > > Fixes: c44d09

[dpdk-dev] [PATCH v2] net/ice: fix wrong RSS hash update

2021-03-03 Thread Wenjun Wu
This patch change redundant judgment statements to disable RSS when users need to disable RSS or RSS hash function configured is not supported. Fixes: 4717a12cfaf1 ("net/ice: initialize and update RSS based on user config") Cc: sta...@dpdk.org Signed-off-by: Wenjun Wu --- v2: do pf->rss_hf = 0