Re: [dpdk-dev] [PATCH v3 1/2] net/mlx5: optimize mprq memcpy

2021-02-08 Thread Aman Kumar
Hi Slava, Thank you for your reply. This is currently supported (and tested) on 2nd gen AMD EPYC series processors. We're currently trying to make it more generic across other EPYC platforms. We too believe having these available at EAL may also help applications and other PMDs. I'll move memory c

[dpdk-dev] [PATCH V3] doc: add tested Intel platforms with Intel NICs

2021-02-08 Thread Xueqin Lin
From: ChenBo Add tested Intel platforms with Intel NICs to v21.02 release note. Signed-off-by: ChenBo --- doc/guides/rel_notes/release_21_02.rst | 124 + 1 file changed, 124 insertions(+) diff --git a/doc/guides/rel_notes/release_21_02.rst b/doc/guides/rel_notes/relea

Re: [dpdk-dev] [PATCH] vdpa/mlx5: fix polling threads scheduling

2021-02-08 Thread Xueming(Steven) Li
>-Original Message- >From: dev On Behalf Of Maxime Coquelin >Sent: Monday, February 8, 2021 7:17 PM >To: Matan Azrad ; dev@dpdk.org >Subject: Re: [dpdk-dev] [PATCH] vdpa/mlx5: fix polling threads scheduling > > > >On 2/8/21 10:28 AM, Matan Azrad wrote: >> When the event mode is with 0 fixe

Re: [dpdk-dev] [PATCH V2] doc: add tested Intel platforms with Intel NICs

2021-02-08 Thread Lin, Xueqin
> -Original Message- > From: dev On Behalf Of ChenBo > Sent: Monday, February 8, 2021 3:10 PM > To: maintain...@intel.org > Cc: dev@dpdk.org; Chen, BoX C > Subject: [dpdk-dev] [PATCH V2] doc: add tested Intel platforms with Intel > NICs > > Add tested Intel platforms with Intel NICs t

Re: [dpdk-dev] [PATCH v2] app/testpmd: fix meter commands help strings

2021-02-08 Thread Li, Xiaoyun
Hi > -Original Message- > From: Yigit, Ferruh > Sent: Monday, February 8, 2021 23:15 > To: Li, Xiaoyun ; Singh, Jasvinder > ; Wu, Jingjing ; Adrien > Mazarguil ; Dumitrescu, Cristian > > Cc: Yigit, Ferruh ; dev@dpdk.org; sta...@dpdk.org > Subject: [PATCH v2] app/testpmd: fix meter comman

Re: [dpdk-dev] [PATCH v3] net/ixgbe: fix UDP zero checksum error

2021-02-08 Thread Zhang, Qi Z
> -Original Message- > From: Ananyev, Konstantin > Sent: Monday, February 8, 2021 9:48 PM > To: Wang, Haiyue ; dev@dpdk.org > Cc: pvale...@redhat.com; acon...@redhat.com; > david.march...@redhat.com; Zhang, Qi Z ; Rong, Leyi > ; Tu, Lijuan ; > ruifeng.w...@arm.com; feifei.wa...@arm.com;

Re: [dpdk-dev] [Question about 'rte_eth_tx_prepare']

2021-02-08 Thread Chengchang Tang
On 2021/2/8 16:40, Olivier Matz wrote: > Hi, > > On Mon, Feb 08, 2021 at 09:07:39AM +0100, Thomas Monjalon wrote: >> 08/02/2021 07:29, Chengchang Tang: >>> Hi, Thomas Monjalon and Ferruh Yigit and others. >>> >>> Here are two questions: >>> 1. What functions should be included in the 'tx_prepare'

Re: [dpdk-dev] [PATCH v2] log: support custom log function

2021-02-08 Thread Dmitry Kozlyuk
On Mon, 8 Feb 2021 14:58:29 +0800, Feng Li wrote: > > > +/** > > > + * Usage function typedef used by the application usage function. > > > > It's unrelated to the following typedef purpose, is it? > It's borrowed from the front typedef sentence. Doesn't make much sense here anyway. > > > + *

Re: [dpdk-dev] [v2 PATCH] usertools: show valid hugepage sizes if user requests an invalid hugepage size

2021-02-08 Thread Stephen Hemminger
On Fri, 05 Feb 2021 19:17:52 +0100 Thomas Monjalon wrote: > 02/12/2020 12:06, Sarosh Arif: > > If user requests a hugepage size which is not supported by the system, > > currently user gets an error message saying that the requested size > > is not a valid system huge page size. In addition to th

Re: [dpdk-dev] [PATCH] cryptodev: support multiple cipher block sizes

2021-02-08 Thread Matan Azrad
Hi Kusztal First, thank you for this review and the suggestions. From: Kusztal, ArkadiuszX > > > > Subject: [dpdk-dev] [PATCH] cryptodev: support multiple cipher > > > > block sizes > > > > > > > > In cryptography, a block cipher is a deterministic algorithm > > > > operating on fixed- length gro

Re: [dpdk-dev] [PATCH] guides: add a testing guide for developing tests

2021-02-08 Thread Kinsella, Ray
On 08/02/2021 16:52, Aaron Conole wrote: > The DPDK testing infrastructure includes a comprehensive set of > libraries, utilities, and CI integrations for developers to test > their code changes. This isn't well documented, however. > > Document the basics for adding a test suite to the infras

Re: [dpdk-dev] [RFC PATCH v1] config/arm: fix clang cross part number

2021-02-08 Thread Juraj Linkeš
> -Original Message- > From: Thomas Monjalon > Sent: Monday, February 8, 2021 6:26 PM > To: Juraj Linkeš > Cc: bruce.richard...@intel.com; ruifeng.w...@arm.com; > honnappa.nagaraha...@arm.com; jerinjac...@gmail.com; > ferruh.yi...@intel.com; dev@dpdk.org > Subject: Re: [RFC PATCH v1] co

Re: [dpdk-dev] [RFC PATCH v1] config/arm: fix clang cross part number

2021-02-08 Thread Thomas Monjalon
08/02/2021 17:46, Juraj Linkeš: > From: Thomas Monjalon > > 08/02/2021 15:46, Juraj Linkeš: > > > I accidentally submitted this as an RFC patch. Please consider this to be > > > a > > regular patch. > > > > > > With that said, Thomas, would it be possible to get this into the release? > > > > Ye

Re: [dpdk-dev] [RFC PATCH v4] build: kni cross-compilation support

2021-02-08 Thread Thomas Monjalon
08/02/2021 12:45, Bruce Richardson: > On Mon, Feb 08, 2021 at 12:21:17PM +0100, Thomas Monjalon wrote: > > 08/02/2021 12:05, Bruce Richardson: > > > On Mon, Feb 08, 2021 at 11:56:21AM +0100, Thomas Monjalon wrote: > > > > 08/02/2021 11:26, Bruce Richardson: > > > > > On Mon, Feb 08, 2021 at 10:17:5

[dpdk-dev] [PATCH] guides: add a testing guide for developing tests

2021-02-08 Thread Aaron Conole
The DPDK testing infrastructure includes a comprehensive set of libraries, utilities, and CI integrations for developers to test their code changes. This isn't well documented, however. Document the basics for adding a test suite to the infrastructure and enabling that test suite for continuous i

Re: [dpdk-dev] [RFC PATCH v1] config/arm: fix clang cross part number

2021-02-08 Thread Juraj Linkeš
> -Original Message- > From: Thomas Monjalon > Sent: Monday, February 8, 2021 5:43 PM > To: Juraj Linkeš > Cc: bruce.richard...@intel.com; ruifeng.w...@arm.com; > honnappa.nagaraha...@arm.com; jerinjac...@gmail.com; > ferruh.yi...@intel.com; dev@dpdk.org > Subject: Re: [RFC PATCH v1] co

Re: [dpdk-dev] [RFC PATCH v1] config/arm: fix clang cross part number

2021-02-08 Thread Thomas Monjalon
08/02/2021 15:46, Juraj Linkeš: > I accidentally submitted this as an RFC patch. Please consider this to be a > regular patch. > > With that said, Thomas, would it be possible to get this into the release? Yes For the sake of understanding, is it an issue due to a missing rebase? Or was it a mi

[dpdk-dev] [Bug 418] failsafe/tap PMD drops first UDP packet

2021-02-08 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=418 Stephen Hemminger (step...@networkplumber.org) changed: What|Removed |Added Resolution|--- |WORKSFORME

Re: [dpdk-dev] building l2fwd-crypto example from Makefile

2021-02-08 Thread Bruce Richardson
On Sun, Feb 07, 2021 at 12:46:50PM +0330, mirzaei.reza wrote: > Hello, > > I have a problem to build l2fwd-crypto example using its Makefile. I > build it using Makefile according to this [1] tutorial, when i run the > compiled file using the following command: > > ./l2fwd-crypto -l 1 -n 4 > --

[dpdk-dev] [PATCH] eal: fix detection of static or shared DPDK builds

2021-02-08 Thread Bruce Richardson
When checking the loading of EAL shared lib to see if we have a shared DPDK build, we only want to include part of the ABI version in the check rather than the whole thing. For example, with ABI version 21.1 for DPDK release 21.02, the linker links the binary against librte_eal.so.21, without the "

Re: [dpdk-dev] [dpdk-ci] [CI] SPDK compilation failures @ DPDK community lab

2021-02-08 Thread Lincoln Lavoie
Thanks Tomek, Can you let us know when the merge happens and we'll make sure the next set of builds pass or see what the next failure is. :-P Cheers, Lincoln On Mon, Feb 8, 2021 at 11:03 AM Zawadzki, Tomasz wrote: > Hi Aaron, > > Thank you for reporting this ! > > This is an issue with rte_pow

Re: [dpdk-dev] [CI] SPDK compilation failures @ DPDK community lab

2021-02-08 Thread Zawadzki, Tomasz
Hi Aaron, Thank you for reporting this ! This is an issue with rte_power now depending on rte_ethdev, which was resolved on latest SPDK. I believe that UNH lab verifies DPDK patches against SPDK branch for latest release. Which after the very recent SPDK release, would be v21.01.x: https://git

Re: [dpdk-dev] [PATCH] cryptodev: support multiple cipher block sizes

2021-02-08 Thread Kusztal, ArkadiuszX
> > > Subject: [dpdk-dev] [PATCH] cryptodev: support multiple cipher block > > > sizes > > > > > > In cryptography, a block cipher is a deterministic algorithm > > > operating on fixed- length groups of bits, called blocks. > > > > > > A block cipher consists of two paired algorithms, one for encry

[dpdk-dev] [CI] SPDK compilation failures @ DPDK community lab

2021-02-08 Thread Aaron Conole
Greetings, I've noticed that recently SPDK compilation in the UNH community lab seems to be failing, and I don't see an obvious reason for the failure. The logs haven't been too helpful - it appears that there is a symbol that isn't available when linking. Job details (for example): https://lab.d

[dpdk-dev] [PATCH v2] app/testpmd: fix meter commands help strings

2021-02-08 Thread Ferruh Yigit
Helps strings syntax is "command : description", the 'command' part was missing, updated command help strings. Fixes: 281eeb8afc55 ("app/testpmd: add commands for metering and policing") Fixes: 30ffb4e67ee3 ("app/testpmd: add commands traffic metering and policing") Fixes: e63b50162aa3 ("app/testp

Re: [dpdk-dev] [RFC PATCH v1] config/arm: fix clang cross part number

2021-02-08 Thread Juraj Linkeš
I accidentally submitted this as an RFC patch. Please consider this to be a regular patch. With that said, Thomas, would it be possible to get this into the release? Thanks, Juraj > -Original Message- > From: Juraj Linkeš > Sent: Monday, February 8, 2021 3:44 PM > To: bruce.richard...@

[dpdk-dev] [RFC PATCH v1] config/arm: fix clang cross part number

2021-02-08 Thread Juraj Linkeš
Rename the 'default' part number in clang cross-file to fix the following issue: config/arm/meson.build:238:2: ERROR: Problem encountered: Unsupported part number default of implementer generic. Please add support for it or use the generic (-Dmachine=generic) build. Fixes: 3d01d65ba0d3 ("config:

Re: [dpdk-dev] [PATCH] app/testpmd: fix meter commands help strings

2021-02-08 Thread Ferruh Yigit
On 2/7/2021 2:47 AM, Li, Xiaoyun wrote: Hi -Original Message- From: Yigit, Ferruh Sent: Friday, February 5, 2021 21:39 To: Lu, Wenzhuo ; Li, Xiaoyun ; Iremonger, Bernard ; Singh, Jasvinder ; Wu, Jingjing ; Dumitrescu, Cristian ; Adrien Mazarguil Cc: Yigit, Ferruh ; dev@dpdk.org; sta..

Re: [dpdk-dev] [PATCH v2] log: support custom log function

2021-02-08 Thread Feng Li
Thanks for your comments. Dmitry Kozlyuk 于2021年2月6日周六 上午3:32写道: > > On Sat, 6 Feb 2021 01:42:04 +0800, Li Feng wrote: > > Currently, the dpdk log is out to stdout/stderr and syslog. > > The rte_openlog_stream could set an external FILE* stream, but it asks the > > consumer to give it a FILE* poi

Re: [dpdk-dev] [PATCH v3] net/ixgbe: fix UDP zero checksum error

2021-02-08 Thread Ananyev, Konstantin
> > There is an 82599 errata that UDP frames with a zero checksum are > incorrectly marked as checksum invalid by the hardware. This was > leading to misleading PKT_RX_L4_CKSUM_BAD flag. > > This patch changes the bad UDP checksum to PKT_RX_L4_CKSUM_UNKNOWN, > so the software application will th

[dpdk-dev] Error building documentation

2021-02-08 Thread Murrell, Brian
When I add "-Denable_docs=true" to my DPDK 20.11 build commandline I get a build error: FAILED: doc/guides/html /usr/bin/python3.6 ../buildtools/call-sphinx-build.py /bin/sphinx-build 20.11.0 /home/brian/daos/rpm/dpdk/_topdir/BUILD/dpdk-20.11/doc/guides /home/brian/daos/rpm/dpdk/_topdir/BUILD/dpd

Re: [dpdk-dev] [PATCH] cryptodev: support multiple cipher block sizes

2021-02-08 Thread Matan Azrad
Hi Kuztal From: Kusztal, ArkadiuszX > Hi Matan, > > Few comments/questions inline with [Arek] > > > -Original Message- > > From: dev On Behalf Of Matan Azrad > > Sent: Thursday, February 4, 2021 3:34 PM > > To: dev@dpdk.org > > Cc: akhil.go...@nxp.com; Doherty, Declan ; > > Somalapuram

[dpdk-dev] [PATCH] net/octeontx2: support for rte_flow_dev_dump api

2021-02-08 Thread psatheesh
From: Satheesh Paul Add support to dump hardware internal representation information of rte flow to file. Every flow rule added will be dumped in the below format. MCAM Index:1881 Interface :NIX-RX (0) Priority :1 NPC RX Action:0X404001 ActionOp:NIX_RX_ACTIONOP_UCAST (1)

Re: [dpdk-dev] [PATCH v4] doc: add new tables for rte flow items and actions support

2021-02-08 Thread Thomas Monjalon
07/02/2021 11:52, Asaf Penso: > In http://doc.dpdk.org/guides/nics/overview.html, table 1.1 lists all > supported features. > It has a single line for "Flow API" that refers to rte_flow support. > rte_flow is composed of many items and actions that are not expressed in > this single line. One comm

Re: [dpdk-dev] [PATCH] cryptodev: support multiple cipher block sizes

2021-02-08 Thread Kusztal, ArkadiuszX
Hi Matan, Few comments/questions inline with [Arek] > -Original Message- > From: dev On Behalf Of Matan Azrad > Sent: Thursday, February 4, 2021 3:34 PM > To: dev@dpdk.org > Cc: akhil.go...@nxp.com; Doherty, Declan ; > Somalapuram Amaranath ; Ruifeng Wang > ; Ajit Khaparde ; > Anoob Jose

Re: [dpdk-dev] [RFC PATCH v4] build: kni cross-compilation support

2021-02-08 Thread Bruce Richardson
On Mon, Feb 08, 2021 at 12:21:17PM +0100, Thomas Monjalon wrote: > 08/02/2021 12:05, Bruce Richardson: > > On Mon, Feb 08, 2021 at 11:56:21AM +0100, Thomas Monjalon wrote: > > > 08/02/2021 11:26, Bruce Richardson: > > > > On Mon, Feb 08, 2021 at 10:17:56AM +, Juraj Linkeš wrote: > > > > > From:

Re: [dpdk-dev] [RFC PATCH v4] build: kni cross-compilation support

2021-02-08 Thread Thomas Monjalon
08/02/2021 12:05, Bruce Richardson: > On Mon, Feb 08, 2021 at 11:56:21AM +0100, Thomas Monjalon wrote: > > 08/02/2021 11:26, Bruce Richardson: > > > On Mon, Feb 08, 2021 at 10:17:56AM +, Juraj Linkeš wrote: > > > > From: Bruce Richardson > > > > > On Fri, Feb 05, 2021 at 04:04:32PM +0100, Jura

Re: [dpdk-dev] [PATCH] vdpa/mlx5: fix polling threads scheduling

2021-02-08 Thread Maxime Coquelin
On 2/8/21 10:28 AM, Matan Azrad wrote: > When the event mode is with 0 fixed delay, the polling-thread will never > give-up CPU. > > So, when multi-polling-threads are active, the context-switch between > them will be managed by the system which may affect latency according to > the time-out de

Re: [dpdk-dev] [RFC PATCH v4] build: kni cross-compilation support

2021-02-08 Thread Bruce Richardson
On Mon, Feb 08, 2021 at 11:56:21AM +0100, Thomas Monjalon wrote: > 08/02/2021 11:26, Bruce Richardson: > > On Mon, Feb 08, 2021 at 10:17:56AM +, Juraj Linkeš wrote: > > > From: Bruce Richardson > > > > On Fri, Feb 05, 2021 at 04:04:32PM +0100, Juraj Linkeš wrote: > > > > > The kni linux module

Re: [dpdk-dev] [RFC PATCH v4] build: kni cross-compilation support

2021-02-08 Thread Thomas Monjalon
08/02/2021 11:26, Bruce Richardson: > On Mon, Feb 08, 2021 at 10:17:56AM +, Juraj Linkeš wrote: > > From: Bruce Richardson > > > On Fri, Feb 05, 2021 at 04:04:32PM +0100, Juraj Linkeš wrote: > > > > The kni linux module is using a custom target for building, which > > > > doesn't take into acc

Re: [dpdk-dev] [RFC PATCH v4] build: kni cross-compilation support

2021-02-08 Thread Bruce Richardson
On Mon, Feb 08, 2021 at 10:17:56AM +, Juraj Linkeš wrote: > > > > -Original Message- > > From: Bruce Richardson > > Sent: Friday, February 5, 2021 4:27 PM > > To: Juraj Linkeš > > Cc: tho...@monjalon.net; ruifeng.w...@arm.com; > > honnappa.nagaraha...@arm.com; jerinjac...@gmail.com;

Re: [dpdk-dev] [RFC PATCH v4] build: kni cross-compilation support

2021-02-08 Thread Juraj Linkeš
> -Original Message- > From: Bruce Richardson > Sent: Friday, February 5, 2021 4:27 PM > To: Juraj Linkeš > Cc: tho...@monjalon.net; ruifeng.w...@arm.com; > honnappa.nagaraha...@arm.com; jerinjac...@gmail.com; > hemant.agra...@nxp.com; ferruh.yi...@intel.com; abo...@pensando.io; > dev@d

[dpdk-dev] [PATCH] vdpa/mlx5: fix polling threads scheduling

2021-02-08 Thread Matan Azrad
When the event mode is with 0 fixed delay, the polling-thread will never give-up CPU. So, when multi-polling-threads are active, the context-switch between them will be managed by the system which may affect latency according to the time-out decided by the system. In order to fix multi-devices po

[dpdk-dev] [PATCH v1] net/ixgbe: fix UDP zero checksum error for Arm NEON path

2021-02-08 Thread Feifei Wang
There is an 82599 errata that UDP frames with a zero checksum are incorrectly marked as checksum invalid by the hardware. This was leading to misleading PKT_RX_L4_CKSUM_BAD flag. To fix it for the NEON path in Arm platform, change the bad UDP checksum to unknown, and then let software application

Re: [dpdk-dev] [Question about 'rte_eth_tx_prepare']

2021-02-08 Thread Olivier Matz
Hi, On Mon, Feb 08, 2021 at 09:07:39AM +0100, Thomas Monjalon wrote: > 08/02/2021 07:29, Chengchang Tang: > > Hi, Thomas Monjalon and Ferruh Yigit and others. > > > > I have some questions about 'rte_eth_tx_prepare'. > > > > When I use TSO offload in bond mode, the checksum error occurs. It is >

Re: [dpdk-dev] [Question about 'rte_eth_tx_prepare']

2021-02-08 Thread Thomas Monjalon
08/02/2021 07:29, Chengchang Tang: > Hi, Thomas Monjalon and Ferruh Yigit and others. > > I have some questions about 'rte_eth_tx_prepare'. > > When I use TSO offload in bond mode, the checksum error occurs. It is > because the bond PMD does not implement 'tx_prepare'. So, it will not > invoke th