[dpdk-dev] [PATCH] vhost: fix packed ring dequeue offloading

2021-02-04 Thread Marvin Liu
When vhost doing dequeue offloading, will parse ethernet and l3/l4 header of the packet. Then vhost will set corresponded value in mbuf attributes. Thus mean offloading action should after packet data copy. Fixes: 75ed51697820 ("vhost: add packed ring batch dequeue") Cc: sta...@dpdk.org Signed-of

Re: [dpdk-dev] [PATCH v5 0/9] ethdev: support SubFunction representor

2021-02-04 Thread Andrew Rybchenko
On 2/4/21 5:15 PM, Xueming(Steven) Li wrote: > >> -Original Message- >> From: Andrew Rybchenko >> Sent: Monday, February 1, 2021 4:39 PM >> To: Xueming(Steven) Li >> Cc: dev@dpdk.org; Slava Ovsiienko ; Asaf Penso >> >> Subject: Re: [dpdk-dev] [PATCH v5 0/9] ethdev: support SubFunction

[dpdk-dev] [PATCH v2 17/17] doc: update release note for txgbe

2021-02-04 Thread Jiawen Wu
Update release note to add txgbevf PMD support. Signed-off-by: Jiawen Wu --- doc/guides/rel_notes/release_21_02.rst | 1 + 1 file changed, 1 insertion(+) diff --git a/doc/guides/rel_notes/release_21_02.rst b/doc/guides/rel_notes/release_21_02.rst index cc181dfd1..78e9db666 100644 --- a/doc/gui

[dpdk-dev] [PATCH v2 16/17] net/txgbe: add some supports as PF driver implemented

2021-02-04 Thread Jiawen Wu
Some RXTX operations like queue setup and release, packet type get, and Tx done cleanup have been supported on PF device. There are ops functions directly added. Signed-off-by: Jiawen Wu --- doc/guides/nics/features/txgbe_vf.ini | 3 +++ drivers/net/txgbe/txgbe_ethdev_vf.c | 6 ++ 2 files

[dpdk-dev] [PATCH v2 13/17] net/txgbe: support to update MTU on VF device

2021-02-04 Thread Jiawen Wu
Add MTU set operation for VF device. Signed-off-by: Jiawen Wu --- doc/guides/nics/features/txgbe_vf.ini | 1 + drivers/net/txgbe/txgbe_ethdev_vf.c | 36 +++ 2 files changed, 37 insertions(+) diff --git a/doc/guides/nics/features/txgbe_vf.ini b/doc/guides/nics/feature

[dpdk-dev] [PATCH v2 15/17] net/txgbe: start and stop VF device

2021-02-04 Thread Jiawen Wu
Add support to start, stop and reset VF device. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/txgbe_ethdev.h| 2 + drivers/net/txgbe/txgbe_ethdev_vf.c | 176 +++- drivers/net/txgbe/txgbe_rxtx.c | 57 + 3 files changed, 234 insertions(+), 1 deletion(-)

[dpdk-dev] [PATCH v2 14/17] net/txgbe: support register dump on VF device

2021-02-04 Thread Jiawen Wu
Add support to dump registers for VF. Signed-off-by: Jiawen Wu --- doc/guides/nics/features/txgbe_vf.ini | 1 + drivers/net/txgbe/txgbe_ethdev_vf.c | 74 +++ 2 files changed, 75 insertions(+) diff --git a/doc/guides/nics/features/txgbe_vf.ini b/doc/guides/nics/featur

[dpdk-dev] [PATCH v2 12/17] net/txgbe: support multicast MAC filter for VF driver

2021-02-04 Thread Jiawen Wu
Add multicast MAC filter support for VF driver. Signed-off-by: Jiawen Wu --- doc/guides/nics/features/txgbe_vf.ini | 1 + drivers/net/txgbe/base/txgbe_hw.c | 1 + drivers/net/txgbe/base/txgbe_vf.c | 83 +++ drivers/net/txgbe/base/txgbe_vf.h | 3 + drivers/n

[dpdk-dev] [PATCH v2 11/17] net/txgbe: add VF device promiscuous and allmulticast mode

2021-02-04 Thread Jiawen Wu
Support to enable and disable promiscuous and allmulticast mode on VF device. Signed-off-by: Jiawen Wu --- doc/guides/nics/features/txgbe_vf.ini | 2 + drivers/net/txgbe/base/txgbe_vf.c | 38 +++ drivers/net/txgbe/base/txgbe_vf.h | 1 + drivers/net/txgbe/txgbe_ethdev_vf.c | 9

[dpdk-dev] [PATCH v2 09/17] net/txgbe: add VLAN handle support to VF driver

2021-02-04 Thread Jiawen Wu
Add VLAN filter, offload and strip set support to VF driver. Signed-off-by: Jiawen Wu --- doc/guides/nics/features/txgbe_vf.ini | 1 + drivers/net/txgbe/base/txgbe_vf.c | 30 +++ drivers/net/txgbe/base/txgbe_vf.h | 2 + drivers/net/txgbe/txgbe_ethdev_vf.c | 117 +++

[dpdk-dev] [PATCH v2 08/17] net/txgbe: add VF device stats and xstats get operation

2021-02-04 Thread Jiawen Wu
Add VF device stats and extended stats get from reading hardware registers. Signed-off-by: Jiawen Wu --- doc/guides/nics/features/txgbe_vf.ini | 2 + drivers/net/txgbe/base/txgbe_regs.h | 23 drivers/net/txgbe/base/txgbe_vf.h | 27 + drivers/net/txgbe/txgbe_ethdev_vf.c | 158

[dpdk-dev] [PATCH v2 10/17] net/txgbe: add RSS support for VF device

2021-02-04 Thread Jiawen Wu
Support RSS hash and reta operations for VF device. Signed-off-by: Jiawen Wu --- doc/guides/nics/features/txgbe_vf.ini | 3 + drivers/net/txgbe/base/txgbe_regs.h | 26 + drivers/net/txgbe/txgbe_ethdev.c | 7 +- drivers/net/txgbe/txgbe_ethdev_vf.c | 4 + drivers/net/txgbe/txgb

[dpdk-dev] [PATCH v2 02/17] net/txgbe: add base code for VF driver

2021-02-04 Thread Jiawen Wu
Implement VF device init and uninit function with hardware operations, and negotiate with PF in mailbox. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/base/meson.build | 1 + drivers/net/txgbe/base/txgbe.h | 1 + drivers/net/txgbe/base/txgbe_hw.c | 4 + drivers/net/txgbe/base/txgb

[dpdk-dev] [PATCH v2 06/17] net/txgbe: get link status of VF device

2021-02-04 Thread Jiawen Wu
Add support to get link speed, duplex mode and state of VF device. Signed-off-by: Jiawen Wu --- doc/guides/nics/features/txgbe_vf.ini | 1 + drivers/net/txgbe/base/txgbe_vf.c | 100 ++ drivers/net/txgbe/base/txgbe_vf.h | 2 + drivers/net/txgbe/txgbe_ethdev_vf.

[dpdk-dev] [PATCH v2 07/17] net/txgbe: add Rx and Tx unit init for VF device

2021-02-04 Thread Jiawen Wu
Configure VF device with RX port. Initialize receive and transmit unit, set the receive and transmit functions. And support to check the status of RX and TX descriptors. Signed-off-by: Jiawen Wu --- doc/guides/nics/features/txgbe_vf.ini | 6 + doc/guides/nics/txgbe.rst | 4 + dri

[dpdk-dev] [PATCH v2 05/17] net/txgbe: add interrupt operation for VF device

2021-02-04 Thread Jiawen Wu
Add VF device interrupt handler, support to enable and disable RX queue interrupt, and configure misx interrupt. Signed-off-by: Jiawen Wu --- doc/guides/nics/features/txgbe_vf.ini | 1 + drivers/net/txgbe/base/txgbe_mbx.h| 2 + drivers/net/txgbe/txgbe_ethdev_vf.c | 181

[dpdk-dev] [PATCH v2 01/17] net/txgbe: add ethdev probe and remove for VF device

2021-02-04 Thread Jiawen Wu
Introduce virtual function driver in txgbe PMD, add simple init and uninit function to probe and remove the device. Signed-off-by: Jiawen Wu --- doc/guides/nics/features/txgbe_vf.ini | 11 +++ drivers/net/txgbe/meson.build | 1 + drivers/net/txgbe/txgbe_ethdev_vf.c | 134 +++

[dpdk-dev] [PATCH v2 03/17] net/txgbe: support add and remove VF device MAC address

2021-02-04 Thread Jiawen Wu
Generate a random MAC address if none was assigned by PF during the initialization of VF device. And support to add and remove MAC address. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/base/txgbe_vf.c | 102 + drivers/net/txgbe/base/txgbe_vf.h | 5 + drivers/net/txgbe/txg

[dpdk-dev] [PATCH v2 04/17] net/txgbe: get VF device information

2021-02-04 Thread Jiawen Wu
Add information get operation for VF device. RX and TX offload capabilities are same as the PF device. Signed-off-by: Jiawen Wu --- doc/guides/nics/features/txgbe_vf.ini | 7 +++ drivers/net/txgbe/txgbe_ethdev_vf.c | 70 +++ 2 files changed, 77 insertions(+) diff --gi

[dpdk-dev] [PATCH v2 00/17] net/txgbe: add VF driver support

2021-02-04 Thread Jiawen Wu
This patch adds txgbevf PMD as a part of txgbe PMD. v2: - Rebase on latest repo - Remove vf port representor because test issue is found - Add a little doc Jiawen Wu (17): net/txgbe: add ethdev probe and remove for VF device net/txgbe: add base code for VF driver net/txgbe: support add and

[dpdk-dev] [PATCH] net/mlx5: fix TCP flag field modification

2021-02-04 Thread Alexander Kozyrev
Wrong modification field ID is used for TCP flags: the inner TCP flag field is changing instead of the outermost one. Use the proper field ID to match the expectations. Fixes: 641dbe4fb0 ("net/mlx5: support modify field flow action") Cc: sta...@dpdk.org Signed-off-by: Alexander Kozyrev --- driv

[dpdk-dev] [PATCH] net/enic: fix a typo in debug message

2021-02-04 Thread Hyong Youb Kim
A debug message for filter API is using a wrong flag. Use the correct one. Fixes: 936a9b9975e7 ("net/enic: flow API debug") Cc: sta...@dpdk.org Reported-by: Hanoch Haim Signed-off-by: Hyong Youb Kim Reviewed-by: John Daley --- drivers/net/enic/enic_flow.c | 2 +- 1 file changed, 1 insertion(+

Re: [dpdk-dev] [PATCH] doc: add new tables for rte flow items and actions support

2021-02-04 Thread Thomas Monjalon
04/02/2021 18:05, Asaf Penso: > In http://doc.dpdk.org/guides/nics/overview.html, table 1.1 lists all > supported features. > It has a single line for "Flow API" that refers to rte_flow support. > rte_flow is composed of many items and actions that are not expressed in > this single line. > > The

Re: [dpdk-dev] [dpdk-announce] release candidate 21.02-rc2

2021-02-04 Thread Thinh Tran
DPDK 21.02 on IBM Power result * DPDK: v21.02-rc2-5-gf6f2d2240 * Build with gcc 9.3.0-1: no issue found * Basic PF on Mallanox: No new issues or regressions were seen. * Performance: not tested yet. System tested: - IBM Power9 Model 8335-101 CPU: 2.3 (pvr 004e 1203) Tested NICs: - Mellanox Tec

Re: [dpdk-dev] [dpdk-ci] [PATCH v2] net/i40e: fix avx code error on MinGW

2021-02-04 Thread Lincoln Lavoie
Hi All, The jobs for Windows compile are running, so it may just be the patch hasn't caught up in the queue. Cheers, Lincoln On Thu, Feb 4, 2021 at 8:43 AM David Marchand wrote: > On Thu, Feb 4, 2021 at 1:36 PM Ferruh Yigit > wrote: > > > > On 2/4/2021 10:41 AM, Zhang, Qi Z wrote: > > > > > >

[dpdk-dev] [PATCH] net/ionic: fix Tx fragment limits

2021-02-04 Thread Andrew Boyer
The reported nb_seg_max should include the main fragment in the descriptor and the fragments in the accompanying SGL. Update the Tx prep check as well. These were missed when updating to the v1 Tx queue structures. Fixes: 786c64763b50 ("net/ionic: clean up Tx queue version support") Signed-off-b

Re: [dpdk-dev] [PATCH 00/14] net/ionic: struct optimizations, fixes

2021-02-04 Thread Andrew Boyer
> On Feb 4, 2021, at 2:58 PM, Andrew Boyer wrote: > > This patch series reorganizes the main datastructure for each > queue, struct ionic_qcq. Its constituent struct ionic_queue and > struct ionic_cq are stripped down first. Then the generic struct > ionic_qcq is stripped down, and a unique st

[dpdk-dev] [PATCH 14/14] net/ionic: fix code around lif init devcmd

2021-02-04 Thread Andrew Boyer
The completion type was wrong. Don't check the completion if the wait timed out. Fixes: 669c8de67c88 ("net/ionic: support basic LIF") Cc: cardigli...@ntop.org Cc: sta...@dpdk.org Signed-off-by: Andrew Boyer --- drivers/net/ionic/ionic_lif.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions

[dpdk-dev] [PATCH 09/14] net/ionic: log queue counters when tearing down

2021-02-04 Thread Andrew Boyer
This improves debuggability. To see the logs, use EAL arg: --log-level=pmd.net.ionic,debug While here, stop counting fragments, but start counting mtods. Signed-off-by: Andrew Boyer --- drivers/net/ionic/ionic_lif.h | 2 +- drivers/net/ionic/ionic_rxtx.c | 13 +++-- 2 files changed,

[dpdk-dev] [PATCH 13/14] net/ionic: fix Tx fragment limit check

2021-02-04 Thread Andrew Boyer
This was missed when updating to the v1 Tx queue structures. Store the value in the queue for easy access. Fixes: 786c64763b50 ("net/ionic: clean up Tx queue version support") Signed-off-by: Andrew Boyer --- drivers/net/ionic/ionic_lif.c | 6 +- drivers/net/ionic/ionic_lif.h | 1 + driver

[dpdk-dev] [PATCH 08/14] net/ionic: use the socket id passed in for Rx and Tx queues

2021-02-04 Thread Andrew Boyer
Pipe the value from the queue setup routines through to ionic_qcq_alloc(). Signed-off-by: Andrew Boyer --- drivers/net/ionic/ionic_lif.c | 10 +++--- drivers/net/ionic/ionic_lif.h | 10 ++ drivers/net/ionic/ionic_rxtx.c | 4 ++-- 3 files changed, 15 insertions(+), 9 deletions(-)

[dpdk-dev] [PATCH 12/14] net/ionic: send as many packets as possible

2021-02-04 Thread Andrew Boyer
Rather than dropping the whole burst if some don't fit. This improves performance. Signed-off-by: Andrew Boyer Signed-off-by: Vishwas Danivas --- drivers/net/ionic/ionic_rxtx.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/net/ionic/ionic_rxtx.c b/drivers/

[dpdk-dev] [PATCH 11/14] net/ionic: ring doorbell once at the end of each burst

2021-02-04 Thread Andrew Boyer
This improves performance. Signed-off-by: Andrew Boyer --- drivers/net/ionic/ionic_rxtx.c | 41 +++--- 1 file changed, 13 insertions(+), 28 deletions(-) diff --git a/drivers/net/ionic/ionic_rxtx.c b/drivers/net/ionic/ionic_rxtx.c index c671b34e94..2522c8283a 100644 -

[dpdk-dev] [PATCH 10/14] net/ionic: break up queue post function

2021-02-04 Thread Andrew Boyer
Break it up rather than inlining it, so that we can remove branches from the hot path. Signed-off-by: Andrew Boyer --- drivers/net/ionic/ionic_dev.c | 11 -- drivers/net/ionic/ionic_dev.h | 1 - drivers/net/ionic/ionic_main.c | 10 - drivers/net/ionic/ionic_rxtx.c | 37 +++

[dpdk-dev] [PATCH 07/14] net/ionic: split up queue-completion queue structure

2021-02-04 Thread Andrew Boyer
Create a unique Q-CQ struct for adminq, notifyq, rxq, and txq to reduce the size of each object. Minimize the size of each field to squeeze into as few cachelines as possible. Signed-off-by: Andrew Boyer --- drivers/net/ionic/ionic_lif.c | 153 ++--- drivers/net/ion

[dpdk-dev] [PATCH 06/14] net/ionic: cut down queue structure

2021-02-04 Thread Andrew Boyer
This will conserve resources. Rename ionic_qcq_alloc() arg from 'base' to 'type_name' for clarity. Signed-off-by: Andrew Boyer --- drivers/net/ionic/ionic_dev.c | 14 +++--- drivers/net/ionic/ionic_dev.h | 34 ++- drivers/net/ionic/ionic_lif.c | 49 +++

[dpdk-dev] [PATCH 05/14] net/ionic: remove unused interrupt free function

2021-02-04 Thread Andrew Boyer
This will conserve resources. Signed-off-by: Andrew Boyer --- drivers/net/ionic/ionic_lif.c | 7 --- drivers/net/ionic/ionic_lif.h | 1 - 2 files changed, 8 deletions(-) diff --git a/drivers/net/ionic/ionic_lif.c b/drivers/net/ionic/ionic_lif.c index 1ca6e050ad..462a526935 100644 --- a/driv

[dpdk-dev] [PATCH 04/14] net/ionic: remove unused field from queue structure

2021-02-04 Thread Andrew Boyer
This will conserve resources. Signed-off-by: Andrew Boyer --- drivers/net/ionic/ionic_dev.c | 6 -- drivers/net/ionic/ionic_dev.h | 2 -- drivers/net/ionic/ionic_lif.c | 1 - drivers/net/ionic/ionic_rxtx.c | 9 + 4 files changed, 5 insertions(+), 13 deletions(-) diff --git a/driv

[dpdk-dev] [PATCH 03/14] net/ionic: convert info array to generic pointers

2021-02-04 Thread Andrew Boyer
Drop the callback part of the object and store only the pointers. This saves a bit of space and simplifies the code. Signed-off-by: Andrew Boyer --- drivers/net/ionic/ionic_dev.c | 8 ++-- drivers/net/ionic/ionic_dev.h | 21 +-- drivers/net/ionic/ionic_main.c | 8

[dpdk-dev] [PATCH 02/14] net/ionic: consolidate adminq code

2021-02-04 Thread Andrew Boyer
The adminq is the only caller of ionic_q_service(), so absorb it into ionic_adminq_service(). Move all of the adminq code together into ionic_main.c. Signed-off-by: Andrew Boyer --- drivers/net/ionic/ionic.h | 13 + drivers/net/ionic/ionic_dev.c | 85 -

[dpdk-dev] [PATCH 01/14] net/ionic: cut down completion queue structure

2021-02-04 Thread Andrew Boyer
Add Q_NEXT_TO_POST() and Q_NEXT_TO_SRVC() macros. Use a precomputed size mask. This will conserve resources. Signed-off-by: Andrew Boyer --- drivers/net/ionic/ionic_dev.c | 14 +++--- drivers/net/ionic/ionic_dev.h | 14 +++--- drivers/net/ionic/ionic_lif.c | 5 +++-- drivers

[dpdk-dev] [PATCH 00/14] net/ionic: struct optimizations, fixes

2021-02-04 Thread Andrew Boyer
This patch series reorganizes the main datastructure for each queue, struct ionic_qcq. Its constituent struct ionic_queue and struct ionic_cq are stripped down first. Then the generic struct ionic_qcq is stripped down, and a unique struct is created for each queue type. The adminq code is consolid

Re: [dpdk-dev] [PATCH v4 1/1] net/pcap: imissed stats support

2021-02-04 Thread Ferruh Yigit
On 2/4/2021 10:33 AM, Ido Goshen wrote: get value from pcap_stats.ps_drop (see man pcap_stats) the value is adjusted in this cases: - port stop - pcap is closed and will lose count - stats reset - pcap doesn't provide reset api - rollover - pcap counter size is u_32 only Signed-off-by: Ido

Re: [dpdk-dev] [PATCH v2 0/3] Update crypto perf script and doc

2021-02-04 Thread Akhil Goyal
> Subject: [PATCH v2 0/3] Update crypto perf script and doc > > This patchset contains some fixes for the crypto perf graphing script. > > A release note is added, and some small fixes for the script documentation > are also included. > The script config handling is modified to handle EAL and app

[dpdk-dev] [pull-request] next-eventdev 21.02-rc3

2021-02-04 Thread Jerin Jacob Kollanukkaran
The following changes since commit f6f2d22401531ba06f5a1c967853453b0cbb8a9d: devtools: fix examples build test (2021-02-02 23:58:22 +0100) are available in the Git repository at: http://dpdk.org/git/next/dpdk-next-eventdev for you to fetch changes up to b982f0ef3f58e8381fa473c2636ea4725b505

Re: [dpdk-dev] [PATCH] eventdev: remove return value comment in pmd api

2021-02-04 Thread Jerin Jacob
On Mon, Feb 1, 2021 at 6:57 PM David Marchand wrote: > > On Mon, Feb 1, 2021 at 2:20 PM Harry van Haaren > wrote: > > > > The PMD info get API has a void return type. Remove the > > @return 0 Success doxygen comment as it doesn't make sense here. > > Fixes: 5223a1f3b8de ("eventdev: define southbo

Re: [dpdk-dev] [PATCH] test/crypto: add a check in decryption with digest test case

2021-02-04 Thread Akhil Goyal
> Some platforms may not support operations on encrypted digest, > So in this patch adding a check for such test cases. > > Signed-off-by: Gagandeep Singh > --- Acked-by: Akhil Goyal Applied to dpdk-next-crypto Thanks.

Re: [dpdk-dev] [PATCH] compress/mlx5: fix assert compilation

2021-02-04 Thread Akhil Goyal
> > When ASSERT is enabled for compilation, the 2 usages of assert mechanism > > in the driver are failed due to typos. > > > > Fix the typos. > > > > Fixes: f8c97babc9f4 ("compress/mlx5: add data-path functions") > > Fixes: 37862dafcbed ("compress/mlx5: support 32-bit systems") > > > > Reported-by

Re: [dpdk-dev] [RFC PATCH v2] build: kni cross-compilation support

2021-02-04 Thread Bruce Richardson
On Thu, Feb 04, 2021 at 10:51:41AM +0100, Juraj Linkeš wrote: > The kni linux module is using a custom target for building, which > doesn't take into account any cross compilation arguments. The arguments > in question are ARCH, CROSS_COMPILE (for gcc, clang) and CC, LD (for > clang). Get those fro

Re: [dpdk-dev] [PATCH] net/mlx5: fix default CQE compression config

2021-02-04 Thread Ferruh Yigit
On 2/4/2021 4:50 PM, Raslan Darawsheh wrote: Hi, -Original Message- From: Alexander Kozyrev Sent: Thursday, February 4, 2021 6:07 PM To: dev@dpdk.org Cc: Raslan Darawsheh ; ferruh.yi...@intel.com; Slava Ovsiienko Subject: [PATCH] net/mlx5: fix default CQE compression config CQE compr

Re: [dpdk-dev] [PATCH v2] net/pcap: fix infinite Rx with large files

2021-02-04 Thread Ferruh Yigit
On 2/4/2021 5:02 PM, Ferriter, Cian wrote: The new error message looks great. As I've already given my ack, I'm happy for this to be applied. -Original Message- From: Yigit, Ferruh Sent: Thursday 4 February 2021 16:51 To: Ferriter, Cian Cc: Yigit, Ferruh ; dev@dpdk.org; sta...@dpdk.o

[dpdk-dev] [PATCH] doc: add new tables for rte flow items and actions support

2021-02-04 Thread Asaf Penso
In http://doc.dpdk.org/guides/nics/overview.html, table 1.1 lists all supported features. It has a single line for "Flow API" that refers to rte_flow support. rte_flow is composed of many items and actions that are not expressed in this single line. The following new tables are suggested: 1. rte_f

Re: [dpdk-dev] [PATCH v2] net/pcap: fix infinite Rx with large files

2021-02-04 Thread Ferriter, Cian
The new error message looks great. As I've already given my ack, I'm happy for this to be applied. > -Original Message- > From: Yigit, Ferruh > Sent: Thursday 4 February 2021 16:51 > To: Ferriter, Cian > Cc: Yigit, Ferruh ; dev@dpdk.org; sta...@dpdk.org > Subject: [PATCH v2] net/pcap: f

Re: [dpdk-dev] [PATCH] net/pcap: fix infinite Rx with large files

2021-02-04 Thread Ferriter, Cian
> -Original Message- > From: Ferruh Yigit > Sent: Thursday 4 February 2021 16:29 > To: Ferriter, Cian > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: Re: [PATCH] net/pcap: fix infinite Rx with large files > > On 2/4/2021 4:03 PM, Ferriter, Cian wrote: > > Hi Ferruh, > > > > This fixes t

Re: [dpdk-dev] [PATCH] net/mlx5: fix Tx queue size created with DevX

2021-02-04 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Viacheslav Ovsiienko > Sent: Thursday, February 4, 2021 2:04 PM > To: dev@dpdk.org > Cc: Raslan Darawsheh ; Matan Azrad > ; Ori Kam ; NBU-Contact-Thomas > Monjalon ; sta...@dpdk.org > Subject: [PATCH] net/mlx5: fix Tx queue size created with DevX > > The

[dpdk-dev] [PATCH v2] net/pcap: fix infinite Rx with large files

2021-02-04 Thread Ferruh Yigit
Packet forwarding is not working when infinite Rx feature is used with large .pcap files that has high number of packets. The problem is number of allocated mbufs are less than the infinite Rx ring size, and all mbufs consumed to fill the ring, so there is no mbuf left for forwarding. Current log

Re: [dpdk-dev] [PATCH] net/mlx5: fix default CQE compression config

2021-02-04 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Alexander Kozyrev > Sent: Thursday, February 4, 2021 6:07 PM > To: dev@dpdk.org > Cc: Raslan Darawsheh ; ferruh.yi...@intel.com; Slava > Ovsiienko > Subject: [PATCH] net/mlx5: fix default CQE compression config > > CQE compression must be enabled by defa

Re: [dpdk-dev] [PATCH] net/mlx5: fix validation of hash Rx queue pointer

2021-02-04 Thread Raslan Darawsheh
Hi, > -Original Message- > From: dev On Behalf Of Dekel Peled > Sent: Wednesday, February 3, 2021 12:09 PM > To: Matan Azrad ; Shahaf Shuler > ; Slava Ovsiienko > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: [dpdk-dev] [PATCH] net/mlx5: fix validation of hash Rx queue > pointer > > Imple

Re: [dpdk-dev] [PATCH] net/pcap: fix byte stats for drop Tx

2021-02-04 Thread Ferruh Yigit
On 2/4/2021 3:47 PM, Ferriter, Cian wrote: -Original Message- From: Yigit, Ferruh Sent: Wednesday 3 February 2021 17:30 To: Ferriter, Cian Cc: Yigit, Ferruh ; dev@dpdk.org; sta...@dpdk.org Subject: [PATCH] net/pcap: fix byte stats for drop Tx Drop Tx path in pcap is Tx that just dro

Re: [dpdk-dev] [PATCH] net/mlx5: fix check of shared RSS capability

2021-02-04 Thread Raslan Darawsheh
Hi, > -Original Message- > From: dev On Behalf Of Dekel Peled > Sent: Wednesday, February 3, 2021 12:09 PM > To: Matan Azrad ; Shahaf Shuler > ; Slava Ovsiienko > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: [dpdk-dev] [PATCH] net/mlx5: fix check of shared RSS capability > > Existing co

Re: [dpdk-dev] [dpdk-stable] [PATCH] app/testpmd: fix support for shared age action query

2021-02-04 Thread Ferruh Yigit
On 2/4/2021 10:04 AM, Dekel Peled wrote: Shared age action query was implemented as part of flow query, but was not implemented as part of shared action query. This patch adds the required implementation. Fixes: 2f622174bf86 ("app/testpmd: support query of age action") Cc: sta...@dpdk.org Sign

Re: [dpdk-dev] [PATCH] net/pcap: fix infinite Rx with large files

2021-02-04 Thread Ferruh Yigit
On 2/4/2021 4:03 PM, Ferriter, Cian wrote: Hi Ferruh, This fixes the issue I was seeing. Now an error is reported, rather than silent failure. I have one piece of feedback about the particular error message below inline which you can take or leave, I'm happy for you to upstream this fix eithe

Re: [dpdk-dev] [PATCH] net/pcap: fix byte stats for drop Tx

2021-02-04 Thread Ferriter, Cian
> -Original Message- > From: Ferriter, Cian > Sent: Thursday 4 February 2021 15:48 > To: Yigit, Ferruh > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: RE: [PATCH] net/pcap: fix byte stats for drop Tx > > > > > -Original Message- > > From: Yigit, Ferruh > > Sent: Wednesday 3 F

Re: [dpdk-dev] [PATCH] net/mlx5: fix default CQE compression config

2021-02-04 Thread Slava Ovsiienko
> -Original Message- > From: Alexander Kozyrev > Sent: Thursday, February 4, 2021 18:07 > To: dev@dpdk.org > Cc: Raslan Darawsheh ; ferruh.yi...@intel.com; Slava > Ovsiienko > Subject: [PATCH] net/mlx5: fix default CQE compression config > > CQE compression must be enabled by default unl

[dpdk-dev] [PATCH] net/mlx5: fix default CQE compression config

2021-02-04 Thread Alexander Kozyrev
CQE compression must be enabled by default unless the rxq_cqe_comp_en devarg is set to 0 or FW cannot support CQE compression for some reason. The latest commit that introduced checks for FW capabilities for new CQE zipping formats disables the CQE compression unless the devarg is 1. Revert this lo

Re: [dpdk-dev] [PATCH] net/pcap: fix infinite Rx with large files

2021-02-04 Thread Ferriter, Cian
Hi Ferruh, This fixes the issue I was seeing. Now an error is reported, rather than silent failure. I have one piece of feedback about the particular error message below inline which you can take or leave, I'm happy for you to upstream this fix either way. Acked-by: Cian Ferriter > -Orig

Re: [dpdk-dev] [PATCH] devtools: select targets in build test

2021-02-04 Thread Thomas Monjalon
04/02/2021 15:48, David Marchand: > On Thu, Feb 4, 2021 at 2:59 PM Thomas Monjalon wrote: > > > > 04/02/2021 14:34, David Marchand: > > > When a target compilation is broken, one way to skip the target is to > > > uninstall the associated toolchain. > > > But it is not always possible and you end

Re: [dpdk-dev] [PATCH] net/pcap: fix byte stats for drop Tx

2021-02-04 Thread Ferriter, Cian
> -Original Message- > From: Yigit, Ferruh > Sent: Wednesday 3 February 2021 17:30 > To: Ferriter, Cian > Cc: Yigit, Ferruh ; dev@dpdk.org; sta...@dpdk.org > Subject: [PATCH] net/pcap: fix byte stats for drop Tx > > Drop Tx path in pcap is Tx that just drops the packets, which is used

Re: [dpdk-dev] [PATCH 00/11] critical bugfixes for hns3

2021-02-04 Thread Ferruh Yigit
On 2/3/2021 12:23 PM, Lijun Ou wrote: Based on some suggestions, we reorganize the fixes and resend the only fixes. Chengchang Tang (4): net/hns3: fix stats flip overflow net/hns3: replace all atomic type with C11 atomic builtins net/hns3: fix cmdq cleared during firmware process net

[dpdk-dev] [PATCH v3] net/ixgbe: fix UDP zero checksum error

2021-02-04 Thread Haiyue Wang
There is an 82599 errata that UDP frames with a zero checksum are incorrectly marked as checksum invalid by the hardware. This was leading to misleading PKT_RX_L4_CKSUM_BAD flag. This patch changes the bad UDP checksum to PKT_RX_L4_CKSUM_UNKNOWN, so the software application will then have to reco

Re: [dpdk-dev] [PATCH] devtools: select targets in build test

2021-02-04 Thread David Marchand
On Thu, Feb 4, 2021 at 2:59 PM Thomas Monjalon wrote: > > 04/02/2021 14:34, David Marchand: > > When a target compilation is broken, one way to skip the target is to > > uninstall the associated toolchain. > > But it is not always possible and you end up with hacking the script to > > avoid this t

Re: [dpdk-dev] [PATCH] net/mlx5: fix E-Switch egress mirror flow validation

2021-02-04 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Jiawei Wang > Sent: Wednesday, February 3, 2021 10:29 AM > To: Slava Ovsiienko ; Matan Azrad > ; Ori Kam ; NBU-Contact-Thomas > Monjalon > Cc: dev@dpdk.org; Raslan Darawsheh ; > sta...@dpdk.org > Subject: [PATCH] net/mlx5: fix E-Switch egress mirror flow

[dpdk-dev] [PATCH] cryptodev: support multiple cipher block sizes

2021-02-04 Thread Matan Azrad
In cryptography, a block cipher is a deterministic algorithm operating on fixed-length groups of bits, called blocks. A block cipher consists of two paired algorithms, one for encryption and the other for decryption. Both algorithms accept two inputs: an input block of size n bits and a key of siz

Re: [dpdk-dev] [PATCH v5 0/9] ethdev: support SubFunction representor

2021-02-04 Thread Xueming(Steven) Li
>-Original Message- >From: Andrew Rybchenko >Sent: Monday, February 1, 2021 4:39 PM >To: Xueming(Steven) Li >Cc: dev@dpdk.org; Slava Ovsiienko ; Asaf Penso > >Subject: Re: [dpdk-dev] [PATCH v5 0/9] ethdev: support SubFunction representor > >On 1/28/21 5:31 PM, Xueming(Steven) Li wrote:

Re: [dpdk-dev] [PATCH v3 1/2] net/mlx5: optimize mprq memcpy

2021-02-04 Thread Slava Ovsiienko
Hi, I'm sorry for asking the questions very late. Is still this patch set actual and should it be updated and considered? As I can understand this one optimizes the memory writes in some way using the instructions with the hints. Is this specific for some CPU families? Is this more common? I su

Re: [dpdk-dev] [PATCH v2] net/ice: fix VLAN 0 adding based on VLAN mode

2021-02-04 Thread Zhang, Qi Z
> -Original Message- > From: Wang, Haiyue > Sent: Thursday, February 4, 2021 8:50 PM > To: dev@dpdk.org > Cc: Yang, Qiming ; Zhang, Qi Z > ; Wang, Haiyue ; Creeley, > Brett > Subject: [PATCH v2] net/ice: fix VLAN 0 adding based on VLAN mode > > In Single VLAN Mode, single VLAN filters

Re: [dpdk-dev] [PATCH] devtools: select targets in build test

2021-02-04 Thread Thomas Monjalon
04/02/2021 14:34, David Marchand: > When a target compilation is broken, one way to skip the target is to > uninstall the associated toolchain. > But it is not always possible and you end up with hacking the script to > avoid this target until a fix is ready. > > It is also often quicker to check

Re: [dpdk-dev] [PATCH] compress/mlx5: fix assert compilation

2021-02-04 Thread Slava Ovsiienko
> -Original Message- > From: dev On Behalf Of Matan Azrad > Sent: Thursday, February 4, 2021 11:06 > To: dev@dpdk.org > Cc: akhil.go...@nxp.com > Subject: [dpdk-dev] [PATCH] compress/mlx5: fix assert compilation > > When ASSERT is enabled for compilation, the 2 usages of assert mechanism

Re: [dpdk-dev] [PATCH v2] net/i40e: fix avx code error on MinGW

2021-02-04 Thread David Marchand
On Thu, Feb 4, 2021 at 1:36 PM Ferruh Yigit wrote: > > On 2/4/2021 10:41 AM, Zhang, Qi Z wrote: > > > > > >> -Original Message- > >> From: Dmitry Kozlyuk > >> Sent: Wednesday, February 3, 2021 7:08 AM > >> To: Rong, Leyi > >> Cc: david.march...@redhat.com; Zhang, Qi Z ; Yigit, > >> Ferru

Re: [dpdk-dev] [PATCH v2 1/2] mbuf: remove unneeded atomic header include

2021-02-04 Thread Andrew Rybchenko
On 2/4/21 1:05 PM, David Marchand wrote: > There is no need for the direct inclusion of the generic/ header [1] > now that we don't use the rte_atomic API anymore. > > 1: https://git.dpdk.org/dpdk/commit/?id=3eb860b08eb7 > > Fixes: e41d27a68df6 ("mbuf: remove atomic reference counters") > Cc: sta

[dpdk-dev] [PATCH] devtools: select targets in build test

2021-02-04 Thread David Marchand
When a target compilation is broken, one way to skip the target is to uninstall the associated toolchain. But it is not always possible and you end up with hacking the script to avoid this target until a fix is ready. It is also often quicker to check a fix on a failing target before checking comp

Re: [dpdk-dev] [PATCH] mempool: fix invalid panic on dump or audit

2021-02-04 Thread Andrew Rybchenko
On 2/3/21 12:01 PM, Olivier Matz wrote: > When doing a mempool dump or an audit, the application can panic because > the length of the cache is greater than the flush threshold, which is > seen as a fatal error. But this can temporarily happen when the mempool > is in use. > > Fix the panic condit

Re: [dpdk-dev] [PATCH] examples/vhost_crypto: remove unused short option

2021-02-04 Thread Zhang, Roy Fan
> -Original Message- > From: Ibtisam Tariq > Sent: Thursday, February 4, 2021 8:06 AM > To: maxime.coque...@redhat.com; Xia, Chenbo > Cc: dev@dpdk.org; Ibtisam Tariq ; Zhang, Roy > Fan > Subject: [PATCH] examples/vhost_crypto: remove unused short option > > Short option "s" was passed t

Re: [dpdk-dev] [PATCH] examples/vhost_crypto: remove unused short option

2021-02-04 Thread Zhang, Roy Fan
> -Original Message- > From: Ibtisam Tariq > Sent: Thursday, February 4, 2021 8:06 AM > To: maxime.coque...@redhat.com; Xia, Chenbo > Cc: dev@dpdk.org; Ibtisam Tariq ; Zhang, Roy > Fan > Subject: [PATCH] examples/vhost_crypto: remove unused short option > > Short option "s" was passed t

[dpdk-dev] [PATCH v2] net/ice: fix VLAN 0 adding based on VLAN mode

2021-02-04 Thread Haiyue Wang
In Single VLAN Mode, single VLAN filters via ICE_SW_LKUP_VLAN are based on the inner VLAN ID, so the VLAN TPID (i.e. 0x8100 or 0x888a8) doesn't matter. In Double VLAN Mode, outer/single VLAN filters via ICE_SW_LKUP_VLAN are based on the outer/single VLAN ID + VLAN TPID. For both modes, adding a V

Re: [dpdk-dev] [PATCH v2] net/i40e: fix avx code error on MinGW

2021-02-04 Thread Thomas Monjalon
04/02/2021 13:36, Ferruh Yigit: > On 2/4/2021 10:41 AM, Zhang, Qi Z wrote: > > From: Dmitry Kozlyuk > >> On Tue, 2 Feb 2021 22:32:58 +0800, Leyi Rong wrote: > >>> Adds extra cflags '-fno-asynchronous-unwind-tables' > >>> to avoid the MinGW build error: > >>> Error: invalid register for .seh_sav

Re: [dpdk-dev] [PATCH v4 2/5] examples/multi_process: cleanup bus objects while terminating app

2021-02-04 Thread David Marchand
On Mon, Jan 25, 2021 at 12:07 PM oulijun wrote: > >> +static void > >> +signal_handler(int signal) > >> +{ > >> + if (signal == SIGINT) > >> + rte_eal_cleanup(); > >> + exit(0); > >> +} > > > > Calling rte_eal_cleanup from a signal handler is a bad idea. > > In most cases

Re: [dpdk-dev] [PATCH 1/7] bus/fslmc: fix to use ci value for qbman 5.0

2021-02-04 Thread Hemant Agrawal
On 2/2/2021 5:06 PM, Ferruh Yigit wrote: On 1/20/2021 2:27 PM, Hemant Agrawal wrote: From: Youri Querry since for qbman 5.0 generally, pi == ci, no need for extra checks. They are causing issue. It would be nice to document the issues, in case users encounter them, they will know this pat

Re: [dpdk-dev] [PATCH] event/dsw: use GCC built-ins for atomics

2021-02-04 Thread Mattias Rönnblom
On 2021-02-04 13:34, Jerin Jacob wrote: > On Tue, Jan 26, 2021 at 10:07 PM Mattias Rönnblom > wrote: >> Use C11-style GCC built-in functions for atomic operations. >> >> Signed-off-by: Mattias Rönnblom >> --- >> drivers/event/dsw/dsw_evdev.c | 5 + >> drivers/event/dsw/dsw_evdev.h | 6

[dpdk-dev] [PATCH v1] net/ice: fix VLAN 0 adding based on VLAN mode

2021-02-04 Thread Haiyue Wang
In Single VLAN Mode, single VLAN filters via ICE_SW_LKUP_VLAN are based on the inner VLAN ID, so the VLAN TPID (i.e. 0x8100 or 0x888a8) doesn't matter. In Double VLAN Mode, outer/single VLAN filters via ICE_SW_LKUP_VLAN are based on the outer/single VLAN ID + VLAN TPID. For both modes, adding a V

Re: [dpdk-dev] [PATCH v2] net/i40e: fix avx code error on MinGW

2021-02-04 Thread Ferruh Yigit
On 2/4/2021 10:41 AM, Zhang, Qi Z wrote: -Original Message- From: Dmitry Kozlyuk Sent: Wednesday, February 3, 2021 7:08 AM To: Rong, Leyi Cc: david.march...@redhat.com; Zhang, Qi Z ; Yigit, Ferruh ; tho...@monjalon.net; Richardson, Bruce ; tal...@nvidia.com; Kadam, Pallavi ; Menon, R

Re: [dpdk-dev] [PATCH] event/dsw: use GCC built-ins for atomics

2021-02-04 Thread Jerin Jacob
On Tue, Jan 26, 2021 at 10:07 PM Mattias Rönnblom wrote: > > Use C11-style GCC built-in functions for atomic operations. > > Signed-off-by: Mattias Rönnblom > --- > drivers/event/dsw/dsw_evdev.c | 5 + > drivers/event/dsw/dsw_evdev.h | 6 +++--- > drivers/event/dsw/dsw_event.c | 37

Re: [dpdk-dev] 【Some Questions About Multi-Process Resource Cleaning】

2021-02-04 Thread Thomas Monjalon
04/02/2021 12:47, oulijun: > > 在 2021/2/4 17:25, Thomas Monjalon 写道: > > Hi, > > > > Sorry your questions are quite confused. > > Please start explaining what is the problem you are trying to solve. > Start the master and slave processes at the same time, and then run the > kill -9 command to kil

Re: [dpdk-dev] [PATCH] event/dlb: fix bugs due to accessing uninitialized variables

2021-02-04 Thread Jerin Jacob
On Wed, Feb 3, 2021 at 11:42 PM Timothy McDaniel wrote: > > This patch updates the PMD to initialize response fields > prior to calling into the PF layer. > > Fixes the following coverity issues: > > Fixes: eb14a3421afd ("event/dlb: add eventdev start") > Coverity issue: 366205 > > Fixes: f0073621

Re: [dpdk-dev] 【Some Questions About Multi-Process Resource Cleaning】

2021-02-04 Thread Bruce Richardson
On Thu, Feb 04, 2021 at 07:47:01PM +0800, oulijun wrote: > > > 在 2021/2/4 17:25, Thomas Monjalon 写道: > > Hi, > > > > Sorry your questions are quite confused. > > Please start explaining what is the problem you are trying to solve. > Start the master and slave processes at the same time, and then

[dpdk-dev] [PATCH v2] Fix loss of data stored in udata64 mbuf field

2021-02-04 Thread Michal Krawczyk
DPDK v20.11 removed mbuf's udata64 field, and changed type of the dynfield1 to uint32_t. Due to pktgen's define for DPDK v20.11+: lib/common/pg_compat.h:#define udata64 dynfield1[0] udata64 field was being mapped to the first entry of the dynfield1 array. Because of that, access

[dpdk-dev] DPDK Release Status Meeting 4/02/2021

2021-02-04 Thread Ferruh Yigit
Meeting minutes of 4 February 2021 -- Agenda: * Release Dates * -rc2 status * Subtrees * LTS * Bugzilla * Opens Participants: * Arm * Broadcom * Debian/Microsoft * Intel * Marvell * Nvidia * NXP * Red Hat Release Dates - * v21.02 dates * -rc2 is r

[dpdk-dev] [PATCH] net/mlx5: fix Tx queue size created with DevX

2021-02-04 Thread Viacheslav Ovsiienko
The number of descriptors specified for queue creation implies the queue should be able to contain the specified amount of packets being sent. Typically one packet takes one queue descriptor (WQE) to be handled. If there is inline data option enabled one packet might require more WQEs to embrace th

Re: [dpdk-dev] 【Some Questions About Multi-Process Resource Cleaning】

2021-02-04 Thread oulijun
在 2021/2/4 17:25, Thomas Monjalon 写道: Hi, Sorry your questions are quite confused. Please start explaining what is the problem you are trying to solve. Start the master and slave processes at the same time, and then run the kill -9 command to kill the slave processes. The slave process shoul

Re: [dpdk-dev] [PATCH] config: increase default maximum number of NUMA nodes

2021-02-04 Thread Jerin Jacob
On Thu, Feb 4, 2021 at 3:58 PM Thomas Monjalon wrote: > > 04/02/2021 07:19, Jerin Jacob: > > On Thu, Feb 4, 2021 at 2:49 AM Thomas Monjalon wrote: > > > > > > AMD CPU can present a high number of NUMA nodes. > > > The default should be 32 for better compatibility. > > > > The typical configuratio

  1   2   >