Re: [dpdk-dev] [PATCH v3 1/1] net/pcap: imissed stats support

2021-02-03 Thread Ido Goshen
> -Original Message- > From: Ferruh Yigit > Sent: Thursday, 4 February 2021 2:13 > To: Ido Goshen > Cc: dev@dpdk.org > Subject: Re: [PATCH v3 1/1] net/pcap: imissed stats support > > On 2/3/2021 11:07 PM, Ido Goshen wrote: > > get value from pcap_stats.ps_drop (see man pcap_stats) the

Re: [dpdk-dev] [PATCH v2] net/ixgbe: fix UDP zero checksum error

2021-02-03 Thread Zhang, Qi Z
> -Original Message- > From: David Marchand > Sent: Wednesday, February 3, 2021 4:32 PM > To: Zhang, Qi Z > Cc: Wang, Haiyue ; dev@dpdk.org; > pvale...@redhat.com; acon...@redhat.com; Rong, Leyi > ; Tu, Lijuan ; > ruifeng.w...@arm.com; feifei.wa...@arm.com; sta...@dpdk.org; Guo, Jia > ;

[dpdk-dev] [PATCH v4 7/7] examples/vhost_crypto: enhance getopt_long usage

2021-02-03 Thread Ibtisam Tariq
Instead of using getopt_long return value, strcmp was used to compare the input parameters with the struct option array. This patch get rid of all those strcmp by directly binding each longopt with an int enum. This is to improve readability and consistency in all examples. Bugzilla ID: 238 Cc: ro

[dpdk-dev] [PATCH v4 6/7] examples/vhost: enhance getopt_long usage

2021-02-03 Thread Ibtisam Tariq
Instead of using getopt_long return value, strcmp was used to compare the input parameters with the struct option array. This patch get rid of all those strcmp by directly binding each longopt with an int enum. This is to improve readability and consistency in all examples. Bugzilla ID: 238 Cc: ji

[dpdk-dev] [PATCH v4 5/7] examples/qos_sched: enhance getopt_long usage

2021-02-03 Thread Ibtisam Tariq
Instead of using getopt_long return value, strcmp was used to compare the input parameters with the struct option array. This patch get rid of all those strcmp by directly binding each longopt with an int enum. This is to improve readability and consistency in all examples. Bugzilla ID: 238 Cc: st

[dpdk-dev] [PATCH v4 4/7] examples/performance-thread/l3fwd-thread: enhance getopt_long usage

2021-02-03 Thread Ibtisam Tariq
Instead of using getopt_long return value, strcmp was used to compare the input parameters with the struct option array. This patch get rid of all those strcmp by directly binding each longopt with an int enum. This is to improve readability and consistency in all examples. Bugzilla ID: 238 Cc: ia

[dpdk-dev] [PATCH v4 3/7] examples/packet_ordering: enhance getopt_long usage

2021-02-03 Thread Ibtisam Tariq
Instead of using getopt_long return value, strcmp was used to compare the input parameters with the struct option array. This patch get rid of all those strcmp by directly binding each longopt with an int enum. This is to improve readability and consistency in all examples. Bugzilla ID: 238 Cc: se

[dpdk-dev] [PATCH v4 2/7] examples/l3fwd-acl: enhance getopt_long usage

2021-02-03 Thread Ibtisam Tariq
Instead of using getopt_long return value, strcmp was used to compare the input parameters with the struct option array. This patch get rid of all those strcmp by directly binding each longopt with an int enum. This is to improve readability and consistency in all examples. Bugzilla ID: 238 Cc: ko

[dpdk-dev] [PATCH v4 1/7] examples/fips_validation: enhance getopt_long usage

2021-02-03 Thread Ibtisam Tariq
Instead of using getopt_long return value, strcmp was used to compare the input parameters with the struct option array. This patch get rid of all those strcmp by directly binding each longopt with an int enum. This is to improve readability and consistency in all examples. Bugzilla ID: 238 Cc: ma

Re: [dpdk-dev] [PATCH] net/iavf: fix VLAN insert issue

2021-02-03 Thread Xing, Beilei
> -Original Message- > From: Li, Xiaoyun > Sent: Thursday, February 4, 2021 11:11 AM > To: Wu, Jingjing ; Xing, Beilei > ; > dev@dpdk.org > Cc: Li, Xiaoyun > Subject: [PATCH] net/iavf: fix VLAN insert issue > > The new VIRTCHNL_VF_OFFLOAD_VLAN_V2 capability allows PF to set the > loc

[dpdk-dev] 【Some Questions About Multi-Process Resource Cleaning】

2021-02-03 Thread oulijun
Hi, Thomas Monjalon&Ferruh Yigit and others I'm analyzing multiprocess with eal. I have some questions I'd like to ask you. Firstly, After the rte_eal_init() command is executed, the master and slave processes are started successfully. and traffic is continuously sent using the tester.I

Re: [dpdk-dev] [PATCH] net/iavf: fix VLAN insert issue

2021-02-03 Thread Li, Xiaoyun
> -Original Message- > From: Xing, Beilei > Sent: Thursday, February 4, 2021 14:36 > To: Li, Xiaoyun ; Wu, Jingjing ; > dev@dpdk.org > Subject: RE: [PATCH] net/iavf: fix VLAN insert issue > > > > > -Original Message- > > From: Li, Xiaoyun > > Sent: Thursday, February 4, 2021

Re: [dpdk-dev] [PATCH] net/iavf: fix VLAN insert issue

2021-02-03 Thread Xing, Beilei
> -Original Message- > From: Li, Xiaoyun > Sent: Thursday, February 4, 2021 11:11 AM > To: Wu, Jingjing ; Xing, Beilei > ; > dev@dpdk.org > Cc: Li, Xiaoyun > Subject: [PATCH] net/iavf: fix VLAN insert issue > > The new VIRTCHNL_VF_OFFLOAD_VLAN_V2 capability allows PF to set the > loc

Re: [dpdk-dev] [PATCH] config: increase default maximum number of NUMA nodes

2021-02-03 Thread Jerin Jacob
On Thu, Feb 4, 2021 at 2:49 AM Thomas Monjalon wrote: > > AMD CPU can present a high number of NUMA nodes. > The default should be 32 for better compatibility. The typical configuration is 4 nodes[1] for AMD. Just wondering, Is it an exception case? if so, Do we need to consume more memory for no

[dpdk-dev] [PATCH v1] net/ice: fix QinQ switch rule input set mask

2021-02-03 Thread Yuying Zhang
QinQ switch rule doesn't support ethertype field match. QinQ ethertype pattern should not be created. Change the input set mask to fix the issue. Fixes: bb3386f348dd ("net/ice: enable QinQ filter for switch") Signed-off-by: Yuying Zhang --- drivers/net/ice/ice_switch_filter.c | 3 ++- 1 file ch

Re: [dpdk-dev] [dpdk-announce] release candidate 21.02-rc2

2021-02-03 Thread Jiang, YuX
All, Update the test status for Intel part. Till now 95% is executed and no critical issue blocked the test. # Basic Intel(R) NIC testing * PF/VF(i40e,ixgbe and igb): Done. 1 issue is found but not are big issue. * PF/VF(ICE): Done. 3 issues are found regarding vf_vlan_strip and mac_vlan_ppp

[dpdk-dev] [PATCH] test/crypto: add a check in decryption with digest test case

2021-02-03 Thread Gagandeep Singh
Some platforms may not support operations on encrypted digest, So in this patch adding a check for such test cases. Signed-off-by: Gagandeep Singh --- app/test/test_cryptodev.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c i

Re: [dpdk-dev] [PATCH v2] net/ice: fix VLAN strip show in double VLAN mode

2021-02-03 Thread Yang, Qiming
Acked-by: Qiming Yang > -Original Message- > From: Wang, Haiyue > Sent: Thursday, February 4, 2021 10:04 > To: dev@dpdk.org > Cc: Yang, Qiming ; Zhang, Qi Z > ; Wang, Haiyue ; Creeley, > Brett > Subject: [PATCH v2] net/ice: fix VLAN strip show in double VLAN mode > > In double VLAN mod

[dpdk-dev] [PATCH] net/iavf: fix VLAN insert issue

2021-02-03 Thread Xiaoyun Li
The new VIRTCHNL_VF_OFFLOAD_VLAN_V2 capability allows PF to set the location of TX VLAN insertion. So VF needs to insert VLAN tag according to the location flags. Fixes: 1c301e8c3cff ("net/iavf: support new VLAN capabilities") Signed-off-by: Xiaoyun Li --- drivers/net/iavf/iavf_rxtx.c | 45 +++

Re: [dpdk-dev] [PATCH v6 0/2] support both PIO and MMIO BAR for legacy device in virtio PMD

2021-02-03 Thread 谢华伟(此时此刻)
On 2021/2/3 17:37, Maxime Coquelin wrote: Hi Huawei, On 2/1/21 8:43 AM, 谢华伟(此时此刻) wrote: On 2021/1/29 11:25, chris wrote: Hi ferruh and maxime: v6 changes: send v6. Let us discuss if merge in this or early next release. Ping. The -rc2 was released on the 29th, so I think it is too late f

[dpdk-dev] [PATCH v2] net/ice: fix VLAN strip show in double VLAN mode

2021-02-03 Thread Haiyue Wang
In double VLAN mode, the VLAN strip is applied on outer, since the VLAN filter is outer; in single VLAN mode, the VLAN strip is applied on inner for the VLAN filter is inner. So it needs to adjust the strip setting according to current VLAN mode. Fixes: 14e7a4b37b4f ("net/ice/base: support config

Re: [dpdk-dev] [PATCH v3 1/1] net/pcap: imissed stats support

2021-02-03 Thread Ferruh Yigit
On 2/3/2021 11:07 PM, Ido Goshen wrote: get value from pcap_stats.ps_drop (see man pcap_stats) the value is adjusted in this cases: - port stop - pcap is closed and will lose count - stats reset - pcap doesn't provide reset api - rollover - pcap counter size is u_32 only Signed-off-by: Ido

[dpdk-dev] [PATCH v3 1/1] net/pcap: imissed stats support

2021-02-03 Thread Ido Goshen
get value from pcap_stats.ps_drop (see man pcap_stats) the value is adjusted in this cases: - port stop - pcap is closed and will lose count - stats reset - pcap doesn't provide reset api - rollover - pcap counter size is u_32 only Signed-off-by: Ido Goshen --- v3: * code cleanup by dedicated

[dpdk-dev] [PATCH] eal/ppc: add ppc specific TSC frequency value

2021-02-03 Thread David Christensen
Return a PPC specific value for get_tsc_freq_arch() rather than depending on the EAL framework to estimate the frequency. Signed-off-by: David Christensen --- lib/librte_eal/ppc/rte_cycles.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/librte_eal/ppc/rte_cycles.c b/l

[dpdk-dev] [PATCH] config: increase default maximum number of NUMA nodes

2021-02-03 Thread Thomas Monjalon
AMD CPU can present a high number of NUMA nodes. The default should be 32 for better compatibility. Signed-off-by: Thomas Monjalon --- meson_options.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meson_options.txt b/meson_options.txt index 5c382487da..6eff62e47d 100644 -

[dpdk-dev] [PATCH v3 1/1] ethdev: refine doxygen comment of UDP tunnel API

2021-02-03 Thread Thomas Monjalon
From: Qi Zhang Clarify what is the scope and impact of the UDP port tunnel API. There are still missing infos to be improved in future: - no capability flag - dependency between ports of the same device - required privilege Signed-off-by: Qi Zhang Signed-off-by: Thomas

[dpdk-dev] [PATCH] event/dlb: fix bugs due to accessing uninitialized variables

2021-02-03 Thread Timothy McDaniel
This patch updates the PMD to initialize response fields prior to calling into the PF layer. Fixes the following coverity issues: Fixes: eb14a3421afd ("event/dlb: add eventdev start") Coverity issue: 366205 Fixes: f0073621940c ("event/dlb: add eventdev stop and close") Coverity issue: 366202 Fi

[dpdk-dev] [PATCH] event/dlb: fix bugs due to accessing unitialized variables

2021-02-03 Thread Timothy McDaniel
This patch updates the PMD to initialize response fields prior to calling into the PF layer. Fixes the following coverity issues: Fixes: eb14a3421afd ("event/dlb: add eventdev start") Coverity issue: 366205 Fixes: f0073621940c ("event/dlb: add eventdev stop and close") Coverity issue: 366202 Fi

[dpdk-dev] [PATCH] net/pcap: fix byte stats for drop Tx

2021-02-03 Thread Ferruh Yigit
Drop Tx path in pcap is Tx that just drops the packets, which is used for the case only Rx from a pcap file is requested/matters. The byte stats was calculated using first mbuf segment, which gives wrong values for multi segmented mbufs, updated to use packet length instead. Bugzilla ID: 597 Fixe

Re: [dpdk-dev] [PATCH v2] vhost: fix vid allocation race

2021-02-03 Thread Maxime Coquelin
On 2/1/21 9:48 AM, Peng He wrote: > vhost_new_device might be called in different threads at the same time. > thread 1(config thread) > rte_vhost_driver_start >->vhost_user_start_client >->vhost_user_add_connection > -> vhost_n

Re: [dpdk-dev] [PATCH v3] examples/vhost: remove async inflight packet counter

2021-02-03 Thread Maxime Coquelin
On 2/3/21 5:27 PM, Maxime Coquelin wrote: > > > On 2/2/21 7:17 AM, Cheng Jiang wrote: >> Remove async inflight packet counter since there is no need to keep >> tracking it. Increase MAX_ENQUEUED_SIZE to prevent packet segment number >> tracking ring from being exhausted. >> >> Fixes: a68ba8e0a

Re: [dpdk-dev] [PATCH v2] examples/vhost: fix potentially overflowing expression

2021-02-03 Thread Maxime Coquelin
On 2/2/21 8:24 AM, Cheng Jiang wrote: > |Change the type of buff_idx from uint64_t to uint32_t to fix coverity > issue. Coverity issue: 366264 Fixes: a68ba8e0a6b6 ("examples/vhost: > refactor vhost data path") Signed-off-by: Cheng Jiang > --- v2: fixed the format of git log > examples/vhost/mai

Re: [dpdk-dev] [PATCH v2] examples/vhost: add error propagation in ioat ops

2021-02-03 Thread Maxime Coquelin
On 2/3/21 3:29 PM, Cheng Jiang wrote: > |It makes more sense to add error propagation for > rte_ioat_completed_ops. And change the type of dev_id from int to > uint16_t. Signed-off-by: Cheng Jiang --- v2: > mentioned dev_id type changes in git log examples/vhost/ioat.c | 14 > ++ 1 f

Re: [dpdk-dev] [PATCH] net/virtio: fix secondary process crash with PCI devices

2021-02-03 Thread Maxime Coquelin
On 2/3/21 4:58 PM, Maxime Coquelin wrote: > The Virtio rework series mistakenly moved the rte_pci_device > pointer to struct virtio_hw, which is shared between the two > processes. But this structure is per-process, so this change > made secondary process to try accessing primary process-only >

Re: [dpdk-dev] [PATCH] net/virtio: fix secondary process crash with PCI devices

2021-02-03 Thread David Marchand
On Wed, Feb 3, 2021 at 4:58 PM Maxime Coquelin wrote: > > The Virtio rework series mistakenly moved the rte_pci_device > pointer to struct virtio_hw, which is shared between the two > processes. But this structure is per-process, so this change > made secondary process to try accessing primary pro

Re: [dpdk-dev] [PATCH] event/dlb: fix bug accessing unitialized variable

2021-02-03 Thread Jerin Jacob
On Wed, Feb 3, 2021 at 10:26 PM Timothy McDaniel wrote: > Please add a comment and also squash the similar patches. > Fixes: eb14a3421afd ("event/dlb: add eventdev start") > Coverity issue: 366205 > > Signed-off-by: Timothy McDaniel > --- > drivers/event/dlb/dlb.c |2 +- > 1 file changed,

[dpdk-dev] [PATCH] event/dlb: fix bug accessing unitialized variable

2021-02-03 Thread Timothy McDaniel
Fixes: eb14a3421afd ("event/dlb: add eventdev start") Coverity issue: 366205 Signed-off-by: Timothy McDaniel --- drivers/event/dlb/dlb.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/event/dlb/dlb.c b/drivers/event/dlb/dlb.c index 64e6df7..b580dc9 100644 --- a/dr

[dpdk-dev] [PATCH] event/dlb: fix bug accessing unitialized variable

2021-02-03 Thread Timothy McDaniel
Fixes: f0073621940c ("event/dlb: add eventdev stop and close") Coverity issue: 366202 Signed-off-by: Timothy McDaniel --- drivers/event/dlb/dlb.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/event/dlb/dlb.c b/drivers/event/dlb/dlb.c index b580dc9..fd03f87 100644

[dpdk-dev] [PATCH] event/dlb: fix bug accessing unitialized variable

2021-02-03 Thread Timothy McDaniel
Fixes: f0073621940c ("event/dlb: add eventdev stop and close") Coverity issue: 366200 Signed-off-by: Timothy McDaniel --- drivers/event/dlb/dlb.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/event/dlb/dlb.c b/drivers/event/dlb/dlb.c index fd03f87..8b26d1d 100644

Re: [dpdk-dev] [PATCH v2] vhost: avoid iotlb mempool allocation while IOMMU disabled

2021-02-03 Thread Maxime Coquelin
Hi, On 2/2/21 9:38 AM, Wan Junjie wrote: > If vhost device's IOMMU feature is disabled, iotlb mempool allocation > is unnecessary. > > Reported-by: Peng He > Signed-off-by: Wan Junjie Welcome to the community, looking forward for more contributions! > Reviewed-by: Zhihong Wang And welcome b

Re: [dpdk-dev] [PATCH v2] examples/vhost: add error propagation in ioat ops

2021-02-03 Thread Maxime Coquelin
On 2/3/21 3:29 PM, Cheng Jiang wrote: > It makes more sense to add error propagation for rte_ioat_completed_ops. > And change the type of dev_id from int to uint16_t. I would reword it to: " This patch adds add error propagation for rte_ioat_completed_ops call, and also changes dev_id type fro

Re: [dpdk-dev] [PATCH v3] examples/vhost: remove async inflight packet counter

2021-02-03 Thread Maxime Coquelin
On 2/2/21 7:17 AM, Cheng Jiang wrote: > Remove async inflight packet counter since there is no need to keep > tracking it. Increase MAX_ENQUEUED_SIZE to prevent packet segment number > tracking ring from being exhausted. > > Fixes: a68ba8e0a6b6 ("examples/vhost: refactor vhost data path") > >

Re: [dpdk-dev] [PATCH v1 1/2] app/test: remove unnecessary barriers for ring stress test

2021-02-03 Thread Honnappa Nagarahalli
> > Hi Feifei, > > > > > Hi, Honnappa, Konstantin and Stephen > > > > Thanks very much for your attention of this patch. Based on your > > opinion, Ruifeng and I discuss about this and make a summary: > > > __ > > > __

[dpdk-dev] [PATCH] net/virtio: fix secondary process crash with PCI devices

2021-02-03 Thread Maxime Coquelin
The Virtio rework series mistakenly moved the rte_pci_device pointer to struct virtio_hw, which is shared between the two processes. But this structure is per-process, so this change made secondary process to try accessing primary process-only memory, leading to a crash This patch reverts to prope

Re: [dpdk-dev] [PATCH 1/1] doc: explain steps for improved code spell checking

2021-02-03 Thread Thomas Monjalon
03/02/2021 14:59, Bruce Richardson: > On Wed, Feb 03, 2021 at 01:53:58PM +0100, Thomas Monjalon wrote: > > 03/02/2021 13:18, Bruce Richardson: > > > On Wed, Feb 03, 2021 at 11:30:57AM +0100, Thomas Monjalon wrote: > > > > - > > > > https://raw.githubusercontent.com/codespell-project/codespell/ma

[dpdk-dev] [PATCH] net/pcap: fix infinite Rx with large files

2021-02-03 Thread Ferruh Yigit
Packet forwarding is not working when infinite Rx feature is used with large .pcap files that has high number of packets. The problem is number of allocated mbufs are less than the infinite Rx ring size, and all mbufs consumed to fill the ring, so there is no mbuf left for forwarding. Current log

[dpdk-dev] [PATCH v2] examples/vhost: add error propagation in ioat ops

2021-02-03 Thread Cheng Jiang
It makes more sense to add error propagation for rte_ioat_completed_ops. And change the type of dev_id from int to uint16_t. Signed-off-by: Cheng Jiang --- v2: mentioned dev_id type changes in git log examples/vhost/ioat.c | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) d

Re: [dpdk-dev] [PATCH v3] common/mlx5: fix storing the synched MAC to internal table

2021-02-03 Thread Raslan Darawsheh
> -Original Message- > From: Slava Ovsiienko > Sent: Wednesday, February 3, 2021 4:15 PM > To: Dey, Souvik ; Raslan Darawsheh > ; Matan Azrad > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: RE: [PATCH v3] common/mlx5: fix storing the synched MAC to > internal table > > > back again, do yo

Re: [dpdk-dev] [PATCH v3] examples/vhost: remove async inflight packet counter

2021-02-03 Thread Jiang, Cheng1
> -Original Message- > From: Maxime Coquelin > Sent: Wednesday, February 3, 2021 10:21 PM > To: Jiang, Cheng1 ; Xia, Chenbo > > Cc: dev@dpdk.org; Hu, Jiayu ; Yang, YvonneX > ; Wang, Yinan > Subject: Re: [PATCH v3] examples/vhost: remove async inflight packet > counter > > > > On 2/3

Re: [dpdk-dev] [PATCH] net/mlx5: fix validation for counter and age

2021-02-03 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Jiawei Wang > Sent: Tuesday, February 2, 2021 6:43 PM > To: Matan Azrad ; Slava Ovsiienko > ; Ori Kam ; NBU-Contact- > Thomas Monjalon > Cc: dev@dpdk.org; Raslan Darawsheh ; > sta...@dpdk.org > Subject: [PATCH] net/mlx5: fix validation for counter and age

Re: [dpdk-dev] [PATCH] doc: fix supported feature table in mlx5 guide

2021-02-03 Thread Raslan Darawsheh
> -Original Message- > From: Slava Ovsiienko > Sent: Wednesday, February 3, 2021 4:25 PM > To: Raslan Darawsheh ; dev@dpdk.org > Cc: NBU-Contact-Thomas Monjalon ; Asaf Penso > ; carsten.andr...@tu-ilmenau.de; sta...@dpdk.org > Subject: RE: [PATCH] doc: fix supported feature table in mlx5 g

Re: [dpdk-dev] [PATCH] doc: fix supported feature table in mlx5 guide

2021-02-03 Thread Slava Ovsiienko
> -Original Message- > From: Raslan Darawsheh > Sent: Wednesday, February 3, 2021 16:19 > To: Slava Ovsiienko ; dev@dpdk.org > Cc: NBU-Contact-Thomas Monjalon ; Asaf Penso > ; carsten.andr...@tu-ilmenau.de; sta...@dpdk.org > Subject: RE: [PATCH] doc: fix supported feature table in mlx5 gui

Re: [dpdk-dev] [PATCH v3] examples/vhost: remove async inflight packet counter

2021-02-03 Thread Maxime Coquelin
On 2/3/21 2:42 PM, Jiang, Cheng1 wrote: > > >> -Original Message- >> From: Maxime Coquelin >> Sent: Wednesday, February 3, 2021 8:55 PM >> To: Jiang, Cheng1 ; Xia, Chenbo >> >> Cc: dev@dpdk.org; Hu, Jiayu ; Yang, YvonneX >> ; Wang, Yinan >> Subject: Re: [PATCH v3] examples/vhost: re

[dpdk-dev] [PATCH v1] net/ice: update VLAN strip set in double VLAN mode

2021-02-03 Thread Haiyue Wang
Since commit 14e7a4b37b4f ("net/ice/base: support configuring device in double VLAN mode"), the VLAN strip design is changed, double VLAN mode is not enabled by updating the VSI setting, it depends on the DDP and FW running support. Also, in double VLAN mode, the VLAN strip is applied on outer, si

Re: [dpdk-dev] [PATCH] doc: fix supported feature table in mlx5 guide

2021-02-03 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Viacheslav Ovsiienko > Sent: Tuesday, February 2, 2021 4:28 PM > To: dev@dpdk.org > Cc: Raslan Darawsheh ; NBU-Contact-Thomas > Monjalon ; Asaf Penso ; > carsten.andr...@tu-ilmenau.de; sta...@dpdk.org > Subject: [PATCH] doc: fix supported feature table in

Re: [dpdk-dev] [PATCH v3] common/mlx5: fix storing the synched MAC to internal table

2021-02-03 Thread Slava Ovsiienko
> back again, do you suggest me to submit v4 with with corrected quota > character or its ok to have the v3 of the patch itself as you have already > acked ? OK, let's ask Raslan to fix this minor issue while integrating the patch. Raslan, could you, please, fix the quota character in the commit m

[dpdk-dev] [PATCH v16 3/3] config: fix Arm implementer and its SoCs

2021-02-03 Thread Juraj Linkeš
Fix the implementer and part number of DPAA and ARMADA SoCs. The current values of 16 cores and 1 NUMA node don't cover all SoCs from the Arm implementer, e.g. Taishan 2280 has 64 cores and 4 NUMA nodes. Increase these to 64 and 4 to widen the coverage. Add configuration to SoC options where smalle

[dpdk-dev] [PATCH v16 2/3] build: add 'platform' meson option and Arm SoC config

2021-02-03 Thread Juraj Linkeš
Add Arm SoC configuration sets to Arm meson.build and add an arch agnostic meson option, 'platform', to select from these SoC configurations for meson native builds. This is preferable to specifying a cross file when doing aarch64 -> aarch64 builds, since the cross file specifies the toolchain as w

[dpdk-dev] [PATCH v16 1/3] build: disable/enable drivers in Arm builds

2021-02-03 Thread Juraj Linkeš
Add support for enabling or disabling drivers for Arm cross build. Do not implement any enable/disable lists yet. Enabling drivers is useful when building for an SoC where we only want to build a few drivers. That way the list won't be too long. Similarly, disabling drivers is useful when we want

[dpdk-dev] [PATCH v16 0/3] Arm build options rework

2021-02-03 Thread Juraj Linkeš
The current way of specifying Arm configuration options is insufficient since we can't identify the SoC we're building for from the MIDR information. For example, we can't distinguish between N1SDP, Graviton2 or Ampere Altra. We also want to be able to enable/disable which drivers are built withou

Re: [dpdk-dev] [PATCH 1/1] doc: explain steps for improved code spell checking

2021-02-03 Thread Bruce Richardson
On Wed, Feb 03, 2021 at 01:53:58PM +0100, Thomas Monjalon wrote: > 03/02/2021 13:18, Bruce Richardson: > > On Wed, Feb 03, 2021 at 11:30:57AM +0100, Thomas Monjalon wrote: > > > - > > > https://raw.githubusercontent.com/codespell-project/codespell/master/codespell_lib/data/dictionary.txt > > > +

Re: [dpdk-dev] [PATCH v3] examples/vhost: remove async inflight packet counter

2021-02-03 Thread Jiang, Cheng1
> -Original Message- > From: Maxime Coquelin > Sent: Wednesday, February 3, 2021 8:55 PM > To: Jiang, Cheng1 ; Xia, Chenbo > > Cc: dev@dpdk.org; Hu, Jiayu ; Yang, YvonneX > ; Wang, Yinan > Subject: Re: [PATCH v3] examples/vhost: remove async inflight packet > counter > > > > On 2/3/

[dpdk-dev] [Bug 634] i40e: rte_flow doesn't allow RSS action on IPV4 only

2021-02-03 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=634 Bug ID: 634 Summary: i40e: rte_flow doesn't allow RSS action on IPV4 only Product: DPDK Version: 20.11 Hardware: x86 OS: Linux Status: UNCONFIRMED Severity: normal

Re: [dpdk-dev] [PATCH] examples/vhost: add error propagation in ioat ops

2021-02-03 Thread Jiang, Cheng1
> -Original Message- > From: Maxime Coquelin > Sent: Wednesday, February 3, 2021 8:49 PM > To: Jiang, Cheng1 ; Xia, Chenbo > > Cc: dev@dpdk.org; Hu, Jiayu ; Yang, YvonneX > ; Wang, Yinan > Subject: Re: [PATCH] examples/vhost: add error propagation in ioat ops > > > > On 2/3/21 12:52

[dpdk-dev] [Bug 633] Secondary process crash with virtio PMD

2021-02-03 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=633 Bug ID: 633 Summary: Secondary process crash with virtio PMD Product: DPDK Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: normal

Re: [dpdk-dev] [PATCH v3] examples/vhost: remove async inflight packet counter

2021-02-03 Thread Maxime Coquelin
On 2/3/21 1:11 PM, Jiang, Cheng1 wrote: > Hi, > >> -Original Message- >> From: Maxime Coquelin >> Sent: Wednesday, February 3, 2021 5:52 PM >> To: Jiang, Cheng1 ; Xia, Chenbo >> >> Cc: dev@dpdk.org; Hu, Jiayu ; Yang, YvonneX >> ; Wang, Yinan >> Subject: Re: [PATCH v3] examples/vhost:

Re: [dpdk-dev] [PATCH 1/1] doc: explain steps for improved code spell checking

2021-02-03 Thread Thomas Monjalon
03/02/2021 13:18, Bruce Richardson: > On Wed, Feb 03, 2021 at 11:30:57AM +0100, Thomas Monjalon wrote: > > - > > https://raw.githubusercontent.com/codespell-project/codespell/master/codespell_lib/data/dictionary.txt > > + git clone https://github.com/codespell-project/codespell.git > > > >

Re: [dpdk-dev] [PATCH] examples/vhost: add error propagation in ioat ops

2021-02-03 Thread Maxime Coquelin
On 2/3/21 12:52 PM, Jiang, Cheng1 wrote: > Hi, > >> -Original Message- >> From: Maxime Coquelin >> Sent: Wednesday, February 3, 2021 5:49 PM >> To: Jiang, Cheng1 ; Xia, Chenbo >> >> Cc: dev@dpdk.org; Hu, Jiayu ; Yang, YvonneX >> ; Wang, Yinan >> Subject: Re: [PATCH] examples/vhost: a

[dpdk-dev] [PATCH 0/2] meson build fixes for hns3

2021-02-03 Thread Lijun Ou
This series fix meson build for kunpeng920 and kunpeng930 boards. Chengchang Tang (2): config/arm: fix Hisilicon kunpeng920 SoC build config/arm: fix Hisilicon kunpeng930 Soc build config/arm/arm64_kunpeng920_linux_gcc | 19 +++ config/arm/arm64_kunpeng930_linux_gcc

[dpdk-dev] [PATCH 1/2] config/arm: fix Hisilicon kunpeng920 SoC build

2021-02-03 Thread Lijun Ou
From: Chengchang Tang Because of the '9ca2f16' have merged, the current hns3 pmd driver can not be directly complied on the kunpeng920 server board. Therefore, we need to fix the meson build. Besides, add kunpeng 920 SoC meson cross compile target. Fixes: 9ca2f16faa7f ("config/arm: isolate gener

[dpdk-dev] [PATCH 2/2] config/arm: fix Hisilicon kunpeng930 Soc build

2021-02-03 Thread Lijun Ou
From: Chengchang Tang Because of the '9ca2f16' have merged, the current hns3 pmd driver can not be directly complied on the kunpeng930 FPGA board. Therefore, we need to fix the meson build. Besides, add kunpeng 930 SoC meson cross compile target. Fixes: 9ca2f16faa7f ("config/arm: isolate generic

[dpdk-dev] [PATCH 07/11] net/hns3: replace all atomic type with C11 atomic builtins

2021-02-03 Thread Lijun Ou
From: Chengchang Tang Replace all the atomic type with C11 atomic builtins in hns3 PMD. Signed-off-by: Chengchang Tang Signed-off-by: Lijun Ou --- drivers/net/hns3/hns3_cmd.c | 13 +++-- drivers/net/hns3/hns3_ethdev.c| 21 - drivers/net/hns3/hns3_ethdev.h

[dpdk-dev] [PATCH 08/11] net/hns3: fix FD rule residue in hardware when malloc fail

2021-02-03 Thread Lijun Ou
From: Chengwen Feng After FD rule config success, driver will malloc fdir_rule to hold the rule info, if malloc fail the FD rule in hardware was not cleanup. Fixes: fcba820d9b9e ("net/hns3: support flow director") Cc: sta...@dpdk.org Signed-off-by: Chengwen Feng Signed-off-by: Lijun Ou --- d

[dpdk-dev] [PATCH 09/11] net/hns3: fix cmdq cleared during firmware process

2021-02-03 Thread Lijun Ou
From: Chengchang Tang There are two scenarios that command queue uninit performed concurrently with the firmware command: asynchronous command and timeout command. For asynchronous command, if a large number of functions send commands, these commands may need to be queued to wait for firmware pr

[dpdk-dev] [PATCH 05/11] net/hns3: remove MPLS type from supported flow items

2021-02-03 Thread Lijun Ou
From: Chengwen Feng The Kunpeng920 and Kunpeng930 don't support parse MPLS packet, so remove the type from supported flow items. Fixes: fcba820d9b9e ("net/hns3: support flow director") Cc: sta...@dpdk.org Signed-off-by: Chengwen Feng Signed-off-by: Lijun Ou --- drivers/net/hns3/hns3_flow.c |

[dpdk-dev] [PATCH 04/11] net/hns3: constraint TM peak rate

2021-02-03 Thread Lijun Ou
From: Chengwen Feng User could config Port or TC's peak rate by TM ops, but hardware does not support peak rate which lower than 1Mbps. So we constraint tm peak rate must be at least 1Mbps. Fixes: c09c7847d892 ("net/hns3: support traffic management") Signed-off-by: Chengwen Feng Signed-off-by:

[dpdk-dev] [PATCH 10/11] net/hns3: fix VF reset after MBX failed

2021-02-03 Thread Lijun Ou
From: Chengchang Tang Currently, during the VF reset, the VF will send a MBX to inform PF to reset it and the disable command bit will be set whether the MBX is successful. Generally, multiple reset attempts are made after a failure. However, because the command is disabled, all subsequent reset

[dpdk-dev] [PATCH 06/11] net/hns3: fix stats flip overflow

2021-02-03 Thread Lijun Ou
From: Chengchang Tang Currently, statistics may overflow in some scenarios. For example, if HW statistics are reset by stats reset operation, but there are still a lot of residual packets exist in the HW queues and these packets are error packets, flip may occurred because the ipacket is obtaine

[dpdk-dev] [PATCH 11/11] net/hns3: add check for max pkt length of Rx

2021-02-03 Thread Lijun Ou
From: Huisong Li When jumbo frame is enabled, the MTU size needs to be modified based on 'max_rx_pkt_len'. Driver needs to check the validity of 'max_rx_pkt_len'. And it should be in the range of HNS3_DEFAULT_FRAME_LEN and HNS3_MAX_FRAME_LEN. Otherwise, it may cause that the MTU size is inconsist

[dpdk-dev] [PATCH 02/11] net/hns3: fix link status change from firmware

2021-02-03 Thread Lijun Ou
From: Huisong Li When the hardware link status changes, the firmware proactively reports the link status change message, and then driver update link status. This feature is lack of a switch to control in pf driver. Otherwise, this feature does not take effect when the kernel PF driver that suppor

[dpdk-dev] [PATCH 03/11] net/hns3: fix RSS indirection table size

2021-02-03 Thread Lijun Ou
the driver should not use the fixed value as the validity check of RSS indirection table size with HW supported. As a result, it will cause misjudgment when the RSS reta size with HW supported have changed. Fixes: c37ca66f2b27 ("net/hns3: support RSS") Cc: sta...@dpdk.org Signed-off-by: Lijun Ou

[dpdk-dev] [PATCH 00/11] critical bugfixes for hns3

2021-02-03 Thread Lijun Ou
Based on some suggestions, we reorganize the fixes and resend the only fixes. Chengchang Tang (4): net/hns3: fix stats flip overflow net/hns3: replace all atomic type with C11 atomic builtins net/hns3: fix cmdq cleared during firmware process net/hns3: fix VF reset after MBX failed Chengw

[dpdk-dev] [PATCH 01/11] net/hns3: fix query order of link status and link info

2021-02-03 Thread Lijun Ou
From: Huisong Li When link information is updated in the firmware, the link information is updated first and then the link status is updated. In a 1s periodic task, PF driver queries the link information and then obtains link status. It may lead to a 1s time difference for obtaining valid link in

Re: [dpdk-dev] [PATCH 00/17] bugfixes and small functionality for hns3

2021-02-03 Thread oulijun
在 2021/2/3 19:46, Ferruh Yigit 写道: On 2/3/2021 11:05 AM, oulijun wrote: 在 2021/2/3 17:24, Ferruh Yigit 写道: On 2/3/2021 7:46 AM, Lijun Ou wrote: This patch series add some bugfixes and some small functions. In order to fix some bugfixes, we had to do some code rework, for example patch[13/

Re: [dpdk-dev] [PATCH 1/1] doc: explain steps for improved code spell checking

2021-02-03 Thread Bruce Richardson
On Wed, Feb 03, 2021 at 11:30:57AM +0100, Thomas Monjalon wrote: > The script build-dict.sh was added in DPDK 20.08. > It generates a better dictionary for spell checking > done via checkpatch. > > Signed-off-by: Thomas Monjalon > --- > doc/guides/contributing/patches.rst | 10 +++--- > 1 fi

Re: [dpdk-dev] [PATCH v3] examples/vhost: remove async inflight packet counter

2021-02-03 Thread Jiang, Cheng1
Hi, > -Original Message- > From: Maxime Coquelin > Sent: Wednesday, February 3, 2021 5:52 PM > To: Jiang, Cheng1 ; Xia, Chenbo > > Cc: dev@dpdk.org; Hu, Jiayu ; Yang, YvonneX > ; Wang, Yinan > Subject: Re: [PATCH v3] examples/vhost: remove async inflight packet > counter > > > > On 2

Re: [dpdk-dev] [PATCH v3] common/mlx5: fix storing the synched MAC to internal table

2021-02-03 Thread Dey, Souvik
Hi Slava, Initially v2 of the patch has " instead of ' in the Fixes tags, but it gave some warnings as wrong quota. So thought of changing it to '. I can change it back again, do you suggest me to submit v4 with with corrected quota character or its ok to have the v3 of the patch itself

Re: [dpdk-dev] [PATCH 0/2] doc update for rte flow shared action

2021-02-03 Thread Ferruh Yigit
On 2/2/2021 12:23 PM, Jack Min wrote: This series update documents as following: 1. Add more information about shared action in rte_flow.rst. 2. Group all supported shared actions in mlx5.rst Xiaoyu Min (2): doc: more info of rte flow shared action doc: group mlx5 shared actions Series

Re: [dpdk-dev] [PATCH 1/2] doc: more info of rte flow shared action

2021-02-03 Thread Ferruh Yigit
On 2/3/2021 9:02 AM, Asaf Penso wrote: Hi Jack, -Original Message- From: dev On Behalf Of Ori Kam Sent: Wednesday, February 3, 2021 9:51 AM To: Jack Min Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH 1/2] doc: more info of rte flow shared action Hi Jack, -Original Message-

Re: [dpdk-dev] [PATCH] examples/vhost: add error propagation in ioat ops

2021-02-03 Thread Jiang, Cheng1
Hi, > -Original Message- > From: Maxime Coquelin > Sent: Wednesday, February 3, 2021 5:49 PM > To: Jiang, Cheng1 ; Xia, Chenbo > > Cc: dev@dpdk.org; Hu, Jiayu ; Yang, YvonneX > ; Wang, Yinan > Subject: Re: [PATCH] examples/vhost: add error propagation in ioat ops > > > > On 1/31/21 1

Re: [dpdk-dev] [PATCH 00/17] bugfixes and small functionality for hns3

2021-02-03 Thread Ferruh Yigit
On 2/3/2021 11:05 AM, oulijun wrote: 在 2021/2/3 17:24, Ferruh Yigit 写道: On 2/3/2021 7:46 AM, Lijun Ou wrote: This patch series add some bugfixes and some small functions. In order to fix some bugfixes, we had to do some code rework, for example patch[13/17]. Chengchang Tang (6):    net/hns3:

Re: [dpdk-dev] [PATCH] net/mlx5: fix miniCQE configuration for Verbs

2021-02-03 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Alexander Kozyrev > Sent: Monday, February 1, 2021 7:17 PM > To: dev@dpdk.org > Cc: sta...@dpdk.org; Raslan Darawsheh ; Slava > Ovsiienko ; Matan Azrad > Subject: [PATCH] net/mlx5: fix miniCQE configuration for Verbs > > Verbs cannot be used to configure

Re: [dpdk-dev] [PATCH] net/mlx5: check FW miniCQE format capabilities

2021-02-03 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Alexander Kozyrev > Sent: Tuesday, February 2, 2021 4:08 AM > To: dev@dpdk.org > Cc: sta...@dpdk.org; Raslan Darawsheh ; Slava > Ovsiienko ; Matan Azrad > Subject: [PATCH] net/mlx5: check FW miniCQE format capabilities > > miniCQE formats for Flow Tag an

Re: [dpdk-dev] [PATCH 00/17] bugfixes and small functionality for hns3

2021-02-03 Thread oulijun
在 2021/2/3 17:24, Ferruh Yigit 写道: On 2/3/2021 7:46 AM, Lijun Ou wrote: This patch series add some bugfixes and some small functions. In order to fix some bugfixes, we had to do some code rework, for example patch[13/17]. Chengchang Tang (6): net/hns3: support module EEPROM dump net/hn

Re: [dpdk-dev] [PATCH v3] doc: update i40e PMD to support on windows

2021-02-03 Thread Ferruh Yigit
On 2/3/2021 10:22 AM, Ferruh Yigit wrote: On 2/2/2021 7:09 PM, Pallavi Kadam wrote: Add documentation to support i40e PMD on Windows. Update the release notes and features list for the same. v3 changes: - Replaced the commit link with netuio README.rst   documentation link v2 changes:

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/sfc: add 8000-series EF10 hardware TSO bug workaround

2021-02-03 Thread Ferruh Yigit
On 2/2/2021 3:23 PM, Ivan Malov wrote: Innermost IP length and outer UDP datagram length must be greater than or equal to the corresponding values derived from the MSS; otherwise, the checksum offloads will break. Fixes: c1ce2ba218f8 ("net/sfc: support tunnel TSO on EF10 native Tx datapath") Fix

[dpdk-dev] [PATCH 1/1] doc: explain steps for improved code spell checking

2021-02-03 Thread Thomas Monjalon
The script build-dict.sh was added in DPDK 20.08. It generates a better dictionary for spell checking done via checkpatch. Signed-off-by: Thomas Monjalon --- doc/guides/contributing/patches.rst | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/doc/guides/contributing

Re: [dpdk-dev] [PATCH v2 3/3] test/cryptodev: fix handling for config parameters

2021-02-03 Thread Dybkowski, AdamX
> -Original Message- > From: Power, Ciara > Sent: Tuesday, 2 February, 2021 17:58 > To: dev@dpdk.org > Cc: akhil.go...@nxp.com; Doherty, Declan ; > Dybkowski, AdamX ; Power, Ciara > > Subject: [PATCH v2 3/3] test/cryptodev: fix handling for config parameters > > The crypto perf graphing

Re: [dpdk-dev] [PATCH v2 2/3] doc: fix crypto perf script guide

2021-02-03 Thread Dybkowski, AdamX
> -Original Message- > From: Power, Ciara > Sent: Tuesday, 2 February, 2021 17:58 > To: dev@dpdk.org > Cc: akhil.go...@nxp.com; Doherty, Declan ; > Dybkowski, AdamX ; Power, Ciara > > Subject: [PATCH v2 2/3] doc: fix crypto perf script guide > > The guide for using the crypto perf graphi

Re: [dpdk-dev] [PATCH v2 1/3] doc: update release notes for crypto perf script

2021-02-03 Thread Dybkowski, AdamX
> -Original Message- > From: Power, Ciara > Sent: Tuesday, 2 February, 2021 17:58 > To: dev@dpdk.org > Cc: akhil.go...@nxp.com; Doherty, Declan ; > Dybkowski, AdamX ; Power, Ciara > > Subject: [PATCH v2 1/3] doc: update release notes for crypto perf script > > Add release note for the ne

  1   2   >