[dpdk-dev] [PATCH v2 2/4] net/iavf_client: enable interrupt on control queue

2021-01-06 Thread Jingjing Wu
New devarg "intr": if intr=1, use interrupt mode on control queue Signed-off-by: Jingjing Wu --- drivers/net/iavf/iavf.h | 19 drivers/net/iavf/iavf_client_ethdev.c | 131 ++ drivers/net/iavf/iavf_ethdev.c| 18 +--- 3 files changed, 134 insert

[dpdk-dev] [PATCH v2 3/4] net/iavf_client: enable interrupt of control queue

2021-01-06 Thread Jingjing Wu
Signed-off-by: Jingjing Wu --- drivers/net/iavf/iavf_client_ethdev.c | 29 +-- drivers/net/iavf/iavf_ethdev.c| 9 +++-- 2 files changed, 26 insertions(+), 12 deletions(-) diff --git a/drivers/net/iavf/iavf_client_ethdev.c b/drivers/net/iavf/iavf_client_ethde

[dpdk-dev] [PATCH v2 1/4] net/iavf_client: introduce iavf driver on vfio-user client

2021-01-06 Thread Jingjing Wu
This patch add a new net driver based on vdev abstraction, i.e. iavf_client_ethdev.c. It is using common iavf functions to talk with Emulated pci interfaces based on vfio-user. -- | -- | | | iavf driver | |> (iavf_client_ethdev.c)

[dpdk-dev] [PATCH v2 0/4] introduce new iavf driver on vfio-user client

2021-01-06 Thread Jingjing Wu
This series introduces a new net virtual device called iavf_client which is based on vfio-user client interface. Through vfio-user client interface, PCI liked device could be used similar as IntelĀ® Ethernet Adaptive Virtual Function specification. The code to enable iavf_client mainly contains two

[dpdk-dev] [Bug 608] DPDK cannot allocate 32GB of memory

2021-01-06 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=608 Bug ID: 608 Summary: DPDK cannot allocate 32GB of memory Product: DPDK Version: 20.11 Hardware: x86 OS: Linux Status: UNCONFIRMED Severity: major Priorit

Re: [dpdk-dev] [PATCH v2 1/1] mbuf: fix rte_mbuf_dyn.h inclusion from C++

2021-01-06 Thread Olivier Matz
On Wed, Jan 06, 2021 at 06:31:14PM -0700, Ashish Sadanandan wrote: > The header was missing the extern "C" directive which causes name > mangling of functions by C++ compilers, leading to linker errors > complaining of undefined references to these functions. > > Fixes: 4958ca3a443a ("mbuf: suppor

[dpdk-dev] [PATCH v2 6/6] doc: new net PMD iavf_be

2021-01-06 Thread Jingjing Wu
Signed-off-by: Jingjing Wu --- MAINTAINERS| 6 +++ doc/guides/nics/features/iavf_be.ini | 11 ++ doc/guides/nics/iavf_be.rst| 53 ++ doc/guides/nics/index.rst | 1 + doc/guides/rel_notes/release_21_02.rst | 6 ++

[dpdk-dev] [PATCH v2 5/6] net/iavf_be: extend backend to support iavf rxq_irq

2021-01-06 Thread Jingjing Wu
Signed-off-by: Jingjing Wu --- drivers/net/iavf_be/iavf_be_ethdev.c | 3 ++- drivers/net/iavf_be/iavf_be_rxtx.c | 5 + drivers/net/iavf_be/iavf_be_vchnl.c | 8 ++-- 3 files changed, 13 insertions(+), 3 deletions(-) diff --git a/drivers/net/iavf_be/iavf_be_ethdev.c b/drivers/net/iavf_

[dpdk-dev] [PATCH v2 4/6] net/iavf_be: add Rx Tx burst support

2021-01-06 Thread Jingjing Wu
Enable packets revcieve and transmit functions. Signed-off-by: Jingjing Wu Signed-off-by: Xiuchun Lu Signed-off-by: Miao Li --- drivers/net/iavf_be/iavf_be_ethdev.c | 3 + drivers/net/iavf_be/iavf_be_rxtx.c | 342 +++ drivers/net/iavf_be/iavf_be_rxtx.h | 60 +

[dpdk-dev] [PATCH v2 3/6] net/iavf_be: virtchnl messages process

2021-01-06 Thread Jingjing Wu
1. Process virtchnl messages from Front End. 2. Ethdev ops implemention for queues setup. Signed-off-by: Jingjing Wu Signed-off-by: Xiuchun Lu --- drivers/net/iavf_be/iavf_be.h| 32 ++ drivers/net/iavf_be/iavf_be_ethdev.c | 339 ++- drivers/net/iavf_be/iavf_be_rxtx.c | 164 ++

[dpdk-dev] [PATCH v2 2/6] net/iavf_be: control queue enabling

2021-01-06 Thread Jingjing Wu
1. Set up control rx/tx queues. 2. Emu device callback functions implemention. 3. Enabling recv/send msg through control queue. Signed-off-by: Jingjing Wu Signed-off-by: Chenbo Xia Signed-off-by: Xiuchun Lu --- drivers/net/iavf_be/iavf_be.h| 38 drivers/net/iavf_be/iavf_be_ethdev

[dpdk-dev] [PATCH v2 1/6] net/iavf_be: introduce iavf backend driver

2021-01-06 Thread Jingjing Wu
Introduce driver for iavf backend vdev which is based on vfio-user protocol and emudev libs. Signed-off-by: Jingjing Wu Signed-off-by: Kun Qiu --- drivers/net/iavf_be/iavf_be.h| 39 drivers/net/iavf_be/iavf_be_ethdev.c | 330 +++ drivers/net/iavf_be/meson.b

[dpdk-dev] [PATCH v2 0/6] introduce iavf backend driver

2021-01-06 Thread Jingjing Wu
This series introduces a net device driver called iavfbe which is working as datapath driver for emulated iavf type device. It provides basic function following IntelĀ® Ethernet Adaptive Virtual Function specification, including recevice/transmit packets and virtchnl control messages handling. The d

Re: [dpdk-dev] [PATCH 7/9] vfio_user: add client APIs of DMA/IRQ/region

2021-01-06 Thread Xia, Chenbo
Hi Beilei, > -Original Message- > From: Xing, Beilei > Sent: Thursday, January 7, 2021 10:42 AM > To: Xia, Chenbo ; dev@dpdk.org; tho...@monjalon.net; > david.march...@redhat.com > Cc: step...@networkplumber.org; Liang, Cunming ; Lu, > Xiuchun ; Li, Miao ; Wu, Jingjing > > Subject: RE: [

Re: [dpdk-dev] [PATCH 4/8] emu/iavf: add vfio-user device register and unregister

2021-01-06 Thread Xing, Beilei
> -Original Message- > From: dev On Behalf Of Chenbo Xia > Sent: Friday, December 18, 2020 3:48 PM > To: dev@dpdk.org; tho...@monjalon.net; david.march...@redhat.com > Cc: step...@networkplumber.org; Liang, Cunming > ; Lu, Xiuchun ; Li, Miao > ; Wu, Jingjing > Subject: [dpdk-dev] [PATC

Re: [dpdk-dev] [PATCH 40/40] net/virtio: move Vhost-vDPA data to its backend

2021-01-06 Thread Xia, Chenbo
Hi Maxime, > -Original Message- > From: Maxime Coquelin > Sent: Monday, December 21, 2020 5:14 AM > To: dev@dpdk.org; Xia, Chenbo ; olivier.m...@6wind.com; > amore...@redhat.com; david.march...@redhat.com > Cc: Maxime Coquelin > Subject: [PATCH 40/40] net/virtio: move Vhost-vDPA data to

Re: [dpdk-dev] [PATCH 39/40] net/virtio: move Vhost-kernel data to its backend

2021-01-06 Thread Xia, Chenbo
Hi Maxime, > -Original Message- > From: Maxime Coquelin > Sent: Monday, December 21, 2020 5:14 AM > To: dev@dpdk.org; Xia, Chenbo ; olivier.m...@6wind.com; > amore...@redhat.com; david.march...@redhat.com > Cc: Maxime Coquelin > Subject: [PATCH 39/40] net/virtio: move Vhost-kernel data t

Re: [dpdk-dev] [PATCH v2 1/9] ethdev: refactor representor infrastructure

2021-01-06 Thread Xueming(Steven) Li
>-Original Message- >From: Somnath Kotur >Sent: Thursday, January 7, 2021 2:32 PM >To: Xueming(Steven) Li >Cc: NBU-Contact-Thomas Monjalon ; Ferruh Yigit >; Andrew Rybchenko >; Olivier Matz ; >Slava Ovsiienko ; dev ; Asaf Penso > >Subject: Re: [dpdk-dev] [PATCH v2 1/9] ethdev: refactor

Re: [dpdk-dev] [PATCH 38/40] net/virtio: move Vhost-user specifics to its backend

2021-01-06 Thread Xia, Chenbo
Hi Maxime, > -Original Message- > From: Maxime Coquelin > Sent: Monday, December 21, 2020 5:14 AM > To: dev@dpdk.org; Xia, Chenbo ; olivier.m...@6wind.com; > amore...@redhat.com; david.march...@redhat.com > Cc: Maxime Coquelin > Subject: [PATCH 38/40] net/virtio: move Vhost-user specific

[dpdk-dev] [PATCH v2 1/1] mbuf: fix rte_mbuf_dyn.h inclusion from C++

2021-01-06 Thread Ashish Sadanandan
The header was missing the extern "C" directive which causes name mangling of functions by C++ compilers, leading to linker errors complaining of undefined references to these functions. Fixes: 4958ca3a443a ("mbuf: support dynamic fields and flags") Cc: olivier.m...@6wind.com Cc: sta...@dpdk.org

Re: [dpdk-dev] [PATCH v7 4/4] examples/ifpga: add example for opae ifpga API

2021-01-06 Thread Xu, Rosen
Hi Wei, Could you add guide in document to let us know how to run it? Thanks, Rosen > -Original Message- > From: Huang, Wei > Sent: Tuesday, January 05, 2021 15:09 > To: dev@dpdk.org; Xu, Rosen ; Zhang, Qi Z > > Cc: sta...@dpdk.org; Zhang, Tianfei ; Huang, Wei > > Subject: [PATCH v7 4

Re: [dpdk-dev] [PATCH v7 1/4] raw/ifpga: add fpga rsu function

2021-01-06 Thread Xu, Rosen
Hi, > -Original Message- > From: Huang, Wei > Sent: Tuesday, January 05, 2021 15:09 > To: dev@dpdk.org; Xu, Rosen ; Zhang, Qi Z > > Cc: sta...@dpdk.org; Zhang, Tianfei ; Huang, Wei > > Subject: [PATCH v7 1/4] raw/ifpga: add fpga rsu function > > RSU (Remote System Update) depends on se

Re: [dpdk-dev] [PATCH v7 3/4] raw/ifpga: add opae API for Cyborg

2021-01-06 Thread Xu, Rosen
Hi, > -Original Message- > From: Huang, Wei > Sent: Tuesday, January 05, 2021 15:09 > To: dev@dpdk.org; Xu, Rosen ; Zhang, Qi Z > > Cc: sta...@dpdk.org; Zhang, Tianfei ; Huang, Wei > > Subject: [PATCH v7 3/4] raw/ifpga: add opae API for Cyborg > > Cyborg is part of OpenStack, it needs

Re: [dpdk-dev] [PATCH v7 2/4] raw/ifpga: add fpga property get function

2021-01-06 Thread Xu, Rosen
Hi, > -Original Message- > From: Huang, Wei > Sent: Tuesday, January 05, 2021 15:09 > To: dev@dpdk.org; Xu, Rosen ; Zhang, Qi Z > > Cc: sta...@dpdk.org; Zhang, Tianfei ; Huang, Wei > > Subject: [PATCH v7 2/4] raw/ifpga: add fpga property get function > > There are three types of proper

Re: [dpdk-dev] [PATCH v2] app/testpmd: fix IP checksum calculation

2021-01-06 Thread Stephen Hemminger
On Wed, 6 Jan 2021 18:02:49 + Ferruh Yigit wrote: > On 12/5/2020 5:42 AM, George Prekas wrote: > > Strict-aliasing rules are violated by cast to uint16_t* in flowgen.c > > and the calculated IP checksum is wrong on GCC 9 and GCC 10. > > > > Signed-off-by: George Prekas > > --- > > v2: > > *

[dpdk-dev] [PATCH v6] raw/ioat: add secondary process support

2021-01-06 Thread Kumar Amber
Add support for secondary processes in ioat devices. The update allocates a memzone for a primary process or returns it in a secondary process. Signed-off-by: Kumar Amber --- v5 * add error check for memzone lookup v6 * fix compilation --- drivers/raw/ioat/ioat_common.c | 20 ++-

Re: [dpdk-dev] [PATCH v2] net/iavf: support FDIR TCP/UDP pattern without input set

2021-01-06 Thread Zhang, Qi Z
> -Original Message- > From: Zhang, Yuying > Sent: Wednesday, January 6, 2021 6:49 PM > To: dev@dpdk.org; Zhang, Qi Z ; Wu, Jingjing > ; Yigit, Ferruh > Cc: Zhang, Yuying > Subject: [PATCH v2] net/iavf: support FDIR TCP/UDP pattern without input set > > This patch adds an input set r

[dpdk-dev] [PATCH v5] raw/ioat: add secondary process support

2021-01-06 Thread Kumar Amber
Add support for secondary processes in ioat devices. The update allocates a memzone for a primary process or returns it in a secondary process. Signed-off-by: Kumar Amber --- v5 * add error check for memzone lookup --- drivers/raw/ioat/ioat_common.c | 21 +++-- drivers/raw/ioat/

Re: [dpdk-dev] [PATCH 35/40] net/virtio: make server mode blocking

2021-01-06 Thread Xia, Chenbo
Hi Maxime, > -Original Message- > From: Maxime Coquelin > Sent: Monday, December 21, 2020 5:14 AM > To: dev@dpdk.org; Xia, Chenbo ; olivier.m...@6wind.com; > amore...@redhat.com; david.march...@redhat.com > Cc: Maxime Coquelin > Subject: [PATCH 35/40] net/virtio: make server mode blockin

Re: [dpdk-dev] [PATCH v1 4/5] net/ice: add outer input set mask check

2021-01-06 Thread Yan, Zhirun
> -Original Message- > From: Cao, Yahui > Sent: Friday, December 25, 2020 1:29 PM > To: Yan, Zhirun ; dev@dpdk.org; Zhang, Qi Z > ; Wang, Xiao W ; Guo, > Junfeng > Cc: Su, Simei ; Xu, Ting ; Zhang, > Yuying > Subject: RE: [PATCH v1 4/5] net/ice: add outer input set mask check > > I su

Re: [dpdk-dev] [PATCH v1 3/5] net/ice: add outer input set mask to distinguish outer fields

2021-01-06 Thread Yan, Zhirun
> -Original Message- > From: Cao, Yahui > Sent: Friday, December 25, 2020 1:28 PM > To: Yan, Zhirun ; dev@dpdk.org; Zhang, Qi Z > ; Wang, Xiao W ; Guo, > Junfeng > Cc: Su, Simei ; Xu, Ting ; Zhang, > Yuying > Subject: RE: [PATCH v1 3/5] net/ice: add outer input set mask to distinguish

Re: [dpdk-dev] [PATCH v1 2/5] net/ice: refactor flow pattern parser

2021-01-06 Thread Yan, Zhirun
> -Original Message- > From: Cao, Yahui > Sent: Friday, December 25, 2020 1:22 PM > To: Yan, Zhirun ; dev@dpdk.org; Zhang, Qi Z > ; Wang, Xiao W ; Guo, > Junfeng > Cc: Su, Simei ; Xu, Ting ; Zhang, > Yuying > Subject: RE: [PATCH v1 2/5] net/ice: refactor flow pattern parser > > > >

Re: [dpdk-dev] [PATCH 7/9] vfio_user: add client APIs of DMA/IRQ/region

2021-01-06 Thread Xing, Beilei
> -Original Message- > From: dev On Behalf Of Chenbo Xia > Sent: Friday, December 18, 2020 3:39 PM > To: dev@dpdk.org; tho...@monjalon.net; david.march...@redhat.com > Cc: step...@networkplumber.org; Liang, Cunming > ; Lu, Xiuchun ; Li, Miao > ; Wu, Jingjing > Subject: [dpdk-dev] [PATC

Re: [dpdk-dev] [PATCH 33/40] net/virtio: improve Virtio-user errors handling

2021-01-06 Thread Xia, Chenbo
Hi Maxime, > -Original Message- > From: Maxime Coquelin > Sent: Monday, December 21, 2020 5:14 AM > To: dev@dpdk.org; Xia, Chenbo ; olivier.m...@6wind.com; > amore...@redhat.com; david.march...@redhat.com > Cc: Maxime Coquelin > Subject: [PATCH 33/40] net/virtio: improve Virtio-user erro

Re: [dpdk-dev] [PATCH 1/1] mbuf: add extern "C" to rte_mbuf_dyn.h

2021-01-06 Thread Ashish Sadanandan
Hi Olivier, On Wed, Jan 6, 2021 at 6:21 AM Olivier Matz wrote: > > Hi Ashish, > > Yes, it should reference the patch that introduced the issue. In this case, > it should be: > > Fixes: 4958ca3a443a ("mbuf: support dynamic fields and flags") > > Can you please also change the title to start with

[dpdk-dev] [PATCH v2 1/1] mbuf: fix rte_mbuf_dyn.h inclusion from C++

2021-01-06 Thread Ashish Sadanandan
The header was missing the extern "C" directive which causes name mangling of functions by C++ compilers, leading to linker errors complaining of undefined references to these functions. Fixes: 4958ca3a443a ("mbuf: support dynamic fields and flags") Cc: olivier.m...@6wind.com Cc: sta...@dpdk.org

[dpdk-dev] [PATCH v2 1/1] mbuf: fix rte_mbuf_dyn.h inclusion from C++

2021-01-06 Thread Ashish Sadanandan
The header was missing the extern "C" directive which causes name mangling of functions by C++ compilers, leading to linker errors complaining of undefined references to these functions. Fixes: 4958ca3a443a ("mbuf: support dynamic fields and flags") Cc: olivier.m...@6wind.com Cc: sta...@dpdk.org

Re: [dpdk-dev] [dpdk-dev v2 1/2] ethdev: add new tunnel type for ecpri

2021-01-06 Thread Thomas Monjalon
24/12/2020 07:59, Jeff Guo: > Add type of RTE_TUNNEL_TYPE_ECPRI into the enum of ethdev tunnel type. > > Signed-off-by: Jeff Guo > Reviewed-by: Qi Zhang [...] > --- a/lib/librte_ethdev/rte_ethdev.h > +++ b/lib/librte_ethdev/rte_ethdev.h > @@ -1219,6 +1219,7 @@ enum rte_eth_tunnel_type { >

Re: [dpdk-dev] [PATCH v1 0/2] Windows sampling actions

2021-01-06 Thread Thomas Monjalon
03/01/2021 13:15, Ophir Munk: > v1: First release > > Ophir Munk (2): > net/mlx5/linux: wrap sampling actions with OS calls > net/mlx5/windows: implement sampling actions wrappers I don't see a need to split Linux and Windows changes. Squashed in one commit in next-net-mlx, thanks.

Re: [dpdk-dev] [dpdk-stable] [PATCH 2/2] net/mlx5: fix Tx queue creation error flow

2021-01-06 Thread Thomas Monjalon
15/12/2020 09:48, Michael Baum: > In Tx queue creation, there are two validations for the Tx > configuration. > > When one of them fails, the MR btree memory was not freed what caused a > memory leak. > > Free it. > > Fixes: f6d9ab4e769f ("net/mlx5: check Tx queue size overflow") > Cc: sta...@dp

Re: [dpdk-dev] [PATCH] net/mlx5: fix VXLAN decap flow created without VXLAN item

2021-01-06 Thread Thomas Monjalon
31/12/2020 10:33, Shiri Kuzin: > The vxlan_decap action preforms decapsulation of the VXLAN > tunnel. > > Currently we can create a flow with vxlan_decap without > matching on VXLAN header. > > To solve this issue this patch adds validation verifying > that the VXLAN item was detected when specif

Re: [dpdk-dev] [PATCH] net/mlx5: fix flow check hairpin split

2021-01-06 Thread Thomas Monjalon
03/01/2021 16:18, Dekel Peled: > Previously, the identification of hairpin queue was done using > mlx5_rxq_get_type() function. > Recent patch replaced it with use of mlx5_rxq_get_hairpin_conf(), > and check of the return value conf != NULL. > The case of return value is NULL (queue is not hairpin)

Re: [dpdk-dev] [PATCH v6 3/4] test: add test case to validate VFIO DMA map/unmap

2021-01-06 Thread David Christensen
On 1/6/21 12:40 AM, Nithin Dabilpuram wrote: On Tue, Jan 05, 2021 at 11:33:20AM -0800, David Christensen wrote: Hey Nithin, +static int +test_memory_vfio_dma_map(void) +{ + uint64_t sz1, sz2, sz = 2 * rte_mem_page_size(); + uint64_t unmap1, unmap2; + uint8_t *alloc_mem; +

Re: [dpdk-dev] [PATCH] net/mlx5: fix shared RSS and mark actions combination

2021-01-06 Thread Thomas Monjalon
15/12/2020 04:46, Suanming Mou: > In order to allow mbuf mark ID update in Rx data-path, there is a > mechanism in the PMD to enable it according to the rte_flows. > When a flow with mark ID and RSS/QUEUE action exists, all the relevant > Rx queues will be enabled to report the mark ID. > > When s

Re: [dpdk-dev] [PATCH] net/bnxt: limit per-poll Rx representor pkts

2021-01-06 Thread Lance Richardson
On Wed, Jan 6, 2021 at 4:27 AM Ferruh Yigit wrote: > > On 12/14/2020 6:53 PM, Lance Richardson wrote: > > Limit number of representor packets transferred per poll > > to requested burst size. > > > > Hi Lance, > > Can you please describe the impact of the change? Since it has a fixes line, > it >

[dpdk-dev] [PATCH v9 0/2] support generic threading functions

2021-01-06 Thread Tal Shnaiderman
Add API for generic threading functions in EAL which do not reference pthread API. --- v8: * Documentation and minor code changes (DmitryK). v9: * Fix sizeof value in key creation, docu change (DmitryK) --- Tal Shnaiderman (2): eal: move thread affinity functions to new file

[dpdk-dev] [PATCH v9 2/2] eal: add generic thread-local-storage functions

2021-01-06 Thread Tal Shnaiderman
Add support for TLS functionality in EAL. The following functions are added: rte_thread_tls_key_create - create a TLS data key. rte_thread_tls_key_delete - delete a TLS data key. rte_thread_tls_value_set - set value bound to the TLS key rte_thread_tls_value_get - get value bound to the TLS key TL

[dpdk-dev] [PATCH v9 1/2] eal: move thread affinity functions to new file

2021-01-06 Thread Tal Shnaiderman
Move the definition of the functions rte_thread_set_affinity and rte_thread_get_affinity to new file, rte_thread.h The file will implement generic threading functionality and will only host threading functions which do not reference pthread API. Signed-off-by: Tal Shnaiderman --- lib/librte_eal

Re: [dpdk-dev] [PATCH v8 2/2] eal: add generic thread-local-storage functions

2021-01-06 Thread Tal Shnaiderman
> Subject: Re: [PATCH v8 2/2] eal: add generic thread-local-storage functions > > External email: Use caution opening links or attachments > > > On Wed, 6 Jan 2021 21:45:43 +0200, Tal Shnaiderman wrote: > [...] > > +/** > > + * Delete a TLS data key visible to all threads in the process > > + *

Re: [dpdk-dev] [PATCH v8 2/2] eal: add generic thread-local-storage functions

2021-01-06 Thread Dmitry Kozlyuk
On Wed, 6 Jan 2021 21:45:43 +0200, Tal Shnaiderman wrote: [...] > +/** > + * Delete a TLS data key visible to all threads in the process > + * rte_tls_key is the opaque pointer allocated by rte_thread_tls_key_create. This line repeats @param key description. > + * > + * @param key > + * The rt

[dpdk-dev] [PATCH v8 0/2] support generic threading functions

2021-01-06 Thread Tal Shnaiderman
Add API for generic threading functions in EAL which do not reference pthread API. --- v8: * Documentation and minor code changes (DmitryK). --- Tal Shnaiderman (2): eal: move thread affinity functions to new file eal: add generic thread-local-storage functions lib/librte_eal/include

[dpdk-dev] [PATCH v8 1/2] eal: move thread affinity functions to new file

2021-01-06 Thread Tal Shnaiderman
Move the definition of the functions rte_thread_set_affinity and rte_thread_get_affinity to new file, rte_thread.h The file will implement generic threading functionality and will only host threading functions which do not reference pthread API. Signed-off-by: Tal Shnaiderman --- lib/librte_eal

[dpdk-dev] [PATCH v8 2/2] eal: add generic thread-local-storage functions

2021-01-06 Thread Tal Shnaiderman
Add support for TLS functionality in EAL. The following functions are added: rte_thread_tls_key_create - create a TLS data key. rte_thread_tls_key_delete - delete a TLS data key. rte_thread_tls_value_set - set value bound to the TLS key rte_thread_tls_value_get - get value bound to the TLS key TL

Re: [dpdk-dev] [EXT] Re: [PATCH 00/15] Octeon Tx/Tx2 Endpoint pmd

2021-01-06 Thread Ferruh Yigit
On 1/6/2021 2:43 PM, Jerin Jacob wrote: On Wed, Jan 6, 2021 at 7:54 PM Ferruh Yigit wrote: On 1/6/2021 11:58 AM, Jerin Jacob wrote: On Wed, Jan 6, 2021 at 5:06 PM Pradeep Kumar Nalla wrote: -Original Message- From: Ferruh Yigit Sent: Tuesday, January 5, 2021 8:59 PM To: Pradeep

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] app/testpmd: fix testpmd flows left before port stop.

2021-01-06 Thread Ferruh Yigit
On 11/26/2020 4:43 PM, Gregory Etelson wrote: According to RTE flow user guide, PMD will not keep flow rules after port stop. Application resources that refer to flow rules become obsolete after port stop and must not be used. Testpmd maintains linked list of active flows for each port. Entries i

Re: [dpdk-dev] [PATCH v2] app/testpmd: fix IP checksum calculation

2021-01-06 Thread Ferruh Yigit
On 12/5/2020 5:42 AM, George Prekas wrote: Strict-aliasing rules are violated by cast to uint16_t* in flowgen.c and the calculated IP checksum is wrong on GCC 9 and GCC 10. Signed-off-by: George Prekas --- v2: * Instead of a compiler barrier, use a compiler flag. --- app/test-pmd/meson.build

Re: [dpdk-dev] [PATCH 3/4] vdpa/mlx5: add cpu core parameter to bind polling thread

2021-01-06 Thread Maxime Coquelin
On 12/3/20 12:36 AM, Xueming Li wrote: > This patch adds new device argument to specify cpu core affinity to > event polling thread for better latency and throughput. The thread > could be also located by name "vDPA-mlx5-". > > Signed-off-by: Xueming Li > Acked-by: Matan Azrad > --- > doc/gu

[dpdk-dev] [PATCH v2 4/4] net/mlx5: improve bonding representor probe

2021-01-06 Thread Xueming Li
To probe representor on 2nd PF of bonding device, had to specify PF1 BDF in devarg: ,representor=0 When closing bonding device, all representors had to be closed together and this implies all representors have to use master PF of bonding device. So after probing representor port on 2nd PF, when l

[dpdk-dev] [PATCH v2 2/4] net/mlx5: support representor of sub function

2021-01-06 Thread Xueming Li
This patch supports of SF representor. Similar to VF representor, switch port name of SF representor in sysfs phys_port_name is "pfsf". Device representor argumnt is "representors=sf[list]", list member could be mix of instance and range. Example: representors=sf[0,2,4,8-12,-1] To probe VF repr

[dpdk-dev] [PATCH v2 0/4] net/mlx5: support SubFunction representor

2021-01-06 Thread Xueming Li
SubFunction [1] is a portion of the PCI device, a SF netdev has its own dedicated queues(txq, rxq). A SF netdev supports eswitch representation offload similar to existing PF and VF representors. A SF shares PCI level resources with other SFs and/or with its parent PCI function. This patch set int

[dpdk-dev] [PATCH v2 1/4] common/mlx5: update representor name parsing

2021-01-06 Thread Xueming Li
This patch updates representor name parsing for SF. In sysfs, representor name stored in from 'phys_port_name file', similar to VF representor, switch port name of SF representor is "pfsf". For netlink message, net SF type is supported. Examples: pf0sf1 pf0sf[0-3] Signed-off-by: Xueming Li ---

[dpdk-dev] [PATCH v2 3/4] net/mlx5: revert setting representor to first PF

2021-01-06 Thread Xueming Li
Representors on second PF are being probed by devargs: ,representor=pf1vf No need to save primary PF port ID and lookup when probing sibling ports, revert patch [1] [1]: commit e6818853c022 ("net/mlx5: set representor to first PF in bonding mode") Signed-off-by: Xueming Li --- drivers/n

Re: [dpdk-dev] [PATCH 08/40] net/virtio: force IOVA as VA mode for Virtio-user

2021-01-06 Thread Kinsella, Ray
On 06/01/2021 09:11, Thomas Monjalon wrote: > 06/01/2021 10:06, David Marchand: >> On Sun, Dec 20, 2020 at 10:14 PM Maxime Coquelin >> wrote: >>> diff --git a/drivers/net/virtio/virtio_user_ethdev.c >>> b/drivers/net/virtio/virtio_user_ethdev.c >>> index 1f1f63a1a5..f4775ff141 100644 >>> --- a

Re: [dpdk-dev] [PATCH 22/40] net/virtio: remove last PCI refs in non-PCI code

2021-01-06 Thread David Marchand
On Sun, Dec 20, 2020 at 10:15 PM Maxime Coquelin wrote: > > This patch finalizes the bus isolation part of this > refactoring. > > Signed-off-by: Maxime Coquelin > --- [snip] > diff --git a/drivers/net/virtio/virtqueue.h b/drivers/net/virtio/virtqueue.h > index 6c1df6f8e5..9274c48080 100644 > -

[dpdk-dev] [PATCH v2 5/9] ethdev: support multi-host representor

2021-01-06 Thread Xueming Li
This patch introduces multi-host controller for ethdev representor syntax, examples: [[c#]pf#]vf#: VF port representor/s, example: pf0vf1 [[c#]pf#]sf#: SF port representor/s, example: c1pf1sf[0-3] c# is controller(host) ID/range in case of multi-host, optional. It is mostly for SmartNIC attached

[dpdk-dev] [PATCH v2 6/9] devarg: change reprsentor ID to bitmap

2021-01-06 Thread Xueming Li
In eth representor comparator callback, ethdev was compared with devarg. Since ethdev representor port didn't contain controller(host) and owner port information, callback only compared representor port and returned representor port on other PF port. This patch changes representor port to bitmap e

[dpdk-dev] [PATCH v2 4/9] ethdev: support PF index in representor

2021-01-06 Thread Xueming Li
To support representor in bonding, this patch introduces 'pf' section to representor devargs syntax: [pf#]vf#: VF port representor/s, example: vf3, pf0vf3 [pf#]sf#: SF port representor/s, example: sf2, pf1sf2 pf# is optional for SF and VF representor, indicates owner PF device of SF or VF. Signe

[dpdk-dev] [PATCH v2 3/9] ethdev: support sub function representor

2021-01-06 Thread Xueming Li
SubFunction is a portion of the PCI device, created on demand, a SF netdev has its own dedicated queues(txq, rxq). A SF netdev supports eswitch representation offload similar to existing PF and VF representors. To support SF representor, this patch introduces new devargs syntax: sf#: new SF port

[dpdk-dev] [PATCH v2 7/9] ethdev: capability of new representor syntax

2021-01-06 Thread Xueming Li
New representor devargs syntax can't be recognized correctly by previous DPDK version. For application to adapt different DPDK version automatically, this patch introduces new eth device capability of supportting SubFunction representor device. Signed-off-by: Xueming Li --- lib/librte_ethdev/rte

[dpdk-dev] [PATCH v2 0/9] support SubFunction representor

2021-01-06 Thread Xueming Li
SubFunction [1] is a portion of the PCI device, a SF netdev has its own dedicated queues(txq, rxq). A SF netdev supports eswitch representation offload similar to existing PF and VF representors. A SF shares PCI level resources with other SFs and/or with its parent PCI function. >From SmartNIC per

[dpdk-dev] [PATCH v2 9/9] eal: allow PCI device with different representors

2021-01-06 Thread Xueming Li
When probing same PCI device with different representor arguments, PCI bus on probed first devargs, ignored other allowed devices with different representor arguments. This patch iterates all devargs and try them all after PCI bus scan. Signed-off-by: Xueming Li --- lib/librte_eal/common/eal_co

[dpdk-dev] [PATCH v2 1/9] ethdev: refactor representor infrastructure

2021-01-06 Thread Xueming Li
To support extended representor syntax, this patch refactor represntor infrastructure: 1. introduces representor type enum 2. devargs representor port range extraction from partial value Signed-off-by: Xueming Li --- drivers/net/bnxt/bnxt_ethdev.c| 12 drivers/net/enic/enic_ethdev.c

[dpdk-dev] [PATCH v2 8/9] kvargs: update parser for new representor syntax

2021-01-06 Thread Xueming Li
This patch updates kvargs parser to allow comma in list value: k1=a[1,2]b[3-5] Signed-off-by: Xueming Li --- lib/librte_kvargs/rte_kvargs.c | 83 +++--- 1 file changed, 57 insertions(+), 26 deletions(-) diff --git a/lib/librte_kvargs/rte_kvargs.c b/lib/librte_kvarg

[dpdk-dev] [PATCH v2 2/9] ethdev: support new VF representor syntax

2021-01-06 Thread Xueming Li
To prepare for more representor types, this patch adds compatible VF representor devargs syntax: vf#: new VF port representor/s, example: vf[0-3], vf2 For backwards compatibility, representor "#" is deemed as "vf#". Signed-off-by: Xueming Li --- doc/guides/prog_guide/poll_mode_drv.rst | 6 +++-

Re: [dpdk-dev] [PATCH 21/40] net/virtio: move vring alignment to generic header

2021-01-06 Thread David Marchand
On Sun, Dec 20, 2020 at 10:15 PM Maxime Coquelin wrote: > > This patch moves vring alignment define to the generic > Virtio header. > > Signed-off-by: Maxime Coquelin Reviewed-by: David Marchand -- David Marchand

Re: [dpdk-dev] [PATCH 20/40] net/virtio: make interrupt handling more generic

2021-01-06 Thread David Marchand
On Sun, Dec 20, 2020 at 10:15 PM Maxime Coquelin wrote: > > This patch aims at isolating MSIX notion into PCI > layer. > > Signed-off-by: Maxime Coquelin Reviewed-by: David Marchand -- David Marchand

Re: [dpdk-dev] DPDK compress API - questions

2021-01-06 Thread Trahe, Fiona
From: Matan Azrad Sent: Wednesday, January 6, 2021 3:57 PM To: Trahe, Fiona ; ashish.gu...@marvell.com Cc: dev@dpdk.org; NBU-Contact-Thomas Monjalon Subject: DPDK compress API - questions Hi Fiona, Ashish I'm going to add new HW offload compress PMD for mlx5 devices in 21.02. I have some q

Re: [dpdk-dev] [PATCH v7 2/2] eal: add generic thread-local-storage functions

2021-01-06 Thread Tal Shnaiderman
> Subject: Re: [PATCH v7 2/2] eal: add generic thread-local-storage functions > > External email: Use caution opening links or attachments > > > On Tue, 5 Jan 2021 19:06:35 +0200, Tal Shnaiderman wrote: > > Add support for TLS functionality in EAL. > > > > The following functions are added: > >

Re: [dpdk-dev] [PATCH 19/40] net/virtio: move config definitions to generic header

2021-01-06 Thread David Marchand
On Sun, Dec 20, 2020 at 10:15 PM Maxime Coquelin wrote: > diff --git a/drivers/net/virtio/virtio.h b/drivers/net/virtio/virtio.h > index eeeb5dba4f..5169436c9f 100644 > --- a/drivers/net/virtio/virtio.h > +++ b/drivers/net/virtio/virtio.h > @@ -106,6 +106,50 @@ > #define VIRTIO_MAX_VIRTQUEUE_PAIR

Re: [dpdk-dev] Windows build broken on latest meson/ninja release

2021-01-06 Thread Tal Shnaiderman
> Subject: Re: [dpdk-dev] Windows build broken on latest meson/ninja release > > External email: Use caution opening links or attachments > > > On Wed, Jan 6, 2021 at 4:18 PM Tal Shnaiderman > wrote: > > > > Hi, > > > > We're testing Windows build with the latest meson/ninja version > > availab

[dpdk-dev] DPDK compress API - questions

2021-01-06 Thread Matan Azrad
Hi Fiona, Ashish I'm going to add new HW offload compress PMD for mlx5 devices in 21.02. I have some questions on the API: #define RTE_COMP_FF_NONCOMPRESSED_BLOCKS(1ULL << 11) /**< Creation of non-compressed blocks using RTE_COMP_LEVEL_NONE is supported */ 1. What does it mean no

Re: [dpdk-dev] [PATCH v6] app/testpmd: fix testpmd packets dump overlapping

2021-01-06 Thread Stephen Hemminger
On Wed, 6 Jan 2021 16:13:37 +0200 Jiawei Wang wrote: > + int buf_size = MAX_STRING_LEN; > + char print_buf[buf_size]; Don't use dynamic sized array if you don't have to. Various static checkers can see look for out of bounds access to fixed size array.

Re: [dpdk-dev] [PATCH v6] app/testpmd: fix testpmd packets dump overlapping

2021-01-06 Thread Stephen Hemminger
On Wed, 6 Jan 2021 16:13:37 +0200 Jiawei Wang wrote: > +print_ether_addr(const char *what, const struct rte_ether_addr *eth_addr, > + char print_buf[], int buf_size, int *cur_len) Use size_t instead of int for sizes? The length can never be negative?

Re: [dpdk-dev] Windows build broken on latest meson/ninja release

2021-01-06 Thread Tal Shnaiderman
> Subject: Re: [dpdk-dev] Windows build broken on latest meson/ninja release > > External email: Use caution opening links or attachments > > > On Wed, Jan 06, 2021 at 03:18:17PM +, Tal Shnaiderman wrote: > > Hi, > > > > We're testing Windows build with the latest meson/ninja version > > ava

Re: [dpdk-dev] [PATCH 18/40] net/virtio: move virtqueue defines in generic header

2021-01-06 Thread David Marchand
On Sun, Dec 20, 2020 at 10:15 PM Maxime Coquelin wrote: > > This patch moves the virtqueues defines from PCI header > to the genreric one. generic* > > Signed-off-by: Maxime Coquelin > --- > drivers/net/virtio/virtio.h| 18 ++ > drivers/net/virtio/virtio_et

Re: [dpdk-dev] [PATCH 2/4] vdpa/mlx5: default polling mode delay time to zero

2021-01-06 Thread Maxime Coquelin
On 12/3/20 12:36 AM, Xueming Li wrote: > To improve performance and latency, this patch set Rx polling mode s/set/sets/ I'll fix while applying. > default delay time to zero. > > Signed-off-by: Xueming Li > Acked-by: Matan Azrad > --- > drivers/vdpa/mlx5/mlx5_vdpa.h | 2 +- > driver

Re: [dpdk-dev] [EXT] Re: [PATCH 00/15] Octeon Tx/Tx2 Endpoint pmd

2021-01-06 Thread Pradeep Kumar Nalla
-Original Message- From: Jerin Jacob Sent: Wednesday, January 6, 2021 8:14 PM To: Ferruh Yigit Cc: Pradeep Kumar Nalla ; Jerin Jacob Kollanukkaran ; Satananda Burla ; dev@dpdk.org Subject: Re: [dpdk-dev] [EXT] Re: [PATCH 00/15] Octeon Tx/Tx2 Endpoint pmd On Wed, Jan 6, 2021 at 7:54 P

Re: [dpdk-dev] [PATCH 1/4] vdpa/mlx5: set polling mode default delay to zero

2021-01-06 Thread Maxime Coquelin
On 12/3/20 12:36 AM, Xueming Li wrote: > To improve throughput and latency, this patch allows Rx polling timer > delay to 0us. > > Signed-off-by: Xueming Li > Acked-by: Matan Azrad > --- > doc/guides/vdpadevs/mlx5.rst | 3 +-- > drivers/vdpa/mlx5/mlx5_vdpa.c | 9 +++-- > 2 files changed

Re: [dpdk-dev] Windows build broken on latest meson/ninja release

2021-01-06 Thread David Marchand
On Wed, Jan 6, 2021 at 4:18 PM Tal Shnaiderman wrote: > > Hi, > > We're testing Windows build with the latest meson/ninja version available in > the meson github [1] > > meson: 0.56.0 > ninja: 1.10.2 > > and getting the output below, any idea why? looks like a bug since /subsystem > should be re

Re: [dpdk-dev] Windows build broken on latest meson/ninja release

2021-01-06 Thread Bruce Richardson
On Wed, Jan 06, 2021 at 03:18:17PM +, Tal Shnaiderman wrote: > Hi, > > We're testing Windows build with the latest meson/ninja version available in > the meson github [1] > > meson: 0.56.0 > ninja: 1.10.2 > > and getting the output below, any idea why? looks like a bug since /subsystem > s

[dpdk-dev] Windows build broken on latest meson/ninja release

2021-01-06 Thread Tal Shnaiderman
Hi, We're testing Windows build with the latest meson/ninja version available in the meson github [1] meson: 0.56.0 ninja: 1.10.2 and getting the output below, any idea why? looks like a bug since /subsystem should be recognized. FAILED: examples/dpdk-helloworld.exe examples/dpdk-helloworld.p

Re: [dpdk-dev] [PATCH v2] net/qede: change driver's default load parameter

2021-01-06 Thread Devendra Singh Rawat
> -Original Message- > From: Devendra Singh Rawat > Sent: Wednesday, January 6, 2021 6:50 PM > To: dev@dpdk.org; Jerin Jacob Kollanukkaran ; > ferruh.yi...@intel.com > Cc: GR-Everest-DPDK-Dev ; Igor > Russkikh ; Rasesh Mody ; > Manish Chopra ; Devendra Singh Rawat > ; sta...@dpdk.org >

Re: [dpdk-dev] [PATCH v7 2/2] eal: add generic thread-local-storage functions

2021-01-06 Thread Dmitry Kozlyuk
On Tue, 5 Jan 2021 19:06:35 +0200, Tal Shnaiderman wrote: > Add support for TLS functionality in EAL. > > The following functions are added: > rte_thread_tls_key_create - function to create a TLS data key. > rte_thread_tls_key_delete - function to delete a TLS data key. > rte_thread_tls_value_set

Re: [dpdk-dev] [EXT] Re: [PATCH 00/15] Octeon Tx/Tx2 Endpoint pmd

2021-01-06 Thread Jerin Jacob
On Wed, Jan 6, 2021 at 7:54 PM Ferruh Yigit wrote: > > On 1/6/2021 11:58 AM, Jerin Jacob wrote: > > On Wed, Jan 6, 2021 at 5:06 PM Pradeep Kumar Nalla > > wrote: > >> > >> > >> > >> -Original Message- > >> From: Ferruh Yigit > >> Sent: Tuesday, January 5, 2021 8:59 PM > >> To: Pradeep K

Re: [dpdk-dev] [RFC PATCH v2] build: add platform meson option

2021-01-06 Thread Bruce Richardson
On Tue, Jan 05, 2021 at 02:17:44PM -0800, David Christensen wrote: > > > The current meson option 'machine' should only specify the ISA, which is > > > not > > > sufficient for Arm, where setting ISA implies other setting as well. > > > Add a new meson option, 'platform', which differentiates the

Re: [dpdk-dev] [PATCH v7 1/2] eal: move thread affinity functions to new file

2021-01-06 Thread Dmitry Kozlyuk
On Tue, 5 Jan 2021 19:06:34 +0200, Tal Shnaiderman wrote: [...] > diff --git a/lib/librte_eal/include/rte_thread.h > b/lib/librte_eal/include/rte_thread.h > new file mode 100644 > index 00..dbc4b3adf8 > --- /dev/null > +++ b/lib/librte_eal/include/rte_thread.h > @@ -0,0 +1,39 @@ > +/* SPD

Re: [dpdk-dev] [EXT] Re: [PATCH 00/15] Octeon Tx/Tx2 Endpoint pmd

2021-01-06 Thread Ferruh Yigit
On 1/6/2021 11:58 AM, Jerin Jacob wrote: On Wed, Jan 6, 2021 at 5:06 PM Pradeep Kumar Nalla wrote: -Original Message- From: Ferruh Yigit Sent: Tuesday, January 5, 2021 8:59 PM To: Pradeep Kumar Nalla Cc: Jerin Jacob Kollanukkaran ; Satananda Burla ; dev@dpdk.org Subject: Re: [EXT]

Re: [dpdk-dev] [PATCH] mlx5: fix __mlx5_bit_off macro warning for Windows

2021-01-06 Thread Dmitry Kozlyuk
On Wed, 6 Jan 2021 15:42:21 +0200, Tal Shnaiderman wrote: > While compiling with clang 11 the callers of the > __mlx5_bit_off macro warns on the cast of pointers to > unsigned long which is a smaller int type in Windows. > > warning: cast to smaller integer type 'unsigned long' > from 'u8 (*)[16]

[dpdk-dev] [PATCH v6] app/testpmd: fix testpmd packets dump overlapping

2021-01-06 Thread Jiawei Wang
When testpmd enabled the verbosity for the received packets, if two packets were received at the same time, for example, sampling packet and normal packet, the dump output of these packets may be overlapping due to multiple core handling the multiple queues simultaneously. The patch uses one strin

Re: [dpdk-dev] [PATCH v4] raw/ioat: add secondary process support

2021-01-06 Thread Bruce Richardson
On Mon, Jan 04, 2021 at 10:00:49PM +0530, Kumar Amber wrote: > Add support for secondary processes in ioat devices. The update > allocates a memzone for a primary process or returns it in a > secondary process. > > Signed-off-by: Kumar Amber > --- Thanks for the patch. Some comments below. Also,

  1   2   >