Re: [dpdk-dev] [PATCH 3/9] vfio_user: implement device and region related APIs

2021-01-05 Thread Xia, Chenbo
Hi Beilei, > -Original Message- > From: Xing, Beilei > Sent: Wednesday, January 6, 2021 1:52 PM > To: Xia, Chenbo ; dev@dpdk.org; tho...@monjalon.net; > david.march...@redhat.com > Cc: step...@networkplumber.org; Liang, Cunming ; Lu, > Xiuchun ; Li, Miao ; Wu, Jingjing > > Subject: RE: [

Re: [dpdk-dev] [PATCH v7 0/2] examples/vhost: sample code refactor

2021-01-05 Thread Ling, WeiX
Tested-by: Wei Ling Regards, Ling Wei > -Original Message- > From: dev On Behalf Of Cheng Jiang > Sent: Tuesday, January 5, 2021 10:15 AM > To: maxime.coque...@redhat.com; Xia, Chenbo > Cc: dev@dpdk.org; Hu, Jiayu ; Yang, YvonneX > ; Wang, Yinan ; Jiang, > Cheng1 > Subject: [dpdk-dev]

Re: [dpdk-dev] [PATCH 9/9] doc: add vfio-user library guide

2021-01-05 Thread Xia, Chenbo
Hi Beilei, > -Original Message- > From: Xing, Beilei > Sent: Wednesday, January 6, 2021 1:08 PM > To: Xia, Chenbo ; dev@dpdk.org; tho...@monjalon.net; > david.march...@redhat.com > Cc: step...@networkplumber.org; Liang, Cunming ; Lu, > Xiuchun ; Li, Miao ; Wu, Jingjing > > Subject: RE: [

Re: [dpdk-dev] [PATCH v2 4/8] emu/iavf: add vfio-user device register and unregister

2021-01-05 Thread Xia, Chenbo
Hi Jingjing, > -Original Message- > From: Wu, Jingjing > Sent: Tuesday, January 5, 2021 9:42 PM > To: Xia, Chenbo ; dev@dpdk.org; tho...@monjalon.net; > david.march...@redhat.com > Cc: step...@networkplumber.org; Liang, Cunming ; Lu, > Xiuchun ; Li, Miao > Subject: RE: [PATCH v2 4/8] emu

[dpdk-dev] [Bug 573] [dpdk-20.11]rss_to_rte_flow/set_key_keylen: create rule failed: Invalid argument.

2021-01-05 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=573 kumar amber (kumar.am...@intel.com) changed: What|Removed |Added CC||kumar.am...@intel.com

Re: [dpdk-dev] [PATCH v2 2/2] net/netvsc: support VF device hot add/remove

2021-01-05 Thread Long Li
> Subject: Re: [dpdk-dev] [PATCH v2 2/2] net/netvsc: support VF device hot > add/remove > > On Mon, 21 Dec 2020 13:33:22 -0800 > Long Li wrote: > > > /* trying to get mac address if this is a network device*/ > > + s = socket(PF_INET, SOCK_DGRAM, IPPROTO_IP); > > + if (s

[dpdk-dev] [PATCH] vdpa/mlx5: fix configuration mutex cleanup

2021-01-05 Thread Matan Azrad
When the vDPA device is closed, the driver polling thread is canceled. The polling thread locks the configuration mutex while it polls the CQs. When the cancellation happens, it may terminate the thread inside the critical section what remains the configuration mutex locked. After device close, t

[dpdk-dev] [PATCH] net/ice: enlarge ice RXQ rearm thresh to 64

2021-01-05 Thread Leyi Rong
We observe performance drop on ice AVX512 data path after stop and start by using testpmd. As CPU polling is faster in AVX512 path, L3 contested accesses is intensified when rxrearm_start is a random value after testpmd stop/start. Enlarge ICE_RXQ_REARM_THRESH to 64 to ease the contested asscesse

Re: [dpdk-dev] [PATCH 3/9] vfio_user: implement device and region related APIs

2021-01-05 Thread Xing, Beilei
> -Original Message- > From: dev On Behalf Of Chenbo Xia > Sent: Friday, December 18, 2020 3:39 PM > To: dev@dpdk.org; tho...@monjalon.net; david.march...@redhat.com > Cc: step...@networkplumber.org; Liang, Cunming > ; Lu, Xiuchun ; Li, Miao > ; Wu, Jingjing > Subject: [dpdk-dev] [PATC

Re: [dpdk-dev] [PATCH 9/9] doc: add vfio-user library guide

2021-01-05 Thread Xing, Beilei
> -Original Message- > From: dev On Behalf Of Chenbo Xia > Sent: Friday, December 18, 2020 3:39 PM > To: dev@dpdk.org; tho...@monjalon.net; david.march...@redhat.com > Cc: step...@networkplumber.org; Liang, Cunming > ; Lu, Xiuchun ; Li, Miao > ; Wu, Jingjing > Subject: [dpdk-dev] [PATC

[dpdk-dev] [PATCH v2 5/6] net/hns3: fix crash with multi-process

2021-01-05 Thread Lijun Ou
From: "Min Hu (Connor)" In current version, procedure of saving eth_dev in hns3 PMD init will be called more than twice, one for primary, the other for secondary. That will cause segmentation fault in Multi-process as eth_dev will be changed in secondary process, which is different from one in pr

[dpdk-dev] [PATCH v2 1/6] net/hns3: fix incorrect interception with filter director

2021-01-05 Thread Lijun Ou
The rte_fdir_conf structure has deprecated and users need to use the specified rule parameters of rte_flow structure when configure a flow rule. As a result, it is incorrectly used in the rte_flow API. Fixes: fcba820d9b9e ("net/hns3: support flow director") Cc: sta...@dpdk.org Signed-off-by: Liju

[dpdk-dev] [PATCH v2 4/6] net/hns3: fix Rx/Tx abnormal errors stats

2021-01-05 Thread Lijun Ou
From: Huisong Li Abnormal errors stats in Rx/Tx datapath are statistics items in driver, and displayed in xstats. They should be cleared by the rte_eth_xstats_reset api, instead of the rte_eth_stats_reset. Fixes: c4b7d6761d01 ("net/hns3: get Tx abnormal errors in xstats") Fixes: 521ab3e93361 ("n

[dpdk-dev] [PATCH v2 3/6] net/hns3: fix abnormal return value in xstats

2021-01-05 Thread Lijun Ou
From: Huisong Li The ethdev API has processed the failure to obtain xstats statistics. Therefore, driver should return an error code instead of 0 in 'hns3_dev_xstats_get' API. Fixes: 8839c5e202f3 ("net/hns3: support device stats") Cc: sta...@dpdk.org Signed-off-by: Huisong Li Signed-off-by: Li

[dpdk-dev] [PATCH v2 6/6] net/hns3: remove unnecessary memset

2021-01-05 Thread Lijun Ou
The hns3_cmd_desc has memset when setup and the memset for req is unnecessary. Signed-off-by: Lijun Ou --- drivers/net/hns3/hns3_rss.c | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/net/hns3/hns3_rss.c b/drivers/net/hns3/hns3_rss.c index e2f0468..b5df374 100644 --- a/drivers/net

[dpdk-dev] [PATCH v2 2/6] net/hns3: fix xstats statistics with id and names

2021-01-05 Thread Lijun Ou
From: Huisong Li Currently, validity check for ids and values in the hns3_dev_xstats_get_by_id API is incorrect, which will cause a problem. Namely, if the ID range of the xstats stats item does not include the basic stats item, the app can not obtain the corresponding xstats statistics in hns3_d

[dpdk-dev] [PATCH v2 0/6] some bugfixes for hns3

2021-01-05 Thread Lijun Ou
Here series fix some hns3 PMD bugs. Change frome V1: 1. remove the fixes patch[6/7] from V1 2. fix ferruh Yigit's comments. Huisong Li (3): net/hns3: fix xstats statistics with id and names net/hns3: fix abnormal return value in xstats net/hns3: fix Rx/Tx abnormal errors stats Lijun Ou (2)

Re: [dpdk-dev] [PATCH] net/iavf: fix GTPU UL and DL support for FDIR

2021-01-05 Thread Xu, HailinX
Tested-by: Xu, HailinX Regards, Xu, Hailin -Original Message- From: dev On Behalf Of Zhang, Qi Z Sent: Monday, January 4, 2021 10:28 AM To: Guo, Junfeng ; Wu, Jingjing ; Xing, Beilei Cc: dev@dpdk.org; sta...@dpdk.org; Yigit, Ferruh Subject: Re: [dpdk-dev] [PATCH] net/iavf: fix GTPU

[dpdk-dev] [PATCH 2/2] vdpa/mlx5: hardware queue moderation

2021-01-05 Thread Xueming Li
The next parameters control the HW queue moderation feature. This feature helps to control the traffic performance and latency tradeoff. Each packet completion report from HW to SW requires CQ processing by SW and triggers interrupt for the guest driver. Interrupt report and handling cost CPU cycl

[dpdk-dev] [PATCH 1/2] common/mlx5: support vDPA completion queue moderation

2021-01-05 Thread Xueming Li
This patch introduces new parameters for VirtQ CQ moderation, used for performance tuning. Signed-off-by: Xueming Li --- drivers/common/mlx5/mlx5_devx_cmds.c | 3 +++ drivers/common/mlx5/mlx5_devx_cmds.h | 3 +++ drivers/common/mlx5/mlx5_prm.h | 6 +- 3 files changed, 11 insertions(+),

Re: [dpdk-dev] 18.11.11 (LTS) patches review and test

2021-01-05 Thread Chen, BoX C
Hi Kevin, > Hi Chen Bo, > Thanks for your testing. > > > * Intel(R) Testing > > > > # Basic Intel(R) NIC testing > > * PF(i40e):Passed > > known issue: create rule for set hash key, but rule create failed. > > Can you please provide some more information. Is there a bugzilla? Is there a > f

Re: [dpdk-dev] [PATCH v7 1/4] raw/ifpga: add fpga rsu function

2021-01-05 Thread Zhang, Tianfei
> -Original Message- > From: Huang, Wei > Sent: 2021年1月5日 15:09 > To: dev@dpdk.org; Xu, Rosen ; Zhang, Qi Z > > Cc: sta...@dpdk.org; Zhang, Tianfei ; Huang, Wei > > Subject: [PATCH v7 1/4] raw/ifpga: add fpga rsu function > > RSU (Remote System Update) depends on secure manager which

Re: [dpdk-dev] [RFC] ethdev: introduce copy_field rte flow action

2021-01-05 Thread Thomas Monjalon
05/01/2021 23:12, Alexander Kozyrev: > Happy New Year Gentlemen, would you mind to share your thought on the > proposed changes? > I was thinking about renaming it to more general "copy item" to cover all > packet fields, tags and metadata. > Other than that it is ready for a formal patch integr

Re: [dpdk-dev] [RFC PATCH v2] build: add platform meson option

2021-01-05 Thread David Christensen
The current meson option 'machine' should only specify the ISA, which is not sufficient for Arm, where setting ISA implies other setting as well. Add a new meson option, 'platform', which differentiates the type of the build (native/generic) and sets machine accordingly, unless the user chooses to

Re: [dpdk-dev] [RFC] ethdev: introduce copy_field rte flow action

2021-01-05 Thread Thomas Monjalon
18/12/2020 02:31, Alexander Kozyrev: > RTE Flows API lacks the ability to save an arbitrary header field in > order to use it later for advanced packet manipulations. Examples > include the usage of VxLAN ID after the packet is decapsulated or > storing this ID inside the packet payload itself or s

Re: [dpdk-dev] [RFC] ethdev: introduce copy_field rte flow action

2021-01-05 Thread Alexander Kozyrev
Happy New Year Gentlemen, would you mind to share your thought on the proposed changes? I was thinking about renaming it to more general "copy item" to cover all packet fields, tags and metadata. Other than that it is ready for a formal patch integration in my opinion if there are no objections

Re: [dpdk-dev] [dpdk-stable] [PATCH] pci/windows: do not fail on missing NUMA node for PCIe

2021-01-05 Thread Thomas Monjalon
13/12/2020 15:16, Tal Shnaiderman: > On older processors, NUMA isn't bound to PCIe locality. > those cases return ERROR_NOT_FOUND in response to the > SetupDiGetDevicePropertyW call with DEVPKEY_Device_Numa_Node > attribute. > > This error fails the probe process for the PCIe device. > this commit

Re: [dpdk-dev] [PATCH v3] build: fix plugin load on static builds

2021-01-05 Thread Thomas Monjalon
21/12/2020 12:04, Bruce Richardson: > On Fri, Dec 18, 2020 at 02:14:22PM +0100, Olivier Matz wrote: > > When dpdk is compiled as static libraries, it is not possible > > to load a plugin from an application. We get the following error: > > > > EAL: librte_pmd_.so: undefined symbol: per_lcore

Re: [dpdk-dev] [PATCH v2] eal/windows: add interrupt functions stub

2021-01-05 Thread Thomas Monjalon
15/12/2020 23:39, Dmitry Kozlyuk: > On Mon, 14 Dec 2020 16:26:22 -0800, Pallavi Kadam wrote: > > Add some missing interrupt implementations on Windows. > > Also add respective functions to export file. > > > > Signed-off-by: Tal Shnaiderman > > Signed-off-by: Pallavi Kadam > > Reviewed-by: Ranji

Re: [dpdk-dev] [PATCH 37/40] net/virtio: introduce backend data

2021-01-05 Thread David Marchand
On Sun, Dec 20, 2020 at 10:16 PM Maxime Coquelin wrote: > diff --git a/drivers/net/virtio/virtio_user/vhost_kernel.c > b/drivers/net/virtio/virtio_user/vhost_kernel.c > index 2fd00afa84..023fddcd69 100644 > --- a/drivers/net/virtio/virtio_user/vhost_kernel.c > +++ b/drivers/net/virtio/virtio_user

Re: [dpdk-dev] [PATCH 29/40] net/virtio: add Virtio-user vring file ops

2021-01-05 Thread David Marchand
On Sun, Dec 20, 2020 at 10:16 PM Maxime Coquelin wrote: > diff --git a/drivers/net/virtio/virtio_user/vhost_kernel.c > b/drivers/net/virtio/virtio_user/vhost_kernel.c > index 2f1b4840ee..1805aee7f7 100644 > --- a/drivers/net/virtio/virtio_user/vhost_kernel.c > +++ b/drivers/net/virtio/virtio_user

Re: [dpdk-dev] [PATCH 28/40] net/virtio: add Virtio-user vring setting ops

2021-01-05 Thread David Marchand
Skipping to the build error, I did not review this patch yet. On Sun, Dec 20, 2020 at 10:16 PM Maxime Coquelin wrote: > --- a/drivers/net/virtio/virtio_user/vhost_kernel.c > +++ b/drivers/net/virtio/virtio_user/vhost_kernel.c > @@ -219,12 +219,49 @@ vhost_kernel_set_memory_table(struct virtio_us

Re: [dpdk-dev] [PATCH 05/40] net/virtio: move PCI device init in dedicated file

2021-01-05 Thread David Marchand
On Sun, Dec 20, 2020 at 10:14 PM Maxime Coquelin wrote: > diff --git a/drivers/net/virtio/virtio_ethdev.c > b/drivers/net/virtio/virtio_ethdev.c > index 99a5a1bb88..ca21a019e5 100644 > --- a/drivers/net/virtio/virtio_ethdev.c > +++ b/drivers/net/virtio/virtio_ethdev.c [...] > @@ -2135,52 +2078,

Re: [dpdk-dev] [PATCH 04/40] net/virtio: introduce PCI device metadata

2021-01-05 Thread David Marchand
On Sun, Dec 20, 2020 at 10:14 PM Maxime Coquelin wrote: > > This patch initiate refactoring of Virtio PCI, by introducing > a new device structure for PCI-specific metadata. This works, but this patch seems artificial. The eth_virtio_dev_init expects dev->data->dev_private to be a virtio_hw obje

Re: [dpdk-dev] [PATCH 03/40] net/virtio: refactor virtio-user device

2021-01-05 Thread David Marchand
On Sun, Dec 20, 2020 at 10:14 PM Maxime Coquelin wrote: > > This patch moves the virtio_hw structure into the virtio_user_dev > structure, with the goal of making virtio_hw bus-agnostic. > > Signed-off-by: Maxime Coquelin Just one comment, the rest lgtm. > diff --git a/drivers/net/virtio/virti

Re: [dpdk-dev] [PATCH 02/40] net/virtio: Introduce Virtio bus type

2021-01-05 Thread David Marchand
On Sun, Dec 20, 2020 at 10:14 PM Maxime Coquelin wrote: > > This patch is preliminary work for introducing a bus layer > in Virtio PMD, in order to improve Virtio-user integration. > > A new bus type is added to provide a unified way to distinguish > which bus type is used (PCI modern, PCI legacy

Re: [dpdk-dev] [PATCH 01/40] bus/vdev: add helper to get vdev from eth dev

2021-01-05 Thread David Marchand
On Sun, Dec 20, 2020 at 10:14 PM Maxime Coquelin wrote: > > This patch adds an helper macro to get the rte_vdev_device > pointer from a rte_eth_dev pointer. > > This is similar to RTE_ETH_DEV_TO_PCI(). > > Signed-off-by: Maxime Coquelin Reviewed-by: David Marchand -- David Marchand

Re: [dpdk-dev] [PATCH v6 3/4] test: add test case to validate VFIO DMA map/unmap

2021-01-05 Thread David Christensen
Hey Nithin, +static int +test_memory_vfio_dma_map(void) +{ + uint64_t sz1, sz2, sz = 2 * rte_mem_page_size(); + uint64_t unmap1, unmap2; + uint8_t *alloc_mem; + uint8_t *mem; + int ret; + + /* Allocate twice size of requirement from heap to align later */ +

[dpdk-dev] [PATCH v2 8/8] doc: update GENEVE TLV option support

2021-01-05 Thread Shiri Kuzin
GENEVE TLV option support added to mlx5 PMD. The limitations and support were updated in documentation. Signed-off-by: Shiri Kuzin --- doc/guides/nics/mlx5.rst | 18 +- doc/guides/rel_notes/release_21_02.rst | 8 2 files changed, 25 insertions(+), 1 delet

[dpdk-dev] [PATCH v2 7/8] net/mlx5: add GENEVE TLV option flow translation

2021-01-05 Thread Shiri Kuzin
The GENEVE TLV option matching flows must be created using a translation function. This function checks whether we already created a Devx object for the matching and either creates the objects or updates the reference counter. Signed-off-by: Shiri Kuzin --- drivers/net/mlx5/mlx5_flow_dv.c | 70

[dpdk-dev] [PATCH v2 6/8] net/mlx5: add GENEVE TLV option flow validation

2021-01-05 Thread Shiri Kuzin
This patch adds validation routine for the GENEVE header TLV option. The GENEVE TLV option match must include all fields with full masks due to NIC does not support masking on option class, type and length. The option data length must be non zero and provided data pattern should be zero neither d

[dpdk-dev] [PATCH v2 5/8] net/mlx5: create GENEVE TLV option management

2021-01-05 Thread Shiri Kuzin
Currently firmware supports the only TLV object per device to match on the GENEVE header option. This patch adds the simple TLV object management to the mlx5 PMD. Signed-off-by: Shiri Kuzin --- drivers/net/mlx5/mlx5.c | 2 + drivers/net/mlx5/mlx5.h | 13 drivers/net/mlx5

[dpdk-dev] [PATCH v2 4/8] common/mlx5: create GENEVE TLV option object with DevX

2021-01-05 Thread Shiri Kuzin
TLV object is a special firmware maintained entity used to support match on GENEVE header extension option. The TLV object is created with DevX API and accepts the option class, type and lehgth fields. The class type and length fields are set using MLX5_SET and the Devx object is created using ml

[dpdk-dev] [PATCH v2 3/8] common/mlx5: check GENEVE TLV support in HCA attributes

2021-01-05 Thread Shiri Kuzin
This is preparation step to support match on GENEVE TLV option. In this Patch we add the HCA attributes that will allow supporting GENEVE TLV option matching. Signed-off-by: Shiri Kuzin --- drivers/common/mlx5/mlx5_devx_cmds.c | 7 +++ drivers/common/mlx5/mlx5_devx_cmds.h | 4 driver

[dpdk-dev] [PATCH v2 2/8] app/testpmd: add GENEVE option item support

2021-01-05 Thread Shiri Kuzin
From: Viacheslav Ovsiienko The patch adds the GENEVE option rte flow item support to command line interpreter. The flow command with GENEVE option items looks like: flow create 0 ingress pattern eth / ipv4 / udp / geneve vni is 100 / geneve-opt class is 99 length is 1 type is 0 data is

[dpdk-dev] [PATCH v2 1/8] lib/librte_ethdev: introduce GENEVE header TLV option item

2021-01-05 Thread Shiri Kuzin
The Geneve tunneling protocol is designed to allow the user to specify some data context on the packet. The GENEVE TLV (Type-Length-Variable) Option is the mean intended to present the user data. In order to support GENEVE TLV Option the new rte_flow item "rte_flow_item_geneve_opt" is added. The n

[dpdk-dev] [PATCH v2 0/8] ethdev: introduce GENEVE header TLV option item

2021-01-05 Thread Shiri Kuzin
The Geneve tunneling protocol is designed to allow the user to specify some data context on the packet. The GENEVE TLV (Type-Length-Variable) Option is the mean intended to present the user data. In order to support GENEVE TLV Option the new rte_flow item "rte_flow_item_geneve_opt" is introduce

[dpdk-dev] [PATCH v7 2/2] eal: add generic thread-local-storage functions

2021-01-05 Thread Tal Shnaiderman
Add support for TLS functionality in EAL. The following functions are added: rte_thread_tls_key_create - function to create a TLS data key. rte_thread_tls_key_delete - function to delete a TLS data key. rte_thread_tls_value_set - function to set value bound to the TLS key rte_thread_tls_value_get

[dpdk-dev] [PATCH v7 1/2] eal: move thread affinity functions to new file

2021-01-05 Thread Tal Shnaiderman
Move the definition of the functions rte_thread_set_affinity and rte_thread_get_affinity to new file, rte_thread.h The file will implement generic threading functionality and will only host threading functions which do not reference pthread API. Signed-off-by: Tal Shnaiderman --- lib/librte_eal

[dpdk-dev] [PATCH v7 0/2] support generic threading functions

2021-01-05 Thread Tal Shnaiderman
Add API for generic threading functions in EAL which do not reference pthread API. Tal Shnaiderman (2): eal: move thread affinity functions to new file eal: add generic thread-local-storage functions lib/librte_eal/include/meson.build | 1 + lib/librte_eal/include/rte_lcore.h | 22 +---

Re: [dpdk-dev] [PATCH 21.02 v2 1/2] net/virtio: fix missing backend features negotiation

2021-01-05 Thread Maxime Coquelin
On 12/23/20 6:37 AM, Xia, Chenbo wrote: > Hi Maxime, > >> -Original Message- >> From: Maxime Coquelin >> Sent: Tuesday, December 22, 2020 6:56 PM >> To: Xia, Chenbo ; dev@dpdk.org; amore...@redhat.com; >> jasow...@redhat.com; david.march...@redhat.com >> Cc: sta...@dpdk.org >> Subject:

Re: [dpdk-dev] [PATCH 25/27] net/ice/base: add eCPRI over UDP type 0 flow support

2021-01-05 Thread Ferruh Yigit
On 12/15/2020 6:05 AM, Qi Zhang wrote: This patch adds extracting field for flow type eCPRI over udp message type 0 and field PC_ID which is used for FDIR/RSS packet steering. Signed-off-by: Yahui Cao Signed-off-by: Qi Zhang <...> @@ -1254,6 +1302,11 @@ ice_fdir_get_gen_prgm_pkt(struct ice

Re: [dpdk-dev] 18.11.11 (LTS) patches review and test

2021-01-05 Thread Kevin Traynor
On 23/12/2020 09:41, Pei Zhang wrote: > Hello Kevin, > > The testing with dpdk 18.11.11-rc1 from Red Hat looks good. We tested below > 16 scenarios and and all got PASS on RHEL8: > > (1)Guest with device assignment(PF) throughput testing(1G hugepage size): PASS > (2)Guest with device assignment(

Re: [dpdk-dev] 18.11.11 (LTS) patches review and test

2021-01-05 Thread Kevin Traynor
On 29/12/2020 09:01, Chen, BoX C wrote: > Hi Kevin, > Update DPDK 18.11.11 (LTS) test result for Intel part. All passed except the > known issues. > Hi Chen Bo, Thanks for your testing. > * Intel(R) Testing > > # Basic Intel(R) NIC testing > * PF(i40e):Passed > known issue: create rule fo

Re: [dpdk-dev] [PATCH 00/27] ice base code update

2021-01-05 Thread Ferruh Yigit
On 12/28/2020 10:34 AM, Zhang, Qi Z wrote: -Original Message- From: Yang, Qiming Sent: Thursday, December 24, 2020 11:17 AM To: Zhang, Qi Z Cc: dev@dpdk.org Subject: RE: [PATCH 00/27] ice base code update -Original Message- From: Zhang, Qi Z Sent: Tuesday, December 15, 20

Re: [dpdk-dev] [RFC PATCH] lpm: add sve support for lookup on Arm platform

2021-01-05 Thread Medvedkin, Vladimir
Hi Ruifeng, Thanks for the patch, see comments below On 18/12/2020 10:12, Ruifeng Wang wrote: Added new path to do lpm4 lookup by using scalable vector extension. The SVE path will be selected if compiler has flag SVE set. Signed-off-by: Ruifeng Wang --- lib/librte_eal/arm/include/rte_vect.

[dpdk-dev] [PATCH v2] net/virtio: improve logs in Vhost-vDPA DMA mapping

2021-01-05 Thread Maxime Coquelin
This patch adds debug logs in vhost_vdpa_dma_map() and vhost_vdpa_dma_unmap() to ease debugging. Signed-off-by: Maxime Coquelin --- Changes in v2: - fix i686 build (Chenbo) drivers/net/virtio/virtio_user/vhost_vdpa.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/net/virtio

Re: [dpdk-dev] [PATCH] net/virtio: improve logs in Vhost-vDPA DMA mapping

2021-01-05 Thread Maxime Coquelin
On 11/19/20 9:36 AM, Xia, Chenbo wrote: > Hi Maxime, > >> -Original Message- >> From: Maxime Coquelin >> Sent: Wednesday, November 18, 2020 4:08 PM >> To: dev@dpdk.org; Xia, Chenbo ; amore...@redhat.com >> Cc: Maxime Coquelin >> Subject: [PATCH] net/virtio: improve logs in Vhost-vDPA

Re: [dpdk-dev] [EXT] Re: [PATCH 00/15] Octeon Tx/Tx2 Endpoint pmd

2021-01-05 Thread Ferruh Yigit
On 1/5/2021 2:43 PM, Pradeep Kumar Nalla wrote: Please do not top post, reply moved below. Thanks Pradeep. -Original Message- From: Ferruh Yigit Sent: Monday, January 4, 2021 5:22 PM To: Pradeep Kumar Nalla Cc: Jerin Jacob Kollanukkaran ; Satananda Burla ; dev@dpdk.org Subject: [EXT]

Re: [dpdk-dev] [PATCH v14 00/12] Arm build options rework

2021-01-05 Thread Honnappa Nagarahalli
> > > >v14: > >Resent for retesting (because of suspected false negative). > > > >Series Acked-by: Jerin Jacob Series Tested-by: > >Jerin Jacob Series Tested-by: Dharmik Thakkar > > Series Tested-by: Vimal Chungath > > > > > > Series Tested-by: Pavan Nikhilesh > > Also, I believe we need to

Re: [dpdk-dev] [EXT] Re: [PATCH 00/15] Octeon Tx/Tx2 Endpoint pmd

2021-01-05 Thread Pradeep Kumar Nalla
Hi Ferruh This PMD, while running on a host, drives octeontx/octeontx2 over pci bus, where as "OcteonTx and OcteonTx2 net drivers" run on respective Tx/Tx2 SOCs to make use of h/w blocks present on the SOC. Thanks Pradeep. -Original Message- From: Ferruh Yigit Sent: Monday, January 4,

Re: [dpdk-dev] [PATCH v1 4/4] net/virtio: add election for packed vector NEON path

2021-01-05 Thread Maxime Coquelin
On 11/17/20 11:06 AM, Joyce Kong wrote: > Add NEON vectorized path selection logic. Default setting comes from > vectorized devarg, then checks each criteria. > > Packed ring vectorized neon path need: > NEON is supported by compiler and host > VERSION_1 and IN_ORDER features are negoti

Re: [dpdk-dev] [PATCH v1 3/4] net/virtio: add vectorized packed ring Tx NEON path

2021-01-05 Thread Maxime Coquelin
On 11/17/20 11:06 AM, Joyce Kong wrote: > Optimize packed ring Tx batch path with NEON instructions. > > Signed-off-by: Joyce Kong > Reviewed-by: Ruifeng Wang > --- > drivers/net/virtio/virtio_rxtx_packed.h | 6 +- > drivers/net/virtio/virtio_rxtx_packed_neon.h | 143 +

Re: [dpdk-dev] [PATCH v1 2/4] net/virtio: add vectorized packed ring Rx NEON path

2021-01-05 Thread Maxime Coquelin
On 1/5/21 3:16 PM, Maxime Coquelin wrote: > > > On 11/17/20 11:06 AM, Joyce Kong wrote: >> Optimize packed ring Rx batch path with NEON instructions. >> >> Signed-off-by: Joyce Kong >> Reviewed-by: Ruifeng Wang >> --- >> drivers/net/virtio/virtio_rxtx_packed.h | 15 ++ >> drivers/net/

Re: [dpdk-dev] [PATCH v1 2/4] net/virtio: add vectorized packed ring Rx NEON path

2021-01-05 Thread Maxime Coquelin
On 11/17/20 11:06 AM, Joyce Kong wrote: > Optimize packed ring Rx batch path with NEON instructions. > > Signed-off-by: Joyce Kong > Reviewed-by: Ruifeng Wang > --- > drivers/net/virtio/virtio_rxtx_packed.h | 15 ++ > drivers/net/virtio/virtio_rxtx_packed_neon.h | 150 +

Re: [dpdk-dev] [PATCH] net/ixgbe: clear registers of all queues on VF reset

2021-01-05 Thread Ferruh Yigit
On 1/5/2021 12:52 PM, Wang, Haiyue wrote: -Original Message- From: Ferruh Yigit Sent: Tuesday, January 5, 2021 18:30 To: Simon Ellmann ; Wang, Haiyue ; Guo, Jia Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] net/ixgbe: clear registers of all queues on VF reset On 1/5/2021 9:02 AM,

Re: [dpdk-dev] [PATCH] ci: fix default ccache in GitHub Actions

2021-01-05 Thread Aaron Conole
David Marchand writes: > 'main' might not be the default branch name. > > Fixes: 87009585e293 ("ci: hook to GitHub Actions") > > Signed-off-by: David Marchand > --- > I found no other option but to call to the remote repository since github > does not seem to expose a HEAD symbolic reference. U

Re: [dpdk-dev] [PATCH v1 1/4] net/virtio: move AVX based Rx and Tx code to separate file

2021-01-05 Thread Maxime Coquelin
On 11/17/20 11:06 AM, Joyce Kong wrote: > Split out AVX instruction based virtio packed ring Rx and Tx > implementation to a separate file. > > Signed-off-by: Joyce Kong > Reviewed-by: Ruifeng Wang > --- > drivers/net/virtio/meson.build | 4 +- > drivers/net/virtio/virtio_rxtx

[dpdk-dev] [PATCH v1 2/2] net/vmxnet3: Provided API to reset vmxnet device

2021-01-05 Thread Dheemanth Mallikarjun
The vmxnet3 driver didn't have the dev_reset function pointer set. Hence, provided the necessary function pointer so that DPDK developers can use the rte_eth_dev_reset API to reset the vmxnet3 device data. Signed-off-by: Dheemanth Mallikarjun --- drivers/net/vmxnet3/vmxnet3_ethdev.c | 14 +++

Re: [dpdk-dev] [PATCH v2 4/8] emu/iavf: add vfio-user device register and unregister

2021-01-05 Thread Wu, Jingjing
> +static int iavf_emu_update_status(int vfio_dev_id) { > + struct iavf_emudev *dev; > + int ret; > + > + dev = find_iavf_with_dev_id(vfio_dev_id); > + if (!dev) > + return -1; > + > + ret = iavf_emu_setup_mem_table(dev); > + if (ret) { > + EMU_IAVF_L

[dpdk-dev] [PATCH v2 3/3] vhost: refactor memory regions mapping

2021-01-05 Thread Maxime Coquelin
This patch moves memory region mmaping and related preparation in a dedicated function in order to simplify VHOST_USER_SET_MEM_TABLE request handling function. Signed-off-by: Maxime Coquelin Reviewed-by: Chenbo Xia --- lib/librte_vhost/vhost_user.c | 178 ++ 1 fi

[dpdk-dev] [PATCH v2 2/3] vhost: refactor postcopy registration

2021-01-05 Thread Maxime Coquelin
This patch moves the registration of postcopy to a dedicated function, with the goal of simplifying VHOST_USER_SET_MEM_TABLE request handling function. Signed-off-by: Maxime Coquelin Reviewed-by: Chenbo Xia --- lib/librte_vhost/vhost_user.c | 98 +-- 1 file chang

[dpdk-dev] [PATCH v2 1/3] vhost: refactor postcopy region registration

2021-01-05 Thread Maxime Coquelin
This patch moves the registration of memory regions to userfaultfd to a dedicated function, with the goal of simplifying VHOST_USER_SET_MEM_TABLE request handling function. Signed-off-by: Maxime Coquelin --- lib/librte_vhost/vhost_user.c | 77 +-- 1 file changed,

[dpdk-dev] [PATCH v2 0/3] vhost: vhost_user_set_mem_table refactoring

2021-01-05 Thread Maxime Coquelin
The goal of this series is to refactor vhost_user_set_mem_table function, to make it easier to understand and maintain. Changes in v2: == - Tag unused args when userfaultfd disabled (Chenbo). Maxime Coquelin (3): vhost: refactor postcopy region registration vhost: refactor postcop

Re: [dpdk-dev] [PATCH] net/ixgbe: clear registers of all queues on VF reset

2021-01-05 Thread Wang, Haiyue
> -Original Message- > From: Ferruh Yigit > Sent: Tuesday, January 5, 2021 18:30 > To: Simon Ellmann ; Wang, Haiyue > ; Guo, Jia > > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] net/ixgbe: clear registers of all queues on > VF reset > > On 1/5/2021 9:02 AM, Simon Ellmann wrote: >

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] pci/windows: fix limit for hardware ID

2021-01-05 Thread Thomas Monjalon
11/12/2020 21:09, Dmitry Kozlyuk: > Length of hardware IDs list is limited by REGSTR_VAL_MAX_HCID_LEN [1], > which is currently 1024. With the old limit of 260, obtaining the list > could fail in a rare occasion of a very long result (no examples known). > This also removes a bogus dependency on th

Re: [dpdk-dev] [PATCH v5] net/i40e: fix flex payload rule conflict issue

2021-01-05 Thread Zhang, Qi Z
> -Original Message- > From: dev On Behalf Of Guo, Jia > Sent: Tuesday, January 5, 2021 11:40 AM > To: Xing, Beilei ; dev@dpdk.org > Cc: sta...@dpdk.org; Sun, Chenmin > Subject: Re: [dpdk-dev] [PATCH v5] net/i40e: fix flex payload rule conflict > issue > > Acked-by: Jeff Guo > > >

Re: [dpdk-dev] [PATCH 4/5] net/iavf: support eCPRI MSG TYPE 0 for AVF FDIR

2021-01-05 Thread Ferruh Yigit
On 12/14/2020 6:49 AM, Junfeng Guo wrote: For eCPRI MSG Type 0, ecpriRtcid/ecpriPcid field within the eCPRI header will be extracted to Field Vector for AVF FDIR. SPEC for eCPRI: http://www.cpri.info/downloads/eCPRI_v_2.0_2019_05_10c.pdf Signed-off-by: Junfeng Guo fixed following checkpatch

Re: [dpdk-dev] [PATCH 3/5] net/iavf: define new bits for eCPRI

2021-01-05 Thread Ferruh Yigit
On 12/14/2020 6:49 AM, Junfeng Guo wrote: Define new bits of protocol header, field and input set for eCPRI. Signed-off-by: Junfeng Guo --- drivers/net/iavf/iavf_generic_flow.h | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/net/iavf/iavf_generic_flow.h b/dri

[dpdk-dev] [PATCH] ci: fix default ccache in GitHub Actions

2021-01-05 Thread David Marchand
'main' might not be the default branch name. Fixes: 87009585e293 ("ci: hook to GitHub Actions") Signed-off-by: David Marchand --- I found no other option but to call to the remote repository since github does not seem to expose a HEAD symbolic reference. The other alternative would be to simply

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] net/ixgbe: fix fdirctrl register setting

2021-01-05 Thread Ferruh Yigit
On 12/22/2020 7:23 AM, Guo, Jia wrote: Acked-by: Jeff Guo -Original Message- From: Zhou, JunX W Sent: Tuesday, December 22, 2020 2:51 PM To: Yu, DapengX ; Guo, Jia Cc: dev@dpdk.org; Yu, DapengX ; sta...@dpdk.org Subject: RE: [dpdk-dev] [PATCH v2] net/ixgbe: fix fdirctrl register sett

Re: [dpdk-dev] [PATCH v6] eal: add generic thread-local-storage functions

2021-01-05 Thread Thomas Monjalon
30/12/2020 12:12, Tal Shnaiderman: > Add support for tls functionality in EAL. You should write TLS uppercase here and below. There is already a TLS capability in rte_per_lcore.h, using __thread keyword. Note: I think the historical wording "lcore" is confusing. We talk about lcore, assuming the

Re: [dpdk-dev] [PATCH v3 0/2] Enhance Async Enqueue for Small Packets

2021-01-05 Thread Wang, Yinan
Tested-by: Wang, Yinan > -Original Message- > From: Hu, Jiayu > Sent: 2020?12?25? 16:29 > To: dev@dpdk.org > Cc: maxime.coque...@redhat.com; Xia, Chenbo ; > Jiang, Cheng1 ; Wang, Yinan > ; Hu, Jiayu > Subject: [PATCH v3 0/2] Enhance Async Enqueue for Small Packets > > Async enqueue off

Re: [dpdk-dev] [PATCH v14 00/12] Arm build options rework

2021-01-05 Thread Pavan Nikhilesh Bhagavatula
>-Original Message- >From: dev On Behalf Of Juraj Linkeš >Sent: Wednesday, December 23, 2020 5:17 PM >To: bruce.richard...@intel.com; ruifeng.w...@arm.com; >honnappa.nagaraha...@arm.com; phil.y...@arm.com; >vcchu...@amazon.com; dharmik.thak...@arm.com; >jerinjac...@gmail.com; hemant.agra

Re: [dpdk-dev] [PATCH v3] net/i40e: issue with ADD VLAN from Guest

2021-01-05 Thread Ferruh Yigit
On 1/5/2021 3:07 AM, Guo, Jia wrote: -Original Message- From: Ferruh Yigit Sent: Tuesday, January 5, 2021 12:43 AM To: Guo, Jia ; Souvik Dey ; Xing, Beilei ; Zhang, Qi Z Cc: dev@dpdk.org; Kevin Traynor ; Luca Boccassi Subject: Re: [dpdk-dev] [PATCH v3] net/i40e: issue with ADD VLAN f

Re: [dpdk-dev] [PATCH] net/ixgbe: clear registers of all queues on VF reset

2021-01-05 Thread Ferruh Yigit
On 1/5/2021 9:02 AM, Simon Ellmann wrote: On 1/4/21 4:56 PM, Ferruh Yigit wrote: On 12/18/2020 2:34 AM, Wang, Haiyue wrote: -Original Message- From: Simon Ellmann Sent: Friday, December 18, 2020 01:15 To: Guo, Jia ; Wang, Haiyue Cc: dev@dpdk.org; Simon Ellmann Subject: [PATCH] net/i

Re: [dpdk-dev] [EXT] [PATCH v3] examples/eventdev: refactor ethdev port stop

2021-01-05 Thread Pavan Nikhilesh Bhagavatula
Hi Feifei, >Move eth stop code from "signal_handler" function to the end of >"main" >function. There are two reasons for this: > >First, this improves code maintenance and makes code look simple and >clear. Based on this change, after receiving the interrupt signal, >"fdata->done" is set as 1. The

Re: [dpdk-dev] [PATCH 2/9] vfio_user: implement lifecycle related APIs

2021-01-05 Thread Xia, Chenbo
Hi Beilei, > -Original Message- > From: Xing, Beilei > Sent: Tuesday, January 5, 2021 4:35 PM > To: Xia, Chenbo ; dev@dpdk.org; tho...@monjalon.net; > david.march...@redhat.com > Cc: step...@networkplumber.org; Liang, Cunming ; Lu, > Xiuchun ; Li, Miao ; Wu, Jingjing > > Subject: RE: [dp

Re: [dpdk-dev] [RFC] vhost: support raising device error

2021-01-05 Thread Maxime Coquelin
Hi Xueming, On 10/26/20 8:25 AM, Xueming Li wrote: > According to virtio spec, The device SHOULD set DEVICE_NEEDS_RESET when > it enters an error state that a reset is needed. If DRIVER_OK is set, > after it sets DEVICE_NEEDS_RESET, the device MUST send a device > configuration change notification

Re: [dpdk-dev] [RFC PATCH v1 4/6] app/eventdev: add release barriers for pipeline test

2021-01-05 Thread Pavan Nikhilesh Bhagavatula
Hi Feifei, >Hi, Pavan > >Sorry for my late reply and thanks very much for your review. > >> -Original Message- >> From: Pavan Nikhilesh Bhagavatula >> Sent: 2020年12月22日 18:33 >> To: Feifei Wang ; jer...@marvell.com; >Harry van >> Haaren ; Pavan Nikhilesh >> >> Cc: dev@dpdk.org; nd ; Honn

[dpdk-dev] [PATCH] net/bnxt: code refactoring changes

2021-01-05 Thread Somnath Kotur
Move all the individual driver fields allocation routines to one routine - bnxt_drv_init(). This houses all such routines where memory needs to be allocated once during the driver's lifetime and does not need to be torn down during error recovery. Rename some function names in accordance with their

Re: [dpdk-dev] [PATCH] net/ixgbe: clear registers of all queues on VF reset

2021-01-05 Thread Simon Ellmann
On 1/4/21 4:56 PM, Ferruh Yigit wrote: On 12/18/2020 2:34 AM, Wang, Haiyue wrote: -Original Message- From: Simon Ellmann Sent: Friday, December 18, 2020 01:15 To: Guo, Jia ; Wang, Haiyue Cc: dev@dpdk.org; Simon Ellmann Subject: [PATCH] net/ixgbe: clear registers of all queues on VF r

[dpdk-dev] [PATCH v2 2/2] bitmap: modify bitmap not empty API for 128B cacheline

2021-01-05 Thread Nithin Dabilpuram
Currently bitmap line not empty check API assumes cache line of 64B and only checks 8 slabs. Since in 128B cacheline, we have 16 slabs per cacheline, rte_bitmap_clear() will mark complete line as empty as soon as 8 slabs are empty thereby breaking bitmap scan functionality. Fix it by defining new _

[dpdk-dev] [PATCH v2 1/2] test/bitmap: test scan after half cline is cleared

2021-01-05 Thread Nithin Dabilpuram
Add a test case to test scan operation post clear of half cacheline of slabs. Also fix meson.build to include test_bitmap.c in the compilation. Signed-off-by: Nithin Dabilpuram --- v2: - No change app/test/meson.build | 1 + app/test/test_bitmap.c | 34 +- 2

Re: [dpdk-dev] [PATCH] ci: fix package installation in GitHub Actions

2021-01-05 Thread David Marchand
Hello Andrew, On Wed, Dec 30, 2020 at 7:00 PM Andrew Boyer wrote: > > Hello David, > I’m hitting this issue on the next/dpdk-next-net branch. Is there a way to > pull the patch into all of the next-* branches so that others don’t hit it > too? Sorry, I was offline, next-* branches are maintain

Re: [dpdk-dev] [PATCH 2/9] vfio_user: implement lifecycle related APIs

2021-01-05 Thread Xing, Beilei
> -Original Message- > From: dev On Behalf Of Chenbo Xia > Sent: Friday, December 18, 2020 3:39 PM > To: dev@dpdk.org; tho...@monjalon.net; david.march...@redhat.com > Cc: step...@networkplumber.org; Liang, Cunming > ; Lu, Xiuchun ; Li, Miao > ; Wu, Jingjing > Subject: [dpdk-dev] [PATC