Re: [dpdk-dev] [PATCH v2 20/33] mlx5/windows: add mlx5 meson file

2020-12-11 Thread Tal Shnaiderman
> Subject: Re: [dpdk-dev] [PATCH v2 20/33] mlx5/windows: add mlx5 meson > file > > External email: Use caution opening links or attachments > > > On Thu, 10 Dec 2020 17:06:35 +0200, Tal Shnaiderman wrote: > > File drivers/common/mlx5/windows/meson.build is added to enable mlx5 > > source files c

Re: [dpdk-dev] [PATCH] net/netvsc: ignore NVS_TYPE_TXTBL_NOTE while executing a sync command

2020-12-11 Thread Long Li
> Subject: Re: [dpdk-dev] [PATCH] net/netvsc: ignore NVS_TYPE_TXTBL_NOTE > while executing a sync command > > On Thu, 10 Dec 2020 23:52:44 -0800 > Long Li wrote: > > > From: Long Li > > > > On netvsc initialization, the host VSP may send a NVS_TYPE_TXTBL_NOTE > > packet while executing a VSP co

Re: [dpdk-dev] [PATCH v2 20/33] mlx5/windows: add mlx5 meson file

2020-12-11 Thread Dmitry Kozlyuk
On Thu, 10 Dec 2020 17:06:35 +0200, Tal Shnaiderman wrote: > File drivers/common/mlx5/windows/meson.build is added to enable mlx5 > source files compilation under common windows directory. > A Devx SDK tool must be installed to export two external H files: > mlx5devx.h and mlx5_ifc_devx.h. The inst

Re: [dpdk-dev] [PATCH] net/virtio-user: fix error run close(0)

2020-12-11 Thread 17826875952
Hi Chenbo, Thanks for your advices! But When I use 'git send-email --to dev@dpdk.org --in-reply-to 1607703293-6121-1-git-send-email-17826875...@163.com --suppress-cc=all 0001-net-virtio-user-fix-run-close-0-and-close-callfd.patch', it still send new same one in patchwork.😭.Please help me delete

Re: [dpdk-dev] [PATCH] eal/windows: add interrupt functions stub

2020-12-11 Thread Dmitry Kozlyuk
On Thu, 10 Dec 2020 16:26:07 -0800, Pallavi Kadam wrote: > Add some missing interrupt implementations on Windows. > Also add respestive functions to export file. > > Signed-off-by: Tal Shnaiderman > Signed-off-by: Pallavi Kadam > Reviewed-by: Ranjit Menon > --- > lib/librte_eal/rte_eal_exports

[dpdk-dev] [PATCH v2] net/netvsc: ignore NVS_TYPE_TXTBL_NOTE while executing a sync command

2020-12-11 Thread Long Li
From: Long Li On netvsc initialization, the host VSP may send a NVS_TYPE_TXTBL_NOTE packet while executing a VSP command synchronously. Instead of returning an error, ignore this packet as we don't use it for DPDK. Cc: sta...@dpdk.org Signed-off-by: Long Li --- drivers/net/netvsc/hn_nvs.c | 7

[dpdk-dev] [PATCH v2] pci/windows: fix limit for hardware ID

2020-12-11 Thread Dmitry Kozlyuk
Length of hardware IDs list is limited by REGSTR_VAL_MAX_HCID_LEN [1], which is currently 1024. With the old limit of 260, obtaining the list could fail in a rare occasion of a very long result (no examples known). This also removes a bogus dependency on the maximum path length. [1]: https://docs

Re: [dpdk-dev] [PATCH v2 1/2] ci: hook to GitHub Actions

2020-12-11 Thread Ferruh Yigit
On 12/4/2020 5:36 PM, David Marchand wrote: With the recent changes in terms of free access to the Travis CI, let's offer an alternative with GitHub Actions. Running jobs on ARM is not supported unless using external runners, so this commit only adds builds for x86_64 and cross compiling for i386

Re: [dpdk-dev] [PATCH] eal/windows: add interrupt functions stub

2020-12-11 Thread Narcisa Ana Maria Vasile
On Thu, Dec 10, 2020 at 04:26:07PM -0800, Pallavi Kadam wrote: > Add some missing interrupt implementations on Windows. > Also add respestive functions to export file. > > Signed-off-by: Tal Shnaiderman > Signed-off-by: Pallavi Kadam > Reviewed-by: Ranjit Menon > --- > lib/librte_eal/rte_eal_e

Re: [dpdk-dev] [PATCH 3/4] usertools: add script to graph crypto perf results

2020-12-11 Thread Stephen Hemminger
On Fri, 11 Dec 2020 17:31:13 + Ciara Power wrote: > + } > +} > \ No newline at end of file > -- Fix your editor please

[dpdk-dev] [PATCH] pci/windows: fix limit for hardware ID

2020-12-11 Thread Dmitry Kozlyuk
Hardware ID length is limited by MAX_DEVICE_ID_LEN [1]. No functional change is intended: new value is 200, and previous one has been 260. However, it's now correct and creates no bogus dependency on path limit. [1]: https://docs.microsoft.com/en-us/windows-hardware/drivers/install/hardware-ids

Re: [dpdk-dev] rte_pktmbuf_pool_create returns EINVAL

2020-12-11 Thread Kamaraj P
Hello All, Looks like the implementation of rte_mempool_populate_default()API changed from dpdk 18.13 to 19.11 version. This to get contiguous memory from the page. Please see the difference in this API. *from dpdk 18.13:* " If we fail to get enough contiguous memory, then we'll go and *from dpd

Re: [dpdk-dev] [PATCH] doc: update documentation for Bluefield platform

2020-12-11 Thread Andrew Boyer
> On Nov 23, 2020, at 3:09 PM, Asaf Penso wrote: > > The documentation file contains some broken links to Mellanox's site. > Also now BlueField-2 platform is supported. > > This patch provides new links and adds documentation for > BlueField-2 platform. > > Signed-off-by: Asaf Penso > --- >

[dpdk-dev] [PATCH 4/4] maintainers: update crypto perf app maintainers

2020-12-11 Thread Ciara Power
This patch adds a maintainer for the crypto perf test application, to cover the new perf test graphing script. Signed-off-by: Ciara Power --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 5e9dc1a1a7..9dd3cb9aef 100644 --- a/MAINTAINERS +++ b/MAIN

[dpdk-dev] [PATCH 3/4] usertools: add script to graph crypto perf results

2020-12-11 Thread Ciara Power
The python script introduced in this patch runs the crypto performance test application for various test cases, and graphs the results. Test cases are defined in the config JSON file, this is where parameters are specified for each test. Currently there are various test cases for devices crypto_qa

[dpdk-dev] [PATCH 2/4] test/cryptodev: improve csv output for perf tests

2020-12-11 Thread Ciara Power
The csv outputs for performance tests were not easily consumed, due to unnecessary whitespaces and capitals. The delimiter is modified to now be "," instead of ";" which was present in some cases. Some unnecessary values were also removed from the output. Signed-off-by: Ciara Power --- app/test-

[dpdk-dev] [PATCH 1/4] test/cryptodev: fix latency test csv output

2020-12-11 Thread Ciara Power
The csv output for the latency performance test had an extra header, "Packet Size", which is a duplicate of "Buffer Size", and had no corresponding value in the output. This is now removed. Fixes: f6cefe253cc8 ("app/crypto-perf: add range/list of sizes") Cc: pablo.de.lara.gua...@intel.com Cc: sta.

[dpdk-dev] [PATCH 0/4] add crypto perf test graphing script

2020-12-11 Thread Ciara Power
This patchset introduces a python script to run various crypto performance test cases, and graph the results in a consumable manner. The test suites can be configured via a JSON file, currently throughput and latency ptests for devices crypto_qat, crypto_aesni_mb and crypto_aesni_gcm are supported.

Re: [dpdk-dev] [PATCH] net/netvsc: ignore NVS_TYPE_TXTBL_NOTE while executing a sync command

2020-12-11 Thread Stephen Hemminger
On Thu, 10 Dec 2020 23:52:44 -0800 Long Li wrote: > From: Long Li > > On netvsc initialization, the host VSP may send a NVS_TYPE_TXTBL_NOTE packet > while executing a VSP command synchronously. > > Ignore this packet as we don't use it for DPDK. > > Cc: sta...@dpdk.org > Signed-off-by: Long L

[dpdk-dev] [PATCH v2] net/virtio-user: fix run close(0) and close callfd

2020-12-11 Thread Jiawei Zhu
From: Jiawei Zhu When i < VIRTIO_MAX_VIRTQUEUES and j == i, dev->callfds[i] and dev->kickfds[i] are default 0. So it will close(0), close the standard input (stdin). And when the code fails in kickfd creation, it will leaves one callfd not closed. Fixes: e6e7ad8b3024 ("net/virtio-user: move even

[dpdk-dev] [PATCH v2] net/virtio-user: fix run close(0) and close callfd

2020-12-11 Thread Jiawei Zhu
From: Jiawei Zhu When i < VIRTIO_MAX_VIRTQUEUES and j == i, dev->callfds[i] and dev->kickfds[i] are default 0. So it will close(0), close the standard input (stdin). And when the code fails in kickfd creation, it will leaves one callfd not closed. Fixes: e6e7ad8b3024 ("net/virtio-user: move even

[dpdk-dev] [PATCH] eal: don't log uninitialized string

2020-12-11 Thread Andrew Boyer
Our Coverity scan pointed out that path[] is never initialized. The official DPDK Coverity has not reported this so there is no public CID for it. Fixes: c44d09811b40 ("eal: add shared indexed file-backed array") Cc: anatoly.bura...@intel.com Cc: sta...@dpdk.org Signed-off-by: Andrew Boyer ---

[dpdk-dev] [PATCH v2] net/virtio-user: fix run close(0) and close callfd

2020-12-11 Thread Jiawei Zhu
From: Jiawei Zhu When i < VIRTIO_MAX_VIRTQUEUES and j == i, dev->callfds[i] and dev->kickfds[i] are default 0. So it will close(0), close the standard input (stdin). And when the code fails in kickfd creation, it will leaves one callfd not closed. Fixes: e6e7ad8b3024 ("net/virtio-user: move even

[dpdk-dev] [PATCH v2] net/virtio-user: fix run close(0) and close callfd

2020-12-11 Thread Jiawei Zhu
From: Jiawei Zhu When i < VIRTIO_MAX_VIRTQUEUES and j == i, dev->callfds[i] and dev->kickfds[i] are default 0. So it will close(0), close the standard input (stdin). And when the code fails in kickfd creation, it will leaves one callfd not closed. Fixes: e6e7ad8b3024 ("net/virtio-user: move even

[dpdk-dev] [PATCH v2] net/virtio-user: fix run close(0) and close callfd

2020-12-11 Thread Jiawei Zhu
From: Jiawei Zhu When i < VIRTIO_MAX_VIRTQUEUES and j == i, dev->callfds[i] and dev->kickfds[i] are default 0. So it will close(0), close the standard input (stdin). And when the code fails in kickfd creationg, it will leaves one callfd not closed. Fixes: e6e7ad8b3024 ("net/virtio-user: move eve

Re: [dpdk-dev] [PATCH] app/testpmd: fix segment number check

2020-12-11 Thread Slava Ovsiienko
Hi, Andrew Thank you for the review, please, see below. > -Original Message- > From: Andrew Boyer > Sent: Friday, December 11, 2020 18:00 > To: Slava Ovsiienko > Cc: dev@dpdk.org; NBU-Contact-Thomas Monjalon ; > ferruh.yi...@intel.com; sta...@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] a

Re: [dpdk-dev] [PATCH] app/testpmd: fix segment number check

2020-12-11 Thread Andrew Boyer
> On Dec 11, 2020, at 10:07 AM, Viacheslav Ovsiienko > wrote: > > The --txpkts command line parameter was silently ignored due to > application was unable to check the Tx queue ring sizes for non > configured ports [1]. ... ignored because the application... > The "set txpkts " was also rej

[dpdk-dev] [RFC PATCH] build/pkg-config: remove machine arch flag

2020-12-11 Thread Bruce Richardson
Traditionally any apps built using DPDK had to support the same instruction sets as supported when the DPDK SDK itself was built, since that was "leaked" through to the end-app and DPDK headers via RTE_MACHINE_CPUFLAG_* values. Therefore, when converting over to meson for app build correctness the

Re: [dpdk-dev] [PATCH] Remove printf from signal handler.

2020-12-11 Thread prateekag
Hi, We reused some code snippets of signal handlers in one of our projects and faced this problem of deadlock when the user sent an interrupt signal (ctrl-C) in quick succession. This is a non-deterministic bug and highly unlikely to be observed frequently. The main idea behind pointing out

Re: [dpdk-dev] [PATCH 2/2] common/sfc_efx/base: check for MAE privilege

2020-12-11 Thread Andrew Rybchenko
On 12/11/20 6:34 PM, Ivan Malov wrote: > VFs can't control MAE, so it's important to override the general > MAE capability bit by taking MAE privilege into account. Reorder > the code slightly to have the privileges queried before datapath > capabilities are discovered and add required MAE privileg

Re: [dpdk-dev] [PATCH 1/2] common/sfc_efx/base: update MCDI headers for MAE privilege

2020-12-11 Thread Andrew Rybchenko
On 12/11/20 6:34 PM, Ivan Malov wrote: > VFs and unprivileged PFs should not be able to control MAE. > Add MAE privilege to MCDI headers in order to reflect that. > > Fixes: 84d3fb7d7e1e ("common/sfc_efx/base: add MAE definitions to MCDI") > Cc: sta...@dpdk.org > > Signed-off-by: Ivan Malov Rev

[dpdk-dev] [PATCH 2/2] common/sfc_efx/base: check for MAE privilege

2020-12-11 Thread Ivan Malov
VFs can't control MAE, so it's important to override the general MAE capability bit by taking MAE privilege into account. Reorder the code slightly to have the privileges queried before datapath capabilities are discovered and add required MAE privilege check. Fixes: eb4e80085fae ("common/sfc_efx/

[dpdk-dev] [PATCH 1/2] common/sfc_efx/base: update MCDI headers for MAE privilege

2020-12-11 Thread Ivan Malov
VFs and unprivileged PFs should not be able to control MAE. Add MAE privilege to MCDI headers in order to reflect that. Fixes: 84d3fb7d7e1e ("common/sfc_efx/base: add MAE definitions to MCDI") Cc: sta...@dpdk.org Signed-off-by: Ivan Malov --- drivers/common/sfc_efx/base/efx_regs_mcdi.h | 54 +++

[dpdk-dev] [PATCH] app/testpmd: fix segment number check

2020-12-11 Thread Viacheslav Ovsiienko
The --txpkts command line parameter was silently ignored due to application was unable to check the Tx queue ring sizes for non configured ports [1]. The "set txpkts " was also rejected if there was some stopped or /unconfigured port. This provides the following: - number of segment check is p

[dpdk-dev] [PATCH] net/mlx5: fix tunnel offload rules validation on VF representor.

2020-12-11 Thread Gregory Etelson
MLX5 PMD implicitly adds vxlan_decap flow action to tunnel offload match type rules. However, VXLAN decap action on VF representors is not supported on MLX5 PMD hardware. The patch rejects attempt to create tunnel offload flow rules on VF representor. Refer: commit 9c4971e5231d ("net/mlx5: update

Re: [dpdk-dev] [EXTERNAL] 19.11.6 patches review and test

2020-12-11 Thread Abhishek Marathe
Hi Luca, No new issues found for 19.11.6 testing. All testcases failed below are due to known issues. Regards, Abhishek Test Results: Test case description: * VERIFY-DPDK-COMPLIANCE - verifies kernel is supported and that the build is successful. * VERIFY-DPDK-BUILD-AND-TESTPMD-TEST - verif

Re: [dpdk-dev] [PATCH v2] license: add licenses for exception cases

2020-12-11 Thread Luca Boccassi
On Fri, 2020-12-11 at 12:49 +, Kevin Traynor wrote: > On 11/12/2020 11:24, Thomas Monjalon wrote: > > 11/12/2020 12:20, Thomas Monjalon: > > > 03/12/2020 10:43, Bruce Richardson: > > > > On Wed, Dec 02, 2020 at 07:01:40PM +, John McNamara wrote: > > > > > The license/exceptions.txt file lis

Re: [dpdk-dev] [PATCH v2] license: add licenses for exception cases

2020-12-11 Thread Kevin Traynor
On 11/12/2020 11:24, Thomas Monjalon wrote: > 11/12/2020 12:20, Thomas Monjalon: >> 03/12/2020 10:43, Bruce Richardson: >>> On Wed, Dec 02, 2020 at 07:01:40PM +, John McNamara wrote: The license/exceptions.txt file lists a small number of files that have licenses that are exceptions t

Re: [dpdk-dev] [PATCH v2 0/4] Enable Checksum Offloading for NEON vector

2020-12-11 Thread Ferruh Yigit
On 11/18/2020 10:48 AM, Feifei Wang wrote: This patch series are mainly to enable checksum offloading for IXGBE NEON vector PMD, including good and bad checksum flags. In the meanwhile, the first patch enable VLAN stripping flag for Arm. Following are the test results for the patches: NICs: 8259

[dpdk-dev] [PATCH] doc: update mlx5 flow MARK action description

2020-12-11 Thread Viacheslav Ovsiienko
There some limitations added for the MARK action value range. Fixes: 2d241515ebaf ("net/mlx5: add devarg for extensive metadata support") Cc: sta...@dpdk.org Signed-off-by: Viacheslav Ovsiienko --- doc/guides/nics/mlx5.rst | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff

[dpdk-dev] [PATCH] net/mlx5: fix buffer split offload advertising

2020-12-11 Thread Viacheslav Ovsiienko
The buffer split Rx offload is not compatible with Multi-Packet Receiving Queue (MPRQ) Rx offload, hence, the buffer split offload flag RTE_ETH_RX_OFFLOAD_BUFFER_SPLIT and other related values should be advertised only if there is no MPRQ engaged. Fixes: 6c8f7f1c1877 ("net/mlx5: report Rx buffer s

Re: [dpdk-dev] [PATCH v2] license: add licenses for exception cases

2020-12-11 Thread Thomas Monjalon
11/12/2020 12:20, Thomas Monjalon: > 03/12/2020 10:43, Bruce Richardson: > > On Wed, Dec 02, 2020 at 07:01:40PM +, John McNamara wrote: > > > The license/exceptions.txt file lists a small number of files > > > that have licenses that are exceptions to the three main > > > licenses defined in th

Re: [dpdk-dev] [PATCH v2] license: add licenses for exception cases

2020-12-11 Thread Thomas Monjalon
03/12/2020 10:43, Bruce Richardson: > On Wed, Dec 02, 2020 at 07:01:40PM +, John McNamara wrote: > > The license/exceptions.txt file lists a small number of files > > that have licenses that are exceptions to the three main > > licenses defined in the Intellectual Property Policy of the > > DPD

[dpdk-dev] [PATCH v1 2/2] linux/kni: Added support for KNI multiple fifos

2020-12-11 Thread dheemanth
In order to improve performance, the KNI is made to support multiple fifos, So that multiple threads pinned to multiple cores can process packets in parallel. Signed-off-by: dheemanth --- app/test/test_kni.c | 4 +- drivers/net/kni/rte_eth_kni.c | 5 +- examples/kni/main.c

[dpdk-dev] DPDK 21.02 Huawei hns3 Roadmap

2020-12-11 Thread oulijun
Hi, Following are the wrok items of hns3 PMD planned for 21.02: New features: [1] Add TM(Traffic Management) support [2] Add PTP(Precise Time Protocol) support [3] Add query optical module info by API [4] Support LSC(Link Status Changed) event [5] Implement tx_done_cleanup API [6]

Re: [dpdk-dev] Faulty VF initialization during DPDK startup when multiple DPDK instances use different VFs with the same PF

2020-12-11 Thread Juraj Linkeš
> -Original Message- > From: Xing, Beilei > Sent: Wednesday, December 9, 2020 1:45 AM > To: Juraj Linkeš ; David Marchand > ; Guo, Jia > Cc: dev@dpdk.org; Kinsella, Ray ; Andrew Yourtchenko > (ayourtch) ; Yigit, Ferruh > Subject: RE: [dpdk-dev] Faulty VF initialization during DPDK star

Re: [dpdk-dev] Napatech pmd

2020-12-11 Thread Michael Lilja
Hi Thomas, The work has not progressed as expected, so we have delays. The intention is still to provide a open source PMD, but at the moment I cannot promise any timelines. Regards, Michael > -Original Message- > From: Thomas Monjalon > Sent: 11. december 2020 09:37 > To: Michael Lil

Re: [dpdk-dev] Napatech pmd

2020-12-11 Thread Thomas Monjalon
Hi Michael, 20/04/2020 07:05, Michael Lilja: > Actually the open-source driver development has been on hold until just > recently, due to other priorities. We just recently allocated a new team to > do the open source driver, a team of people who has not been working with > DPDK before, so the

[dpdk-dev] [PATCH v12 5/6] ci: add aarch64 -> aarch32 cross compiling jobs

2020-12-11 Thread Juraj Linkeš
Add two jobs (static and shared libs), both building on aarch64 and producing 32-bit arm binaries executable on armv8-a, but not armv7. Do not run tests in these jobs. Signed-off-by: Juraj Linkeš Reviewed-by: Ruifeng Wang Acked-by: Aaron Conole --- .ci/linux-build.sh | 7 ++- .travis.yml

[dpdk-dev] [PATCH v12 6/6] doc: add aarch32 build guidance

2020-12-11 Thread Juraj Linkeš
From: Phil Yang Add cross-compiling guidance for 32-bit aarch32 DPDK on aarch64 host. Signed-off-by: Phil Yang Acked-by: Ruifeng Wang --- .../linux_gsg/cross_build_dpdk_for_arm64.rst | 34 +-- 1 file changed, 24 insertions(+), 10 deletions(-) diff --git a/doc/guides/linux_gs

[dpdk-dev] [PATCH v12 4/6] build: add aarch32 to meson cross-compilation

2020-12-11 Thread Juraj Linkeš
Create meson cross file arm32_armv8a_linux_gcc. Use arm-linux-gnueabihf- toolset which comes with standard packages on most used systems, such as Ubuntu and CentOS. Signed-off-by: Juraj Linkeš Acked-by: Ruifeng Wang --- config/arm/arm32_armv8a_linux_gcc | 17 + 1 file changed, 1

[dpdk-dev] [PATCH v12 3/6] build: add aarch32 meson build flags

2020-12-11 Thread Juraj Linkeš
Add aarch32 extra build flags and aarch32 machine flags to generic machine args. Also modify how arm flags are updated in meson build - for 32-bit build, update only if cross-compiling. Signed-off-by: Juraj Linkeš Acked-by: Ruifeng Wang --- config/arm/meson.build | 22 +++--- 1

[dpdk-dev] [PATCH v12 2/6] net/bnxt: fix aarch32 build

2020-12-11 Thread Juraj Linkeš
From: Ruifeng Wang NEON vector path of the PMD needs aarch64 support. But it was enabled for aarch32 build as well because aarch32 build had cpu_family set to aarch64. So build for aarch32 will fail due to unsupported intrinsics. Fixed aarch32 build by updating meson file to execule NEON vector

[dpdk-dev] [PATCH v12 0/6] aarch64 -> aarch32 cross compilation support

2020-12-11 Thread Juraj Linkeš
Add support for aarch32 cross build in meson and add aarch64 -> aarch32 cross build to Travis. Aarch32 is an execution state that allows execution of 32-bit code on armv8 machines. This execution state contains a superset of previous armv7 32-bit instructions and features. Thus the aarch32 build i

[dpdk-dev] [PATCH v12 1/6] net/sfc: fix aarch32 build

2020-12-11 Thread Juraj Linkeš
From: Ruifeng Wang The sfc PMD was enabled for aarch32 which is 32-bit mode but has cpu_family set to aarch64. As sfc support only 64-bit system, it should be disabled for aarch32. Updated meson file to disable sfc for aarch32 build. Fixes: 141d2870675a ("net/sfc: support aarch64 architecture")