Re: [dpdk-dev] [PATCH 2/3] net/i40e: add changes to support i40e PMD on windows

2020-12-05 Thread Dmitry Kozlyuk
On Fri, 4 Dec 2020 17:10:19 -0800, Pallavi Kadam wrote: You could drop "add changes" and "i40e PMD" from subject line, as any commit changes something and topic is "net/i40e" already. > Adding build changes to compile i40e PMD on windows. This is redundant given the commit subject. Please use p

Re: [dpdk-dev] [PATCH 3/3] config/build: ignore enum forward reference warning

2020-12-05 Thread Dmitry Kozlyuk
On Fri, 4 Dec 2020 17:10:20 -0800, Pallavi Kadam wrote: > Warning generated using Clang compiler: > ..\drivers\net\i40e\base/i40e_osdep.h:34:14: warning: forward references > to 'enum' types are a Microsoft extension > [-Wmicrosoft-enum-forward-reference] > typedef enum i40e_status_code i40e_statu

Re: [dpdk-dev] [PATCH 1/5] maintainers: update maintainers file for apistats

2020-12-05 Thread Varghese, Vipin
Look like I am facing `mail delivery` issues to `ntt-tx.co.jp`. ``` The following message to was undeliverable. The reason for the problem: 5.1.0 - Unknown address error 550-'5.1.1 : Recipient address rejected: User unknown in relay recipient table' ``` > -Original Message- > From: dev

Re: [dpdk-dev] [PATCH 0/5] add apistats function

2020-12-05 Thread Varghese, Vipin
Sharing an alternate approach, if RX-TX callbacks are enabled in DPDK (which is by default). One can register a callback handler to update counters with the following information as `port-queue pair, lcoreid, total rx burst request, total empty rx burst, 1-8 pks, 9-16 pkts, 16-32 pkts`. Callback

Re: [dpdk-dev] [PATCH 2/5] app/proc-info: add to use apistats

2020-12-05 Thread Varghese, Vipin
snipped > " --xstats-ids IDLIST: to display xstat values by id. " > "The argument is comma-separated list of xstat ids to > print out.\n" > + " --apistats: to display api statistics, disabled by default\n" As per the code base the logic ` rte_apicou

Re: [dpdk-dev] [PATCH 3/5] app/test-pmd: add to use apistats

2020-12-05 Thread Varghese, Vipin
snipped > --- a/app/test-pmd/testpmd.c > +++ b/app/test-pmd/testpmd.c > @@ -60,6 +60,8 @@ > #ifdef RTE_LIB_LATENCYSTATS > #include > #endif > +#include > + > > #include "testpmd.h" > > @@ -3958,6 +3960,8 @@ main(int argc, char** argv) > } > #endif > > + rte_apistats_init(); Sugg

Re: [dpdk-dev] [PATCH 4/5] docs: add description of apistats parameter into proc-info

2020-12-05 Thread Varghese, Vipin
@Tahhan, Maryam and @Pattan, Reshma should not documentation and code change of proc-info be in the same patch request? > -Original Message- > From: dev On Behalf Of Hideyuki Yamashita > Sent: Friday, December 4, 2020 1:21 PM > To: Tahhan, Maryam ; Pattan, Reshma > > Cc: dev@dpdk.org; H

Re: [dpdk-dev] [PATCH 5/5] librte_ethdev: add to use apistats

2020-12-05 Thread Varghese, Vipin
snipped > + > +int rte_apistats_init(void) > +{ > + int i; > + const struct rte_memzone *mz = NULL; > + const unsigned int flags = 0; > + > + /** Allocate stats in shared memory fo multi process support */ > + if (rte_eal_process_type() == RTE_PROC_SECONDARY) { > + m

[dpdk-dev] [PATCH v2] app/testpmd: fix IP checksum calculation

2020-12-05 Thread George Prekas
Strict-aliasing rules are violated by cast to uint16_t* in flowgen.c and the calculated IP checksum is wrong on GCC 9 and GCC 10. Signed-off-by: George Prekas --- v2: * Instead of a compiler barrier, use a compiler flag. --- app/test-pmd/meson.build | 1 + 1 file changed, 1 insertion(+) diff --