Re: [dpdk-dev] [PATCH v3 3/3] vhost: fix fd leak in kick setup

2020-11-10 Thread Xia, Chenbo
Hi Xueming & Maxime, > -Original Message- > From: Xueming(Steven) Li > Sent: Wednesday, November 11, 2020 2:02 PM > To: Maxime Coquelin ; dev@dpdk.org; Ding, Xuan > ; step...@networkplumber.org; NBU-Contact-Thomas > Monjalon ; sta...@dpdk.org; Xia, Chenbo > > Subject: RE: [dpdk-dev] [PAT

Re: [dpdk-dev] [EXT] Re: [PATCH] maintainers: Update for OcteonTx2 DMA and EP

2020-11-10 Thread Mahipal Challa
-Original Message- From: Radha Mohan Sent: Tuesday, November 10, 2020 11:44 PM To: Radha Chintakuntla ; Satha Koteswara Rao Kottidi ; Mahipal Challa Cc: dev@dpdk.org; Thomas Monjalon ; Veerasenareddy Burru ; Satananda Burla ; Jerin Jacob Kollanukkaran Subject: [EXT] Re: [dpdk-dev]

[dpdk-dev] [PATCH 3/5] net/mlx5: fix ASO age pools resize error flow

2020-11-10 Thread Michael Baum
In ASO age pools resize, the PMD starts ASO data-path. When starting ASO data-path is failed, the pools memory was not freed what caused a memory leak. Free it. Fixes: f935ed4b645a ("net/mlx5: support flow hit action for aging") Signed-off-by: Michael Baum Acked-by: Matan Azrad --- drivers/n

[dpdk-dev] [PATCH 4/5] net/mlx5: fix compiler code arrangement in probe

2020-11-10 Thread Michael Baum
Bonding adjustment is done only when DEVX_PORT is supported in the rdma-core. Some bonding condition was done even when DEVX_PORT is not supported. Remove it. Fixes: 2eb4d0107acc ("net/mlx5: refactor PCI probing on Linux") Cc: sta...@dpdk.org Signed-off-by: Michael Baum Acked-by: Matan Azrad

[dpdk-dev] [PATCH 5/5] common/mlx5: fix flex parser creation error flow

2020-11-10 Thread Michael Baum
From: Michael Baum The mlx5_devx_cmd_create_flex_parser function defines a local array (with constant size) named in, and then allocates a pointer to mlx5_devx_obj structure by the mlx5_malloc function. If the allocation fails, the function releases the array in and returns NULL. However, the ar

[dpdk-dev] [PATCH 2/5] net/mlx5: fix Rx queue creation error flow

2020-11-10 Thread Michael Baum
In Rx queue creation, there is a validation for the Rx configuration. When scatter offload validation for buffer split is failed, the Rx queue object memory was not freed what caused a memory leak. Free it. Fixes: a0a45e8af723 ("net/mlx5: configure Rx queue for buffer split") Signed-off-by: Mic

[dpdk-dev] [PATCH 1/5] net/mlx5: fix unused calculation in RSS expansion

2020-11-10 Thread Michael Baum
The RSS flow expansion get a memory buffer to fill the new patterns of the expanded flows. This memory management saves the next address to write into the buffer in a dedicated variable. The calculation for the next address was wrongly also done when all the patterns were ready. Remove it. Fixes

Re: [dpdk-dev] [PATCH] net/tap: Allow all-zero checksum for UDP over IPv4

2020-11-10 Thread Michael Pfeiffer
Hi, On Tue, 2020-11-10 at 15:59 +, Ferruh Yigit wrote: > On 11/9/2020 2:22 PM, Michael Pfeiffer wrote: > > Unlike TCP, UDP checksums are optional and may be zero to indicate "not > > set" [RFC 768] (except for IPv6, where this prohibited [RFC 8200]). Add > > this special case to the checksum o

[dpdk-dev] [PATCH 4/4] net/mlx5: fix tunnel offload callback names

2020-11-10 Thread Gregory Etelson
Fix mlx5_flow_tunnel_action_release and mlx5_flow_tunnel_item_release callback names to match tunnel offload names pattern. Fixes: 4ec6360de37d ("net/mlx5: implement tunnel offload") Signed-off-by: Gregory Etelson --- drivers/net/mlx5/mlx5_flow.c | 17 + 1 file changed, 9 insert

[dpdk-dev] [PATCH 1/4] net/mlx5: fix offloaded tunnel allocation

2020-11-10 Thread Gregory Etelson
The original patch allocated tunnel offload objects with invalid indexes. As the result, PMD tunnel object allocation failed. In this patch indexed pool provides both an index and memory for a new tunnel offload object. Also tunnel offload ipool moved to dv enabled code only. Fixes: f2e8093 ("net

[dpdk-dev] [PATCH 2/4] net/mlx5: fix tunnel offload hub multi-thread protection

2020-11-10 Thread Gregory Etelson
The original patch was removing active tunnel offload objects from a tunnels db list. That action was leading to a PMD crash. Current patch isolates tunnels db list into a separate API. That API manages MT protection of the tunnel offload db. Fixes: e4f5880 ("net/mlx5: make tunnel hub list thread

[dpdk-dev] [PATCH 3/4] net/mlx5: fix PMD crash after tunnel offload match rule destruction

2020-11-10 Thread Gregory Etelson
The new flow table resource management API triggered a PMD crash in tunnel offload mode, when tunnel match flow rule was inserted before tunnel set rule. Reason for the crash was double flow table registration. The table was registered by the tunnel offload code for the first time and once more by

[dpdk-dev] [PATCH 0/4] restore tunnel offload functionality in mlx5

2020-11-10 Thread Gregory Etelson
post merge fixes to restore tunnel offload functionality in mlx5 Signed-off-by: Gregory Etelson Acked-by: Viacheslav Ovsiienko Gregory Etelson (4): net/mlx5: fix offloaded tunnel allocation net/mlx5: fix tunnel offload hub multi-thread protection net/mlx5: fix PMD crash after tunnel offlo

Re: [dpdk-dev] [PATCH] net/tap: Allow all-zero checksum for UDP over IPv4

2020-11-10 Thread Morten Brørup
> From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] > Sent: Tuesday, November 10, 2020 6:43 PM > > On 11/10/2020 4:01 PM, Morten Brørup wrote: > >> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ferruh Yigit > >> Sent: Tuesday, November 10, 2020 3:47 PM > >> > >> On 11/9/2020 2:22 PM, Micha

[dpdk-dev] [PATCH v2 33/37] net/txgbe: add IPsec context creation

2020-11-10 Thread Jiawen Wu
Initialize securiry context, and add support to get security capabilities. Signed-off-by: Jiawen Wu --- doc/guides/nics/features/txgbe.ini | 1 + drivers/net/txgbe/meson.build | 3 +- drivers/net/txgbe/txgbe_ethdev.c | 13 +++ drivers/net/txgbe/txgbe_ethdev.h | 3 + drivers/net/t

[dpdk-dev] [PATCH v2 24/37] net/txgbe: add flow API destroy function

2020-11-10 Thread Jiawen Wu
Add support to destroy operation for flow API. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/txgbe_flow.c | 128 + 1 file changed, 128 insertions(+) diff --git a/drivers/net/txgbe/txgbe_flow.c b/drivers/net/txgbe/txgbe_flow.c index 4141352bf..8d5362175 100644 --

[dpdk-dev] [PATCH v2 37/37] net/txgbe: add security type in flow action

2020-11-10 Thread Jiawen Wu
Add security type in flow action. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/txgbe_flow.c | 52 + drivers/net/txgbe/txgbe_ipsec.c | 30 +++ drivers/net/txgbe/txgbe_ipsec.h | 3 ++ 3 files changed, 85 insertions(+) diff --git a/drivers/net/tx

[dpdk-dev] [PATCH v2 35/37] net/txgbe: support security session destroy

2020-11-10 Thread Jiawen Wu
Add support to clear a security session's private data, get the size of a security session, add update the mbuf with provided metadata. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/txgbe_ipsec.c | 167 drivers/net/txgbe/txgbe_ipsec.h | 15 +++ 2 files changed,

[dpdk-dev] [PATCH v2 32/37] net/txgbe: add macsec setting

2020-11-10 Thread Jiawen Wu
Add macsec register enable and setting reset operations. Add macsec offload suuport. Signed-off-by: Jiawen Wu --- doc/guides/nics/features/txgbe.ini | 1 + drivers/net/txgbe/txgbe_ethdev.c | 87 ++ drivers/net/txgbe/txgbe_ethdev.h | 17 ++ drivers/net/txgbe/t

[dpdk-dev] [PATCH v2 36/37] net/txgbe: add security offload in Rx and Tx process

2020-11-10 Thread Jiawen Wu
Add security offload in Rx and Tx process. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/txgbe_ipsec.c | 106 drivers/net/txgbe/txgbe_ipsec.h | 1 + drivers/net/txgbe/txgbe_rxtx.c | 93 +++- drivers/net/txgbe/txgbe_rxtx.h | 13

[dpdk-dev] [PATCH v2 34/37] net/txgbe: add security session create operation

2020-11-10 Thread Jiawen Wu
Add support to configure a security session. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/txgbe_ethdev.h | 6 + drivers/net/txgbe/txgbe_ipsec.c | 250 +++ drivers/net/txgbe/txgbe_ipsec.h | 66 3 files changed, 322 insertions(+) diff --git a/drivers/ne

[dpdk-dev] [PATCH v2 29/37] net/txgbe: support TM shaper profile add and delete

2020-11-10 Thread Jiawen Wu
Support traffic manager profile add and delete operations. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/txgbe_tm.c | 129 +++ 1 file changed, 129 insertions(+) diff --git a/drivers/net/txgbe/txgbe_tm.c b/drivers/net/txgbe/txgbe_tm.c index 545590ba2..8adb03825 1

[dpdk-dev] [PATCH v2 31/37] net/txgbe: add TM hierarchy commit

2020-11-10 Thread Jiawen Wu
Add traffic manager hierarchy commit. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/txgbe_tm.c | 70 1 file changed, 70 insertions(+) diff --git a/drivers/net/txgbe/txgbe_tm.c b/drivers/net/txgbe/txgbe_tm.c index 6dd593e54..b8edd78bf 100644 --- a/drivers/ne

[dpdk-dev] [PATCH v2 30/37] net/txgbe: support TM node add and delete

2020-11-10 Thread Jiawen Wu
Support traffic manager node add and delete operations. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/txgbe_ethdev.h | 1 + drivers/net/txgbe/txgbe_tm.c | 488 +++ 2 files changed, 489 insertions(+) diff --git a/drivers/net/txgbe/txgbe_ethdev.h b/drivers/net/t

[dpdk-dev] [PATCH v2 22/37] net/txgbe: add generic flow API

2020-11-10 Thread Jiawen Wu
Add flow API with generic flow operaions, validate first. Signed-off-by: Jiawen Wu --- doc/guides/nics/features/txgbe.ini | 1 + doc/guides/nics/txgbe.rst | 1 + drivers/net/txgbe/txgbe_ethdev.c | 25 drivers/net/txgbe/txgbe_ethdev.h | 2 + drivers/net/txgbe/txgbe_fl

[dpdk-dev] [PATCH v2 27/37] net/txgbe: add TM configuration init and uninit

2020-11-10 Thread Jiawen Wu
Add traffic manager configuration init and uninit operations. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/meson.build| 1 + drivers/net/txgbe/txgbe_ethdev.c | 16 + drivers/net/txgbe/txgbe_ethdev.h | 60 drivers/net/txgbe/txgbe_tm.c | 57 +

[dpdk-dev] [PATCH v2 28/37] net/txgbe: add TM capabilities get operation

2020-11-10 Thread Jiawen Wu
Add support to get traffic manager capabilities. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/txgbe_ethdev.c | 1 + drivers/net/txgbe/txgbe_ethdev.h | 9 + drivers/net/txgbe/txgbe_tm.c | 278 +++ 3 files changed, 288 insertions(+) diff --git a/drivers/net/t

[dpdk-dev] [PATCH v2 26/37] net/txgbe: support UDP tunnel port add and delete

2020-11-10 Thread Jiawen Wu
Support UDP tunnel port add and delete operations. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/txgbe_ethdev.c | 105 +++ 1 file changed, 105 insertions(+) diff --git a/drivers/net/txgbe/txgbe_ethdev.c b/drivers/net/txgbe/txgbe_ethdev.c index 881ccaa57..5eaeaa0a9 1

[dpdk-dev] [PATCH v2 25/37] net/txgbe: add flow API flush function

2020-11-10 Thread Jiawen Wu
Add support to flush operation for flow API. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/base/txgbe_hw.c | 87 +++ drivers/net/txgbe/base/txgbe_hw.h | 1 + drivers/net/txgbe/txgbe_ethdev.c | 21 drivers/net/txgbe/txgbe_ethdev.h | 2 + drivers/net/txgbe

[dpdk-dev] [PATCH v2 23/37] net/txgbe: add flow API create function

2020-11-10 Thread Jiawen Wu
Add support to create operation for flow API. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/txgbe_ethdev.h | 2 + drivers/net/txgbe/txgbe_fdir.c | 27 drivers/net/txgbe/txgbe_flow.c | 257 +++ 3 files changed, 286 insertions(+) diff --git a/drivers/net/t

[dpdk-dev] [PATCH v2 20/37] net/txgbe: add RSS filter restore operation

2020-11-10 Thread Jiawen Wu
Add restore operation on RSS filter. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/txgbe_ethdev.c | 12 + drivers/net/txgbe/txgbe_ethdev.h | 7 +++ drivers/net/txgbe/txgbe_rxtx.c | 76 3 files changed, 95 insertions(+) diff --git a/drivers/net/txgbe/txgb

[dpdk-dev] [PATCH v2 19/37] net/txgbe: add RSS filter parse rule

2020-11-10 Thread Jiawen Wu
Add support to parse flow for RSS filter. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/txgbe_ethdev.h | 8 +++ drivers/net/txgbe/txgbe_flow.c | 114 +++ drivers/net/txgbe/txgbe_rxtx.c | 20 ++ 3 files changed, 142 insertions(+) diff --git a/drivers/net/t

[dpdk-dev] [PATCH v2 21/37] net/txgbe: add filter list init and uninit

2020-11-10 Thread Jiawen Wu
Add filter list init and uninit. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/txgbe_ethdev.c | 6 ++ drivers/net/txgbe/txgbe_ethdev.h | 8 ++ drivers/net/txgbe/txgbe_flow.c | 127 +++ 3 files changed, 141 insertions(+) diff --git a/drivers/net/txgbe/txgbe_eth

[dpdk-dev] [PATCH v2 18/37] net/txgbe: add FDIR restore operation

2020-11-10 Thread Jiawen Wu
Add restore operation on FDIR filter. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/txgbe_ethdev.c | 1 + drivers/net/txgbe/txgbe_ethdev.h | 2 ++ drivers/net/txgbe/txgbe_fdir.c | 34 3 files changed, 37 insertions(+) diff --git a/drivers/net/txgbe/txgbe_et

[dpdk-dev] [PATCH v2 09/37] net/txgbe: add L2 tunnel filter init and uninit

2020-11-10 Thread Jiawen Wu
Add L2 tunnel filter init and uninit. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/txgbe_ethdev.c | 65 drivers/net/txgbe/txgbe_ethdev.h | 32 2 files changed, 97 insertions(+) diff --git a/drivers/net/txgbe/txgbe_ethdev.c b/drivers/net/txgbe/

[dpdk-dev] [PATCH v2 16/37] net/txgbe: add FDIR parse normal rule

2020-11-10 Thread Jiawen Wu
Add support to parse flow for fdir filter. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/base/txgbe_type.h | 10 + drivers/net/txgbe/txgbe_flow.c | 856 2 files changed, 866 insertions(+) diff --git a/drivers/net/txgbe/base/txgbe_type.h b/drivers/net/txgbe/b

[dpdk-dev] [PATCH v2 17/37] net/txgbe: add FDIR parse tunnel rule

2020-11-10 Thread Jiawen Wu
Add support to parse tunnel flow for fdir filter. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/base/txgbe_type.h | 8 + drivers/net/txgbe/txgbe_flow.c | 290 2 files changed, 298 insertions(+) diff --git a/drivers/net/txgbe/base/txgbe_type.h b/drivers/net/

[dpdk-dev] [PATCH v2 15/37] net/txgbe: support FDIR add and delete operations

2020-11-10 Thread Jiawen Wu
Support add and delete operations on flow director. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/base/txgbe_type.h | 11 + drivers/net/txgbe/txgbe_ethdev.h| 16 + drivers/net/txgbe/txgbe_fdir.c | 472 +++- 3 files changed, 498 insertions(+), 1 deletion(-) di

[dpdk-dev] [PATCH v2 12/37] net/txgbe: add L2 tunnel filter parse rule

2020-11-10 Thread Jiawen Wu
Add support to parse flow for L2 tunnel filter. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/txgbe_flow.c | 202 + 1 file changed, 202 insertions(+) diff --git a/drivers/net/txgbe/txgbe_flow.c b/drivers/net/txgbe/txgbe_flow.c index 7110e594b..8589e3328 100644 -

[dpdk-dev] [PATCH v2 11/37] net/txgbe: support L2 tunnel filter add and delete

2020-11-10 Thread Jiawen Wu
Support L2 tunnel filter add and delete operations. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/txgbe_ethdev.c | 230 +++ drivers/net/txgbe/txgbe_ethdev.h | 18 +++ 2 files changed, 248 insertions(+) diff --git a/drivers/net/txgbe/txgbe_ethdev.c b/drivers/net/txg

[dpdk-dev] [PATCH v2 14/37] net/txgbe: configure FDIR filter

2020-11-10 Thread Jiawen Wu
Configure flow director filter with it enabled. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/base/txgbe_type.h | 6 + drivers/net/txgbe/meson.build | 1 + drivers/net/txgbe/txgbe_ethdev.c| 6 + drivers/net/txgbe/txgbe_ethdev.h| 6 + drivers/net/txgbe/txgbe_fdir.c | 4

[dpdk-dev] [PATCH v2 04/37] net/txgbe: support ntuple filter remove operaion

2020-11-10 Thread Jiawen Wu
Support remove operation on ntuple filter. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/txgbe_ethdev.c | 11 +++ drivers/net/txgbe/txgbe_ethdev.h | 2 ++ 2 files changed, 13 insertions(+) diff --git a/drivers/net/txgbe/txgbe_ethdev.c b/drivers/net/txgbe/txgbe_ethdev.c index 3a31d4bba

[dpdk-dev] [PATCH v2 13/37] net/txgbe: add FDIR filter init and uninit

2020-11-10 Thread Jiawen Wu
Add flow director filter init and uninit operations. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/base/txgbe_type.h | 29 + drivers/net/txgbe/txgbe_ethdev.c| 63 + drivers/net/txgbe/txgbe_ethdev.h| 51 +++ 3 files changed, 143

[dpdk-dev] [PATCH v2 06/37] net/txgbe: add ethertype parse rule

2020-11-10 Thread Jiawen Wu
Add support to parse flow for ethertype filter. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/txgbe_flow.c | 250 + 1 file changed, 250 insertions(+) diff --git a/drivers/net/txgbe/txgbe_flow.c b/drivers/net/txgbe/txgbe_flow.c index 6f8be3b7f..fc2505ddc 100644 -

[dpdk-dev] [PATCH v2 10/37] net/txgbe: config L2 tunnel filter with e-tag

2020-11-10 Thread Jiawen Wu
Config L2 tunnel filter with e-tag. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/txgbe_ethdev.c | 63 1 file changed, 63 insertions(+) diff --git a/drivers/net/txgbe/txgbe_ethdev.c b/drivers/net/txgbe/txgbe_ethdev.c index 3418841b6..21369d40f 100644 --- a/driv

[dpdk-dev] [PATCH v2 03/37] net/txgbe: add ntuple parse rule

2020-11-10 Thread Jiawen Wu
Add support to parse flow for ntuple filter. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/meson.build | 1 + drivers/net/txgbe/txgbe_flow.c | 536 + 2 files changed, 537 insertions(+) create mode 100644 drivers/net/txgbe/txgbe_flow.c diff --git a/drivers/ne

[dpdk-dev] [PATCH v2 05/37] net/txgbe: support ethertype filter add and delete

2020-11-10 Thread Jiawen Wu
Support add and delete operaions on ethertype filter. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/txgbe_ethdev.c | 111 +++ drivers/net/txgbe/txgbe_ethdev.h | 19 ++ 2 files changed, 130 insertions(+) diff --git a/drivers/net/txgbe/txgbe_ethdev.c b/drivers/ne

[dpdk-dev] [PATCH v2 07/37] net/txgbe: support syn filter add and delete

2020-11-10 Thread Jiawen Wu
Support add and delete operations on syn filter. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/txgbe_ethdev.c | 70 drivers/net/txgbe/txgbe_ethdev.h | 6 +++ 2 files changed, 76 insertions(+) diff --git a/drivers/net/txgbe/txgbe_ethdev.c b/drivers/net/txgbe/tx

[dpdk-dev] [PATCH v2 08/37] net/txgbe: add syn filter parse rule

2020-11-10 Thread Jiawen Wu
Add support to parse flow for syn filter. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/txgbe_flow.c | 256 + 1 file changed, 256 insertions(+) diff --git a/drivers/net/txgbe/txgbe_flow.c b/drivers/net/txgbe/txgbe_flow.c index fc2505ddc..7110e594b 100644 --- a/d

[dpdk-dev] [PATCH v2 00/37] net: add txgbe PMD part 2

2020-11-10 Thread Jiawen Wu
This patch adds the rest of txgbe PMD for its PF part. Support include flow API, traffic manager, macsec and ipsec. v2: - Rebase on next-net Jiawen Wu (37): net/txgbe: add ntuple filter init and uninit net/txgbe: support ntuple filter add and delete net/txgbe: add ntuple parse rule net/tx

[dpdk-dev] [PATCH v2 02/37] net/txgbe: support ntuple filter add and delete

2020-11-10 Thread Jiawen Wu
Support add and delete operations on ntuple filter. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/txgbe_ethdev.c | 310 +++ drivers/net/txgbe/txgbe_ethdev.h | 6 + 2 files changed, 316 insertions(+) diff --git a/drivers/net/txgbe/txgbe_ethdev.c b/drivers/net/txgbe

[dpdk-dev] [PATCH v2 01/37] net/txgbe: add ntuple filter init and uninit

2020-11-10 Thread Jiawen Wu
Add ntuple filter init and uninit. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/base/txgbe_type.h | 1 + drivers/net/txgbe/txgbe_ethdev.c| 28 drivers/net/txgbe/txgbe_ethdev.h| 33 + 3 files changed, 62 insertions(+) diff --git a/d

[dpdk-dev] [PATCH v1] net/iavf: fix RSS queue region size exceeds

2020-11-10 Thread Ting Xu
When a rule is set to do RSS to redirect flows to a group of queues, the queue region size should not be larger than the max RSS queue region supported by HW. This patch added the step to check the queue region size, and report failure if the size does not meet the requirement. Fixes: e436cd43835b

[dpdk-dev] [PATCH v1 1/1] net/hinic/base: add message check for command channel

2020-11-10 Thread Guoyang Zhou
In the command channel, a message may has several fragments, and the several fragments should have same message id. To prevent problems, this check is added. Fixes: 1e4593db1d58 ("net/hinic/base: fix log info for PF command channel") Cc: sta...@dpdk.org Signed-off-by: Guoyang Zhou --- drivers/ne

[dpdk-dev] [PATCH v1 0/1] add message id check for command channel

2020-11-10 Thread Guoyang Zhou
In the command channel, a message may has several fragments, and the several fragments should have same message id. To prevent problems, this check is added. -- v1: - add message id check for command channel Guoyang Zhou (1): net/hinic/base: add message check for command channel drivers/ne

Re: [dpdk-dev] [PATCH v3 2/3] vhost: fix fd leak in dirty logging setup

2020-11-10 Thread Xueming(Steven) Li
>-Original Message- >From: dev On Behalf Of Maxime Coquelin >Sent: Monday, November 9, 2020 8:16 PM >To: dev@dpdk.org; xuan.d...@intel.com; step...@networkplumber.org; >NBU-Contact-Thomas Monjalon ; sta...@dpdk.org; >chenbo@intel.com >Cc: Maxime Coquelin >Subject: [dpdk-dev] [PATCH

Re: [dpdk-dev] [PATCH v3 1/3] vhost: fix error path when setting memory tables

2020-11-10 Thread Xueming(Steven) Li
Hi Maxime, >-Original Message- >From: dev On Behalf Of Maxime Coquelin >Sent: Monday, November 9, 2020 8:16 PM >To: dev@dpdk.org; xuan.d...@intel.com; step...@networkplumber.org; >NBU-Contact-Thomas Monjalon ; sta...@dpdk.org; >chenbo@intel.com >Cc: Maxime Coquelin >Subject: [dpdk-de

Re: [dpdk-dev] [PATCH v3 3/3] vhost: fix fd leak in kick setup

2020-11-10 Thread Xueming(Steven) Li
Hi Maxime, Near end of this function, if vhost_check_queue_inflights_packed() and vhost_check_queue_inflights_split() return with error, is the fd expected to be closed by closing vq? >-Original Message- >From: dev On Behalf Of Maxime Coquelin >Sent: Monday, November 9, 2020 8:17 PM >To:

Re: [dpdk-dev] [PATCH v1] net/iavf: fix cannot release mbufs issue

2020-11-10 Thread Wu, Jingjing
> -Original Message- > From: Xu, Ting > Sent: Wednesday, November 11, 2020 11:07 AM > To: dev@dpdk.org > Cc: Zhang, Qi Z ; Xing, Beilei ; > Wu, Jingjing ; Xu, Ting ; > sta...@dpdk.org > Subject: [PATCH v1] net/iavf: fix cannot release mbufs issue > > In the function _iavf_rx_queue_rele

Re: [dpdk-dev] [PATCH v2 2/3] vfio: fix DMA mapping granularity for type1 iova as va

2020-11-10 Thread Nithin Dabilpuram
On Tue, Nov 10, 2020 at 02:17:39PM +, Burakov, Anatoly wrote: > On 05-Nov-20 9:04 AM, Nithin Dabilpuram wrote: > > Partial unmapping is not supported for VFIO IOMMU type1 > > by kernel. Though kernel gives return as zero, the unmapped size > > returned will not be same as expected. So check for

[dpdk-dev] [PATCH] doc: update firmware/driver mapping table for i40e

2020-11-10 Thread Shougang Wang
Update i40e PMD firmware/driver mapping table. Signed-off-by: Shougang Wang --- doc/guides/nics/i40e.rst | 4 1 file changed, 4 insertions(+) diff --git a/doc/guides/nics/i40e.rst b/doc/guides/nics/i40e.rst index 828a25988..961a51820 100644 --- a/doc/guides/nics/i40e.rst +++ b/doc/guides/n

[dpdk-dev] [PATCH v1] net/iavf: fix cannot release mbufs issue

2020-11-10 Thread Ting Xu
In the function _iavf_rx_queue_release_mbufs_vec to release rx mbufs, rxq->rxrearm_nb is given the value of rx descriptor number at last. However, since the process to release and allocate mbufs lacks the initialization of rxrearm_nb, if we try to release mbufs next time, it will return without rel

Re: [dpdk-dev] [PATCH] net/ice: fix mismatched hash flds with hdrs

2020-11-10 Thread Xu, HailinX
Tested-by: Xu, HailinX Regards, Xu, Hailin > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Junfeng Guo > Sent: Tuesday, November 10, 2020 4:45 PM > To: Zhang, Qi Z ; Wu, Jingjing ; > Xing, Beilei > Cc: dev@dpdk.org; Guo, Junfeng > Subject: [dpdk-dev] [PAT

Re: [dpdk-dev] [PATCH v1] examples/vhost: fix string split error handling issue

2020-11-10 Thread Jiang, Cheng1
Hi, > -Original Message- > From: Maxime Coquelin > Sent: Tuesday, November 10, 2020 5:35 PM > To: Jiang, Cheng1 ; Xia, Chenbo > > Cc: dev@dpdk.org; Fu, Patrick ; Yang, YvonneX > > Subject: Re: [PATCH v1] examples/vhost: fix string split error handling issue > > > > On 11/6/20 4:23 AM

Re: [dpdk-dev] [PATCH v1 27/72] common/mlx5/windows: add OS alloc/dealloc pd

2020-11-10 Thread Narcisa Ana Maria Vasile
On Tue, Oct 27, 2020 at 11:22:50PM +, Ophir Munk wrote: > From: Tal Shnaiderman > > Implement Windows API mlx5_os_alloc_pd() and mlx5_os_dealloc_pd(). They > are equivalent to the Linux implementation. > > Signed-off-by: Tal Shnaiderman > Acked-by: Matan Azrad > --- > drivers/common/mlx5/

Re: [dpdk-dev] [PATCH v1 34/72] net/mlx5/windows: implement mlx5 mac addr add

2020-11-10 Thread Narcisa Ana Maria Vasile
On Tue, Oct 27, 2020 at 11:22:57PM +, Ophir Munk wrote: > From: Tal Shnaiderman > > Get the list of MAC addresses and verify if the input mac parameter > already exists. If not - return -ENOTSUP (as Windows does not support > adding new MAC addresses). If the MAC address exists (EEXIST) retur

Re: [dpdk-dev] [PATCH v1 42/72] common/mlx5/windows: add DevX UAR getters

2020-11-10 Thread Narcisa Ana Maria Vasile
On Tue, Oct 27, 2020 at 11:23:05PM +, Ophir Munk wrote: > The following getters are added: mlx5_os_get_devx_uar_mmap_offset, > mlx5_os_get_devx_uar_base_addr, mlx5_os_get_devx_uar_reg_addr, > mlx5_os_get_devx_uar_page_id. This commit is the Windows equivalent of > the Linux implementation in (

Re: [dpdk-dev] [PATCH v1 48/72] net/mlx5/windows: support link update

2020-11-10 Thread Narcisa Ana Maria Vasile
On Tue, Oct 27, 2020 at 11:23:11PM +, Ophir Munk wrote: > From: Tal Shnaiderman > > Add support for mlx5_link_update() to get link speed and link state. > Other parameters are currently hard-coded. > > Signed-off-by: Tal Shnaiderman > --- > drivers/net/mlx5/windows/mlx5_ethdev_os.c | 39 >

Re: [dpdk-dev] [PATCH v1 59/72] net/mlx5/windows: support VF PCI address

2020-11-10 Thread Narcisa Ana Maria Vasile
On Tue, Oct 27, 2020 at 11:23:22PM +, Ophir Munk wrote: > From: Tal Shnaiderman > > Support VF BDF scanning by checking both the BDF and raw BDF provided by > DevX. In Linux a PCI address is formatted as: domain, bus, device, > function (DBDF). This is right for both a PF and a VF. In Window

Re: [dpdk-dev] [PATCH v1 57/72] net/mlx5/windows: initial probing implementation

2020-11-10 Thread Narcisa Ana Maria Vasile
On Tue, Oct 27, 2020 at 11:23:20PM +, Ophir Munk wrote: > From: Tal Shnaiderman > > This commit implements mlx5_os_pci_probe API under Windows. It does all > required initializations then it gets the PCI device list using glue API > get_device_list(). Next, all non MLX5 matched devices are f

Re: [dpdk-dev] [PATCH v1 58/72] net/mlx5/windws: spawn eth devices

2020-11-10 Thread Narcisa Ana Maria Vasile
On Tue, Oct 27, 2020 at 11:23:21PM +, Ophir Munk wrote: > This commit implements mlx5_dev_spawn() API which allocates an eth > device (struct rte_eth_dev) for each PCI device. When working with > representors virtual functions (as in Linux), one PCI device may spawn > several eth devices: the m

Re: [dpdk-dev] [PATCH v9 6/6] doc: update release notes now for block allow changes

2020-11-10 Thread Stephen Hemminger
> > > Are all the other macro changes non-user visible? Do they need to be called > out somewhere, or is the above enough? > There are some internal enums used to pass things around but they should never have been used directly anyway. We don't have a way to mark macros and enums as internal

[dpdk-dev] [PATCH v10 4/7] doc: update documentation to reflect new options

2020-11-10 Thread Stephen Hemminger
Replace old option syntax -w with -a and update any wording around blacklisting. Signed-off-by: Stephen Hemminger --- doc/guides/cryptodevs/dpaa2_sec.rst | 6 ++-- doc/guides/cryptodevs/dpaa_sec.rst| 6 ++-- doc/guides/cryptodevs/qat.rst | 12 doc

[dpdk-dev] [PATCH v10 7/7] eal: mark old definitions as deprecated

2020-11-10 Thread Stephen Hemminger
This patch marks the compatiablity macros with RTE_DEPRECATED which causes a warning if used. There are no remaining warnings in the current release. Signed-off-by: Stephen Hemminger --- lib/librte_eal/include/rte_bus.h | 6 -- lib/librte_eal/include/rte_dev.h | 6 -- lib/librte

[dpdk-dev] [PATCH v10 6/7] auto test comment fix

2020-11-10 Thread Stephen Hemminger
--- app/test/autotest_runner.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/test/autotest_runner.py b/app/test/autotest_runner.py index 72c40e85fdd2..8aa4d45569db 100644 --- a/app/test/autotest_runner.py +++ b/app/test/autotest_runner.py @@ -279,7 +279,7 @@ def __filter

[dpdk-dev] [PATCH v10 5/7] app/test: use new allowlist and blocklist

2020-11-10 Thread Stephen Hemminger
Test the renamed blocklist and allowlist arguments. Use new terms in test variable names as well. Signed-off-by: Stephen Hemminger Acked-by: Luca Boccassi --- app/test/autotest.py| 16 +-- app/test/autotest_runner.py | 18 ++--- app/test/test.c | 2 +- app/t

[dpdk-dev] [PATCH v10 3/7] eal: replace pci-whitelist/pci-blacklist options

2020-11-10 Thread Stephen Hemminger
Replace -w / --pci-whitelist with -a / --allow options and --pci-blacklist with --block. The -b short option remains unchanged. Allow the old options for now, but print a nag warning since old options are deprecated. Signed-off-by: Stephen Hemminger Acked-by: Luca Boccassi --- lib/librte_eal/c

[dpdk-dev] [PATCH v10 0/7] replace blacklist/whitelist with allow/block

2020-11-10 Thread Stephen Hemminger
This patch series changes the use of the terms blacklist and whitelist and instead uses block and allow. The change is most visible in the options passed to DPDK programs for marking which devices to use. The options are also shortened because they can be used for not just PCI devices. When DPDK

[dpdk-dev] [PATCH v10 1/7] eal: replace usage of blacklist/whitelist in enum

2020-11-10 Thread Stephen Hemminger
This patch renames the enum values in the EAL include files. As a backward compatible temporary migration tool, define a replacement mapping for old values. The old names relating to blacklist and whitelist are replaced by block list and allow list, but applications may be using the older compatib

[dpdk-dev] [PATCH v10 2/7] drivers: replace references to blacklist

2020-11-10 Thread Stephen Hemminger
Use the new terminology blocked to describe when devices are excluded from being used. Signed-off-by: Stephen Hemminger Acked-by: Luca Boccassi Acked-by: Hemant Agrawal --- drivers/bus/dpaa/dpaa_bus.c| 7 +++ drivers/bus/fslmc/fslmc_bus.c | 9 - drivers/bus/fslmc/fsl

[dpdk-dev] [PATCH V2] doc: add the SWX pipeline type to the prog_guide

2020-11-10 Thread Cristian Dumitrescu
Add the new SWX pipeline type to the Programmer's Guide. V2 changes: fixed 2 typos. Signed-off-by: Cristian Dumitrescu --- doc/guides/prog_guide/packet_framework.rst | 77 ++ 1 file changed, 77 insertions(+) diff --git a/doc/guides/prog_guide/packet_framework.rst b/doc/gui

[dpdk-dev] [PATCH] doc: add the SWX pipeline type to the prog_guide

2020-11-10 Thread Cristian Dumitrescu
Add the new SWX pipeline type to the Programmer's Guide. Signed-off-by: Cristian Dumitrescu --- doc/guides/prog_guide/packet_framework.rst | 77 ++ 1 file changed, 77 insertions(+) diff --git a/doc/guides/prog_guide/packet_framework.rst b/doc/guides/prog_guide/packet_framew

Re: [dpdk-dev] [PATCH] maintainers: Update for OcteonTx2 DMA and EP

2020-11-10 Thread Radha Mohan
On Mon, Nov 9, 2020 at 4:20 PM Radha Mohan Chintakuntla wrote: > > Replace the maintainers for OcteonTx2 DMA and EP drivers. > > Signed-off-by: Radha Mohan Chintakuntla > --- > MAINTAINERS | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/MAINTAINERS b/MAINTAINERS >

Re: [dpdk-dev] [PATCH 1/1] devtools: fix build test config inheritance from env

2020-11-10 Thread Ferruh Yigit
On 11/10/2020 5:55 PM, Thomas Monjalon wrote: 10/11/2020 18:18, Ferruh Yigit: On 11/9/2020 9:00 PM, Thomas Monjalon wrote: PKG_CONFIG_PATH is specific to each target, so it must be empty before configuring each build from the file according to DPDK_TARGET. Inheriting a default PKG_CONFIG_PATH f

[dpdk-dev] [PATCH 1/4] doc: move VFIO driver to be first

2020-11-10 Thread Anatoly Burakov
Currently, the Linux GSG mentions UIO drivers first. This is not ideal as for the longest time, the recommended way to use DPDK with hardware devices has been to use VFIO driver. This commit simply moves UIO section after VFIO, with minor edits. Signed-off-by: Anatoly Burakov --- doc/guides/lin

[dpdk-dev] [PATCH 4/4] doc: add VFIO troubleshooting section

2020-11-10 Thread Anatoly Burakov
There are common problems with VFIO that get asked over and over on the mailing list. Document common problems with VFIO and how to fix them or at least figure out what went wrong. Signed-off-by: Anatoly Burakov --- doc/guides/linux_gsg/linux_drivers.rst | 43 ++ 1 file c

[dpdk-dev] [PATCH 3/4] doc: add VFIO no-IOMMU Linux GSG section

2020-11-10 Thread Anatoly Burakov
Currently, we have no documentation on how to use VFIO in no-IOMMU mode. Add such documentation. Signed-off-by: Anatoly Burakov --- doc/guides/linux_gsg/linux_drivers.rst | 23 ++- 1 file changed, 22 insertions(+), 1 deletion(-) diff --git a/doc/guides/linux_gsg/linux_driver

[dpdk-dev] [PATCH 2/4] doc: reword VFIO and UIO Linux GSG section

2020-11-10 Thread Anatoly Burakov
Make sure that we always prioritize VFIO over UIO. Also, minor wording corrections and improvements. Signed-off-by: Anatoly Burakov --- doc/guides/linux_gsg/linux_drivers.rst | 88 ++ 1 file changed, 49 insertions(+), 39 deletions(-) diff --git a/doc/guides/linux_gsg/lin

[dpdk-dev] [PATCH v1] net/i40e: argument in RSS action should have queue

2020-11-10 Thread Kumar Amber
The driver must check for the queue number in the RSS action list and if not should return with a proper error message to user. Signed-off-by: Kumar Amber --- drivers/net/i40e/i40e_flow.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/drivers/net/i40e/i40e_flow.c b/drivers/net/

Re: [dpdk-dev] [PATCH v2 2/2] mbuf: move pool pointer in first half

2020-11-10 Thread Stephen Hemminger
On Tue, 10 Nov 2020 17:25:09 +0100 Olivier Matz wrote: > On Mon, Nov 09, 2020 at 10:29:37PM +0100, Thomas Monjalon wrote: > > According to the Technical Board decision > > (http://mails.dpdk.org/archives/dev/2020-November/191859.html), > > the mempool pointer in the mbuf struct is moved > > from

Re: [dpdk-dev] [PATCH v2 2/2] mbuf: move pool pointer in first half

2020-11-10 Thread Jerin Jacob
On Tue, Nov 10, 2020 at 9:55 PM Olivier Matz wrote: > > On Mon, Nov 09, 2020 at 10:29:37PM +0100, Thomas Monjalon wrote: > > According to the Technical Board decision > > (http://mails.dpdk.org/archives/dev/2020-November/191859.html), > > the mempool pointer in the mbuf struct is moved > > from th

Re: [dpdk-dev] [PATCH v2] net/i40e: fix build for log format specifier

2020-11-10 Thread Luca Boccassi
On Tue, 2020-11-10 at 17:54 +, Ferruh Yigit wrote: > Build error: > i40e_common.c: In function "i40e_parse_discover_capabilities": > ../drivers/net/i40e/base/../i40e_logs.h:43:50: > error: format "%llX" expects argument of type "long long unsigned >int", but argument 7 has type

Re: [dpdk-dev] [PATCH v2 1/2] drivers: disable OCTEON TX2 in 32-bit build

2020-11-10 Thread Jerin Jacob
On Tue, Nov 10, 2020 at 3:00 AM Thomas Monjalon wrote: > > The drivers for OCTEON TX2 are not supported in 32-bit mode. > > Suggested-by: Jerin Jacob > Signed-off-by: Thomas Monjalon Acked-by: Jerin Jacob > --- > drivers/common/octeontx2/meson.build | 18 ++ > drivers/cryp

[dpdk-dev] [PATCH v2] net/i40e: fix build for log format specifier

2020-11-10 Thread Ferruh Yigit
Build error: i40e_common.c: In function "i40e_parse_discover_capabilities": ../drivers/net/i40e/base/../i40e_logs.h:43:50: error: format "%llX" expects argument of type "long long unsigned int", but argument 7 has type "u64" {aka "long unsigned int" [-Werror=format=] 43

Re: [dpdk-dev] [PATCH 1/1] devtools: fix build test config inheritance from env

2020-11-10 Thread Thomas Monjalon
10/11/2020 18:18, Ferruh Yigit: > On 11/9/2020 9:00 PM, Thomas Monjalon wrote: > > PKG_CONFIG_PATH is specific to each target, so it must be empty > > before configuring each build from the file according to DPDK_TARGET. > > Inheriting a default PKG_CONFIG_PATH for all targets does not make sense >

[dpdk-dev] [PATCH v7 1/1] vfio: modify spapr iommu support to use static window sizing

2020-11-10 Thread David Christensen
The SPAPR IOMMU requires that a DMA window size be defined before memory can be mapped for DMA. Current code dynamically modifies the DMA window size in response to every new memory allocation which is potentially dangerous because all existing mappings need to be unmapped/remapped in order to resi

Re: [dpdk-dev] [PATCH] net/tap: Allow all-zero checksum for UDP over IPv4

2020-11-10 Thread Ferruh Yigit
On 11/10/2020 4:01 PM, Morten Brørup wrote: From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ferruh Yigit Sent: Tuesday, November 10, 2020 3:47 PM On 11/9/2020 2:22 PM, Michael Pfeiffer wrote: Unlike TCP, UDP checksums are optional and may be zero to indicate "not set" [RFC 768] (except for

[dpdk-dev] [PATCH v7 0/1] vfio: modify spapr iommu support to use static window sizing

2020-11-10 Thread David Christensen
The SPAPR v2 IOMMU used on bare-metal PowerNV systems requires that a DMA window be defined before mapping/unmapping memory. The current VFIO code dynamically resizes this DMA window every time a new memory request is made, which requires that all existing memory be unmapped/remapped. While this s

Re: [dpdk-dev] [dpdk-stable] [PATCH] install: fix flattening of examples directory

2020-11-10 Thread Bruce Richardson
On Tue, Nov 10, 2020 at 06:33:03PM +0100, David Marchand wrote: > On Tue, Nov 10, 2020 at 6:08 PM Bruce Richardson > wrote: > > > > By installing the examples one-by-one in a loop in the examples > > meson.build file we effectively flatted out the structure of the examples > > flattened* > > > f

Re: [dpdk-dev] [dpdk-stable] [PATCH] install: fix flattening of examples directory

2020-11-10 Thread David Marchand
On Tue, Nov 10, 2020 at 6:08 PM Bruce Richardson wrote: > > By installing the examples one-by-one in a loop in the examples > meson.build file we effectively flatted out the structure of the examples flattened* > folder and omitted some common and shared subfolders that were never > directly bui

  1   2   3   >