[dpdk-dev] [PATCH v1] vhost: remove fallback in async enqueue API

2020-10-20 Thread Patrick Fu
By design, async enqueue API should return directly if async device is not registered. This patch removes the corrupted implementation of the enqueue fallback from async mode to sync mode. Fixes: cd6760da1076 ("vhost: introduce async enqueue for split ring") Signed-off-by: Patrick Fu --- lib/li

Re: [dpdk-dev] [PATCH 12/14] ethdev: remove legacy FDIR filter type support

2020-10-20 Thread Guo, Jia
> -Original Message- > From: Andrew Rybchenko > Sent: Sunday, October 18, 2020 10:09 PM > To: Lu, Wenzhuo ; Xing, Beilei > ; Iremonger, Bernard > ; Ray Kinsella ; Neil > Horman ; Ajit Khaparde > ; Somnath Kotur > ; John Daley ; > Hyong Youb Kim ; Guo, Jia ; Wang, > Haiyue ; Matan Azrad ;

Re: [dpdk-dev] [PATCH 11/14] ethdev: remove legacy global filter configuration support

2020-10-20 Thread Guo, Jia
> -Original Message- > From: Andrew Rybchenko > Sent: Sunday, October 18, 2020 10:09 PM > To: Lu, Wenzhuo ; Xing, Beilei > ; Iremonger, Bernard > ; Guo, Jia ; Andrew > Rybchenko > Cc: dev@dpdk.org > Subject: [PATCH 11/14] ethdev: remove legacy global filter configuration > support > P

Re: [dpdk-dev] [PATCH 03/14] ethdev: remove legacy EtherType filter type support

2020-10-20 Thread Guo, Jia
> -Original Message- > From: Andrew Rybchenko > Sent: Sunday, October 18, 2020 10:09 PM > To: Lu, Wenzhuo ; Xing, Beilei > ; Iremonger, Bernard > ; Ray Kinsella ; Neil > Horman ; Ajit Khaparde > ; Somnath Kotur > ; Guo, Jia ; Wang, > Haiyue ; Ziyang Xuan > ; Xiaoyun Wang > ; Guoyang Zhou

Re: [dpdk-dev] [PATCH v5 4/4] test/hash: add tests for integrated RCU QSBR

2020-10-20 Thread Dharmik Thakkar
> On Oct 20, 2020, at 10:54 PM, Wang, Yipeng1 wrote: > >> -Original Message- >> From: Dharmik Thakkar >> Sent: Tuesday, October 20, 2020 9:13 AM >> To: Wang, Yipeng1 ; Gobriel, Sameh >> ; Richardson, Bruce >> Cc: dev@dpdk.org; n...@arm.com; Dharmik Thakkar >> >> Subject: [PATCH v5 4

Re: [dpdk-dev] [PATCH v5 2/4] lib/hash: integrate RCU QSBR

2020-10-20 Thread Dharmik Thakkar
> On Oct 20, 2020, at 9:42 PM, Wang, Yipeng1 wrote: > >> -Original Message- >> From: Dharmik Thakkar >> Sent: Tuesday, October 20, 2020 9:13 AM >> To: Wang, Yipeng1 ; Gobriel, Sameh >> ; Richardson, Bruce >> ; Ray Kinsella ; Neil Horman >> >> Cc: dev@dpdk.org; n...@arm.com; Dharmik T

Re: [dpdk-dev] [PATCH 02/14] ethdev: move MAC filter type to i40e driver

2020-10-20 Thread Guo, Jia
> -Original Message- > From: Andrew Rybchenko > Sent: Sunday, October 18, 2020 10:09 PM > To: Xing, Beilei ; Guo, Jia ; > Thomas Monjalon ; Yigit, Ferruh > ; Andrew Rybchenko > > Cc: dev@dpdk.org > Subject: [PATCH 02/14] ethdev: move MAC filter type to i40e driver > > net/i40e driver i

Re: [dpdk-dev] [PATCH v5 4/4] test/hash: add tests for integrated RCU QSBR

2020-10-20 Thread Wang, Yipeng1
> -Original Message- > From: Dharmik Thakkar > Sent: Tuesday, October 20, 2020 9:13 AM > To: Wang, Yipeng1 ; Gobriel, Sameh > ; Richardson, Bruce > Cc: dev@dpdk.org; n...@arm.com; Dharmik Thakkar > > Subject: [PATCH v5 4/4] test/hash: add tests for integrated RCU QSBR > > Add functional

Re: [dpdk-dev] [PATCH 01/14] ethdev: remove legacy MACVLAN filter type support

2020-10-20 Thread Guo, Jia
> -Original Message- > From: Andrew Rybchenko > Sent: Sunday, October 18, 2020 10:09 PM > To: Lu, Wenzhuo ; Xing, Beilei > ; Iremonger, Bernard > ; Ray Kinsella ; Neil > Horman ; Guo, Jia ; Rasesh > Mody ; Shahed Shaikh ; > Andrew Rybchenko ; Thomas Monjalon > ; Yigit, Ferruh > Cc: dev@

[dpdk-dev] [PATCH] net/octeontx2: support for VF base steering rule

2020-10-20 Thread psatheesh
From: Satheesh Paul Adds support for merging a base steering rule with all flow rules created on a VF. Signed-off-by: Satheesh Paul --- drivers/net/octeontx2/otx2_flow.c | 2 ++ drivers/net/octeontx2/otx2_flow.h | 1 + drivers/net/octeontx2/otx2_flow_utils.c | 19

[dpdk-dev] [PATCH v2 2/2] lpm: hide internal data

2020-10-20 Thread Ruifeng Wang
Fields except tbl24 and tbl8 in rte_lpm structure have no need to be exposed to the user. Hide the unneeded exposure of structure fields for better ABI maintainability. Suggested-by: David Marchand Signed-off-by: Ruifeng Wang Reviewed-by: Honnappa Nagarahalli Acked-by: Kevin Traynor Acked-by:

[dpdk-dev] [PATCH v2 0/2] LPM changes

2020-10-20 Thread Ruifeng Wang
The rte_lpm structure is exported because lookup API is inlined. But most of the structure can be hidden. Discussion at: http://patches.dpdk.org/patch/72403/ This patch set aimed to hide the rte_lpm structure as much as possible. A data free issue was identified and fixed. Ruifeng Wang (2): lpm

[dpdk-dev] [PATCH v2 1/2] lpm: fix free of data structure

2020-10-20 Thread Ruifeng Wang
The container structure should be freed instead of rte_lpm structure after wrapping rte_lpm into internal structure __rte_lpm. Fixes: 8a9f8564e9f9 ("lpm: implement RCU rule reclamation") Cc: sta...@dpdk.org Signed-off-by: Ruifeng Wang Reviewed-by: Phil Yang Acked-by: Bruce Richardson Acked-by:

Re: [dpdk-dev] [PATCH v5 3/4] test/hash: replace rte atomic with C11 atomic APIs

2020-10-20 Thread Wang, Yipeng1
> -Original Message- > From: Dharmik Thakkar > Sent: Tuesday, October 20, 2020 9:13 AM > To: Wang, Yipeng1 ; Gobriel, Sameh > ; Richardson, Bruce > Cc: dev@dpdk.org; n...@arm.com; Dharmik Thakkar > > Subject: [PATCH v5 3/4] test/hash: replace rte atomic with C11 atomic APIs > > Replace

Re: [dpdk-dev] [PATCH v5 2/4] lib/hash: integrate RCU QSBR

2020-10-20 Thread Wang, Yipeng1
> -Original Message- > From: Dharmik Thakkar > Sent: Tuesday, October 20, 2020 9:13 AM > To: Wang, Yipeng1 ; Gobriel, Sameh > ; Richardson, Bruce > ; Ray Kinsella ; Neil Horman > > Cc: dev@dpdk.org; n...@arm.com; Dharmik Thakkar > > Subject: [PATCH v5 2/4] lib/hash: integrate RCU QSBR >

[dpdk-dev] [PATCH v3] examples/tep_term: deprecate this example

2020-10-20 Thread Xiaoyun Li
This example sets up a scenario that VXLAN packets can be received by different PF queues based on VNID and each queue is bound to a VM with a VNID so that the VM can receive its inner packets. Usually, OVS is used to do the software encap/decap for VXLAN packets. And the VXLAN packets offloading

[dpdk-dev] [PATCH v2 11/11] net/bnxt: add VXLAN decap offload support

2020-10-20 Thread Ajit Khaparde
From: Venkat Duvvuru VXLAN decap offload can happen in stages. The offload request may not come as a single flow request rather may come as two flow offload requests F1 & F2. This patch is adding support for this two stage offload design. The match criteria for F1 is O_DMAC, O_SMAC, O_DST_IP, O_U

[dpdk-dev] [PATCH v2 06/11] net/bnxt: add support for flow counter accumulation

2020-10-20 Thread Ajit Khaparde
From: Kishore Padmanabha Add support for flow counter accumulation. In case of hierarchical flows, involving parent and child flows, the child flow counters are aggregated to get the parent flow counter information. Signed-off-by: Kishore Padmanabha Reviewed-by: Shahaji Bhosle Reviewed-by: Aji

[dpdk-dev] [PATCH v2 09/11] net/bnxt: refactor flow id allocation

2020-10-20 Thread Ajit Khaparde
From: Venkat Duvvuru Currently, the flow id is allocated inside ulp_mapper_flow_create. However with vxlan decap feature if F2 flow comes before F1 flow then F2 is cached and not really installed in the hardware which means the code will return without calling ulp_mapper_flow_create. But, ULP has

[dpdk-dev] [PATCH v2 08/11] net/bnxt: add mapper support for wildcard TCAM

2020-10-20 Thread Ajit Khaparde
From: Kishore Padmanabha Added support for the key and mask fields encoding for the wildcard tcam entry. Signed-off-by: Kishore Padmanabha Reviewed-by: Mike Baucom Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/tf_ulp/ulp_mapper.c | 47 -- drivers/net/bnxt/tf_ulp/ulp_utils.c | 125

[dpdk-dev] [PATCH v2 05/11] net/bnxt: fix infinite loop in flow query count

2020-10-20 Thread Ajit Khaparde
From: Somnath Kotur `nxt_resource_idx` could be zero in some cases which is invalid and should be part of the while loop condition. Also synchronize access to the flow db using the fdb_lock Fixes: 306c2d28e247 ("net/bnxt: support count action in flow query") Signed-off-by: Somnath Kotur Review

[dpdk-dev] [PATCH v2 07/11] net/bnxt: change HWRM command to create reps

2020-10-20 Thread Ajit Khaparde
From: Somnath Kotur Use cfa pair alloc for configuring reps. Instead of cfa_vfr_alloc for Wh+ and cfa_pair_alloc for Stingray, converge to cfa_pair_alloc/free for both devices. Set the command request structure bits accordingly. As part of this, remove the old cfa_vfr_alloc cmd definitions as FW

[dpdk-dev] [PATCH v2 04/11] net/bnxt: update ULP resource counts

2020-10-20 Thread Ajit Khaparde
From: Peter Spreadborough - Update the SR ULP requested resource counts to reflect those available after AFM resources are accounted for. - Add build option to select either 2 or 4 slot EM entries. The default is 4 slot entries. Signed-off-by: Peter Spreadborough Signed-off-by: Farah Smith Rev

[dpdk-dev] [PATCH v2 02/11] net/bnxt: changes to support two table scopes

2020-10-20 Thread Ajit Khaparde
From: Jay Ding New API to map a PARIF to an EEM table scope (set of Rx and Tx EEM base addresses). It uses HWRM_TF_GLOBAL_CFG_SET HWRM to configure. PARIF is handler to a partition of the physical port. Adjustments to tf_global_cfg_set() to reduce overhead and nominal name clarification. Signed-

[dpdk-dev] [PATCH v2 03/11] net/bnxt: add table scope to PF Mapping

2020-10-20 Thread Ajit Khaparde
From: Farah Smith Add table scope to PF Mapping for SR and Wh+ devices. Legacy devices require PF set of base addresses for EEM operation. A table scope id is a logical construct and is mapped to the PF associated with the communications channel used. In the case of a VF, the parent PF is used.

[dpdk-dev] [PATCH v2 01/11] net/bnxt: add stingray support to core layer

2020-10-20 Thread Ajit Khaparde
From: Peter Spreadborough - Moved P4 specific code under the P4 directory - Added P45 skeleton code for SR to build on - Add SR support in truflow core layer Signed-off-by: Peter Spreadborough Signed-off-by: Jay Ding Reviewed-by: Farah Smith Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/h

[dpdk-dev] [PATCH v2 00/11] bnxt fixes and enhancements to TRUFLOW support

2020-10-20 Thread Ajit Khaparde
This patchset has support for VXLAN decap full offload, SR device support in tf_core and a few bug fixes. v1->v2:  - Squashed some patches.  - Updated commit logs. - Fixed a compilation issue reported during clang builds. Farah Smith (1): net/bnxt: add table scope to PF Mapping Jay Ding (1):

Re: [dpdk-dev] [PATCH v2] examples/tep_term: deprecate this example

2020-10-20 Thread Li, Xiaoyun
OK. > -Original Message- > From: Thomas Monjalon > Sent: Tuesday, October 20, 2020 19:43 > To: Li, Xiaoyun > Cc: Yigit, Ferruh ; dev@dpdk.org; > arybche...@solarflare.com; david.march...@redhat.com > Subject: Re: [dpdk-dev] [PATCH v2] examples/tep_term: deprecate this example > > 20/10/

Re: [dpdk-dev] [PATCH] net/vdev_netvsc: Prevent alarm lost on failed device probe

2020-10-20 Thread Long Li
> Subject: RE: [PATCH] net/vdev_netvsc: Prevent alarm lost on failed device > probe > > > > From: Long Li > > > Subject: RE: [PATCH] net/vdev_netvsc: Prevent alarm lost on failed > > > device probe > > > > > > > > > > > > From: Long Li > > > > If a device probe fails, the alarm is canceled and w

Re: [dpdk-dev] [PATCH v2 0/8] net/mlx5: make counter thread safe

2020-10-20 Thread Raslan Darawsheh
Hi, > -Original Message- > From: dev On Behalf Of Suanming Mou > Sent: Tuesday, October 20, 2020 6:02 AM > Cc: dev@dpdk.org > Subject: [dpdk-dev] [PATCH v2 0/8] net/mlx5: make counter thread safe > > The mlx5 PMD is going to support multiple-thread flow operations. > This patchset makes t

Re: [dpdk-dev] [PATCH 2/2] examples/performance-thread: fix undef behavior

2020-10-20 Thread Lukasz Wojciechowski
Looks good! W dniu 16.10.2020 o 08:03, Honnappa Nagarahalli pisze: > When the value of RTE_MAX_LCORE is small, it results in the > following compilation error. > > ../examples/performance-thread/l3fwd-thread/main.c:2338:34: error: > iteration 4 invokes undefined behavior > [-Werror=aggressive-loop

[dpdk-dev] [PATCH 21/21] net/ice/base: update version

2020-10-20 Thread Qi Zhang
Update base code version in readme. Signed-off-by: Qi Zhang --- drivers/net/ice/base/README | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ice/base/README b/drivers/net/ice/base/README index 1e9c854ae8..5229e5fe7d 100644 --- a/drivers/net/ice/base/README +++ b/dr

[dpdk-dev] [PATCH 19/21] net/ice/base: refactor RSS configure API

2020-10-20 Thread Qi Zhang
Use struct ice_rss_hash_cfg as parameter for ice_add_rss_cfg, ice_add_rss_cfg_sync and ice_rem_rss_cfg, ice_rem_rss_cfg_sync. Introduce enmu ice_rss_cfg_hdr_type to allow user specify the more flexible RSS configure. ICE_RSS_OUTER_HEADERS - take outer layer as RSS inputset ICE_RSS_INNER_HEADERS -

[dpdk-dev] [PATCH 17/21] net/ice/base: remove duplicated AQ command flag setting

2020-10-20 Thread Qi Zhang
When sending the indirect Read/Write SFF EEPROM AQ command. The flag is already added later in the code flow for all indirect AQ commands, i.e. commands that provide an additional data buffer. Signed-off-by: Bruce Allan Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_common.c | 2 +- 1 fil

[dpdk-dev] [PATCH 20/21] net/ice/base: add support for get/set RSS LUT to specify global LUT

2020-10-20 Thread Qi Zhang
There is no way to specify a global RSS LUT ID with the current API and 0 is the only global LUT ID that can be supported since it's hard coded. Upcoming support to specify a global LUT ID will require this flexibility. To fix this, update the API for ice_aq_get_rss_lut() and ice_aq_set_rss_lut() t

[dpdk-dev] [PATCH 18/21] net/ice/base: introduce and use FLEX_ARRAY_SIZE where possible

2020-10-20 Thread Qi Zhang
Use the FLEX_ARRAY_SIZE() helper with the recently added flexible array members in structures. Signed-off-by: Bruce Allan Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_common.c| 2 +- drivers/net/ice/base/ice_flex_pipe.c | 2 +- drivers/net/ice/base/ice_type.h | 4 3 files

[dpdk-dev] [PATCH 16/21] net/ice/base: support extended GPIO access

2020-10-20 Thread Qi Zhang
Added two new admin commands called: SW Set GPIO and SW Get GPIO (0x6EF and 0x6F0 respectively) which extends GPIO handling capabilities by SW driver Signed-off-by: Amir Shay Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_adminq_cmd.h | 18 ++ 1 file changed, 18 insertions

[dpdk-dev] [PATCH 14/21] net/ice/base: recognize 860 as iSCSI port in CEE mode

2020-10-20 Thread Qi Zhang
iSCSI can use both TCP ports 860 and 3260. However, in our current implementation, the ice_aqc_opc_get_cee_dcb_cfg (0x0A07) AQ command doesn't provide a way to communicate the protocol port number to the AQ's caller. Thus, we assume that 3260 is the iSCSI port number at the AQ's caller layer. In t

[dpdk-dev] [PATCH 15/21] net/ice/base: fix parameter name in comment

2020-10-20 Thread Qi Zhang
Fix parameter name for cookie_high and cookie_low. Fixes: a90fae1d0755 ("net/ice/base: add admin queue structures and commands") Cc: sta...@dpdk.org Signed-off-by: Jesse Brandeburg Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_adminq_cmd.h | 4 ++-- 1 file changed, 2 insertions(+), 2 de

[dpdk-dev] [PATCH 13/21] net/ice/base: implement shared rate limiter

2020-10-20 Thread Qi Zhang
Implemented shared bandwidth rate limit functionality to account for dedicated bandwidth and minimum bandwidth. It requires non default profile be programmed for CIR, EIR/PIR, and SRL. Signed-off-by: Tarun Singh Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_sched.c | 484

[dpdk-dev] [PATCH 12/21] net/ice/base: return error directly

2020-10-20 Thread Qi Zhang
As there is nothing to unroll, return the error directly. Remove the label as this is the only reference to that label. Signed-off-by: Tony Nguyen Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_sched.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/ne

[dpdk-dev] [PATCH 11/21] net/ice/base: add support for class 5+ modules

2020-10-20 Thread Qi Zhang
Currently QSFP/SFP modules up to power class 4 are supported. 100G modules require higher power in many cases. Also, low power mode requires support of power classes 7 and even 8. This change extends "Get Link Status" AQ command (0x0607) to support class 5+ modules. The patch also add couple othe

[dpdk-dev] [PATCH 09/21] net/ice/base: update to use package info from ice segment

2020-10-20 Thread Qi Zhang
There are two package versions in the package binary. Today, these two version numbers are the same. However, in the future that may change. Update code to use the package info from the ice segment metadata section, which is the package information that is actually downloaded to the firmware durin

[dpdk-dev] [PATCH 07/21] net/ice/base: add functions to allocate and free a RSS global LUT

2020-10-20 Thread Qi Zhang
Currently there is no API to allocate and free a RSS global LUT. Incoming changes to support VFs having >16 queues will require using RSS global LUT resources. The functions included will allow a PF to configure a RSS global LUT for VFs that request >16 queues. Signed-off-by: Brett Creeley Signed

[dpdk-dev] [PATCH 10/21] net/ice/base: use malloc instead of calloc

2020-10-20 Thread Qi Zhang
Use *malloc() instead of *calloc() when allocating only a single object as opposed to an array of objects. Signed-off-by: Bruce Allan Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_switch.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/ice/base/ice_swit

[dpdk-dev] [PATCH 08/21] net/ice/base: add more capability to admin queue

2020-10-20 Thread Qi Zhang
Add below 3 new capability to "Get Capabilities" AQ commands 0x000A and 0x000B. ICE_AQC_CAPS_IWARP ICE_AQC_CAPS_PCIE_RESET_AVOIDANCE ICE_AQC_CAPS_NVM_MGMT Signed-off-by: Amir Shay Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_adminq_cmd.h | 3 +++ 1 file changed, 3 insertions(+) diff -

[dpdk-dev] [PATCH 04/21] net/ice/base: rename ptype bitmap

2020-10-20 Thread Qi Zhang
Align all ptype bitmap to follow ice_ptypes_xxx prefix. Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_flow.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/net/ice/base/ice_flow.c b/drivers/net/ice/base/ice_flow.c index 45990aeca0..4512b12368

[dpdk-dev] [PATCH 06/21] net/ice/base: read security revision

2020-10-20 Thread Qi Zhang
The main NVM module and the Option ROM module contain a security revision in their CSS header. This security revision is used to determine whether or not the signed module should be loaded at bootup. If the module security revision is lower than the associated minimum security revision, it will not

[dpdk-dev] [PATCH 05/21] net/ice/base: move sched function prototypes

2020-10-20 Thread Qi Zhang
These functions reside in ice_sched.c but the function protypes are declared in ice_common.h. Move the function prototypes to ice_sched.h. Signed-off-by: Tony Nguyen Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_common.h | 7 --- drivers/net/ice/base/ice_sched.h | 8 2 file

[dpdk-dev] [PATCH 02/21] net/ice/base: add NVM Write Response flags

2020-10-20 Thread Qi Zhang
Added NVM Write Admin Command (0x703) ARQ response flags - as returned in "Response flags" field. Three flags are supported: POR, PERST and EMPR. All indicate the type of reset required to get the NVM bank update effective. Signed-off-by: Amir Shay Signed-off-by: Qi Zhang --- drivers/net/ice/ba

[dpdk-dev] [PATCH 03/21] net/ice/base: modify ptype bitmap for outer MAC

2020-10-20 Thread Qi Zhang
Add below ptypes into ice_ptypes_mac_ofos: MAC_IPV4[6]_ESP MAC_IPV4[6]_AH MAC_IPV4[6]_NAT_T_ESP MAC_IPV4[6]_NAT_T_IKE MAC_IPV4[6]_NAT_T_KEEP MAC_IPV4[6]_PFCP_NODE MAC_IPV4[6]_PFCP_SESSION MAC_IPV4[6]_L2TPV3 So above ptype can also be selected by a filter when outer mac header is required. Signed

[dpdk-dev] [PATCH 01/21] net/ice/base: add tunnel support for FDIR

2020-10-20 Thread Qi Zhang
Add struct to store outer part for tunnel rule. Add vxlan ptype in ipv4 mac bitmap. So when create a vxlan rule, the ptype group will be valid. Signed-off-by: Zhirun Yan Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_fdir.c | 8 drivers/net/ice/base/ice_fdir.h | 9 + driv

[dpdk-dev] [PATCH 00/21] ice: update base code

2020-10-20 Thread Qi Zhang
main change: 1. Refactor the RSS configure API. 2. Add global LUT support . 3. copule fix and code clean Qi Zhang (21): net/ice/base: add tunnel support for FDIR net/ice/base: add NVM Write Response flags net/ice/base: modify ptype bitmap for outer MAC net/ice/base: rename ptype bitmap n

Re: [dpdk-dev] [PATCH v7 0/3] pmdinfogen: rewrite in Python

2020-10-20 Thread Dmitry Kozlyuk
Hi IOL team, The following error persists in v8: > - In a thread on c...@dpdk.org > http://inbox.dpdk.org/ci/CAOeXdvbosqRGouSX06_phVTCam57XUt0s=sf_kpe-vmiwft...@mail.gmail.com/T/#m9bb193c74ca979c151f2dbfa35664f95093a9e71, > UNH people confirmed that python3-elftools should be available, but > the

Re: [dpdk-dev] [PATCH] librte_eal: fix mcslock hang on weak memory

2020-10-20 Thread Honnappa Nagarahalli
> > Honnappa? > > 07/10/2020 11:55, Diogo Behrens: > > Hi Thomas, > > > > we are still waiting for the comments from Honnappa. In our > > understanding, the missing barrier is a bug according to the model. We > > reproduced the scenario in herd7, which represents the authoritative > > memory mo

Re: [dpdk-dev] [PATCH 1/2] test/rcu: fix array subscript is above array bounds

2020-10-20 Thread Lukasz Wojciechowski
Hi Honnappa, If setting value lower than 2 makes no sense as there is no place for worker thread, then the patch is perfectly fine >>> When RTE_MAX_LCORE value is small, following compiler errors are >>> observed. >>> >>> ../app/test/test_rcu_qsbr.c:296:54: error: iteration 2 invokes >>> unde

[dpdk-dev] [PATCH v2] mbuf: allow dynamic flags to be used by secondary process

2020-10-20 Thread Stephen Hemminger
The dynamic flag management is broken if rte_mbuf_dynflag_lookup() is done in a secondary process because the local pointer to the memzone is not ever initialized. Fix it by using the same checks as dynfield_register(). I.e if shared memory zone has not been looked up already, then discover it. F

Re: [dpdk-dev] [PATCH] efd: fix tailq entry leak in error path

2020-10-20 Thread Wang, Yipeng1
> -Original Message- > From: Thomas Monjalon > Sent: Tuesday, October 20, 2020 7:11 AM > To: Marohn, Byron ; Wang, Yipeng1 > > Cc: dev@dpdk.org; jerry.lili...@huawei.com; xudin...@huawei.com; Yunjian > Wang ; sta...@dpdk.org; wangyunjian > > Subject: Re: [dpdk-dev] [PATCH] efd: fix tailq

[dpdk-dev] DPDK-VIRTIO- GCP- RSS

2020-10-20 Thread kumaraparameshwaran rathinavel
Hi All, I tried using multiqueue in DPDK GCP. But I am facing issues where descriptor index between guest and hypervisor going out of sync. Basically when device notifies rx but the mbuf cookie at that index is NULL. Please let me know if there are known limitations in using GCP RSS. I have two q

Re: [dpdk-dev] [PATCH v5 22/22] doc: Add new DLB eventdev driver to relnotes

2020-10-20 Thread Eads, Gage
> -Original Message- > From: McDaniel, Timothy > Sent: Saturday, October 17, 2020 2:04 PM > To: Thomas Monjalon ; Mcnamara, John > ; Kovacevic, Marko > Cc: dev@dpdk.org; Carrillo, Erik G ; Eads, Gage > ; Van Haaren, Harry ; > jer...@marvell.com > Subject: [PATCH v5 22/22] doc: Add new

Re: [dpdk-dev] [PATCH v5 11/22] event/dlb: add port setup

2020-10-20 Thread Eads, Gage
[...] > +static int > +dlb_pf_ldb_port_create(struct dlb_hw_dev *handle, > +struct dlb_create_ldb_port_args *cfg, > +enum dlb_cq_poll_modes poll_mode) > +{ > + struct dlb_dev *dlb_dev = (struct dlb_dev *)handle->pf_dev; > + struct dlb_cmd_response re

Re: [dpdk-dev] [PATCH v5 20/22] event/dlb: add queue and port release

2020-10-20 Thread Eads, Gage
> -Original Message- > From: McDaniel, Timothy > Sent: Saturday, October 17, 2020 2:04 PM > Cc: dev@dpdk.org; Carrillo, Erik G ; Eads, Gage > ; Van Haaren, Harry ; > jer...@marvell.com > Subject: [PATCH v5 20/22] event/dlb: add queue and port release > > These entry points are NO-OPS.

Re: [dpdk-dev] [PATCH v5 16/22] event/dlb: add dequeue and its burst variants

2020-10-20 Thread Eads, Gage
> -Original Message- > From: McDaniel, Timothy > Sent: Saturday, October 17, 2020 2:04 PM > Cc: dev@dpdk.org; Carrillo, Erik G ; Eads, Gage > ; Van Haaren, Harry ; > jer...@marvell.com > Subject: [PATCH v5 16/22] event/dlb: add dequeue and its burst variants > > Add support for dequeue

Re: [dpdk-dev] [PATCH v5 08/22] event/dlb: add infos get and configure

2020-10-20 Thread Eads, Gage
> -Original Message- > From: McDaniel, Timothy > Sent: Saturday, October 17, 2020 2:04 PM > Cc: dev@dpdk.org; Carrillo, Erik G ; Eads, Gage > ; Van Haaren, Harry ; > jer...@marvell.com > Subject: [PATCH v5 08/22] event/dlb: add infos get and configure > > Add support for configuring th

Re: [dpdk-dev] [PATCH v5 07/22] event/dlb: add xstats

2020-10-20 Thread Eads, Gage
> -Original Message- > From: McDaniel, Timothy > Sent: Saturday, October 17, 2020 2:04 PM > Cc: dev@dpdk.org; Carrillo, Erik G ; Eads, Gage > ; Van Haaren, Harry ; > jer...@marvell.com > Subject: [PATCH v5 07/22] event/dlb: add xstats > > Add support for DLB xstats. Perform initializa

Re: [dpdk-dev] [PATCH v5 06/22] event/dlb: add probe

2020-10-20 Thread Eads, Gage
> -Original Message- > From: McDaniel, Timothy > Sent: Saturday, October 17, 2020 2:04 PM > To: Burakov, Anatoly > Cc: dev@dpdk.org; Carrillo, Erik G ; Eads, Gage > ; Van Haaren, Harry ; > jer...@marvell.com > Subject: [PATCH v5 06/22] event/dlb: add probe > > The DLB hardware is a PC

Re: [dpdk-dev] [PATCH v5 03/22] event/dlb: add private data structures and constants

2020-10-20 Thread Eads, Gage
> -Original Message- > From: McDaniel, Timothy > Sent: Saturday, October 17, 2020 2:04 PM > Cc: dev@dpdk.org; Carrillo, Erik G ; Eads, Gage > ; Van Haaren, Harry ; > jer...@marvell.com > Subject: [PATCH v5 03/22] event/dlb: add private data structures and constants > > Add headers used

Re: [dpdk-dev] [PATCH v5 01/22] event/dlb: add documentation and meson infrastructure

2020-10-20 Thread Eads, Gage
[...] > diff --git a/doc/guides/eventdevs/index.rst b/doc/guides/eventdevs/index.rst > index bb66a5e..f651818 100644 > --- a/doc/guides/eventdevs/index.rst > +++ b/doc/guides/eventdevs/index.rst > @@ -18,3 +18,4 @@ application through the eventdev API. > octeontx > octeontx2 > opdl

Re: [dpdk-dev] [PATCH v7 02/10] eal: add power management intrinsics

2020-10-20 Thread Thomas Monjalon
20/10/2020 19:26, Ananyev, Konstantin: > > 20/10/2020 16:17, David Hunt: > > > On 20/10/2020 3:01 PM, David Hunt wrote: > > > > On 20/10/2020 8:35 AM, Thomas Monjalon wrote: > > > >> 20/10/2020 04:49, Ruifeng Wang: > > > >>> From: Thomas Monjalon > > > 15/10/2020 14:04, Anatoly Burakov: > > >

Re: [dpdk-dev] [RFC] eal: introduce function to get lcore thread id

2020-10-20 Thread Mattias Rönnblom
On 2020-10-20 15:38, David Marchand wrote: > On Mon, Aug 10, 2020 at 11:37 AM Mattias Rönnblom > wrote: >> Introduce function in to retrieve a lcore worker >> thread's pthread id. >> >> This change allows applications to do things like changing the name of >> a lcore thread, or detect if it's get

Re: [dpdk-dev] [PATCH v7] usertools: add a huge page setup script

2020-10-20 Thread Ferruh Yigit
On 9/14/2020 4:31 PM, Burakov, Anatoly wrote: On 09-Sep-20 7:51 PM, Stephen Hemminger wrote: This is an improved version of the setup of huge pages bases on earlier DPDK setup. Differences are:     * autodetects NUMA vs non NUMA     * allows setting different page sizes   recent kernels sup

[dpdk-dev] [PATCH v8 3/3] pmdinfogen: remove C implementation

2020-10-20 Thread Dmitry Kozlyuk
Delete the files no longer used in build process. Add myself as maintainer of new implementation. Signed-off-by: Dmitry Kozlyuk --- MAINTAINERS| 3 +- buildtools/pmdinfogen/meson.build | 14 - buildtools/pmdinfogen/pmdinfogen.c | 456 - bui

Re: [dpdk-dev] [PATCH v7 0/3] pmdinfogen: rewrite in Python

2020-10-20 Thread Dmitry Kozlyuk
Hello David, > - Travis reported an error in meson: > https://travis-ci.com/github/ovsrobot/dpdk/jobs/399762460#L478 > > Build machine cpu: x86_64 > buildtools/meson.build:27:10: ERROR: Expecting endforeach got eol_cont. > script = \ > ^ > For a block that started at 26,0 > foreach mod

[dpdk-dev] [PATCH v8 1/3] pmdinfogen: add Python implementation

2020-10-20 Thread Dmitry Kozlyuk
Using a high-level, interpreted language simplifies maintenance and build process. Furthermore, ELF handling is delegated to pyelftools package. Original logic is kept, the copyright recognizes that. Signed-off-by: Dmitry Kozlyuk --- buildtools/pmdinfogen.py | 189 +++

[dpdk-dev] [PATCH v8 2/3] build: use Python pmdinfogen

2020-10-20 Thread Dmitry Kozlyuk
Use the same interpreter to run pmdinfogen as for other build scripts. Adjust wrapper script accordingly and also don't suppress stderr from ar and pmdinfogen. Add configure-time check for elftools Python module for Unix hosts. Add python3-pyelftools to CI configuration. The package is available

[dpdk-dev] [PATCH v8 0/3] pmdinfogen: rewrite in Python

2020-10-20 Thread Dmitry Kozlyuk
This patchset implements existing pmdinfogen logic in Python, replaces and removes the old code. The goals of rewriting are: * easier maintenance by using a more high-level language, * simpler build process without host application and libelf, * foundation for adding Windows support. Travis CI sc

Re: [dpdk-dev] [PATCH v7 02/10] eal: add power management intrinsics

2020-10-20 Thread Ananyev, Konstantin
> 20/10/2020 16:17, David Hunt: > > On 20/10/2020 3:01 PM, David Hunt wrote: > > > On 20/10/2020 8:35 AM, Thomas Monjalon wrote: > > >> 20/10/2020 04:49, Ruifeng Wang: > > >>> From: Thomas Monjalon > > 15/10/2020 14:04, Anatoly Burakov: > > > +/** > > > + * This function is not su

Re: [dpdk-dev] [RFC] rcu: build on Windows

2020-10-20 Thread Ranjit Menon
On 10/20/2020 9:37 AM, Dharmik Thakkar wrote: On Oct 20, 2020, at 10:52 AM, Dmitry Kozlyuk wrote: On Tue, 20 Oct 2020 12:51:14 +, Dharmik Thakkar wrote: I tried cross-compilation on Linux (Ubuntu 18.04) with MinGW-w64 toolchain, but I am seeing some compilation error: ../lib/librte_e

Re: [dpdk-dev] [PATCH v2 2/2] net/ixgbe: remove rte_panic

2020-10-20 Thread Wang, Haiyue
> -Original Message- > From: Walsh, Conor > Sent: Tuesday, October 20, 2020 18:03 > To: Guo, Jia ; Wang, Haiyue ; > Yigit, Ferruh > ; Awal, Mohammad Abdul > ; Doherty, Declan > ; sta...@dpdk.org > Cc: dev@dpdk.org; Walsh, Conor > Subject: [PATCH v2 2/2] net/ixgbe: remove rte_panic > >

Re: [dpdk-dev] [PATCH v2 1/2] net/ixgbe: fix unchecked return value

2020-10-20 Thread Wang, Haiyue
> -Original Message- > From: Walsh, Conor > Sent: Tuesday, October 20, 2020 18:03 > To: Guo, Jia ; Wang, Haiyue ; > Yigit, Ferruh > ; Awal, Mohammad Abdul > ; Doherty, Declan > ; sta...@dpdk.org > Cc: dev@dpdk.org; Walsh, Conor > Subject: [PATCH v2 1/2] net/ixgbe: fix unchecked return v

Re: [dpdk-dev] [PATCH v2 1/3] virtio-user: fix backend selection if stat fails

2020-10-20 Thread Kevin Traynor
On 20/10/2020 16:20, Adrian Moreno wrote: > If stat fails because the file does not exist, it means that > the backend must be vhost-user in server mode. > > Also, log the detected backend type. > > Bugzilla ID: 559 > Fixes: f908b22ea47a ("net/virtio: move backend type selection to ethdev") > Cc:

[dpdk-dev] [dpdk-announce] release candidate 20.11-rc1

2020-10-20 Thread Thomas Monjalon
A new DPDK release candidate is ready for testing: https://git.dpdk.org/dpdk/tag/?id=v20.11-rc1 There are 1265 new patches in this snapshot, being the biggest -rc1 ever. Like the previous LTS, the API of this -rc1 is exceptionnally not frozen. More major changes are pending for -rc2. Rele

Re: [dpdk-dev] [PATCH v2 3/3] virtio-user: set status on virtio-user reconnect

2020-10-20 Thread Maxime Coquelin
On 10/20/20 5:20 PM, Adrian Moreno wrote: > Newer vhost-user backends will rely on SET_STATUS to start the device > so this required to support them. > > Fixes: 57912824615f ("net/virtio-user: support vhost status setting") > Cc: maxime.coque...@redhat.com > Cc: sta...@dpdk.org > > Signed-off-

Re: [dpdk-dev] [RFC] rcu: build on Windows

2020-10-20 Thread Dharmik Thakkar
> On Oct 20, 2020, at 10:52 AM, Dmitry Kozlyuk wrote: > > On Tue, 20 Oct 2020 12:51:14 +, Dharmik Thakkar wrote: >> I tried cross-compilation on Linux (Ubuntu 18.04) with MinGW-w64 toolchain, >> but I am seeing some compilation error: >> >> ../lib/librte_eal/common/eal_common_dev.c: In fu

Re: [dpdk-dev] [PATCH 1/2] test/rcu: fix array subscript is above array bounds

2020-10-20 Thread Honnappa Nagarahalli
Hi Lukasz, > > Hi Honnappa, > > I verified building and testing and all the warnings/errors disappear for > RTE_MAX_LCORE >= 2 and tests pass. Thank you for testing this. > > I wonder, if it is possible to set RTE_MAX_LCORE = 1 ? I thought, we would need 2 cores minimum, one for main and the

[dpdk-dev] [PATCH v2 5/5] doc: change references to blacklist and whitelist

2020-10-20 Thread Stephen Hemminger
There are two areas where documentation needed update. The first was use of whitelist when describing address filtering. The other is the legacy -w whitelist option for PCI which is used in many examples Signed-off-by: Stephen Hemminger Acked-by: Luca Boccassi doc: replace -w with -a in the do

[dpdk-dev] [PATCH v2 4/5] app/test: use new allowlist and blocklist

2020-10-20 Thread Stephen Hemminger
Test the renamed blocklist and allowlist arguments. Use new terms in test variable names as well. Signed-off-by: Stephen Hemminger Acked-by: Luca Boccassi --- app/test/autotest.py | 16 +++ app/test/autotest_runner.py| 18 app/test/test.c

[dpdk-dev] [PATCH v2 3/5] eal: replace pci-whitelist/pci-blacklist options

2020-10-20 Thread Stephen Hemminger
Replace -w / --pci-whitelist with -a / --allow options and --pci-blacklist with --block. The -b short option remains unchanged. Allow the old options for now, but print a nag warning since old options are deprecated. Signed-off-by: Stephen Hemminger Acked-by: Luca Boccassi --- lib/librte_eal/c

[dpdk-dev] [PATCH v2 2/5] drivers: replace references to blacklist

2020-10-20 Thread Stephen Hemminger
Use the new terminology blocked to describe when devices are excluded from being used. Signed-off-by: Stephen Hemminger Acked-by: Luca Boccassi Acked-by: Hemant Agrawal --- drivers/bus/dpaa/dpaa_bus.c| 7 +++ drivers/bus/fslmc/fslmc_bus.c | 9 - drivers/bus/fslmc/fsl

[dpdk-dev] [PATCH v2 0/5] replace blacklist/whitelist with block/allow

2020-10-20 Thread Stephen Hemminger
This is a revised version of the earlier RFC patch set for changing the blacklist/whitelist terms in DPDK. The first patch is a duplicate from the other patch set about use of master/slave in API. v2 - rebase on main branch - fix the handling of -b option. Keep -b as --block-list but depreca

[dpdk-dev] [PATCH v2 1/5] eal: replace usage of blacklist/whitelist in enum

2020-10-20 Thread Stephen Hemminger
This patch renames the enum values in the EAL include files. As a backward compatible temporary migration tool, define a replacement mapping for old values. The old names relating to blacklist and whitelist are replaced by block list and allow list, but applications may be using the older compatib

Re: [dpdk-dev] [PATCH V2] bonding: fix xmit balance policy name

2020-10-20 Thread Ferruh Yigit
On 10/20/2020 4:04 AM, Min Hu (Connor) wrote: Currently there exits inconsistence about name of transmission policy for a Link Bonding device. "xmit_balance_policy" is not correct, which should be modified to "balance_xmit_policy". Fixes: 2950a769315e ("bond: testpmd support") Fixes: ac718398f47

Re: [dpdk-dev] [PATCH v2 2/3] virtio_user: don't set/get_status until FEATURES_OK

2020-10-20 Thread Maxime Coquelin
On 10/20/20 5:20 PM, Adrian Moreno wrote: > According to the virtio spec, ACK and DRIVER status bits should be set > before feature negotiation. > > However, until the protocol features are negotiated, the driver does not > know if the device actually supports the those vhost-user messages. s/

[dpdk-dev] [PATCH v5 0/4] hash: integrate RCU QSBR

2020-10-20 Thread Dharmik Thakkar
Integrate RCU QSBR to make it easier for the applications to use lock free algorithm. Resource reclamation implementation was split from the original series, and has already been part of RCU library. Rework the series to base hash integration on RCU reclamation APIs. Refer 'Resource reclamation f

[dpdk-dev] [PATCH v5 4/4] test/hash: add tests for integrated RCU QSBR

2020-10-20 Thread Dharmik Thakkar
Add functional and performance tests for the integrated RCU QSBR. Suggested-by: Honnappa Nagarahalli Signed-off-by: Dharmik Thakkar Reviewed-by: Ruifeng Wang --- app/test/test_hash.c | 390 - app/test/test_hash_readwrite_lf_perf.c | 170 ++- 2

[dpdk-dev] [PATCH v5 3/4] test/hash: replace rte atomic with C11 atomic APIs

2020-10-20 Thread Dharmik Thakkar
Replace rte_atomic APIs with C11 atomic APIs in test_hash_readwrite_lf_perf.c Signed-off-by: Dharmik Thakkar Reviewed-by: Ruifeng Wang --- app/test/test_hash_readwrite_lf_perf.c | 89 +++--- 1 file changed, 36 insertions(+), 53 deletions(-) diff --git a/app/test/test_hash_r

[dpdk-dev] [PATCH v5 2/4] lib/hash: integrate RCU QSBR

2020-10-20 Thread Dharmik Thakkar
Currently, users have to use external RCU mechanisms to free resources when using lock free hash algorithm. Integrate RCU QSBR process to make it easier for the applications to use lock free algorithm. Refer to RCU documentation to understand various aspects of integrating RCU library into other l

[dpdk-dev] [PATCH v5 1/4] rcu: build on Windows

2020-10-20 Thread Dharmik Thakkar
Build the lib for Windows. Signed-off-by: Dharmik Thakkar Tested-by: Dmitry Kozlyuk --- lib/meson.build | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/meson.build b/lib/meson.build index dd55b5cb53e4..1bb019720c6a 100644 --- a/lib/meson.build +++ b/lib/meson.build @@ -41,6 +41,7 @@ if

Re: [dpdk-dev] [PATCH v3 0/7] BBDEV test updates

2020-10-20 Thread Chautru, Nicolas
Hi Akhil, Heads up on this one. Can you consider applying it for rc2 now? Thanks Nic > -Original Message- > From: Akhil Goyal > Sent: Tuesday, October 6, 2020 11:38 PM > To: Chautru, Nicolas ; dev@dpdk.org; > t...@redhat.com > Cc: Richardson, Bruce > Subject: RE: [PATCH v3 0/7] BBDEV te

Re: [dpdk-dev] [PATCH v7 0/3] pmdinfogen: rewrite in Python

2020-10-20 Thread David Marchand
Hello Dmitry, On Wed, Oct 14, 2020 at 8:31 PM Dmitry Kozlyuk wrote: > > This patchset implements existing pmdinfogen logic in Python, replaces > and removes the old code. The goals of rewriting are: > > * easier maintenance by using a more high-level language, > * simpler build process without ho

  1   2   3   4   >