[dpdk-dev] [PATCH][v2] net/af_xdp: avoid to unnecessary allocation and free mbuf in rx path

2020-09-24 Thread Li RongQing
when receive packets, the max bunch number of mbuf are allocated if hardware does not receive the max bunch number packets, it will free redundancy mbuf, that is low-performance so optimize rx performance, by allocating number of mbuf based on result of xsk_ring_cons__peek, to avoid to redundancy

Re: [dpdk-dev] [PATCH v5] net/iavf: support flex desc metadata extraction

2020-09-24 Thread Wang, Haiyue
> -Original Message- > From: Guo, Jia > Sent: Friday, September 25, 2020 14:23 > To: Wu, Jingjing ; Zhang, Qi Z ; > Xing, Beilei > > Cc: dev@dpdk.org; Wang, Haiyue ; Guo, Jia > > Subject: [PATCH v5] net/iavf: support flex desc metadata extraction > > Enable metadata extraction for fle

[dpdk-dev] [PATCH v5] net/iavf: support flex desc metadata extraction

2020-09-24 Thread Jeff Guo
Enable metadata extraction for flexible descriptors in AVF, that would allow network function directly get metadata without additional parsing which would reduce the CPU cost for VFs. The enabling metadata extractions involve the metadata of VLAN/IPv4/IPv6/IPv6-FLOW/TCP/MPLS flexible descriptors, a

Re: [dpdk-dev] [PATCH 1/2] eal/windows: add interrupt thread skeleton

2020-09-24 Thread Dmitry Kozlyuk
> Getting an "undefined reference to rte_intr_rx_ctl", guess we need to add a > stub for this. > Otherwise, compiles successfully with both clang and mingw. This is because a patch got merged that also eal_interrupts.c and this stub. I'll rebase and send v2.

Re: [dpdk-dev] [EXTERNAL] [PATCH 2/2] eal/windows: implement alarm API

2020-09-24 Thread Khoa To
> -Original Message- > From: Dmitry Kozlyuk > Sent: Thursday, September 24, 2020 2:39 PM > To: Khoa To > Cc: dev@dpdk.org; Narcisa Ana Maria Vasile > ; Dmitry Malloy (MESHCHANINOV) > ; Pallavi Kadam > Subject: Re: [EXTERNAL] [dpdk-dev] [PATCH 2/2] eal/windows: implement > alarm API >

Re: [dpdk-dev] [PATCH RFC] raw: add dpaa qdma driver

2020-09-24 Thread Hemant Agrawal
Hi Gagan, On 9/7/2020 3:20 PM, Gagandeep Singh wrote: This patch adds support for dpaa qdma based driver. Can you provide more details and break it into logical parts? Signed-off-by: Gagandeep Singh Signed-off-by: Peng Ma --- doc/guides/rawdevs/dpaa_qdma.rst | 98 ++

Re: [dpdk-dev] [PATCH 5/8] net/bnxt: add a null ptr check in bnxt PCI probe

2020-09-24 Thread Somnath Kotur
On Thu, Sep 24, 2020 at 8:17 PM Ferruh Yigit wrote: > > On 9/22/2020 8:06 AM, Somnath Kotur wrote: > > Check for devargs before invoking rep port probe. > > > > Fixes: 6dc83230b43b ("net/bnxt: support port representor data path") > > > > Signed-off-by: Somnath Kotur > > Reviewed-by: Venkat Duvvur

[dpdk-dev] [PATCH v2 2/2] net/iavf: enable large VF configuration

2020-09-24 Thread Ting Xu
Add support to negotiate large VF capability, configure VSI queues, enable/disable queues and IRQ mapping for large VF. Use new virtchnl opcodes and structures to support max 256 queue pairs. Request additional queues from PF first if current allocated queues are not enough. Query max RSS queue reg

[dpdk-dev] [PATCH v2 0/2] enable large VF configuration

2020-09-24 Thread Ting Xu
This patchset supports to configure up to 256 queue pairs per VF. If large VF is supported after capability negotiation, VF will request queues from PF as needed. New virtual channel opcodes and structures are used to indicate 256 queues, so VF is designed to handle the new function of configure VS

[dpdk-dev] [PATCH v2 1/2] net/iavf: add IAVF request queues function

2020-09-24 Thread Ting Xu
Add new virtchnl function to request additional queues from PF. Current default queue pairs number when creating a VF is 16. In order to support up to 256 queue pairs, enable this request queues function. Since request queues command may return event message, modify function iavf_read_msg_from_pf t

[dpdk-dev] [PATCH v2 1/3] net: fix variable size of ethdev port id

2020-09-24 Thread Chenbo Xia
The ethdev port id should be 16 bits now. This patch changes the variable size of port id in some net drivers from 8 bits to 16 bits. Fixes: cf18d4def295 ("net/ark: provide API for hardware modules UDM and DDM") Fixes: 09b23f8b9df6 ("net/bnxt: fix port stop process and cleanup resources") Fixes: 7

[dpdk-dev] [PATCH v2 3/3] doc: fix variable size of ethdev port id

2020-09-24 Thread Chenbo Xia
The ethdev port id should be 16 bits now. This patch changes the variable size of port id in docs from 8 bits to 16 bits. Fixes: fdec9301f52d ("doc: add flow classify guides") Fixes: 4a3ef59a10c8 ("examples/flow_filtering: add simple demo of flow API") Cc: sta...@dpdk.org Signed-off-by: Chenbo Xi

[dpdk-dev] [PATCH v2 2/3] app: fix variable size of ethdev port id

2020-09-24 Thread Chenbo Xia
The ethdev port id should be 16 bits now. This patch changes the variable size of port id in applications from 8 bits to 16 bits. Fixes: e977e4199a8d ("app/testpmd: add commands to load/unload BPF filters") Fixes: 46cf97e4bbfa ("eventdev: add test for eth Tx adapter") Cc: sta...@dpdk.org Signed-o

[dpdk-dev] [PATCH] stack: fix possible uninitialized success variable

2020-09-24 Thread wangyunjian
From: Yunjian Wang This patch fixes an issue that uninitialized 'success' is used to be compared with '0'. Coverity issue: 337676 Fixes: 3340202f5954 ("stack: add lock-free implementation") Cc: sta...@dpdk.org Signed-off-by: Yunjian Wang --- lib/librte_stack/rte_stack_lf_generic.h | 2 +- 1 f

Re: [dpdk-dev] [PATCH 16/20] ethdev: remove old close behaviour

2020-09-24 Thread Rasesh Mody
Hi Thomas, Ferruh, >From: dev On Behalf Of Ferruh Yigit >Sent: Wednesday, September 23, 2020 9:45 AM > >On 9/13/2020 11:07 PM, Thomas Monjalon wrote: >> The temporary flag RTE_ETH_DEV_CLOSE_REMOVE is removed. >> It was introduced in DPDK 18.11 in order to give time for PMDs to migrate. >> >> The

Re: [dpdk-dev] [EXT] [PATCH 1/4] net/qede: fix build with gcc 11

2020-09-24 Thread Rasesh Mody
Hi Ferruh, >From: Ferruh Yigit >Sent: Monday, September 21, 2020 6:38 AM > >Error observed with gcc 11 under development gcc (GCC) 11.0.0 20200920 >(experimental) > >build error: >../drivers/net/qede/qede_main.c: In function ‘qed_get_current_link’: >../drivers/net/qede/qede_main.c:587:17: >

Re: [dpdk-dev] CALL to eth PMD maintainers: complete closing of port

2020-09-24 Thread Rasesh Mody
Hi Thomas, >From: dev On Behalf Of Thomas Monjalon >Sent: Sunday, September 13, 2020 3:16 PM > >The patches for removing RTE_ETH_DEV_CLOSE_REMOVE are sent: > https://urldefense.proofpoint.com/v2/url?u=https- >3A__patches.dpdk.org_project_dpdk_list_-3Fseries- >3D12173&d=DwICAg&c=nKjWec2b6R0m

[dpdk-dev] [PATCH] net/qede: enhance old ethdev close behavior

2020-09-24 Thread Rasesh Mody
Set RTE_ETH_DEV_CLOSE_REMOVE upon probe so all the private resources for the port can be freed by rte_eth_dev_close(). With this change the private port resources are released in the .dev_close callback. Signed-off-by: Rasesh Mody --- drivers/net/qede/qede_ethdev.c | 13 + 1 file cha

[dpdk-dev] [PATCH] net/bnx2x: enhance old ethdev close behavior

2020-09-24 Thread Rasesh Mody
Set RTE_ETH_DEV_CLOSE_REMOVE upon probe so all the private resources for the port can be freed by rte_eth_dev_close(). With this change the private port resources are released in the .dev_close callback. Signed-off-by: Rasesh Mody --- drivers/net/bnx2x/bnx2x_ethdev.c | 20 ++-- 1

[dpdk-dev] [PATCH] net/bnxt: add support for 200G PAM4 link

2020-09-24 Thread Ajit Khaparde
Thor based NICs can support PAM4 as wells as NRZ link negotiation. With this patch we are adding support for 200G link speeds based on PAM4 signaling. While PAM4 can negotiate speeds for 50G and 100G as well, the PMD will use NRZ signalling for these speeds. Signed-off-by: Ajit Khaparde Reviewed-

[dpdk-dev] [PATCH v2 2/2] net/mlx5: add non temporal store for WQE fields

2020-09-24 Thread Aman Kumar
add non temporal store for few WQE fields to optimize data path. Define RTE_LIBRTE_MLX5_NT_STORE in build configurations to enable this optimization. Signed-off-by: Aman Kumar --- drivers/net/mlx5/meson.build | 1 + drivers/net/mlx5/mlx5.c | 17 + drivers/net/mlx5/m

[dpdk-dev] [PATCH v2 1/2] net/mlx5: optimize mprq memcpy

2020-09-24 Thread Aman Kumar
add non temporal load and temporal store for mprq memcpy. define RTE_LIBRTE_MLX5_NTLOAD_TSTORE_ALIGN_COPY in build configuration to enable this optimization. Signed-off-by: Aman Kumar --- drivers/net/mlx5/meson.build | 1 + drivers/net/mlx5/mlx5.c | 12 drivers/net/mlx5/mlx5.h

[dpdk-dev] [PATCH] bus/pci: fix mapping BAR containing MSI-X table

2020-09-24 Thread Hyong Youb Kim
When the BAR contains MSI-X table, pci_vfio_mmap_bar() tries to skip the table and map the rest. "map around it" is the phrase used in the source. The function splits the BAR into two regions: the region before the table (first part or memreg[0]) and the region after the table (second part or memre

[dpdk-dev] [PATCH v5] bus/pci: netuio interface for windows

2020-09-24 Thread Pallavi Kadam
This patch adds implementations to probe PCI devices bound to netuio with the help of "netuio" class device changes. Now Windows will support both "netuio" and "net" device class and can set kernel driver type based on the device class selection. Note: Few definitions and structures have been copi

Re: [dpdk-dev] [PATCH 1/2] eal/windows: add interrupt thread skeleton

2020-09-24 Thread Narcisa Ana Maria Vasile
On Fri, Sep 11, 2020 at 03:22:06AM +0300, Dmitry Kozlyuk wrote: > Windows interrupt support is based on IO completion ports (IOCP). > Interrupt thread would send the devices requests to notify about > interrupts and then wait for any request completion. Add skeleton code > of this model without any

Re: [dpdk-dev] [PATCH v2 1/6] ethdev: add flow shared action API

2020-09-24 Thread Ajit Khaparde
On Thu, Sep 17, 2020 at 9:03 AM Ori Kam wrote: > > > > > -Original Message- > > From: Andrew Rybchenko > > Sent: Thursday, September 17, 2020 6:34 PM > > > > Subject: Re: [dpdk-dev] [PATCH v2 1/6] ethdev: add flow shared action API > > > > On 9/16/20 10:20 PM, Ajit Khaparde wrote: > > >

Re: [dpdk-dev] [PATCH v3 2/4] bbdev: use C11 atomic builtins for device processing counter

2020-09-24 Thread Chautru, Nicolas
Thanks Honnappa, Acked-By: Nicolas Chautru > -Original Message- > From: Honnappa Nagarahalli > Sent: Thursday, September 24, 2020 3:45 PM > To: Chautru, Nicolas ; Phil Yang > ; dev@dpdk.org; david.march...@redhat.com; Hunt, > David > Cc: Ruifeng Wang ; nd ; > Honnappa Nagarahalli ; nd

[dpdk-dev] [PATCH] eal/windows: use bundled getopt with MinGW

2020-09-24 Thread Dmitry Kozlyuk
Clang builds use getopt.c in librte_eal while MinGW provides implementation as part of the toolchain. Statically linking librte_eal to an application that depends on getopt results in undefined reference errors with MinGW. There are no such errors with Clang, because with Clang librte_eal actually

Re: [dpdk-dev] [PATCH] eal/windows: fix incorrect free condition in getopt implementation

2020-09-24 Thread Dmitry Kozlyuk
On Wed, 23 Sep 2020 17:15:38 +0300, Tal Shnaiderman wrote: > In the Windows getopt_internal function the condition freeing > the memory allocated by _dupenv_s is correct only for the first > call to the function. Hi Tal, a few days back Khoa To and me privately discussed a patch that makes MinGW

Re: [dpdk-dev] [PATCH v3 2/4] bbdev: use C11 atomic builtins for device processing counter

2020-09-24 Thread Honnappa Nagarahalli
> > Hi Phil, > Naïve question but the deprecation document was stating that "DPDK will > adopt C11 atomic operations semantics and provide wrappers using C11 > atomic built-ins." At the time of writing the deprecation notice, that was the thinking. However, through further discussions [1] in th

Re: [dpdk-dev] [RFC PATCH 1/2] build: rework Arm build options

2020-09-24 Thread Ali Saidi
> > > > > > > > The current system can identify only the implementer and part number > > > > of the arm device we're targeting, which is enough to identify the > > > > target > > CPU. > > > > However, even the full MIDR information is not enough to identify > > > > the SoC we're targeting. > > >

Re: [dpdk-dev] [PATCH v3 2/4] bbdev: use C11 atomic builtins for device processing counter

2020-09-24 Thread Chautru, Nicolas
Hi Phil, Naïve question but the deprecation document was stating that "DPDK will adopt C11 atomic operations semantics and provide wrappers using C11 atomic built-ins." Here you are using directly the C11 atomic built-ins and not providing and using a DPDK wrapper. Wasn't the intent to have a

Re: [dpdk-dev] [PATCH 10/20] net/null: release port upon close

2020-09-24 Thread Thomas Monjalon
23/09/2020 22:47, Thomas Monjalon: > 23/09/2020 18:44, Ferruh Yigit: > > On 9/13/2020 11:07 PM, Thomas Monjalon wrote: > > > The flag RTE_ETH_DEV_CLOSE_REMOVE is set so all port resources > > > can be freed by rte_eth_dev_close(). > > > > > > Signed-off-by: Thomas Monjalon > > > --- > > > --- a/d

Re: [dpdk-dev] [EXTERNAL] [PATCH 2/2] eal/windows: implement alarm API

2020-09-24 Thread Dmitry Kozlyuk
Hi Khoa, Disclaimer: my experience with interrupts and alarms is limited. > Since all alarm callbacks are scheduled on the interrupt thread, looks like > this implementation of rte_eal_alarm_set() would create a head-of-line > blocking issue, as the callbacks are serialized one after the other.

Re: [dpdk-dev] [PATCH] mempool/ring: build on Windows

2020-09-24 Thread Ranjit Menon
On 9/16/2020 3:42 AM, Tal Shnaiderman wrote: Build the ring mempool handler for Windows OS. Signed-off-by: Tal Shnaiderman --- drivers/mempool/bucket/meson.build| 5 + drivers/mempool/meson.build | 4 drivers/mempool/octeontx/meson.build | 5 + drivers/mempool/o

[dpdk-dev] [PATCH] build: support i686 target on x86 64-bit hosts

2020-09-24 Thread Lance Richardson
Add meson cross files for building i686 targets using gcc on x86_64 linux hosts. Uusage example: meson --cross-file config/x86/cross-i686-linux-gcc build-i686 ninja -C build-i686 Signed-off-by: Lance Richardson --- Red Hat distros use a different name for the 32-bit pkg-config command f

Re: [dpdk-dev] [RFC PATCH 1/2] build: rework Arm build options

2020-09-24 Thread Honnappa Nagarahalli
> > > > > > > > The current system can identify only the implementer and part number > > > of the arm device we're targeting, which is enough to identify the target > CPU. > > > However, even the full MIDR information is not enough to identify > > > the SoC we're targeting. > > > > > > Expand the

Re: [dpdk-dev] [PATCH v1] event/sw: performance improvements

2020-09-24 Thread Ananyev, Konstantin
Add minimum burst throughout the scheduler pipeline and a flush counter. Replace ring API calls with local single threaded implementation where possible. Signed-off-by: Radu Nicolau mailto:radu.nico...@intel.com Thanks for the patch, a few comments inline. --- drivers/event/sw/sw_evdev.h  

Re: [dpdk-dev] [PATCH] pci: support both PIO and MMIO BAR for legacy virtio on x86

2020-09-24 Thread Ferruh Yigit
On 9/15/2020 4:21 PM, 谢华伟(此时此刻) wrote: Hi Ferruh: Legacy virtio only supports PIO BAR resource. As we need to create lots of virtio devices and PIO resource on x86 is very limited, we expose MMIO BAR. Kernel support both PIO and MMIO BAR for legacy virtio device. This patch deals with two case

[dpdk-dev] [PATCH v2] doc/devbind: remove references to igb_uio

2020-09-24 Thread Stephen Hemminger
We should be encouraging the use of vfio_pci for developers, not telling them to use igb_uio. Signed-off-by: Stephen Hemminger --- v2 -- drop change about filename doc/guides/tools/devbind.rst | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/doc/guides/tool

Re: [dpdk-dev] [PATCH v1] event/sw: performance improvements

2020-09-24 Thread Honnappa Nagarahalli
Add minimum burst throughout the scheduler pipeline and a flush counter. Replace ring API calls with local single threaded implementation where possible. Signed-off-by: Radu Nicolau Thanks for the patch, a few comments inline. --- drivers/event/sw/s

Re: [dpdk-dev] [v2 1/2] cryptodev: support enqueue callback functions

2020-09-24 Thread Ananyev, Konstantin
> > > > > > > > > > > > > > > > > > > +#ifdef RTE_CRYPTODEV_CALLBACKS int > > > > > > > > > +rte_cryptodev_rcu_qsbr_add(uint8_t dev_id, struct > > > > > > > > > +rte_rcu_qsbr > > > > > > > > > +*qsbr) { > > > > > > > > > + > > > > > > > > > + struct rte_cryptodev *dev; > > > > > > > > > + >

[dpdk-dev] [PATCH] EEPROM Dump Feature

2020-09-24 Thread David Liu
add test case and test plan for eeprom dump compare output result from ethtool and testpmd Signed-off-by: David Liu --- test_plans/eeprom_dump_test_plan.rst | 92 ++ tests/TestSuite_eeprom_dump.py | 139 +++ 2 files changed, 231 insertions(+) creat

[dpdk-dev] [dpdk-dev v10 3/4] crypto/qat: add raw crypto data-path API support

2020-09-24 Thread Fan Zhang
This patch updates QAT PMD to add raw data-path API support. Signed-off-by: Fan Zhang --- drivers/crypto/qat/meson.build | 1 + drivers/crypto/qat/qat_sym.h | 11 + drivers/crypto/qat/qat_sym_hw_dp.c | 951 + drivers/crypto/qat/qat_sym_pmd.c | 9 +- 4

[dpdk-dev] [dpdk-dev v10 2/4] cryptodev: add raw crypto data-path APIs

2020-09-24 Thread Fan Zhang
This patch adds raw data-path APIs for enqueue and dequeue operations to cryptodev. The APIs support flexible user-define enqueue and dequeue behaviors. Signed-off-by: Fan Zhang Signed-off-by: Piotr Bronowski --- doc/guides/prog_guide/cryptodev_lib.rst | 93 + doc/guides/rel_notes/re

[dpdk-dev] [dpdk-dev v10 4/4] test/crypto: add unit-test for cryptodev raw API test

2020-09-24 Thread Fan Zhang
This patch adds the cryptodev raw API test support to unit test. In addtion a new test-case for QAT PMD for the test type is enabled. Signed-off-by: Fan Zhang --- app/test/test_cryptodev.c | 759 -- app/test/test_cryptodev.h | 12 + app/test/test_

[dpdk-dev] [dpdk-dev v10 0/4] cryptodev: add raw data-path APIs

2020-09-24 Thread Fan Zhang
The Crypto Raw data-path APIs are a set of APIs are designed to enable externel libraries/applications which want to leverage the cryptographic processing provided by DPDK crypto PMDs through the cryptodev API but in a manner that is not dependent on native DPDK data structures (eg. rte_mbuf, rte_c

[dpdk-dev] [dpdk-dev v10 1/4] cryptodev: change crypto symmetric vector structure

2020-09-24 Thread Fan Zhang
This patch updates ``rte_crypto_sym_vec`` structure to add support for both cpu_crypto synchrounous operation and asynchronous raw data-path APIs. The patch also includes AESNI-MB and AESNI-GCM PMD changes, unit test changes and documentation updates. Signed-off-by: Fan Zhang --- app/test/test_c

Re: [dpdk-dev] [PATCH] security: update session create API

2020-09-24 Thread Coyle, David
Hi Akhil > -Original Message- > From: akhil.go...@nxp.com > Sent: Thursday, September 3, 2020 9:10 PM > diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c index > 70bf6fe2c..6d7da1408 100644 > --- a/app/test/test_cryptodev.c > +++ b/app/test/test_cryptodev.c > @@ -7219,

Re: [dpdk-dev] Meson Minimum Version

2020-09-24 Thread Bruce Richardson
On Thu, Sep 24, 2020 at 03:32:41PM +, John Alexander wrote: >Hi, >Regarding the subproject local patch support, yes, it's only supported >since Meson 0.55: >https://mesonbuild.com/Wrap-dependency-system-manual.html We pip >installed 0.55 Meson. >I have a number of subseq

Re: [dpdk-dev] [RFC PATCH] app/testpmd: tx pkt clones parameter in flowgen

2020-09-24 Thread Stephen Hemminger
On Thu, 24 Sep 2020 14:34:14 +0300 Igor Russkikh wrote: > When testing high performance numbers, it is often that CPU performance > limits the max values device can reach (both in pps and in gbps) > > Here instead of recreating each packet separately, we use clones counter > to resend the same m

Re: [dpdk-dev] Meson Minimum Version

2020-09-24 Thread John Alexander
Hi, Regarding the subproject local patch support, yes, it's only supported since Meson 0.55: https://mesonbuild.com/Wrap-dependency-system-manual.html We pip installed 0.55 Meson. I have a number of subsequent patches that depend on this particular pthreads library to advance the Windows DPDK

Re: [dpdk-dev] [PATCH v3 1/1] net/af_xdp: shared UMEM support

2020-09-24 Thread Ferruh Yigit
On 9/23/2020 8:34 AM, Ciara Loftus wrote: Kernel v5.10 will introduce the ability to efficiently share a UMEM between AF_XDP sockets bound to different queue ids on the same or different devices. This patch integrates that functionality into the AF_XDP PMD. A PMD will attempt to share a UMEM wit

Re: [dpdk-dev] [PATCH v1] event/sw: performance improvements

2020-09-24 Thread Nicolau, Radu
On 9/24/2020 12:10 AM, Honnappa Nagarahalli wrote: Add minimum burst throughout the scheduler pipeline and a flush counter. Replace ring API calls with local single threaded implementation where possible. Signed-off-by: Radu Nicolau Thanks for the pa

Re: [dpdk-dev] [PATCH] [PATCH V2] testpmd: add eeprom/module eeprom display

2020-09-24 Thread Ferruh Yigit
On 9/24/2020 11:57 AM, Phil Yang wrote: dev On Behalf Of Phil Yang : writes: Subject: [dpdk-dev] [PATCH] [PATCH V2] testpmd: add eeprom/module eeprom display Add module EEPROM/EEPROM dump command "show port (module_eeprom|eeprom)" Commands will dump the content of the EEPROM/module EEP

[dpdk-dev] [PATCH v2 2/2] ethdev: move RSS expand code from ethdev to MLX5 PMD

2020-09-24 Thread Dekel Peled
Patch [1] added support for RSS flow expansion. It was added in ethdev for public use, but until now it is used only by MLX5 PMD. To allow local changes in this code, this patch removes it from ethdev and moves it to MLX5 PMD file. [1] commit 4ed05fcd441b ("ethdev: add flow API to expand RSS flows

[dpdk-dev] [PATCH v2 0/2] ethdev: RSS expand code fix and relocate

2020-09-24 Thread Dekel Peled
Patch [1] added support for RSS flow expansion. It was added in ethdev for public use, but until now it is used only by MLX5 PMD. This patch series fixes an issue in this code, removes it from ethdev and moves it to MLX5 PMD file (following maintainer comments on v1). [1] commit 4ed05fcd441b ("eth

[dpdk-dev] [PATCH v2 1/2] ethdev: fix RSS flow expansion in case of mismatch

2020-09-24 Thread Dekel Peled
Function rte_flow_expand_rss() is used to expand a flow rule with partial pattern into several rules, to ensure all relevant packets are matched. It uses utility function rte_flow_expand_rss_item_complete(), to check if the last valid item in the flow rule pattern needs to be completed. For example

Re: [dpdk-dev] [PATCH 02/20] ethdev: allow drivers to return error on close

2020-09-24 Thread Stephen Hemminger
On Thu, 24 Sep 2020 10:12:46 +0100 Bruce Richardson wrote: > On Thu, Sep 24, 2020 at 12:35:58AM +0200, Thomas Monjalon wrote: > > 24/09/2020 00:02, Stephen Hemminger: > > > On Wed, 23 Sep 2020 23:52:07 +0200 > > > Thomas Monjalon wrote: > > > > > > > > > > > Yes it is a step in the right di

Re: [dpdk-dev] [PATCH 5/8] net/bnxt: add a null ptr check in bnxt PCI probe

2020-09-24 Thread Ferruh Yigit
On 9/22/2020 8:06 AM, Somnath Kotur wrote: Check for devargs before invoking rep port probe. Fixes: 6dc83230b43b ("net/bnxt: support port representor data path") Signed-off-by: Somnath Kotur Reviewed-by: Venkat Duvvuru --- drivers/net/bnxt/bnxt_ethdev.c | 4 1 file changed, 4 insertio

Re: [dpdk-dev] [PATCH V12 1/4] ethdev: introduce FEC API

2020-09-24 Thread Andrew Rybchenko
On 9/24/20 4:05 PM, Min Hu (Connor) wrote: > This patch adds Forward error correction(FEC) support for ethdev. > Introduce APIs which support query and config FEC information in > hardware. Almost good now. See my notes below. Many thanks for hard work and patience. > > Signed-off-by: Min Hu (Co

Re: [dpdk-dev] Questions on DPDK pkg-config

2020-09-24 Thread Bruce Richardson
On Thu, Sep 24, 2020 at 03:34:12PM +0100, Harris, James R wrote: > > > On 9/24/20, 2:27 AM, "Bruce Richardson" wrote: > > On Wed, Sep 23, 2020 at 07:21:16PM +0100, Harris, James R wrote: > >Hi, > > > > > >SPDK would like to use DPDK’s pkg-config files rather than ro

Re: [dpdk-dev] Meson Minimum Version

2020-09-24 Thread Bruce Richardson
On Thu, Sep 24, 2020 at 02:22:03PM +, John Alexander wrote: > Hi, > > I've submitted a patch that uses new features of Meson, specifically the > directory patch aspect of the subproject feature. This requires a minimum > Meson version of 0.55.0. How do we go about getting the community to

Re: [dpdk-dev] Questions on DPDK pkg-config

2020-09-24 Thread Harris, James R
On 9/24/20, 2:27 AM, "Bruce Richardson" wrote: On Wed, Sep 23, 2020 at 07:21:16PM +0100, Harris, James R wrote: >Hi, > > >SPDK would like to use DPDK’s pkg-config files rather than rolling our >own linker arguments. I’m running into a couple of issues – o

[dpdk-dev] Meson Minimum Version

2020-09-24 Thread John Alexander
Hi, I've submitted a patch that uses new features of Meson, specifically the directory patch aspect of the subproject feature. This requires a minimum Meson version of 0.55.0. How do we go about getting the community to accept a more recent version of Meson and getting the Travis server upgra

Re: [dpdk-dev] [PATCH V12 4/4] doc: add FEC API and PMD information

2020-09-24 Thread Andrew Rybchenko
On 9/24/20 4:05 PM, Min Hu (Connor) wrote: > Added the FEC API, and hns3 FEC PMD information in > release 20.11.rst file. > > Signed-off-by: Min Hu (Connor) > Reviewed-by: Wei Hu (Xavier) > Reviewed-by: Chengwen Feng > Reviewed-by: Chengchang Tang > --- > doc/guides/rel_notes/release_20_11.rs

[dpdk-dev] [PATCH v4] app/testpmd: fix the default RSS key configuration

2020-09-24 Thread Lijun Ou
It use the NIC valid default RSS key instead of the testpmd dummy RSS key in the flow configuration when the RSS key is not specified in the flow rule. If the NIC RSS key is invalid, it will use testpmd dummy RSS key as the default key. Fixes: ac8d22de2394 ("ethdev: flatten RSS configuration in fl

[dpdk-dev] [PATCH v4] RSS key use with testpmd

2020-09-24 Thread Lijun Ou
Consider the follow usage with testpmd: 1. first, startup testpmd: testpmd> show port 0 rss-hash key RSS functions: all ipv4-frag ipv4-other ipv6-frag ipv6-other ip RSS key: 6D5A56DA255B0EC24167253D43A38FB0D0CA2BCBAE7B30B477CB2DA38030F 20C6A42B73BBEAC01FA 2. create a rss rule testpmd> flow create

[dpdk-dev] [PATCH] maintainers: update email address

2020-09-24 Thread Andrew Rybchenko
Signed-off-by: Andrew Rybchenko --- MAINTAINERS | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 858463aa2a..ff0731cda2 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -29,7 +29,7 @@ T: git://dpdk.org/dpdk Next-net Tree M: Ferruh Yig

Re: [dpdk-dev] [PATCH v5 16/20] doc: remove references to make from app guides

2020-09-24 Thread David Hunt
Hi Ciara, On 21/9/2020 2:59 PM, Ciara Power wrote: Make is no longer supported for compiling DPDK, references are now removed in the documentation. Signed-off-by: Ciara Power Acked-by: Nicolas Chautru --- --snip-- When checking the vm_power_manager portion of this guide, I came across a

[dpdk-dev] [PATCH V12 2/4] net/hns3: support FEC

2020-09-24 Thread Min Hu (Connor)
Forward error correction (FEC) is a bit error correction mode. It adds error correction information to data packets at the transmit end, and uses the error correction information to correct the bit errors generated during data packet transmission at the receive end. This improves signal quality but

[dpdk-dev] [PATCH V12 4/4] doc: add FEC API and PMD information

2020-09-24 Thread Min Hu (Connor)
Added the FEC API, and hns3 FEC PMD information in release 20.11.rst file. Signed-off-by: Min Hu (Connor) Reviewed-by: Wei Hu (Xavier) Reviewed-by: Chengwen Feng Reviewed-by: Chengchang Tang --- doc/guides/rel_notes/release_20_11.rst | 9 + 1 file changed, 9 insertions(+) diff --git

[dpdk-dev] [PATCH V12 0/4] add FEC support

2020-09-24 Thread Min Hu (Connor)
This series add FEC support for ethdev. Min Hu (Connor) (4): ethdev: introduce FEC API net/hns3: support FEC app/testpmd: add FEC command doc: add FEC API and PMD information app/test-pmd/cmdline.c | 221 +++ app/test-pmd/config.c| 9

[dpdk-dev] [PATCH V12 1/4] ethdev: introduce FEC API

2020-09-24 Thread Min Hu (Connor)
This patch adds Forward error correction(FEC) support for ethdev. Introduce APIs which support query and config FEC information in hardware. Signed-off-by: Min Hu (Connor) Reviewed-by: Wei Hu (Xavier) Reviewed-by: Chengwen Feng Reviewed-by: Chengchang Tang Reviewed-by: Ajit Khaparde Acked-by:

[dpdk-dev] [PATCH V12 3/4] app/testpmd: add FEC command

2020-09-24 Thread Min Hu (Connor)
This commit adds testpmd capability to query and config FEC function of device. This includes: - show FEC capabilities, example: testpmd> show port 0 fec capabilities - show FEC mode, example: testpmd> show port 0 fec_mode - config FEC mode, example: testpmd> set port 0

Re: [dpdk-dev] [PATCH 19/20] app/testpmd: reset port status on close notification

2020-09-24 Thread Ferruh Yigit
On 9/24/2020 1:17 PM, Thomas Monjalon wrote: 24/09/2020 14:07, Ferruh Yigit: On 9/23/2020 9:32 PM, Thomas Monjalon wrote: 23/09/2020 18:45, Ferruh Yigit: On 9/13/2020 11:07 PM, Thomas Monjalon wrote: Since rte_eth_dev_release_port() is called on all port close operations, the event RTE_ETH_EV

[dpdk-dev] [PATCH v2 1/3] test/crypto: replace NITROX PMD specific test suite

2020-09-24 Thread Nagadheeraj Rottela
Replace NITROX PMD specific tests with generic test suite. Signed-off-by: Nagadheeraj Rottela --- app/test/test_cryptodev.c | 18 +- 1 file changed, 1 insertion(+), 17 deletions(-) diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c index 70bf6fe2c..162134a5c 1006

[dpdk-dev] [PATCH v2 3/3] crypto/nitrox: support cipher only crypto operations

2020-09-24 Thread Nagadheeraj Rottela
This patch adds cipher only crypto operation support. Signed-off-by: Nagadheeraj Rottela --- doc/guides/cryptodevs/nitrox.rst | 2 - doc/guides/rel_notes/release_20_11.rst| 5 + drivers/crypto/nitrox/nitrox_sym.c| 3 + drivers/crypto/nitrox/nitrox_sym_reqmgr.c | 191 ++

[dpdk-dev] [PATCH v2 2/3] crypto/nitrox: support AES-GCM

2020-09-24 Thread Nagadheeraj Rottela
This patch adds AES-GCM AEAD algorithm. Signed-off-by: Nagadheeraj Rottela --- doc/guides/cryptodevs/features/nitrox.ini | 3 + doc/guides/cryptodevs/nitrox.rst | 4 + drivers/crypto/nitrox/nitrox_sym.c| 82 +++- .../crypto/nitrox/nitrox_sym_capabilities.c

[dpdk-dev] [PATCH v2 0/3] Add AES-GCM and cipher only offload support

2020-09-24 Thread Nagadheeraj Rottela
This patch set replaces the NITROX PMD specific test suite with generic test suite and adds support for AES-GCM and cipher only offload. --- v2: * Rebased patches to latest master and resolved merge conflict. * Updated release notes. Nagadheeraj Rottela (3): test/crypto: replace NITROX PMD speci

[dpdk-dev] [PATCH] net/sfc: create virtual switch to enable VFs

2020-09-24 Thread Andrew Rybchenko
PF driver is responsible for vSwitch creation and vPorts allocation for VFs. Signed-off-by: Andrew Rybchenko Reviewed-by: Andy Moreton --- doc/guides/nics/sfc_efx.rst | 2 + doc/guides/rel_notes/release_20_11.rst| 6 + drivers/common/sfc_efx/efsys.h

[dpdk-dev] [PATCH 2/2] net/sfc: fix RSS hash offload if QUEUE action is used

2020-09-24 Thread Andrew Rybchenko
From: Igor Romanov When RSS hash offload is requested, the ingress filters that forward packets to an RX queue must have an RSS context assigned to them to calculate RSS hash, which was not always provided. Fix it by creating a dummy RSS context that forwards packets to the same queue and assign

[dpdk-dev] [PATCH 1/2] net/sfc: fix RSS hash flag when offload is disabled

2020-09-24 Thread Andrew Rybchenko
From: Igor Romanov Do not set RSS hash flag in the received mbufs when RSS hash offload is not enabled, which means that RSS hash value is invalid. Fixes: 5d308972954c ("ethdev: add mbuf RSS update as an offload") Cc: sta...@dpdk.org Signed-off-by: Igor Romanov Signed-off-by: Andrew Rybchenko

Re: [dpdk-dev] [PATCH v3 3/6] app/testpmd: remove restriction on txpkts set

2020-09-24 Thread Ferruh Yigit
On 9/24/2020 7:08 AM, Chengchang Tang wrote: On 2020/9/24 0:59, Ferruh Yigit wrote: On 9/23/2020 12:57 PM, Wei Hu (Xavier) wrote: Hi, Ferruh Yigit On 2020/9/23 11:14, Wei Hu (Xavier) wrote: Hi, Ferruh Yigit On 2020/9/22 22:51, Ferruh Yigit wrote: On 9/19/2020 11:47 AM, Wei Hu (Xavier) wro

Re: [dpdk-dev] [PATCH 19/20] app/testpmd: reset port status on close notification

2020-09-24 Thread Thomas Monjalon
24/09/2020 14:07, Ferruh Yigit: > On 9/23/2020 9:32 PM, Thomas Monjalon wrote: > > 23/09/2020 18:45, Ferruh Yigit: > >> On 9/13/2020 11:07 PM, Thomas Monjalon wrote: > >>> Since rte_eth_dev_release_port() is called on all port close operations, > >>> the event RTE_ETH_EVENT_DESTROY can be reliably

[dpdk-dev] [PATCH v3 56/60] common/sfc_efx/base: support creation of extended width EvQ

2020-09-24 Thread Andrew Rybchenko
From: Andy Moreton Add a flag to request an extended width event queue, and check that the supplied buffer is large enough to hold the event queue descriptors. Signed-off-by: Andy Moreton Signed-off-by: Andrew Rybchenko --- drivers/common/sfc_efx/base/ef10_ev.c| 2 + drivers/common/sfc_e

[dpdk-dev] [PATCH v3 29/60] common/sfc_efx/base: maintain RxQ counter in generic code

2020-09-24 Thread Andrew Rybchenko
The counter is incremented in generic efx_rx_qcreate(), but was asserted and decremented in NIC family specific queue create and destroy callbacks. Move assert and decrement to generic functions as well to make NIC family specific callbacks shorter. Signed-off-by: Andrew Rybchenko Reviewed-by: A

[dpdk-dev] [PATCH v3 59/60] common/sfc_efx/base: add option for descriptor proxy queues

2020-09-24 Thread Andrew Rybchenko
From: Andy Moreton EF100 uses descriptor proxy queues to support virtio-blk proxy. Signed-off-by: Andy Moreton Signed-off-by: Andrew Rybchenko --- drivers/common/sfc_efx/base/efx_check.h | 10 ++ drivers/common/sfc_efx/efsys.h | 2 ++ 2 files changed, 12 insertions(+) diff

[dpdk-dev] [PATCH v3 57/60] common/sfc_efx/base: poll extended width event queues

2020-09-24 Thread Andrew Rybchenko
From: Andy Moreton Extended width queues use a different layout and so require a different polling loop. Signed-off-by: Andy Moreton Signed-off-by: Andrew Rybchenko --- drivers/common/sfc_efx/base/rhead_ev.c | 155 - 1 file changed, 154 insertions(+), 1 deletion(-) di

[dpdk-dev] [PATCH v3 51/60] common/sfc_efx/base: replace PCI efsys macros with functions

2020-09-24 Thread Andrew Rybchenko
From: Igor Romanov efsys macros that manipulate PCI devices cannot be defined in common sfc_efx DPDK driver since in DPDK build the bus drivers that provide required functionality are built after common drivers. Replace the macros with function callbacks to remove that build dependency. Drivers

[dpdk-dev] [PATCH v3 54/60] common/sfc_efx/base: add option for extended width events

2020-09-24 Thread Andrew Rybchenko
From: Andy Moreton EF100 uses event queues with 256bit extended width events to support descriptor proxy queues. Signed-off-by: Andy Moreton Signed-off-by: Andrew Rybchenko --- drivers/common/sfc_efx/base/efx_check.h | 7 +++ drivers/common/sfc_efx/efsys.h | 1 + 2 files changed,

[dpdk-dev] [PATCH v3 60/60] common/sfc_efx/base: handle descriptor proxy queue events

2020-09-24 Thread Andrew Rybchenko
From: Andy Moreton The TXQ_DESC and VIRTQ_DESC events are used to pass host descriptors over an extended width event queue to an application processor for handling. See SF-122927-TC and SF-122966-SW for details. Signed-off-by: Andy Moreton Signed-off-by: Andrew Rybchenko --- drivers/common/sf

[dpdk-dev] [PATCH v3 30/60] common/sfc_efx/base: free Rx queue structure in generic code

2020-09-24 Thread Andrew Rybchenko
Rx queue structure is allocated in generic code, but was freed in NIC family specific callbacks. Move free to generic function makes NIC family specific callbacks shorter and reduces code duplication. Signed-off-by: Andrew Rybchenko Reviewed-by: Andy Moreton --- drivers/common/sfc_efx/base/ef10

[dpdk-dev] [PATCH v3 58/60] common/sfc_efx/base: handle normal events in extended width

2020-09-24 Thread Andrew Rybchenko
From: Andy Moreton Process the encasulated events as for the normal event loop. The phase bit in the encapsulated event should be ignored, as the polling loop uses the phase bit from the extended-width event. Signed-off-by: Andy Moreton Signed-off-by: Andrew Rybchenko --- drivers/common/sfc_e

[dpdk-dev] [PATCH v3 44/60] common/sfc_efx/base: add function control window lookup API

2020-09-24 Thread Andrew Rybchenko
From: Igor Romanov Riverhead NIC may provide a locator of function control window (EF100 resource locator). The locator may be present in a Xilinx capabilities table which itself is located by looking into extended PCI capabilities. PCI capabilities are made possible to access by adding PCI conf

[dpdk-dev] [PATCH v3 49/60] common/sfc_efx/base: introduce states for UDP tunnel entries

2020-09-24 Thread Andrew Rybchenko
From: Igor Romanov UDP tunnel reconfigure operation takes UDP tunnel table, which contains entries that need to be applied to HW. This approach does not retain information about what entries were removed or added, which is required for Riverhead. Add states to the table entries to indicate add o

[dpdk-dev] [PATCH v3 45/60] common/sfc_efx/base: add efsys API to find a memory BAR

2020-09-24 Thread Andrew Rybchenko
From: Igor Romanov Function control window lookup needs memory BARs handles to search Xilinx capabilities tables. Define an API to get a memory BAR handle by a PCIe device handle and BAR index. Signed-off-by: Igor Romanov Signed-off-by: Andrew Rybchenko Reviewed-by: Andy Moreton --- drivers

[dpdk-dev] [PATCH v3 55/60] common/sfc_efx/base: add 256bit type

2020-09-24 Thread Andrew Rybchenko
From: Andy Moreton EF100 requires support for extended-width event descriptors for use with descriptor proxy queues. Extend libefx types used for hardware access (and endian conversion) to support a 256bit data type. Signed-off-by: Andy Moreton Signed-off-by: Andrew Rybchenko --- drivers/comm

[dpdk-dev] [PATCH v3 52/60] common/sfc_efx/base: use EF10 EVB methods for Riverhead

2020-09-24 Thread Andrew Rybchenko
There is no difference yet in EVB support on EF10 and Riverhead. So, it is better to reuse existing methods. Signed-off-by: Andrew Rybchenko Reviewed-by: Andy Moreton --- drivers/common/sfc_efx/base/ef10_evb.c | 8 drivers/common/sfc_efx/base/efx_check.h | 4 ++-- drivers/common/sfc

[dpdk-dev] [PATCH v3 39/60] common/sfc_efx: do not include libefx headers from efsys.h

2020-09-24 Thread Andrew Rybchenko
efsys.h may depends on target system headers only. Otherwise, it could result in cross-dependency when libefx header depends on efsys.h and efsys.h depends on the libefx header. Signed-off-by: Andrew Rybchenko Reviewed-by: Andrew Lee Reviewed-by: Andy Moreton --- drivers/common/sfc_efx/efsys.h

  1   2   3   >